Commit-ID:  0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf
Gitweb:     http://git.kernel.org/tip/0dd945ff4647a1f29c6ae8f4f9a69c8f37c994cf
Author:     Thomas Gleixner <t...@linutronix.de>
AuthorDate: Tue, 20 Jun 2017 01:37:25 +0200
Committer:  Thomas Gleixner <t...@linutronix.de>
CommitDate: Thu, 22 Jun 2017 18:21:16 +0200

genirq/cpuhotplug: Remove irq disabling logic

This is called from stop_machine() with interrupts disabled. No point in
disabling them some more.

Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Cc: Jens Axboe <ax...@kernel.dk>
Cc: Marc Zyngier <marc.zyng...@arm.com>
Cc: Michael Ellerman <m...@ellerman.id.au>
Cc: Keith Busch <keith.bu...@intel.com>
Cc: Peter Zijlstra <pet...@infradead.org>
Cc: Christoph Hellwig <h...@lst.de>
Link: http://lkml.kernel.org/r/20170619235445.198042...@linutronix.de

---
 kernel/irq/cpuhotplug.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c
index 011f8c4..7051398 100644
--- a/kernel/irq/cpuhotplug.c
+++ b/kernel/irq/cpuhotplug.c
@@ -59,11 +59,8 @@ static bool migrate_one_irq(struct irq_desc *desc)
  */
 void irq_migrate_all_off_this_cpu(void)
 {
-       unsigned int irq;
        struct irq_desc *desc;
-       unsigned long flags;
-
-       local_irq_save(flags);
+       unsigned int irq;
 
        for_each_active_irq(irq) {
                bool affinity_broken;
@@ -73,10 +70,9 @@ void irq_migrate_all_off_this_cpu(void)
                affinity_broken = migrate_one_irq(desc);
                raw_spin_unlock(&desc->lock);
 
-               if (affinity_broken)
-                       pr_warn_ratelimited("IRQ%u no longer affine to CPU%u\n",
+               if (affinity_broken) {
+                       pr_warn_ratelimited("IRQ %u: no longer affine to 
CPU%u\n",
                                            irq, smp_processor_id());
+               }
        }
-
-       local_irq_restore(flags);
 }

Reply via email to