On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:
> +from __future__ import print_function
Again, you don't need this.
> - print "\nsyscall events for %s:\n\n" % (for_comm),
> + print("\nsyscall events for %s:\n\n" % (for_comm)),
same comments regarding trailing comma usage
$ git annotate tools/perf/scripts/python/sctop.py | grep thread
2e7d1e3fb8043 (Arnaldo Carvalho de Melo 2010-10-25 18:39:20 -0200
11)import os, sys, thread, time
47902f3611b39 (Tom Zanussi 2010-04-01 23:59:23 -0500 42)
thread.start_new_thread(print_syscall_totals, (interval,))
The low level threading api has changed in the most recent Python versions. I
think you'll find you also need:
@@ -8,7 +8,12 @@
# will be refreshed every [interval] seconds. The default interval is
# 3 seconds.
-import os, sys, thread, time
+import os, sys, time
+
+try:
+ import thread
+except ImportError:
+ import _thread as thread
Tony
