> -----Original Message-----
> From: Marc Zyngier <m...@kernel.org>
> Sent: 18 May 2020 13:45
> To: Anup Patel <anup.pa...@wdc.com>
> Cc: Palmer Dabbelt <pal...@dabbelt.com>; Paul Walmsley
> <paul.walms...@sifive.com>; Thomas Gleixner <t...@linutronix.de>; Jason
> Cooper <ja...@lakedaemon.net>; Atish Patra <atish.pa...@wdc.com>; Alistair
> Francis <alistair.fran...@wdc.com>; Anup Patel <a...@brainfault.org>; linux-
> ri...@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/4] irqchip/sifive-plic: Separate irq_chip for muiltiple
> PLIC
> instances
>
> On 2020-05-16 17:38, Anup Patel wrote:
> >> -----Original Message-----
> >> From: Marc Zyngier <m...@kernel.org>
>
> [...]
>
> >> I *have* given you a way to implement that in a better way. But
> >> again, I'd rather you *don't* do it for the reason I have outlined
> >> above.
> >
> > I explored kernel/irq/proc.c and we can achieve what this patch does
> > by implementing irq_print_chip() callback of "struct irq_chip" so we
> > certainly don't need separate "struct irq_chip" for each PLIC instance.
> >
> > I will implement irq_print_chip() callback in v2 series.
>
> You still haven't explained *why* you need to have this change.
> As it stands, I'm not prepared to take it.
>
This is only for differentiating interrupts of multiple PLIC instance
In /proc/interrupts.
I will drop this patch since (like you mentioned) contents of
/proc/interrupts is considered an ABI and this patch breaks it.
For now, we can infer the PLIC instance for interrupt X based
on contents of /proc/irq/X/node (i.e. interrupt NUMA node id).
Thanks,
Anup
