+       m.misc = (MCI_MISC_ADDR_PHYS << 6) | 
__ffs64(mem_err->physical_addr_mask);

Do we want to unconditionally trust the sanity of the BIOS provided 
physical_address_mask?

There's a warning comment on the kernel __ffs64() function:

 * The result is not defined if no bits are set, so check that @word
 * is non-zero before calling this.

Otherwise, this looks like a good idea.

-Tony

Reply via email to