On Tue, 30 Dec 2025 at 20:26, Thomas Weißschuh <[email protected]> wrote: > > Currently there is a lack of tests validating the result reporting from > nested tests. Add one, it will also be used to validate upcoming changes > to the nested test parsing. > > Signed-off-by: Thomas Weißschuh <[email protected]> > Reviewed-by: David Gow <[email protected]> > Reviewed-by: Rae Moar <[email protected]> > ---
Thanks for splitting these out. This is still: Reviewed-by: David Gow <[email protected]> (Note, though, that it introduces another call to test_data_path(), which conflicts with your pytest patches.) Cheers, -- David > tools/testing/kunit/kunit_tool_test.py | 10 > ++++++++++ > .../kunit/test_data/test_is_test_passed-failure-nested.log | 7 +++++++ > 2 files changed, 17 insertions(+) > > diff --git a/tools/testing/kunit/kunit_tool_test.py > b/tools/testing/kunit/kunit_tool_test.py > index bbba921e0eac..b74dc05fc2fe 100755 > --- a/tools/testing/kunit/kunit_tool_test.py > +++ b/tools/testing/kunit/kunit_tool_test.py > @@ -165,6 +165,16 @@ class KUnitParserTest(unittest.TestCase): > self.assertEqual(kunit_parser.TestStatus.FAILURE, > result.status) > self.assertEqual(result.counts.errors, 0) > > + def test_parse_failed_nested_tests_log(self): > + nested_log = > test_data_path('test_is_test_passed-failure-nested.log') > + with open(nested_log) as file: > + result = > kunit_parser.parse_run_tests(file.readlines(), stdout) > + self.assertEqual(kunit_parser.TestStatus.FAILURE, > result.status) > + self.assertEqual(result.counts.failed, 2) > + self.assertEqual(kunit_parser.TestStatus.FAILURE, > result.subtests[0].status) > + self.assertEqual(kunit_parser.TestStatus.FAILURE, > result.subtests[1].status) > + self.assertEqual(kunit_parser.TestStatus.FAILURE, > result.subtests[1].subtests[0].status) > + > def test_no_header(self): > empty_log = > test_data_path('test_is_test_passed-no_tests_run_no_header.log') > with open(empty_log) as file: > diff --git > a/tools/testing/kunit/test_data/test_is_test_passed-failure-nested.log > b/tools/testing/kunit/test_data/test_is_test_passed-failure-nested.log > new file mode 100644 > index 000000000000..2e528da39ab5 > --- /dev/null > +++ b/tools/testing/kunit/test_data/test_is_test_passed-failure-nested.log > @@ -0,0 +1,7 @@ > +KTAP version 1 > +1..2 > +not ok 1 subtest 1 > + KTAP version 1 > + 1..1 > + not ok 1 subsubtest 1 > +not ok 2 subtest 2 > > -- > 2.52.0 >
smime.p7s
Description: S/MIME Cryptographic Signature
