On Fri, Jan 02, 2026 at 02:45:04PM +0000, Ben Horgan wrote: > On 12/19/25 19:28, Mark Brown wrote: > > Currently when set_id_regs encounters a problem checking validation of > > writes to feature registers it uses an immediately fatal assert to report > > the problem. This is not idiomatic for kselftest, and it is also not great
> This one also looks good to me. I'm not aware of why the asserts have > been favoured previously though. The older KVM selftests and the KVM specific selftest framework don't work with the kselftest framework inside the test programs and instead just run a single test within each test program and die immediately if there's some issue. This is fine so long as each test only does one thing but falls apart when you've got multiple tests in a single program like this one, there the kselftest framework helps a lot. It looks like the program is mixing the two idioms.
signature.asc
Description: PGP signature
