Re: [PATCH, v2 13/13] mm/m68k: fix build warning of unused variable

[Sergei Shtylyov]

Hello.

On 05/29/2013 06:44 PM, Jiang Liu wrote:

Fix build warning of unused variable:
arch/m68k/mm/init.c: In function 'mem_init':
arch/m68k/mm/init.c:151:6: warning: unused variable 'i' [-Wunused-variable]

Signed-off-by: Jiang Liu <jiang....@huawei.com>
Cc: Geert Uytterhoeven <ge...@linux-m68k.org>
Cc: Greg Ungerer <g...@uclinux.org>
Cc: Thadeu Lima de Souza Cascardo <casca...@holoscopio.com>
Cc: linux-m...@lists.linux-m68k.org
Cc: linux-kernel@vger.kernel.org
---
  arch/m68k/mm/init.c | 13 ++++++++-----
  1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/m68k/mm/init.c b/arch/m68k/mm/init.c
index 6e0a938..6b4baa6 100644
--- a/arch/m68k/mm/init.c
+++ b/arch/m68k/mm/init.c
@@ -146,14 +146,11 @@ void __init print_memmap(void)
                MLK_ROUNDUP(__bss_start, __bss_stop));
  }

-void __init mem_init(void)

+static inline void init_pointer_tables(void)
  {
+#if defined(CONFIG_MMU) && !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)

   #ifdef's in the function bodies are frowned upon, this should better be:

#if defined(CONFIG_MMU) && !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)

static inline void init_pointer_tables(void)
{
[...]
}
#else
static inline void init_pointer_tables(void) {}
#endif

        int i;

- /* this will put all memory onto the freelists */

-       free_all_bootmem();
-
-#if defined(CONFIG_MMU) && !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)
        /* insert pointer tables allocated so far into the tablelist */
        init_pointer_table((unsigned long)kernel_pg_dir);
        for (i = 0; i < PTRS_PER_PGD; i++) {
@@ -165,7 +162,13 @@ void __init mem_init(void)
        if (zero_pgtable)
                init_pointer_table((unsigned long)zero_pgtable);
  #endif
+}

+void __init mem_init(void)

+{
+       /* this will put all memory onto the freelists */
+       free_all_bootmem();
+       init_pointer_tables();
        mem_init_print_info(NULL);
        print_memmap();
  }

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/