On 08/20/2013 09:12 PM, Rob Herring wrote:
On 08/19/2013 09:04 PM, Sebastian Hesselbarth wrote:
With arch/arm calling of_clk_init(NULL) from time_init(), we can now
remove custom .init_time hooks. Highbank clock provider need a reference
to system registers, as a workaround current clk driver maps those
independent of arch code now.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com>
---
Notes:
- I suggest to consolidate the four single clock providers into a single
provider with one node if possible.
And how do you suggest doing that while maintaining the DT ABI?
Rob,
I am aware of ABI status of the DT bindings and the discussion about
deprecating/cleanup of what went in in the past. Maybe "suggest" is a
little bit too strong and should have been "would be nice to have".
But looking at clk-highbank, all providers depend on the same register.
If you'd introduce e.g. a new "calxeda,core-clocks" that sets up the
four providers and also CLK_OF_DECLARE the same init with one out of
the four existing compatibles shouldn't that maintain backwards
compatibility?
Anyway, I was just puting the note above to raise some comment on it.
You actually gave a good one to leave it as is.
---
arch/arm/mach-highbank/highbank.c | 23 +++++++----------------
drivers/clk/clk-highbank.c | 10 +++++++---
2 files changed, 14 insertions(+), 19 deletions(-)
Acked-by: Rob Herring <rob.herr...@calxeda.com>
Ok, I keep that in mind until all other issues are resolved.
Thanks,
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
