On 13.06.14 13:02:57, Tomasz Nowicki wrote: > Currently APEI depends on x86 architecture. It is because of NMI hardware > error notification of GHES which is currently supported by x86 only. > However, many other APEI features can be still used perfectly by other > architectures. > > This commit adds ARCH_HAS_ACPI_APEI_NMI which will be used in next patches > for NMI related code isolation in ghes.c file. Only NMI error notification > feature depends on x86 so let it be hard selected for x86 arch. > > Signed-off-by: Tomasz Nowicki <tomasz.nowi...@linaro.org> > --- > arch/x86/Kconfig | 1 + > drivers/acpi/apei/Kconfig | 8 +++++++- > 2 files changed, 8 insertions(+), 1 deletion(-)
Apart from merging the patch with later ones this change looks fine to me > +config ARCH_HAS_ACPI_APEI_NMI > + bool > + help > + Firmware first mode can use NMI notification mechanism to report > errors > + to operating system. This feature is currently supported by X86 > + architecture only. > + Maybe the help description could be removed, it is not used anywhere in a dialog. At least the reference to x86 should be removed (if the option is used for another arch the text will be wrong and need to be changed again). -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
