On Fri, Dec 18, 2015 at 11:46 AM, Linus Torvalds
<torva...@linux-foundation.org> wrote:
> On Thu, Dec 17, 2015 at 8:10 PM, James Morris <jmor...@namei.org> wrote:
>> David Howells (7):
>>       Handle leap seconds in mktime64()
> This one is completely wrong.
> Leap seconds are inserted *at* the minute, not at the secodn before the 
> minute.
> So this code:
> +       /* Handle leap seconds */
> +       if (sec == 60)
> +               sec = 59;
> is just complete crap. Making the whole commit bogus and wrong.
> The code did the right thing wrt leap seconds before, without having
> any magical and incorrect special case. That commit makes it instead
> have two seconds of xx:xx:59.

So leap-seconds are inserted at the minute, but the kernel represents
it as repeating the last second of the day.
xx:xx:59 (+ TIME_OOP)

So I did suggest that he follow the kernel's behavior in this way, but
I've not yet had a chance to review the patch.

To unsubscribe from this list: send the line "unsubscribe 
linux-security-module" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to