> * The validator allows to enter "10em", but the value is then changed
> after application to "10cm". Not good. A special validator would need
> to be set up for this task.


I didn't realize that would happen! Thanks for catching it.

> Meanwhile, I have added you to the credits. Welcome aboard!

> Well done! Thanks for pushing the patch over the commit line.

Thank you :)

Chris


On Sun, Oct 30, 2022 at 11:46 PM Jürgen Spitzmüller <jspi...@gmail.com> wrote:
>
> Am Sonntag, dem 30.10.2022 um 16:39 -0400 schrieb Christopher
> Hillenbrand:
> > That is a valid point!
> > Restricting the units and using a CheckedLineEdit are still probably
> > worthwhile considering, so here are those changes separately.
>
> Thanks. I have some thoughts about that:
>
> * The validator allows to enter "10em", but the value is then changed
> after application to "10cm". Not good. A special validator would need
> to be set up for this task.
>
> * I actually think some of the removed values are quite useful in the
> given case: ex and em are best to estimate a good line length related
> to the font size (which is, typographically, the most sensible
> measure). I also think the pt-related units (sp, bp, pt etc.) are quite
> sensible here. And finally, I don't see why cm is there, but mm
> removed.
> Generally speaking, I doubt whether removing any of these measures is
> worth the effort.
>
> Meanwhile, I have added you to the credits. Welcome aboard!
>
> --
> Jürgen
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to