Hi Carsten, thanks for the changes.
On 25.02.2013 17:34, Carsten Neumann wrote: > Hello Christoph, > > On 02/25/2013 03:21 AM, "Christoph Fünfzig" wrote: >> I would like like to report some change proposals. >> >> * In OSGHDRStage.cpp, >> HDRStage::generateFragmentProgram the default arguments >> do not compile with a recent ATI driver: > > hmm, I always thought default args were allowed in GLSL? Anyway... > >> << "vec4 radial(sampler2D tex," >> OSGHDRL >> << " vec2 texcoord," >> OSGHDRL >> << " int samples," >> OSGHDRL >> << " float startScale = 1.0," >> OSGHDRL >> << " float scaleMul = 0.9)" >> OSGHDRL >> >> They are not necessary and should be omitted! > > ... removed. > >> * HDRStage::initData(RenderAction *pAction, Int32 iVPWidth, Int32 >> iVPHeight) >> there is still an old style "fprinf(stderr, ..". It should use the log: >> >> SINFO << "use pixe size " >> << pAction->getActivePartition()->getViewportWidth () >> << " " << pAction->getActivePartition()->getViewportHeight() >> << std::endl; > > I removed the output and surrounding dead code (it was reporting a value > that is potentially different from the one actually used). > >> * In OSGSimpleSHLChunk.cpp (handleGL), OSGShaderProgram.cpp (handleGL) >> when compiling or linking does not work, I think the shader source should be >> output for consideration. >> This is discussable for longer sources, but a better way for debugging is >> definitely needed. > > Shader link errors already log the source code > (OSGShaderExecutableChunk.cpp) for debug libraries (i.e. #ifdef > OSG_DEBUG). I've added it for shader compile errors as well. > I don't have a strong opinion either way on dropping the #ifdef > OSG_DEBUG around this and have it work with release libs too. Anyone? Well, I mostly use Release or ReleaseNoOpt libraries. SimpleSHLChunk is not needed anymore? Cheers, Christoph ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Opensg-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-users
