Hi JS, On Thu, Feb 5, 2009 at 4:41 PM, Jean-Sébastien Guay <jean-sebastien.g...@cm-labs.com> wrote: > That's your opinion but you shouldn't be making judgement calls like that > for other people's projects, which is why I think putting suppression in > include/osg/Export is a bad practice. But I know I won't make you change > your opinion on this.
I have *really* *really* hard to get the pragma's out of the include/osg/Export. I've have poured several weeks of my life trying to do so. I have only added suppression back into the Export because the remaining warnings were just detracting form the real job in hand - fixing the code rather adding workarounds. > I just think if OSG wants to be a truly cross-platform library it needs to > do things the right way on all platforms. On VS, using push/pop is the way > to go so you don't cause warnings to be suppressed in user code (which is > the other project's call to make). push/pop adds a lot of extra syntax to headers for just one single platform, it's not cross platform in any whatso ever. Polluting our headers and .cpp's with lots of pragma's for just one platform because it's warnings are misleading and impractical/impossible to fix is not good practice. One should only do hacks like this when you absolutely have to. Don't forgot fixing warnings are double edge sword. Right now I've investigating a new bug that has occurred because of the warnings work. I hate taking step backs on code quality and this one is exactly because of an attempt at fixing bugs. Robert. _______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
