Hi all Thanks Martin for his excellent work on SphericalManipulator. I will be so glad if this can be added to the submission list.
But there are a few notes and questions: 1 - you have commented the body of zoomOn function, but it's declaration exits in the class. 2 - I think zoomOn function offers a good and useful functionality. Is it necessary to remove it from the manipulator? 3 - I haven't implemented the setByMatrix function, because I don't need it. But this should be done. 4 - There is an small issue in getInverseMatrix and getMatrix functions. Both compute the matrix even if it hasn't changed from the previous step. Maybe it is better to compute it when needed and just return the computed one otherwise. 5 - The member variable named _dragged is not necessary and can be removed. I use it in my specialized version only. Regards, Moji the Great --- On Thu, 4/23/09, Martin Beckett <m...@mgbeckett.com> wrote: From: Martin Beckett <m...@mgbeckett.com> Subject: Re: [osg-users] CAD style rotation To: osg-users@lists.openscenegraph.org Date: Thursday, April 23, 2009, 12:18 AM It's Moji's code so he should probably be the one to submit it. There seems to be a few functions that aren't necessary (perhaps for some other code) which could be cleaned up. It would be nice if there was a method to set a rotation origin in the model - or is there some general way to do this? Martin ps. There seems to be a lot of cut+paste code between the different manipulators - perhaps somebody who understands them better could look at how much could be moved to MatrixManipulator. ------------------ Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=10679#10679 _______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
_______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
