On Sun, 10 May 2009, Robert Spier wrote:
Ask Bjørn Hansen wrote:
On May 9, 2009, at 19:21, Charlie Brady wrote:
This is really a namespace issue, I think. Should "check_spamhelo"
belong to an old simple ineffective plugin, or a newer, and
presumably more useful, one?
As much as it sucks to lose the old simple plugins for examples, I
think I could go for replacing it with a newer one.
...
If the newer one is going to have different behavior, or doesn't
support the old config file, it'll potentially break people who
upgrade. (And people don't read documentation or check the changes
file -- it just doesn't happen.) The easiest way around that is to
make the new version have a different name.
Yes that's easier. But not better.
What would be better IMO is to have an enhanced plugin which is a strict
superset of the existing plugin. I think that would be easy to do with a
legacy badhelo config, and new badhelo_re config. That would work simply,
but at the cost of an extra config load per execution.
Or we could fudge a bit and just have badhelo. I doubt there will be many
false positive re matches with the existing badhelo configs. e.g "aolycom"
will be a false positive match with "aol.com", but it's probably something
you'd reject anyway and would have rejected via existing check_spamhelo if
a patch proposed by Andrew Pam in 2003 had been accepted:
http://markmail.org/message/sckrkzhtft34rqgg
Does anyone have existing literal badhelo matches which might match a
valid helo hostname if interpreted as an RE?
---
Charlie
