On Saturday, October 08, 2011, Tom Breton (Tehom) wrote:

>  * Value widgets are spinboxes instead of menus from 0 to 127

Menus?  It's not completely obvious from a glance through the diff, but I'd 
expect to find the original widgets were combo boxes with 0..127, rather than 
menus.

Chris Cannam loves those things, and I have to agree with him that it's a lot 
easier to use one of those combo boxes (eg. the Transpose combo in Segment 
Parameters) to jump to a specific value than it is with a spin box.

Anything involving reworking something of Chris's to use spin boxes is sure to 
go over like a lead balloon.  I know this from springing that particular booby 
trap myself on several occasions.
 
> Under the hood, it moves everything except the gui logic into
> base/parameterpattern.

Anyway, that quibble aside this looks like some nice work here.  I haven't sat 
down to play with this or any of the other stuff you guys have committed this 
week, but the code certainly looks very clean, well-organized, and purposeful.
-- 
D. Michael McIntyre

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to