On 03/25/2015 04:00 PM, Tom Breton (Tehom) wrote: >> I also introduced a new color, MemberOfParallelColour, in >> NotePixmapFactory in enum ColorType. This is then hardcoded in >> NotePixmapFactory::getCharacter as magenta. Is this ok or is there a >> better way to do this? Should this be configureable? Or is this too >> complicated? > > I think that's ok.
Configurable is too complicated. I'd have to see the code in context to judge whether it's coded in an appropriate way, or maybe needs tweaked. It's not something that would get a patch rejected either way. If it's far enough along to be useful and not excessively complicated to go through, it should be fine. This doesn't sound like something that's going to end up in limbo over needing a little polish. That really only happens when the thing needing polished is gigantic and very rough. >> 3: >> The notes are colored now, but not the stems. How would I also change the >> color of the corresponding stem? > > As Michael mentioned, that code has multiple layers of functionality for > historical reasons. I wouldn't worry about it. Out of range notes don't have colored stems either, which means I looked at how to get that done, and decided it wasn't worth it. Following my lead would be fine. If you really care that much, grab a shovel and start digging is all I can tell you. -- D. Michael McIntyre ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
