All done (for Qt4 at least), except for the following items:
* The about dialog is displaying a BUILDKEY, computed as a sha1 of the sources.
Is this useful ?
Other projects typically show a SVN revision number (when compiling from svn;
nothing otherwise
since the release version number is already there). Yet other projects don't do
any of that, people
compiling from SVN can run `svn info` themselves :) Let me know what I should
do.
* The Makefile had rules for running perl scripts that deal with translations.
I didn't port this to cmake yet, because I'm not sure it should be part of the
buildsystem,
since AFAICS these things are run manually, not as part of the actual build.
Wouldn't it be enough to have a few shell scripts with these commands?
instrument-ts:
$(PERL) scripts/extract_instrument_tr_strings.pl
data/presets/presets.xml > data/InstrumentStrings.cpp
menu-ts:
$(PERL) scripts/extract_menu_tr_strings.pl $(RCS) >
data/QMenuStrings.cpp
autoload-ts:
gunzip -c data/autoload/autoload.rg > data/autoload/autoload.xml #
(couldn't make macro $(GUNZIP_C) work)
$(PERL) scripts/extract_autoload_tr_strings.pl
data/autoload/autoload.xml > data/AutoloadStrings.cpp
rm -f data/autoload/autoload.xml
ts: menu-ts instrument-ts autoload-ts
$(MKDIR_P) data/locale
$(LUPDATE) $(UI) $(HEADERS) $(SOURCES) data/QMenuStrings.cpp
data/InstrumentStrings.cpp data/AutoloadStrings.cpp -ts
data/locale/rosegarden.ts $(TRANSLATIONS)
@scripts/ts-stats
ts-noobsolete: menu-ts instrument-ts
$(MKDIR_P) data/locale
$(LUPDATE) -noobsolete $(HEADERS) $(SOURCES) data/QMenuStrings.cpp
data/InstrumentStrings.cpp data/AutoloadStrings.cpp -ts
data/locale/rosegarden.ts $(TRANSLATIONS)
@scripts/ts-stats
* Does someone want to give a try to compiling with cmake?
http://www.davidfaure.fr/2015/cmake_buildsystem_v1.diff
Meanwhile I'll add the missing Qt5 support. I'll put the final patch in the
sf.net patches list.
Maybe I can get SVN commit access so I don't have to go through it for followup
commits to the cmake buildsystem?
I will still definitely request review for anything else.
* Later on when everyone is happy with the cmake buildsystem and we can remove
the existing buildsystem,
I will be able to do some improvements which require some changes in the source
code (so I can't do them yet).
- removing the "foo.moc" includes which trigger a warning in the automoc cmake
feature
- replacing -D on the commandline with generated headers to minimize rebuilds
--
David Faure, [email protected], http://www.davidfaure.fr
Working on KDE Frameworks 5
------------------------------------------------------------------------------
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
