[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854019#comment-17854019 ] Ingo Wolfmayr commented on OFBIZ-12390: --- Hi [~jleroux], yes please. I do not have the time right now to take care of the issue. Thanks > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-13115) Ofbiz performance issue with ThemeFactory
[ https://issues.apache.org/jira/browse/OFBIZ-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852394#comment-17852394 ] Ingo Wolfmayr commented on OFBIZ-13115: --- The provided patch pins the search to the widget folders of the themes and plugins. > Ofbiz performance issue with ThemeFactory > - > > Key: OFBIZ-13115 > URL: https://issues.apache.org/jira/browse/OFBIZ-13115 > Project: OFBiz > Issue Type: Improvement > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: themefactory.patch > > > If there are many products with images (images stored in the plugin or > theme), the ThemeFactory blocks the frontend until all files are processed. > The problem is initiated in the following lines of code in ThemeFactory.java: > List xmlThemes = FileUtil.findXmlFiles(themeFolderPath, null, "theme", > "widget-theme.xsd"); > List xmlPluginThemes = FileUtil.findXmlFiles(pluginsFolderPath, > null, "theme", "widget-theme.xsd"); > I think the search path should be restricted to the "widget" folder of the > respective plugins/themes, as the theme.xml file should be located there. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-13115) Ofbiz performance issue with ThemeFactory
[ https://issues.apache.org/jira/browse/OFBIZ-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-13115: -- Attachment: themefactory.patch > Ofbiz performance issue with ThemeFactory > - > > Key: OFBIZ-13115 > URL: https://issues.apache.org/jira/browse/OFBIZ-13115 > Project: OFBiz > Issue Type: Improvement > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: themefactory.patch > > > If there are many products with images (images stored in the plugin or > theme), the ThemeFactory blocks the frontend until all files are processed. > The problem is initiated in the following lines of code in ThemeFactory.java: > List xmlThemes = FileUtil.findXmlFiles(themeFolderPath, null, "theme", > "widget-theme.xsd"); > List xmlPluginThemes = FileUtil.findXmlFiles(pluginsFolderPath, > null, "theme", "widget-theme.xsd"); > I think the search path should be restricted to the "widget" folder of the > respective plugins/themes, as the theme.xml file should be located there. -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: AW: Ofbiz starting slow
Found the problem - not solved yet:
https://issues.apache.org/jira/browse/OFBIZ-13115
-Ursprüngliche Nachricht-
Von: Ingo Wolfmayr
Gesendet: Mittwoch, 5. Juni 2024 08:35
An: user@ofbiz.apache.org
Betreff: AW: AW: Ofbiz starting slow
Hi Jaques,
In my development environment, I have the images on a different server, and I
mount them into the defined folder – for Ofbiz, they appear to be local. On the
production server, the images are stored on the local drive. I have been doing
it this way for years now and have never had a problem.
The strange thing is the different behavior when:
Mounting the images before starting Ofbiz: Ofbiz will start as usual, but when
I try to access the backend, it can take hours until I get a response. Ofbiz
takes requests but seems to be unable to respond. There is no indication of
unusual usage of resources such as CPU, RAM, database, or hard disk. It looks
like a deadlock.
Mounting the images after Ofbiz has started: everything works fine, including
the images.
To clarify: I am talking about product images.
I will start profiling the Java process today; maybe that will shed some light
on the issue.
Best regards,
Ingo
-Ursprüngliche Nachricht-
Von: Jacques Le Roux
Gesendet: Mittwoch, 5. Juni 2024 08:12
An: user@ofbiz.apache.org
Betreff: Re: AW: Ofbiz starting slow
Forgot to tell about image.server.path in catalog.properties. I guess you are
already setting it?
Le 05/06/2024 à 07:58, Jacques Le Roux a écrit :
> Hi Ingo,
>
> After reading
> https://lists.apache.org/thread/ymbjbf4r6tlcj5r8grh9dsrdhnfkj2tp
>
> Are you putting your images on a dedicated server as suggested here
> https://lists.apache.org/thread/k2zj0hkf4sr2rdb90s6s8x2jfzb256lb ?
>
> HTH
>
> Jacques
>
> Le 04/06/2024 à 16:22, Ingo Wolfmayr a écrit :
>> Hi Johan,
>>
>> I have already excluded these tasks. In my case, Ofbiz is ready to
>> take requests. I can see the requests in the log, but nothing seems
>> to happen after showing the information mentioned below. If I remove the
>> images and restart the instance, everything works as expected. I can make
>> the images available afterwards, and it will work just fine.
>>
>> I thought it could be something with loading images into the cache or
>> indexing?
>>
>> Best regards,
>> Ingo
>> -Ursprüngliche Nachricht-
>> Von: Johan Cronje
>> Gesendet: Dienstag, 4. Juni 2024 15:41
>> An: user@ofbiz.apache.org
>> Betreff: Re: Ofbiz starting slow
>>
>> Hi Ingo,
>>
>> Not sure if this would be of help.
>> Since we did not need it on our local instance we made zip and tar gradle
>> tasks optional based on arguments.
>>
>> Added the below within the build.gradle:
>>
>> tasks.named('distTar').configure {
>> onlyIf {
>> project.hasProperty('includeDistTar')
>> }
>> }
>> tasks.named('distZip').configure {
>> onlyIf {
>> project.hasProperty('includeDistZip')
>> }
>> }
>>
>> This made our startup significantly faster.
>>
>> Kind Regards,
>> Johan
>>
>> On Tue, 4 Jun 2024 at 14:32, Ingo Wolfmayr wrote:
>>> Hi everybody,
>>>
>>> I have an OFBiz installation (multiple tenants, trunk) with many
>>> products and therefore many images. When I start OFBiz, it takes forever
>>> until it can be accessed via the interface. The log stops with the
>>> following entry: "This is the first request in this visit. Hidden sessionId
>>> by default."
>>>
>>> If I remove the images (unmount the path) and restart, OFBiz is quickly
>>> available as usual.
>>>
>>> What could be the problem here? During the waiting time, hardly any
>>> resources are used - neither CPU, memory, nor HDD read.
>>>
>>> Best regards,
>>> Ingo
[jira] [Created] (OFBIZ-13115) Ofbiz performance issue with ThemeFactory
Ingo Wolfmayr created OFBIZ-13115: - Summary: Ofbiz performance issue with ThemeFactory Key: OFBIZ-13115 URL: https://issues.apache.org/jira/browse/OFBIZ-13115 Project: OFBiz Issue Type: Improvement Reporter: Ingo Wolfmayr If there are many products with images (images stored in the plugin or theme), the ThemeFactory blocks the frontend until all files are processed. The problem is initiated in the following lines of code in ThemeFactory.java: List xmlThemes = FileUtil.findXmlFiles(themeFolderPath, null, "theme", "widget-theme.xsd"); List xmlPluginThemes = FileUtil.findXmlFiles(pluginsFolderPath, null, "theme", "widget-theme.xsd"); I think the search path should be restricted to the "widget" folder of the respective plugins/themes, as the theme.xml file should be located there. -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: AW: Ofbiz starting slow
Hi Jaques,
In my development environment, I have the images on a different server, and I
mount them into the defined folder – for Ofbiz, they appear to be local. On the
production server, the images are stored on the local drive. I have been doing
it this way for years now and have never had a problem.
The strange thing is the different behavior when:
Mounting the images before starting Ofbiz: Ofbiz will start as usual, but when
I try to access the backend, it can take hours until I get a response. Ofbiz
takes requests but seems to be unable to respond. There is no indication of
unusual usage of resources such as CPU, RAM, database, or hard disk. It looks
like a deadlock.
Mounting the images after Ofbiz has started: everything works fine, including
the images.
To clarify: I am talking about product images.
I will start profiling the Java process today; maybe that will shed some light
on the issue.
Best regards,
Ingo
-Ursprüngliche Nachricht-
Von: Jacques Le Roux
Gesendet: Mittwoch, 5. Juni 2024 08:12
An: user@ofbiz.apache.org
Betreff: Re: AW: Ofbiz starting slow
Forgot to tell about image.server.path in catalog.properties. I guess you are
already setting it?
Le 05/06/2024 à 07:58, Jacques Le Roux a écrit :
> Hi Ingo,
>
> After reading
> https://lists.apache.org/thread/ymbjbf4r6tlcj5r8grh9dsrdhnfkj2tp
>
> Are you putting your images on a dedicated server as suggested here
> https://lists.apache.org/thread/k2zj0hkf4sr2rdb90s6s8x2jfzb256lb ?
>
> HTH
>
> Jacques
>
> Le 04/06/2024 à 16:22, Ingo Wolfmayr a écrit :
>> Hi Johan,
>>
>> I have already excluded these tasks. In my case, Ofbiz is ready to
>> take requests. I can see the requests in the log, but nothing seems
>> to happen after showing the information mentioned below. If I remove the
>> images and restart the instance, everything works as expected. I can make
>> the images available afterwards, and it will work just fine.
>>
>> I thought it could be something with loading images into the cache or
>> indexing?
>>
>> Best regards,
>> Ingo
>> -Ursprüngliche Nachricht-
>> Von: Johan Cronje
>> Gesendet: Dienstag, 4. Juni 2024 15:41
>> An: user@ofbiz.apache.org
>> Betreff: Re: Ofbiz starting slow
>>
>> Hi Ingo,
>>
>> Not sure if this would be of help.
>> Since we did not need it on our local instance we made zip and tar gradle
>> tasks optional based on arguments.
>>
>> Added the below within the build.gradle:
>>
>> tasks.named('distTar').configure {
>> onlyIf {
>> project.hasProperty('includeDistTar')
>> }
>> }
>> tasks.named('distZip').configure {
>> onlyIf {
>> project.hasProperty('includeDistZip')
>> }
>> }
>>
>> This made our startup significantly faster.
>>
>> Kind Regards,
>> Johan
>>
>> On Tue, 4 Jun 2024 at 14:32, Ingo Wolfmayr wrote:
>>> Hi everybody,
>>>
>>> I have an OFBiz installation (multiple tenants, trunk) with many
>>> products and therefore many images. When I start OFBiz, it takes forever
>>> until it can be accessed via the interface. The log stops with the
>>> following entry: "This is the first request in this visit. Hidden sessionId
>>> by default."
>>>
>>> If I remove the images (unmount the path) and restart, OFBiz is quickly
>>> available as usual.
>>>
>>> What could be the problem here? During the waiting time, hardly any
>>> resources are used - neither CPU, memory, nor HDD read.
>>>
>>> Best regards,
>>> Ingo
AW: Google Tag Manager + Facebook Advertising
Hi James, I have created a plugin to push products to google merchant center - the basis for google advertising. I can give you access to the code if you want. What do you mean with Facebook feeds? Do you want to create the ads in Ofbiz and push them to facebook? Best regards, Ingo -Ursprüngliche Nachricht- Von: james productive1.com Gesendet: Dienstag, 4. Juni 2024 20:44 An: user@ofbiz.apache.org Betreff: Google Tag Manager + Facebook Advertising Anyone familiar with integrating Ofbiz products to Google Tag Manager or Facebook feeds for advertising? Thanks, James
AW: Ofbiz starting slow
Hi Johan,
I have already excluded these tasks. In my case, Ofbiz is ready to take
requests. I can see the requests in the log, but nothing seems to happen after
showing the information mentioned below. If I remove the images and restart the
instance, everything works as expected. I can make the images available
afterwards, and it will work just fine.
I thought it could be something with loading images into the cache or indexing?
Best regards,
Ingo
-Ursprüngliche Nachricht-
Von: Johan Cronje
Gesendet: Dienstag, 4. Juni 2024 15:41
An: user@ofbiz.apache.org
Betreff: Re: Ofbiz starting slow
Hi Ingo,
Not sure if this would be of help.
Since we did not need it on our local instance we made zip and tar gradle tasks
optional based on arguments.
Added the below within the build.gradle:
tasks.named('distTar').configure {
onlyIf {
project.hasProperty('includeDistTar')
}
}
tasks.named('distZip').configure {
onlyIf {
project.hasProperty('includeDistZip')
}
}
This made our startup significantly faster.
Kind Regards,
Johan
On Tue, 4 Jun 2024 at 14:32, Ingo Wolfmayr wrote:
>
> Hi everybody,
>
> I have an OFBiz installation (multiple tenants, trunk) with many products and
> therefore many images. When I start OFBiz, it takes forever until it can be
> accessed via the interface. The log stops with the following entry: "This is
> the first request in this visit. Hidden sessionId by default."
>
> If I remove the images (unmount the path) and restart, OFBiz is quickly
> available as usual.
>
> What could be the problem here? During the waiting time, hardly any resources
> are used - neither CPU, memory, nor HDD read.
>
> Best regards,
> Ingo
Ofbiz starting slow
Hi everybody, I have an OFBiz installation (multiple tenants, trunk) with many products and therefore many images. When I start OFBiz, it takes forever until it can be accessed via the interface. The log stops with the following entry: "This is the first request in this visit. Hidden sessionId by default." If I remove the images (unmount the path) and restart, OFBiz is quickly available as usual. What could be the problem here? During the waiting time, hardly any resources are used - neither CPU, memory, nor HDD read. Best regards, Ingo
AW: Webstore Design/Functionality
Hi James, I am working with the webstore module for years - working as an ecommerce cunsultant - focusing on Ofbiz. Best regards, Ingo -Ursprüngliche Nachricht- Von: james productive1.com Gesendet: Samstag, 11. Mai 2024 16:02 An: user@ofbiz.apache.org Betreff: Webstore Design/Functionality Good morning we are looking for someone who has worked extensively with the webstore module. We are looking to put together a design template that is comparable to what Shopify or Big Commerce offers. If you are a consultant that has this expertise, please let us know ASAP. Sincerely James
AW: Performance scale up Thread
Did you check the caching settings. framework/base/config/cache.properties You should enable caching groovy scripts : # Development Mode - comment these out to better cache groovy scripts, etc #These are all cleared by default every 1 milliseconds, or ten seconds #minilang.SimpleMethodsDirect.expireTime=1 #minilang.SimpleMethodsResource.expireTime=1 #minilang.SimpleMethodsURL.expireTime=1 I remember this causing a memory leak on production - it is meant for developing mode. Best regards, Ingo -Ursprüngliche Nachricht- Von: Mandar K Gesendet: Mittwoch, 8. Mai 2024 20:31 An: ofbizuser Betreff: Performance scale up Thread Dear All, related to performance scale up thread wanted to share one observation : Everytime there is an increase in memory it gets filled up. This may be due to a memory management bug in any code. Some processes are creating a lot of objects and not clearing afterwards. Requesting inputs on the below 1. How to identify those objects / code which is causing memory leak 2. Any suggestions for GC We are facing a challenge on the performance issue. Any strong assistance will really help. Thanks a lot. -- Regards Mandar K
AW: Performance issues
Hi Mk, I recommend checking the following points first: 1. Database Optimization: Indexes: Ensure that your database tables are properly indexed. Missing indexes can dramatically slow down query performance. Query Analysis: Use tools like slow query logs to identify inefficient queries and optimize them. Connection Pooling: Verify that your database connection settings are optimized for your usage pattern. For mysql/mariadb I use: https://github.com/major/MySQLTuner-perl for performance recommendations 2. Server and JVM Tuning: Memory Allocation: Increase the JVM heap size if necessary. This is especially important if you are experiencing OutOfMemoryErrors. Garbage Collection: Optimize garbage collection parameters to reduce overhead. Tools like VisualVM can help monitor garbage collection and tweak settings. 3. OFBiz Configuration: Thread Pools: Adjust the size of thread pools in OFBiz to match your server’s hardware capabilities. Service Engine: Review the service engine configuration for performance bottlenecks. Best regards Ingo -Ursprüngliche Nachricht- Von: Mandar K Gesendet: Dienstag, 23. April 2024 06:51 An: user@ofbiz.apache.org Betreff: Performance issues Hi All, In a recent switchover to Ofbiz we are observing performance issues where almost all the application is running very slow. Please give pointers which will give breakthrough. Thanks for your inputs, much appreciated. Regards Mk
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834792#comment-17834792 ] Ingo Wolfmayr commented on OFBIZ-12390: --- Hi [~jleroux], I check and update the ticket. Best regards, Ingo > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12780) Tax rate from shipping address when taxInPrice = "Y"
[ https://issues.apache.org/jira/browse/OFBIZ-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834789#comment-17834789 ] Ingo Wolfmayr commented on OFBIZ-12780: --- Hi Pierre, I have temporarily returned to taxInPrice = N as when it comes to adjustments like promotions it does not work as expected (for me with sales tax). Also the ShoppingCart price infos have problems showing the correct values in some of my cases. Unfortunately fixing this is not a quick hack as the price calculation service result does not provide enough details by now to allow further calculation (with the result as basis). I will work on this as soon as I have enough time. Best regards, Ingo > Tax rate from shipping address when taxInPrice = "Y" > > > Key: OFBIZ-12780 > URL: https://issues.apache.org/jira/browse/OFBIZ-12780 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > Attachments: eutax-1.patch, taxexample.jpg > > > *Case:* shipment from AUT (20% sales tax) to DEU (19% sales tax). > *Now:* > Productprice with taxInPrice = "N": tax calculated according to > taxRateProduct definition --> ok > Productprice with taxInPrice = "Y": if productPrice for target country exists > --> ok, if not, the productStore tax setting is used. > *Goal:* > Calculate VAT for tax taken from shipment target + add price adjustment. > *Example:* > Gross price: € 14,80 (20% sales tax - default price) > Order: > Unit price: € 14,80 > Tax: € 2,47 (19%) > OrderAdjustment (item): € -0,127 > When done, the order result will be the same as when using taxInPrice = "N" > *Testing:* > # create product + productprice (taxInPrice="Y") > # create order with shipping address geoId different to productprice > taxAuthGeoId > # --> Ofbiz will then create the order item adjustments > Reason: > Administration of multiple prices due to different taxes may be quite time > consuming. For example selling from one country within the EU to another EU > country (27) will result in 27 listprices and 27 default prices for a single > product. EU law for example obligates the seller to apply the shipping target > tax rate on the invoice. -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: Shipment of inventory for a workshop
Hi Emad, Completing the quick ship for the entire order is not the final step when managing inventory. Depending on your store settings, inventory is allocated when the order status changes to "approved". You can view the assigned inventory in the order lines, with ATP being reduced while QOH remains unchanged. At this stage, you can still edit the order (update/create/delete order lines...). Upon finalizing the order, QOH will decrease as the inventory leaves the facility. Best regards, Ingo Von: Emad Radwan Gesendet: Sonntag, 3. März 2024 14:18:38 An: user@ofbiz.apache.org Betreff: Shipment of inventory for a workshop Hello Community, Issuing customer inventory is the last step via actions like 'Quick ship entire order' and maybe others. That's fine in merchandising but if we're in a workshop where we need to issue the spare parts to do the maintenance and finalizing the sales order is yet to take place later. Could you let me know how this situation is handled? Regadsm Emad
[jira] [Commented] (OFBIZ-12850) Duplicate class ... hot reload failed
[
https://issues.apache.org/jira/browse/OFBIZ-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814277#comment-17814277
]
Ingo Wolfmayr commented on OFBIZ-12850:
---
Hi [~danwatford] ,
as [~jleroux] mentioned, it seems to be related to OFBIZ-12888
I already managed to get it working by deleting ./build directory, create the
build and start ofbiz in debug mode. Also I added "Script" to any groovy file
name in my addons in order to avoid having duplicate class names. If I build
ofbiz without clearing the ./build directory the error will come up again.
*About the steps:*
I have gradle tasks in my IDE (I moved from eclipse to Intellj, but the setup
is almost the same).
Task 1: build (build -x distTar -x distZip)
Task 2: start (ofbiz --debug-jvm)
Task 3: debug (remote application)
> Duplicate class ... hot reload failed
> -
>
> Key: OFBIZ-12850
> URL: https://issues.apache.org/jira/browse/OFBIZ-12850
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Ingo Wolfmayr
>Priority: Major
>
> I have the problem, that with the current trunk, hot-reloading java code
> failed.
> Sometimes (I have not clue by now why not every-time) building the project
> printed the following error and failed:
> {noformat}
> Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
> duplicate handling strategy has been set. Please refer to
> https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
> for details.{noformat}
> There is no duplicate groovy or java that could lead to
> org/apache/ofbiz/accounting/GlEvents.class is a duplicate
> I have not finished my investigation yet. If someone has an idea, please let
> me know.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776562#comment-17776562 ] Ingo Wolfmayr commented on OFBIZ-12639: --- Hi Jacques, I have to finish a project before I can come back to this. By middle of next month I will take care of it. Sorry. > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: 4054.png, RerenderPatch_notready.patch, test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: Running a service instance
Hello Giulio, thanks for the input. I will take a closer look. Cheers, Ingo -Ursprüngliche Nachricht- Von: Giulio Speri - MpStyle Srl Gesendet: Sonntag, 8. Oktober 2023 23:55 An: user@ofbiz.apache.org Cc: Nicolas Malin Betreff: Re: Running a service instance Hello Ingo, I share a solution we use for sharing images across ofbiz instances on different servers. If your instances run on Linux servers you could also consider to use Bison, an utility tool that could keep two remote directory synced, both for adding and removing files. It's not real-time as a mounted volume, since the sync script has to be scheduled in crontab (is: every 5 minutes), but it's quite simple to use and configure and if you do not necessarily need real-time for your imes/files you could give it a try. Regards, Giulio Il giorno ven 22 set 2023 alle ore 07:52 Ingo Wolfmayr < ingo.wolfm...@wolfix.at> ha scritto: > Hello Nicolas, > > sounds great! Thanks for the fast response. > > Cheers, > Ingo > > Von: Nicolas Malin > Gesendet: Donnerstag, 21. September 2023 09:19 > An: user@ofbiz.apache.org; Ingo Wolfmayr > Betreff: Re: Running a service instance > > Hello Ingo, > > * Store your upload directory on shared volume (bucket, nfs, sshfs > other something like that) and mount it on the same patch on each > server (like > /var/lib/ofbiz/contents) > * Use the same path for the ofbiz home on each server hosting each > instance. > * Configure the upload content on your ofbiz properties > > Let's rock > > Nicolas > > Le 21/09/2023 à 09:09, Ingo Wolfmayr a écrit : > > Hi everybody, > > > > I am thinking about the following setup and I am not sure if it is > possible. If yes, what are the proposed configurations settings and > what should be monitored in detail? > > > > Instance1: main instance > > - holds images, files ... > > - serving views ... > > > > Instance2: service worker instance > > - process defined services > > -- for example addToSolrIndex > > -- import tasks - long running task > > > > Both instances will use the same database. > > > > My concerns: > > - how do I configure instance2 to store images uploaded by an import > task to the right directory (runtime/uploads/... of Instance1, > images/products/... of instance1) > > > > Any hints, thoughts about this topic would be very appreciated. > > > > Best regards, > > Ingo > > > > -- Giulio Speri *Mp Styl**e Srl* via Antonio Meucci, 37 41019 Limidi di Soliera (MO) T 059/684916 M 347/0965506 www.mpstyle.it
Dropship
Hi everybody, I am currently setting up dropship suppliers and I have the following questions: * Is it possible to have Ofbiz consider the supplier stock. For example the supplier has ATP = 10. * If there are multiple dropship suppliers. How do I setup shipping estimates to calculate the shipping costs and assign the costs to the correct party * supplier01 - € 3 * supplier02 - € 3 If anyone has experiences here it would be nice if they could share it. Best regards, Ingo
AW: Transaction
Hi Deepak,
thank. I will adapt my code.
Cheers,
Ingo
-Ursprüngliche Nachricht-
Von: Deepak Dixit
Gesendet: Freitag, 22. September 2023 07:35
An: user@ofbiz.apache.org
Betreff: Re: Transaction
Hi Ingo,
You can use dispatcher.runSync with requireNewTransaction true eg.
try {
Map result = dispatcher.runSync(serviceName, serviceInCtx ,
transactionTimeout, true);
if (!ServiceUtil.isSuccess(result)) {
Debug.logError(ServiceUtil.getErrorMessage(result), MODULE);
}
} catch (GenericServiceException gee) {
Debug.logError(gee, MODULE);
}
In this way you don't need to explicitly commit and begin the transaction.
Thanks & Regards
--
Deepak Dixit
ofbiz.apache.org
On Wed, Sep 20, 2023 at 9:45 PM Ingo Wolfmayr
wrote:
> Solved it myself.
>
> I set the service to manual transaction (use-transaction="N") and set
> TransactionUtil.begin() at the beginning and TransactionUtil.commit()
> at the end of every loop.
>
> Cheers,
> Ingo
>
> -----Ursprüngliche Nachricht-
> Von: Ingo Wolfmayr
> Gesendet: Mittwoch, 20. September 2023 08:30
> An: user@ofbiz.apache.org
> Betreff: Transaction
>
> Hi everybody,
>
> I have a question regarding transaction:
>
> I have a service that parses a big file and creates products from it.
> >
> 100.000 products
>
> If I do a TransactionUtil.commit() after each product, do I have to
> add a
> TransactionUtil.begin() for the next loop?
>
> - Service starts and creates a transaction
> - Product 1 --> commit
> - Product 2 --> commit
>
> or should I disable the service transaction via use-transaction="N"
>
> - Service starts - no transaction
> - begin --> Product 1 --> commit
> - begin --> Product 2 --> commit
>
> The goal is to reduce memory consumption.
>
> Best regards,
> Ingo
>
AW: Running a service instance
Hello Nicolas, sounds great! Thanks for the fast response. Cheers, Ingo Von: Nicolas Malin Gesendet: Donnerstag, 21. September 2023 09:19 An: user@ofbiz.apache.org; Ingo Wolfmayr Betreff: Re: Running a service instance Hello Ingo, * Store your upload directory on shared volume (bucket, nfs, sshfs other something like that) and mount it on the same patch on each server (like /var/lib/ofbiz/contents) * Use the same path for the ofbiz home on each server hosting each instance. * Configure the upload content on your ofbiz properties Let's rock Nicolas Le 21/09/2023 à 09:09, Ingo Wolfmayr a écrit : Hi everybody, I am thinking about the following setup and I am not sure if it is possible. If yes, what are the proposed configurations settings and what should be monitored in detail? Instance1: main instance - holds images, files ... - serving views ... Instance2: service worker instance - process defined services -- for example addToSolrIndex -- import tasks - long running task Both instances will use the same database. My concerns: - how do I configure instance2 to store images uploaded by an import task to the right directory (runtime/uploads/... of Instance1, images/products/... of instance1) Any hints, thoughts about this topic would be very appreciated. Best regards, Ingo
Running a service instance
Hi everybody, I am thinking about the following setup and I am not sure if it is possible. If yes, what are the proposed configurations settings and what should be monitored in detail? Instance1: main instance - holds images, files ... - serving views ... Instance2: service worker instance - process defined services -- for example addToSolrIndex -- import tasks - long running task Both instances will use the same database. My concerns: - how do I configure instance2 to store images uploaded by an import task to the right directory (runtime/uploads/... of Instance1, images/products/... of instance1) Any hints, thoughts about this topic would be very appreciated. Best regards, Ingo
AW: Transaction
Solved it myself. I set the service to manual transaction (use-transaction="N") and set TransactionUtil.begin() at the beginning and TransactionUtil.commit() at the end of every loop. Cheers, Ingo -Ursprüngliche Nachricht- Von: Ingo Wolfmayr Gesendet: Mittwoch, 20. September 2023 08:30 An: user@ofbiz.apache.org Betreff: Transaction Hi everybody, I have a question regarding transaction: I have a service that parses a big file and creates products from it. > 100.000 products If I do a TransactionUtil.commit() after each product, do I have to add a TransactionUtil.begin() for the next loop? - Service starts and creates a transaction - Product 1 --> commit - Product 2 --> commit or should I disable the service transaction via use-transaction="N" - Service starts - no transaction - begin --> Product 1 --> commit - begin --> Product 2 --> commit The goal is to reduce memory consumption. Best regards, Ingo
Transaction
Hi everybody, I have a question regarding transaction: I have a service that parses a big file and creates products from it. > 100.000 products If I do a TransactionUtil.commit() after each product, do I have to add a TransactionUtil.begin() for the next loop? - Service starts and creates a transaction - Product 1 --> commit - Product 2 --> commit or should I disable the service transaction via use-transaction="N" - Service starts - no transaction - begin --> Product 1 --> commit - begin --> Product 2 --> commit The goal is to reduce memory consumption. Best regards, Ingo
[jira] [Updated] (OFBIZ-12850) Duplicate class ... hot reload failed
[
https://issues.apache.org/jira/browse/OFBIZ-12850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ingo Wolfmayr updated OFBIZ-12850:
--
Description:
I have the problem, that with the current trunk, hot-reloading java code
failed.
Sometimes (I have not clue by now why not every-time) building the project
printed the following error and failed:
{noformat}
Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
duplicate handling strategy has been set. Please refer to
https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
for details.{noformat}
There is no duplicate groovy or java that could lead to
org/apache/ofbiz/accounting/GlEvents.class is a duplicate
I have not finished my investigation yet. If someone has an idea, please let me
know.
was:
I had the problem, that with the current trunk, hot-reloading java code failed.
Sometimes (I have not clue by now why not every-time) building the project
printed the following error and failed:
{noformat}
Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
duplicate handling strategy has been set. Please refer to
https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
for details.{noformat}
There is no duplicate groovy or java that could lead to
org/apache/ofbiz/accounting/GlEvents.class is a duplicate
Finally I added the following statement to build.gradle:
{code:java}
tasks.jar {
duplicatesStrategy(DuplicatesStrategy.EXCLUDE)
}{code}
Now it works again.
There are also three other options:
FAIL, INCLUDE, WARN
I have not finished my investigation yet. If someone has an idea, please let me
know.
> Duplicate class ... hot reload failed
> -
>
> Key: OFBIZ-12850
> URL: https://issues.apache.org/jira/browse/OFBIZ-12850
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Ingo Wolfmayr
>Priority: Major
>
> I have the problem, that with the current trunk, hot-reloading java code
> failed.
> Sometimes (I have not clue by now why not every-time) building the project
> printed the following error and failed:
> {noformat}
> Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
> duplicate handling strategy has been set. Please refer to
> https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
> for details.{noformat}
> There is no duplicate groovy or java that could lead to
> org/apache/ofbiz/accounting/GlEvents.class is a duplicate
> I have not finished my investigation yet. If someone has an idea, please let
> me know.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12850) Duplicate class ... hot reload failed
Ingo Wolfmayr created OFBIZ-12850:
-
Summary: Duplicate class ... hot reload failed
Key: OFBIZ-12850
URL: https://issues.apache.org/jira/browse/OFBIZ-12850
Project: OFBiz
Issue Type: Improvement
Reporter: Ingo Wolfmayr
I had the problem, that with the current trunk, hot-reloading java code failed.
Sometimes (I have not clue by now why not every-time) building the project
printed the following error and failed:
{noformat}
Entry org/apache/ofbiz/accounting/GlEvents.class is a duplicate but no
duplicate handling strategy has been set. Please refer to
https://docs.gradle.org/7.6/dsl/org.gradle.api.tasks.Copy.html#org.gradle.api.tasks.Copy:duplicatesStrategy
for details.{noformat}
There is no duplicate groovy or java that could lead to
org/apache/ofbiz/accounting/GlEvents.class is a duplicate
Finally I added the following statement to build.gradle:
{code:java}
tasks.jar {
duplicatesStrategy(DuplicatesStrategy.EXCLUDE)
}{code}
Now it works again.
There are also three other options:
FAIL, INCLUDE, WARN
I have not finished my investigation yet. If someone has an idea, please let me
know.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12847) Groovy refactoring correction
[ https://issues.apache.org/jira/browse/OFBIZ-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12847: -- Attachment: GroovyCorr.patch > Groovy refactoring correction > - > > Key: OFBIZ-12847 > URL: https://issues.apache.org/jira/browse/OFBIZ-12847 > Project: OFBiz > Issue Type: Improvement > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: GroovyCorr.patch > > > Some corrections due to groovy refactoring "mistakes". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12847) Groovy refactoring correction
Ingo Wolfmayr created OFBIZ-12847: - Summary: Groovy refactoring correction Key: OFBIZ-12847 URL: https://issues.apache.org/jira/browse/OFBIZ-12847 Project: OFBiz Issue Type: Improvement Reporter: Ingo Wolfmayr Attachments: GroovyCorr.patch Some corrections due to groovy refactoring "mistakes". -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: QR code creation
Hi Mandar,
I generate them in Java or Groovy, using the generateQRCodeImage service:
Map qrMap = UtilMisc.toMap("message", yourData,
"height", 200, "width", 200);
Map qrCodeResult =
this.dispatcher.runSync("generateQRCodeImage", qrMap);
if (qrCodeResult != null && qrCodeResult.get("bufferedImage") != null) {
BufferedImage qrCode = (BufferedImage)
qrCodeResult.get("bufferedImage");
...
}
Then use this image in the xsl-fo code.
Best regards,
Ingo
-Ursprüngliche Nachricht-
Von: Mandar K
Gesendet: Dienstag, 22. August 2023 19:51
An: ofbizuser
Betreff: QR code creation
Hi Team, requesting urgent input.
How to create QR code in pdf.
The one shown in the demo example is not working.
Thank you.
--
Regards
Mandar
Adaptability is the whole mystery of life - Swami Vivekanand
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756847#comment-17756847 ] Ingo Wolfmayr commented on OFBIZ-12639: --- Hi Jacques, I already have. As far as I have seen it re-renders a file that is temporary saved, but after the securedUpload method is triggerd the upload method uses the imageData from context. I was going to ask you about that anyway :) I don't see where the re-renderd image created by securedUpload is used. I work on linux (debian). The image that is re-rendered is stored in /tmp/... I have already an initial patch that works with the current setup but I have not gone through all cases. When uploading a productImage (Main) all generated scales run through securedUpload - I don't think that is necessary. If the original file passes, why should the scaled image (scaled by ofbiz) fail? I attached the current status of my patch. Just a few lines. You will see what I mean ;) > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: 4054.png, RerenderPatch_notready.patch, test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12639: -- Attachment: RerenderPatch_notready.patch > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: 4054.png, RerenderPatch_notready.patch, test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756482#comment-17756482 ] Ingo Wolfmayr commented on OFBIZ-12639: --- Hi Jacques, I will provide a patch. > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: 4054.png, test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[
https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756461#comment-17756461
]
Ingo Wolfmayr commented on OFBIZ-12639:
---
Hi Jacques,
I am currently focusing on images. When the image is uploaded and Extension,
Mime-Type is validated, we could re-render a new version of the image to ensure
to get rid of possible webshells. Like:
{code:java}
BufferedImage originalImage = ImageIO.read(inputFile);
ImageIO.write(originalImage, "jpg", outputFile);{code}
This works because only visible image data is carried over into the new image.
Metadata is removed.
As I am curious: how to you train users to upload images? 3 of ten images did
not work on my side while testing.
What do you think?
> Upload image size issue
> ---
>
> Key: OFBIZ-12639
> URL: https://issues.apache.org/jira/browse/OFBIZ-12639
> Project: OFBiz
> Issue Type: Improvement
> Components: product/catalog
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: 4054.png, test.jpeg
>
>
> I tied to uploaded an Image > 3MB and it fails as the line length > 1
> Does this security check make sense for images? Attached you will find the
> image.
> Additional to that, the security message is missleading: For security reason
> only valid files of supported image formats...
> Responsible code can be found in: SecuredUploads.java (line 205) &
> DataServices.java (line 216)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12639: -- Attachment: 4054.png > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: 4054.png, test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755953#comment-17755953 ] Ingo Wolfmayr commented on OFBIZ-12639: --- [~jleroux] There seems to be another issue with the SecureUpload. The "isValidImageFile" method includes the "isValidTextFile" method that inludes "isValidText". This method check for '+' and \"+\" Sometimes the source of an image includes these chars - there is no vicious purpose behind it + I do not see a solution how this can be prevented . It also happens that uploading an image creates image scales including these chars. The result is an uploaded "original" file but no scales. Would it be a bad idea to disable the "ALLOWSTRINGCONCATENATIONINUPLOADEDFILES" for certain types of files like images, pdf? Maybe in combination with an special upload permission? Does it even make sense with images, pdf? I want to keep the system on my side as secure as possible, but uploading an image should not presume a degree in computer science. > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Attachments: test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755949#comment-17755949 ] Ingo Wolfmayr commented on OFBIZ-12639: --- There seems to be another issue with the SecureUpload. > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (OFBIZ-12639) Upload image size issue
[ https://issues.apache.org/jira/browse/OFBIZ-12639 ] Ingo Wolfmayr deleted comment on OFBIZ-12639: --- was (Author: iwolf): There seems to be another issue with the SecureUpload. > Upload image size issue > --- > > Key: OFBIZ-12639 > URL: https://issues.apache.org/jira/browse/OFBIZ-12639 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: test.jpeg > > > I tied to uploaded an Image > 3MB and it fails as the line length > 1 > Does this security check make sense for images? Attached you will find the > image. > Additional to that, the security message is missleading: For security reason > only valid files of supported image formats... > Responsible code can be found in: SecuredUploads.java (line 205) & > DataServices.java (line 216) -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: POS Integration
Hi James, there is an option in entity ProductStore "IS_IMMEDIATELY_FULFILLED" that is used with POS. Best regards, Ingo -Ursprüngliche Nachricht- Von: ja...@productive1.com Gesendet: Dienstag, 8. August 2023 19:50 An: user@ofbiz.apache.org Betreff: POS Integration We are integrating a POS system to Ofbiz. One of the challenges is we want orders from POS to come in as Order w/ Payment inside of Ofbiz but these orders do not require inventory reservation or the shipping process. What should happen is the order comes in and decreases inventory immediately and create a closed invoice. Is this possible? Thanks, James
AW: Job priority
Hi Nicolas, thanks for the Info. Best regards, ingo Von: Nicolas Malin Gesendet: Donnerstag, 15. Juni 2023 09:12 An: user@ofbiz.apache.org; Ingo Wolfmayr Betreff: Re: Job priority Hello Ingo, At this time no priority are present on service job. For our part, when this appear we deploy a dedicate ofbiz with it own pool for high level job. We also thinking about increase the capacity for the service engine to manage job (sharing charge, priority, dedicate pool) but not take the time o implement. Nicolas Le 15/06/2023 à 08:44, Ingo Wolfmayr a écrit : Hi everybody, I have seen that there is an option to define the priority of a job (LOW, HIGH, NORMAL). Where and how is it supposed to be set. For example I have the job "addToSolr" set as async eca and want it to run with low priority. Sending e-mail confirmations should be run with higher priority. Best regards, Ingo
Job priority
Hi everybody, I have seen that there is an option to define the priority of a job (LOW, HIGH, NORMAL). Where and how is it supposed to be set. For example I have the job "addToSolr" set as async eca and want it to run with low priority. Sending e-mail confirmations should be run with higher priority. Best regards, Ingo
AW: Editing Inventory Items
Hi Emad, I start with the second question: For example: You may have produced the inventory yourself and just added it with the form. You can also create an Inventory Item via the manufacturing app without the use of purchase orders. First: I had cases where the productId of a product has changed (new company productId-pattern ...). Just created the new product and update the inventoryItem to the new product and here we go. I have implemented use-case where the inventory becomes another product before it expires - different logic applies. Therefore I replace the productId with the new one. The purchase order won't change when you update the InventoryItem entity. You will still see the InventoryItem applied to the purchase order and if you dig deeper you will see that the product relation has changed. The productId + product name and more is stored in the OrderItem entity. It will stay unchanged. + you can easily update the field to "readOnly" in the source code. Best regards, Ingo -Ursprüngliche Nachricht- Von: Emad Radwan Gesendet: Montag, 15. Mai 2023 15:20 An: user@ofbiz.apache.org Betreff: Editing Inventory Items Hello Community, Part of the columns that Ofbiz allows to edit is the Product. I'm not getting the use case behind this, Won't it affect the consistency of the Purchase Order related to inventory item? Also - from business perspective - I can understand why I would need to edit the inventory item but when I'll need to create it from scratch without a purchase order? Regards, Emad
AW: Working with multiple facilities
Hi Emad, you can create multiple facilities and assign inventory to the facility (down to the place in the storage rack). The inventory entity has a relation from the product to the facility. You can have the same product as stock (inventory) in multiple facilities. In the facility app you will find everything to move inventory between locations or pack & ship to the customer. If you use it with a product store you can configure it to use multiple facility + inventory pick logic (FIFO, ...) If you lookup the product you will find a tab called "Inventory". Here you will find an overview of your product stock by facility. If you select a facility in the facility app you will work with that facility - process all shippings from that facility. Move inventory from that faciilty to ... Best regards Ingo -Ursprüngliche Nachricht- Von: Emad Radwan Gesendet: Mittwoch, 10. Mai 2023 15:47 An: user@ofbiz.apache.org Betreff: Working with multiple facilities Hello Community, How to work with multiple facilities at the same time? Like moving inventory from facility A to facility B, show inventory by product in all of our inventories, etc? Ofbiz - in the facility - module starts by prompting for which facility to work with and all proceeding functionality will be based on that one facility! I'm sure that I'm missing something here, please help. Regards, Emad
AW: How to disable a Promo
Hi Emad, a promo is assigned to one or more productStore/s - you can find the relation under the tab "stores". Here you can delete the relation or assign a through-date. Best regards, Ingo -Ursprüngliche Nachricht- Von: Emad Radwan Gesendet: Dienstag, 9. Mai 2023 21:35 An: user@ofbiz.apache.org Betreff: How to disable a Promo Hello Comunity, Where is the UI I can disable - temporarily / permanently - a promo, so Ofbiz skips adding the promo product automatically to the order? Regards, Emad
AW: TO ACCESS THE MULTI-TENANT INSTANCES USING SUB-DOMAINS
Hi Sumesh, that is quite easy. You have to create an entry in table TENANT_DOMAIN_NAME. This can be done 1.) while creating the tenant: gradlew createTenant -PtenantId=mytenant -PtenantName="My Name" -PdomainName=com.example 2.) by adding the entry manually into the database (you still need to create the tenant before) + enable multitenant support in general.properties. That’s it. Best regards, Ingo -Ursprüngliche Nachricht- Von: Sumesh R Acharya <7.sumesh...@gmail.com> Gesendet: Samstag, 22. April 2023 09:36 An: user@ofbiz.apache.org Betreff: TO ACCESS THE MULTI-TENANT INSTANCES USING SUB-DOMAINS Hello community, I gone through the document where instruction are given to configure and use the nginx as the reverse proxy for the ofbiz single tenant. LINK :- https://gist.github.com/bagasme/1de1908c86303c83b7bd51d50a12e041 But i want to know like what configuration i have to make in the ofbiz so that i can access two tenants using different sub domains using similar approach that is there for the single tenant (using nginx) Example: tenant1.example.com -> should point to tenant1 tenant2.example.com -> should point to tenant2 Regards, Sumeshwol
AW: Job Detail
Hi Dan, thanks for your reponse. The problem was with the "cus-obj" in the runtimeData - (visualTheme, timeZone). I wrote a little script to update the values. Now it works. Every job without runtimeData is fine. Best regards, Ingo -Ursprüngliche Nachricht- Von: Daniel Watford Gesendet: Freitag, 24. März 2023 23:06 An: user@ofbiz.apache.org Betreff: Re: Job Detail Hi Ingo, What version of OFBiz did you migrate from? If from a version prior to 18, these pages might help: - https://cwiki.apache.org/confluence/display/OFBIZ/Data+Migration+by+releases - https://cwiki.apache.org/confluence/display/OFBIZ/Revisions+Requiring+Data+Migration+-+upgrade+ofbiz If you went from version 18 to trunk, we can try and replicate the issue you are seeing. Thanks, Dan. On Fri, 24 Mar 2023 at 18:02, Ingo Wolfmayr wrote: > Hi community, > > I have migrated an ofbiz installation to the trunk version. When I > open an existing job I get: > > java.lang.IllegalArgumentException: Error running script at location > [component://webtools/groovyScripts/service/JobDetails.groovy]: > org.apache.ofbiz.entity.serialize.SerializeException: Problem > deserializing object from byte array + cus-obj > > Creating the same job anew, it works fine. Is there some upgrade stuff > i missed? > > Thanks, > Ingo > -- Daniel Watford
Job Detail
Hi community, I have migrated an ofbiz installation to the trunk version. When I open an existing job I get: java.lang.IllegalArgumentException: Error running script at location [component://webtools/groovyScripts/service/JobDetails.groovy]: org.apache.ofbiz.entity.serialize.SerializeException: Problem deserializing object from byte array + cus-obj Creating the same job anew, it works fine. Is there some upgrade stuff i missed? Thanks, Ingo
[jira] [Created] (OFBIZ-12780) Tax rate from shipping address when taxInPrice = "Y"
Ingo Wolfmayr created OFBIZ-12780: - Summary: Tax rate from shipping address when taxInPrice = "Y" Key: OFBIZ-12780 URL: https://issues.apache.org/jira/browse/OFBIZ-12780 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Fix For: Upcoming Branch Attachments: eutax-1.patch, taxexample.jpg *Case:* shipment from AUT (20% sales tax) to DEU (19% sales tax). *Now:* Productprice with taxInPrice = "N": tax calculated according to taxRateProduct definition --> ok Productprice with taxInPrice = "Y": if productPrice for target country exists --> ok, if not, the productStore tax setting is used. *Goal:* Calculate VAT for tax taken from shipment target + add price adjustment. *Example:* Gross price: € 14,80 (20% sales tax - default price) Order: Unit price: € 14,80 Tax: € 2,47 (19%) OrderAdjustment (item): € -0,127 When done, the order result will be the same as when using taxInPrice = "N" *Testing:* # create product + productprice (taxInPrice="Y") # create order with shipping address geoId different to productprice taxAuthGeoId # --> Ofbiz will then create the order item adjustments Reason: Administration of multiple prices due to different taxes may be quite time consuming. For example selling from one country within the EU to another EU country (27) will result in 27 listprices and 27 default prices for a single product. EU law for example obligates the seller to apply the shipping target tax rate on the invoice. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12779) Metadescription to plain text
Ingo Wolfmayr created OFBIZ-12779: - Summary: Metadescription to plain text Key: OFBIZ-12779 URL: https://issues.apache.org/jira/browse/OFBIZ-12779 Project: OFBiz Issue Type: Improvement Components: ecommerce, order Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Fix For: Upcoming Branch Attachments: metadescription.patch I have enabled minimal HTML Editor (Linebreak, bold, italic) for the product and productcategory description. Both descriptions are used for the metaDescription value used on html pages. Unfortunately they break the page header if they are not plain text. The attached patch would fix this issue and ensure the metaDescription comes without HTML entities. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12773) Async Service with multiple tenants - tenant null
[
https://issues.apache.org/jira/browse/OFBIZ-12773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ingo Wolfmayr updated OFBIZ-12773:
--
Description:
{*}System{*}: clean ofbiz trunk, Java 17
{*}Tenants{*}: demo, zdemo - both with demo data
DB: derby (issue not db related - same issue with mysq)
{code:java}
./gradlew createTenant -PtenantId=zdemo
./gradlew createTenant -PtenantId=demo
./gradlew loadTenant -PtenantId=demo -PtenantReaders=seed,seed-initial,demo
./gradlew loadTenant -PtenantId=zdemo -PtenantReaders=seed,seed-initial,demo
./gradlew ofbiz{code}
Attached is a "patch" with the service for testing and the tenant settings in
entityengine.xml.
I use two different browsers to login to both tenants.
*Tenant demo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run the first 100 jobs (100 jobs defined in
serviceengine.xml). After some seconds will run the final 100 jobs. All jobs
will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:13 - demo
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:195 - demo{code}
*Tenant xdemo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run through all 200 jobs (100 jobs defined in
serviceengine.xml). Only 100 jobs will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@495392e0
TENANT:13 - null
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@44fe81d9
TENANT:195 - zdemo{code}
It seems the the last tenant (zdemo) has a problem.
*The problem with this:* everything run in this jobs that require tenant
specific logic will fail.
I would appreciate every thought on this as I am a little bit clueless right
now (after hours and hours of debugging why my jobs fail ;)).
{*}Update{*}: when using rest-api plugin it is possible to connect to the zdemo
tenant without any tenant information.
was:
{*}System{*}: clean ofbiz trunk, Java 17
{*}Tenants{*}: demo, zdemo - both with demo data
DB: derby (issue not db related - same issue with mysq)
{code:java}
./gradlew createTenant -PtenantId=zdemo
./gradlew createTenant -PtenantId=demo
./gradlew loadTenant -PtenantId=demo -PtenantReaders=seed,seed-initial,demo
./gradlew loadTenant -PtenantId=zdemo -PtenantReaders=seed,seed-initial,demo
./gradlew ofbiz{code}
Attached is a "patch" with the service for testing and the tenant settings in
entityengine.xml.
I use two different browsers to login to both tenants.
*Tenant demo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run the first 100 jobs (100 jobs defined in
serviceengine.xml). After some seconds will run the final 100 jobs. All jobs
will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:13 - demo
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:195 - demo{code}
*Tenant xdemo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run through all 200 jobs (100 jobs defined in
serviceengine.xml). Only 100 jobs will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@495392e0
TENANT:13 - null
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@44fe81d9
TENANT:195 - zdemo{code}
It seems the the last tenant (zdemo) has a problem.
*The problem with this:* everything run in this jobs that require tenant
specific logic will fail.
I would appreciate every thought on this as I am a little bit clueless right
now (after hours and hours of debugging why my jobs fail ;)).
> Async Service with multiple tenants - tenant null
> -
>
> Key: OFBIZ-12773
> URL: https://issues.apache.org/jira/browse/OFBIZ-12773
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: testsettings.patch
>
>
> {*}System{*}: clean ofbiz trunk, Java 17
> {*}Tenants{*}: demo, zdemo - both with demo data
> DB: derby (issue not db related - same issue with mysq)
> {code:java}
> ./gradlew createTenant -PtenantId=zdemo
> ./gradlew createTenant -PtenantId=demo
&
RestApi Plugin - Tenant
Hi Communitiy, is it possible to use the restApi with multi-tenant support? Best regards, Ingo
[jira] [Commented] (OFBIZ-12772) Setting verbose log results in 500
[
https://issues.apache.org/jira/browse/OFBIZ-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699188#comment-17699188
]
Ingo Wolfmayr commented on OFBIZ-12772:
---
I have created a patch to have verbose mode working again.
> Setting verbose log results in 500
> --
>
> Key: OFBIZ-12772
> URL: https://issues.apache.org/jira/browse/OFBIZ-12772
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: verbose.patch
>
>
> When changing debug.properties
> print.verbose=true
> will bring up the following error when accessing any application:
> for example: [https://localhost:8443/catalog/control/main]
> Tested on: trunk, java 17
> {code:java}
> Mar 07, 2023 5:20:53 PM org.apache.catalina.core.StandardWrapperValve invoke
> SEVERE: Servlet.service() for servlet [ControlServlet] in context with path
> [/webtools] threw exception
> java.lang.ArrayStoreException: javax.servlet.http.Cookie
> at
> java.base/java.util.stream.Nodes$FixedNodeBuilder.accept(Nodes.java:1222)
> at
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)
> at
> java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12772) Setting verbose log results in 500
[
https://issues.apache.org/jira/browse/OFBIZ-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ingo Wolfmayr updated OFBIZ-12772:
--
Attachment: verbose.patch
> Setting verbose log results in 500
> --
>
> Key: OFBIZ-12772
> URL: https://issues.apache.org/jira/browse/OFBIZ-12772
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: verbose.patch
>
>
> When changing debug.properties
> print.verbose=true
> will bring up the following error when accessing any application:
> for example: [https://localhost:8443/catalog/control/main]
> Tested on: trunk, java 17
> {code:java}
> Mar 07, 2023 5:20:53 PM org.apache.catalina.core.StandardWrapperValve invoke
> SEVERE: Servlet.service() for servlet [ControlServlet] in context with path
> [/webtools] threw exception
> java.lang.ArrayStoreException: javax.servlet.http.Cookie
> at
> java.base/java.util.stream.Nodes$FixedNodeBuilder.accept(Nodes.java:1222)
> at
> java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
> at
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
> at
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
> at
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)
> at
> java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12773) Async Service with multiple tenants - tenant null
Ingo Wolfmayr created OFBIZ-12773:
-
Summary: Async Service with multiple tenants - tenant null
Key: OFBIZ-12773
URL: https://issues.apache.org/jira/browse/OFBIZ-12773
Project: OFBiz
Issue Type: Improvement
Affects Versions: Upcoming Branch
Reporter: Ingo Wolfmayr
Attachments: testsettings.patch
{*}System{*}: clean ofbiz trunk, Java 17
{*}Tenants{*}: demo, zdemo - both with demo data
DB: derby (issue not db related - same issue with mysq)
{code:java}
./gradlew createTenant -PtenantId=zdemo
./gradlew createTenant -PtenantId=demo
./gradlew loadTenant -PtenantId=demo -PtenantReaders=seed,seed-initial,demo
./gradlew loadTenant -PtenantId=zdemo -PtenantReaders=seed,seed-initial,demo
./gradlew ofbiz{code}
Attached is a "patch" with the service for testing and the tenant settings in
entityengine.xml.
I use two different browsers to login to both tenants.
*Tenant demo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run the first 100 jobs (100 jobs defined in
serviceengine.xml). After some seconds will run the final 100 jobs. All jobs
will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:13 - demo
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@38b821e9
TENANT:195 - demo{code}
*Tenant xdemo:*
Then goto "webtools" --> "service engine" -->"run service": enter testx -->
submit
Result: ofbiz will run through all 200 jobs (100 jobs defined in
serviceengine.xml). Only 100 jobs will print the tenantId.
{code:java}
DISPATCHER:13 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@495392e0
TENANT:13 - null
DISPATCHER:195 -
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher@44fe81d9
TENANT:195 - zdemo{code}
It seems the the last tenant (zdemo) has a problem.
*The problem with this:* everything run in this jobs that require tenant
specific logic will fail.
I would appreciate every thought on this as I am a little bit clueless right
now (after hours and hours of debugging why my jobs fail ;)).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Async Service Issue with tenant
Hi Community, I hope someone my give me a hint to solve the following problem: I have ofbiz with tenant enabled. I have multiple tenants. For testing I create a service the calls another service async in a loop (200 times). The service just prints the tenantId. In 2 of 3 tenant it works fine: as defined in serviceengine.xml the async jobs are called in packs of 100 and the tenantId is printed. In the third tenant all 200 jobs are called at once. The tenantId is only printed for the first 100 jobs. The rest prints null. Any idea where that comes from? Best regards, Ingo
[jira] [Created] (OFBIZ-12772) Setting verbose log results in 500
Ingo Wolfmayr created OFBIZ-12772:
-
Summary: Setting verbose log results in 500
Key: OFBIZ-12772
URL: https://issues.apache.org/jira/browse/OFBIZ-12772
Project: OFBiz
Issue Type: Improvement
Affects Versions: Upcoming Branch
Reporter: Ingo Wolfmayr
When changing debug.properties
print.verbose=true
will bring up the following error when accessing any application:
for example: [https://localhost:8443/catalog/control/main]
Tested on: trunk, java 17
{code:java}
Mar 07, 2023 5:20:53 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [ControlServlet] in context with path
[/webtools] threw exception
java.lang.ArrayStoreException: javax.servlet.http.Cookie
at java.base/java.util.stream.Nodes$FixedNodeBuilder.accept(Nodes.java:1222)
at
java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at
java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at
java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at
java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)
at
java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
AW: Async Services
Ok, just found that not all added services fail. If I add 100 jobs it works as
in serviceengine the value "jobs" == 100. If I add 200 jobs, 100 will fail. If
I change the jobs value to 50, 50 of 100 will fail. I have to check why. Does
not make sense to me right now.
Thanks for your help.
Best regards,
Ingo
-Ursprüngliche Nachricht-
Von: Ingo Wolfmayr
Gesendet: Dienstag, 7. März 2023 09:52
An: user@ofbiz.apache.org
Betreff: AW: Async Services
Hi Michael,
the dispatcher is available when the script is called (it’s a groovy service
that calls another service - async). The async service is added to the
jobSandbox.
When it is started, the job is missing dispatcher: dctx.getDispatcher()
In a loop:
Map serviceCtxx = [:]
serviceCtxx.put("instance", p)
serviceCtxx.put("userLogin", userLogin)
dispatcher.runAsync('addToSolr', serviceCtxx)
I use webtools to run the service above. In the example the addToSolr service
is added to the jobSandbox and fails.
Best regards
Ingo
-Ursprüngliche Nachricht-
Von: Michael Brohl
Gesendet: Dienstag, 7. März 2023 09:32
An: user@ofbiz.apache.org
Betreff: Re: Async Services
Hi Ingo,
with a dispatcher of null, I wonder how it should be possible to run a service
(synx or async)?
If it is a groovy script in the context of a screen, you should have dispatcher
and delegator available. Else you should provide more information of the
process/code.
I am not aware of any additional data you have to provide. The service engine
just takes the provided service context and stores it as RuntimeData together
with the job in the JobSandbox instead of running the service directly.
Best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 07.03.23 um 09:16 schrieb Ingo Wolfmayr:
> Hi Michael,
>
> thanks for the fast response. I have one more question:
>
> I created a services that is fired inside a groovy script - async. When I
> define persist = "true" the dispatcher is null / delegator not defined. I use
> tenants.
>
> Sync works.
> Async with persist = false works
> Async with persist = true fails
>
> Did I miss something? Should I pass some specific data to the service when
> using persist = true?
>
> Best regards,
> Ingo
>
> -Ursprüngliche Nachricht-
> Von: Michael Brohl
> Gesendet: Dienstag, 7. März 2023 08:57
> An: user@ofbiz.apache.org
> Betreff: Re: Async Services
>
> Hi Ingo,
>
> with persist = true, the async service will be persisted in the Job Sandbox
> and executed, els it will only be executed.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 07.03.23 um 08:24 schrieb Ingo Wolfmayr:
>> Hi Michael,
>>
>> sorry "persist".
>>
>> Best regards,
>> Ingo
>>
>> -Ursprüngliche Nachricht-
>> Von: Michael Brohl
>> Gesendet: Dienstag, 7. März 2023 08:21
>> An: user@ofbiz.apache.org
>> Betreff: Re: Async Services
>>
>> Hi Ingo,
>>
>> where did you find this option and for which version?
>>
>> Best regards,
>>
>> Michael
>>
>> Am 07.03.23 um 08:04 schrieb Ingo Wolfmayr:
>>> Hi Community,
>>>
>>> I would like to know what is the difference between an async service with
>>> option set "permit = true" or "permit = false".
>>>
>>> Best regards,
>>> Ingo
>>>
AW: Async Services
Hi Michael,
the dispatcher is available when the script is called (it’s a groovy service
that calls another service - async). The async service is added to the
jobSandbox.
When it is started, the job is missing dispatcher: dctx.getDispatcher()
In a loop:
Map serviceCtxx = [:]
serviceCtxx.put("instance", p)
serviceCtxx.put("userLogin", userLogin)
dispatcher.runAsync('addToSolr', serviceCtxx)
I use webtools to run the service above. In the example the addToSolr service
is added to the jobSandbox and fails.
Best regards
Ingo
-Ursprüngliche Nachricht-
Von: Michael Brohl
Gesendet: Dienstag, 7. März 2023 09:32
An: user@ofbiz.apache.org
Betreff: Re: Async Services
Hi Ingo,
with a dispatcher of null, I wonder how it should be possible to run a service
(synx or async)?
If it is a groovy script in the context of a screen, you should have dispatcher
and delegator available. Else you should provide more information of the
process/code.
I am not aware of any additional data you have to provide. The service engine
just takes the provided service context and stores it as RuntimeData together
with the job in the JobSandbox instead of running the service directly.
Best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 07.03.23 um 09:16 schrieb Ingo Wolfmayr:
> Hi Michael,
>
> thanks for the fast response. I have one more question:
>
> I created a services that is fired inside a groovy script - async. When I
> define persist = "true" the dispatcher is null / delegator not defined. I use
> tenants.
>
> Sync works.
> Async with persist = false works
> Async with persist = true fails
>
> Did I miss something? Should I pass some specific data to the service when
> using persist = true?
>
> Best regards,
> Ingo
>
> -Ursprüngliche Nachricht-
> Von: Michael Brohl
> Gesendet: Dienstag, 7. März 2023 08:57
> An: user@ofbiz.apache.org
> Betreff: Re: Async Services
>
> Hi Ingo,
>
> with persist = true, the async service will be persisted in the Job Sandbox
> and executed, els it will only be executed.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 07.03.23 um 08:24 schrieb Ingo Wolfmayr:
>> Hi Michael,
>>
>> sorry "persist".
>>
>> Best regards,
>> Ingo
>>
>> -Ursprüngliche Nachricht-
>> Von: Michael Brohl
>> Gesendet: Dienstag, 7. März 2023 08:21
>> An: user@ofbiz.apache.org
>> Betreff: Re: Async Services
>>
>> Hi Ingo,
>>
>> where did you find this option and for which version?
>>
>> Best regards,
>>
>> Michael
>>
>> Am 07.03.23 um 08:04 schrieb Ingo Wolfmayr:
>>> Hi Community,
>>>
>>> I would like to know what is the difference between an async service with
>>> option set "permit = true" or "permit = false".
>>>
>>> Best regards,
>>> Ingo
>>>
AW: Async Services
Hi Michael, thanks for the fast response. I have one more question: I created a services that is fired inside a groovy script - async. When I define persist = "true" the dispatcher is null / delegator not defined. I use tenants. Sync works. Async with persist = false works Async with persist = true fails Did I miss something? Should I pass some specific data to the service when using persist = true? Best regards, Ingo -Ursprüngliche Nachricht- Von: Michael Brohl Gesendet: Dienstag, 7. März 2023 08:57 An: user@ofbiz.apache.org Betreff: Re: Async Services Hi Ingo, with persist = true, the async service will be persisted in the Job Sandbox and executed, els it will only be executed. Best regards, Michael Brohl ecomify GmbH - www.ecomify.de Am 07.03.23 um 08:24 schrieb Ingo Wolfmayr: > Hi Michael, > > sorry "persist". > > Best regards, > Ingo > > -Ursprüngliche Nachricht- > Von: Michael Brohl > Gesendet: Dienstag, 7. März 2023 08:21 > An: user@ofbiz.apache.org > Betreff: Re: Async Services > > Hi Ingo, > > where did you find this option and for which version? > > Best regards, > > Michael > > Am 07.03.23 um 08:04 schrieb Ingo Wolfmayr: >> Hi Community, >> >> I would like to know what is the difference between an async service with >> option set "permit = true" or "permit = false". >> >> Best regards, >> Ingo >>
AW: Async Services
Hi Michael, sorry "persist". Best regards, Ingo -Ursprüngliche Nachricht- Von: Michael Brohl Gesendet: Dienstag, 7. März 2023 08:21 An: user@ofbiz.apache.org Betreff: Re: Async Services Hi Ingo, where did you find this option and for which version? Best regards, Michael Am 07.03.23 um 08:04 schrieb Ingo Wolfmayr: > Hi Community, > > I would like to know what is the difference between an async service with > option set "permit = true" or "permit = false". > > Best regards, > Ingo >
Async Services
Hi Community, I would like to know what is the difference between an async service with option set "permit = true" or "permit = false". Best regards, Ingo
[jira] [Created] (OFBIZ-12770) Pull plugin failed
Ingo Wolfmayr created OFBIZ-12770:
-
Summary: Pull plugin failed
Key: OFBIZ-12770
URL: https://issues.apache.org/jira/browse/OFBIZ-12770
Project: OFBiz
Issue Type: Improvement
Components: ALL PLUGINS
Reporter: Ingo Wolfmayr
{*}example{*}: ./gradlew pullPluginSource -PpluginId=ecommerce
{*}result{*}:
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pullPluginFromSvn'.
> svn-checkout failed for
> https://github.com/apache/ofbiz-plugins/branches/master/ecommerce
svn: E17: URL
'https://github.com/apache/ofbiz-plugins/branches/master/ecommerce' doesn't
exist
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
AW: Service availability for tenant
Hi Rishi, thanks, I will see what I can do :) Best regards Ingo Mag. (FH) Ingo Wolfmayr Wolfix Solutions Gänsgasse 14 A-5282 Ranshofen Tel.: +43 (0) 664 2549626 Web: https://www.wolfix.at Xing: https://www.xing.com/profile/Ingo_Wolfmayr/ -Ursprüngliche Nachricht- Von: Rishi Solanki Gesendet: Donnerstag, 23. Februar 2023 19:32 An: user@ofbiz.apache.org Betreff: Re: Service availability for tenant Hi Ingo, Yes it is possible but not out of the box available you need to add a config entity which decides this and minor modification in the code. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> On Thu, Feb 16, 2023 at 6:33 PM Ingo Wolfmayr wrote: > Hi Community, > > > > is it possible to make a service only available for a specific tenant. > I have create a custom plugin want the service to be available only > for the specific tenant. > > > > Best regards, > > Ingo > > > > > > > >
[jira] [Created] (OFBIZ-12759) CreatePaymentFromOrder issue with autocreate = N
Ingo Wolfmayr created OFBIZ-12759: - Summary: CreatePaymentFromOrder issue with autocreate = N Key: OFBIZ-12759 URL: https://issues.apache.org/jira/browse/OFBIZ-12759 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Fix For: Upcoming Branch Attachments: createPaymentFromOrder.patch Using the service "createPaymentFromOrder" with accounting.payment.purchaseorder.autocreate or accounting.payment.salesorder.autocreate set to "N" returns an error. >From my view it would be correct to return success/failure as by configuration >it is not an error. The problem: when changing the order status a SECAS will fire the service which will fire the error and rollback everything. Using "failure" would be the better option. Additionally to that, it would be nice if the autocreate setting can be set in SystemProperty entity for use with multiple tenants. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Service availability for tenant
Hi Community, is it possible to make a service only available for a specific tenant. I have create a custom plugin want the service to be available only for the specific tenant. Best regards, Ingo
AW: Manual for distribution build
Hi Nicolas, thanks! Best regards Ingo Von: Nicolas Malin Gesendet: Freitag, 3. Februar 2023 14:12 An: user@ofbiz.apache.org; Ingo Wolfmayr Betreff: Re: Manual for distribution build You can use it on production site with systemd, untar on /opt and uste it like # nano /etc/systemd/system/ofbiz.service [Unit] Description=OFBiz [Service] Type=exec User=ofbiz WorkingDirectory=/opt/ofbiz/ EnvironmentFile=/etc/default/ofbiz ExecStart=/usr/bin/ofbiz -u ExecStop=/usr/bin/ofbiz -d [Install] WantedBy=multi-user.target # ln -s /opt/ofbiz/bin/ofbiz /usr/bin/ofbiz # systemctl daemon-reload # systemctl start ofbiz Nicolas On 03/02/2023 13:38, Ingo Wolfmayr wrote: Hi Community, is there a description what can be done with the ofbiz.tar/zip files in build/distribution. Best regards, Ingo Mag. (FH) Ingo Wolfmayr Wolfix Solutions Gänsgasse 14 A-5282 Ranshofen Tel.: +43 (0) 664 2549626 Web: https://www.wolfix.at<https://www.wolfix.at/> Xing: https://www.xing.com/profile/Ingo_Wolfmayr/ [emailsignatur]
[jira] [Commented] (OFBIZ-12751) Imagepreview - Content Management
[ https://issues.apache.org/jira/browse/OFBIZ-12751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684193#comment-17684193 ] Ingo Wolfmayr commented on OFBIZ-12751: --- Great, thanks!!! > Imagepreview - Content Management > - > > Key: OFBIZ-12751 > URL: https://issues.apache.org/jira/browse/OFBIZ-12751 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog, themes/helveticus >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 22.01.01 > > Attachments: imagemanagement.patch, preview.jpg > > > It would be nice, if the image preview in "image management" would be > displayed in thumbnail size. > /catalog/control/ListImageManage?productId > The full size image can be displayed via the "view" button. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684192#comment-17684192 ] Ingo Wolfmayr commented on OFBIZ-12750: --- Thanks Jacques!!! > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Fix For: 22.01.01 > > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[
https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683983#comment-17683983
]
Ingo Wolfmayr commented on OFBIZ-12750:
---
Hi
Jacques,[|https://demo-trunk.ofbiz.apache.org/catalog/control/EditProduct?productId=GZ-1001]
go to product GZ-1001 --> Content tab
[https://demo-trunk.ofbiz.apache.org/catalog/control/EditProductContent?productId=GZ-1001]
Upload the png file attached or any other png file with transparent background.
Problem is the following line:
BufferedImage sanitizedImage = new
BufferedImage(initialSizedImage.getWidth(null),
initialSizedImage.getHeight(null),BufferedImage.{color:#de350b}*TYPE_INT_RGB*{color});
> Product Image PNG - Black Background
>
>
> Key: OFBIZ-12750
> URL: https://issues.apache.org/jira/browse/OFBIZ-12750
> Project: OFBiz
> Issue Type: Improvement
> Components: product/catalog
>Affects Versions: Upcoming Branch
> Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Lyke CF SE.png, png.patch
>
>
> When uploading an png image to a product (default image), transparent
> background becomes black.
> [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original]
> Uploading the same image as content or via image management works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Manual for distribution build
Hi Community, is there a description what can be done with the ofbiz.tar/zip files in build/distribution. Best regards, Ingo Mag. (FH) Ingo Wolfmayr Wolfix Solutions Gänsgasse 14 A-5282 Ranshofen Tel.: +43 (0) 664 2549626 Web: https://www.wolfix.at<https://www.wolfix.at/> Xing: https://www.xing.com/profile/Ingo_Wolfmayr/ [emailsignatur]
[jira] [Created] (OFBIZ-12751) Imagepreview - Content Management
Ingo Wolfmayr created OFBIZ-12751: - Summary: Imagepreview - Content Management Key: OFBIZ-12751 URL: https://issues.apache.org/jira/browse/OFBIZ-12751 Project: OFBiz Issue Type: Improvement Components: product/catalog, themes/helveticus Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Attachments: imagemanagement.patch, preview.jpg It would be nice, if the image preview in "image management" would be displayed in thumbnail size. /catalog/control/ListImageManage?productId The full size image can be displayed via the "view" button. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17682662#comment-17682662 ] Ingo Wolfmayr commented on OFBIZ-12750: --- Attached a patch to resolve the issue. > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12750) Product Image PNG - Black Background
[ https://issues.apache.org/jira/browse/OFBIZ-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12750: -- Attachment: png.patch > Product Image PNG - Black Background > > > Key: OFBIZ-12750 > URL: https://issues.apache.org/jira/browse/OFBIZ-12750 > Project: OFBiz > Issue Type: Improvement > Components: product/catalog >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Lyke CF SE.png, png.patch > > > When uploading an png image to a product (default image), transparent > background becomes black. > [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] > Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12750) Product Image PNG - Black Background
Ingo Wolfmayr created OFBIZ-12750: - Summary: Product Image PNG - Black Background Key: OFBIZ-12750 URL: https://issues.apache.org/jira/browse/OFBIZ-12750 Project: OFBiz Issue Type: Improvement Components: product/catalog Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Attachments: Lyke CF SE.png When uploading an png image to a product (default image), transparent background becomes black. [https://demo-trunk.ofbiz.apache.org/catalog/control/UploadProductImage?productId=WG-9943-B3_file_type=original] Uploading the same image as content or via image management works. -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: Sales Order Invoice Due in the future
Hi, I assume by due date you mean "ship after"? For creating invoices before shipping is done I use the service "createInvoiceForOrderAllItems". Important related tables are: OrderItemBilling ItemIssuance Hope that helps. Best regards Ingo -Ursprüngliche Nachricht- Von: Bs Serge Gesendet: Freitag, 9. Dezember 2022 14:59 An: user@ofbiz.apache.org Betreff: Sales Order Invoice Due in the future Hi all, How to create a sales invoice to a customer for a placed order that has a due date of a certain specific date in the future? I can create an order separately and then create a sales invoice separately with the item, but I want that sales invoice to be related to the created order. There is a way to relate invoice items to an order as I can see in the invoice items table but I can't figure how to relate them even while adding invoice items. Best regards,
[jira] [Created] (OFBIZ-12707) Picklist with same product multiple times
Ingo Wolfmayr created OFBIZ-12707: - Summary: Picklist with same product multiple times Key: OFBIZ-12707 URL: https://issues.apache.org/jira/browse/OFBIZ-12707 Project: OFBiz Issue Type: Improvement Components: product/facility Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Attachments: Picklist.patch Create an order with the same product in different order item lines - for example with different amount, comment. Goto Facility --> Pack shipment --> Enter orderId You will see two lines with the same product. Enter the productId into the input box (leave quantity 1) and click pack item. You will receive an error message saying the quantity is not available for this packing item ... The attached patch enables packing with the above setting. That's important if you have the situation that products can't be grouped by orderSeqId (order item comments, amounts ...). -- This message was sent by Atlassian Jira (v8.20.10#820010)
AW: Question about invoices
Hi Emad, here some examples how I sometimes use it: - order is created in another system. I have usecases where the data is provided via data interface and Ofbiz generates the invoice and everything accounting related. - quickly create a credit invoice - repeating invoice for exampe IT services (domain, hosting ...) - Invoices from work effort (for example from helpdesk) Best regards, Ingo -Ursprüngliche Nachricht- Von: Emad Radwan Gesendet: Sonntag, 18. September 2022 16:56 An: user@ofbiz.apache.org Betreff: Question about invoices Hello Community, Sorry for the newbie question. Why is there a feature to create an invoice - e.g. sales invoice - from the Accounting tab and outside the normal route from Sales Order? What is the use case to start with the invoice first? Regards, Emad
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606098#comment-17606098 ] Ingo Wolfmayr commented on OFBIZ-12390: --- Hi Jacques, I create a new patch. Best regards, Ingo > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: cartRounding.patch > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: (was: cartRounding.patch) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606074#comment-17606074 ] Ingo Wolfmayr commented on OFBIZ-12390: --- [~jamesyong] : the order calculation and invoice calculation are correct and the results are even. Creating an invoice from an order will add all necessary adjustments (like VAT_CORRECTION). I did not see any problem here. The order payment preference uses the cart "displayGrandTotal" to create the value. Using the cart (ecommerce, update order, webpos ...) the displayGrandTotal with the example provided will always result in a different value. The order items are stored with 3 decimals. The problem, as far as I can see, is not a missing adjustment but a different logic/timing in rounding when summing up the order/cart/invoice lines. When using the cart object, the rounding for the same order line is not limited. Rounding the cart line subtotal before building the grand total (for Display) solved it - order & invoice are doing it that way. Does not rule out that I am missing something. :) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605870#comment-17605870 ] Ingo Wolfmayr edited comment on OFBIZ-12390 at 9/16/22 2:46 PM: Hi Jacques, I have updated the XML files. 1.) Import [^pricecheckData-1.xml] 2.) Import Orders.xml 3.) Update the order to recalculate prices. The order will then be up-to-date. There is no payment preference right now. 4.) Goto Webtools and run the service "createPaymentFromOrder" - it will create a new payment preference. If you create one payment preference before applying the patch you will see the wrong amount. Apply the patch and run the service again. You will see a second preference with the right amount. See the image below. Thanks, Ingo !image-2022-09-16-16-43-38-897.png! was (Author: iwolf): Hi Jacques, I have updated the XML files. 1.) Import [^pricecheckData-1.xml] 2.) Import Orders.xml 3.) Update the order to recalculate prices. The order will then be up-to-date. There is not payment preference right now. 4.) Goto Webtools and run the service "createPaymentFromOrder" - it will create a new payment preference. If you create one payment preference before applying the patch you will see the wrong amount. Apply the patch and run the service again. You will see a second preference with the right amount. See the image below. Thanks, Ingo !image-2022-09-16-16-43-38-897.png! > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605870#comment-17605870 ] Ingo Wolfmayr commented on OFBIZ-12390: --- Hi Jacques, I have updated the XML files. 1.) Import [^pricecheckData-1.xml] 2.) Import Orders.xml 3.) Update the order to recalculate prices. The order will then be up-to-date. There is not payment preference right now. 4.) Goto Webtools and run the service "createPaymentFromOrder" - it will create a new payment preference. If you create one payment preference before applying the patch you will see the wrong amount. Apply the patch and run the service again. You will see a second preference with the right amount. See the image below. Thanks, Ingo !image-2022-09-16-16-43-38-897.png! > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch >Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: Orders.xml > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: (was: Orders.xml) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: image-2022-09-16-16-43-38-897.png > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, > pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: (was: pricecheckData-1.xml) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: pricecheckData-1.xml > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: Orders.xml pricecheckData-1.xml > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: (was: pricecheckData-1.xml) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: (was: Orders.xml) > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17605655#comment-17605655 ] Ingo Wolfmayr commented on OFBIZ-12390: --- The attached patch defines rounding on cart object to apply to the order & invoice total logic. It does not change the price calulcation but the cart price total result. Having different results in order/invoice total and cart total has the following effect: * Invoice can not be closed, as payment amount created from order does not match invoice amount * Payment on cart will differ to created order. WebPos payment request will not match order. > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12390) Order/Invoice: Item total result diff total result
[ https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12390: -- Attachment: cartRounding.patch > Order/Invoice: Item total result diff total result > -- > > Key: OFBIZ-12390 > URL: https://issues.apache.org/jira/browse/OFBIZ-12390 > Project: OFBiz > Issue Type: Improvement > Components: accounting, order >Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: Orders.xml, cartRounding.patch, > image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, > image-2021-11-19-09-59-07-571.png, pricecheckData-1.xml > > > In some cases the order total is not correct: > net price: €1.273 > 10% sales tax: € 0.127 > quantity: 1 > grand total: € 1.40 > Now taking the same product and adding it with two order lines: > grand total: € 2.79 > Right now the grand total is calculated by total all item net prices, total > all adjustments and finally adding those two values together. > The following screenshots are taken from the orderview. Ofbiz request a > payment of € 2.80 but will create an invoice with a grand total of € 2.79. > !image-2021-11-19-09-44-18-759.png! > !image-2021-11-19-09-44-44-443.png! > Heres the result with just one orderline: > !image-2021-11-19-09-59-07-571.png! > > I have created a XML file for testing. Import the file via XML import and > create an order: > partyId: AUT_CUSTOMER > productStore: Test GmbH > product 1: AUT_PRODUCT (quantity 1) > product 1: AUT_PRODUCT_CP (quantity 1) > Checkout with default settings. > From my perspective the calculation should be changed to calculate the total > amount for each line and calculate the grand total from these results. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12674) Send Confirmation Mail Request Problem
[
https://issues.apache.org/jira/browse/OFBIZ-12674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17602825#comment-17602825
]
Ingo Wolfmayr commented on OFBIZ-12674:
---
Hi Jacques,
looks good. Thanks!
> Send Confirmation Mail Request Problem
> --
>
> Key: OFBIZ-12674
> URL: https://issues.apache.org/jira/browse/OFBIZ-12674
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
>
> When sending a confirmation mail from the order screen
> ([https://localhost:8443/ordermgr/control/confirmationmailedit]) it get the
> following error.
> {code:java}
> 2022-07-25 10:52:26,244 |sse-nio-8443-exec-19 |ControlServlet
> |T| [[[ordermgr::sendconfirmationmail (Domain:https://localhost)] Request
> Done- total:13.844,since last([ordermgr::sendco...):13.844]]
> 2022-07-25 10:52:27,499 |jsse-nio-8443-exec-7 |ControlServlet
> |T| [[[ordermgr::sendconfirmationmail (Domain:https://localhost)] Request
> Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
> 2022-07-25 10:52:27,501 |jsse-nio-8443-exec-7 |ControlServlet
> |E| Error in request handler:
> org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request
> [sendconfirmationmail]; this request does not exist or cannot be called
> directly.
> at
> org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:408)
> ~[main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
> ~[main/:?]
> at
> org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
> ~[main/:?]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
> ~[tomcat-servlet-api-9.0.60.jar:4.0.FR]
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
> ~[tomcat-servlet-api-9.0.60.jar:4.0.FR]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
> ~[tomcat-embed-websocket-9.0.41.jar:9.0.41]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.ofbiz.webapp.control.SameSiteFilter.doFilter(SameSiteFilter.java:45)
> ~[main/:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:188)
> ~[main/:?]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:167)
> ~[main/:?]
> at javax.servlet.http.HttpFilter.doFilter(HttpFilter.java:57)
> ~[tomcat-servlet-api-9.0.60.jar:4.0.FR]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.logging.log4j.web.Log4jServletFilter.doFilter(Log4jServletFilter.java:71)
> ~[log4j-web-2.17.2.jar:2.17.2]
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:189)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
> ~[tomcat-catalina-9.0.60.jar:9.0.60]
> at
> org.apache.catalina.core.StandardWrapperValve.invoke
[jira] [Updated] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12691: -- Attachment: SanitizerStyle.patch > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
[ https://issues.apache.org/jira/browse/OFBIZ-12691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12691: -- Attachment: (was: SanitizerStyle.patch) > Extend HTML Sanitizer - style attribute > --- > > Key: OFBIZ-12691 > URL: https://issues.apache.org/jira/browse/OFBIZ-12691 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Attachments: SanitizerStyle.patch > > > Right now it is not possible to assign inline style to html content. > Trumbowyg Editor uses such tags for align paragraphs. > style="text-align:right" > It is necessary to remove space within the attribute and remove the trailing > semicolon in order to apply with OWASP filter rules. > Create or open content with "Long text". Goto dataresource and edit HTML. Put > in some text and use the align icons (right, center ...) to format the text. > Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12691) Extend HTML Sanitizer - style attribute
Ingo Wolfmayr created OFBIZ-12691: - Summary: Extend HTML Sanitizer - style attribute Key: OFBIZ-12691 URL: https://issues.apache.org/jira/browse/OFBIZ-12691 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: Upcoming Branch Reporter: Ingo Wolfmayr Attachments: SanitizerStyle.patch Right now it is not possible to assign inline style to html content. Trumbowyg Editor uses such tags for align paragraphs. style="text-align:right" It is necessary to remove space within the attribute and remove the trailing semicolon in order to apply with OWASP filter rules. Create or open content with "Long text". Goto dataresource and edit HTML. Put in some text and use the align icons (right, center ...) to format the text. Save. You will get a security info. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12690) Load cart from order with modified price
[ https://issues.apache.org/jira/browse/OFBIZ-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12690: -- Attachment: (was: modifiedPrice.patch) > Load cart from order with modified price > > > Key: OFBIZ-12690 > URL: https://issues.apache.org/jira/browse/OFBIZ-12690 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > > The loadCartFromOrder method does not consider the selectedAmount from > orderItems. When creating an order where the selectedAmount is not empty the > current logic will take the already calculated unitprice and multiply it with > the unitprice. > SelectedAmount: 0.5 > Unitprice: 10 > Update 1: 5 > Update 2: 2.5 > ... > My proposal uses the unitListPrice if the order item has modifiedPrice=Y && > selectedAmount!=null -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12690) Load cart from order with modified price
[ https://issues.apache.org/jira/browse/OFBIZ-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601152#comment-17601152 ] Ingo Wolfmayr commented on OFBIZ-12690: --- Hi Jacques, I agree. I have no easy solution right now. As I have to walk through the whole price logic (OFBIZ-12390) I will try to come up with a proposal. * add isModifiedPrice to addItem methods and pass it to the price calc service.?? * add basePrice to orderItem?? ( *It sounds like you need a workflow field to capture the initial unit price (unless the list price is the initial unit price).*) If you have a proposal :) > Load cart from order with modified price > > > Key: OFBIZ-12690 > URL: https://issues.apache.org/jira/browse/OFBIZ-12690 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > Attachments: modifiedPrice.patch > > > The loadCartFromOrder method does not consider the selectedAmount from > orderItems. When creating an order where the selectedAmount is not empty the > current logic will take the already calculated unitprice and multiply it with > the unitprice. > SelectedAmount: 0.5 > Unitprice: 10 > Update 1: 5 > Update 2: 2.5 > ... > My proposal uses the unitListPrice if the order item has modifiedPrice=Y && > selectedAmount!=null -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12690) Load cart from order with modified price
[ https://issues.apache.org/jira/browse/OFBIZ-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12690: -- Attachment: (was: modifiedPrice.patch) > Load cart from order with modified price > > > Key: OFBIZ-12690 > URL: https://issues.apache.org/jira/browse/OFBIZ-12690 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > Attachments: modifiedPrice.patch > > > The loadCartFromOrder method does not consider the selectedAmount from > orderItems. When creating an order where the selectedAmount is not empty the > current logic will take the already calculated unitprice and multiply it with > the unitprice. > SelectedAmount: 0.5 > Unitprice: 10 > Update 1: 5 > Update 2: 2.5 > ... > My proposal uses the unitListPrice if the order item has modifiedPrice=Y && > selectedAmount!=null -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12690) Load cart from order with modified price
[ https://issues.apache.org/jira/browse/OFBIZ-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Wolfmayr updated OFBIZ-12690: -- Attachment: modifiedPrice.patch > Load cart from order with modified price > > > Key: OFBIZ-12690 > URL: https://issues.apache.org/jira/browse/OFBIZ-12690 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Upcoming Branch > Reporter: Ingo Wolfmayr >Priority: Major > Fix For: Upcoming Branch > > Attachments: modifiedPrice.patch > > > The loadCartFromOrder method does not consider the selectedAmount from > orderItems. When creating an order where the selectedAmount is not empty the > current logic will take the already calculated unitprice and multiply it with > the unitprice. > SelectedAmount: 0.5 > Unitprice: 10 > Update 1: 5 > Update 2: 2.5 > ... > My proposal uses the unitListPrice if the order item has modifiedPrice=Y && > selectedAmount!=null -- This message was sent by Atlassian Jira (v8.20.10#820010)
