[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-09 Thread Sven Joachim via Aptitude-devel
Control: reassign -1 ncurses-base 6.4+20231118-1
Control: retitle -1 ncurses-base: mouse malfunctions in tmux

On 2023-12-08 14:29 -0500, Thomas Dickey wrote:

> On Fri, Dec 08, 2023 at 05:01:43PM +0100, Sven Joachim wrote:
>>
>> However, tmux got changed the other way around: it already had used
>> xterm+focus, and you added xterm+sm+1006.  This is the diff hunk:
>>
>> ,
>> | @@ -8550,7 +8556,7 @@ tmux|tmux terminal multiplexer,
>> |use=ecma+italics, use=ecma+strikeout, use=xterm+edit,
>> |use=xterm+pcfkeys, use=xterm+sl, use=xterm+tmux,
>> |use=screen, use=bracketed+paste, use=report+version,
>> | -  use=xterm+focus,
>> | +  use=xterm+focus, use=xterm+sm+1006,
>> |
>> |  tmux-256color|tmux with 256 colors,
>> |use=xterm+256setaf, use=tmux,
>> `
>>
>> That seems to be not really intended and should likely be reverted,
>> given the issue at hand.
>
> will do.

Thanks, I will either cherry-pick that fix or upgrade to the 20231209
patchlevel, then we are all set.

Cheers,
   Sven

___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel


[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-08 Thread Thomas Dickey
On Fri, Dec 08, 2023 at 05:01:43PM +0100, Sven Joachim wrote:
> On 2023-12-07 17:41 -0500, Thomas Dickey wrote:
> 
> > On Thu, Dec 07, 2023 at 06:06:49PM +0100, Axel Beckert wrote:
> >> Hi Sven,
> >>
> >> Sven Joachim via Aptitude-devel wrote:
> >> > Debian ncurses maintainer here, bringing the ncurses upstream developer
> >> > into the loop.
> >>
> >> Thanks for that!
> >>
> >> > In addition to aptitude, mouse support is also broken in dialog(1) under
> >> > tmux.
> >> >
> >> > > Maybe this bug should instead be assigned to ncurses?
> >> >
> >> > Probably should be reassigned to ncurses-base, but let's first see what
> >> > Thomas has to say about it.
> >
> > It's probaby the same issue as this;
> >
> > 20231028
> > + move xterm focus mode 1004 from xterm+sm+1006 into xterm+focus as
> >   fe/fd capabilities, like vim (vim-pr #13440).
> 
> Looking at the misc/terminfo.src changes in that patchlevel, I see that
> you added xterm+focus to several terminfo entries that had used
> xterm+sm+1006, which is logical and in line with the NEWS entry.
> 
> However, tmux got changed the other way around: it already had used
> xterm+focus, and you added xterm+sm+1006.  This is the diff hunk:
> 
> ,
> | @@ -8550,7 +8556,7 @@ tmux|tmux terminal multiplexer,
> | use=ecma+italics, use=ecma+strikeout, use=xterm+edit,
> | use=xterm+pcfkeys, use=xterm+sl, use=xterm+tmux,
> | use=screen, use=bracketed+paste, use=report+version,
> | -   use=xterm+focus,
> | +   use=xterm+focus, use=xterm+sm+1006,
> |
> |  tmux-256color|tmux with 256 colors,
> | use=xterm+256setaf, use=tmux,
> `
> 
> That seems to be not really intended and should likely be reverted,
> given the issue at hand.

will do.

-- 
Thomas E. Dickey 
https://invisible-island.net


signature.asc
Description: PGP signature
___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel


[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-08 Thread Antonio Russo via Aptitude-devel
On 2023-12-08 09:01, Sven Joachim wrote:
> 
> ,
> | @@ -8550,7 +8556,7 @@ tmux|tmux terminal multiplexer,
> | use=ecma+italics, use=ecma+strikeout, use=xterm+edit,
> | use=xterm+pcfkeys, use=xterm+sl, use=xterm+tmux,
> | use=screen, use=bracketed+paste, use=report+version,
> | -   use=xterm+focus,
> | +   use=xterm+focus, use=xterm+sm+1006,
> |
> |  tmux-256color|tmux with 256 colors,
> | use=xterm+256setaf, use=tmux,
> `
> 
> That seems to be not really intended and should likely be reverted,
> given the issue at hand.

I can confirm this change resolves the aptitude issue for me.  I'll continue
testing it.

> 
>> (a change to the terminal description to help vim turned out to expose one
>> of the VTE bugs - fixed by making it less likely for other applications
>> to trigger the bug)
> 
> There is no VTE involved in this case, I reproduced the problem in
> xterm.
> 
> Cheers,
>Sven

Thanks!
Antonio

OpenPGP_0xB01C53D5DED4A4EE.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature
___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel


[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-08 Thread Sven Joachim via Aptitude-devel
On 2023-12-07 17:41 -0500, Thomas Dickey wrote:

> On Thu, Dec 07, 2023 at 06:06:49PM +0100, Axel Beckert wrote:
>> Hi Sven,
>>
>> Sven Joachim via Aptitude-devel wrote:
>> > Debian ncurses maintainer here, bringing the ncurses upstream developer
>> > into the loop.
>>
>> Thanks for that!
>>
>> > In addition to aptitude, mouse support is also broken in dialog(1) under
>> > tmux.
>> >
>> > > Maybe this bug should instead be assigned to ncurses?
>> >
>> > Probably should be reassigned to ncurses-base, but let's first see what
>> > Thomas has to say about it.
>
> It's probaby the same issue as this;
>
> 20231028
> + move xterm focus mode 1004 from xterm+sm+1006 into xterm+focus as
> fe/fd capabilities, like vim (vim-pr #13440).

Looking at the misc/terminfo.src changes in that patchlevel, I see that
you added xterm+focus to several terminfo entries that had used
xterm+sm+1006, which is logical and in line with the NEWS entry.

However, tmux got changed the other way around: it already had used
xterm+focus, and you added xterm+sm+1006.  This is the diff hunk:

,
| @@ -8550,7 +8556,7 @@ tmux|tmux terminal multiplexer,
|   use=ecma+italics, use=ecma+strikeout, use=xterm+edit,
|   use=xterm+pcfkeys, use=xterm+sl, use=xterm+tmux,
|   use=screen, use=bracketed+paste, use=report+version,
| - use=xterm+focus,
| + use=xterm+focus, use=xterm+sm+1006,
|
|  tmux-256color|tmux with 256 colors,
|   use=xterm+256setaf, use=tmux,
`

That seems to be not really intended and should likely be reverted,
given the issue at hand.

> (a change to the terminal description to help vim turned out to expose one
> of the VTE bugs - fixed by making it less likely for other applications
> to trigger the bug)

There is no VTE involved in this case, I reproduced the problem in
xterm.

Cheers,
   Sven

___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel


[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-07 Thread Sven Joachim via Aptitude-devel
Hi,

Debian ncurses maintainer here, bringing the ncurses upstream developer
into the loop.

On 2023-12-06 22:28 -0700, Antonio Russo wrote:

> Package: aptitude
> Version: 0.8.13-5
> Severity: normal
> X-Debbugs-Cc: aeru...@aerusso.net
>
> Dear maintainer,
>
> If I run aptitude inside xterm, and click on an aptitude TUI element (say, a 
> particular
> package), that package will be selected.  If, instead, I am running aptitude 
> inside tmux,
> and I click on said element, it appears many garbage characters are sent to 
> aptitude,
> including probably m and M, (the symptom is the automatic install state of 
> packages changes).
>
> If I manually set TERM=xterm inside the tmux window, everything works.  
> Alternatively, outside
> of tmux, if I set TERM=tmux-256color I get the same bad behavior in aptitude.
>
> If I downgrade all ncurses packages to 6.4+20231016, I don't get this
> behavior.

The culprit is the addition of xterm+sm+1006 (xterm SGR-mouse) to the
tmux/tmux-256color terminfo entries in the ncurses 20231028 patchlevel.
In addition to aptitude, mouse support is also broken in dialog(1) under
tmux.

> Maybe this bug should instead be assigned to ncurses?

Probably should be reassigned to ncurses-base, but let's first see what
Thomas has to say about it.

Cheers,
   Sven

___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel


[Aptitude-devel] Bug#1057688: aptitude: Stray input on window click when running under tmux

2023-12-06 Thread Antonio Russo via Aptitude-devel
Package: aptitude
Version: 0.8.13-5
Severity: normal
X-Debbugs-Cc: aeru...@aerusso.net

Dear maintainer,

If I run aptitude inside xterm, and click on an aptitude TUI element (say, a 
particular
package), that package will be selected.  If, instead, I am running aptitude 
inside tmux,
and I click on said element, it appears many garbage characters are sent to 
aptitude,
including probably m and M, (the symptom is the automatic install state of 
packages changes).

If I manually set TERM=xterm inside the tmux window, everything works.  
Alternatively, outside
of tmux, if I set TERM=tmux-256color I get the same bad behavior in aptitude.

If I downgrade all ncurses packages to 6.4+20231016, I don't get this behavior. 
 Maybe this
bug should instead be assigned to ncurses?

Best,
Antonio Russo

OpenPGP_0xB01C53D5DED4A4EE.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature
___
Aptitude-devel mailing list
Aptitude-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/aptitude-devel