Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-12 Thread Kourosh Kalayeh
On Nov 11, 2023 Arash Esbati  wrote:

> Kourosh Kalayeh  writes:
>
>> On Nov 10, 2023 Arash Esbati  wrote:
>>
>>> Great, glad this issue is resolved.  I wonder if we should introduce
>>> something similar to `TeX-arg-cite-note-p' for beamer which suppresses or
>>> allows the query for the overlay specs?  I'm not a beamer user, so I
>>> can't tell.
>>
>> Yes, that makes perfect sense and it would be a great option to have.
>
> I see we already have
>
>   (defcustom LaTeX-beamer-item-overlay-flag t
> "If non-nil do prompt for an overlay in itemize-like environments."
> :type 'boolean)
>
> in tex-style.el.  It should be easy to add something like
> `LaTeX-beamer-overlay-flag' to that file and then update beamer.el to
> use the new flag; TeX-arg-conditional is our friend.  Is there a
> volunteer who wants to submit a patch for this?

I would have loved to, but unfortunately, I don't have enough Lisp knowledge 
yet.

Best, 
Kourosh 


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-11 Thread Arash Esbati
Kourosh Kalayeh  writes:

> On Nov 10, 2023 Arash Esbati  wrote:
>
>> Great, glad this issue is resolved.  I wonder if we should introduce
>> something similar to `TeX-arg-cite-note-p' for beamer which suppresses or
>> allows the query for the overlay specs?  I'm not a beamer user, so I
>> can't tell.
>
> Yes, that makes perfect sense and it would be a great option to have.

I see we already have

  (defcustom LaTeX-beamer-item-overlay-flag t
"If non-nil do prompt for an overlay in itemize-like environments."
:type 'boolean)

in tex-style.el.  It should be easy to add something like
`LaTeX-beamer-overlay-flag' to that file and then update beamer.el to
use the new flag; TeX-arg-conditional is our friend.  Is there a
volunteer who wants to submit a patch for this?

Best, Arash




Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-10 Thread Kourosh Kalayeh
On Nov 10, 2023 Arash Esbati  wrote:

> Kourosh Kalayeh  writes:
>
>> On Nov 09, 2023 Arash Esbati  wrote:
>>
>>> You are not asked for the next optional argument which can contain
>>> 'width', and that's what you're looking for.  So you can set
>>> `TeX-insert-macro-default-style' to `show-all-optional-args' and try it
>>> again.
>>
>> Perfect, it did the trick.
>
> Great, glad this issue is resolved.  I wonder if we should introduce
> something similar to `TeX-arg-cite-note-p' for beamer which suppresses or
> allows the query for the overlay specs?  I'm not a beamer user, so I
> can't tell.

Yes, that makes perfect sense and it would be a great option to have.

Kourosh


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-10 Thread Hongyi Zhao
On Fri, Nov 10, 2023 at 6:28 PM Arash Esbati  wrote:
>
> Kourosh Kalayeh  writes:
>
> > On Nov 09, 2023 Arash Esbati  wrote:
> >
> >> You are not asked for the next optional argument which can contain
> >> 'width', and that's what you're looking for.  So you can set
> >> `TeX-insert-macro-default-style' to `show-all-optional-args' and try it
> >> again.
> >
> > Perfect, it did the trick.
>
> Great, glad this issue is resolved.  I wonder if we should introduce
> something similar to `TeX-arg-cite-note-p' for beamer which suppresses or
> allows the query for the overlay specs?  I'm not a beamer user, so I
> can't tell.

IMHO, your suggestion is feasible because the beamer LaTeX class is
widely used for slide preparation.

> Best, Arash

Regards,
Zhao



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-10 Thread Arash Esbati
Kourosh Kalayeh  writes:

> On Nov 09, 2023 Arash Esbati  wrote:
>
>> You are not asked for the next optional argument which can contain
>> 'width', and that's what you're looking for.  So you can set
>> `TeX-insert-macro-default-style' to `show-all-optional-args' and try it
>> again.
>
> Perfect, it did the trick.

Great, glad this issue is resolved.  I wonder if we should introduce
something similar to `TeX-arg-cite-note-p' for beamer which suppresses or
allows the query for the overlay specs?  I'm not a beamer user, so I
can't tell.

Best, Arash



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-09 Thread Kourosh Kalayeh
On Nov 09, 2023 Arash Esbati  wrote:

> Thanks, now I understand what's happening.  beamer.el contain these
> lines:
>
> '("includegraphics" [TeX-arg-beamer-overlay-spec]
>   [TeX-arg-key-val (LaTeX-graphicx-key-val-options) nil nil ?\s]
>   LaTeX-arg-includegraphics)
>
> So it overrules the definition in graphicx.el by adding one more
> optional argument which you see as '(Optional) Overlay:'.  Now you hit
> return and this means that the optional argument is rejected.  With the
> setup below:
>
>> Its value is `'show-optional-args''.
>
> You are not asked for the next optional argument which can contain
> 'width', and that's what you're looking for.  So you can set
> `TeX-insert-macro-default-style' to `show-all-optional-args' and try it
> again.

Perfect, it did the trick.

Thanks a lot Arash.

Kourosh 


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-09 Thread Arash Esbati
Kourosh Kalayeh  writes:

> I start with `emacs -Q' followed by evaluating `(progn
> (package-initialize t) (package-activate 'auctex))'.  I then open my
> `beamer' LaTeX file and do `C-c RET', at this point I start typing
> `\includegraphics', I can autocomplete the macro with `Tab'.  Once I
> hit return, AUCTeX asks me for `(Optional) Overlay:', I hit return,
> then it ask for the `Image file' and that is it.  I am expecting to be
> asked for `width' after `Overlay' but that does not happen.

Thanks, now I understand what's happening.  beamer.el contain these
lines:

'("includegraphics" [TeX-arg-beamer-overlay-spec]
  [TeX-arg-key-val (LaTeX-graphicx-key-val-options) nil nil ?\s]
  LaTeX-arg-includegraphics)

So it overrules the definition in graphicx.el by adding one more
optional argument which you see as '(Optional) Overlay:'.  Now you hit
return and this means that the optional argument is rejected.  With the
setup below:

> Its value is `'show-optional-args''.

You are not asked for the next optional argument which can contain
'width', and that's what you're looking for.  So you can set
`TeX-insert-macro-default-style' to `show-all-optional-args' and try it
again.

Best, Arash



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-09 Thread Kourosh Kalayeh
Thanks for your response Arash.  Sure, see below.

On Nov 09, 2023 Arash Esbati  wrote:

> Kourosh Kalayeh  writes:
>
>> I am still facing this issue (AUCTeX not asking for `width' in
>> `\includegraphics' macro) in `beamer' mode.  I have tried `Emacs -Q'
>> and same thing happens.  Can anyone please confirm if the issue
>> persists or resolved on your end.
>
> I didn't test it (no test case here) but from looking at the code, I'd
> say it should just work.  Can you come up with a recipe what you do in
> order to reproduce this, starting with emacs -Q?

I start with `emacs -Q' followed by evaluating `(progn (package-initialize t) 
(package-activate 'auctex))'.  I then open my `beamer' LaTeX file and do `C-c 
RET', at this point I start typing `\includegraphics', I can autocomplete the 
macro with `Tab'.  Once I hit return, AUCTeX asks me for `(Optional) Overlay:', 
I hit return, then it ask for the `Image file' and that is it.  I am expecting 
to be asked for `width' after `Overlay' but that does not happen.  

> Maybe you have a stale AUCTeX installation on your HD.  Can you open
> your .tex file where you get the behavior above and do
>
>  M-x list-load-path-shadows RET

Sure, I get `No Emacs Lisp load-path shadowing were found'

> And what's the value of `TeX-insert-macro-default-style' when you open
> your .tex file?  Shouldn't be relevant for emacs -Q case, but just to be
> sure.

Its value is `'show-optional-args''.

Thanks,
Kourosh 


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-09 Thread Arash Esbati
Kourosh Kalayeh  writes:

> I am still facing this issue (AUCTeX not asking for `width' in
> `\includegraphics' macro) in `beamer' mode.  I have tried `Emacs -Q'
> and same thing happens.  Can anyone please confirm if the issue
> persists or resolved on your end.

I didn't test it (no test case here) but from looking at the code, I'd
say it should just work.  Can you come up with a recipe what you do in
order to reproduce this, starting with emacs -Q?

Maybe you have a stale AUCTeX installation on your HD.  Can you open
your .tex file where you get the behavior above and do

 M-x list-load-path-shadows RET 

And what's the value of `TeX-insert-macro-default-style' when you open
your .tex file?  Shouldn't be relevant for emacs -Q case, but just to be
sure.

Best, Arash



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-11-09 Thread Kourosh Kalayeh
Hi all,

I am still facing this issue (AUCTeX not asking for `width' in 
`\includegraphics' macro) in `beamer' mode.  I have tried `Emacs -Q' and same 
thing happens.  Can anyone please confirm if the issue persists or resolved on 
your end. 

I am running AUCTeX 13.2.2 on GNU Emacs 29.1 (build 2, 
x86_64-apple-darwin23.0.0, NS appkit-2487.00 Version 14.0 (Build 23A344)) of 
2023-10-02.

Thanks,
Kourosh 


On Mar 14, 2023 Arash Esbati  wrote:

> Ikumi Keita  writes:
>
>>> Tassilo Horn  writes:
>>> Ah, that's the thing.  Arash, you broke it with commit
>>> b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the function
>>> LaTeX-arg-graphicx-includegraphics-key-val which is still used by
>>> beamer.el and overpic.el.
>>
>> Ah, sorry, then it's my fault. When Arash committed that changeset,
>> beamer.el didn't use `LaTeX-arg-graphicx-includegraphics-key-val'. I
>> committed the new beamer.el a week after that, which includes
>> `LaTeX-arg-graphicx-includegraphics-key-val' :-(
>> My development on beamer.el took several months, in most of which the
>> function was kept in latex.el. That's the reason I overlooked it had
>> gone.
>>
>> Thank you for taking care of this issue, Tassilo.
>
> Gentlemen, Thanks for fixing this and sorry for my late response, I was
> AFK.  I also pushed a change to overpic.el which nukes the function
> `LaTeX-arg-overpic-key-val' and uses our latest improvements to
> `TeX-arg-key-val'.
>
> Best, Arash


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-22 Thread Kourosh Kalayeh
On 17 Mar 2023, at 2:36, Tassilo Horn wrote:

> Kourosh Kalayeh kay...@pm.me writes:
>
>>> I do, too, so just using those two shouldn't be problematic. BTW,
>>> during key-val completion (through multi-prompt-key-value) I see no
>>> sign of vertico/maginalia, i.e., no vertical display of completion
>>> candidates but just standard Completions buffer on hitting TAB
>>> multiple times.
>>
>> I think I was able to pin down the issue. As you suspect, it was not
>> due to Vertico or Marginilia. I think it is due to orderless. With
>> minimal orderless setup as below, the optional arguments to
>> \includegraphics macro is not working as expected in AUCTeX. Any
>> suggestion or workaround?
>
> I guess you could do something like
>
> (add-hook 'TeX-mode-hook
> (lambda ()
> (setq-local completion-styles '(basic
>
> i.e., ensure that orderless is not in `completion-styles' in TeX
> buffers. Of course, then you'd not have orderless completion with
> normal symbol (non-key-val) completion, too.
>
> Please also report it to the orderless maintainers. Tell them that
> AUCTeX `multi-prompt-key-value' [1] seems to misbehave with orderless in
> that it doesn't strictly complete key=val but also val=key, key=key, and
> val=val. In a sense, orderless is doing what it advertises, ignoring
> the order. But maybe they can find a fix. If not, I guess, AUCTeX can
> add a workaround and let-bind completion-styles to a value without
> orderless during multi-prompt-key-value. Please Cc me in the report by
> mentioning me with @tsdh.
>
> Thanks,
> Tassilo
>
> [1] http://git.savannah.gnu.org/cgit/auctex.git/tree/multi-prompt.el#n183

Thank you Tassilo, and sorry for my late response.

Sure, will do that.

Kourosh

Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-17 Thread Tassilo Horn
Kourosh Kalayeh  writes:

>> I do, too, so just using those two shouldn't be problematic. BTW,
>> during key-val completion (through multi-prompt-key-value) I see no
>> sign of vertico/maginalia, i.e., no vertical display of completion
>> candidates but just standard Completions buffer on hitting TAB
>> multiple times.
>
> I think I was able to pin down the issue. As you suspect, it was not
> due to Vertico or Marginilia. I think it is due to orderless. With
> minimal orderless setup as below, the optional arguments to
> \includegraphics macro is not working as expected in AUCTeX. Any
> suggestion or workaround?

I guess you could do something like

  (add-hook 'TeX-mode-hook
(lambda ()
  (setq-local completion-styles '(basic

i.e., ensure that orderless is not in `completion-styles' in TeX
buffers.  Of course, then you'd not have orderless completion with
normal symbol (non-key-val) completion, too.

Please also report it to the orderless maintainers.  Tell them that
AUCTeX `multi-prompt-key-value' [1] seems to misbehave with orderless in
that it doesn't strictly complete key=val but also val=key, key=key, and
val=val.  In a sense, orderless is doing what it advertises, ignoring
the order.  But maybe they can find a fix.  If not, I guess, AUCTeX can
add a workaround and let-bind completion-styles to a value without
orderless during multi-prompt-key-value.  Please Cc me in the report by
mentioning me with @tsdh.

Thanks,
Tassilo

[1] http://git.savannah.gnu.org/cgit/auctex.git/tree/multi-prompt.el#n183



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-16 Thread Kourosh Kalayeh
On 8 Mar 2023, at 2:35, Tassilo Horn wrote:

> Kourosh Kalayeh kay...@pm.me writes:
>
>>> Do you use some non-standard completion framework?
>>
>> Yes, I am using Vertico and Marginilia.
>
> I do, too, so just using those two shouldn't be problematic. BTW,
> during key-val completion (through multi-prompt-key-value) I see no sign
> of vertico/maginalia, i.e., no vertical display of completion candidates
> but just standard Completions buffer on hitting TAB multiple times.

I think I was able to pin down the issue. As you suspect, it was not due to 
Vertico or Marginilia. I think it is due to orderless. With minimal orderless 
setup as below, the optional arguments to \includegraphics macro is not working 
as expected in AUCTeX. Any suggestion or workaround? If you think it is a bug 
with orderless I can report it there.

(use-package orderless
  :custom
  (completion-styles '(orderless basic))
  (completion-category-overrides '((file (styles basic partial-completion)

Thanks,
Kourosh

Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-14 Thread Arash Esbati
Ikumi Keita  writes:

>> Tassilo Horn  writes:
>> Ah, that's the thing.  Arash, you broke it with commit
>> b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the function
>> LaTeX-arg-graphicx-includegraphics-key-val which is still used by
>> beamer.el and overpic.el.
>
> Ah, sorry, then it's my fault. When Arash committed that changeset,
> beamer.el didn't use `LaTeX-arg-graphicx-includegraphics-key-val'. I
> committed the new beamer.el a week after that, which includes
> `LaTeX-arg-graphicx-includegraphics-key-val' :-(
> My development on beamer.el took several months, in most of which the
> function was kept in latex.el. That's the reason I overlooked it had
> gone.
>
> Thank you for taking care of this issue, Tassilo.

Gentlemen, Thanks for fixing this and sorry for my late response, I was
AFK.  I also pushed a change to overpic.el which nukes the function
`LaTeX-arg-overpic-key-val' and uses our latest improvements to
`TeX-arg-key-val'.

Best, Arash



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-07 Thread Tassilo Horn
Kourosh Kalayeh  writes:

>> Do you use some non-standard completion framework?
>
> Yes, I am using Vertico and Marginilia.

I do, too, so just using those two shouldn't be problematic.  BTW,
during key-val completion (through multi-prompt-key-value) I see no sign
of vertico/maginalia, i.e., no vertical display of completion candidates
but just standard *Completions* buffer on hitting TAB multiple times.

Bye,
Tassilo



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-07 Thread Kourosh Kalayeh
Hi Tassilo and Ikumi,

On 7 Mar 2023, at 13:57, Tassilo Horn wrote:


> In that screenshot, you are queried for the overlay which is a free-form
> string.  That's nothing AUCTeX could complete.

This was a mistake.  Sorry about that.

> Do you use some non-standard completion framework?

Yes, I am using Vertico and Marginilia.  I think you are right, it has to do 
with my completion packages.  I will dig into this.  Thanks for the hint.

Kourosh




Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-07 Thread Tassilo Horn
Kourosh Kalayeh  writes:

Hi Kourosh,

>> Didn't you hit just RET for "(Optional) Overlay:" query? If so,
>> that's default behavior of AUCTeX: When you hit just RET for a query
>> of optional argument, the rest of queries of optional argument is
>> skipped.  To avoid that behavior, customize
>> TeX-insert-macro-default-style' to show-all-optional-args'.
>
> Thanks Ikumi. Previously, when AUCTeX inquired for options I could
> have autocomplete both width and \linewidth but now AUCTeX does not
> recognize this. See the attached screenshot.
>
> [Screenshot 2023-03-06 at 20.47.53.png]

In that screenshot, you are queried for the overlay which is a free-form
string.  That's nothing AUCTeX could complete.

> I also noticed that with the most recent update autocomplete for width
> add an extra width, see the second screenshot.
>
> [Screenshot 2023-03-06 at 20.52.44.png]

Not for me.  When I type w it completes to width, then I type a =
and then -ing after the width= completes to either \linewidth,
\textwidth, or \columnwidth but never to another width.

Do you use some non-standard completion framework?

Bye,
Tassilo



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-06 Thread Ikumi Keita
Hi Kourosh,

> Kourosh Kalayeh  writes:
> Thanks Ikumi. Previously, when AUCTeX inquired for options I could
> have autocomplete both width and \linewidth but now AUCTeX does not
> recognize this. See the attached screenshot.

> [Screenshot 2023-03-06 at 20.47.53.png]

Why do you try to complete "width" for prompt asking overlay? You are
expected to type in a beamer overlay spec like "2-" and "3,5" there.

> I also noticed that with the most recent update autocomplete for width
> add an extra width, see the second screenshot.

> [Screenshot 2023-03-06 at 20.52.44.png]

That doesn't occur for me with TeX-insert-macro-default-style being
`show-all-optional-args'. What key sequence did you type to get that
result? When I type
C-c RET includeg TAB RET RET wi TAB
in the frame environment for the document listed below, AUCTeX completes
to "width".


When I type subsequently
= TAB
, AUCTeX completes to add a backslash so that the minibuffer contents
becomes "width=\". I can complete, say, "width=\linewidth" after that.

Maybe some in-buffer completion facility is interfering with you.

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine

\documentclass{beamer}

\begin{document}
\begin{frame}
  \frametitle{abc}
  
\end{frame}
\end{document}

%%% Local Variables:
%%% mode: latex
%%% TeX-master: t
%%% End:


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-06 Thread Kourosh Kalayeh
On 6 Mar 2023, at 2:34, Ikumi Keita wrote:

> Didn't you hit just RET for "(Optional) Overlay:" query? If so, that's
> default behavior of AUCTeX: When you hit just RET for a query of
> optional argument, the rest of queries of optional argument is skipped.
> To avoid that behavior, customize TeX-insert-macro-default-style' to 
> show-all-optional-args'.

Thanks Ikumi. Previously, when AUCTeX inquired for options I could have 
autocomplete both width and \linewidth but now AUCTeX does not recognize this. 
See the attached screenshot.

[Screenshot 2023-03-06 at 20.47.53.png]

I also noticed that with the most recent update autocomplete for width add an 
extra width, see the second screenshot.

[Screenshot 2023-03-06 at 20.52.44.png]

Thanks,
Kourosh

Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-05 Thread Ikumi Keita
Hi Kourosh,

> kaykal  writes:
> I installed 13.1.10 and still having the same issue. AUCTeX only asks
> me for (Optional) Overlay: and Image file: in the minibuffer.

Didn't you hit just RET for "(Optional) Overlay:" query? If so, that's
default behavior of AUCTeX: When you hit just RET for a query of
optional argument, the rest of queries of optional argument is skipped.
To avoid that behavior, customize `TeX-insert-macro-default-style' to
`show-all-optional-args'.

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-05 Thread kaykal
On 5 Mar 2023, at 3:26, Tassilo Horn wrote:

> I've just made a new ELPA release GNU AUCTeX 13.1.10 which should appear
> in a few hours.

Thanks. I installed 13.1.10 and still having the same issue. AUCTeX only asks 
me for (Optional) Overlay: and Image file: in the minibuffer.

Thanks,
Kourosh

Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-05 Thread Ikumi Keita
> Tassilo Horn  writes:
> Ah, that's the thing.  Arash, you broke it with commit
> b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the function
> LaTeX-arg-graphicx-includegraphics-key-val which is still used by
> beamer.el and overpic.el.

Ah, sorry, then it's my fault. When Arash committed that changeset,
beamer.el didn't use `LaTeX-arg-graphicx-includegraphics-key-val'. I
committed the new beamer.el a week after that, which includes
`LaTeX-arg-graphicx-includegraphics-key-val' :-(
My development on beamer.el took several months, in most of which the
function was kept in latex.el. That's the reason I overlooked it had
gone.

Thank you for taking care of this issue, Tassilo.

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-05 Thread Tassilo Horn
kaykal  writes:

Hi Kourosh,

>> Should be fixed now.  Apparently, overpic only referred to the
>> removed function in a docstring so wasn't really broken.
>
> Thanks! Is it pushed yet?

Yes, but only to Git master.

> I cannot see it on gnu.

I've just made a new ELPA release GNU AUCTeX 13.1.10 which should appear
in a few hours.

Bye,
Tassilo



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-04 Thread kaykal


On 4 Mar 2023, at 15:22, Tassilo Horn wrote:

> Tassilo Horn  writes:
>
>>> It only happens for Beamer. It works fine when using article class
>>> for example.
>>
>> Ah, that's the thing.  Arash, you broke it with commit
>> b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the
>> function LaTeX-arg-graphicx-includegraphics-key-val which is still
>> used by beamer.el and overpic.el.
>
> Should be fixed now.  Apparently, overpic only referred to the removed
> function in a docstring so wasn't really broken.

Thanks! Is it pushed yet?  I cannot see it on gnu.

Kourosh




Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-04 Thread Tassilo Horn
Tassilo Horn  writes:

>> It only happens for Beamer. It works fine when using article class
>> for example.
>
> Ah, that's the thing.  Arash, you broke it with commit
> b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the
> function LaTeX-arg-graphicx-includegraphics-key-val which is still
> used by beamer.el and overpic.el.

Should be fixed now.  Apparently, overpic only referred to the removed
function in a docstring so wasn't really broken.

Bye,
Tassilo



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread Tassilo Horn


kaykal  writes:

>> Tassilo Horn t...@gnu.org writes:
>
>>> It's not. For me using the current master version, it still queries for
>>> the keyval parameters (width, height, angle, scale, etc.).
>
> It only happens for Beamer. It works fine when using article class for
> example.

Ah, that's the thing.  Arash, you broke it with commit
b7b498baad045685c7fcec0bce61f7290b86d09b where you removed the function
LaTeX-arg-graphicx-includegraphics-key-val which is still used by
beamer.el and overpic.el.

Bye,
Tassilo



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread David Kastrup
kaykal  writes:

> On 3 Mar 2023, at 8:23, Thibaut Verron wrote:
>
>> On 03/03/2023 14:19, kaykal wrote:
>>>
>>> Tassilo Horn t...@gnu.org writes:
>>>
>>> It's not. For me using the current master version, it still
>>> queries for
>>> the keyval parameters (width, height, angle, scale, etc.).
>>>
>>> It only happens for Beamer. It works fine when using article class for 
>>> example.
>>>
>> Did you try forcing AUCTeX to refresh its scanned data with C-c C-n?
>>
>> I occasionally need to do that to get AUCTeX to prompt me for the
>> frametitle of beamer frames, it could be a similar problem here.
>
> Thanks for the suggestions, yes I have done it and no luck.

Which lines in the document are responsible for pulling in graphics.sty
or graphicx.sty ?

-- 
David Kastrup



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread kaykal


On 3 Mar 2023, at 8:23, Thibaut Verron wrote:

> On 03/03/2023 14:19, kaykal wrote:
>>
>> Tassilo Horn t...@gnu.org writes:
>>
>> It's not. For me using the current master version, it still
>> queries for
>> the keyval parameters (width, height, angle, scale, etc.).
>>
>> It only happens for Beamer. It works fine when using article class for 
>> example.
>>
> Did you try forcing AUCTeX to refresh its scanned data with C-c C-n?
>
> I occasionally need to do that to get AUCTeX to prompt me for the frametitle 
> of beamer frames, it could be a similar problem here.

Thanks for the suggestions, yes I have done it and no luck.

Kourosh





Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread Thibaut Verron

On 03/03/2023 14:19, kaykal wrote:


Tassilo Horn t...@gnu.org writes:

It's not. For me using the current master version, it still
queries for
the keyval parameters (width, height, angle, scale, etc.).

It only happens for Beamer. It works fine when using article class for 
example.



Did you try forcing AUCTeX to refresh its scanned data with C-c C-n?

I occasionally need to do that to get AUCTeX to prompt me for the 
frametitle of beamer frames, it could be a similar problem here.


Best wishes,

Thibaut


Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread kaykal
> Tassilo Horn t...@gnu.org writes:

>> It's not. For me using the current master version, it still queries for
>> the keyval parameters (width, height, angle, scale, etc.).

It only happens for Beamer. It works fine when using article class for example.

>> What AUCTeX version and what's your config (check M-x
>> TeX-submit-bug-report RET which gathers all relevant settings)? Also
>> check M-x list-load-path-shadows RET to see if you have an old auctex
>> version somewhere messing things up.

Below is the complete output of TeX-submit-bug-report. I am using AUCTeX 
2023-01-31 on emacs 28.2.

I also checked M-x list-load-path-shadows, there is not AUCTeX entry in the 
output.

On 3 Mar 2023, at 7:28, David Kastrup wrote:

> Not to mention the settings for document parsing. \includegraphics is
> only available via packages.

I think this should be ok, since AUCTeX recognizes the \includegraphic as a 
macro.

Thanks,
Kourosh

Emacs  : GNU Emacs 28.2 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 
Version 10.14.6 (Build 18G95))
 of 2022-09-12
Package: 13.1.9

current state:
==
(setq
 AUCTeX-date "2023-01-31"
 window-system nil
 LaTeX-version "2e"
 TeX-style-path '("/usr/local/var/auctex" 
"/Users/kourosh/.emacs.d/elpa/auctex-13.1.9/style"
"/Users/kourosh/.emacs.d/auctex/auto" 
"/Users/kourosh/.emacs.d/auctex/style" "auto" "style")
 TeX-auto-save t
 TeX-parse-self t
 TeX-master t
 TeX-command-list '(("TeX" "%(PDF)%(tex) %(file-line-error) %`%(extraopts) 
%S%(PDFout)%(mode)%' %(output-dir) %t"
TeX-run-TeX nil (plain-tex-mode ams-tex-mode texinfo-mode) 
:help "Run plain TeX")
("LaTeX" "%`%l%(mode)%' %T" TeX-run-TeX nil (latex-mode 
doctex-mode) :help "Run LaTeX")
("Makeinfo" "makeinfo %(extraopts) %(o-dir) %t" TeX-run-compile 
nil (texinfo-mode) :help
"Run Makeinfo with Info output")
("Makeinfo HTML" "makeinfo %(extraopts) %(o-dir) --html %t" 
TeX-run-compile nil
(texinfo-mode) :help "Run Makeinfo with HTML output")
("AmSTeX" "amstex %(PDFout) %`%(extraopts) %S%(mode)%' 
%(output-dir) %t" TeX-run-TeX nil
(ams-tex-mode) :help "Run AMSTeX")
("ConTeXt" "%(cntxcom) --once --texutil %(extraopts) 
%(execopts)%t" TeX-run-TeX nil
(context-mode) :help "Run ConTeXt once")
("ConTeXt Full" "%(cntxcom) %(extraopts) %(execopts)%t" 
TeX-run-TeX nil (context-mode) :help
"Run ConTeXt until completion")
("BibTeX" "bibtex %(O?aux)" TeX-run-BibTeX nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode context-mode) :help
"Run BibTeX")
("Biber" "biber %(output-dir) %s" TeX-run-Biber nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help "Run Biber")
("Texindex" "texindex %s.??" TeX-run-command nil (texinfo-mode) 
:help "Run Texindex")
("Texi2dvi" "%(PDF)texi2dvi %t" TeX-run-command nil 
(texinfo-mode) :help
"Run Texi2dvi or Texi2pdf")
("View" "%V" TeX-run-discard-or-function t t :help "Run Viewer")
("Print" "%p" TeX-run-command t t :help "Print the file")
("Queue" "%q" TeX-run-background nil t :help "View the printer 
queue" :visible
TeX-queue-command)
("File" "%(o?)dvips %d -o %f " TeX-run-dvips t
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Generate PostScript file")
("Dvips" "%(o?)dvips %d -o %f " TeX-run-dvips nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Convert DVI file to PostScript")
("Dvipdfmx" "dvipdfmx -o %(O?pdf) %d" TeX-run-dvipdfmx nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Convert DVI file to PDF with dvipdfmx")
("Ps2pdf" "ps2pdf %f %(O?pdf)" TeX-run-ps2pdf nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Convert PostScript file to PDF")
("Glossaries" "makeglossaries %(d-dir) %s" TeX-run-command nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Run makeglossaries to create glossary file")
("Index" "makeindex %(O?idx)" TeX-run-index nil
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Run makeindex to create index file")
("upMendex" "upmendex %(O?idx)" TeX-run-index t
(plain-tex-mode latex-mode doctex-mode ams-tex-mode 
texinfo-mode) :help
"Run upmendex to create index file")
("Xindy" "texindy %s" TeX-run-command nil
(plain-tex-mode 

Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread David Kastrup
Tassilo Horn  writes:

> kaykal  writes:
>
> Hi Kourosh,
>
>> I recently noticed that when using TeX-insert-macro (C-c RET) for
>> \includegraphics AUCtex does not inquire about graphics width in the
>> minibuffer anymore. Can anyone comment if this is expected or not?
>
> It's not.  For me using the current master version, it still queries for
> the keyval parameters (width, height, angle, scale, etc.).
>
> What AUCTeX version and what's your config (check M-x
> TeX-submit-bug-report RET which gathers all relevant settings)?  Also
> check M-x list-load-path-shadows RET to see if you have an old auctex
> version somewhere messing things up.

Not to mention the settings for document parsing.  \includegraphics is
only available via packages.

-- 
David Kastrup



Re: AUCTeX does not ask for width for \includegraphics macro anymore

2023-03-03 Thread Tassilo Horn
kaykal  writes:

Hi Kourosh,

> I recently noticed that when using TeX-insert-macro (C-c RET) for
> \includegraphics AUCtex does not inquire about graphics width in the
> minibuffer anymore. Can anyone comment if this is expected or not?

It's not.  For me using the current master version, it still queries for
the keyval parameters (width, height, angle, scale, etc.).

What AUCTeX version and what's your config (check M-x
TeX-submit-bug-report RET which gathers all relevant settings)?  Also
check M-x list-load-path-shadows RET to see if you have an old auctex
version somewhere messing things up.

Bye,
Tassilo