Add timezone in bbdb-time-stamp-format
I propose the following change that includes the timezone info so that 3rd library does not need to know the time is actually UTC. diff --git a/lisp/bbdb.el b/lisp/bbdb.el index d2c72fb9..89e890c3 100644 --- a/lisp/bbdb.el +++ b/lisp/bbdb.el @@ -222,7 +222,7 @@ (defcustom bbdb-change-hook 'bbdb-timestamp :group 'bbdb :type 'hook) -(defcustom bbdb-time-stamp-format %Y-%m-%d %T +(defcustom bbdb-time-stamp-format %Y-%m-%d %T %z The BBDB time stamp format. See `format-time-string'. This function is called with arg UNIVERSAL being non-nil. :group 'bbdb Leo -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
[BBDB] ChangLog 2011-04-16
I tried to incoprorate a bunch of smaller issues that came up on this list the past couple of days. Thanks to everyone who contributed to this in one or the other way. On Wed Apr 13 2011 Sam Steingold wrote: if you do not care about obsolete emacsen, please apply this instead. I extended (and fixed) this patch to inherit from special-mode. Now bbdb-mode is also derived from special-mode. PS: The BBDB web page on savannah includes a bug tracker. This might help to keep track of bugs in BBDB. (Thanks Barak for entering the first report! This bug got hopefully fixed in one of the patches below. I have not yet figured out what I need to do in order to update the bug tracker accordingly.) 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-time-stamp-format): Includes timezone info. 2011-04-16 Roland Winkler wink...@gnu.org * TODO: New file. 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-faces): Group of faces used by BBDB. (bbdb-name, bbdb-organization, bbdb-field-name): New faces. (bbdb-display-name-organization, bbdb-display-record-one-line) (bbdb-display-record-multi-line): Use them. 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-mode-map): Inherit from special-mode-map. (bbdb-quit-window): Renamed from bbdb-bury-buffer. Use quit-window. (bbdb-mode): Use define-derived-mode. 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-indent-string): New function. (bbdb-display-record-multi-line): Use it. (Bug#33101) 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb-com.el: Autoload browse-url-url-at-point. 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-create-hook, bbdb-change-hook): Call add-hook for the default hook functions. BBDB is avaiable at http://git.savannah.nongnu.org/cgit/bbdb.git To check it out, use git clone git://git.savannah.nongnu.org/bbdb.git -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
[BBDB] Contributing to the new BBDB
Several people on this list have started to contribute to the new BBDB in one or the other way. I am quite happy to see that! I'd like to outline my view / strategy for that: I'd be happy to see a proper release of the new BBDB in the not to far future. To make BBDB really free software, I'd be glad if everyone who has previously contributed to the code of BBDB (code which is still contained in the new BBDB) as well as future contributors will agree to assign the copyright for their contribution to the Free Software Foundation. Ted Zlatanov has kindly agreed to help collecting these copyright assignments. Honestly, right now we really do not yet have an overview who has contributed what to BBDB. The more we are able to unfold these things, we'll try to contact the respective people and request they assign the copyright for their work to the FSF (similarly for new contributors to BBDB). Those who have been contributing to GNU Emacs and have previously signed copyright assignments for that, these people need not sign new paperwork. Yet BBDB is not (yet?) part of GNU Emacs. So these people are asked to just email fsf-reco...@gnu.org, and tell them that their work on BBDB should be considered part of their Emacs assignment. On Mon Apr 11 2011 Didier Verna wrote: For those of us who had write access to the old repo, is that still the case ? While I simply have no idea who has had write access to the old repo, I'll be happy to give write access to the new repo on savannah to anyone who will contribute to BBDB and can agree to the above procedures (and I hope this will be everyone who considers contributing to the new BBDB). From a more technical perspective, I've added a TODO file to the repo, which reflects my current view of what needs to be done. It would be great if anybody who wants to work on any of these things (or anything else related to BBDB) could let us know on this list. As usual, comments and suggestions are always welcome. Thanks again to everyone contributing to BBDB, Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: Is the feature to add/update record when sending emails useful?
On Fri Apr 15 2011 Leo wrote: I personally haven't used this much in Emacs. But since gmail does this and I have found it useful at times, I wonder if this feature should be part of the bbdb-mua feature set. I am sorry, it's not clear to me what you want to say here. The new BBDB treats outgoing messages (i.e., Emacs message and mail mode) like incoming messages in your Emacs MUA (Gnus, Rmail, VM, etc). So you can configure BBDB such that it updates BBDB based on outgoing messages in much the same way you can do this with incoming messages. Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: Replace bbdb-defstruct with defstruct?
On Fri Apr 15 2011 Leo wrote: I wonder if it makes sense to replace bbdb-defstruct with defstruct? What benefit(s) would you expect from that? I guess that bbdb-defstruct is about as efficient and effective as possible for the needs of BBDB. Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: Non-nil default value in hook variables
On Fri Apr 15 2011 Leo wrote: When people use add-hook they think they are adding another function to a hook so if this isn't the case it will surprise them. People who are setting hook to nil is in a different thinking. There are add-hook and remove-hook. The latter fails (now) if you want to remove the default hook function via a simple call to remove-hook in your .eamcs. It only works if you make sure it is called after loading bbdb. (Yet as I said, this case is probably more rare, so it is probably OK.) Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-04-10
On Mon Apr 11 2011 Nix wrote: On 11 Apr 2011, Roland Winkler told this: - Finally, I fixed various bugs and improved the documentation. I just noticed that BBDB development has restarted. Unfortunately BBDB 3.0 has removed a good few features, including one I definitely rely on: bbdb-canonicalize-net-hook, which is crucial to keep your database clean in the face of the large number of people with semiautomatically morphing addresses. I renamed this to bbdb-canonicalize-mail-function which is more in line with the naming conventions both of emacs in general and the new BBDB in particular. Is this done in some new way these days? Would you mind if I reimplemented it? (The v2.x BBDB's canonicalize-net-hook has just broken due to changes in the behaviour of run-hook-with-args in upstream Emacs bzr, to wit, that it always now returns nil if called with a hook list rather than a hook variable. This behaviour appears to be intentional: when you think about it it doesn't make much sense to return the value of any one hook function if there is more than one. A fix would be trivial, but if BBDB 2.x is dead, it may not be worth doing.) I have not tested bbdb-canonicalize-mail-function myself. So I do not know whether it is actually working. As usual bug reports are welcome. And bug fixes are yet more appreciated! (I'll also see if bbdb-expire works with v3.0x and make it work if it doesn't.) I believe this was some kind of add-on for BBDB. So it is probably broken right now. Again, if you can get it going again you might make more people happy. To merge such things into the new repo, it would be best if we can get not only your copyright assignment but also from the original author(s) / contributors of bbdb-expire. (See my other email on copyright.) Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-04-10
On 17 Apr 2011, Roland Winkler told this: On Mon Apr 11 2011 Nix wrote: (I'll also see if bbdb-expire works with v3.0x and make it work if it doesn't.) I believe this was some kind of add-on for BBDB. It was, making heavy use of advisements to do its job. If it isn't broken I'd be astonished. :) So it is probably broken right now. Again, if you can get it going again you might make more people happy. I wrote it, I rely on it, so I'm fairly sure I can get it going again :) probably tomorrow... To merge such things into the new repo, it would be best if we can get not only your copyright assignment but also from the original author(s) / contributors of bbdb-expire. (See my other email on copyright.) That would be me, me, and me. (I had suggestsions from other people, but no code.) I don't have an assignment for Emacs yet as far as I can recall (I might have one from many years ago: I wasn't keeping good records before about 2002, but I don't think so). I'm happy to sign one. (My employer (Oracle) signed a disclaimer for all its employees long since, so that part is done.) -- NULL (void) -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
[BBDB] builtbot (was: bbdb-mode-map should inherit from special-mode-map)
On Thu Apr 14 2011 David Engster wrote: I shortly tested compilation, and it works more or less fine for GNU Emacs22 to the latest GNU emacs-snapshot. XEmacs is another matter, though. I attached the current logs for XEmacs 21.4 and 21.5. Note that your 'PUSHPATH' eval doesn't work for XEmacs; just use -L .. I can set up a buildbot, but this only makes sense if all of the builds are working initially. So I'm afraid someone would have to volunteer to fix the XEmacs stuff first. :-) Is anybody interested in working on the XEmacs stuff? I do not know about XEmacs. Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-04-10
On Sun Apr 17 2011 Nix wrote: (I'll also see if bbdb-expire works with v3.0x and make it work if it doesn't.) I believe this was some kind of add-on for BBDB. It was, making heavy use of advisements to do its job. If it isn't broken I'd be astonished. :) If possible, I'd like to avoid using advice in any released code. If you find anything missing in the new BBDB that allowed bbdb-expire to work without advice, it's probably much cleaner to go that route! I wrote it, I rely on it, so I'm fairly sure I can get it going again :) probably tomorrow... OK! To merge such things into the new repo, it would be best if we can get not only your copyright assignment but also from the original author(s) / contributors of bbdb-expire. (See my other email on copyright.) That would be me, me, and me. (I had suggestsions from other people, but no code.) I don't have an assignment for Emacs yet as far as I can recall (I might have one from many years ago: I wasn't keeping good records before about 2002, but I don't think so). I'm happy to sign one. (My employer (Oracle) signed a disclaimer for all its employees long since, so that part is done.) Sounds good! Please see the questionaire below. (The package name is BBDB/EMACS.) Thaks a lot, Roland -- Please email the following information to fsf-reco...@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full name as the subject line of the message. [What is the name of the program or package you're contributing to?] [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your snail address here.] [Which files have you changed so far, and which new files have you written so far?] -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-04-10
On 17 Apr 2011, Roland Winkler stated: On Sun Apr 17 2011 Nix wrote: (I'll also see if bbdb-expire works with v3.0x and make it work if it doesn't.) I believe this was some kind of add-on for BBDB. It was, making heavy use of advisements to do its job. If it isn't broken I'd be astonished. :) This was a lie caused by my forgetting all about earlier improvements done around the days of BBDB 2.34. It *used* to make heavy use of advisements and engaged in actual redefinition of BBDB functions. Nowadays we get away with a single advisement: everything else is done via hooking. We rely on the bbdb-notice-hook's precise semantics: actually those semantics are not quite right for us so we modify them via the one piece of advice. If possible, I'd like to avoid using advice in any released code. If you find anything missing in the new BBDB that allowed bbdb-expire to work without advice, it's probably much cleaner to go that route! Oh, agreed. I just didn't want to require changes to BBDB for something as piddly as this. We're binding a variable to nil around the call to bbdb-update-records is called, then jamming things into that variable from various functions we add to the update-records hook so as to ensure that each such function is called only once per BBDB record, even if bbdb-update-records spots the same record a dozen times. (We use this to expire records that have been hit only once earlier than other records, on the grounds that they are probably spammers or flyby question-askers who don't need to be remembered for long.) We could do the same job with a new hook which is called only once per record, no matter how many times it is spotted by a given call to bbdb-update-records, or with a new guarantee that the bbdb-notice-hook would only fire once per record per call to bbdb-update-records. But in the absence of that, an advisement is the only neat approach. Please see the questionaire below. (The package name is BBDB/EMACS.) I might as well sign one for all of Emacs: I have a bunch of patches to that queued up for when the git repo ever unjams (if it ever does, sigh, maybe I'll be forced to use bloody bzr: but last time I tried to branch the emacs repo using that awful VCS I gave up after five hours). If I do an Emacs-wide one, will it apply to BBDB as well? (Sorry for the stupid question, but the packages are so tightly related...) -- NULL (void) -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-04-10
On Sun Apr 17 2011 Nix wrote: We could do the same job with a new hook which is called only once per record, no matter how many times it is spotted by a given call to bbdb-update-records, or with a new guarantee that the bbdb-notice-hook would only fire once per record per call to bbdb-update-records. But in the absence of that, an advisement is the only neat approach. First I wanted to say that bbdb-notice-hook is really in the wrong place and that it might be better to move it elsewhere in the code. Yet the functions in this hook can refer to the particular email address in a message which actually triggered the noticing of a record (and maybe we have a message with two email addresses for the same person, so that the same record is matched twice by one message). So it seems to me it is useful to keep this hook where and what it is. Yet it appears also useful beyond your particular problem to have a hook which is called for each message only once per record. This could be done in bbdb-update-records, or probably yet better in bbdb-mua-update-records. Do you have a good name for such a hook? I might as well sign one for all of Emacs: I have a bunch of patches to that queued up for when the git repo ever unjams (if it ever does, sigh, maybe I'll be forced to use bloody bzr: but last time I tried to branch the emacs repo using that awful VCS I gave up after five hours). If I do an Emacs-wide one, will it apply to BBDB as well? (Sorry for the stupid question, but the packages are so tightly related...) If someone has previously signed copyright assignments for GNU Emacs, these people need not sign new paperwork. Yet BBDB is not (yet?) part of GNU Emacs. So these people are asked to just email fsf-reco...@gnu.org, and tell them that their work on BBDB should be considered part of their Emacs assignment. If you have not yet signed any paperwork, it is probably the easiest if you simply say it is for Emacs and BBDB/Emacs. Roland -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] ChangLog 2011-04-16 (addendum)
Two many changes today. I lost track! 2011-04-16 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-create-hook, bbdb-change-hook): Use defvar. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
