Re: Fix wrong expansion of rules in bbdb-auto-notes
On Tue May 10 2011 Leo wrote: On 2011-05-09 02:59 +0800, Roland Winkler wrote: In principle there is no ambiguityconcerning lists and strings. All bbdb fields except for names and individual note fields are lists (and different notes are again forming a list). For your issue, a cleaner solution might be an optional argument merge for bbdb-record-set-field. That could make bbdb-annotate-notes completely obsolete. Do you want to look into this? OK, I'll look into this. Is the intention to extend BBDB-record-set-field to support setting sub-fields of notes too? ...I just noticed a problem I had not realized before: Currently bbdb-record-set-field assumes that its arg VALUE takes values that are by themselves valid for the respective field of a record. For a merge that would probably not make sense as I assume that VALUE for a merge should be a string. So maybe it is better to put the extension we are thinking about into bbdb-merge-note: - If its arg LABEL is either affix, aka, organization, or mail, this function could add a new element to the list of values of the respective field. - IF LABEL is name (or firstname, lastname), phone or address, it throws an error. (Unless someone has a great idea how to handle these cases in a better way. Such things can always be extended later. -- BBDB would get very confused if there were also note subfields with such labels.) - Any other value of LABEL should correspond to a proper note, so that this function should keep doing what it is doing now. Does this make sense? Possibly, this extended function should then be called bbdb-merge-field. Roland -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: Fix wrong expansion of rules in bbdb-auto-notes
On Wed May 11 2011 Roland Winkler wrote: So maybe it is better to put the extension we are thinking about into bbdb-merge-note: - If its arg LABEL is either affix, aka, organization, or mail, this function could add a new element to the list of values of the respective field. - IF LABEL is name (or firstname, lastname), phone or address, it throws an error. (Unless someone has a great idea how to handle these cases in a better way. Such things can always be extended later. -- BBDB would get very confused if there were also note subfields with such labels.) - Any other value of LABEL should correspond to a proper note, so that this function should keep doing what it is doing now. One more thought: currently bbdb-merge-note will add the same VALUE multiple times, even if it is already present. Is this useful? I am thinking here in particular of bbdb-auto-notes which started this thread. It might be better if it checked whether VALUE was already present. Only if not it merges old and new. Roland -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
[BBDB] Changelog 2010-05-11
On Sun Apr 17 2011 Nix wrote: I'd be inclined to say that the existing hook should have been called bbdb-notice-address-hook, so the new one could get called bbdb-notice-record-hook, I split bbdb-notice-hook into bbdb-notice-mail-hook and bbdb-notice-record-hook. I hope that this will make things easier for bbdb-expire such that it need not advice bbdb functions anymore. Does the new bbdb-notice-record-hook work the way you need it? (I renamed bbdb-notice-hook to bbdb-notice-mail-hook because I am trying to use address first of all for the snail mail addresses. I know that nonetheless things are not fully consistent in the code. Oh well...) Roland 2011-05-11 Roland Winkler wink...@gnu.org * lisp/bbdb.el (bbdb-notice-mail-hook): Rename from bbdb-notice-hook. (bbdb-notice-record-hook): New variable. (bbdb-notice-hook-pending): Update doc string. * lisp/bbdb-mua.el (bbdb-update-records): Call bbdb-notice-record-hook. (bbdb-annotate-message): Use bbdb-notice-mail-hook. * lisb/bbdb-vm.el (bbdb/vm-auto-add-label): Update doc string. BBDB is avaiable at http://git.savannah.nongnu.org/cgit/bbdb.git To check it out, use git clone git://git.savannah.nongnu.org/bbdb.git -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
[BBDB] Changelog 2010-05-11, part 2 (was: patch for bbdb-get-help-window)
On Tue May 10 2011 Sam Steingold wrote: PS. I would appreciate it if you would give me git commit rights. I don't mind giving you write access... 2011-05-10 Sam Steingold s...@gnu.org * bbdb-com.el (bbdb-get-help-window): use `special-mode' instead of setting `buffer-read-only' explicitly, this way we get all the special bindings for free ...though I do not know (yet) which version of BBDB you want to work on. bbdb-get-help-window was a function in BBDB v2, but in v3, it's been merged with bbdb-prompt-for-create. From a different perspective, the special bindings of special-mode are not used at all in this context. The help window is only used for displaying the help message. But the current buffer in that moment is the minibuffer. 2011-05-11 Roland Winkler wink...@gnu.org * lisp/bbdb-mua.el (bbdb-update-records): Fix previous patch. (bbdb-prompt-for-create): Use special-mode. BBDB is avaiable at http://git.savannah.nongnu.org/cgit/bbdb.git To check it out, use git clone git://git.savannah.nongnu.org/bbdb.git -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-05-11, part 2
* Roland Winkler jvax...@tah.bet [2011-05-11 11:25:25 -0500]: On Tue May 10 2011 Sam Steingold wrote: PS. I would appreciate it if you would give me git commit rights. I don't mind giving you write access... thanks. 2011-05-10 Sam Steingold s...@gnu.org * bbdb-com.el (bbdb-get-help-window): use `special-mode' instead of setting `buffer-read-only' explicitly, this way we get all the special bindings for free ...though I do not know (yet) which version of BBDB you want to work on. bbdb-get-help-window was a function in BBDB v2, but in v3, it's been merged with bbdb-prompt-for-create. I see. I use v2 for now, waiting for a clear upgrade path, i.e., the list of symbol renamings and make-obsolete declarations. From a different perspective, the special bindings of special-mode are not used at all in this context. The help window is only used for displaying the help message. But the current buffer in that moment is the minibuffer. yes, but getting rid of the help buffer by merely hitting q or z there is still useful. BBDB is avaiable at http://git.savannah.nongnu.org/cgit/bbdb.git To check it out, use git clone git://git.savannah.nongnu.org/bbdb.git yep, I have it and I am watching it for the appearance of make-obsolete forms :-) -- Sam Steingold (http://sds.podval.org/) on CentOS release 5.6 (Final) X 11.0.60900031 http://jihadwatch.org http://iris.org.il http://truepeace.org http://pmw.org.il http://www.memritv.org http://thereligionofpeace.com When C++ is your hammer, everything looks like a thumb. -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [BBDB] Changelog 2010-05-11, part 2
On Wed May 11 2011 Sam Steingold wrote: I use v2 for now, waiting for a clear upgrade path, i.e., the list of symbol renamings and make-obsolete declarations. It's all a matter of manpower which is limited. Help is always appreciated :-) yes, but getting rid of the help buffer by merely hitting q or z there is still useful. Sure. -- The new code should make it more unlikely that you ever see such a window though you do not want it. (Up to now, it has never become an issue for me.) Roland -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
