IvyDE JIRA issues and changes for proposed release?

[J Pai]

There’s been some good progress on reviving the Ivy project (thanks Nicolas and 
Jan for helping out with the reviews and merging PRs) and we seem to be moving 
towards a state where the release is a possibility. The other project IvyDE 
(the Eclipse plugin) however needs a bit more push I think. 

I am not a Eclipse user nor do I have any experience with plugin development, 
so there’s not much I can contribute on that front. However, there has been an 
external community member whose team(?) seemed to be interested in contributing 
to that plugin and in fact seem to have built some features on top of the 
current state of the plugin, in their own fork. They even proposed the 
contribution on the mailing list[1]. I suggested they raise a PR (to make it 
easier for review), but haven’t heard back. Given that and things in general, 
do we have someone who has experience of the code base plus Eclipse plugins who 
can help review that code? Furthermore, is there anything else the user has to 
do (like signing some CLA) for that contribution?

I think in general, do we have someone experienced with the plugin who can look 
at some of the IvyDE open JIRA issues/enhancements and decide which ones to fix 
in the upcoming release and make sure things work fine with the proposed Ivy 
release itself?

[1] https://www.mail-archive.com/dev@ant.apache.org/msg45486.html

-Jaikiran
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: IVYDE-382 proposed patch

[J Pai]

Hi Alexander,

I actually just realized that your initial mail actually had a patch file 
attached. I didn’t notice that before and only today noticed it while looking 
at the mail list archive. So assuming this applies cleanly on latest master 
branch of IvyDE, I think this should be fine too, instead of creating a PR. I 
am not experienced with Eclipse plugins, so I personally won’t be able to help 
much, but hopefully someone from the IvyDE team will be able to review and 
decide about this patch. Thank you again for contributing this.

-Jaikiran
On 26-May-2017, at 8:28 AM, J Pai  wrote:

Hi Alexander,

Thank you for volunteering to provide this feature patch. I had a look a the 
repo you pointed to and read the README. It does seem to contain a good amount 
of work in that branch in multiple commits. 

To make it easier for whoever will decide about merging these to upstream 
ant-ivyde project, would it to be possible for you to do the following:

1. *Fork* the ant-ivyde project (on github) 
https://github.com/apache/ant-ivyde/ into your account. There’s a “Fork” button 
on the right corner of the github page for the repo.
2. Once forked into your account, you can push your enhancement and bug fix 
related commits to either your master branch of your repo or any specific 
branch of your choice.
- If the bug fixes are independent of the feature, then it would be 
good if they are done in separate branches, so that a separate pull request 
(PR) can be issued.
3. Once you are ready with the commits, you can then issue a pull request (PR) 
from your repo to the “master” branch of the ant-ivyde upstream repo 
https://github.com/apache/ant-ivyde/.  Typically PRs are meant to contain 
commits that are all specific to a single feature or for a specific bug fix.

Once the PRs are submitted, I’m sure one or more members of the development 
team who have relevant knowledge of Eclipse and the project will review this 
and either merge it or provide inputs.

Thanks again for this, both Ivy and IvyDE project has been stagnant for a while 
and with contributions like these, we should be able to release out a new 
version soon.

-Jaikiran


On 25-May-2017, at 1:12 PM, alexander.bl...@arctis.at wrote:

Dear Sir or Madam,

as it was suggested in 
https://issues.apache.org/jira/browse/IVYDE-382?focusedCommentId=16018847=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16018847,
 we are sending you our proposed patch for 
https://issues.apache.org/jira/browse/IVYDE-382. The corresponding patch-file 
is attached to this email. The source code is available at 
https://github.com/alex-bl/ivyDEextension/tree/ivyDECredentials in the branch 
"ivyDECredentials". 

Yours sincerely,

Alexander Blaas


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

[jaikiran]

Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/38
  
Closing this PR, because looking at the commits in master branch, it looks 
like Jan already pulled in this commit. Thanks @janmaterne 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #38: IVY-1475 Throw an explicit BuildException if cache...

[jaikiran]

Github user jaikiran closed the pull request at:

https://github.com/apache/ant-ivy/pull/38


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/43
  
Here comes a bunch of new changes: I had to go for Commons Collections 4 to 
use generics, and threw in Commons CLI 1.4 for a good measure. I left HTTP 
Client 2.0 for the future lest this PR grows further 😃 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

[janmaterne]

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/43
  
I wont split this PR. Adress these in this PR:
- diamond operator
- renaming
- ModuleIdTest

The other things should be done in a new PR (PRs shouldnt be too big ;)
I wouldnt remove commons-collections as it is an example how to use 
external libs with Ivy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

[jaikiran]

Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/38
  
>> Maybe we could extract the method into FileUtil later.

I went ahead and moved it to `FileUtil` since it does make sense for it to 
be there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[ANN] Apache Compress Antlib 1.5 Released

[Stefan Bodewig]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

The Apache Compress Antlib offers tasks and types for archive and
compression formats. It supports gzip, xz, pack200, lzma, snappy, Unix
.Z, DEFLATE, LZ4, Brotli and bzip2 compression and ar, arj, cpio, tar,
Unix dump, 7z and zip archives.

Version 1.5 catches up with Apache Commons Compress 1.14 and adds
tasks and re-sources for LZ4 and DEFLATE, read-only support for Brotli
and write-support for Snappy and LZMA on top of the read-support
provided by verion 1.4 of this antlib.

Support for the XZ and LZMA compression formats is based on the XZ for
Java library of the Tukaani Project[1], which is required at runtime in
addition to Commons Compress.  Some 7z archives will require LZMA
support and thus XZ for Java as well.

Support for Brotli compression is based on Google's brotli dec
library[2], which is required at runtime in addition to Commons
Compress.

The full list of changes:

Changes that Could Break Older Environments:

* The coordinates inside the Ivy file have been changed to match those
  of the POM.

* The Apache Compress Antlib now requires Apache Commons Compress 1.14
  or later for 7z, DEFLATE, LZ4 and write support for LZMA and
  Snappy. XZ for Java 1.6 or later is required for write support for
  LZMA. Brotli dec 0.1.2 or later is required for Brotli support. As a
  side effect the Compress Antlib now requires Java 7 at runtime as this
  is required by Commons Compress 1.14.

Other Changes:

* A new keepCompression flag can be used to keep the content compression
  methods the same they have been when updating a 7z archive or adding
  entries from a sevenzfileset.
  
* Multiple content compression/encryption/filter methods can now be
  specified via nested elements of the sevenz task.
  
* The gzip task has a new attribute that controls the level of
  compression.
  BugZilla Issue 52414
  
* Added write support for the LZMA format.

* Added support for the DEFLATE format with and without ZLIB headers.

* Added write support for the Snappy format.

* Added support for the LZ4 format.

* Added read-only support for the Brotli format.

Source and binary distributions are available from the Apache Ant
download site:

http://ant.apache.org/antlibs/bindownload.cgi

and

http://ant.apache.org/antlibs/srcdownload.cgi

Please verify signatures using the KEYS file available at the above
location when downloading the release.

For complete information on the Compress Antlib, including instructions
on how to submit bug reports, patches, or suggestions for improvement,
see the Apache Compress Antlib website:

http://ant.apache.org/antlibs/compress/index.html

Stefan Bodewig, on behalf of the Apache Ant community

[1] http://tukaani.org/xz/java.html
[2] https://github.com/google/brotli
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iEYEARECAAYFAlk/0ukACgkQohFa4V9ri3LMOACbBraLs/4FXox3e24BFON9BBy+
nS0An3ScbWB9BSmy/3MUYqU5TnDC/ycl
=Pf0s
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

[janmaterne]

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/38
  
All fine with me. Maybe we could extract the method into FileUtil later. 
I'll merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

[twogee]

GitHub user twogee reopened a pull request:

https://github.com/apache/ant-ivy/pull/43

Generics and other fixes in tests and tutorials

foreach loops are more terse than iterators, and they go well together with 
generic -- here's the first stab 😃 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit 8b9f2d5177c849b37809ab38035e1d757d963314
Author: twogee 
Date:   2017-06-10T06:56:44Z

Generics and other fixes in tests and tutorials

commit 8f35a1d28e795833e6a095ff55ecc37f3db882aa
Author: twogee 
Date:   2017-06-10T22:26:54Z

More foreach loops

commit 314dfa80d4e815ba3c689cd3ad0d508209665bf6
Author: twogee 
Date:   2017-06-11T02:38:47Z

More generics…




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #43: Generics and other fixes in tests and tutorials

[twogee]

Github user twogee closed the pull request at:

https://github.com/apache/ant-ivy/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

[twogee]

Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/43
  
Thank you for comments, I'll split the PR and correct according to your 
suggestions. Should I remove common-colections altogether and use collections 
with generics from Java runtime?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

[jaikiran]

Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/38
  
>> requireCommonBaseDir:
>>could we replace firstPath by base==null?
>>   line 115: additional comment:
>>'fail fast: ...'
>>line 117: 'finally we got ...'

Done and PR updated

>> getBaseDir:
>>
>>Rename parameter to file1 and file2. For me it seems that both 
parameters are indepent from each other. 'base' implies that it's itself a 
parent of the other.

You are right about that. So I changed the param names and updated the 
javadoc too. Please have a look in the updated PR and let me know if it makes 
sense now.

>> you changed the semantic of the method:
>> base==null && file==null --> old=NPE, new=null (ok with me ;)
>> base==null && file!=null --> old=file.paren, new=null (incompatible 
change)
>> base!=null && file==null --> both=null
>> base!=null && file!=null --> both=commonBase
>> could be static, maybe moved to a FileUtil-class

When I started implementing the changes for this bug fix, I had a look at 
this method and its references. In reality, this `getBaseDir` essentially 
can/should be a private method. The only reason why it's package private right 
now is to have access to this method in a test case. There are no other 
references to this and given that this is a package private method, there's no 
other way this method can be by any other (external) code then that specific 
package. Given this background, I decided to intentionally make that 
incompatible semantic change so that it now fits in with the expectations of 
how we want it to behave. Do you think that should be good enough reason to go 
ahead with this change in semantics of this method?






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #38: IVY-1475 Throw an explicit BuildException if cachefileset...

[janmaterne]

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/38
  
requireCommonBaseDir: 
- could we replace firstPath by base==null?
- line 115: additional comment:
  'fail fast: ...'
- line 117: 'finally we got ...'

getBaseDir:
- Rename parameter to file1 and file2. For me it seems that both parameters 
are indepent from each other. 'base' implies that it's itself a parent of the 
other.
- you changed the semantic of the method:
  base==null && file==null --> old=NPE, new=null  (ok with me ;)
  base==null && file!=null --> old=file.paren, new=null (incompatible 
change)
  base!=null && file==null --> both=null
  base!=null && file!=null --> both=commonBase
- could be static, maybe moved to a FileUtil-class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #44: IVY-1561 - Enhancement to take into account environment a...

[janmaterne]

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/44
  
merged, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #44: IVY-1561 - Enhancement to take into account enviro...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/44


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

[janmaterne]

Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/43
  
Java7 supports the diamond operator and Ivy's baseline is now Java7. So you 
could use that (e.g. CCFilter.java).

HMFilter: one advantage of foreach is having a meaningful iterator name. So 
renaming s/string/value/ would be more readable.

HelloIvy: maybe you could change the hello-message: s/hello ivy !/Hello 
Ivy!/

src/example/multi-project/projects/find/src/find/Main.java: maybe also 
change from raw Collection to Collection, so the foreach could also be 
typed. This would impact FindFile.
--> better in a separate PR

Same for src/example/multi-project/projects/list/src/list/Main.java
--> better in a separate PR

Same src/example/multi-project/projects/size/src/size/FileSize.java
--> better in a separate PR

test/java/org/apache/ivy/core/module/id/ModuleIdTest.java
You changed the semantics:
  assertFalse(moduleId.equals(null)) --> asserts that moduleId is not null 
(otherwise a NPE would be thrown) and it's equal-comparison returns false
  assertNotNull(moduleId) --> 'just' assert that moduleId is not null
--> maybe just place the notnull before the assertfalse?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[RESULT] Release Compress Antlib 1.5 based on RC3

[Stefan Bodewig]

Hi all

with +1s by Nicolas, Jan and myself and no other votes this vote has
passed.

I'll publish the artifacts and give the mirrors time to catch up before
sending out the announcement.

Thanks to all who took the time to look into any of the several RCs.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: [VOTE] Release Compress Antlib 1.5 based on RC3

[jhm]

> Should we include the PGP [e.g. 1] signature in the future?

Answer myself: should be only on ASF server, so people could trust that ;)
Maybe place a note (next time) how to check that (do we have a build snippet
for that?)

Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

AW: [VOTE] Release Compress Antlib 1.5 based on RC3

[jhm]

+1
Should we include the PGP [e.g. 1] signature in the future?

Jan

[1]
https://dist.apache.org/repos/dist/dev/ant/antlibs/compress/binaries/apache-
ant-compress-1.5-bin.zip.asc

> -Ursprüngliche Nachricht-
> Von: Stefan Bodewig [mailto:bode...@apache.org]
> Gesendet: Samstag, 10. Juni 2017 22:39
> An: dev@ant.apache.org
> Betreff: Re: [VOTE] Release Compress Antlib 1.5 based on RC3
> 
> On 2017-06-08, Stefan Bodewig wrote:
> 
> > I've created a new release candidate for Compress Antlib 1.5, this
> time
> > the source distribution should contain everything needed to build.
> 
> > git tag: 1_5_RC3
> >  on commit: 3194691
> > tarballs:
> https://dist.apache.org/repos/dist/dev/ant/antlibs/compress/
> >   revision: 19936
> > Maven artifacts:
> >
> https://repository.apache.org/content/repositories/orgapacheant-
> 1019/org/apache/ant/ant-compress/1.5/
> 
> > This Vote will be open at least for 72 hours and close no earlier
> than
> > 2017-06-11 12:00UTC.
> 
> +1
> 
> Stefan
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org