Re: Method of Unit Testing for Collections

2016-08-25 Thread Pascal Schumacher
I took a look a some tests, some are using JUnit 3 (e.g. ArrayStackTest) 
and others are using JUnit 4 (e.g. BagUtilsTest).


You should be able to run the with mvn test from the command line and as 
JUnit tests in your IDE.


Cheers,
Pascal

Am 25.08.2016 um 18:51 schrieb Landon Blake:

I was taking a look at the code for Collections. I did see a big set of
unit tests. However, I couldn't figure out what library was being used to
run the unit tests. I didn't see any JUnit import statements in the
beginning of any of the test classes, and if they are unit tests, they are
old, because I didn't see any JUnit 4 annotations either.

I was hoping to work with Ustav a bit on some of the collections code, but
wanted to make sure we could run all of the unit tests first.

Can anyone give us a bit of help on this?

Thanks!

Landon





Method of Unit Testing for Collections

2016-08-25 Thread Landon Blake
I was taking a look at the code for Collections. I did see a big set of
unit tests. However, I couldn't figure out what library was being used to
run the unit tests. I didn't see any JUnit import statements in the
beginning of any of the test classes, and if they are unit tests, they are
old, because I didn't see any JUnit 4 annotations either.

I was hoping to work with Ustav a bit on some of the collections code, but
wanted to make sure we could run all of the unit tests first.

Can anyone give us a bit of help on this?

Thanks!

Landon

-- 
Landon
"Homemade cookies. Hmm!"

Web: www.landonblake.com

LinkedIn: https://www.linkedin.com/in/landonblake

Google+: https://plus.google.com/u/0/+LandonBlake

Facebook: https://www.facebook.com/scott.l.blake.3

Pinterest: https://www.pinterest.com/landon_blake/

Sumry: https://sumry.me/landonblake

About.Me: https://about.me/landonblake


Jenkins build is back to normal : commons-net #15

2016-08-25 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Jenkins build is back to normal : commons-net ยป Apache Commons Net #15

2016-08-25 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Review for PR

2016-08-25 Thread sebb
On 25 August 2016 at 17:04, Raviteja Lokineni
 wrote:
> The pull request is closed. If you like people to review and merge it:
>
>1. It should be open
>2. There should be an associated JIRA issue

Good advice.

Also note that most developers work on ASF projects in their own time,
so bugs may take a while to get fixed.

As it happens, this one was trivial (no testing needed) so I fixed it
in SVN already, so no need to raise the JIRA.

In general it's hard work keeping track of PRs/fixes sent to the mailing list.
Unless they are dealt with immediately they are likely to get forgotten.


> Thanks,
> Raviteja
>
> On Wed, Aug 24, 2016 at 7:37 AM, Utsav Oza  wrote:
>
>> While surfing through the code base I encountered few spelling errors in
>> the comments provided alongside the code. Please review this pull request
>> and let me know if I am attempting anything in a wrong way or not.
>>
>> https://github.com/apache/commons-net/pull/4
>>
>> Regards
>> Utsav
>>
>
>
>
> --
> *Raviteja Lokineni* | Business Intelligence Developer
> TD Ameritrade
>
> E: raviteja.lokin...@gmail.com
>
> [image: View Raviteja Lokineni's profile on LinkedIn]
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Review for PR

2016-08-25 Thread Raviteja Lokineni
The pull request is closed. If you like people to review and merge it:

   1. It should be open
   2. There should be an associated JIRA issue

Thanks,
Raviteja

On Wed, Aug 24, 2016 at 7:37 AM, Utsav Oza  wrote:

> While surfing through the code base I encountered few spelling errors in
> the comments provided alongside the code. Please review this pull request
> and let me know if I am attempting anything in a wrong way or not.
>
> https://github.com/apache/commons-net/pull/4
>
> Regards
> Utsav
>



-- 
*Raviteja Lokineni* | Business Intelligence Developer
TD Ameritrade

E: raviteja.lokin...@gmail.com

[image: View Raviteja Lokineni's profile on LinkedIn]



Re: Maven artifacts for commons.io 2.5 corrupt

2016-08-25 Thread Jochen Wiedmann
And, in particular: Where, and what, did you download? Jar file from a
Maven repositoiry? Which repo?


On Wed, Aug 24, 2016 at 9:51 PM, sebb  wrote:
> A quick jar listing looks OK to me.
>
> Have you checked the hash to make sure the jar was downloaded OK?
>
> Which classes are empty?
>
>
> On 24 August 2016 at 19:37, P Holder  wrote:
>> I don't know if anyone else has reported this, as I am not on any of
>> the mail lists, but I didn't want to leave it unreported.
>>
>> Yesterday I added commons.io 2.5 to my project, and was getting class
>> loading errors.  I looked at the downloaded jar, and there were a lot
>> of 0 byte class files in it.  I switched to 2.4 and it worked fine.
>>
>> Paul
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>



-- 
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org