[all/travis-ci] Regarding potential Travis-CI solutions

2017-08-03 Thread Rob Tompkins
Hello all,

We have an open pull request from Amey 
(https://github.com/apache/commons-text/pull/61 
) proposing a fairly 
complicated but quite nice travis-ci build solution (taken from the jacoco 
project) that accommodates building on JDK7, JDK8, JDK8-ea, EclipseJava, 
JDK9-ea, as well as IBMJava-8. To accommodate building on all of these 
different versions of Java, we do however need to make the travis-ci build a 
good deal more complex. 

As the two reviewers on the pull request, Pascal and myself, have mildly 
differing opinions on the complexity-value trade off here, with Pascal’s 
opinion being: "…[T]his is overkill. I don't think commons-text needs to be 
tested against the eclipse java compiler and early access versions of java 8 
and 9. The script looks difficult to debug and maintain.” And my perspective is 
that this could be a test piece for using this elsewhere in commons.

To me, the argument for simplicity is always quite compelling, to the point 
that I’m mostly willing to let go of using the jacoco travis-ci pattern. But I 
figured I would, before making any decisions, see what the community thinks 
generally about this possible travis-ci build script.

Cheers,
-Rob

Re: [VOTE] Release Apache Commons JCS 2.2 based on RC1

2017-08-03 Thread Oliver Heger
Build works fine with Java 1.6 on Windows 10. Artifacts and site look good.

Nits (not blocking):
- All jars for the different modules are OSGi bundles, but they have the
same Bundle-SymbolicName. The name should be unique.
- The site build fails with Java 1.8 due to Javadoc warnings.
- The RAT report of the top-level project contains a spurious file.
- There are some PMD and Findbugs warnings which might be worth having a
look.

+1
Oliver

Am 02.08.2017 um 15:32 schrieb Thomas Vandahl:
> I would like to release the [jcs] component to resolve some overdue bugs
> 
> Apache Commons JCS 2.2 RC1 is available for review at:
>   https://dist.apache.org/repos/dist/dev/commons/jcs/ (r20728).
> 
> Maven artifacts are at:
>   https://repository.apache.org/content/repositories/orgapachecommons-1256 .
> 
> The Subversion tag is:
> 
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2
> (r1803806).
> 
> The release notes are at:
> 
> https://svn.apache.org/repos/asf/commons/proper/jcs/tags/commons-jcs-2.2/RELEASE-NOTES.txt
> (r1803806).
> 
> The staged site is available as a tarball at
> 
> https://dist.apache.org/repos/dist/dev/commons/jcs/commons-jcs-site-2.2.tar.gz
> (r20723).
> 
> Please review the release candidate and vote.
> 
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
> 
> Bye, Thomas
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



[GitHub] commons-text pull request #61: Added flexible Travis-ci build script.

2017-08-03 Thread ameyjadiye
Github user ameyjadiye commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/61#discussion_r131239555
  
--- Diff: pom.xml ---
@@ -171,6 +171,7 @@
   src/site/resources/download_lang.cgi
   
src/test/resources/stringEscapeUtilsTestData.txt
   
src/site/resources/release-notes/RELEASE-NOTES-*.txt
+  .travis.sh
--- End diff --

which part of their license shall I add ? content of their ```License.md``` 
? seems like they distribut code with eclipse license.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Help with task: Implement Ziggurat algorithm

2017-08-03 Thread Amey Jadiye
Hello 仓央杰克 ,

If you are not in possition to submit this I'm taking this task up for
completion.

I will submit my PR in a week or so you may give your inputs on that.

Regards,
Amey


On Jul 5, 2017 10:20 AM, "Amey Jadiye"  wrote:

code should go in commons rng btw. here is repo link and contribution guide
lines

https://github.com/apache/commons-rng

Regards,
Amey


On Tue, Jul 4, 2017, 11:46 PM Amey Jadiye  wrote:

> Hello,
>
> your contribution will always be welcome, you can provide your code via
> github pull request.
> read contribution guidelines before submitting PR,
> https://github.com/apache/commons-numbers
>
> Regards,
> Amey
>
> On Mon, Jun 19, 2017 at 8:00 PM, 仓央杰克  wrote:
>
>> I would like to help out with the task listed at
>> https://helpwanted.apache.org/task.html?9d71a269
>>
>
>
>
> --
>
> -
>
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>
> For additional commands, e-mail: dev-h...@commons.apache.org
>


Re: Attaching Apache repository pushes to GitHub page

2017-08-03 Thread Matt Sicker
Add your GitHub username to your LDAP profile by visiting
https://id.apache.org/

On 3 August 2017 at 06:55, Jörg Schaible 
wrote:

> Hi Eric,
>
> Eric Barnhill wrote:
>
> > I am applying for jobs soon and want my work on commons-numbers to be
> > visible on my GitHub page. However I am pushing to an Apache repository
> > rather than to my own fork, so it doesn't show up on my GitHub page. Is
> > there a way to link the two?
>
> it should work if you add your Apache email address to the email addresses
> in your GitHub profile.
>
> Cheers,
> Jörg
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
Matt Sicker 


Re: Attaching Apache repository pushes to GitHub page

2017-08-03 Thread Jörg Schaible
Hi Eric,

Eric Barnhill wrote:

> I am applying for jobs soon and want my work on commons-numbers to be
> visible on my GitHub page. However I am pushing to an Apache repository
> rather than to my own fork, so it doesn't show up on my GitHub page. Is
> there a way to link the two?

it should work if you add your Apache email address to the email addresses 
in your GitHub profile.

Cheers,
Jörg


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



Re: Attaching Apache repository pushes to GitHub page

2017-08-03 Thread Eric Barnhill
Do you mean what is listed under "forwarding email" in my apache.org email
account?

I believe all my pushes to apache are under my apache.org email address.

On Thu, Aug 3, 2017 at 1:44 PM, Allon Mureinik  wrote:

> Assuming you're using the same email to contribute to commons-numbers as
> you use for your GitHub profile, staring the Apache repository should do
> the trick.
> See also [1] for some other common pitfalls that you may have encountered
>
> [1]
> https://help.github.com/articles/why-are-my-contributions-not-showing-up-
> on-my-profile/
>
> On Thu, Aug 3, 2017 at 2:38 PM, Eric Barnhill 
> wrote:
>
> > I am applying for jobs soon and want my work on commons-numbers to be
> > visible on my GitHub page. However I am pushing to an Apache repository
> > rather than to my own fork, so it doesn't show up on my GitHub page. Is
> > there a way to link the two?
> >
>


Re: Attaching Apache repository pushes to GitHub page

2017-08-03 Thread Allon Mureinik
Assuming you're using the same email to contribute to commons-numbers as
you use for your GitHub profile, staring the Apache repository should do
the trick.
See also [1] for some other common pitfalls that you may have encountered

[1]
https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile/

On Thu, Aug 3, 2017 at 2:38 PM, Eric Barnhill 
wrote:

> I am applying for jobs soon and want my work on commons-numbers to be
> visible on my GitHub page. However I am pushing to an Apache repository
> rather than to my own fork, so it doesn't show up on my GitHub page. Is
> there a way to link the two?
>


Attaching Apache repository pushes to GitHub page

2017-08-03 Thread Eric Barnhill
I am applying for jobs soon and want my work on commons-numbers to be
visible on my GitHub page. However I am pushing to an Apache repository
rather than to my own fork, so it doesn't show up on my GitHub page. Is
there a way to link the two?


Re: commons-numbers git commit: NUMBERS-13: Some tests in the old ComplexTest tested the old NaN behavior (i.e. turn the whole Complex into NaN) and these were deleted. There is also an error in the t

2017-08-03 Thread Eric Barnhill
You are right, this commit applied to ComplexUtils and I believe it is
reverted and fixed. Unfortunately which commit contains the edits to
ComplexTest I cannot figure out.

On Mon, Jul 31, 2017 at 4:54 PM, Gilles 
wrote:

> Eric,
>
> On Mon, 31 Jul 2017 11:32:12 + (UTC), ericbarnh...@apache.org wrote:
>
>> Repository: commons-numbers
>> Updated Branches:
>>   refs/heads/complex-dev 387f4e09b -> 0a01e2d0e
>>
>>
>> NUMBERS-13: Some tests in the old ComplexTest tested the old NaN
>> behavior (i.e. turn the whole Complex into NaN) and these were
>> deleted. There is also an error in the testSerial() method and this
>> has been commented out for the time being so that the package
>> installs.
>>
>
> The message does not seem to apply to the changes reported below.
>
> Gilles
>
> P.S. Nit-pick about git log: One short summary line would avoid
>  lengthy "Subject: " line in notification email.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
>> Commit:
>>
>> http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/0a01e2d0
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/
>> 0a01e2d0
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/
>> 0a01e2d0
>>
>> Branch: refs/heads/complex-dev
>> Commit: 0a01e2d0e7e6c6621cbf6b5c2c7da885c1691c07
>> Parents: 387f4e0
>> Author: Eric Barnhill 
>> Authored: Mon Jul 31 13:34:18 2017 +0200
>> Committer: Eric Barnhill 
>> Committed: Mon Jul 31 13:34:18 2017 +0200
>>
>>
>> --
>>  .../commons/numbers/complex/ComplexUtils.java   | 36
>> 
>>  1 file changed, 36 insertions(+)
>>
>> --
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/
>> 0a01e2d0/commons-numbers-complex/src/main/java/org/apache/
>> commons/numbers/complex/ComplexUtils.java
>>
>> --
>> diff --git
>>
>> a/commons-numbers-complex/src/main/java/org/apache/commons/n
>> umbers/complex/ComplexUtils.java
>>
>> b/commons-numbers-complex/src/main/java/org/apache/commons/n
>> umbers/complex/ComplexUtils.java
>> index e41709c..529521d 100644
>> ---
>>
>> a/commons-numbers-complex/src/main/java/org/apache/commons/n
>> umbers/complex/ComplexUtils.java
>> +++
>>
>> b/commons-numbers-complex/src/main/java/org/apache/commons/n
>> umbers/complex/ComplexUtils.java
>> @@ -338,6 +338,24 @@ public class ComplexUtils {
>>  }
>>
>>  /**
>> + * Converts a 2D real {@code float[][]} array to a 2D {@code
>> Complex[][]}
>> + * array.
>> + *
>> + * @param d 2D array
>> + * @return 2D {@code Complex} array
>> + *
>> + * @since 1.0
>> + */
>> +public static Complex[][] real2Complex(float[][] d) {
>> +final int w = d.length;
>> +final Complex[][] c = new Complex[w][];
>> +for (int n = 0; n < w; n++) {
>> +c[n] = ComplexUtils.real2Complex(d[n]);
>> +}
>> +return c;
>> +}
>> +
>> +/**
>>   * Converts a 3D real {@code double[][][]} array to a {@code
>> Complex [][][]}
>>   * array.
>>   *
>> @@ -356,6 +374,24 @@ public class ComplexUtils {
>>  }
>>
>>  /**
>> + * Converts a 3D real {@code float[][][]} array to a {@code
>> Complex [][][]}
>> + * array.
>> + *
>> + * @param d 3D complex interleaved array
>> + * @return 3D {@code Complex} array
>> + *
>> + * @since 1.0
>> + */
>> +public static Complex[][][] real2Complex(float[][][] d) {
>> +final int w = d.length;
>> +final Complex[][][] c = new Complex[w][][];
>> +for (int x = 0; x < w; x++) {
>> +c[x] = ComplexUtils.real2Complex(d[x]);
>> +}
>> +return c;
>> +}
>> +
>> +/**
>>   * Converts a 4D real {@code double[][][][]} array to a {@code
>> Complex [][][][]}
>>   * array.
>>   *
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>