Re: maven-assembly-plugin / Maven default folder layout
Hello Karl-Heinz, I thought you said appassembler would put configs wrongly into src/main/config instead of src/config. Now it seems the stuff is included in the artifact. IMO stuff going into the artifact should be beneath src/main while configs for e.g. plugins should go to src/config (say checkstyle excludes).. Regards Mirko -- Sent from my mobile On Mar 14, 2014 10:58 PM, "Dennis Lundberg" wrote: > Hi, > > Did you change from src/main/config to src/config on purpose? > > In this case (i.e. when using the appassembler plugin) it really > should be src/main/config, because the contents of that directory will > end up in the main artifact. Similar to resources which might not be > required at compile time, but will be required at runtime. > > On Fri, Mar 14, 2014 at 6:45 PM, Karl Heinz Marbaise > wrote: > > Hi, > > > > so based on the discussion we can conclude the result as follows: > > > > > > src/main > > * are files required during compile time (production) > > > > src/main/java > > src/main/resources > > src/main/filters > > > > > > src/test > > * are files required during test time (unit testing; based on naming > > schema we could also have integration tests here) > > > > src/test/java > > src/test/resources > > src/test/filters > > > > > > src/it > > * are files required during integration tests > > (primarily for plugins) > > > > src/assembly > > * for assembly descriptors and appropriate filter property files. > > > > src/config > > * for configuration files. > > > > src/main/filters > > * Resource filter files > > > > src/main/scripts > > * Application/Library scripts > > > > src/main/webapp > > * Web application sources > > > > src/site > > * Maven Site > > > > So the default folder layout site should be updated. > > > > src/it is currently not on the site in any way... > > > > > > Kind regards > > Karl-Heinz Marbaise > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > Dennis Lundberg > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: maven-assembly-plugin / Maven default folder layout
Hi, Did you change from src/main/config to src/config on purpose? In this case (i.e. when using the appassembler plugin) it really should be src/main/config, because the contents of that directory will end up in the main artifact. Similar to resources which might not be required at compile time, but will be required at runtime. On Fri, Mar 14, 2014 at 6:45 PM, Karl Heinz Marbaise wrote: > Hi, > > so based on the discussion we can conclude the result as follows: > > > src/main > * are files required during compile time (production) > > src/main/java > src/main/resources > src/main/filters > > > src/test > * are files required during test time (unit testing; based on naming > schema we could also have integration tests here) > > src/test/java > src/test/resources > src/test/filters > > > src/it > * are files required during integration tests > (primarily for plugins) > > src/assembly > * for assembly descriptors and appropriate filter property files. > > src/config > * for configuration files. > > src/main/filters > * Resource filter files > > src/main/scripts > * Application/Library scripts > > src/main/webapp > * Web application sources > > src/site > * Maven Site > > So the default folder layout site should be updated. > > src/it is currently not on the site in any way... > > > Kind regards > Karl-Heinz Marbaise > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Mirko, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. Why for the appassembler-maven-plugin ? It currently uses src/config ? Should appassembler-maven-plugin stop using src/config ? Hm... Kind regards Karl-Heinz Marbaise done so. That's of course rubbish ... http://jira.codehaus.org/browse/MNGSITE-195 I meant for the site to be updated... Kind regards Karl-Heinz Marbaise Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Fri, Mar 14, 2014 at 6:40 PM, Karl Heinz Marbaise wrote: Hello Dennis, src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. Ah damn...Just forgot about that...;-) Thanks for that hint. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. What i missed: What is about src/main/config ? I would suggest to remove it from the default folder layout, cause i can't remember a case where it is used ? Someone else? - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Mirko, > Karl-Heinz, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. done so. http://jira.codehaus.org/browse/MNGSITE-195 Kind regards Karl-Heinz Marbaise Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Fri, Mar 14, 2014 at 6:40 PM, Karl Heinz Marbaise wrote: Hello Dennis, src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. Ah damn...Just forgot about that...;-) Thanks for that hint. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. What i missed: What is about src/main/config ? I would suggest to remove it from the default folder layout, cause i can't remember a case where it is used ? Someone else? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Karl-Heinz, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ On Fri, Mar 14, 2014 at 6:40 PM, Karl Heinz Marbaise wrote: > Hello Dennis, > > >> src/main/config is used as the default value for configuration files >> >> in appassembler-maven-plugin @Mojo. > > > Ah damn...Just forgot about that...;-) > > Thanks for that hint. > > >> >> On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise >> wrote: >>> >>> Hi, >>> >>> >>> On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. >>> >>> What i missed: >>> >>> What is about >>> >>> src/main/config ? >>> >>> I would suggest to remove it from the default folder layout, cause i >>> can't >>> remember a case where it is used ? Someone else? >>> >>> > Kind regards > Karl-Heinz Marbaise > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hello Dennis, > src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. Ah damn...Just forgot about that...;-) Thanks for that hint. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. What i missed: What is about src/main/config ? I would suggest to remove it from the default folder layout, cause i can't remember a case where it is used ? Someone else? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi, so based on the discussion we can conclude the result as follows: src/main * are files required during compile time (production) src/main/java src/main/resources src/main/filters src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) src/test/java src/test/resources src/test/filters src/it * are files required during integration tests (primarily for plugins) src/assembly * for assembly descriptors and appropriate filter property files. src/config * for configuration files. src/main/filters * Resource filter files src/main/scripts * Application/Library scripts src/main/webapp * Web application sources src/site * Maven Site So the default folder layout site should be updated. src/it is currently not on the site in any way... Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: > Hi, > > > On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: >> >> So based on the discussion could we go with the following: >> >> /src/main >> * are files required during compile time (production) >> >> /src/test >> * are files required during test time (unit testing; based on naming >> schema we could also have integration tests here) >> >> /src/it >> * are files required during integration tests (primarily for plugins) >> >> /src/assembly >> * for assembly descriptors and appropriate filter property files. >> >> The /src/it/ should be added to the default folder layout page. >> > > What i missed: > > What is about > > src/main/config ? > > I would suggest to remove it from the default folder layout, cause i can't > remember a case where it is used ? Someone else? > > > > Kind regards > Karl-Heinz Marbaise > > > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
It could be used for build-time configuration files, which are not part of the artifact / shouldn't be available on the classpath. I've never used it. I think it's too rare, so I agree that it can be removed. Robert Op Tue, 11 Mar 2014 21:57:43 +0100 schreef Karl Heinz Marbaise : Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. What i missed: What is about src/main/config ? I would suggest to remove it from the default folder layout, cause i can't remember a case where it is used ? Someone else? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. What i missed: What is about src/main/config ? I would suggest to remove it from the default folder layout, cause i can't remember a case where it is used ? Someone else? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Michael, You forgot: src/site. No, cause it's already part of the default folder layout. Kind Regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Michael, > Always use a relative path in the docs otherwise it could be misinterpreted. Of course you are right.. Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Michael, I do not want to enforce any real or precieved connection between a phase and an assembly. As you say, there is no such thing for assemblies. They are either triggered implicitly during the package phase och explicitly using an execution. On Sun, Mar 9, 2014 at 11:41 AM, Michael Osipov wrote: > Am 2014-03-08 22:24, schrieb Dennis Lundberg: > >> Hi >> >> I agree with Karl Heinz that the Assembly Plugin should support the >> documented default directory. >> >> It seems that we disagree about what the preferred directory should >> be. I think it should be src/main/assembly/ because almost all >> assemblies I have ever seen are for the main part of a project. If >> someone wanted to create an assembly for the test part of a project I >> would recommend to place the assembly descriptor in src/test/assembly. > > > Dennis, > > neither do you have src/main/site and other resembling structures. There is > no way to enforce that this "assembly" is part of a test cycle, moreover > such a notion does not exist for assemblies. > > Michael > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Robert, I think we are talking past each other here. From what you are writing we seem to agree that having an assembly for stuff in the src/test directory doesn't make little sense. I'm not opposed to changing things that are not working well. I'm just trying to make sure that the change will benefit our users, and also it does not lead to more support issues than we have today. On Sun, Mar 9, 2014 at 11:31 AM, Robert Scholte wrote: > I would call it advancing insight. I can't think of an assembly which is > only for unittesting (due to the src/test folder) and won't be attached the > the MavenProject for deployment. > > For users it would make it clear: > everything under /src/main are files required during compile time > everything under /src/test are files required during test time > everything under /src/it are files required during integration tests > assembly descriptors doesn't cover one of these, so it should have its own > folder. > > While Maven-core uses src/main/assembly for years doesn't mean that we could > adjust our advice. > > Robert > > Op Sat, 08 Mar 2014 23:57:06 +0100 schreef Dennis Lundberg > : > > >> Hi Robert, >> >> I was not thinking about scope here, just the directory structure of >> the project. >> >> We've used src/main/assembly for years now. Maven-core has its >> assembly descriptors in src/main/assembly. It seems strange to >> suddenly change it. In what way would our users benefit from this >> change? >> >> On Sat, Mar 8, 2014 at 10:41 PM, Robert Scholte >> wrote: >>> >>> Hi Dennis, >>> >>> an assembly will always result in an attachment, but there's no such >>> thing >>> as attaching with a scope. >>> For that reason I wouldn't separate the assembly descriptors, it might >>> cause >>> invalid assumptions. >>> >>> Robert >>> >>> >>> Op Sat, 08 Mar 2014 22:24:10 +0100 schreef Dennis Lundberg >>> : >>> >>> Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. If someone wanted to create an assembly for the test part of a project I would recommend to place the assembly descriptor in src/test/assembly. On Fri, Mar 7, 2014 at 8:25 PM, Robert Scholte wrote: > > > Hi, > > This is the standard (preferred) directory layout, so it doesn't have > to > be > the default. > I actually think that src/main/assembly/ should be src/assembly/, > otherwise > it would imply that there can also be a src/test/assembly/. I wouldn't > separate the descriptors into different folders. > > Robert > > Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise > : > > >> Hi, >> >> I stumbled over a small thing. >> >> The page about the default folder layout >> >> >> >> https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html >> >> mentioned a location for the maven-assembly-plugin descriptors: >> >> src/main/assembly/ >> >> So the location is a suggestion to locate assembly descriptors but the >> maven-assembly-plugin itself does not have such a default value for >> that >> ? >> >> In my opinion the maven-assembly-plugin should have a default location >> as >> mentioned above (descriptors default value to search for >> src/main/assembly/ >> descriptors) or we should change the above description.. >> >> What do you thing ? Ideas ? >> >> Kind regards >> Karl-Heinz Marbaise >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Am 2014-03-09 21:02, schrieb Karl Heinz Marbaise: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. +1 You forgot: src/site. Always use a relative path in the docs otherwise it could be misinterpreted. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Sounds good to me. /Anders On Sun, Mar 9, 2014 at 9:02 PM, Karl Heinz Marbaise wrote: > So based on the discussion could we go with the following: > > /src/main >* are files required during compile time (production) > > /src/test >* are files required during test time (unit testing; based on naming > schema we could also have integration tests here) > > /src/it >* are files required during integration tests (primarily for plugins) > > /src/assembly >* for assembly descriptors and appropriate filter property files. > > The /src/it/ should be added to the default folder layout page. > > Should we start a VOTE for this ? > > Kind regards > Karl-Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: maven-assembly-plugin / Maven default folder layout
So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required during integration tests (primarily for plugins) /src/assembly * for assembly descriptors and appropriate filter property files. The /src/it/ should be added to the default folder layout page. Should we start a VOTE for this ? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Am 2014-03-08 22:24, schrieb Dennis Lundberg: Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. If someone wanted to create an assembly for the test part of a project I would recommend to place the assembly descriptor in src/test/assembly. Dennis, neither do you have src/main/site and other resembling structures. There is no way to enforce that this "assembly" is part of a test cycle, moreover such a notion does not exist for assemblies. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
I would call it advancing insight. I can't think of an assembly which is only for unittesting (due to the src/test folder) and won't be attached the the MavenProject for deployment. For users it would make it clear: everything under /src/main are files required during compile time everything under /src/test are files required during test time everything under /src/it are files required during integration tests assembly descriptors doesn't cover one of these, so it should have its own folder. While Maven-core uses src/main/assembly for years doesn't mean that we could adjust our advice. Robert Op Sat, 08 Mar 2014 23:57:06 +0100 schreef Dennis Lundberg : Hi Robert, I was not thinking about scope here, just the directory structure of the project. We've used src/main/assembly for years now. Maven-core has its assembly descriptors in src/main/assembly. It seems strange to suddenly change it. In what way would our users benefit from this change? On Sat, Mar 8, 2014 at 10:41 PM, Robert Scholte wrote: Hi Dennis, an assembly will always result in an attachment, but there's no such thing as attaching with a scope. For that reason I wouldn't separate the assembly descriptors, it might cause invalid assumptions. Robert Op Sat, 08 Mar 2014 22:24:10 +0100 schreef Dennis Lundberg : Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. If someone wanted to create an assembly for the test part of a project I would recommend to place the assembly descriptor in src/test/assembly. On Fri, Mar 7, 2014 at 8:25 PM, Robert Scholte wrote: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. Robert Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise : Hi, I stumbled over a small thing. The page about the default folder layout https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html mentioned a location for the maven-assembly-plugin descriptors: src/main/assembly/ So the location is a suggestion to locate assembly descriptors but the maven-assembly-plugin itself does not have such a default value for that ? In my opinion the maven-assembly-plugin should have a default location as mentioned above (descriptors default value to search for src/main/assembly/ descriptors) or we should change the above description.. What do you thing ? Ideas ? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Robert, I was not thinking about scope here, just the directory structure of the project. We've used src/main/assembly for years now. Maven-core has its assembly descriptors in src/main/assembly. It seems strange to suddenly change it. In what way would our users benefit from this change? On Sat, Mar 8, 2014 at 10:41 PM, Robert Scholte wrote: > Hi Dennis, > > an assembly will always result in an attachment, but there's no such thing > as attaching with a scope. > For that reason I wouldn't separate the assembly descriptors, it might cause > invalid assumptions. > > Robert > > > Op Sat, 08 Mar 2014 22:24:10 +0100 schreef Dennis Lundberg > : > > >> Hi >> >> I agree with Karl Heinz that the Assembly Plugin should support the >> documented default directory. >> >> It seems that we disagree about what the preferred directory should >> be. I think it should be src/main/assembly/ because almost all >> assemblies I have ever seen are for the main part of a project. If >> someone wanted to create an assembly for the test part of a project I >> would recommend to place the assembly descriptor in src/test/assembly. >> >> On Fri, Mar 7, 2014 at 8:25 PM, Robert Scholte >> wrote: >>> >>> Hi, >>> >>> This is the standard (preferred) directory layout, so it doesn't have to >>> be >>> the default. >>> I actually think that src/main/assembly/ should be src/assembly/, >>> otherwise >>> it would imply that there can also be a src/test/assembly/. I wouldn't >>> separate the descriptors into different folders. >>> >>> Robert >>> >>> Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise >>> : >>> >>> Hi, I stumbled over a small thing. The page about the default folder layout https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html mentioned a location for the maven-assembly-plugin descriptors: src/main/assembly/ So the location is a suggestion to locate assembly descriptors but the maven-assembly-plugin itself does not have such a default value for that ? In my opinion the maven-assembly-plugin should have a default location as mentioned above (descriptors default value to search for src/main/assembly/ descriptors) or we should change the above description.. What do you thing ? Ideas ? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >>> >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Dennis, an assembly will always result in an attachment, but there's no such thing as attaching with a scope. For that reason I wouldn't separate the assembly descriptors, it might cause invalid assumptions. Robert Op Sat, 08 Mar 2014 22:24:10 +0100 schreef Dennis Lundberg : Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. If someone wanted to create an assembly for the test part of a project I would recommend to place the assembly descriptor in src/test/assembly. On Fri, Mar 7, 2014 at 8:25 PM, Robert Scholte wrote: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. Robert Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise : Hi, I stumbled over a small thing. The page about the default folder layout https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html mentioned a location for the maven-assembly-plugin descriptors: src/main/assembly/ So the location is a suggestion to locate assembly descriptors but the maven-assembly-plugin itself does not have such a default value for that ? In my opinion the maven-assembly-plugin should have a default location as mentioned above (descriptors default value to search for src/main/assembly/ descriptors) or we should change the above description.. What do you thing ? Ideas ? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. If someone wanted to create an assembly for the test part of a project I would recommend to place the assembly descriptor in src/test/assembly. On Fri, Mar 7, 2014 at 8:25 PM, Robert Scholte wrote: > Hi, > > This is the standard (preferred) directory layout, so it doesn't have to be > the default. > I actually think that src/main/assembly/ should be src/assembly/, otherwise > it would imply that there can also be a src/test/assembly/. I wouldn't > separate the descriptors into different folders. > > Robert > > Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise > : > > >> Hi, >> >> I stumbled over a small thing. >> >> The page about the default folder layout >> >> https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html >> >> mentioned a location for the maven-assembly-plugin descriptors: >> >> src/main/assembly/ >> >> So the location is a suggestion to locate assembly descriptors but the >> maven-assembly-plugin itself does not have such a default value for that ? >> >> In my opinion the maven-assembly-plugin should have a default location as >> mentioned above (descriptors default value to search for src/main/assembly/ >> descriptors) or we should change the above description.. >> >> What do you thing ? Ideas ? >> >> Kind regards >> Karl-Heinz Marbaise >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi Robert, > I've changed the location and published the site Robert You have been faster than I ;-) Kind regards Karl-Heinz Op Sat, 08 Mar 2014 00:14:02 +0100 schreef Hervé BOUTEMY : +1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. Robert Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise : > Hi, > > I stumbled over a small thing. > > The page about the default folder layout > https://maven.apache.org/guides/introduction/introduction-to-the-standard-> > directory-layout.html > > mentioned a location for the maven-assembly-plugin descriptors: > > src/main/assembly/ > > So the location is a suggestion to locate assembly descriptors but the > maven-assembly-plugin itself does not have such a default value for that > ? > > In my opinion the maven-assembly-plugin should have a default location > as mentioned above (descriptors default value to search for > src/main/assembly/ descriptors) or we should change the above > description.. > > What do you thing ? Ideas ? > > Kind regards > Karl-Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org Mit freundlichem Gruß Karl-Heinz Marbaise -- SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893 Dipl.Ing.(FH) Karl-Heinz MarbaiseICQ#: 135949029 Hauptstrasse 177 USt.IdNr: DE191347579 52146 Würselen http://www.soebes.de - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
I've changed the location and published the site Robert Op Sat, 08 Mar 2014 00:14:02 +0100 schreef Hervé BOUTEMY : +1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. Robert Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise : > Hi, > > I stumbled over a small thing. > > The page about the default folder layout > https://maven.apache.org/guides/introduction/introduction-to-the-standard-> > directory-layout.html > > mentioned a location for the maven-assembly-plugin descriptors: > > src/main/assembly/ > > So the location is a suggestion to locate assembly descriptors but the > maven-assembly-plugin itself does not have such a default value for that > ? > > In my opinion the maven-assembly-plugin should have a default location > as mentioned above (descriptors default value to search for > src/main/assembly/ descriptors) or we should change the above > description.. > > What do you thing ? Ideas ? > > Kind regards > Karl-Heinz Marbaise > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
+1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : > Hi, > > This is the standard (preferred) directory layout, so it doesn't have to > be the default. > I actually think that src/main/assembly/ should be src/assembly/, > otherwise it would imply that there can also be a src/test/assembly/. I > wouldn't separate the descriptors into different folders. > > Robert > > Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise > > : > > Hi, > > > > I stumbled over a small thing. > > > > The page about the default folder layout > > https://maven.apache.org/guides/introduction/introduction-to-the-standard-> > > > directory-layout.html > > > > mentioned a location for the maven-assembly-plugin descriptors: > > > > src/main/assembly/ > > > > So the location is a suggestion to locate assembly descriptors but the > > maven-assembly-plugin itself does not have such a default value for that > > ? > > > > In my opinion the maven-assembly-plugin should have a default location > > as mentioned above (descriptors default value to search for > > src/main/assembly/ descriptors) or we should change the above > > description.. > > > > What do you thing ? Ideas ? > > > > Kind regards > > Karl-Heinz Marbaise > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Am 2014-03-07 20:25, schrieb Robert Scholte: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. +1 That's the first thing which came to my mind too. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Am 2014-03-07 20:25, schrieb Robert Scholte: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. +1 That's the first thing which came to my mind too. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven-assembly-plugin / Maven default folder layout
Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders. Robert Op Fri, 07 Mar 2014 20:14:48 +0100 schreef Karl Heinz Marbaise : Hi, I stumbled over a small thing. The page about the default folder layout https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html mentioned a location for the maven-assembly-plugin descriptors: src/main/assembly/ So the location is a suggestion to locate assembly descriptors but the maven-assembly-plugin itself does not have such a default value for that ? In my opinion the maven-assembly-plugin should have a default location as mentioned above (descriptors default value to search for src/main/assembly/ descriptors) or we should change the above description.. What do you thing ? Ideas ? Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org