Re: cactus tests and debugging...

2005-09-28 Thread Werner Punz
Hi Bill, could you push the info on the wiki for future references?

Werner



Bill Dudney wrote:
 Hi All,
 
 Most of you have probably see the fast and furious emails going on 
 about issue #623. I wanted to drop you a quick note on how to debug a 
 failing cactus test.
 
 First you need to have tomcat setup to run in debug mode and then 
 attach to it via your IDE. That process is explained in an old post  on
 my blog;
 
 http://bill.dudney.net/roller/page/bill/20040210
 
 the content is a bit dated but it works like a champ for tomcat 5.5.9.
 
 Once you are connected to tomcat running in the debug-able vm you can 
 set breakpoints in the server side code (such as ValueBindingImpl for 
 bug #623) and merrily debug away with a quick simple means to repeat 
 the buggy code (i.e. no more wading through a JSP to invoke the buggy 
 code). You can run the cactus tests in Eclipse as JUnit tests so it 
 appears that everything is happening right in eclipse but half of the 
 code is running on the server.
 
 You have to deploy the cactus tests into your running version of  tomcat
 for all this to work. I was thinking of adding build stuff to 
 accomplish that as well if there is enough interest. In the mean time 
 you can simply startup tomcat as described in the blog post and copy 
 the cactus-app.war file into the auto deploy directory (usually 
 webapps) then connect Eclipse to the debug-able jvm running tomcat 
 (also described earlier in the blog post). You also need to specify  the
 following property;
 
 cactus.contextURL=http://localhost:8080/cactus-app
 
 You can specify this in your launch specification in Eclipse or  create
 a cactus.properties file in the Eclipse output folder (where  the
 projects compiled classes end up). The file should contain a  single
 line defining cactus.contextURL. Cactus will look for this  property
 either specified on the command line or in a file called 
 'cactus.properties' in the class path so either way will work. I find 
 it easier to manually create the file in the Eclipse output directory 
 but do what you like :)
 
 Anyway I should probably put this on the Wiki but its too manual IMO 
 right now. If there is enough interest I'll generalize it so that you 
 can deploy the cactus tests from the build file.
 
 TTFN,
 
 -bd-
 



Re: cactus tests and debugging...

2005-09-28 Thread Werner Punz
Ah sorry, just saw that you are planning to put it onto the wiki anyway.

Werner



[jira] Commented: (MYFACES-623) setValue() method of ValueBindingImpl does not behave properly

2005-09-28 Thread Martin Marinschek (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-623?page=comments#action_12330670 
] 

Martin Marinschek commented on MYFACES-623:
---

I'd say it shouldn't cause a problem. Anton is our el-specialist, so he might 
know more...

regards,

Martin

 setValue() method of ValueBindingImpl does not behave properly
 --

  Key: MYFACES-623
  URL: http://issues.apache.org/jira/browse/MYFACES-623
  Project: MyFaces
 Type: Bug
   Components: JSR-127
 Versions: 1.1.0
 Reporter: sean schofield
  Attachments: MYFACES-623.patch

 According to section 5.1.4 of the specification (p. 5-4) ...
 If you have #{expr-a[value-b]}  where value-a is a Map then ...
 call value-a.put(value-b, newValue).
 The MyFaces implementation is coercing newValue into String which is 
 incorrect behavior.  
 NOTE: I discovered the problem while using a bean that was programatically 
 added to the session map.  So there is is no class defined in 
 faces-config.xml.  I don't think this should matter but I thought I would 
 mention it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (MYFACES-635) Calendar popup is incorrectly positioned inside scrolling div

2005-09-28 Thread Martin Marinschek (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-635?page=all ]

Martin Marinschek updated MYFACES-635:
--

Attachment: (was: popcalendar.js.diff)

 Calendar popup is incorrectly positioned inside scrolling div
 -

  Key: MYFACES-635
  URL: http://issues.apache.org/jira/browse/MYFACES-635
  Project: MyFaces
 Type: Bug
   Components: Tomahawk
 Versions: 1.1.1
 Reporter: Jack Honeghan-Bates
 Assignee: Martin Marinschek
 Priority: Minor
  Attachments: popcalendar.js.diff

 I've noticed two positioning issues with the calendar popup:
 1) When it's inside a scrollable div or similar, which is currently scrolled, 
 the popup is offset from it's correct position.
 2) When the popup button is near the edge of the current window, the popup 
 does not adjust it's position to remain within the window.
 I've reproduced the problem with the latest code from the repository. 
 I've attached a diff for popcalendar.js, which fixes the problem and seems to 
 work fine on IE and firefox.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



MYFACES-152: ResponseWriter.endDocument() abuse breaks ADF Faces and Facelets

2005-09-28 Thread Martin Marinschek
-- Forwarded message --
From: Thomas Spiegl [EMAIL PROTECTED]
Date: Sep 28, 2005 9:45 AM
Subject: Re: MYFACES-152: ResponseWriter.endDocument() abuse breaks
ADF Faces and Facelets
To: [EMAIL PROTECTED]


int flags = Pattern.CASE_INSENSITIVE | Pattern.DOTALL;
 Pattern pattern = Pattern.compile( * / *head *, flags);

 would even find   /  head   

 regards,
 Thomas


On 9/28/05, Martin Marinschek [EMAIL PROTECTED] wrote:
 Ok, good.

 As of today, it is easy to break the ExtensionFilter - I just need to
 change from

 head to  head

 and it won't work anymore, right?

 regards,

 Martin

 On 9/27/05, Thomas Spiegl  [EMAIL PROTECTED] wrote:
  IMHO parsing the markup and inserting the necessary scripts would not have a
  great impact on performance. Doing the search with regular expressions is
  really fast.
 
 
 
  On 9/27/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   Indeed, it could be generated them in t:head/body. But then we would have
  to set a request attribute, and in the filter, fallback on parsing the input
  if the request attribute hasn't been set.
   So, to be compatible with pages without the t:head/body, we would have to
  do the code in the filter anyway.
  
   This code to parse the input isn't too hard. Some very good tools like
  SiteMesh work like this and are very reliable  fast, so I don't see that as
  a problem.
   So, in the end, I'm not sure those t:head  t:body tags are really useful
  to solve this problem.
  
  
   On Tue, 2005-09-27 at 17:07 +0200, Martin Marinschek wrote:
   We could move the script generation from endDocument to encodeEnd in
   t:head or t:body - tag...
  
   With that we make sure that no scripts are outputted after the
  
   document has already been closed!
  
   Manfred suggests as a solution to parse the input for head - or body
   tags, I don't like having to parse the whole output for these strings
  
   - there are just too many possibilities. With a clearly defined call
   to startElement, we know the position!
  
   regards,
  
  
   Martin
  
   On 9/27/05, Sylvain Vieujot [EMAIL PROTECTED]
wrote:
I think it does.
So, basically, a phase listener would start the filter's job if the
  filter
hasn't been configured. Right ?
  
   
I'm not 100% sure how it solves MYFACES-152 though.
   
   
  
On Tue, 2005-09-27 at 16:08 +0200, Martin Marinschek wrote:
Well, any HTML before the JSF components would just be rendered out -
untouched!
  
   
As soon as the JSF processing starts, we start caching the response.
When the t:body element is closed, we write out the cached data.
  
   
Our existing filter might work unchanged, if I don't have any problems
in my reasoning...
  
   
Sounds reasonable?
   
   
On 9/27/05, Sylvain Vieujot 
   [EMAIL PROTECTED]  wrote:
 On Tue, 2005-09-27 at 15:55 +0200, Martin Marinschek wrote:
 Yes, but ideally we would find a way to integrate it into the
  
 life-cycle - not having a separate filter, with this we could
 remember the insert position.
  

 Not having a separate filter would be good, but I don't know how this
  can
 be done, as any HTML rendered before the JSF components would be lost.
  


 Wait a minute - we could set the insert position by setting request
  
 parameters which the filter reads, right?

 Sure !


  


 regards,

 Martin
  

 On 9/27/05, Sylvain Vieujot 
   [EMAIL PROTECTED] wrote:
  So, If I understand you well, the t:head for example would render
 something
  
  like :
  head!-- Hello, I'm the tomahawk head Start --
  ...
  !-- Hello, I'm the tomahawk head End --/head
  
 
  And the extensions filter would first search for the !-- Hello,
  I'm
the
  
  tomahawk head Start -- to get the insert position.
  If he doesn't find it, it would fallback on the current parsing.
  
 
  Is that it ?
 
 
  On Tue, 2005-09-27 at 15:40 +0200, Martin Marinschek wrote:
  
  Basically, it would work very much like the approach we are using
  today.
 
  So we would need to do some caching of the response, and parsing in
  
  the statements as we go. We would have defined markers, though, and
  wouldn't need to search through the whole markup!
  
 
  We are doing this today for the rendering of the javascript for
  commandLinks...
  
 
  If we don't find a way to fix this problem, we won't be able to use
  the ADF components with MyFaces apps, nor will facelets be properly
  
  working.
 
  regards,
 
  
  Martin
 
  On 9/27/05, Sylvain Vieujot 
   [EMAIL PROTECTED] wrote:
   What do you mean by he just won't have the extras ?
  
  
   I think that if it's fully optional, it sure would bey good.
   I mean if the page has t:head  t:body, then it uses it, otherwise
  it
  
  works
   as today.
  

Re: New s:graphicImageAjax component.

2005-09-28 Thread Mathias Brökelmann
Great! We definitely need a component to render dynamic images.

I took a view into the code and saw that the state is appended to the
image url. IMO it will not work in every case since the state could be
very large and as far as I know there is a limitation around 1024
chars in a request url.

The other thing is the phase listener which will not work if the
component is used in a uidata component. Try using a custom faces
event which is queued through UIComponent.queueEvent(...).


2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
  I just committed a first working version of a graphicImage component that
 displays the images from bytes, and that doesn't need an additional servlet.

  It works, but there is still work to be done (See the TODOs in the
 component's java file).

  The most important things are :
  1) Find a good name for this component. Right now, it says Ajax whereas
 it's not really Ajax.
  2) Extend it to make download links (uses an a instead of an img

  Thanks for your ideas,

  Sylvain.

  On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
  Sylvain,

 I'm definitely interested in a component that can display an image
 from bytes as well, if you want any assistance.

 -- need a dynamic image servlet is the next item on my todo list :)

 On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Yes, you're right, but I was looking for a way to use the same code with a
  get request instead of a post request.
  So, I think this will work.
 
  I'll post this soon so that you can check it.
 
  Thanks,
 
  Sylvain.
 
 
  On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
  The snippet you posted is just about remembering the state of the
  application client side - it doesn't have to do anything with dynamic
  loading of images...
 
  Or do I get you completely wrong?
 
  regards,
 
  Martin
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   You're right, Ajax isn't the perfect term for this, as the result won't
 be
   XML.
  
   But maybe it can work using something similar to that :
callback: function(element,entry) {return
  
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
   +
  
   (extracted from the inputSuggestAjax code).
  
   Thanks for the clue.
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
  
   The XMLHttpRequest object (or the equivalent ActiveX control)'s open
  method
   takes as its first argument the request method you want to use. So you
   could make a get request simply by saying:
  
   xHR.open(GET, url[, asyncflag][, username][, password]);
  
   I believe that answers your question, but I'm not sure I understand how
   that helps you. I mean, AJAX will return a text string, and possibly a
   document object if the response is valid XML. It won't return an image.
   The only way to load an image is, as you say, using the src property of
  the
   image object, and that will always do a GET. I don't see how you get
 AJAX
   to work into this scenario, unless you plan to use it to generate the
 URL
   for the image object to load.
  
   Or am I just missing something in your original message?
  
   -Matt
  
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  
   Hello,
  
   I'm trying to make a new component that would display an image, but
  without
   the need to have a dedicated servlet.
   It would make applications that use images from a lot of different
 sources
   (i.e. servlets) much simpler.
   Basically, it would be a component like :
   x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
  
   As the only way I found to load an image in javascript is
 image.src=...,
   I can't use a post request.
  
   Does someone know a way either to load an image in javascript with the
   result of a post request, or a way to use ajax like in inputSuggestAjax,
  but
   with a get url ?
  
   Thanks,
  
   Sylvain.
  
  
 
 
  --
 
  http://www.irian.at
  Your JSF powerhouse -
  JSF Trainings in English and German
 
 




--
Mathias


Re: 30 more minutes till branch...

2005-09-28 Thread Mathias Brökelmann
IMO it´s better if we fix a bug in both trunk and the branch. Trunk is
used by more users (either by svn or through the nightlies). This will
give us more feedback if a bugfix introduces a new bug.

2005/9/28, Sean Schofield [EMAIL PROTECTED]:
 Bugs that have been introduced on the branch (ex. MYFACES-634) should
 obviously be fixed on the branch.

 Additional Rule of thumb: If the bug is going to be fixed in the
 branch fix it *only* in the branch.  Do not fix in the trunk.  We will
 merge into the trunk in a few weeks when we are done.

 sean

 On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:
  I changed all of the issues fixed in nightly to be version 1.1.1 (by
  renaming the existing nightly version in JIRA and creating a new one.)
 
  So we can now search on a list of things that are fixed in that
  version and eventually generate release notes.
 
  Thanks Bill for the branch (its tedious - I know.)
 
  sean
 
  On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
   branch created
  
   If you want a bug to be fixed in the 1_1_1 release you must apply
   your changes to the release/branches/1_1_1 branch in SVN.
  
   Please limit the changes to the ones identified in the other thread
   titled '[proposal] Branch Content'.
  
   Thanks!
  
   -bd-
  
   On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:
  
Go for it.
   
sean
   
On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
   
Hi Sean,
   
I need about 30 more minutes to finish up something. I'll start the
branch around 1:00 EST. Is that OK with everyone?
   
TTFN,
   
-bd-
   
   
  
  
 



--
Mathias


[jira] Commented: (MYFACES-568) tree2 TreeState wrong after node deletion/reposition, causes Servlet Exception

2005-09-28 Thread Mathias Werlitz (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-568?page=comments#action_12330672 
] 

Mathias Werlitz commented on MYFACES-568:
-

I'm not really up-to-date with the release of 1.1.1 but I think this patch 
should be included ... it will save us a lot of illogical state exceptions 

 tree2 TreeState wrong after node deletion/reposition, causes Servlet Exception
 --

  Key: MYFACES-568
  URL: http://issues.apache.org/jira/browse/MYFACES-568
  Project: MyFaces
 Type: Bug
   Components: Tomahawk
 Versions: 1.1.1
  Environment:  Tomcat 4.1.31, SDK 1.4.2, windows XP Pro
 Reporter: Bett Koch
  Attachments: tree2_bitmask.txt

 We are using the tree2 component in a situation where nodes can be 
 dynamically added, deleted and re-parented.
 The tree can also be completely re-populated with a different version of data.
 We have also simulated multiple node selection, by placing a checkbox 
 next to certain nodes. Clicking a button then causes bulk-deletion of all 
 ticked nodes.
 We were using the myfaces 1.0.9 version in this way:
   
   t:tree2 value=#{xxx.treeData}
var=n
varNodeToggler=tn
clientSideToggle=false
   
 The backing bean is in Session Scope; treeData was a TreeNode.
 All this was basically working, with the exception of a refresh problem after 
 a re-population (reported in MYFACES-404),
 and a problem whereby you had to click twice to expand the root node when the 
 page first displayed.
 We want to migrate to the nightly builds, in which these two issues are fixed 
 (thanks!)
 But we hit problems with the new TreeState: (using nightly build of 11-Sep-05)
 1. When moving to another page and then coming back, the tree is always 
 collapsed.
 2. When re-populating the tree with a different data set, OR
 3. When deleting or reparenting a node, often this kind of error (eventually) 
 occurs:
   javax.servlet.ServletException: 
   Encountered a node [0:4] + with an illogical state.  
   Node is expanded but it is also considered a leaf (a leaf cannot be 
 considered expanded.
 By reading thru the various postings and forums I have fixed:
 1 by creating our own TreeModel and value-binding to that (rather than a 
 TreeNode)
 (Incidentally, adding a component-binding, ie t:tree2 
 binding=#{xxx.treeComponent} value=#{xxx.treeNode}..  
 also fixed the problem without using our own TreeModel)
 2 by setting the Transient property of our TreeModel's TreeState to True
 (which I understand is OK since our backing bean is session-scoped)
 But I can't figure out 3.  
 How can you fix up the TreeState after programatically causing nodes to 
 change positions or disappear,
 since the TreeState maintains its node expansion knowledge via a Hashmap 
 keyed on positional node ids
 (0:1:4, etc).
 As a work-around I've thought of collapsing any node (and its subnodes) 
 before trying to delete or move it, or even
 collapsing the whole tree, but I can't work out how
 UITreeData only gives you the nodeId of the 'current' node, so I don't 
 understand how you get at 
 nodeIds of arbitrary nodes to feed to the new collapsePath() method.
 (Incidentally, maybe a collapseAll() method might be useful to have as well 
 as expandAll()?)
 Thanks for any help, and please set me straight if I've misunderstood 
 anything about the changes made to tree2 along the way!
 Regards, Bett

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-392) When using x:navigationMenuItems in jsCookMenu, only top-level is displayed

2005-09-28 Thread Lee Smith (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-392?page=comments#action_12330674 
] 

Lee Smith commented on MYFACES-392:
---

Yup, have now upgraded to 1.1.0 and this issue is fixed.


Cheers,

Lee

 When using x:navigationMenuItems in jsCookMenu, only top-level is displayed
 -

  Key: MYFACES-392
  URL: http://issues.apache.org/jira/browse/MYFACES-392
  Project: MyFaces
 Type: Bug
   Components: Tomahawk
 Versions: 1.0.9m9
  Environment: Microsoft Windows XP
 JDeveloper 10.0.2
 Oracle OC4J 10.0.2
 MyFaces 1.0.9
 Reporter: Lee Smith
 Assignee: Thomas Spiegl


 When programmatically builing a menu for jscookmenu using the following 
 syntax:
 x:jscookMenu layout=hbr theme=ThemeOffice
x:navigationMenuItems value=#{menuBean.menu}/
 /x:jscookMenu
 only the top-level of items in the specified bean are rendered. For example, 
 if the menuBean was defined as:
 public class MenuBean
 {
public List getMenu()
{
   NavigationMenuItem menu1 = new NavigationMenuItem(label1,action1, 
 null, false);
   menu1.setNavigationMenuItems(new NavigationMenuItem[] {
  new NavigationMenuItem(label1.1, action1.1, null, false),
  new NavigationMenuItem(label1.2, action1.2, null, false)
   });
   NavigationMenuItem menu2 = new NavigationMenuItem(label2, action2, 
 null, false);
   menu2.setNavigationMenuitems(new NavigationMenuItem[] {
 new NavigationMenuItem(label2.1, action2.1, null, false),
 new NavigationMenuItem(label2.2, action2.2, null, false)
   });
   List menu = new ArrayList();
   menu.add(menu1);
   menu.add(menu2);
   return menu;
}
 }
 then only the root options 'label1' and 'label2' are rendered.
 This appears to be cause by 
 org.apache.myfaces.custom.navmenu.jscookmenu.HtmlJSCookMenuRenderer, in the 
 method encodeNavigationMenuItems.
 The following changes seem to fix the problem (not sure if the fix is 
 appropriate, given I'm not entirely sure what uiNavMenuItemList is used for 
 :) ):
 199a200
  
 201a203,204
  if (uiNavMenuItemList != null)
  {
 202a206
  }
 267a272,276
  else
  {
  
  encodeNavigationMenuItems(context, writer, menuItems,
  null, menuId);
  }
 Cheers,
 Lee

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Closed: (MYFACES-588) JSCookMenu separator bug - phantom item

2005-09-28 Thread Bruno Aranda (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-588?page=all ]
 
Bruno Aranda closed MYFACES-588:


Fix Version: Nightly
 (was: 1.1.1)
 Resolution: Fixed

This should be fixed in the HEAD SVN. Test it, but I think it will work now. 
Thanks,

 JSCookMenu separator bug - phantom item
 ---

  Key: MYFACES-588
  URL: http://issues.apache.org/jira/browse/MYFACES-588
  Project: MyFaces
 Type: Bug
   Components: Tomahawk
 Versions: 1.1.1
  Environment: tomcat 5.0, jdk1.4.2_09, jbuilder 2005, winxp, intel p4
 Reporter: Zoltán Baranyi
 Assignee: Bruno Aranda
 Priority: Trivial
  Fix For: Nightly


 These tag lines
   t:jscookMenu layout=hbr theme=ThemeOffice
 t:navigationMenuItem itemLabel=Menu1 itemValue=Menu1 value=Menu1
   t:navigationMenuItem itemLabel=Menu1-1 itemValue=Menu1-1 
 value=Menu1-1  /t:navigationMenuItem
   t:navigationMenuItem split=true  /t:navigationMenuItem
   t:navigationMenuItem itemLabel=Menu1-2 itemValue=Menu1-2 
 value=Menu1-2  /t:navigationMenuItem
 /t:navigationMenuItem
   /t:jscookMenu
 produces this output
 var id2_menu =
 [
   [null, 'Menu1', null, 'linkDummyForm', null,
   [null, 'Menu1-1', null, 'linkDummyForm', null],
   _cmSplit,
   [null, '0', null, 'linkDummyForm', null],
   [null, 'Menu1-2', null, 'linkDummyForm', null]
   ]
 ];
 So the split item was rendered twice: the separator item, and a phantom 
 item.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: 30 more minutes till branch...

2005-09-28 Thread Bill Dudney
problem is that merging is a pain in the neck. we can do it its just  
a pain


So we need to push out the release sooner rather than later.

I've not seen any discussion on the bug list to get fixed.

TTFN,

-bd-
On Sep 28, 2005, at 2:11 AM, Mathias Brökelmann wrote:


IMO it´s better if we fix a bug in both trunk and the branch. Trunk is
used by more users (either by svn or through the nightlies). This will
give us more feedback if a bugfix introduces a new bug.

2005/9/28, Sean Schofield [EMAIL PROTECTED]:


Bugs that have been introduced on the branch (ex. MYFACES-634) should
obviously be fixed on the branch.

Additional Rule of thumb: If the bug is going to be fixed in the
branch fix it *only* in the branch.  Do not fix in the trunk.  We  
will

merge into the trunk in a few weeks when we are done.

sean

On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:


I changed all of the issues fixed in nightly to be version 1.1.1 (by
renaming the existing nightly version in JIRA and creating a new  
one.)


So we can now search on a list of things that are fixed in that
version and eventually generate release notes.

Thanks Bill for the branch (its tedious - I know.)

sean

On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:


branch created

If you want a bug to be fixed in the 1_1_1 release you must apply
your changes to the release/branches/1_1_1 branch in SVN.

Please limit the changes to the ones identified in the other thread
titled '[proposal] Branch Content'.

Thanks!

-bd-

On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:



Go for it.

sean

On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:



Hi Sean,

I need about 30 more minutes to finish up something. I'll  
start the

branch around 1:00 EST. Is that OK with everyone?

TTFN,

-bd-


















--
Mathias





Re: 30 more minutes till branch...

2005-09-28 Thread Martin Marinschek
Honestly, I just think we should push this one out.

there have been 64 issues fixed since 1.1.0, that should be enough.

regards,

Martin

On 9/28/05, Bill Dudney [EMAIL PROTECTED] wrote:
 problem is that merging is a pain in the neck. we can do it its just
 a pain

 So we need to push out the release sooner rather than later.

 I've not seen any discussion on the bug list to get fixed.

 TTFN,

 -bd-
 On Sep 28, 2005, at 2:11 AM, Mathias Brökelmann wrote:

  IMO it´s better if we fix a bug in both trunk and the branch. Trunk is
  used by more users (either by svn or through the nightlies). This will
  give us more feedback if a bugfix introduces a new bug.
 
  2005/9/28, Sean Schofield [EMAIL PROTECTED]:
 
  Bugs that have been introduced on the branch (ex. MYFACES-634) should
  obviously be fixed on the branch.
 
  Additional Rule of thumb: If the bug is going to be fixed in the
  branch fix it *only* in the branch.  Do not fix in the trunk.  We
  will
  merge into the trunk in a few weeks when we are done.
 
  sean
 
  On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:
 
  I changed all of the issues fixed in nightly to be version 1.1.1 (by
  renaming the existing nightly version in JIRA and creating a new
  one.)
 
  So we can now search on a list of things that are fixed in that
  version and eventually generate release notes.
 
  Thanks Bill for the branch (its tedious - I know.)
 
  sean
 
  On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
 
  branch created
 
  If you want a bug to be fixed in the 1_1_1 release you must apply
  your changes to the release/branches/1_1_1 branch in SVN.
 
  Please limit the changes to the ones identified in the other thread
  titled '[proposal] Branch Content'.
 
  Thanks!
 
  -bd-
 
  On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:
 
 
  Go for it.
 
  sean
 
  On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
 
 
  Hi Sean,
 
  I need about 30 more minutes to finish up something. I'll
  start the
  branch around 1:00 EST. Is that OK with everyone?
 
  TTFN,
 
  -bd-
 
 
 
 
 
 
 
 
 
 
 
 
 
  --
  Mathias
 




--

http://www.irian.at
Your JSF powerhouse -
JSF Trainings in English and German


Re: 30 more minutes till branch...

2005-09-28 Thread Sean Schofield
The plan was to do a release candidate over the weekend after using
the rest of this week to fix last minute must fix bugs.  We could
move that up a bit.  What if we build the RC on Friday?  That gives us
through tomorrow to fix everything that needs to go in.

Once we build the RC we can merge the fixes down.  The users of the
nightly build will only be without these fixes for a few days.

sean

On 9/28/05, Martin Marinschek [EMAIL PROTECTED] wrote:
 Honestly, I just think we should push this one out.

 there have been 64 issues fixed since 1.1.0, that should be enough.

 regards,

 Martin

 On 9/28/05, Bill Dudney [EMAIL PROTECTED] wrote:
  problem is that merging is a pain in the neck. we can do it its just
  a pain
 
  So we need to push out the release sooner rather than later.
 
  I've not seen any discussion on the bug list to get fixed.
 
  TTFN,
 
  -bd-
  On Sep 28, 2005, at 2:11 AM, Mathias Brökelmann wrote:
 
   IMO it´s better if we fix a bug in both trunk and the branch. Trunk is
   used by more users (either by svn or through the nightlies). This will
   give us more feedback if a bugfix introduces a new bug.
  
   2005/9/28, Sean Schofield [EMAIL PROTECTED]:
  
   Bugs that have been introduced on the branch (ex. MYFACES-634) should
   obviously be fixed on the branch.
  
   Additional Rule of thumb: If the bug is going to be fixed in the
   branch fix it *only* in the branch.  Do not fix in the trunk.  We
   will
   merge into the trunk in a few weeks when we are done.
  
   sean
  
   On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:
  
   I changed all of the issues fixed in nightly to be version 1.1.1 (by
   renaming the existing nightly version in JIRA and creating a new
   one.)
  
   So we can now search on a list of things that are fixed in that
   version and eventually generate release notes.
  
   Thanks Bill for the branch (its tedious - I know.)
  
   sean
  
   On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
  
   branch created
  
   If you want a bug to be fixed in the 1_1_1 release you must apply
   your changes to the release/branches/1_1_1 branch in SVN.
  
   Please limit the changes to the ones identified in the other thread
   titled '[proposal] Branch Content'.
  
   Thanks!
  
   -bd-
  
   On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:
  
  
   Go for it.
  
   sean
  
   On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
  
  
   Hi Sean,
  
   I need about 30 more minutes to finish up something. I'll
   start the
   branch around 1:00 EST. Is that OK with everyone?
  
   TTFN,
  
   -bd-
  
  
  
  
  
  
  
  
  
  
  
  
  
   --
   Mathias
  
 
 


 --

 http://www.irian.at
 Your JSF powerhouse -
 JSF Trainings in English and German



Re: New s:graphicImageAjax component.

2005-09-28 Thread Sean Schofield
How about something like dynaImage?

sean

On 9/28/05, Mathias Brökelmann [EMAIL PROTECTED] wrote:
 Great! We definitely need a component to render dynamic images.

 I took a view into the code and saw that the state is appended to the
 image url. IMO it will not work in every case since the state could be
 very large and as far as I know there is a limitation around 1024
 chars in a request url.

 The other thing is the phase listener which will not work if the
 component is used in a uidata component. Try using a custom faces
 event which is queued through UIComponent.queueEvent(...).


 2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
   I just committed a first working version of a graphicImage component that
  displays the images from bytes, and that doesn't need an additional servlet.
 
   It works, but there is still work to be done (See the TODOs in the
  component's java file).
 
   The most important things are :
   1) Find a good name for this component. Right now, it says Ajax whereas
  it's not really Ajax.
   2) Extend it to make download links (uses an a instead of an img
 
   Thanks for your ideas,
 
   Sylvain.
 
   On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
   Sylvain,
 
  I'm definitely interested in a component that can display an image
  from bytes as well, if you want any assistance.
 
  -- need a dynamic image servlet is the next item on my todo list :)
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   Yes, you're right, but I was looking for a way to use the same code with a
   get request instead of a post request.
   So, I think this will work.
  
   I'll post this soon so that you can check it.
  
   Thanks,
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
   The snippet you posted is just about remembering the state of the
   application client side - it doesn't have to do anything with dynamic
   loading of images...
  
   Or do I get you completely wrong?
  
   regards,
  
   Martin
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
You're right, Ajax isn't the perfect term for this, as the result won't
  be
XML.
   
But maybe it can work using something similar to that :
 callback: function(element,entry) {return
   
  
  entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
+
   
(extracted from the inputSuggestAjax code).
   
Thanks for the clue.
   
Sylvain.
   
   
On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
   
The XMLHttpRequest object (or the equivalent ActiveX control)'s open
   method
takes as its first argument the request method you want to use. So you
could make a get request simply by saying:
   
xHR.open(GET, url[, asyncflag][, username][, password]);
   
I believe that answers your question, but I'm not sure I understand how
that helps you. I mean, AJAX will return a text string, and possibly a
document object if the response is valid XML. It won't return an image.
The only way to load an image is, as you say, using the src property of
   the
image object, and that will always do a GET. I don't see how you get
  AJAX
to work into this scenario, unless you plan to use it to generate the
  URL
for the image object to load.
   
Or am I just missing something in your original message?
   
-Matt
   
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   
Hello,
   
I'm trying to make a new component that would display an image, but
   without
the need to have a dedicated servlet.
It would make applications that use images from a lot of different
  sources
(i.e. servlets) much simpler.
Basically, it would be a component like :
x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
   
As the only way I found to load an image in javascript is
  image.src=...,
I can't use a post request.
   
Does someone know a way either to load an image in javascript with the
result of a post request, or a way to use ajax like in inputSuggestAjax,
   but
with a get url ?
   
Thanks,
   
Sylvain.
   
   
  
  
   --
  
   http://www.irian.at
   Your JSF powerhouse -
   JSF Trainings in English and German
  
  
 
 


 --
 Mathias



Re: Build Failure

2005-09-28 Thread Sean Schofield
Last nights build was broken.  Can we get things compiling again?

sean


On 9/27/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
  [echo] build.dir: /home/sjs4/bootstrap/myfaces-current/build
  [echo] build output directory: /home/sjs4/release
  [echo] suproject : api
  [echo] properties: api/build.properties
  [echo] suproject : impl
  [echo] properties: impl/build.properties
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/share/src/java/org/apache/myfaces/renderkit/html/HtmlFormRendererBase.java:85:
  warning - @return tag has no arguments.
  [echo] suproject : tomahawk
  [echo] properties: tomahawk/build.properties
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:156:
  warning - Tag @see: can't find 
 encodeColumnChild(javax.faces.context.FacesContext, 
 javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
 javax.faces.component.UIComponent, java.lang.String) in 
 org.apache.myfaces.renderkit.html.HtmlTableRendererBase
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/share/src/java/org/apache/myfaces/renderkit/html/HtmlFormRendererBase.java:85:
  warning - @return tag has no arguments.
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:179:
  warning - Tag @see: can't find 
 renderColumnBody(javax.faces.context.FacesContext, 
 javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
 javax.faces.component.UIComponent, java.lang.String) in 
 org.apache.myfaces.renderkit.html.HtmlTableRendererBase
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/custom/tree2/UITreeData.java:421:
  warning - @param argument expandAll is not a parameter name.
   [javadoc] 
 /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:179:
  warning - Tag @see: can't find 
 renderColumnBody(javax.faces.context.FacesContext, 
 javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
 javax.faces.component.UIComponent, java.lang.String) in 
 org.apache.myfaces.renderkit.html.HtmlTableRendererBase
  [echo] suproject : examples
  [echo] properties: examples/build.properties
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/AppointmentBean.java:23:
  package org.apache.myfaces.custom.schedule.model does not exist
 [javac] import 
 org.apache.myfaces.custom.schedule.model.DefaultScheduleEntry;
 [javac] ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/AppointmentBean.java:24:
  package org.apache.myfaces.custom.schedule.model does not exist
 [javac] import 
 org.apache.myfaces.custom.schedule.model.SimpleScheduleModel;
 [javac] ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:28:
  package org.apache.myfaces.custom.schedule.model does not exist
 [javac] import org.apache.myfaces.custom.schedule.model.ScheduleModel;
 [javac] ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:29:
  package org.apache.myfaces.custom.schedule.model does not exist
 [javac] import 
 org.apache.myfaces.custom.schedule.model.SimpleScheduleModel;
 [javac] ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:30:
  package org.apache.myfaces.custom.schedule.util does not exist
 [javac] import org.apache.myfaces.custom.schedule.util.ScheduleUtil;
 [javac]^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:50:
  cannot resolve symbol
 [javac] symbol  : class SimpleScheduleModel
 [javac] location: class org.apache.myfaces.examples.schedule.ScheduleBean
 [javac] private SimpleScheduleModel model;
 [javac] ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:178:
  cannot resolve symbol
 [javac] symbol  : class SimpleScheduleModel
 [javac] location: class org.apache.myfaces.examples.schedule.ScheduleBean
 [javac] public void setModel(SimpleScheduleModel model)
 [javac]  ^
 [javac] 
 /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:186:
  cannot resolve symbol
 

[jira] Created: (MYFACES-639) wrong renderer for HtmlCommandSortHeader

2005-09-28 Thread Dave Brondsema (JIRA)
wrong renderer for HtmlCommandSortHeader


 Key: MYFACES-639
 URL: http://issues.apache.org/jira/browse/MYFACES-639
 Project: MyFaces
Type: Bug
  Components: Tomahawk  
Versions: 1.1.0, Nightly
Reporter: Dave Brondsema
Priority: Minor


HtmlCommandSortHeader.xml and HtmlCommandSortHeader.java specify 
DEFAULT_RENDERER_TYPE = javax.faces.Link but it should be 
org.apache.myfaces.SortHeader

This causes the custom rendering (i.e. direction arrows not to appear).   I do 
not know if this manifests itself with JSPs.   Using facelets, I used the 
HtmlCommandSortHeader.java file as a reference to know which render to use in 
the facelet config.  I used javax.faces.Link and didn't get the arrows; I had 
to change it to org.apache.myfaces.SortHeader.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: 30 more minutes till branch...

2005-09-28 Thread Sean Schofield
Also I don't think we've even checked in single fix into the branch
yet.  So we're only talking one or two fixes that weren't already in
the trunk.

sean

On 9/28/05, Sean Schofield [EMAIL PROTECTED] wrote:
 The plan was to do a release candidate over the weekend after using
 the rest of this week to fix last minute must fix bugs.  We could
 move that up a bit.  What if we build the RC on Friday?  That gives us
 through tomorrow to fix everything that needs to go in.

 Once we build the RC we can merge the fixes down.  The users of the
 nightly build will only be without these fixes for a few days.

 sean

 On 9/28/05, Martin Marinschek [EMAIL PROTECTED] wrote:
  Honestly, I just think we should push this one out.
 
  there have been 64 issues fixed since 1.1.0, that should be enough.
 
  regards,
 
  Martin
 
  On 9/28/05, Bill Dudney [EMAIL PROTECTED] wrote:
   problem is that merging is a pain in the neck. we can do it its just
   a pain
  
   So we need to push out the release sooner rather than later.
  
   I've not seen any discussion on the bug list to get fixed.
  
   TTFN,
  
   -bd-
   On Sep 28, 2005, at 2:11 AM, Mathias Brökelmann wrote:
  
IMO it´s better if we fix a bug in both trunk and the branch. Trunk is
used by more users (either by svn or through the nightlies). This will
give us more feedback if a bugfix introduces a new bug.
   
2005/9/28, Sean Schofield [EMAIL PROTECTED]:
   
Bugs that have been introduced on the branch (ex. MYFACES-634) should
obviously be fixed on the branch.
   
Additional Rule of thumb: If the bug is going to be fixed in the
branch fix it *only* in the branch.  Do not fix in the trunk.  We
will
merge into the trunk in a few weeks when we are done.
   
sean
   
On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:
   
I changed all of the issues fixed in nightly to be version 1.1.1 (by
renaming the existing nightly version in JIRA and creating a new
one.)
   
So we can now search on a list of things that are fixed in that
version and eventually generate release notes.
   
Thanks Bill for the branch (its tedious - I know.)
   
sean
   
On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
   
branch created
   
If you want a bug to be fixed in the 1_1_1 release you must apply
your changes to the release/branches/1_1_1 branch in SVN.
   
Please limit the changes to the ones identified in the other thread
titled '[proposal] Branch Content'.
   
Thanks!
   
-bd-
   
On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:
   
   
Go for it.
   
sean
   
On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
   
   
Hi Sean,
   
I need about 30 more minutes to finish up something. I'll
start the
branch around 1:00 EST. Is that OK with everyone?
   
TTFN,
   
-bd-
   
   
   
   
   
   
   
   
   
   
   
   
   
--
Mathias
   
  
  
 
 
  --
 
  http://www.irian.at
  Your JSF powerhouse -
  JSF Trainings in English and German
 



[jira] Commented: (MYFACES-628) Current Lifecycle implementation violates JSF Spec 1.1

2005-09-28 Thread Bill Dudney (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-628?page=comments#action_12330690 
] 

Bill Dudney commented on MYFACES-628:
-

I think I have this fixed, testing now.

Holger - will you be able to test it out in your app with the RC that Sean will 
put out later in the week?

Thanks!

 Current Lifecycle implementation violates JSF Spec 1.1
 --

  Key: MYFACES-628
  URL: http://issues.apache.org/jira/browse/MYFACES-628
  Project: MyFaces
 Type: Bug
   Components: JSR-127
 Versions: 1.1.0
 Reporter: Holger Schimanski
 Priority: Blocker


 If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or 
 FacesContext.responseComplete(), then the LifeCycleImpl should not execute 
 the functionality required for the current phase. (see JSF Spec 1.1 section 
 11-1 page 296f.)  LifeCycleImpl is not taking care about this. 
 This is important for us, because we'd like to make a redirect in the before 
 render response phase. And at the moment an Illegal State exception is 
 thrown, because the renderResponse is executed although responseComplete has 
 been called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (MYFACES-640) Externalize the t:commandSortHeader arrow

2005-09-28 Thread Tim Mashinter (JIRA)
Externalize the t:commandSortHeader arrow
---

 Key: MYFACES-640
 URL: http://issues.apache.org/jira/browse/MYFACES-640
 Project: MyFaces
Type: Improvement
  Components: Tomahawk  
Versions: 1.1.0
 Environment: Windows XP Professional SP 2.
Reporter: Tim Mashinter


Externalize the arrow values used by the 
org.apache.myfaces.custom.sortheader.HtmlSortHeaderRenderer are hardcoded to 
#x2191;  #x2193;. It would be nice if you could customize the value used 
there. Alternately allowing the use of images as well as characters.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Created: (MYFACES-641) f:convertNumber type=currency/ not working properly.

2005-09-28 Thread Tim Mashinter (JIRA)
f:convertNumber type=currency/ not working properly.


 Key: MYFACES-641
 URL: http://issues.apache.org/jira/browse/MYFACES-641
 Project: MyFaces
Type: Bug
  Components: General  
Versions: 1.1.0
 Environment: Win XP Professional SP2
Reporter: Tim Mashinter
Priority: Minor


h:outputText value=#{object.dollarAmount}
 f:convertNumber type=currency/
/h:outputText

When using the sun implementation of JSF it outputs the following: $1,200.55
When using the MyFaces implemenation if output the following: ¤1,200.55

The pattern being used is correct. But the currency symbol isn't automatically 
determined based on my locale the same way the SUN implementation is done. 

Having this automatically determined based on the systems locale makes this 
better for applications aiming to support multiple languages (I18N).


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-628) Current Lifecycle implementation violates JSF Spec 1.1

2005-09-28 Thread Holger Schimanski (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-628?page=comments#action_12330691 
] 

Holger Schimanski commented on MYFACES-628:
---

Wow, very fast response! I am on holiday next week, but I talk to a colleague 
to check it. Thanks a lot!

 Current Lifecycle implementation violates JSF Spec 1.1
 --

  Key: MYFACES-628
  URL: http://issues.apache.org/jira/browse/MYFACES-628
  Project: MyFaces
 Type: Bug
   Components: JSR-127
 Versions: 1.1.0
 Reporter: Holger Schimanski
 Assignee: Bill Dudney
 Priority: Blocker


 If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or 
 FacesContext.responseComplete(), then the LifeCycleImpl should not execute 
 the functionality required for the current phase. (see JSF Spec 1.1 section 
 11-1 page 296f.)  LifeCycleImpl is not taking care about this. 
 This is important for us, because we'd like to make a redirect in the before 
 render response phase. And at the moment an Illegal State exception is 
 thrown, because the renderResponse is executed although responseComplete has 
 been called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-640) Externalize the t:commandSortHeader arrow

2005-09-28 Thread Tim Mashinter (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-640?page=comments#action_12330693 
] 

Tim Mashinter commented on MYFACES-640:
---

Sorry. Meant to make this a minor issue not major. (DOH!)

 Externalize the t:commandSortHeader arrow
 ---

  Key: MYFACES-640
  URL: http://issues.apache.org/jira/browse/MYFACES-640
  Project: MyFaces
 Type: Improvement
   Components: Tomahawk
 Versions: 1.1.0
  Environment: Windows XP Professional SP 2.
 Reporter: Tim Mashinter


 Externalize the arrow values used by the 
 org.apache.myfaces.custom.sortheader.HtmlSortHeaderRenderer are hardcoded to 
 #x2191;  #x2193;. It would be nice if you could customize the value 
 used there. Alternately allowing the use of images as well as characters.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Updated: (MYFACES-636) t:selectOneRadio validation messages in dataTable

2005-09-28 Thread Jamie Cash (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-636?page=all ]

Jamie Cash updated MYFACES-636:
---

Attachment: 636.patch.diff

Patch. Now checks if message with same id is already on messages queue, if so, 
it doesn't add it again. This behaviour only happens if falseId = true and 
falseIdIndex = false. The behaviour is the same as before (call to super) if 
these conditions are not met.

 t:selectOneRadio validation messages in dataTable
 -

  Key: MYFACES-636
  URL: http://issues.apache.org/jira/browse/MYFACES-636
  Project: MyFaces
 Type: Bug
   Components: Tomahawk
 Versions: 1.1.0, 1.0.9m9, Nightly
  Environment: All Tested (JBoss, Tomcat on Win 2000, and Win 2003). Code 
 analysis identifies that this bug would occour on all environments.
 Reporter: Jamie Cash
  Attachments: 636.patch.diff

 If the tomahawk selectOneRadio is used in a datatable (forceId = true, 
 forceIdIndex = false) and required is true and no items are selected, then a 
 validation error message will be added for every radio button in the data 
 table. This message should only occour once for the set.
 forceId = true and forceIdIndex = false identifies that all radio buttons 
 with the same id are within the same group, and should be validated 
 accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Commented: (MYFACES-640) Externalize the t:commandSortHeader arrow

2005-09-28 Thread Mike Kienenberger (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-640?page=comments#action_12330699 
] 

Mike Kienenberger commented on MYFACES-640:
---

Tim,  can you create a patch for this behavior?

In most open source projects, improvements and new features are implemented by 
those who need them. :)

Thanks!

 Externalize the t:commandSortHeader arrow
 ---

  Key: MYFACES-640
  URL: http://issues.apache.org/jira/browse/MYFACES-640
  Project: MyFaces
 Type: Improvement
   Components: Tomahawk
 Versions: 1.1.0
  Environment: Windows XP Professional SP 2.
 Reporter: Tim Mashinter


 Externalize the arrow values used by the 
 org.apache.myfaces.custom.sortheader.HtmlSortHeaderRenderer are hardcoded to 
 #x2191;  #x2193;. It would be nice if you could customize the value 
 used there. Alternately allowing the use of images as well as characters.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: 30 more minutes till branch...

2005-09-28 Thread Sean Schofield
No worries :-)

On 9/28/05, Martin Marinschek [EMAIL PROTECTED] wrote:
 Sorry Sean,

 I didn't mean to put stress on anyone ;)

 I was just saying that we don't need to commit anything against the
 branch - if it is good as it is, we can just release it.

 If need be, we can of course commit against the branch, it might just
 not be necessary!

 regards,

 Martin

 On 9/28/05, Sean Schofield [EMAIL PROTECTED] wrote:
  Also I don't think we've even checked in single fix into the branch
  yet.  So we're only talking one or two fixes that weren't already in
  the trunk.
 
  sean
 
  On 9/28/05, Sean Schofield [EMAIL PROTECTED] wrote:
   The plan was to do a release candidate over the weekend after using
   the rest of this week to fix last minute must fix bugs.  We could
   move that up a bit.  What if we build the RC on Friday?  That gives us
   through tomorrow to fix everything that needs to go in.
  
   Once we build the RC we can merge the fixes down.  The users of the
   nightly build will only be without these fixes for a few days.
  
   sean
  
   On 9/28/05, Martin Marinschek [EMAIL PROTECTED] wrote:
Honestly, I just think we should push this one out.
   
there have been 64 issues fixed since 1.1.0, that should be enough.
   
regards,
   
Martin
   
On 9/28/05, Bill Dudney [EMAIL PROTECTED] wrote:
 problem is that merging is a pain in the neck. we can do it its just
 a pain

 So we need to push out the release sooner rather than later.

 I've not seen any discussion on the bug list to get fixed.

 TTFN,

 -bd-
 On Sep 28, 2005, at 2:11 AM, Mathias Brökelmann wrote:

  IMO it´s better if we fix a bug in both trunk and the branch. Trunk 
  is
  used by more users (either by svn or through the nightlies). This 
  will
  give us more feedback if a bugfix introduces a new bug.
 
  2005/9/28, Sean Schofield [EMAIL PROTECTED]:
 
  Bugs that have been introduced on the branch (ex. MYFACES-634) 
  should
  obviously be fixed on the branch.
 
  Additional Rule of thumb: If the bug is going to be fixed in the
  branch fix it *only* in the branch.  Do not fix in the trunk.  We
  will
  merge into the trunk in a few weeks when we are done.
 
  sean
 
  On 9/27/05, Sean Schofield [EMAIL PROTECTED] wrote:
 
  I changed all of the issues fixed in nightly to be version 1.1.1 
  (by
  renaming the existing nightly version in JIRA and creating a new
  one.)
 
  So we can now search on a list of things that are fixed in that
  version and eventually generate release notes.
 
  Thanks Bill for the branch (its tedious - I know.)
 
  sean
 
  On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
 
  branch created
 
  If you want a bug to be fixed in the 1_1_1 release you must apply
  your changes to the release/branches/1_1_1 branch in SVN.
 
  Please limit the changes to the ones identified in the other 
  thread
  titled '[proposal] Branch Content'.
 
  Thanks!
 
  -bd-
 
  On Sep 27, 2005, at 10:21 AM, Sean Schofield wrote:
 
 
  Go for it.
 
  sean
 
  On 9/27/05, Bill Dudney [EMAIL PROTECTED] wrote:
 
 
  Hi Sean,
 
  I need about 30 more minutes to finish up something. I'll
  start the
  branch around 1:00 EST. Is that OK with everyone?
 
  TTFN,
 
  -bd-
 
 
 
 
 
 
 
 
 
 
 
 
 
  --
  Mathias
 


   
   
--
   
http://www.irian.at
Your JSF powerhouse -
JSF Trainings in English and German
   
  
 
 


 --

 http://www.irian.at
 Your JSF powerhouse -
 JSF Trainings in English and German



Re: New s:graphicImageAjax component.

2005-09-28 Thread Sylvain Vieujot




As for the URL limitation, this can indeed be a problem, but not @ 1024 chars.
There is no spec limiting the number of chars in the URL, but browsers can have problems :
http://www.aspfaq.com/show.asp?id=

But, as I didn't find any way to use a post request to load an image, I see no workaround for this.
We'll just have to experiment if in real life it causes really problems, and put a warning on this.

About your phase listener comment, could you send me a patch for this ?

Thanks !

Sylvain.

On Wed, 2005-09-28 at 10:06 +0200, Mathias Brkelmann wrote:


Great! We definitely need a component to render dynamic images.

I took a view into the code and saw that the state is appended to the
image url. IMO it will not work in every case since the state could be
very large and as far as I know there is a limitation around 1024
chars in a request url.

The other thing is the phase listener which will not work if the
component is used in a uidata component. Try using a custom faces
event which is queued through UIComponent.queueEvent(...).


2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
  I just committed a first working version of a graphicImage component that
 displays the images from bytes, and that doesn't need an additional servlet.

  It works, but there is still work to be done (See the TODOs in the
 component's java file).

  The most important things are :
  1) Find a good name for this component. Right now, it says Ajax whereas
 it's not really Ajax.
  2) Extend it to make download links (uses an a instead of an img

  Thanks for your ideas,

  Sylvain.

  On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
  Sylvain,

 I'm definitely interested in a component that can display an image
 from bytes as well, if you want any assistance.

 -- need a dynamic image servlet is the next item on my todo list :)

 On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Yes, you're right, but I was looking for a way to use the same code with a
  get request instead of a post request.
  So, I think this will work.
 
  I'll post this soon so that you can check it.
 
  Thanks,
 
  Sylvain.
 
 
  On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
  The snippet you posted is just about remembering the state of the
  application client side - it doesn't have to do anything with dynamic
  loading of images...
 
  Or do I get you completely wrong?
 
  regards,
 
  Martin
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   You're right, Ajax isn't the perfect term for this, as the result won't
 be
   XML.
  
   But maybe it can work using something similar to that :
callback: function(element,entry) {return
  
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
   +
  
   (extracted from the inputSuggestAjax code).
  
   Thanks for the clue.
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
  
   The XMLHttpRequest object (or the equivalent ActiveX control)'s open
  method
   takes as its first argument the request method you want to use. So you
   could make a get request simply by saying:
  
   xHR.open(GET, url[, asyncflag][, username][, password]);
  
   I believe that answers your question, but I'm not sure I understand how
   that helps you. I mean, AJAX will return a text string, and possibly a
   document object if the response is valid XML. It won't return an image.
   The only way to load an image is, as you say, using the src property of
  the
   image object, and that will always do a GET. I don't see how you get
 AJAX
   to work into this scenario, unless you plan to use it to generate the
 URL
   for the image object to load.
  
   Or am I just missing something in your original message?
  
   -Matt
  
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  
   Hello,
  
   I'm trying to make a new component that would display an image, but
  without
   the need to have a dedicated servlet.
   It would make applications that use images from a lot of different
 sources
   (i.e. servlets) much simpler.
   Basically, it would be a component like :
   x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
  
   As the only way I found to load an image in _javascript_ is
 image.src="">
   I can't use a post request.
  
   Does someone know a way either to load an image in _javascript_ with the
   result of a post request, or a way to use ajax like in inputSuggestAjax,
  but
   with a get url ?
  
   Thanks,
  
   Sylvain.
  
  
 
 
  --
 
  http://www.irian.at
  Your JSF powerhouse -
  JSF Trainings in English and German
 
 




--
Mathias






[jira] Resolved: (MYFACES-623) setValue() method of ValueBindingImpl does not behave properly

2005-09-28 Thread Bill Dudney (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-623?page=all ]
 
Bill Dudney resolved MYFACES-623:
-

Fix Version: 1.1.1
 Resolution: Fixed

Added the fix for this to the branch since I had the tests there. We still need 
comments on the 'null' type being returned for properties in a map.

 setValue() method of ValueBindingImpl does not behave properly
 --

  Key: MYFACES-623
  URL: http://issues.apache.org/jira/browse/MYFACES-623
  Project: MyFaces
 Type: Bug
   Components: JSR-127
 Versions: 1.1.0
 Reporter: sean schofield
 Assignee: Bill Dudney
  Fix For: 1.1.1
  Attachments: MYFACES-623.patch

 According to section 5.1.4 of the specification (p. 5-4) ...
 If you have #{expr-a[value-b]}  where value-a is a Map then ...
 call value-a.put(value-b, newValue).
 The MyFaces implementation is coercing newValue into String which is 
 incorrect behavior.  
 NOTE: I discovered the problem while using a bean that was programatically 
 added to the session map.  So there is is no class defined in 
 faces-config.xml.  I don't think this should matter but I thought I would 
 mention it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



[jira] Resolved: (MYFACES-628) Current Lifecycle implementation violates JSF Spec 1.1

2005-09-28 Thread Bill Dudney (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-628?page=all ]
 
Bill Dudney resolved MYFACES-628:
-

Fix Version: 1.1.1
 Resolution: Fixed

fix for this bug is on the branch along with a cactus test

 Current Lifecycle implementation violates JSF Spec 1.1
 --

  Key: MYFACES-628
  URL: http://issues.apache.org/jira/browse/MYFACES-628
  Project: MyFaces
 Type: Bug
   Components: JSR-127
 Versions: 1.1.0
 Reporter: Holger Schimanski
 Assignee: Bill Dudney
 Priority: Blocker
  Fix For: 1.1.1


 If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or 
 FacesContext.responseComplete(), then the LifeCycleImpl should not execute 
 the functionality required for the current phase. (see JSF Spec 1.1 section 
 11-1 page 296f.)  LifeCycleImpl is not taking care about this. 
 This is important for us, because we'd like to make a redirect in the before 
 render response phase. And at the moment an Illegal State exception is 
 thrown, because the renderResponse is executed although responseComplete has 
 been called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: New s:graphicImageAjax component.

2005-09-28 Thread Sylvain Vieujot




I like the fact that it starts like the standard graphicImage component, but the Dynamic part is good to.
What about graphicImageDynamic?
A bite long though 

Or maybe graphicImageBytes, which would be consistent with a downloadBytes tag ?

On Wed, 2005-09-28 at 08:49 -0400, Sean Schofield wrote:


How about something like dynaImage?

sean

On 9/28/05, Mathias Brkelmann [EMAIL PROTECTED] wrote:
 Great! We definitely need a component to render dynamic images.

 I took a view into the code and saw that the state is appended to the
 image url. IMO it will not work in every case since the state could be
 very large and as far as I know there is a limitation around 1024
 chars in a request url.

 The other thing is the phase listener which will not work if the
 component is used in a uidata component. Try using a custom faces
 event which is queued through UIComponent.queueEvent(...).


 2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
   I just committed a first working version of a graphicImage component that
  displays the images from bytes, and that doesn't need an additional servlet.
 
   It works, but there is still work to be done (See the TODOs in the
  component's java file).
 
   The most important things are :
   1) Find a good name for this component. Right now, it says Ajax whereas
  it's not really Ajax.
   2) Extend it to make download links (uses an a instead of an img
 
   Thanks for your ideas,
 
   Sylvain.
 
   On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
   Sylvain,
 
  I'm definitely interested in a component that can display an image
  from bytes as well, if you want any assistance.
 
  -- need a dynamic image servlet is the next item on my todo list :)
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   Yes, you're right, but I was looking for a way to use the same code with a
   get request instead of a post request.
   So, I think this will work.
  
   I'll post this soon so that you can check it.
  
   Thanks,
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
   The snippet you posted is just about remembering the state of the
   application client side - it doesn't have to do anything with dynamic
   loading of images...
  
   Or do I get you completely wrong?
  
   regards,
  
   Martin
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
You're right, Ajax isn't the perfect term for this, as the result won't
  be
XML.
   
But maybe it can work using something similar to that :
 callback: function(element,entry) {return
   
  
  entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
+
   
(extracted from the inputSuggestAjax code).
   
Thanks for the clue.
   
Sylvain.
   
   
On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
   
The XMLHttpRequest object (or the equivalent ActiveX control)'s open
   method
takes as its first argument the request method you want to use. So you
could make a get request simply by saying:
   
xHR.open(GET, url[, asyncflag][, username][, password]);
   
I believe that answers your question, but I'm not sure I understand how
that helps you. I mean, AJAX will return a text string, and possibly a
document object if the response is valid XML. It won't return an image.
The only way to load an image is, as you say, using the src property of
   the
image object, and that will always do a GET. I don't see how you get
  AJAX
to work into this scenario, unless you plan to use it to generate the
  URL
for the image object to load.
   
Or am I just missing something in your original message?
   
-Matt
   
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   
Hello,
   
I'm trying to make a new component that would display an image, but
   without
the need to have a dedicated servlet.
It would make applications that use images from a lot of different
  sources
(i.e. servlets) much simpler.
Basically, it would be a component like :
x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
   
As the only way I found to load an image in _javascript_ is
  image.src="">
I can't use a post request.
   
Does someone know a way either to load an image in _javascript_ with the
result of a post request, or a way to use ajax like in inputSuggestAjax,
   but
with a get url ?
   
Thanks,
   
Sylvain.
   
   
  
  
   --
  
   http://www.irian.at
   Your JSF powerhouse -
   JSF Trainings in English and German
  
  
 
 


 --
 Mathias







Re: Build Failure

2005-09-28 Thread Sean Schofield
I figured out the problem (it was with the build scrpt).  I'm working
on the fix.

sean

On 9/28/05, Sean Schofield [EMAIL PROTECTED] wrote:
 Last nights build was broken.  Can we get things compiling again?

 sean


 On 9/27/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
   [echo] build.dir: /home/sjs4/bootstrap/myfaces-current/build
   [echo] build output directory: /home/sjs4/release
   [echo] suproject : api
   [echo] properties: api/build.properties
   [echo] suproject : impl
   [echo] properties: impl/build.properties
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/share/src/java/org/apache/myfaces/renderkit/html/HtmlFormRendererBase.java:85:
   warning - @return tag has no arguments.
   [echo] suproject : tomahawk
   [echo] properties: tomahawk/build.properties
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:156:
   warning - Tag @see: can't find 
  encodeColumnChild(javax.faces.context.FacesContext, 
  javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
  javax.faces.component.UIComponent, java.lang.String) in 
  org.apache.myfaces.renderkit.html.HtmlTableRendererBase
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/share/src/java/org/apache/myfaces/renderkit/html/HtmlFormRendererBase.java:85:
   warning - @return tag has no arguments.
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:179:
   warning - Tag @see: can't find 
  renderColumnBody(javax.faces.context.FacesContext, 
  javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
  javax.faces.component.UIComponent, java.lang.String) in 
  org.apache.myfaces.renderkit.html.HtmlTableRendererBase
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/custom/tree2/UITreeData.java:421:
   warning - @param argument expandAll is not a parameter name.
[javadoc] 
  /home/sjs4/bootstrap/myfaces-current/tomahawk/src/java/org/apache/myfaces/renderkit/html/ext/HtmlTableRenderer.java:179:
   warning - Tag @see: can't find 
  renderColumnBody(javax.faces.context.FacesContext, 
  javax.faces.context.ResponseWriter, javax.faces.component.UIData, 
  javax.faces.component.UIComponent, java.lang.String) in 
  org.apache.myfaces.renderkit.html.HtmlTableRendererBase
   [echo] suproject : examples
   [echo] properties: examples/build.properties
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/AppointmentBean.java:23:
   package org.apache.myfaces.custom.schedule.model does not exist
  [javac] import 
  org.apache.myfaces.custom.schedule.model.DefaultScheduleEntry;
  [javac] ^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/AppointmentBean.java:24:
   package org.apache.myfaces.custom.schedule.model does not exist
  [javac] import 
  org.apache.myfaces.custom.schedule.model.SimpleScheduleModel;
  [javac] ^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:28:
   package org.apache.myfaces.custom.schedule.model does not exist
  [javac] import org.apache.myfaces.custom.schedule.model.ScheduleModel;
  [javac] ^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:29:
   package org.apache.myfaces.custom.schedule.model does not exist
  [javac] import 
  org.apache.myfaces.custom.schedule.model.SimpleScheduleModel;
  [javac] ^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:30:
   package org.apache.myfaces.custom.schedule.util does not exist
  [javac] import org.apache.myfaces.custom.schedule.util.ScheduleUtil;
  [javac]^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:50:
   cannot resolve symbol
  [javac] symbol  : class SimpleScheduleModel
  [javac] location: class 
  org.apache.myfaces.examples.schedule.ScheduleBean
  [javac] private SimpleScheduleModel model;
  [javac] ^
  [javac] 
  /home/sjs4/bootstrap/myfaces-current/examples/sandbox/src/java/org/apache/myfaces/examples/schedule/ScheduleBean.java:178:
   cannot resolve symbol
  [javac] symbol  : class SimpleScheduleModel
  [javac] location: class 
  org.apache.myfaces.examples.schedule.ScheduleBean
  [javac] public void 

[jira] Created: (MYFACES-642) t:commandSortHeader is not disabled if attribute 'enabledOnUserRole' is used and user isn't in role

2005-09-28 Thread JIRA
t:commandSortHeader is not disabled if attribute 'enabledOnUserRole' is used 
and user isn't in role
-

 Key: MYFACES-642
 URL: http://issues.apache.org/jira/browse/MYFACES-642
 Project: MyFaces
Type: Bug
  Components: Tomahawk  
Versions: 1.0.9m9, 1.1.0
Reporter: Sascha Groß


The table-row-header is not disabled if  attribute 'enabledOnUserRole' is used 
and user isn't in role. 
The only difference is that the arrow isn't rendered.

Fix in org.apache.myfaces.custom.sortheader.HtmlSortHeaderRenderer:
class HtmlSortHeaderRenderer
extends org.apache.myfaces.renderkit.html.ext.HtmlLinkRenderer

and not 
   org.apache.myfaces.renderkit.html.HtmlLinkRendererBase

Note:
This fix requires fix from MYFACES-637


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: Stability of 1.1.0?

2005-09-28 Thread Sean Schofield
Personally I would wait another week or so until 1.1.1 comes out. 
Perhaps you could help us test the RC when it comes out over the
weekend...

sean

On 9/28/05, CONNER, BRENDAN (SBCSI) [EMAIL PROTECTED] wrote:
 I've noticed a lot of bug reports since the development of the 1.1.0
 release.  Should I be waiting for a 1.1.1 release before trying to
 integrate the new JARs into our production application?  We're currently
 using a nightly build from late August, which seems to be working well,
 but we obviously want to start using an official release.

 - Brendan



RE: Stability of 1.1.0?

2005-09-28 Thread CONNER, BRENDAN \(SBCSI\)
OK, sounds good.  I'd be up for helping to test.

- Brendan

-Original Message-
From: Sean Schofield [mailto:[EMAIL PROTECTED] 
Sent: Wednesday, September 28, 2005 1:18 PM
To: MyFaces Development
Subject: Re: Stability of 1.1.0?


Personally I would wait another week or so until 1.1.1 comes out. 
Perhaps you could help us test the RC when it comes out over the
weekend...

sean

On 9/28/05, CONNER, BRENDAN (SBCSI) [EMAIL PROTECTED] wrote:
 I've noticed a lot of bug reports since the development of the 1.1.0
 release.  Should I be waiting for a 1.1.1 release before trying to
 integrate the new JARs into our production application?  We're
currently
 using a nightly build from late August, which seems to be working
well,
 but we obviously want to start using an official release.

 - Brendan



Re: svn commit: r292231 - /myfaces/build/branches/1_1_1/build.xml

2005-09-28 Thread Mike Kienenberger
Sean, this appears to be broken in the current trunk as well.
I'm trying to use the sandbox for the first time (graphicImageAjax),
and it's now skipping over the sandbox build when using ant by
itself.

I've manually applied your patch to what I checked out, and it's working.

On 9/28/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
 Author: schof
 Date: Wed Sep 28 10:50:17 2005
 New Revision: 292231

 URL: http://svn.apache.org/viewcvs?rev=292231view=rev
 Log:
 now building sandbox stuff (and in correct order)

 Modified:
 myfaces/build/branches/1_1_1/build.xml

 Modified: myfaces/build/branches/1_1_1/build.xml
 URL: 
 http://svn.apache.org/viewcvs/myfaces/build/branches/1_1_1/build.xml?rev=292231r1=292230r2=292231view=diff
 ==
 --- myfaces/build/branches/1_1_1/build.xml (original)
 +++ myfaces/build/branches/1_1_1/build.xml Wed Sep 28 10:50:17 2005
 @@ -499,6 +499,9 @@
  property name=subproject value=tomahawk/
  /ant
  ant target=subproject
 +property name=subproject value=sandbox/
 +/ant
 +ant target=subproject
  property name=subproject value=examples/
  /ant
  /target





[jira] Created: (MYFACES-643) InputSuggestAjax does not work when javax.faces.STATE_SAVING_METHOD=server

2005-09-28 Thread Chris Barlow (JIRA)
InputSuggestAjax does not work when javax.faces.STATE_SAVING_METHOD=server
--

 Key: MYFACES-643
 URL: http://issues.apache.org/jira/browse/MYFACES-643
 Project: MyFaces
Type: Bug
  Components: Sandbox  
Versions: 1.1.0
 Environment: Tomcat 5.0.30; IE 6.0.2800
Reporter: Chris Barlow


Setting javax.faces.STATE_SAVING_METHOD=server causes a javascript error when 
typing text into the input box.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: svn commit: r292231 - /myfaces/build/branches/1_1_1/build.xml

2005-09-28 Thread Sean Schofield
Yes I noticed that as well.  Merging the branch down to the trunk is
on my todo list for today.  (This is why last night's build failed
btw.)

sean

On 9/28/05, Mike Kienenberger [EMAIL PROTECTED] wrote:
 Sean, this appears to be broken in the current trunk as well.
 I'm trying to use the sandbox for the first time (graphicImageAjax),
 and it's now skipping over the sandbox build when using ant by
 itself.

 I've manually applied your patch to what I checked out, and it's working.

 On 9/28/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
  Author: schof
  Date: Wed Sep 28 10:50:17 2005
  New Revision: 292231
 
  URL: http://svn.apache.org/viewcvs?rev=292231view=rev
  Log:
  now building sandbox stuff (and in correct order)
 
  Modified:
  myfaces/build/branches/1_1_1/build.xml
 
  Modified: myfaces/build/branches/1_1_1/build.xml
  URL: 
  http://svn.apache.org/viewcvs/myfaces/build/branches/1_1_1/build.xml?rev=292231r1=292230r2=292231view=diff
  ==
  --- myfaces/build/branches/1_1_1/build.xml (original)
  +++ myfaces/build/branches/1_1_1/build.xml Wed Sep 28 10:50:17 2005
  @@ -499,6 +499,9 @@
   property name=subproject value=tomahawk/
   /ant
   ant target=subproject
  +property name=subproject value=sandbox/
  +/ant
  +ant target=subproject
   property name=subproject value=examples/
   /ant
   /target
 
 
 



Re: New s:graphicImageAjax component.

2005-09-28 Thread Mike Kienenberger
Well, the url is also a problem with some containers.

Jetty 5.1.3 is generating this error:

15:28:58.609 WARN!! [SocketListener0-1]
org.mortbay.http.HttpConnection.exception(HttpConnection.java:762)
06 null /faces/pages/announcement/EditAnnouncements.xhtml HTTP/1.1
HttpException(414,Request URI Too Large,null)

and this is with a small (13,342 byte) image.  Well, relatively small :)

On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  As for the URL limitation, this can indeed be a problem, but not @ 1024
 chars.
  There is no spec limiting the number of chars in the URL, but browsers can
 have problems :
  http://www.aspfaq.com/show.asp?id=

  But, as I didn't find any way to use a post request to load an image, I see
 no workaround for this.
  We'll just have to experiment if in real life it causes really problems,
 and put a warning on this.

  About your phase listener comment, could you send me a patch for this ?

  Thanks !

  Sylvain.


  On Wed, 2005-09-28 at 10:06 +0200, Mathias Brökelmann wrote:
  Great! We definitely need a component to render dynamic images.

 I took a view into the code and saw that the state is appended to the
 image url. IMO it will not work in every case since the state could be
 very large and as far as I know there is a limitation around 1024
 chars in a request url.

 The other thing is the phase listener which will not work if the
 component is used in a uidata component. Try using a custom faces
 event which is queued through UIComponent.queueEvent(...).


 2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
  I just committed a first working version of a graphicImage component that
  displays the images from bytes, and that doesn't need an additional
 servlet.
 
  It works, but there is still work to be done (See the TODOs in the
  component's java file).
 
  The most important things are :
  1) Find a good name for this component. Right now, it says Ajax whereas
  it's not really Ajax.
  2) Extend it to make download links (uses an a instead of an img
 
  Thanks for your ideas,
 
  Sylvain.
 
  On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
  Sylvain,
 
  I'm definitely interested in a component that can display an image
  from bytes as well, if you want any assistance.
 
  -- need a dynamic image servlet is the next item on my todo list :)
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   Yes, you're right, but I was looking for a way to use the same code with
 a
   get request instead of a post request.
   So, I think this will work.
  
   I'll post this soon so that you can check it.
  
   Thanks,
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
   The snippet you posted is just about remembering the state of the
   application client side - it doesn't have to do anything with dynamic
   loading of images...
  
   Or do I get you completely wrong?
  
   regards,
  
   Martin
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
You're right, Ajax isn't the perfect term for this, as the result
 won't
  be
XML.
   
But maybe it can work using something similar to that :
 callback: function(element,entry) {return
   
  
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
+
   
(extracted from the inputSuggestAjax code).
   
Thanks for the clue.
   
Sylvain.
   
   
On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
   
The XMLHttpRequest object (or the equivalent ActiveX control)'s open
   method
takes as its first argument the request method you want to use. So you
could make a get request simply by saying:
   
xHR.open(GET, url[, asyncflag][, username][, password]);
   
I believe that answers your question, but I'm not sure I understand
 how
that helps you. I mean, AJAX will return a text string, and possibly a
document object if the response is valid XML. It won't return an
 image.
The only way to load an image is, as you say, using the src property
 of
   the
image object, and that will always do a GET. I don't see how you get
  AJAX
to work into this scenario, unless you plan to use it to generate the
  URL
for the image object to load.
   
Or am I just missing something in your original message?
   
-Matt
   
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   
Hello,
   
I'm trying to make a new component that would display an image, but
   without
the need to have a dedicated servlet.
It would make applications that use images from a lot of different
  sources
(i.e. servlets) much simpler.
Basically, it would be a component like :
x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
   
As the only way I found to load an image in javascript is
  image.src=...,
I 

Branch merge complete

2005-09-28 Thread Sean Schofield
I merged the latest branch changes down to the trunk.  If there are
more branch changes between now and Friday morning (or as a result of
the RC testing) then I will merge them down periodically.

Here are some important notes regarding the SVN merging process and
how we have our repository set up ... (Eventually this should make its
way into a wiki)

You need to identify the start and end point of the set of changes
that you want to merge.  For the first merge you do down to the trunk
you want to be very careful in selecting the start point.  You should
select the revision number after the last revision related to the
creation of the branch and the setup of the new svn:externals.  I
accidentally selected a revision after the creation of the branch but
then noticed there were changes to subprojects that I didn't think had
changed.  Turns out I was merging in the svn:externals which would be
a DISASTER.  We don't want the externals from the branch to EVER be in
the trunk.  Otherwise we will be working with the branch code even
though we think we are modifying the trunk.

When committing its important to mention the direction of the merge
(ie. branch to trunk) and the revisions that were merged (ie. r292022
- r292231).  This will help make sure that only the new changes are
merged down the next time.  So the next merge down can be (r292232 -
???) where ??? = the latest revision number at the moment.

sean


Re: 100.000 Hits a day

2005-09-28 Thread Sean Schofield
Mailing list traffic also continues to grow:

http://people.apache.org/~coar/mlists.html#myfaces.apache.org



On 9/27/05, Werner Punz [EMAIL PROTECTED] wrote:
 The funny thing is, that www.theserverside.com also had problems at the exact 
 time
 back then, so there was no official announcement.
 (Hell I tried to send them the info)
 now given that a bugfix release is in preparation I am glad that they did not 
 get the info...

 :-)


 Mathias Brökelmann wrote:
  Wasn´t there an announce for the new myfaces release in the struts
  user mailing list? ;)
 




[jira] Created: (MYFACES-644) InputDate doesn't parses submitted seconds

2005-09-28 Thread Volker Weber (JIRA)
InputDate doesn't parses submitted seconds
--

 Key: MYFACES-644
 URL: http://issues.apache.org/jira/browse/MYFACES-644
 Project: MyFaces
Type: Bug
  Components: Tomahawk  
Versions: Nightly
 Environment: any
Reporter: Volker Weber


Implement to parse the submitted seconds seems to be forgotten.

I have patched this, the diff follows:

Index: src/java/org/apache/myfaces/custom/date/HtmlInputDate.java
===
--- src/java/org/apache/myfaces/custom/date/HtmlInputDate.java  (Revision 
292164)
+++ src/java/org/apache/myfaces/custom/date/HtmlInputDate.java  (Arbeitskopie)
@@ -209,6 +209,7 @@
 tempCalendar.set(Calendar.YEAR,Integer.parseInt(year));
 tempCalendar.set(Calendar.HOUR_OF_DAY,Integer.parseInt(hours));
 tempCalendar.set(Calendar.MINUTE,Integer.parseInt(minutes));
+tempCalendar.set(Calendar.SECOND,Integer.parseInt(seconds));

 return tempCalendar.getTime();
 }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira



Re: New s:graphicImageAjax component.

2005-09-28 Thread Sylvain Vieujot




Except if you serialize the image, the size of the image shouldn't be a factor.
Did you try this with the sandbox application ?
Do you know the URL size limit in Jetty ?

Thanks,

Sylvain.

On Wed, 2005-09-28 at 15:30 -0400, Mike Kienenberger wrote:


Well, the url is also a problem with some containers.

Jetty 5.1.3 is generating this error:

15:28:58.609 WARN!! [SocketListener0-1]
org.mortbay.http.HttpConnection.exception(HttpConnection.java:762)
06 null /faces/pages/announcement/EditAnnouncements.xhtml HTTP/1.1
HttpException(414,Request URI Too Large,null)

and this is with a small (13,342 byte) image.  Well, relatively small :)

On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  As for the URL limitation, this can indeed be a problem, but not @ 1024
 chars.
  There is no spec limiting the number of chars in the URL, but browsers can
 have problems :
  http://www.aspfaq.com/show.asp?id=

  But, as I didn't find any way to use a post request to load an image, I see
 no workaround for this.
  We'll just have to experiment if in real life it causes really problems,
 and put a warning on this.

  About your phase listener comment, could you send me a patch for this ?

  Thanks !

  Sylvain.


  On Wed, 2005-09-28 at 10:06 +0200, Mathias Brkelmann wrote:
  Great! We definitely need a component to render dynamic images.

 I took a view into the code and saw that the state is appended to the
 image url. IMO it will not work in every case since the state could be
 very large and as far as I know there is a limitation around 1024
 chars in a request url.

 The other thing is the phase listener which will not work if the
 component is used in a uidata component. Try using a custom faces
 event which is queued through UIComponent.queueEvent(...).


 2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
  I just committed a first working version of a graphicImage component that
  displays the images from bytes, and that doesn't need an additional
 servlet.
 
  It works, but there is still work to be done (See the TODOs in the
  component's java file).
 
  The most important things are :
  1) Find a good name for this component. Right now, it says Ajax whereas
  it's not really Ajax.
  2) Extend it to make download links (uses an a instead of an img
 
  Thanks for your ideas,
 
  Sylvain.
 
  On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
  Sylvain,
 
  I'm definitely interested in a component that can display an image
  from bytes as well, if you want any assistance.
 
  -- need a dynamic image servlet is the next item on my todo list :)
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   Yes, you're right, but I was looking for a way to use the same code with
 a
   get request instead of a post request.
   So, I think this will work.
  
   I'll post this soon so that you can check it.
  
   Thanks,
  
   Sylvain.
  
  
   On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
   The snippet you posted is just about remembering the state of the
   application client side - it doesn't have to do anything with dynamic
   loading of images...
  
   Or do I get you completely wrong?
  
   regards,
  
   Martin
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
You're right, Ajax isn't the perfect term for this, as the result
 won't
  be
XML.
   
But maybe it can work using something similar to that :
 callback: function(element,entry) {return
   
  
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
+
   
(extracted from the inputSuggestAjax code).
   
Thanks for the clue.
   
Sylvain.
   
   
On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
   
The XMLHttpRequest object (or the equivalent ActiveX control)'s open
   method
takes as its first argument the request method you want to use. So you
could make a get request simply by saying:
   
xHR.open(GET, url[, asyncflag][, username][, password]);
   
I believe that answers your question, but I'm not sure I understand
 how
that helps you. I mean, AJAX will return a text string, and possibly a
document object if the response is valid XML. It won't return an
 image.
The only way to load an image is, as you say, using the src property
 of
   the
image object, and that will always do a GET. I don't see how you get
  AJAX
to work into this scenario, unless you plan to use it to generate the
  URL
for the image object to load.
   
Or am I just missing something in your original message?
   
-Matt
   
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   
Hello,
   
I'm trying to make a new component that would display an image, but
   without
the need to have a dedicated servlet.
It would make applications that use images from a 

Re: New s:graphicImageAjax component.

2005-09-28 Thread Mike Kienenberger
Yes, I think you're right in that the size of the image doesn't matter.
However, the size of my page's jsf_state_64 attribute does matter.
The page I'm looking at right this second has a jsf_state_64 of 3,768
bytes.

No, I didn't try this with the sandbox since it seemed easy enough to
just dump it into my own application (and it was).

I did some investigating, and the URL limit in Jetty is hardcoded to
4096 bytes.   I also noticed that this error (414 Url too large) is a
standard http protocol error, so it's reasonable to think that other
servers are going to throw it.

On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Except if you serialize the image, the size of the image shouldn't be a
 factor.
  Did you try this with the sandbox application ?
  Do you know the URL size limit in Jetty ?

  Thanks,

  Sylvain.


  On Wed, 2005-09-28 at 15:30 -0400, Mike Kienenberger wrote:
  Well, the url is also a problem with some containers.

 Jetty 5.1.3 is generating this error:

 15:28:58.609 WARN!! [SocketListener0-1]
 org.mortbay.http.HttpConnection.exception(HttpConnection.java:762)
 06 null /faces/pages/announcement/EditAnnouncements.xhtml
 HTTP/1.1
 HttpException(414,Request URI Too Large,null)

 and this is with a small (13,342 byte) image. Well, relatively small :)

 On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  As for the URL limitation, this can indeed be a problem, but not @ 1024
  chars.
  There is no spec limiting the number of chars in the URL, but browsers can
  have problems :
  http://www.aspfaq.com/show.asp?id=
 
  But, as I didn't find any way to use a post request to load an image, I
 see
  no workaround for this.
  We'll just have to experiment if in real life it causes really problems,
  and put a warning on this.
 
  About your phase listener comment, could you send me a patch for this ?
 
  Thanks !
 
  Sylvain.
 
 
  On Wed, 2005-09-28 at 10:06 +0200, Mathias Brökelmann wrote:
  Great! We definitely need a component to render dynamic images.
 
  I took a view into the code and saw that the state is appended to the
  image url. IMO it will not work in every case since the state could be
  very large and as far as I know there is a limitation around 1024
  chars in a request url.
 
  The other thing is the phase listener which will not work if the
  component is used in a uidata component. Try using a custom faces
  event which is queued through UIComponent.queueEvent(...).
 
 
  2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
   I just committed a first working version of a graphicImage component
 that
   displays the images from bytes, and that doesn't need an additional
  servlet.
  
   It works, but there is still work to be done (See the TODOs in the
   component's java file).
  
   The most important things are :
   1) Find a good name for this component. Right now, it says Ajax whereas
   it's not really Ajax.
   2) Extend it to make download links (uses an a instead of an img
  
   Thanks for your ideas,
  
   Sylvain.
  
   On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
   Sylvain,
  
   I'm definitely interested in a component that can display an image
   from bytes as well, if you want any assistance.
  
   -- need a dynamic image servlet is the next item on my todo list :)
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
Yes, you're right, but I was looking for a way to use the same code
 with
  a
get request instead of a post request.
So, I think this will work.
   
I'll post this soon so that you can check it.
   
Thanks,
   
Sylvain.
   
   
On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
The snippet you posted is just about remembering the state of the
application client side - it doesn't have to do anything with dynamic
loading of images...
   
Or do I get you completely wrong?
   
regards,
   
Martin
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
 You're right, Ajax isn't the perfect term for this, as the result
  won't
   be
 XML.

 But maybe it can work using something similar to that :
  callback: function(element,entry) {return

   
  
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
 +

 (extracted from the inputSuggestAjax code).

 Thanks for the clue.

 Sylvain.


 On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:

 The XMLHttpRequest object (or the equivalent ActiveX control)'s open
method
 takes as its first argument the request method you want to use. So
 you
 could make a get request simply by saying:

 xHR.open(GET, url[, asyncflag][, username][, password]);

 I believe that answers your question, but I'm not sure I understand
  how
 that helps 

Re: New s:graphicImageAjax component.

2005-09-28 Thread Sylvain Vieujot




Yes, probably.
I tested it with Tomcat, and it works fine, but I didn't try on a big page though.
A fix to this problem could be to have an optional initializationParameters, and omit the jsf state.
It wouldn't be as transparent, but it still would remove the need to do a special purpose servlet, and it would work with much smaller URLs.
Example :

x:graphicImageBytes
 initializationParameters=#{imageUnid=09183912}
 getContentTypeMethod=#{graphicImageAjaxBean.upImage.getContentType}
 getBytesMethod=#{graphicImageAjaxBean.upImage.getBytes}/

So the URL would just have :
- The initializationParameters
- The viewId
- The componentId

On Wed, 2005-09-28 at 16:12 -0400, Mike Kienenberger wrote:


Yes, I think you're right in that the size of the image doesn't matter.
However, the size of my page's jsf_state_64 attribute does matter.
The page I'm looking at right this second has a jsf_state_64 of 3,768
bytes.

No, I didn't try this with the sandbox since it seemed easy enough to
just dump it into my own application (and it was).

I did some investigating, and the URL limit in Jetty is hardcoded to
4096 bytes.   I also noticed that this error (414 Url too large) is a
standard http protocol error, so it's reasonable to think that other
servers are going to throw it.

On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Except if you serialize the image, the size of the image shouldn't be a
 factor.
  Did you try this with the sandbox application ?
  Do you know the URL size limit in Jetty ?

  Thanks,

  Sylvain.


  On Wed, 2005-09-28 at 15:30 -0400, Mike Kienenberger wrote:
  Well, the url is also a problem with some containers.

 Jetty 5.1.3 is generating this error:

 15:28:58.609 WARN!! [SocketListener0-1]
 org.mortbay.http.HttpConnection.exception(HttpConnection.java:762)
 06 null /faces/pages/announcement/EditAnnouncements.xhtml
 HTTP/1.1
 HttpException(414,Request URI Too Large,null)

 and this is with a small (13,342 byte) image. Well, relatively small :)

 On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  As for the URL limitation, this can indeed be a problem, but not @ 1024
  chars.
  There is no spec limiting the number of chars in the URL, but browsers can
  have problems :
  http://www.aspfaq.com/show.asp?id=
 
  But, as I didn't find any way to use a post request to load an image, I
 see
  no workaround for this.
  We'll just have to experiment if in real life it causes really problems,
  and put a warning on this.
 
  About your phase listener comment, could you send me a patch for this ?
 
  Thanks !
 
  Sylvain.
 
 
  On Wed, 2005-09-28 at 10:06 +0200, Mathias Brkelmann wrote:
  Great! We definitely need a component to render dynamic images.
 
  I took a view into the code and saw that the state is appended to the
  image url. IMO it will not work in every case since the state could be
  very large and as far as I know there is a limitation around 1024
  chars in a request url.
 
  The other thing is the phase listener which will not work if the
  component is used in a uidata component. Try using a custom faces
  event which is queued through UIComponent.queueEvent(...).
 
 
  2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
   I just committed a first working version of a graphicImage component
 that
   displays the images from bytes, and that doesn't need an additional
  servlet.
  
   It works, but there is still work to be done (See the TODOs in the
   component's java file).
  
   The most important things are :
   1) Find a good name for this component. Right now, it says Ajax whereas
   it's not really Ajax.
   2) Extend it to make download links (uses an a instead of an img
  
   Thanks for your ideas,
  
   Sylvain.
  
   On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
   Sylvain,
  
   I'm definitely interested in a component that can display an image
   from bytes as well, if you want any assistance.
  
   -- need a dynamic image servlet is the next item on my todo list :)
  
   On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
Yes, you're right, but I was looking for a way to use the same code
 with
  a
get request instead of a post request.
So, I think this will work.
   
I'll post this soon so that you can check it.
   
Thanks,
   
Sylvain.
   
   
On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
The snippet you posted is just about remembering the state of the
application client side - it doesn't have to do anything with dynamic
loading of images...
   
Or do I get you completely wrong?
   
regards,
   
Martin
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
 You're right, Ajax isn't the perfect term for this, as the result
  won't
   be
 XML.

 But maybe it can work using something similar to that :
  callback: function(element,entry) {return

   
  
 
 

Re: New s:graphicImageAjax component.

2005-09-28 Thread Mike Kienenberger
One other issue I hit (I hit it earlier but thought it was the URL
size problem by mistake).

You currently have to include this tag inside an h:form, otherwise
there's no jsf_state_64 to reference.

Now that I figured that out, I'm back to trying it in a popup window. 
 I think there's some issues with the Tag bindings under facelets that
I'll have to work out since the get* method bindings are set to null.

On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Yes, probably.
  I tested it with Tomcat, and it works fine, but I didn't try on a big page
 though.
  A fix to this problem could be to have an optional
 initializationParameters, and omit the jsf state.
  It wouldn't be as transparent, but it still would remove the need to do a
 special purpose servlet, and it would work with much smaller URLs.
  Example :

  x:graphicImageBytes
  initializationParameters=#{imageUnid=09183912}

 getContentTypeMethod=#{graphicImageAjaxBean.upImage.getContentType}

 getBytesMethod=#{graphicImageAjaxBean.upImage.getBytes}/

  So the URL would just have :
  - The initializationParameters
  - The viewId
  - The componentId


  On Wed, 2005-09-28 at 16:12 -0400, Mike Kienenberger wrote:
  Yes, I think you're right in that the size of the image doesn't matter.
 However, the size of my page's jsf_state_64 attribute does matter.
 The page I'm looking at right this second has a jsf_state_64 of 3,768
 bytes.

 No, I didn't try this with the sandbox since it seemed easy enough to
 just dump it into my own application (and it was).

 I did some investigating, and the URL limit in Jetty is hardcoded to
 4096 bytes. I also noticed that this error (414 Url too large) is a
 standard http protocol error, so it's reasonable to think that other
 servers are going to throw it.

 On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Except if you serialize the image, the size of the image shouldn't be a
  factor.
  Did you try this with the sandbox application ?
  Do you know the URL size limit in Jetty ?
 
  Thanks,
 
  Sylvain.
 
 
  On Wed, 2005-09-28 at 15:30 -0400, Mike Kienenberger wrote:
  Well, the url is also a problem with some containers.
 
  Jetty 5.1.3 is generating this error:
 
  15:28:58.609 WARN!! [SocketListener0-1]
 
 org.mortbay.http.HttpConnection.exception(HttpConnection.java:762)
  06 null
 /faces/pages/announcement/EditAnnouncements.xhtml
  HTTP/1.1
  HttpException(414,Request URI Too Large,null)
 
  and this is with a small (13,342 byte) image. Well, relatively small :)
 
  On 9/28/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
   As for the URL limitation, this can indeed be a problem, but not @ 1024
   chars.
   There is no spec limiting the number of chars in the URL, but browsers
 can
   have problems :
   http://www.aspfaq.com/show.asp?id=
  
   But, as I didn't find any way to use a post request to load an image, I
  see
   no workaround for this.
   We'll just have to experiment if in real life it causes really problems,
   and put a warning on this.
  
   About your phase listener comment, could you send me a patch for this ?
  
   Thanks !
  
   Sylvain.
  
  
   On Wed, 2005-09-28 at 10:06 +0200, Mathias Brökelmann wrote:
   Great! We definitely need a component to render dynamic images.
  
   I took a view into the code and saw that the state is appended to the
   image url. IMO it will not work in every case since the state could be
   very large and as far as I know there is a limitation around 1024
   chars in a request url.
  
   The other thing is the phase listener which will not work if the
   component is used in a uidata component. Try using a custom faces
   event which is queued through UIComponent.queueEvent(...).
  
  
   2005/9/28, Sylvain Vieujot [EMAIL PROTECTED]:
I just committed a first working version of a graphicImage component
  that
displays the images from bytes, and that doesn't need an additional
   servlet.
   
It works, but there is still work to be done (See the TODOs in the
component's java file).
   
The most important things are :
1) Find a good name for this component. Right now, it says Ajax
 whereas
it's not really Ajax.
2) Extend it to make download links (uses an a instead of an img
   
Thanks for your ideas,
   
Sylvain.
   
On Tue, 2005-09-27 at 12:35 -0400, Mike Kienenberger wrote:
Sylvain,
   
I'm definitely interested in a component that can display an image
from bytes as well, if you want any assistance.
   
-- need a dynamic image servlet is the next item on my todo list :)
   
On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
 Yes, you're right, but I was looking for a way to use the same code
  with
   a
 get request instead of a post request.
 So, I think this will work.

 I'll post this soon so that you can check it.

 Thanks,

 Sylvain.


 On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
 The snippet you posted is 

Re: Ajax with get requests

2005-09-28 Thread Mike Kienenberger
Sylvain,

Just saw this posted elsewhere.

Maybe it'll be useful.

Performing a JSF GET
http://jroller.com/page/why?entry=how_to_do_a_jsf

It doesn't quite look like what you want, though.

On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  Yes, you're right, but I was looking for a way to use the same code with a
 get request instead of a post request.
  So, I think this will work.

  I'll post this soon so that you can check it.

  Thanks,

  Sylvain.


  On Mon, 2005-09-26 at 23:24 +0200, Martin Marinschek wrote:
  The snippet you posted is just about remembering the state of the
 application client side - it doesn't have to do anything with dynamic
 loading of images...

 Or do I get you completely wrong?

 regards,

 Martin

 On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
  You're right, Ajax isn't the perfect term for this, as the result won't be
  XML.
 
  But maybe it can work using something similar to that :
   callback: function(element,entry) {return
 
 entry+'jsf_tree_64='+encodeURIComponent(document.getElementById('jsf_tree_64').value)+'jsf_state_64='+encodeURIComponent(document.getElementById('jsf_state_64').value)+'jsf_viewid='+encodeURIComponent(document.getElementById('jsf_viewid').value)}
  +
 
  (extracted from the inputSuggestAjax code).
 
  Thanks for the clue.
 
  Sylvain.
 
 
  On Mon, 2005-09-26 at 16:27 -0400, Matt Blum wrote:
 
  The XMLHttpRequest object (or the equivalent ActiveX control)'s open
 method
  takes as its first argument the request method you want to use. So you
  could make a get request simply by saying:
 
  xHR.open(GET, url[, asyncflag][, username][, password]);
 
  I believe that answers your question, but I'm not sure I understand how
  that helps you. I mean, AJAX will return a text string, and possibly a
  document object if the response is valid XML. It won't return an image.
  The only way to load an image is, as you say, using the src property of
 the
  image object, and that will always do a GET. I don't see how you get AJAX
  to work into this scenario, unless you plan to use it to generate the URL
  for the image object to load.
 
  Or am I just missing something in your original message?
 
  -Matt
 
 
  On 9/26/05, Sylvain Vieujot [EMAIL PROTECTED] wrote:
 
  Hello,
 
  I'm trying to make a new component that would display an image, but
 without
  the need to have a dedicated servlet.
  It would make applications that use images from a lot of different sources
  (i.e. servlets) much simpler.
  Basically, it would be a component like :
  x:graphicImageAjax getBytesMethod=#{myBean.imageBytes}/
 
  As the only way I found to load an image in javascript is image.src=...,
  I can't use a post request.
 
  Does someone know a way either to load an image in javascript with the
  result of a post request, or a way to use ajax like in inputSuggestAjax,
 but
  with a get url ?
 
  Thanks,
 
  Sylvain.
 
 


 --

 http://www.irian.at
 Your JSF powerhouse -
 JSF Trainings in English and German




Re: Branch merge complete

2005-09-28 Thread Bill Dudney

Hi Sean,

I was able to perform a merge from the branch to the trunk like this;

svn merge https://svn.apache.org/repos/asf/myfaces/impl/trunk
https://svn.apache.org/repos/asf/myfaces/impl/ 
branches/1_1_1 .


I did this command while inside the impl subproject under 'current'.

It worked like a champ and seems to be much easier (and safer) that  
what you describe below.


Thoughts?

-bd-

On Sep 28, 2005, at 1:36 PM, Sean Schofield wrote:


I merged the latest branch changes down to the trunk.  If there are
more branch changes between now and Friday morning (or as a result of
the RC testing) then I will merge them down periodically.

Here are some important notes regarding the SVN merging process and
how we have our repository set up ... (Eventually this should make its
way into a wiki)

You need to identify the start and end point of the set of changes
that you want to merge.  For the first merge you do down to the trunk
you want to be very careful in selecting the start point.  You should
select the revision number after the last revision related to the
creation of the branch and the setup of the new svn:externals.  I
accidentally selected a revision after the creation of the branch but
then noticed there were changes to subprojects that I didn't think had
changed.  Turns out I was merging in the svn:externals which would be
a DISASTER.  We don't want the externals from the branch to EVER be in
the trunk.  Otherwise we will be working with the branch code even
though we think we are modifying the trunk.

When committing its important to mention the direction of the merge
(ie. branch to trunk) and the revisions that were merged (ie. r292022
- r292231).  This will help make sure that only the new changes are
merged down the next time.  So the next merge down can be (r292232 -
???) where ??? = the latest revision number at the moment.

sean





[jira] Closed: (MYFACES-401) CommandLink tag override onsubmit function of Form

2005-09-28 Thread Martin Marinschek (JIRA)
 [ http://issues.apache.org/jira/browse/MYFACES-401?page=all ]
 
Martin Marinschek closed MYFACES-401:
-

Resolution: Fixed

Right - closing this out.

It's correct as it is implemented right now (with the patch of Zhong Li) and is 
already in the code that was branched for 1.1.1

regards,

Martin

 CommandLink tag override onsubmit function of Form
 --

  Key: MYFACES-401
  URL: http://issues.apache.org/jira/browse/MYFACES-401
  Project: MyFaces
 Type: Bug
   Components: Implementation
 Versions: 1.1.0
  Environment: Tomcat 5.0.28
 Reporter: Zhong Li
 Assignee: Martin Marinschek
 Priority: Critical
  Fix For: 1.1.1
  Attachments: bugfix_myfaces-401.txt

 I have java script onsubmit in h:form, when I use commandLink tag, even 
 onsubmit return false, the form still submitted. I checked javasctipt, If I 
 am right, the bug should be here,
 JSF generate Javascript for each commandLink like,
 clear_unitItemViewList();
 document.forms['unitItemViewList'].elements['autoScroll'].value=getScrolling();
 document.forms['unitItemViewList'].elements['unitItemViewList:_link_hidden_'].value='unitItemViewList:_id49_0:_id72';
 if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
 document.forms['unitItemViewList'].submit();
 return false;
 --
 so problem it will be caused by 
 if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
 document.forms['unitItemViewList'].submit(); //the form submitted!!
 it should be 
 if(document.forms['unitItemViewList'].onsubmit)
 {
 if( document.forms['unitItemViewList'].onsubmit() )
 {
document.forms['unitItemViewList'].submit();
 }
 }
 else
 {
document.forms['unitItemViewList'].submit();
 }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira