Re: Ofbiz REST API

[Hans Bakker]

Hi James,

I created a POC REST interface from OFBiz some time ago. Although there 
no accounting services, there are several others. They could serve as a 
guideline how to implement the services you need.


The service definitions are here: 
https://github.com/growerp/growerp-ofbiz/blob/master/servicedef/services100.xml
The implementation here: 
https://github.com/growerp/growerp-ofbiz/tree/master/src/100


documentation of the interface here: 
https://github.com/growerp/growerp-ofbiz/blob/master/README.adoc


If i can help you in any way, let me know.

Regards,

Hans

On 31/01/2024 03:51, James David wrote:

Hello,



Is there an official released version of REST API’s for the accounts
portion of Ofbiz or is it up to each developer to expose the services they
require?



Perhaps I’m missing something but I have installed the rest-api plugin and
there are no services other than a sample findProductById.

We would like to automate an interface from another application that would
add A/R invoices, A/P invoices, and GL Transactions and then read things
like customer A/R balances back. We have an existing interface using a REST
API and would like to reuse it as much as possible.



If there is no distribution with services included, is there any documented
walk through of how to add services?

The videos I’ve seen online are very hard to see/understand.



Appreciate your help.



Thanks,

James





*James David*

jam...@jonasmetals.com

Re: Using containers to run demo sites

[Hans Bakker]

You might have a look at: https://issues.apache.org/jira/browse/OFBIZ-10407

I tried to implement this some time ago

Regards,

Hans

On 1/3/23 21:31, Daniel Watford wrote:

Hi Jacques and all,

 From the ongoing discussions regarding JDK 17 and release 21, I inferred
from one of Jacques comments that there was some difficulty in using
different JDK versions for the stable and next demos and it was therefore
preferred to run the stable and next demos on the same JDK version.

My inference may be incorrect here, but it got me thinking again on the
subject of running OFBiz from containers.

I'm not familiar with the infrastructure used to host the demo sites, so
this thought process may be a non-starter, but do we have the facility to
run Docker containers on the demo sites' server?

If containers on the demo servers are a possibility then it may be worth
exploring their use as they might allow side-stepping difficulties related
to installing JDK versions on the server.

There will doubtlessly be some difficulties to overcome and I don't have a
full solution in mind yet, but some potential benefits I see are:
- All dependencies, including the JDK, are encapsulated in the container
image. This will allow use of different JDK/Gradle versions for different
branches.
- Use of tagging on built images to identify the stable and next images.
- - Nightly scripts can pull the latest image for a tag and relaunch the
container accordingly.
- Demo images can embed the Derby database. The database can be pre-loaded
with demo data before the image is pushed to the image repository, speeding
up the process of updating a demo site to a new version.
- We will be able to learn from our demos and iterate on the OFBiz approach
to containers. We will then be in a better position to advise potential
users on container deployments. I believe that running OFBiz from a
container will reduce barriers for new users to evaluate OFBiz.

To be clear, I do not propose use of containers as an immediate need, and
do not wish discussions around containers to block any efforts around
release 21.

Some issues we would need to resolve:

- Is the use of containers viable on the demo servers?
- - Perhaps use of Docker containers is not permitted for some reason.

- We would need to figure out how we want to build container images.
- - My preference is to have the Dockerfile be part of the OFBiz sources,
that way the Dockerfile can change with the sources and become a
first-class build method.
- - I do not favour the approach of a Dockerfile external to the OFBiz
sources that then downloads and extracts a zip of the sources. My concern
is that the zip could change in a way unexpected by the Dockerfile user.
- - Having the Dockerfile alongside the sources it is building, rather than
retrieving sources from a URL, will make it easier for developers to try
out changes in their own container images, without having to amend the
Dockerfile. Any reduction in cognitive load for developers is a good thing
as they have plenty to worry about already! :)

- Where would we store built container images?
- - From past discussions on the container topic I remember a comment about
'the Apache way' is to distribute sources rather than binaries. From this I
infer that we probably do not want to stand up a publically accessible
repository to host demo container images.
- - Perhaps each demo site server can have access to a private container
image repository used only to host their own images.
- - - The build process could produce the demo container image and push it
to the relevant private repository.
- - Could the wider Apache Foundation offer any guidance from other
projects on this topic?

Thanks for reading this far! :) Comments and opinions appreciated.

Re: Using the Java Trunk API to implement 3rd Party Java Apps

[Hans Bakker]

Hi Mat,

i created a flutter mobile app with a REST interface to ofbiz which 
gives you plenty of examples how to do this.


please check :

the ofbiz plugin: https://github.com/growerp/growerp-ofbiz
the flutter app: https://github.com/growerp/growerp

the ofbiz plugin is a bit behind the moqui plugin but is fully 
functional with the flutter version last December.


Regards,

Hans

On 7/6/21 10:12 PM, matt domanowski wrote:

I am new to OFBiz but fairly familiar with ERPs in general. We are trying to 
make API calls into OFBiz using the Java classes.

For example, something simple such as searching products from a stand alone 
Java app importing the OFBiz classes is proving very difficult.
(See below example)

..
ResultSortOrder resultSortOrder=new ProductSearch.SortKeywordRelevancy();
List productSearchList=new 
ArrayList();
productSearchList.add(new ProductSearch.CategoryConstraint("*", 
true, true));

ProductSearch.searchProducts(productSearchList,resultSortOrder,delegator,visitId);
..
Does anyone have examples on how to do this.  There does not seem to be any 
examples online.  We would prefer to use the Java classes directly as they are 
documented.  The web services seem less developed and there also seems to be 
very little documentation on those.

Re: REST upgrade not find services anymore....

[Hans Bakker]

Hi Girish,

please ignore my last message, everything working fine!

Regards, Hans

On 10/7/20 7:14 AM, Hans Bakker wrote:

Yes you are right, but that is an error i introduced later

still my problem is still there.

can you please check?

Regards,

Hans

On 10/6/20 8:46 PM, Girish Vasmatkar wrote:

Hi Hans

There's an error in your service definition file *services100.xml. 
*Please check *invoke* attribute below.







Best Regards,
Girish


On Tue, Oct 6, 2020 at 6:58 PM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


    Hi Girish,

    just upgraded the rest plugin and now services are not found
    anymore

    my log:

    2020-10-06 20:18:34,185 |OFBiz-JobQueue-1 |ServiceDispatcher
    |T| Sync service [default/runServiceOnSubscriptionExpiry] 
finished in

    [42] milliseconds
    2020-10-06 20:19:10,230 |jsse-nio-8443-exec-4
    |APIAuthFilter |E| Cannot locate service by name
    (registerUserAndCompany100)
    2020-10-06 20:19:10,873 |jsse-nio-8443-exec-5
    |APIAuthFilter |E| Cannot locate service by name
    (getCompanies100)
    2020-10-06 20:19:11,181 |jsse-nio-8443-exec-6
    |UtilProperties    |I| ResourceBundle 
SecurityextUiLabels

    (en) created in 0.109s with 69 properties
    2020-10-06 20:19:11,184 |jsse-nio-8443-exec-6
    |LoginServices |I| [LoginServices.userLogin] Invalid
    User : '4344du...@example.com <mailto:4344du...@example.com>';
    User not found.
    2020-10-06 20:19:11,185 |jsse-nio-8443-exec-6
    |ServiceDispatcher |W| Service Failure [userLogin]:
    User not
    found.
    2020-10-06 20:19:11,188 |jsse-nio-8443-exec-6
    |ServiceDispatcher |T| Sync service
    [ofbiz-rest-jersey/userLogin] finished in [145] milliseconds
    2020-10-06 20:19:11,192 |jsse-nio-8443-exec-6
    |HttpBasicAuthFilter   |E| User not found.
    2020-10-06 20:19:11,262 |jsse-nio-8443-exec-7
    |APIAuthFilter |E| Cannot locate service by name
    (getAuthenticate100)

    do i perhaps miss something?

    my plugin at https://github.com/growerp/growerp-ofbiz

    regards,

    Hans

Re: REST upgrade not find services anymore....

[Hans Bakker]

Yes you are right, but that is an error i introduced later

still my problem is still there.

can you please check?

Regards,

Hans

On 10/6/20 8:46 PM, Girish Vasmatkar wrote:

Hi Hans

There's an error in your service definition file *services100.xml. 
*Please check *invoke* attribute below.







Best Regards,
Girish


On Tue, Oct 6, 2020 at 6:58 PM Hans Bakker <mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish,

just upgraded the rest plugin and now services are not found
anymore

my log:

2020-10-06 20:18:34,185 |OFBiz-JobQueue-1 |ServiceDispatcher
|T| Sync service [default/runServiceOnSubscriptionExpiry] finished in
[42] milliseconds
2020-10-06 20:19:10,230 |jsse-nio-8443-exec-4
|APIAuthFilter |E| Cannot locate service by name
(registerUserAndCompany100)
2020-10-06 20:19:10,873 |jsse-nio-8443-exec-5
|APIAuthFilter |E| Cannot locate service by name
(getCompanies100)
2020-10-06 20:19:11,181 |jsse-nio-8443-exec-6
|UtilProperties    |I| ResourceBundle SecurityextUiLabels
(en) created in 0.109s with 69 properties
2020-10-06 20:19:11,184 |jsse-nio-8443-exec-6
|LoginServices |I| [LoginServices.userLogin] Invalid
User : '4344du...@example.com <mailto:4344du...@example.com>';
User not found.
2020-10-06 20:19:11,185 |jsse-nio-8443-exec-6
|ServiceDispatcher |W| Service Failure [userLogin]:
User not
found.
2020-10-06 20:19:11,188 |jsse-nio-8443-exec-6
|ServiceDispatcher |T| Sync service
[ofbiz-rest-jersey/userLogin] finished in [145] milliseconds
2020-10-06 20:19:11,192 |jsse-nio-8443-exec-6
|HttpBasicAuthFilter   |E| User not found.
2020-10-06 20:19:11,262 |jsse-nio-8443-exec-7
|APIAuthFilter |E| Cannot locate service by name
(getAuthenticate100)

do i perhaps miss something?

my plugin at https://github.com/growerp/growerp-ofbiz

regards,

Hans

REST upgrade not find services anymore....

[Hans Bakker]

Hi Girish,

just upgraded the rest plugin and now services are not found anymore

my log:

2020-10-06 20:18:34,185 |OFBiz-JobQueue-1 |ServiceDispatcher 
|T| Sync service [default/runServiceOnSubscriptionExpiry] finished in 
[42] milliseconds
2020-10-06 20:19:10,230 |jsse-nio-8443-exec-4 
|APIAuthFilter |E| Cannot locate service by name 
(registerUserAndCompany100)
2020-10-06 20:19:10,873 |jsse-nio-8443-exec-5 
|APIAuthFilter |E| Cannot locate service by name 
(getCompanies100)
2020-10-06 20:19:11,181 |jsse-nio-8443-exec-6 
|UtilProperties    |I| ResourceBundle SecurityextUiLabels 
(en) created in 0.109s with 69 properties
2020-10-06 20:19:11,184 |jsse-nio-8443-exec-6 
|LoginServices |I| [LoginServices.userLogin] Invalid 
User : '4344du...@example.com'; User not found.
2020-10-06 20:19:11,185 |jsse-nio-8443-exec-6 
|ServiceDispatcher |W| Service Failure [userLogin]: User not 
found.
2020-10-06 20:19:11,188 |jsse-nio-8443-exec-6 
|ServiceDispatcher |T| Sync service 
[ofbiz-rest-jersey/userLogin] finished in [145] milliseconds
2020-10-06 20:19:11,192 |jsse-nio-8443-exec-6 
|HttpBasicAuthFilter   |E| User not found.
2020-10-06 20:19:11,262 |jsse-nio-8443-exec-7 
|APIAuthFilter |E| Cannot locate service by name 
(getAuthenticate100)


do i perhaps miss something?

my plugin at https://github.com/growerp/growerp-ofbiz

regards,

Hans

ofbiz REST error messages, was: REST, how about 'Login' map

[Hans Bakker]

Hi Girish,

again thanks for your help.

I updated my version here, and show the flutter Dio error messages 
better as explained at:

https://pub.dev/packages/dio#handling-errors

and now these error messages are received properly,

Thanks again,

Regards,
Hans Bakker
antwebsystems.com

On 10/2/20 8:25 AM, Girish Vasmatkar wrote:

Hi Hans, if service is returning an error, it should get converted into a
422.

I took your getCompanies service example from your plugin and modified the
service as below

def getCompanies() {
 Map result = success()
 logInfo("service starting with ${parameters.input}")
 result.companies = parameters.input
 return error("this is the error message")
}

And accessed it like

https://localhost:8443/rest
/services/getCompanies?inParams=%7B%0A%20%20%22input%22%3A%20%22string%22%0A%7D

And it returned below error. I had cleaned up some code and added
additional handling yesterday, so might be possible you don't have those
changes. Pl sync once and give it a try again.

{

 "statusCode": 422,

 "statusDescription": *"Unprocessable Entity"*,

 "errorType": *"ServiceError"*,

 "errorMessage": *"getCompanies returned error. The request contained
invalid information and could not be processed."*,

 "errorDescription": *"this is the error message"*

}

Let me know if it still does not work for you and additionally provide your
service def for me to take a more closer look.

Best,
Girish








On Fri, Oct 2, 2020 at 6:07 AM Hans Bakker 
wrote:


Hi Girish,

thanks for the explanation, however if i create a last statement in a
groovy service:
return error("this is the error message")

then i get an error 500 returned, however not showing the error message of
the service.

Regards,

Hans
On 10/2/20 12:14 AM, Girish Vasmatkar wrote:

Thanks Hans.

The error codes are broadly categorized in three types based on what ofbiz
is generating during service call -

1. 400 Bad Request = if ServiceValidationException is thrown. This
indicates client error and client must make amends to the request. Example,
service's required IN parameter were missing in the JSON body.
2. 422 Unprocessable Entity = if GenericEntityException is thrown. This
also indicates client error but also indicates that the request was
syntactically correct but semantically wrong. Example - while creating a
product, *productTypeId* was provided in the request, but it didn't
exist. This indicates client error again, but the json was not malformed.
3. 404 NotFoundException = if service being invoked does not exist, or is
not declared export=true, or action attribute is not defined.
4. 500 Internal Server Error = Any other category of exception that might
be thrown from the service.

In all three cases, appropriate error messages from the original exception
should be included in the error response.

Best,
Girish






On Thu, Oct 1, 2020 at 1:43 PM Hans Bakker 
wrote:


Hi Girish,

yes userLogin is working fine now,

further i see you are working on the error messages?
would be nice to get the ofbiz error message together with the error code
500?

keep up the good work, it is getting better and better!

Regards,

Hans
On 10/1/20 10:49 AM, Girish Vasmatkar wrote:

Hi Hans,

This is now implemented/fixed with commit8545cfe
<https://github.com/apache/ofbiz-plugins/commit/8545cfebb2193bead7d06bd8e8cdb5108d24b209>
  .

Best,
Girish
HotWax Systems


On Tue, Sep 29, 2020 at 5:26 PM Hans Bakker 
wrote:


Hi Girish, thanks for your prompt reply,

the login map need to be filled when the related token is available,
what is currently not the case.

Not sure if this is directly related to the Auth=false parameter, you
know that better,

Regards, Hans
On 9/29/20 4:20 PM, Girish Vasmatkar wrote:

Hi Hans

Since you specifically mentioned about groovy service, I would think it
is true for other services as well.

It would possibly be happening, if the service itself is declared with
auth=false, so no token check is happening and hence userLogin is not
retrieved from the token.
Can you confirm if this is the case? The userLogin is added to the
service call before delegating the service call to dispatcher after jwt has
been verified. But in case of auth=false, services, auth is bypassed and
hence userLogin is not set.

I guess the key here is to bypass token validation if, and only if, the
Authorization header is absent, otherwise perform validation. I had a
discussion about this with Jacopo as well and here is what can be done
(applicable for */services *endpoint ) -

If auth=false and *Authorization* header is *present*, validate token
and return error if invalid. Else set userLogin in context and delegate the
call to dispatcher.
If auth=false and *Authorization* header is *absent, *just call the
service. The service will be executed *without* userLogin in context.

I will try to work o

Re: REST, how about 'Login' map

[Hans Bakker]

Hi Girish,

thanks for the explanation, however if i create a last statement in a 
groovy service:

return error("this is the error message")

then i get an error 500 returned, however not showing the error message 
of the service.


Regards,

Hans

On 10/2/20 12:14 AM, Girish Vasmatkar wrote:

Thanks Hans.

The error codes are broadly categorized in three types based on what 
ofbiz is generating during service call -


1. 400 Bad Request = if ServiceValidationException is thrown. This 
indicates client error and client must make amends to the request. 
Example, service's required IN parameter were missing in the JSON body.
2. 422 Unprocessable Entity = if GenericEntityException is thrown. 
This also indicates client error but also indicates that the request 
was syntactically correct but semantically wrong. Example - while 
creating a product, *productTypeId* was provided in the request, but 
it didn't exist. This indicates client error again, but the json was 
not malformed.
3. 404 NotFoundException = if service being invoked does not exist, or 
is not declared export=true, or action attribute is not defined.
4. 500 Internal Server Error = Any other category of exception that 
might be thrown from the service.


In all three cases, appropriate error messages from the original 
exception should be included in the error response.


Best,
Girish






On Thu, Oct 1, 2020 at 1:43 PM Hans Bakker <mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish,

yes userLogin is working fine now,

further i see you are working on the error messages?
would be nice to get the ofbiz error message together with the
error code 500?

keep up the good work, it is getting better and better!

Regards,

Hans

On 10/1/20 10:49 AM, Girish Vasmatkar wrote:

Hi Hans,

This is now implemented/fixed with commit8545cfe

<https://github.com/apache/ofbiz-plugins/commit/8545cfebb2193bead7d06bd8e8cdb5108d24b209>
 .


Best,
Girish
HotWax Systems


On Tue, Sep 29, 2020 at 5:26 PM Hans Bakker
mailto:h.bak...@antwebsystems.com>>
wrote:

Hi Girish, thanks for your prompt reply,

the login map need to be filled when the related token is
available, what is currently not the case.

Not sure if this is directly related to the Auth=false
parameter, you know that better,

Regards, Hans

On 9/29/20 4:20 PM, Girish Vasmatkar wrote:

Hi Hans

Since you specifically mentioned about groovy service, I
would think it is true for other services as well.

It would possibly be happening, if the service itself is
declared with auth=false, so no token check is happening and
hence userLogin is not retrieved from the token.
Can you confirm if this is the case? The userLogin is added
to the service call before delegating the service call to
dispatcher after jwt has been verified. But in case of
auth=false, services, auth is bypassed and hence userLogin
is not set.

I guess the key here is to bypass token validation if, and
only if, the Authorization header is absent, otherwise
perform validation. I had a discussion about this with
Jacopo as well and here is what can be done (applicable for
*/services *endpoint ) -

If auth=false and *Authorization* header is */present/*,
validate token and return error if invalid. Else set
userLogin in context and delegate the call to dispatcher.
If auth=false and *Authorization* header is *absent, *just
call the service. The service will be executed */without/*
userLogin in context.

I will try to work on this change in the next couple days.

Best,
Girish
HotWax Systems











Best,
Girish
HotWax Systems








On Tue, Sep 29, 2020 at 6:20 AM Hans Bakker
mailto:h.bak...@antwebsystems.com>> wrote:

Hi Girish,

thanks for your last email, that is working now too

howeveranother question,

If i call a service using the token i obtained earlier,
i see that the
userLogin map in the groovy service I called, is null

can you set the login map to the userLogin of the token
that was used so
we know who the user is?

Thanks, Hans

Re: REST, how about 'Login' map

[Hans Bakker]

Hi Girish,

yes userLogin is working fine now,

further i see you are working on the error messages?
would be nice to get the ofbiz error message together with the error 
code 500?


keep up the good work, it is getting better and better!

Regards,

Hans

On 10/1/20 10:49 AM, Girish Vasmatkar wrote:

Hi Hans,

This is now implemented/fixed with commit8545cfe 
<https://github.com/apache/ofbiz-plugins/commit/8545cfebb2193bead7d06bd8e8cdb5108d24b209> . 



Best,
Girish
HotWax Systems


On Tue, Sep 29, 2020 at 5:26 PM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish, thanks for your prompt reply,

the login map need to be filled when the related token is
available, what is currently not the case.

Not sure if this is directly related to the Auth=false parameter,
you know that better,

Regards, Hans

On 9/29/20 4:20 PM, Girish Vasmatkar wrote:

Hi Hans

Since you specifically mentioned about groovy service, I would
think it is true for other services as well.

It would possibly be happening, if the service itself is declared
with auth=false, so no token check is happening and hence
userLogin is not retrieved from the token.
Can you confirm if this is the case? The userLogin is added to
the service call before delegating the service call to dispatcher
after jwt has been verified. But in case of auth=false, services,
auth is bypassed and hence userLogin is not set.

I guess the key here is to bypass token validation if, and only
if, the Authorization header is absent, otherwise perform
validation. I had a discussion about this with Jacopo as well and
here is what can be done (applicable for */services *endpoint ) -

If auth=false and *Authorization* header is */present/*, validate
token and return error if invalid. Else set userLogin in context
and delegate the call to dispatcher.
If auth=false and *Authorization* header is *absent, *just call
the service. The service will be executed */without/* userLogin
in context.

I will try to work on this change in the next couple days.

Best,
Girish
HotWax Systems











Best,
Girish
HotWax Systems








On Tue, Sep 29, 2020 at 6:20 AM Hans Bakker
mailto:h.bak...@antwebsystems.com>>
wrote:

Hi Girish,

thanks for your last email, that is working now too

howeveranother question,

If i call a service using the token i obtained earlier, i see
that the
userLogin map in the groovy service I called, is null

can you set the login map to the userLogin of the token that
was used so
we know who the user is?

Thanks, Hans

Re: REST, how about 'Login' map

[Hans Bakker]

Hi Girish, thanks for your prompt reply,

the login map need to be filled when the related token is available, 
what is currently not the case.


Not sure if this is directly related to the Auth=false parameter, you 
know that better,


Regards, Hans

On 9/29/20 4:20 PM, Girish Vasmatkar wrote:

Hi Hans

Since you specifically mentioned about groovy service, I would think 
it is true for other services as well.


It would possibly be happening, if the service itself is declared with 
auth=false, so no token check is happening and hence userLogin is not 
retrieved from the token.
Can you confirm if this is the case? The userLogin is added to the 
service call before delegating the service call to dispatcher after 
jwt has been verified. But in case of auth=false, services, auth is 
bypassed and hence userLogin is not set.


I guess the key here is to bypass token validation if, and only if, 
the Authorization header is absent, otherwise perform validation. I 
had a discussion about this with Jacopo as well and here is what can 
be done (applicable for */services *endpoint ) -


If auth=false and *Authorization* header is */present/*, validate 
token and return error if invalid. Else set userLogin in context and 
delegate the call to dispatcher.
If auth=false and *Authorization* header is *absent, *just call the 
service. The service will be executed */without/* userLogin in context.


I will try to work on this change in the next couple days.

Best,
Girish
HotWax Systems











Best,
Girish
HotWax Systems








On Tue, Sep 29, 2020 at 6:20 AM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish,

thanks for your last email, that is working now too

howeveranother question,

If i call a service using the token i obtained earlier, i see that
the
userLogin map in the groovy service I called, is null

can you set the login map to the userLogin of the token that was
used so
we know who the user is?

Thanks, Hans

REST, how about 'Login' map

[Hans Bakker]

Hi Girish,

thanks for your last email, that is working now too

howeveranother question,

If i call a service using the token i obtained earlier, i see that the 
userLogin map in the groovy service I called, is null


can you set the login map to the userLogin of the token that was used so 
we know who the user is?


Thanks, Hans

REST input is a map?

[Hans Bakker]

Hi Girish,

did some more tests and it works well with strings as in- and output,

how about Maps and Lists?

i tried the following input: {"input":{"test":"just testing"}}

and the service definition: 

then the ofbiz log below

can you have a look?

Regards,

Hans

2020-09-27 18:56:26,801 |jsse-nio-8443-exec-6 
|ObjectType    |W| Exception thrown while converting type:
org.apache.ofbiz.base.conversion.ConversionException: Could not convert 
just testing to Map:
    at 
org.apache.ofbiz.base.conversion.CollectionConverters$StringToMap.convert(CollectionConverters.java:172) 
~[main/:?]
    at 
org.apache.ofbiz.base.conversion.CollectionConverters$StringToMap.convert(CollectionConverters.java:164) 
~[main/:?]
    at 
org.apache.ofbiz.base.util.ObjectType.simpleTypeOrObjectConvert(ObjectType.java:350) 
~[main/:?]
    at 
org.apache.ofbiz.service.ModelService.makeValid(ModelService.java:1589) 
~[main/:?]
    at 
org.apache.ofbiz.service.ModelService.makeValid(ModelService.java:1516) 
~[main/:?]
    at 
org.apache.ofbiz.service.ModelService.makeValid(ModelService.java:1503) 
~[main/:?]
    at 
org.apache.ofbiz.service.DispatchContext.makeValidContext(DispatchContext.java:190) 
~[main/:?]
    at 
org.apache.ofbiz.service.DispatchContext.makeValidContext(DispatchContext.java:162) 
~[main/:?]
    at 
org.apache.ofbiz.ws.rs.ServiceRequestProcessor.process(ServiceRequestProcessor.java:64) 
~[main/:?]
    at 
org.apache.ofbiz.ws.rs.resources.OFBizServiceResource.doGet(OFBizServiceResource.java:120) 
~[main/:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[?:1.8.0_265]
    at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
~[?:1.8.0_265]
    at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 
~[?:1.8.0_265]

    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_265]
    at 
org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory.lambda$static$0(ResourceMethodInvocationHandlerFactory.java:52) 
~[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:124) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:167) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$ResponseOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:176) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:79) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:469) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:391) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:80) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:253) 
[jersey-server-2.31.jar:?]
    at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248) 
[jersey-common-2.31.jar:?]
    at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244) 
[jersey-common-2.31.jar:?]
    at org.glassfish.jersey.internal.Errors.process(Errors.java:292) 
[jersey-common-2.31.jar:?]
    at org.glassfish.jersey.internal.Errors.process(Errors.java:274) 
[jersey-common-2.31.jar:?]
    at org.glassfish.jersey.internal.Errors.process(Errors.java:244) 
[jersey-common-2.31.jar:?]
    at 
org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:265) 
[jersey-common-2.31.jar:?]
    at 
org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:232) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:680) 
[jersey-server-2.31.jar:?]
    at 
org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394) 
[jersey-container-servlet-core-2.31.jar:?]
    at 
org.glassfish.jersey.servlet.ServletContainer.serviceImpl(ServletContainer.java:386) 
[jersey-container-servlet-core-2.31.jar:?]
    at 
org.glassfish.jersey.servlet.ServletContainer.doFilter(ServletContainer.java:561) 
[jersey-container-servlet-core-2.31.jar:?]
    at 
org.glassfish.jersey.servlet.ServletContainer.doFilter(ServletContainer.java:502) 
[jersey-container-servlet-core-2.31.jar:?]
    at 
org.glassfish.jersey.servlet.ServletContainer.doFilter(ServletContainer.java:439) 
[jersey-container-servlet-core-2.31.jar:?]
    at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) 
[tomcat-catalina-9.0.37.jar:9.0.37]
    at 

Re: public rest API

[Hans Bakker]

Hi Girish,

i did a quit check using flutter test this morning and it looks like it 
is working fine.


for people interested in using flutter(http://flutter.dev) with ofbiz:
    the test: 
https://github.com/growerp/growerp/blob/master/test/services/ofbiz_testManual.dart
    if you want to run you need to install the growerp plugin into 
ofbiz: https://github.com/growerp/growerp-ofbiz


Thank you Girish for this enhancement and keep up the good work!

Regards,

Hans Bakker
http://www.antwebsystems.com

On 9/26/20 4:05 PM, Girish Vasmatkar wrote:

Hello Hans

With the latest commi1361c3c 
<https://github.com/apache/ofbiz-plugins/commit/1361c3cdaf7d6756cc9abdc6c37450ef3d46f921> on 
trunk, the system now honours the "auth" attribute defined on service 
and accordingly bypasses authorization for such services.


Best,
Girish


On Thu, Sep 10, 2020 at 5:46 PM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


Thank you Girish,

look forward to your updates of this excellent and much needed
addition to OFBiz.

Regars

Hans
www.antwebsystems.com <http://www.antwebsystems.com>

On 9/10/20 3:27 PM, Girish Vasmatkar wrote:

Thanks Hans, I will plan to include this change for the
exportable services as well.

There is also OFBIZ-11995, where more RESTFul resources can be
declared (development is undergoing) and bound to services where
I had planned to include declarative authentication.
*
*
Best Regards,
Girish Vasmatkar
HotWax Systems




On Thu, Sep 10, 2020 at 12:08 PM Hans Bakker
mailto:h.bak...@antwebsystems.com>>
wrote:

Hi Girish,

how about ecommerce? you want to show the products without
logging in,
actually all information on the ecommerce frontend?

so yes, really required.

regards,

Hans


On 9/10/20 12:37 PM, Girish Vasmatkar wrote:
> Every REST endpoint, as it is implemented now, is secured
by default. I had
> not thought of a scenario where internal OFBiz services
will need to be
> invoked without authentication (externally)
>
> Yes, the services themselves can be specified to NOT
require auth but I had
> always thought that was applicable within internal
execution. I may be
> wrong here, so please correct me.
>
> auth and login-required are not taken into account yet, but
can certainly
> be, if some exportable services should be exposed as public
APIs.
>
> Best Regards,
> Girish Vasmatkar
> HotWax Systems
    >
>
>
> On Thu, Sep 10, 2020 at 5:55 AM Hans Bakker
mailto:h.bak...@antwebsystems.com>>
> wrote:
>
>> Hi, Girish,
>>
>> thanks again for your last reply it defenity helped,
however i have
>> another question.
>>
>> I need to access certain services publicly without a token.
>>
>> I have put auth="false" on the service definition and
>> login-required="false" on the simple-method implementation
>>
>> still i get a 401 response.
>>
>> any suggestions?
>>
>> Regards,
>>
>> Hans
>>
>>

Re: public rest API

[Hans Bakker]

Thank you Girish,

look forward to your updates of this excellent and much needed addition 
to OFBiz.


Regars

Hans
www.antwebsystems.com

On 9/10/20 3:27 PM, Girish Vasmatkar wrote:
Thanks Hans, I will plan to include this change for the exportable 
services as well.


There is also OFBIZ-11995, where more RESTFul resources can be 
declared (development is undergoing) and bound to services where I had 
planned to include declarative authentication.

*
*
Best Regards,
Girish Vasmatkar
HotWax Systems




On Thu, Sep 10, 2020 at 12:08 PM Hans Bakker 
mailto:h.bak...@antwebsystems.com>> wrote:


Hi Girish,

how about ecommerce? you want to show the products without logging
in,
actually all information on the ecommerce frontend?

so yes, really required.

regards,

Hans


On 9/10/20 12:37 PM, Girish Vasmatkar wrote:
> Every REST endpoint, as it is implemented now, is secured by
default. I had
> not thought of a scenario where internal OFBiz services will
need to be
> invoked without authentication (externally)
>
> Yes, the services themselves can be specified to NOT require
auth but I had
> always thought that was applicable within internal execution. I
may be
> wrong here, so please correct me.
>
> auth and login-required are not taken into account yet, but can
certainly
> be, if some exportable services should be exposed as public APIs.
>
> Best Regards,
> Girish Vasmatkar
> HotWax Systems
>
    >
    >
> On Thu, Sep 10, 2020 at 5:55 AM Hans Bakker
mailto:h.bak...@antwebsystems.com>>
> wrote:
>
>> Hi, Girish,
>>
>> thanks again for your last reply it defenity helped, however i have
>> another question.
>>
>> I need to access certain services publicly without a token.
>>
>> I have put auth="false" on the service definition and
>> login-required="false" on the simple-method implementation
>>
>> still i get a 401 response.
>>
>> any suggestions?
>>
>> Regards,
>>
>> Hans
>>
>>

Re: public rest API

[Hans Bakker]

Hi Girish,

how about ecommerce? you want to show the products without logging in, 
actually all information on the ecommerce frontend?


so yes, really required.

regards,

Hans


On 9/10/20 12:37 PM, Girish Vasmatkar wrote:

Every REST endpoint, as it is implemented now, is secured by default. I had
not thought of a scenario where internal OFBiz services will need to be
invoked without authentication (externally)

Yes, the services themselves can be specified to NOT require auth but I had
always thought that was applicable within internal execution. I may be
wrong here, so please correct me.

auth and login-required are not taken into account yet, but can certainly
be, if some exportable services should be exposed as public APIs.

Best Regards,
Girish Vasmatkar
HotWax Systems



On Thu, Sep 10, 2020 at 5:55 AM Hans Bakker 
wrote:


Hi, Girish,

thanks again for your last reply it defenity helped, however i have
another question.

I need to access certain services publicly without a token.

I have put auth="false" on the service definition and
login-required="false" on the simple-method implementation

still i get a 401 response.

any suggestions?

Regards,

Hans

REST get no parameters

[Hans Bakker]

Sorry Girish me again,

if i create a simple method service with action GET and no parameters , 
i get a 500 http error,


like:

curl -X  GET https://localhost:8443/rest/services/findProductById -H 
"Accept: application/json" -H "Authorization: Bearer $token" --insecure

{
  "statusCode" : 500,
  "statusDescription" : "Internal Server Error"
}

regards,

Hans

public rest API

[Hans Bakker]

Hi, Girish,

thanks again for your last reply it defenity helped, however i have 
another question.


I need to access certain services publicly without a token.

I have put auth="false" on the service definition and 
login-required="false" on the simple-method implementation


still i get a 401 response.

any suggestions?

Regards,

Hans

Re: getting started with ofbiz-rest-impl

[Hans Bakker]

Hi Girish,

thanks for your last help, that worked fine.

I am struggling with simple method services.

i went to applications/party/servicedef/services.xml

and enabled the service ensureNaPartyRole with export="true" and 
action="post"


then issued the command:

curl -G -X  POST https://localhost:8443/rest/services/ensureNaPartyRole 
--data-urlencode 'inParams={"partyId":"admin"}' -H "Accept: 
application/json" -H "Authorization: Bearer $token" --insecure


and tells me:
{
  "statusCode" : 500,
  "statusDescription" : "Internal Server Error",
  "errorMessage" : "Required Field Missing : Party Id"
}

any idea?

Thanks in advance.

Hans


just a quick question , does it also work with minilang?


 i get
{
  "statusCode" : 500,
  "statusDescription" : "Internal Server Error"
}:
Regards.

On 9/5/20 8:26 PM, Girish Vasmatkar wrote:

Hello Hans

Thanks for giving it (REST Impl) a try and providing valuable feedback.The
token's signature part and the payload part (that includes claims) does
indeed change, while the header part is not expected to change.
The token is revoked after it is expired (default is 1800 seconds basedon
security.properties).

Looking forward to hearing more from you and please let us know of any
issue you encounter.

Best Regards,
Girish










On Sat, Sep 5, 2020 at 6:51 AM Hans Bakker 
wrote:


Good day!

Good to see we finally have a REST interface in OFBiz, thank you
girishvasmatkar for this implementation!

I will try to use it for the Growerp.org open source project, a
flutter frontend for currently Moqui.org but also will try to use OFBiz,
yes with this REST interface.

My experience after away from ofbiz for a couple of years and just for
other users getting started email.

OFBIZ install:
==
i looked how to install ofbiz in the readme.adoc fle , this tells me to
run ./gradle/init-gradle-wrapper for linux
did not worked on my linux system, however ./gradlew init-gradle-wrapper
worked but got stuck at the end...
killed it and then ran ./gradlew cleanAll loadAll and all was fine.

Did not know how to install a plugin, ( a lot changed the last couple of
years that is good!) so i added it to the application folder and updated
the component-load.xml file. that was still the same.

REST plugin:
==
then I searched for how to get an token after authorization.
These curl commands worked for me: could be added to the READ me file?

curl -X POST https://localhost:8443/rest/auth/token -H "Accept:
application/json" -u admin:ofbiz --insecure

however when i requested it the second time, the token did not change?
shouldn't it? Now i cannot revoke a token?

then tried the services list:
curl -X GET https://localhost:8443/rest/services -H "Accept:
application/json" -H "Authorization: Bearer
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzUxMiJ9.eyJpc3MiOiJBcGFjaGVPRkJpeiIsImlhdCI6MTU0NzczOTM0OCwiZXhwIjoxNjc5Mjc1MzQ4LCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJqcm9ja2V0QGV4YW1wbGUuY29tIiwiR2l2ZW5OYW1lIjoiSm9obm55IiwiU3VybmFtZSI6IlJvY2tldCIsIkVtYWlsIjoianJvY2tldEBleGFtcGxlLmNvbSIsInVzZXJMb2dpbklkIjoiYWRtaW4iLCJSb2xlIjpbIk1hbmFnZXIiLCJQcm9qZWN0IEFkbWluaXN0cmF0b3IiXX0.fwafgrgpodBJcXxNTQdZknKeWKb3sDOsQrcR2vcRw97FznD6mkE79p10Tu7cqpUx7LiXuROUAnXEgqDice-BSg"

--insecure

also working fine!

if I have more comments or remarks, i will let you know

Regards,

Hans Bakker https://www.AntWebsystems.com
we specialize in flutter.dev growerp.org moqui.org and ofbiz.apache.org

Re: getting started with ofbiz-rest-impl

[Hans Bakker]

OK, made some progress, have it now working from the flutter dart 
environment however..


this curl works even from flutter dart,
curl -X  GET 
https://localhost:8443/rest/services/findProductByI?inParams=%7B%22idToFind%22:%22GZ-1001%22%7D 
-H "Accept: application/json" -H "Authorization: Bearer $token" --insecure

however i do not want to url encode myself, so shouldn't this also work:

curl -X  GET https://localhost:8443/rest/services/findProductById 
--data-urlencode "{'inparams': {'idToFind':'GZ-1001'}}" -H "Accept: 
application/json" -H "Authorization: Bearer $token" --insecure


I tried it also without the inner quotes but could not get his to work.

i get:
{
  "statusCode" : 500,
  "statusDescription" : "Internal Server Error"
}

can you help?

regards,

Hans

On 9/5/20 8:26 PM, Girish Vasmatkar wrote:

Hello Hans

Thanks for giving it (REST Impl) a try and providing valuable feedback. The
token's signature part and the payload part (that includes claims) does
indeed change, while the header part is not expected to change.
The token is revoked after it is expired (default is 1800 seconds based on
security.properties).

Looking forward to hearing more from you and please let us know of any
issue you encounter.

Best Regards,
Girish










On Sat, Sep 5, 2020 at 6:51 AM Hans Bakker 
wrote:


Good day!

Good to see we finally have a REST interface in OFBiz, thank you
girishvasmatkar for this implementation!

   I will try to use it for the Growerp.org open source project, a
flutter frontend for currently Moqui.org but also will try to use OFBiz,
yes with this REST interface.

My experience after away from ofbiz for a couple of years and just for
other users getting started email.

OFBIZ install:
==
i looked how to install ofbiz in the readme.adoc fle , this tells me to
run ./gradle/init-gradle-wrapper for linux
did not worked on my linux system, however ./gradlew init-gradle-wrapper
worked but got stuck at the end...
killed it and then ran ./gradlew cleanAll loadAll and all was fine.

Did not know how to install a plugin, ( a lot changed the last couple of
years that is good!) so i added it to the application folder and updated
the component-load.xml file. that was still the same.

REST plugin:
==
then I searched for how to get an token after authorization.
These curl commands worked for me: could be added to the READ me file?

curl -X POST https://localhost:8443/rest/auth/token -H "Accept:
application/json" -u admin:ofbiz --insecure

however when i requested it the second time, the token did not change?
shouldn't it? Now i cannot revoke a token?

then tried the services list:
curl -X GET https://localhost:8443/rest/services -H "Accept:
application/json" -H "Authorization: Bearer
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzUxMiJ9.eyJpc3MiOiJBcGFjaGVPRkJpeiIsImlhdCI6MTU0NzczOTM0OCwiZXhwIjoxNjc5Mjc1MzQ4LCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJqcm9ja2V0QGV4YW1wbGUuY29tIiwiR2l2ZW5OYW1lIjoiSm9obm55IiwiU3VybmFtZSI6IlJvY2tldCIsIkVtYWlsIjoianJvY2tldEBleGFtcGxlLmNvbSIsInVzZXJMb2dpbklkIjoiYWRtaW4iLCJSb2xlIjpbIk1hbmFnZXIiLCJQcm9qZWN0IEFkbWluaXN0cmF0b3IiXX0.fwafgrgpodBJcXxNTQdZknKeWKb3sDOsQrcR2vcRw97FznD6mkE79p10Tu7cqpUx7LiXuROUAnXEgqDice-BSg"

--insecure

also working fine!

if I have more comments or remarks, i will let you know

Regards,

Hans Bakker https://www.AntWebsystems.com
we specialize in flutter.dev growerp.org moqui.org and ofbiz.apache.org

Re: getting started with ofbiz-rest-impl

[Hans Bakker]

just a quick question , does it also work with minilang?

 i get
{
  "statusCode" : 500,
  "statusDescription" : "Internal Server Error"
}:
Regards.

On 9/5/20 8:26 PM, Girish Vasmatkar wrote:

Hello Hans

Thanks for giving it (REST Impl) a try and providing valuable feedback. The
token's signature part and the payload part (that includes claims) does
indeed change, while the header part is not expected to change.
The token is revoked after it is expired (default is 1800 seconds based on
security.properties).

Looking forward to hearing more from you and please let us know of any
issue you encounter.

Best Regards,
Girish










On Sat, Sep 5, 2020 at 6:51 AM Hans Bakker 
wrote:


Good day!

Good to see we finally have a REST interface in OFBiz, thank you
girishvasmatkar for this implementation!

   I will try to use it for the Growerp.org open source project, a
flutter frontend for currently Moqui.org but also will try to use OFBiz,
yes with this REST interface.

My experience after away from ofbiz for a couple of years and just for
other users getting started email.

OFBIZ install:
==
i looked how to install ofbiz in the readme.adoc fle , this tells me to
run ./gradle/init-gradle-wrapper for linux
did not worked on my linux system, however ./gradlew init-gradle-wrapper
worked but got stuck at the end...
killed it and then ran ./gradlew cleanAll loadAll and all was fine.

Did not know how to install a plugin, ( a lot changed the last couple of
years that is good!) so i added it to the application folder and updated
the component-load.xml file. that was still the same.

REST plugin:
==
then I searched for how to get an token after authorization.
These curl commands worked for me: could be added to the READ me file?

curl -X POST https://localhost:8443/rest/auth/token -H "Accept:
application/json" -u admin:ofbiz --insecure

however when i requested it the second time, the token did not change?
shouldn't it? Now i cannot revoke a token?

then tried the services list:
curl -X GET https://localhost:8443/rest/services -H "Accept:
application/json" -H "Authorization: Bearer
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzUxMiJ9.eyJpc3MiOiJBcGFjaGVPRkJpeiIsImlhdCI6MTU0NzczOTM0OCwiZXhwIjoxNjc5Mjc1MzQ4LCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJqcm9ja2V0QGV4YW1wbGUuY29tIiwiR2l2ZW5OYW1lIjoiSm9obm55IiwiU3VybmFtZSI6IlJvY2tldCIsIkVtYWlsIjoianJvY2tldEBleGFtcGxlLmNvbSIsInVzZXJMb2dpbklkIjoiYWRtaW4iLCJSb2xlIjpbIk1hbmFnZXIiLCJQcm9qZWN0IEFkbWluaXN0cmF0b3IiXX0.fwafgrgpodBJcXxNTQdZknKeWKb3sDOsQrcR2vcRw97FznD6mkE79p10Tu7cqpUx7LiXuROUAnXEgqDice-BSg"

--insecure

also working fine!

if I have more comments or remarks, i will let you know

Regards,

Hans Bakker https://www.AntWebsystems.com
we specialize in flutter.dev growerp.org moqui.org and ofbiz.apache.org

getting started with ofbiz-rest-impl

[Hans Bakker]

Good day!

Good to see we finally have a REST interface in OFBiz, thank you 
girishvasmatkar for this implementation!


 I will try to use it for the Growerp.org open source project, a 
flutter frontend for currently Moqui.org but also will try to use OFBiz, 
yes with this REST interface.


My experience after away from ofbiz for a couple of years and just for 
other users getting started email.


OFBIZ install:
==
i looked how to install ofbiz in the readme.adoc fle , this tells me to 
run ./gradle/init-gradle-wrapper for linux
did not worked on my linux system, however ./gradlew init-gradle-wrapper 
worked but got stuck at the end...

killed it and then ran ./gradlew cleanAll loadAll and all was fine.

Did not know how to install a plugin, ( a lot changed the last couple of 
years that is good!) so i added it to the application folder and updated 
the component-load.xml file. that was still the same.


REST plugin:
==
then I searched for how to get an token after authorization.
These curl commands worked for me: could be added to the READ me file?

curl -X POST https://localhost:8443/rest/auth/token -H "Accept: 
application/json" -u admin:ofbiz --insecure


however when i requested it the second time, the token did not change? 
shouldn't it? Now i cannot revoke a token?


then tried the services list:
curl -X GET https://localhost:8443/rest/services -H "Accept: 
application/json" -H "Authorization: Bearer 
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzUxMiJ9.eyJpc3MiOiJBcGFjaGVPRkJpeiIsImlhdCI6MTU0NzczOTM0OCwiZXhwIjoxNjc5Mjc1MzQ4LCJhdWQiOiJ3d3cuZXhhbXBsZS5jb20iLCJzdWIiOiJqcm9ja2V0QGV4YW1wbGUuY29tIiwiR2l2ZW5OYW1lIjoiSm9obm55IiwiU3VybmFtZSI6IlJvY2tldCIsIkVtYWlsIjoianJvY2tldEBleGFtcGxlLmNvbSIsInVzZXJMb2dpbklkIjoiYWRtaW4iLCJSb2xlIjpbIk1hbmFnZXIiLCJQcm9qZWN0IEFkbWluaXN0cmF0b3IiXX0.fwafgrgpodBJcXxNTQdZknKeWKb3sDOsQrcR2vcRw97FznD6mkE79p10Tu7cqpUx7LiXuROUAnXEgqDice-BSg" 
--insecure


also working fine!

if I have more comments or remarks, i will let you know

Regards,

Hans Bakker https://www.AntWebsystems.com
we specialize in flutter.dev growerp.org moqui.org and ofbiz.apache.org

Re: future of OFBiz: REST is essential.

[Hans Bakker]

Hi Michael,

i checked https://issues.apache.org/jira/browse/OFBIZ-4274 which started 
2011,  lets hope you are right?


Regards,
Hans
antwebsystems.com

On 01/29/2019 03:47 PM, Michael Brohl wrote:

Hi Hans,

several people in the community are already working on REST 
implementations, I'm sure we will have one soon.


Thanks,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 29.01.19 um 06:12 schrieb Hans Bakker:

Good morning, fellow developers.

It is now almost 15 years ago i started with OFBiz. I always followed 
new technology developments and used them when they became usable in 
a production environment. That is why i joined OFBiz early. I also 
proposed years ago to go from svn to git that now finally is approved 
for OFBiz. I also proposed to replace the OFBiz framework with 
Moqui.org, yes I know a much bigger change but believe me, that will 
also happen one time for you.


We now support Moqui for about a year and the main reason we switched 
over is the excellent REST interface Moqui has. This allows you to 
have a user interface fully independent from Moqui, yes a website or 
a mobile application just using the data from Moqui via REST. All 
screen rendering is now done with for example the vue.js framework 
using javascript in the client, not using ftl at all, improving the 
user interface experience dramatically. So all templates and the 
rendering is in the client making it completely static and can be 
loaded from cdn networks.


My advise? If you want to extend the life of OFBiz implement a REST 
interface quickly...or copy it over from Moqui, no problem, the 
license allows it.


Regards,

Hans Bakker,
CEO antwebsystems.com

Re: future of OFBiz: REST is essential.

[Hans Bakker]

see my answer inline...

On 01/29/2019 04:01 PM, Mathieu Lirzin wrote:

Hello Hans,

Hans Bakker  writes:


It is now almost 15 years ago i started with OFBiz. I always followed
new technology developments and used them when they became usable in a
production environment. That is why i joined OFBiz early. I also
proposed years ago to go from svn to git that now finally is approved
for OFBiz. I also proposed to replace the OFBiz framework with
Moqui.org, yes I know a much bigger change but believe me, that will
also happen one time for you.

I don't think this kind of communication style is very helpful in
general.  This sounds a lot like you are saying to the rest of us “You
are doing it wrong, I know better!”.
I just want to indicate that the OFBiz community is going to run behind 
in the technology developments so from my point of view too conservative.

We now support Moqui for about a year and the main reason we switched
over is the excellent REST interface Moqui has. This allows you to
have a user interface fully independent from Moqui, yes a website or a
mobile application just using the data from Moqui via REST. All screen
rendering is now done with for example the vue.js framework using
javascript in the client, not using ftl at all, improving the user
interface experience dramatically. So all templates and the .rendering
is in the client making it completely static and can be loaded from
cdn networks.

This is indeed highly desirable to let other interfaces like Single Page
Applications (SPA) consume the data and manipulate the services OFBiz
provides via a RESTlike interface.

On the SPA side, I personally encourage you to look at frameworks based
on what is often referred as the “Elm Architecture” [1] (React/Redux,
Re-agent, Elm, …) for the reason that are based on a “one way data flow”
and embraces functional programming.  They differs from frameworks like
Angular or Vue which has a “two way data-binding” which mean that they
are inherently more complex and harder to reason about.
choosing a use rinterface is an other subject, but not possible without 
a proper rest interface

My advise? If you want to extend the life of OFBiz implement a REST
interface quickly...or copy it over from Moqui, no problem, the
license allows it.

Could you present the design of Moqui REST support (architecture,
advantages, drawbacks, limitations, …) and give some pointers to the
implementation?

Additionally what would be your recommended strategy to port this work?
Are you willing to do the work?

Thanks.

[1] https://guide.elm-lang.org/architecture/

We just support existing OFBiz installations For new installations we 
use Moqui.
I just finished a proof of concept for a native Android/IOS app using 
Moqui REST. For OFBiz i intended to make it work too but that proved to 
be too difficult without REST.


If there would be an OFBiz REST API then it is feasibel to write UI 
applications which both work on OFBiz and Moqui because the basic 
functionality from an API point of view is not that different.


Thanks for your reply..

Regards,Hans Bakker
CEO antwebsystems.com

future of OFBiz: REST is essential.

[Hans Bakker]

Good morning, fellow developers.

It is now almost 15 years ago i started with OFBiz. I always followed 
new technology developments and used them when they became usable in a 
production environment. That is why i joined OFBiz early. I also 
proposed years ago to go from svn to git that now finally is approved 
for OFBiz. I also proposed to replace the OFBiz framework with 
Moqui.org, yes I know a much bigger change but believe me, that will 
also happen one time for you.


We now support Moqui for about a year and the main reason we switched 
over is the excellent REST interface Moqui has. This allows you to have 
a user interface fully independent from Moqui, yes a website or a mobile 
application just using the data from Moqui via REST. All screen 
rendering is now done with for example the vue.js framework using 
javascript in the client, not using ftl at all, improving the user 
interface experience dramatically. So all templates and the rendering is 
in the client making it completely static and can be loaded from cdn 
networks.


My advise? If you want to extend the life of OFBiz implement a REST 
interface quickly...or copy it over from Moqui, no problem, the license 
allows it.


Regards,

Hans Bakker,
CEO antwebsystems.com

Re: Successor for elRTE

[Hans Bakker]

today i saw this one: https://prosemirror.net/

interesting?

Re: Alternative UI using Vaadin as ofbiz user interface

[Hans Bakker]

Hi Nicolas,

i created https://issues.apache.org/jira/browse/OFBIZ-9831 for you

we are still working to improve the implementation.

if you have questions, let me know

we can also provide write access to our git repository

Thanks in advance for your help.

Regards,
Hans

On 30/09/17 01:05, Nicolas Malin wrote:

Hi Hans,

If it's too complicate for you to migrate your current works on the 
common-theme structure, please open an issue with your current patch I 
will check if it's possible to support it by common-theme or if the 
framework need some improvement to realize that.


Cheers,

Nicolas


Le 19/09/2017 à 08:49, Jacques Le Roux a écrit :

Hi Hans,

I'd then suggest to have a look at the common-theme Nicolas recently 
introduced and how to use it with your Vaadin effort in order to not 
have to change things in framework if possible


Please check https://issues.apache.org/jira/browse/OFBIZ-9138

Thanks

Jacques


Le 19/09/2017 à 03:56, Hans Bakker a écrit :

Hi Jacques,

we currently create it as a plugin with some patches, but it would be 
nice to integrate it in the framework, so it can be used by all 
components


regards,
Hans

On 08/08/17 20:10, Jacques Le Roux wrote:

Hi Hans,

I'm not interested in helping to implement (rather not enough spare 
time) but that could be contributed as a component I guess.


Could it be a plugins or does it need to be in framework? What would 
be the entailments for framework changes?


Thanks

Jacques


Le 07/08/2017 à 10:08, Hans Bakker a écrit :

Interest for co-operation?

We are looking here using vaadin (http://vaadin.com/) as user 
interface for OFBIz using existing OFBiz screens and forms


we have a proof of concept working here and are preparing a 
vadinDemo component for others to try.
 We implemented it creating an FTL macrolibrary generating Vaadin 
instead of HTML statements.


Please let me know here, if there is interest helping to implement 
this.


The license of Vaadin is in general Apache 2.0 or compatible.












--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: Alternative UI using Vaadin as ofbiz user interface

[Hans Bakker]

Hi Jacques,

we currently create it as a plugin with some patches, but it would be 
nice to integrate it in the framework, so it can be used by all components


regards,
Hans

On 08/08/17 20:10, Jacques Le Roux wrote:

Hi Hans,

I'm not interested in helping to implement (rather not enough spare 
time) but that could be contributed as a component I guess.


Could it be a plugins or does it need to be in framework? What would be 
the entailments for framework changes?


Thanks

Jacques


Le 07/08/2017 à 10:08, Hans Bakker a écrit :

Interest for co-operation?

We are looking here using vaadin (http://vaadin.com/) as user 
interface for OFBIz using existing OFBiz screens and forms


we have a proof of concept working here and are preparing a vadinDemo 
component for others to try.
 We implemented it creating an FTL macrolibrary generating Vaadin 
instead of HTML statements.


Please let me know here, if there is interest helping to implement this.

The license of Vaadin is in general Apache 2.0 or compatible.

Alternative UI using Vaadin as ofbiz user interface

[Hans Bakker]

Interest for co-operation?

We are looking here using vaadin (http://vaadin.com/) as user interface 
for OFBIz using existing OFBiz screens and forms


we have a proof of concept working here and are preparing a vadinDemo 
component for others to try.
 We implemented it creating an FTL macrolibrary generating Vaadin 
instead of HTML statements.


Please let me know here, if there is interest helping to implement this.

The license of Vaadin is in general Apache 2.0 or compatible.

--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: OFBiz Sanity Test Document

[Hans Bakker]

We have developed a test component called growerptest which uses 
webdriver with configuration in xml files separating re-usable 
commandstepgroups and testdata. The component uses the ofbiz test hook 
to integrate it with the standard junit tests


all available at
https://gerrit.antwebsystems.com/#/admin/projects/growerptest

compatible with V15

--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

On 09/07/17 17:29, Sanjay Yadav wrote:

Thank you, Rishi.

Best Regards,*
*
*
*
*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce <http://www.hotwax.co/>by**HotWax Systems 
<http://www.hotwaxsystems.com/>

80, Scheme No. 78, Part II, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav 
<https://www.linkedin.com/in/sanjay-yadav/>


HotWax Systems recently received 8 mentions in /*The Gartner Digital 
Commerce Vendor Guide, 2016 */by Gartner, Inc., the world's leading IT 
research and advisory company.//Learn more about our researchhere 
<https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html>.

Inline image 1



On Sun, Jul 9, 2017 at 3:52 PM, Rishi Solanki <rishisolan...@gmail.com 
<mailto:rishisolan...@gmail.com>> wrote:


Thanks Sanjay for great effort,

Moving this thread to dev list for better handling of feedback.


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com

On Sun, Jul 9, 2017 at 3:46 PM, Sanjay Yadav
<sanjay.ya...@hotwaxsystems.com <mailto:sanjay.ya...@hotwaxsystems.com>
> wrote:

> Hello Everyone,
>
> I've created OFBiz Sanity Test document at below location -
>
 > <http://goog_291272848>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test
<https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test>
>
> Please have a look and let me know your feedback. Thanks!
>
>
> Best Regards,
>
 > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
 > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
 > <http://www.hotwaxsystems.com/>
> 80, Scheme No. 78, Part II, Indore, M.P. 452010, India
> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
 > <https://www.linkedin.com/in/sanjay-yadav/
<https://www.linkedin.com/in/sanjay-yadav/>>
 >
 > HotWax Systems recently received 8 mentions in *The Gartner Digital
 > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> research and advisory company. Learn more about our research here
 >

<https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html

<https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html>>
 > .
 > [image: Inline image 1]
 >
 >
 >




--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: Gradle documentation and migration status

[Hans Bakker]

Jaques,

we keep our changes to the OFBiz code in a git branch which we merge in 
after every OFBiz upgrade. The three way merge process in Git is 
excellent and saves us a lot of time compared to using patches.


Regards,
Hans

On 14/03/17 15:08, Jacques Le Roux wrote:

Le 10/03/2017 à 19:10, Jacques Le Roux a écrit :

So I'd like a confirmation on how you are handling changes you do
inside the OOTB code (framework, applications or plugins). Of course,
I don't speak about poking inside the code, but putting changes apart
to take care of the coming updates/upgrades...


OK, it's now almost 4 days and I got any answers, so I guess this is no
longer something of interest for the community. So

 * I set OFBIZ-7962 "Migrate the patch management Ant targets" as a
postponed task
 * I completely struck the "Patch Management Using Gradle Targets"
section and will let it as is. I will see later if I need to drop or
update it.
 * I have closed OFBIZ-7677 "Update documentation with respect to
implementation of gradle as a replacement of ant"

For me the Ant to Gradle documentation is completely done.

BTW while looking at OFBIZ-9256 "Split the tools folder from the trunk
and put it in another branch" I noticed for OFBIZ-7677 I created a
documentation folder under the tools directory. I believe now, before
splitting the tools, we should put it directly under the root dir and
put there all generic documentation, I'll do so w/o comment before doing
OFBIZ-7677

Jacques




--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: What is the "Apache OFBiz" product?

[Hans Bakker]

+1 for "Apache OFBiz enterprise automation framework"

and perhaps later create a new product "OFBiz Business suite" based on 
the framework which is ready for direct use.


However currently leave the immediate consumption for the systems like 
Hotwax e-commerce, Ilscipio ERP and GrowERP and others


Regards,
Hans

On 12/01/17 00:44, Nicolas Malin wrote:

I don't like the term ERP because is so reduced term for OFBiz dans all
product that can register a task for a party and a product is an ERP

I prefer "Apache OFBiz enterprise automation framework"

The term ERP or Business suite will come with the plugin addition to the
OFBiz core.

Nicolas

Le 11/01/2017 à 17:15, Taher Alkhateeb a écrit :

Agreed Jacopo,

My preference would be The "Apache OFBiz" ERP suite. The reason is
that the
term ERP is very popular and understandable to business folks. It also
conveys the heart of what this product is all about. Yes it is not yet
refined for immediate consumption by end users, but that does not prevent
usage of the term.




On Jan 11, 2017 6:19 PM, "Jacopo Cappellato" <jacopo.cappellato@
hotwaxsystems.com> wrote:

On Wed, Jan 11, 2017 at 3:51 PM, Julien NICOLAS
<julien.nico...@nereide.fr>
wrote:


[...]
This is why I prefer the actual sentence "Apache OFBiz® is an open
source
product for the automation of enterprise processes that includes
framework
components and business applications"


>From a trademark best practice perspective the above is incorrect
(yeah...
it is in our website) and should be changed to its equivalent:

"The Apache OFBiz® open source product for the automation of enterprise
processes"

and its longer (descriptive) version would be:

"The Apache OFBiz® open source product for the automation of enterprise
processes includes framework components and business applications"

A bit ugly.

Jacopo





--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: Replace password encryption SHA-1 by SHA-512

[Hans Bakker]

What is the impact?

if people have to re-enter the password then it is not acceptable.

it should be backwards compatible.

Regards,
Hans

On 08/12/16 16:33, Michael Brohl wrote:

Jacques,

I have no time to think about it more so I would prefer to create a
Jira, provide a patch and wait a few days for people to review.

I see no need to hurry with this issue.

Thanks,

Michael


Am 08.12.16 um 10:01 schrieb Jacques Le Roux:

OK, nobody expressed a concern so I'll apply a lazy consensus and
implement "SHA-512 and increase PBKDF2_ITERATIONS to 10 000"

Else please express your concern now before I create a Jira for that

Thanks

Jacques


Le 05/12/2016 à 16:38, Jacques Le Roux a écrit :

Thanks Jinghai, indeed Argon does not seems to be implemented in
available JDKs, maybe later...

Jacques


Le 05/12/2016 à 15:48, Shi Jinghai a écrit :

Hi Jacques,

Personally I'd prefer PBKDF2 rather than Argon, because the encrypt
of PBKDF2 is done by JDK, I don't know whether Argon has been
supported by JDK.

Kind Regards,

Shi Jinghai

-邮件原件-
发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com]
发送时间: 2016年12月5日 22:24
收件人: dev@ofbiz.apache.org
抄送: gregory draperi
主题: Replace password encryption SHA-1 by SHA-512

Hi,

At https://issues.apache.org/jira/browse/OFBIZ-8537 Junyuan has
contributed a new PBDKF2_SHA* one way encryption for password

At http://svn.apache.org/viewvc?rev=1772589=rev Jinghai has
committed it, I made few remarks on this commit, one of this comment
was also discussed in the Jira by Pierre and Michael. It's about
using PBDKF2 OOTB.

After reading https://cryptosense.com/parameter-choice-for-pbkdf2/ I
think we should replace our current SHA1 default implementation by
SHA-512 and increase PBKDF2_ITERATIONS to 10 000

We should also provide new PBDKF2_SHA1 password data.

As suggested by the article above, another step would be to use
Argon https://password-hashing.net/

What do you think?

Jacques













--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: ofbiz entity query problem?

[Hans Bakker]

looks like it is caused by the underlying viewforget it for now.

On 01/09/16 13:18, Hans Bakker wrote:

Sorry it is a bit more complicated:

andExprs = [];
andExprs.add(EntityCondition.makeCondition("marketingCampaignId",
EntityOperator.EQUALS, parameters.marketingCampaignId));
andExprs.add(EntityCondition.makeCondition("actionIsActive",
EntityOperator.NOT_EQUAL, "N"));

orExprs = [];
orExprs.add(EntityCondition.makeCondition(andExprs, EntityOperator.AND));
orExprs.add(EntityCondition.makeCondition("workEffortId",
EntityOperator.EQUALS, null));


i tried to simplify it but too much.

these condictions are on a custom view i created here.

the message is still:
 java.lang.IllegalArgumentException: Operator must be EQUALS or
NOT_EQUAL when right/rhs argument is NULL )


Regards,
Hans



On 01/09/16 13:05, Hans Bakker wrote:

if i write the groovy statement:

orExprs = [];
orExprs.add(EntityCondition.makeCondition("workEffortId",
EntityOperator.NOT_EQUAL, null));

i get the error message:

java.lang.IllegalArgumentException: Operator must be EQUALS or NOT_EQUAL
when right/rhs argument is NULL )

if i change the operator to EQUALS it seems to work fine.

anybody can confirm?





--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: ofbiz entity query problem?

[Hans Bakker]

Sorry it is a bit more complicated:

andExprs = [];
andExprs.add(EntityCondition.makeCondition("marketingCampaignId", 
EntityOperator.EQUALS, parameters.marketingCampaignId));
andExprs.add(EntityCondition.makeCondition("actionIsActive", 
EntityOperator.NOT_EQUAL, "N"));


orExprs = [];
orExprs.add(EntityCondition.makeCondition(andExprs, EntityOperator.AND));
orExprs.add(EntityCondition.makeCondition("workEffortId", 
EntityOperator.EQUALS, null));



i tried to simplify it but too much.

these condictions are on a custom view i created here.

the message is still:
 java.lang.IllegalArgumentException: Operator must be EQUALS or 
NOT_EQUAL when right/rhs argument is NULL )



Regards,
Hans



On 01/09/16 13:05, Hans Bakker wrote:

if i write the groovy statement:

orExprs = [];
orExprs.add(EntityCondition.makeCondition("workEffortId",
EntityOperator.NOT_EQUAL, null));

i get the error message:

java.lang.IllegalArgumentException: Operator must be EQUALS or NOT_EQUAL
when right/rhs argument is NULL )

if i change the operator to EQUALS it seems to work fine.

anybody can confirm?



--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

ofbiz entity query problem?

[Hans Bakker]

if i write the groovy statement:

orExprs = [];
orExprs.add(EntityCondition.makeCondition("workEffortId", 
EntityOperator.NOT_EQUAL, null));


i get the error message:

java.lang.IllegalArgumentException: Operator must be EQUALS or NOT_EQUAL 
when right/rhs argument is NULL )


if i change the operator to EQUALS it seems to work fine.

anybody can confirm?

--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Comment Edited] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391227#comment-15391227
 ] 

Hans Bakker edited comment on OFBIZ-7754 at 7/25/16 1:11 AM:
-

if you move these initial property settings to the database is fine with me, As 
long as you delete the general.properties file,  because that file does not do 
anything anymore because overridden by the database settings... 

But here you will upset the people upgrading who did previously used the 
general properties file.


was (Author: hansbak):
if you move these initial property settings to the database is fine with me, As 
long as you delete the general.properties file,  because that file does not do 
anything anymore because overridden by the database settings... 

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Pierre Smits
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391227#comment-15391227
 ] 

Hans Bakker commented on OFBIZ-7754:


if you move these initial property settings to the database is fine with me, As 
long as you delete the general.properties file,  because that file does not do 
anything anymore because overridden by the database settings... 

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Pierre Smits
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to modify the testing framework for OFBiz

[Hans Bakker]

great initiative Taher, finally someone who values automated tests to 
enable TDD but also leading to continuous improvement and finally 
continuous deployment


Regards,
Hans Bakker
CEO AntWebsystems.com

On 18/07/16 12:06, Taher Alkhateeb wrote:

Hello Everyone,

In reference to this thread and the Jira OFBIZ-7254, I'm very happy to
announce that OFBiz is now ready for applying unit tests with only 8 new
lines of code in the build script (r1753143) :)

I recommend we do the following moving forward:

1- Introduce unit tests as much as we can to all components
2- Migrate most of the integration tests we currently have to unit tests
(since they are designed to do very little integration).

This is a great chance for us to practice real TDD in OFBiz

Cheers,

Taher Alkhateeb

On Mon, Jun 13, 2016 at 7:43 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:


+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 10, 2016 at 7:46 PM, Taher Alkhateeb <
slidingfilame...@gmail.com

wrote:



Hello Everyone,

I was able to get a few tests running and this is very doable. But I

faced

a big problem in designing the testing framework because of ANT.

The problem

The way the build scripts are designed in OFBiz are very complex. A

master

file calls other files which call other files. And in the middle you have
external libraries (ant-contrib) and macros, and variables, and class

path

declarations, and and and 

I cannot declare the tests programmatically (with JUnit test suites)
because this means lower level components would depend on higher level
components. So I have to do it in ANT, by navigating this maze of build
scripts, and it was a headache for me just to read them, let alone modify
them to create a testing framework.

Suggested Solution

I suggest to implement the testing framework in Gradle, and simply call

it

from within ant. This is a middle solution that sustains ant for now, but
can allow us to switch out later.

This means I will just add one more file called build.gradle in the top
level directory, and figure out the business logic for calling the test
suites from that file

I look forward to your feedback.

Regards,

Taher Alkhateeb

On Wed, Jun 8, 2016 at 6:00 PM, Taher Alkhateeb <
slidingfilame...@gmail.com>
wrote:


Hi Everyone,

Thank you all for your support, JIRA created in
https://issues.apache.org/jira/browse/OFBIZ-7254

I will start working on it and try to implement ASAP to get my focus

back

on refactoring.

Cheers!

Taher Alkhateeb

On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:


+1

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:


+1

Makes perfect sense.

--
Thanks & Regards,
Mridul Pathak
Senior Manager
HotWax Systems
http://www.hotwaxsystems.com


On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb <

slidingfilame...@gmail.com>

wrote:


Hello Everyone,

After refactoring the start component and while starting on the

base

component I realized that the testing framework for OFBiz is not

good.

You

cannot do real test driven development or red-green-refactor with

the

current setup, hence my proposal to change it. I explain below:

Problem with current design

- What we have right now is not unit tests, it's really

integration

tests.

You have to start the framework, the database, the service engine,

the

entity engine and pretty much everything.
- Testing is very slow, because it's an integration test as I

mentioned

above. 10 minutes on a good computer!
- There is zero mocking! We actually have to --load-data for

things

to

work. Again, these are integration tests.
- Too complex: Integration tests by their nature are grabbing too

much.

Mind you, I am not objecting to integration tests (I actually like

them)

but I am objecting to not having real unit-tests. Unit tests

should

all

run

in a few seconds.

Proposed solution
--
- We keep what is considered real integration tests the way they

are

right

now and keep using them
- We move what should be unit tests into simple JUnit classes, and

we

do

not run them using java -jar ofbiz.jar --test, but instead run

them

directly from the build.xml script, so these files are not

identified

in

any XML document, but are simply called immediately from the build

scripts.

- We clearly mark the difference between integration tests and

unit

tests

(inside the source files or in the suite declarations).
- We change the run-tests target in build.xml to run both unit

tests

and

integration tests.

I intend to heavily refactor the framework and I would feel better

about

introducing this change while refactoring. What do you guys think?

Ideas?

Suggestions? Approvals 

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376506#comment-15376506
 ] 

Hans Bakker commented on OFBIZ-7754:


Can only repeat:
simply remove the framework/common/data/CommonSystemPropertyData.xml file from 
ofbiz-component is my suggestion.
then the file general.properties is active again.

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370065#comment-15370065
 ] 

Hans Bakker commented on OFBIZ-7754:


Looks like my emails about this subject did not come through
I am sorry Jacques, it still think this change solves a problem which does not 
exists. Referring to database settings we do not have in properties files is 
not justifying it. I was asking for actual examples.

Anyway if you people think it is a good idea, i am fine but would like to 
propose to disable the file framework/common/data/CommonSystemPropertyData.xml 
completely and just use it as an example how to use systemproperties.
So even not use it for initial seed. Then the general.properties gets active 
again and is not confusing for new users.
Regards,
Hans

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367112#comment-15367112
 ] 

Hans Bakker commented on OFBIZ-7754:


here it shows that we always need a business reason for the change. This issue 
is a nice example that is trying to provide a solution for a technical problem 
for which i do not see a business reason.

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (OFBIZ-7112) EntityUtilProperties

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker reopened OFBIZ-7112:


please see my comment at:
https://issues.apache.org/jira/browse/OFBIZ-7754

where i propose to revert this change.

> EntityUtilProperties
> 
>
> Key: OFBIZ-7112
> URL: https://issues.apache.org/jira/browse/OFBIZ-7112
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Wai
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7112.patch, OFBIZ-7112.patch, OFBIZ-7112.patch, 
> OFBIZ-7112.patch
>
>
> Ofbiz reads properties from either a properties file or the 
> entity:SystemProperty. The way it works previously is that ofbiz reads from 
> the entity:SystemProperty first and if there is no value associated with the 
> target propertyname, it would then locate the value from the relevant 
> properties file.
> In other words, if there is a database entry for a property, the database 
> entry should override the associated properties file.
> The issue is that if a database entry exist but the value is empty, it would 
> look for a value from the properties file.  It should not do so.  If a 
> database entry exists for the propertyname of interest, the value should be 
> taken from the database even if it holds an empty value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-7754) The big problem when load seed.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363576#comment-15363576
 ] 

Hans Bakker commented on OFBIZ-7754:


After more thought I would like to question the whole implementation of  
OFBIZ-7112.

As far as i understood it, it was initiated because it was not possible to set 
a properties value to 'blank' or Empty, sure, accepted that is true. (although 
set in the properties file set to blank would be a solution?)
But is it required? Please give me a number of examples where this is needed. 
As far as I can see a properties value always has content either Y/N or 
False/True or a value.

Further, anybody just starting with the system will try to change the most 
important properties file  'general.properties' and will see no result.

then as Kongrath (we call him Joe) mentioned an upgrade will be much more 
difficult if you set your parameters in general.properties or even worse set 
them in the DB and they get overwritten and sure should not be seed.

So my proposal: please revert this change in OFBIZ-7112 it causes far more 
problems than it solves.

> The big problem when load seed.
> ---
>
> Key: OFBIZ-7754
> URL: https://issues.apache.org/jira/browse/OFBIZ-7754
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Jacques Le Roux
> Attachments: OFBIZ-7754.patch
>
>
> Hi All,
> Regarding, [OFBIZ-7112|https://issues.apache.org/jira/browse/OFBIZ-7112]
> That's good for who start on use the ofbiz with initial setup, but not for 
> the site that already online and has to update the OFBiz core. Because when 
> has update OFBiz core they will use command load-seed for update.
> The problem is if we use load-seed mean the configuration data that's already 
> exists will be replaced by the data from this file,
> *CommonSystemPropertyData.xml*
> So, for my suggestion should change the reader from *seed* to *seed-initial*  
> or remove systemPropertyValue from the data file.
> Thank you,
> Kongrath



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Proposal to delete stale java files

[Hans Bakker]

+1

On 15/06/16 13:30, Ashish Vijaywargiya wrote:

I would prefer to keep Tax and Third Party Payment gateway files(The files
that does exists inside cybersource, ideal, orbital, paypal, securepay,
verisign etc). If you see some problems in those code base, like code base
is not updated based on latest changes then we can update those files.
Those files might have been used by so many users that we can't know
because we are doing this conversation on Dev mailing list. We should not
remove those files.

--
Kind Regards
Ashish Vijaywargiya
HotWax Systems - est. 1997

On Tue, Jun 14, 2016 at 7:40 PM, Taher Alkhateeb <slidingfilame...@gmail.com

wrote:



Hi Everyone,

I cannot actually believe it but while I was working on a project (I will
announce later) I discovered in the process that the below files cannot
compile!!! They existed for years in the code base without even being able
to compile. They reference non existent libraries or they have faulty code
(e.g. not importing used code)

I propose to delete them immediately from trunk


applications/accounting/src/org/ofbiz/accounting/thirdparty/cybersource/IcsPaymentServices.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealEvents.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/ideal/IdealPaymentServiceTest.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalServices.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayPaymentServices.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/securepay/SecurePayServiceTest.java

applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java

applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayInputStream.java

applications/content/src/org/ofbiz/content/openoffice/OpenOfficeByteArrayOutputStream.java

applications/content/src/org/ofbiz/content/openoffice/OpenOfficeServices.java
applications/content/src/org/ofbiz/content/openoffice/OpenOfficeWorker.java
applications/content/src/org/ofbiz/content/report

applications/content/src/org/ofbiz/content/report/JREntityListIteratorDataSource.java

applications/content/src/org/ofbiz/content/report/JRMapCollectionDataSource.java
applications/order/src/org/ofbiz/order/thirdparty/taxware

applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareException.java

applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareServices.java
applications/order/src/org/ofbiz/order/thirdparty/taxware/TaxwareUTL.java
applications/product/src/ShipmentScaleApplet.java

applications/securityext/src/org/ofbiz/securityext/thirdparty/truition/TruitionCoReg.java

framework/webapp/src/org/ofbiz/webapp/view/JasperReportsJXlsViewHandler.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPdfViewHandler.java

framework/webapp/src/org/ofbiz/webapp/view/JasperReportsPoiXlsViewHandler.java
framework/webapp/src/org/ofbiz/webapp/view/JasperReportsXmlViewHandler.java

Regards,

Taher Alkhateeb





--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: svn commit: r1728584 [1/2] - in /ofbiz/trunk: applications/accounting/script/org/ofbiz/accounting/admin/ applications/accounting/servicedef/ applications/accounting/webapp/accounting/WEB-INF/ appl

[Hans Bakker]

 
@@ -358,10 +350,9 @@ under the License.
  
  
  
-

  
-
+
  
  
  
@@ -385,10 +376,9 @@ under the License.
  
  
  
-

   
-
+
  
  
  
@@ -416,10 +406,9 @@ under the License.
  
  
  
-

  
-
+
  
  
  
@@ -443,10 +432,9 @@ under the License.
  
  
  
-

  
-
+
  
  
  
@@ -470,9 +458,8 @@ under the License.
  
  
  
-
  
-
+
  
  
  
@@ -495,9 +482,8 @@ under the License.
  
  
  
-
  
-
+
  
  
  
@@ -523,9 +509,8 @@ under the License.
  
  
  
-
  
-
+
  
  
  
@@ -549,7 +534,6 @@ under the License.
  
  
  
-    
      
  
  
@@ -568,9 +552,8 @@ under the License.
  
  
  
-
  
-
+
  
  
  
@@ -588,10 +571,9 @@ under the License.
  
  
  
-
  
  
-
+
  
  
  

Modified:
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?rev=1728584=1728583=1728584=diff

==
---
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
(original)
+++
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
Fri Feb  5 01:45:50 2016
@@ -508,7 +508,7 @@ under the License.
  
  
  
-
+
  
  
  






--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Commented] (OFBIZ-6783) Refactor start.java

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281216#comment-15281216
 ] 

Hans Bakker commented on OFBIZ-6783:


wouldn't it be nice (or even required?) to write an automated jUnit test for 
this new start.java?

> Refactor start.java
> ---
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> StartCommandUtil.java
>
>
> Looking at the main method and design of Start.java looks ugly. The things I 
> would like to fix so far are:
> - the file is too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at 
> Start! Given that this is an important file, I will provide a patch to be 
> reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-2219) Special issue to allow submitting patches for online help update

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-2219:
---
Assignee: (was: Hans Bakker)

> Special issue to allow submitting patches for online help update
> 
>
> Key: OFBIZ-2219
> URL: https://issues.apache.org/jira/browse/OFBIZ-2219
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: HelpAccounting.jpg, 
> OFBIZ-2219_DocbookAccountingHelp10.patch, build.xml
>
>
> *This issue should not be closed, at least until the online help is 
> completed...*
> in OFBIZ-2133, Bruno Busco has used Sharan's work in wiki as an help from 
> OFBiz OOTB. You can find links in AccountingHelpUrls.xml. I have asked Sharan 
> if she could update this links, while she is improving documentation, and she 
> agreed. So this issue is to allow her, and anybody else, to submit patches to 
> improve the online help (not only accounting of course hence the ALL 
> COMPONENTS)
> We commit only the [ones 
> completed|https://issues.apache.org/jira/browse/OFBIZ-4175?focusedCommentId=12993718=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12993718]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-4502) Improved CMS tree: more functionality and faster for large trees

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-4502:
---
Assignee: (was: Hans Bakker)

> Improved CMS tree: more functionality and faster for large trees
> 
>
> Key: OFBIZ-4502
> URL: https://issues.apache.org/jira/browse/OFBIZ-4502
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Trunk
>Reporter: Martin Kreidenweis
> Attachments: CMS-Tree-Improvement-2.patch, CMS-Tree-Improvement.patch
>
>
> We here at [Lusini|http://www.lusini.de/] did several improvements to the CMS 
> backend to make it more useable for large CMS installations. 
> * Improved performance of CMS tree
> ** loading nodes dynamically using AJAX
> *** Created ContentJsonEvents to handle the JSON calls
> ** use OFBiz entity caches
> ** removed duplicate execution of WebSitePublishPoint.groovy
> *** removed reference from controller.xml as it is not used anywhere
> * Moving nodes in CMS tree possible now using drag'n'drop
> ** ContentJsonEvents returns updated node attributes
> ** Adjusted WebSiteCMSNav.ftl to update the moved node with the data from the 
> ajax request
> ** Needed to replace the jstree jQuery plugin by the current version 
> available on the jstree website
> * Made nodes deleteable
> ** added remove to context menu
> ** We did not want to delete the WebSitePathAlias entities right away, so we 
> added a fromDate and thruDate to it. 
> *** extended WebSitePathAlias entity definition: added fromDate and thruDate
> *** now checking for date range everywhere when accessing path aliases
> *** This also allows users to publish or unpublish contents under a certain 
> URL automatically at some time in the future. 
> ** created event to "delete" a node
> *** thruDate of all assocs pointing to this node are set to current timestamp
> *** thruDate of WebSitePathAliases pointing to this content or any contents 
> below are set to current timestamp
> *** this way nothing is actually removed from the DB and a "undo" would be 
> possible if necessary
> ** extracted context menu to variable so it can be reused for all trees
> * fixed missing references to uiLabels in CMS menu bar
> * Activated cookie plugin so the selected node is remembered
> To migrate existing path aliases the following SQL statements can be used:
> BEGIN;
> UPDATE web_site_path_alias SET from_date=w.created_stamp FROM 
> web_site_path_alias w WHERE w.path_alias=web_site_path_alias.path_alias;
> ALTER TABLE web_site_path_alias
> DROP CONSTRAINT pk_web_site_path_alias,
> ADD CONSTRAINT pk_web_site_path_alias PRIMARY KEY (web_site_id, 
> path_alias, from_date);
> COMMIT;



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-2531) Enhancements in Trainings under HR module

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-2531:
---
Assignee: (was: Hans Bakker)

> Enhancements in Trainings under HR module
> -
>
> Key: OFBIZ-2531
> URL: https://issues.apache.org/jira/browse/OFBIZ-2531
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Trunk
> Environment: Windows XP
>Reporter: Simranjeet Singh
>Priority: Minor
> Attachments: ASF.LICENSE.NOT.GRANTED--Trng Write Up.txt, 
> HR_Training_improvements.patch, HR_Trainings.patch, HR_Trainings.patch, 
> HR_Trainings.patch
>
>
> Hi users,
> We are working on enhancement of "Trainings" under HR module. We have 
> modified the existing Trainings tab by adding a Training calendar to it. We 
> have planned to integrate following functionalities by doing some 
> modifications and enhancements under HR module
> *In GlobalHRSettings tab*
> 1. Added "Training Types" tab where admin can add/delete/update the types of 
> trainings available in an organization.
> 2. Implemented the functionality of "Training Calendar" where training 
> schedules are maintained. All the trainings are listed with their names, 
> from/thru date and target audience. Admin can create/update/delete any 
> calendar entry.
> *In Trainings tab*
> 1. Added "Trainings" sub-tab where employee can apply for available 
> trainings. Approver/Admin can assign any training from training calendar to 
> the employee.
> 2. Added "Trainings Status" tab where employee/approver can check their 
> training request status. Approver/Admin can approve/reject requested trainings
> We would like to upload the implemented trainings patch ASAP. Before 
> uploading patch we would like to discuss our approach with community members.
> Any comments/suggestions on this would be appreciated.
> Regards
> Simranjeet Singh
> iLabs, L & T Infotech Ltd.
> Mumbai.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6985) New Theme spnsored by an end user.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6985:
---
Description: 
This theme was created by a big ofbiz customer and contributed to the the ofbiz 
community.

A demo you can see in GrowERP:
https://minimum.growerpdemo.com/backend/control/main?PASSWORD=ofbiz=admin

  was:This theme was created by a big ofbiz customer and contributed to the the 
ofbiz community.


> New Theme spnsored by an end user.
> --
>
> Key: OFBIZ-6985
> URL: https://issues.apache.org/jira/browse/OFBIZ-6985
> Project: OFBiz
>  Issue Type: Improvement
>  Components: themes
>Affects Versions: Upcoming Branch
>    Reporter: Hans Bakker
>Priority: Minor
>
> This theme was created by a big ofbiz customer and contributed to the the 
> ofbiz community.
> A demo you can see in GrowERP:
> https://minimum.growerpdemo.com/backend/control/main?PASSWORD=ofbiz=admin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6985) New Theme spnsored by an end user.

[Hans Bakker (JIRA)]

Hans Bakker created OFBIZ-6985:
--

 Summary: New Theme spnsored by an end user.
 Key: OFBIZ-6985
 URL: https://issues.apache.org/jira/browse/OFBIZ-6985
 Project: OFBiz
  Issue Type: Improvement
  Components: themes
Affects Versions: Upcoming Branch
Reporter: Hans Bakker
Priority: Minor


This theme was created by a big ofbiz customer and contributed to the the ofbiz 
community.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: antwebsystems references in source

[Hans Bakker]

Ok Jacques, done in revision 1736947.

On 26/03/16 14:19, Jacques Le Roux wrote:

Hi Hans, All,

I stumbled upon this message by Adam by chance 
http://markmail.org/message/u2sffp4xvepfygfz


It seems you already did a fix but there are still some antwebsystems 
references in source.
Could you please look at them and fix them when possible. For instance 
"ofbizMenu.ftl" in cmssite is maybe OK.
Maybe because it could be updated. Or IMO removed, else how to keep 
this list up to date for equality purpose?


applications
party
data
PartyDemoData.xml
43:  ... ; Sent to: ofbizt...@example.com; Delivered-To: 
ofbizt...@example.com; " fromString="mailingl...@antwebsystems.com" 
toString="ofbizt...@example.com"/>


specialpurpose
cmssite
template
ofbiz
ofbizMenu.ftl
104: http://www.antwebsystems.com; target="_blank">Ant 
Websystems


googlebase
data
helpdata
HELP_GOOGLEBASE.xml
68:  ... fbizdemo2.antwebsystems.com", Web Site Mount Point = 
"ecommerce", Action Type = "insert", Status ID = "Publish Draft", Test 
Mode =  ...


scrum
script
org
ofbiz
scrum
test
TaskTests.xml (3 matches)
30: value="https://www.antwebsystems.com/svn/"/>
49: value="https://www.antwebsystems.com/svn/scrum"/>
67: value="https://www.antwebsystems.com/svn/scrum"/>


Thanks!

Jacques

[jira] [Commented] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196910#comment-15196910
 ] 

Hans Bakker commented on OFBIZ-6923:


correction\ committed 1735189

> Improve the decorator for manufacturing/order/facility component for re-use
> ---
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Hans Bakker
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6923.patch, OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6923.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

Committed revision 1735178.
Thank you Kongrath Suankaewmanee for your contribution.

> Improve the decorator for manufacturing/order/facility component for re-use
> ---
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Hans Bakker
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6923:
---
Component/s: product
 order

> Improve the decorator for manufacturing/order/facility component for re-use
> ---
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Hans Bakker
> Attachments: OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6923:
---
Summary: Improve the decorator for manufacturing/order/facility component 
for re-use  (was: Improve the decorator for manufacturing component.)

> Improve the decorator for manufacturing/order/facility component for re-use
> ---
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
> Attachments: OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-6923) Improve the decorator for manufacturing/order/facility component for re-use

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker reassigned OFBIZ-6923:
--

Assignee: Hans Bakker

> Improve the decorator for manufacturing/order/facility component for re-use
> ---
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
>Assignee: Hans Bakker
> Attachments: OFBIZ-6923.patch
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6923) Improve the decorator for manufacturing component.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186278#comment-15186278
 ] 

Hans Bakker commented on OFBIZ-6923:


+
does not seem right

> Improve the decorator for manufacturing component.
> --
>
> Key: OFBIZ-6923
> URL: https://issues.apache.org/jira/browse/OFBIZ-6923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Kongrath Suankaewmanee
> Attachments: manufacturing-decorator.diff
>
>
> We have a problem on organize the existing decorator. In this case is 
> manufacturing decorator and also in another decorator too. We cannot use the 
> existing decorator with *main-decorator* that define on another component in 
> *hot-deploy*.
> So, I thought we should make reorganization for decorator like in the 
> partymgr component
> *applications/party/widget/partymgr/CommonScreens.xml*
> All screen should call the common decorator and each common decorator call 
> *main-decorator* in each commonent, so if we have create the new component in 
> *hot-deploy* and it should use the *main-decorator* in their.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6847) use organizationPartyId from Application decorator instead of retrieve organizationPartyId that sent from other request, to support change accounting company.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6847.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

implemented with https://issues.apache.org/jira/browse/OFBIZ-6802

> use organizationPartyId from Application decorator instead of retrieve 
> organizationPartyId that sent from other request, to support change 
> accounting company.
> --
>
> Key: OFBIZ-6847
> URL: https://issues.apache.org/jira/browse/OFBIZ-6847
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Parinya Wongjina
> Fix For: Upcoming Branch
>
>
> This implement related to proposal of issue OFBIZ-6802



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6802.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch

just committed the corrective patch for xml and pdf problem
accounting/control/IncomeStatement?organizationPartyId=Company
Thank you Bank for the patch

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6802-fix-bug.patch, OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker reopened OFBIZ-6802:


jacopo reported a problem at 
https://demo-trunk-ofbiz.apache.org/accounting/control/IncomeStatement?organizationPartyId=Company

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix-bug.patch, OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1728584 [1/2] - in /ofbiz/trunk: applications/accounting/script/org/ofbiz/accounting/admin/ applications/accounting/servicedef/ applications/accounting/webapp/accounting/WEB-INF/ appl

[Hans Bakker]

ev=1728584=1728583=1728584=diff

==
--- ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
(original)
+++ ofbiz/trunk/applications/accounting/widget/GlSetupScreens.xml
Fri Feb  5 01:45:50 2016
@@ -26,7 +26,7 @@ under the License.
 
 
 
-
+
 
 
 
@@ -97,13 +97,13 @@ under the License.
 
 
 
-
+
 
 
 
 
 
-
+
 
 ${uiLabelMap.CommonImport}
 
@@ -126,7 +126,7 @@ under the License.
 
 
 
-
+
 
 
 
@@ -163,17 +163,16 @@ under the License.
 
 
 
-
 
 
-
+
 
 
 
 
 
 
-
+
 
 
 
@@ -205,9 +204,8 @@ under the License.
 
 
 
-
 
-
+
 
 
 
@@ -228,7 +226,6 @@ under the License.
 
 
 
-
 
 
 
@@ -251,7 +248,6 @@ under the License.
 
 
 
-
 
 
 
@@ -273,7 +269,6 @@ under the License.
 
 
 
-
 
 
 
@@ -294,7 +289,6 @@ under the License.
 
 
 
-
 
 
 
@@ -315,7 +309,6 @@ under the License.
 
 
 
-
 
 
 
@@ -336,7 +329,6 @@ under the License.
 
 
 
-
 
 
 
@@ -358,10 +350,9 @@ under the License.
 
 
 
-

 
-
+
 
 
 
@@ -385,10 +376,9 @@ under the License.
 
 
 
-

  
-
+
 
 
 
@@ -416,10 +406,9 @@ under the License.
 
 
 
-

 
-
+
 
 
 
@@ -443,10 +432,9 @@ under the License.
 
 
 
-

 
-
+
 
 
 
@@ -470,9 +458,8 @@ under the License.
 
 
 
-
 
-
+
 
 
 
@@ -495,9 +482,8 @@ under the License.
 
 
 
-
 
-
+
 
 
 
@@ -523,9 +509,8 @@ under the License.
 
 
 
-
 
-
+
 
 
 
@@ -549,7 +534,6 @@ under the License.
 
 
 
-
 
 
 
@@ -568,9 +552,8 @@ under the License.
 
 
 
    -        
 
-
+
 
 
 
@@ -588,10 +571,9 @@ under the License.
 
 
 
-
 
 
-
+
 
 
 

Modified:
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml?rev=1728584=1728583=1728584=diff

==
---
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
(original)
+++
ofbiz/trunk/applications/accounting/widget/ReportFinancialSummaryForms.xml
Fri Feb  5 01:45:50 2016
@@ -508,7 +508,7 @@ under the License.
 
 
 
-
+
 
 
 





--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Closed] (OFBIZ-6845) On the balance sheet, it display incorrect value on the total of long-term asset.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6845.
--
   Resolution: Fixed
Fix Version/s: Trunk

Committed revision 1730456
thank you Supatthra Nawicha  for the contribution.

> On the balance sheet, it display incorrect value on the total of long-term 
> asset.
> -
>
> Key: OFBIZ-6845
> URL: https://issues.apache.org/jira/browse/OFBIZ-6845
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Supatthra Nawicha
> Fix For: Trunk
>
> Attachments: addConditionForLongTermAsset.patch
>
>
> Now, it display the totals of all transactions of any assets. I have checked 
> on the code and I have found the missing condition checked in there. 
> {code:title=BalanceSheet.groovy|borderStyle=solid}
> List longtermAssetAndExprs = mainAndExprs as LinkedList;
> longtermAssetAndExprs.add(EntityCondition.makeCondition("glAccountClassId", 
> EntityOperator.IN, longtermAssetAccountClassIds));
> transactionTotals = select("glAccountId", "accountName", "accountCode", 
> "debitCreditFlag", 
> "amount").from("AcctgTransEntrySums").orderBy("glAccountId").queryList();
> {code}
> Actually, it should be:
> {code:java}
> List longtermAssetAndExprs = mainAndExprs as LinkedList;
> longtermAssetAndExprs.add(EntityCondition.makeCondition("glAccountClassId", 
> EntityOperator.IN, longtermAssetAccountClassIds));
> transactionTotals = select("glAccountId", "accountName", "accountCode", 
> "debitCreditFlag", 
> "amount").from("AcctgTransEntrySums").where(longtermAssetAndExprs).orderBy("glAccountId").queryList();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other 
companent can change it too.  (was: be able to set accounting company in the 
header, remove from accounting, so other companent can change it too.)

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, remove from 
accounting, so other companent can change it too.  (was: be able to set 
accounting company in the header, so other components can change it too.)

> be able to set accounting company in the header, remove from accounting, so 
> other companent can change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6802) be able to set accounting company in the header, so other companent can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6802.
--
Resolution: Fixed

Committed revision 1728584. Thank you Parinya Wongjina for the patch.

> be able to set accounting company in the header, so other companent can 
> change it too.
> --
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, so other components can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, so other 
components can change it too.  (was: be able to set accounting company in the 
header, remove from accounting, so other components can change it too.)

> be able to set accounting company in the header, so other components can 
> change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Attachment: (was: OFBIZ-6802.patch)

> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (OFBIZ-6875) Update various accounting labels regarding the dutch locale

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker reassigned OFBIZ-6875:
--

Assignee: Hans Bakker  (was: Pierre Smits)

> Update various accounting labels regarding the dutch locale
> ---
>
> Key: OFBIZ-6875
> URL: https://issues.apache.org/jira/browse/OFBIZ-6875
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Hans Bakker
>  Labels: Nederlands
> Attachments: OFBIZ-6875-AccountingLabels-v2.patch, 
> OFBIZ-6875-AccountingLabels.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6875) Update various accounting labels regarding the dutch locale

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131508#comment-15131508
 ] 

Hans Bakker commented on OFBIZ-6875:


Hi Pierre,

you changed 'bestelling' to 'order' That is fine with me, however there are 17 
other labels using 'bestelling'

further is there a suggested translation list for the Dutch language which 
lists that the translation for order should be 'order' in Dutch?

> Update various accounting labels regarding the dutch locale
> ---
>
> Key: OFBIZ-6875
> URL: https://issues.apache.org/jira/browse/OFBIZ-6875
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Hans Bakker
>  Labels: Nederlands
> Attachments: OFBIZ-6875-AccountingLabels-v2.patch, 
> OFBIZ-6875-AccountingLabels.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122728#comment-15122728
 ] 

Hans Bakker commented on OFBIZ-6802:


I tested the patch according the test instructions and it works well.

When the patch is applied there is no visible change in the ofbiz user 
interface when there is only a single accounting company. It becomes only 
visible when there is more than one in the header of all themes where it will 
show the current selected accounting company.

Also the accounting company list in accounting is not changed (yet).

Please provide your comments, when there are no objections, i will commit this 
change in a week.

> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
> Attachments: OFBIZ-6802-fix.patch, OFBIZ-6802.patch
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15114656#comment-15114656
 ] 

Hans Bakker commented on OFBIZ-6791:


Jacques, i admire your dedication, but, sorry to say, i still think that making 
the lead party mandatory would have been much easier and even cleaner 
too..what is an opportunity without a lead?

> Various fixes related with sales opportunity
> 
>
> Key: OFBIZ-6791
> URL: https://issues.apache.org/jira/browse/OFBIZ-6791
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01, Upcoming Branch
>
> Attachments: sfa.patch
>
>
> Hans directly committed
> * r1723007 "sales opportunity creation: required-field removed, disturbed the 
> form submission, entityone no value field, error in the log"
> * and r1723248 "various fixes to the salesopportunity list and create 
> functions"
> I wanted to backport them and create this Jira for releases notes. But before 
> I checked the commits and found an issue, see 
> http://markmail.org/message/mspie3qdjcac2tci



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6791) Various fixes related with sales opportunity

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6791:
---
Attachment: sfa.patch

patch to change the opportunitylist to show an opportunity even if no lead or 
account attached

> Various fixes related with sales opportunity
> 
>
> Key: OFBIZ-6791
> URL: https://issues.apache.org/jira/browse/OFBIZ-6791
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: sfa.patch
>
>
> Hans directly committed
> * r1723007 "sales opportunity creation: required-field removed, disturbed the 
> form submission, entityone no value field, error in the log"
> * and r1723248 "various fixes to the salesopportunity list and create 
> functions"
> I wanted to backport them and create this Jira for releases notes. But before 
> I checked the commits and found an issue, see 
> http://markmail.org/message/mspie3qdjcac2tci



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15111949#comment-15111949
 ] 

Hans Bakker commented on OFBIZ-6791:


My apologies if I upset you Jacques, it was not my intention.

this problems can be solved either, changing the seca to make the lead 
mandatory, which you do not seem to like or we change the listing program so it 
will list all opportunities even if there is no lead or account

Attached a patch for the second possibility.
in this case however it is not possible to select only the lead of the role so 
depending on availability either the lead or the account is shown. 

anyway that is all i can do..

> Various fixes related with sales opportunity
> 
>
> Key: OFBIZ-6791
> URL: https://issues.apache.org/jira/browse/OFBIZ-6791
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Hans directly committed
> * r1723007 "sales opportunity creation: required-field removed, disturbed the 
> form submission, entityone no value field, error in the log"
> * and r1723248 "various fixes to the salesopportunity list and create 
> functions"
> I wanted to backport them and create this Jira for releases notes. But before 
> I checked the commits and found an issue, see 
> http://markmail.org/message/mspie3qdjcac2tci



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6791) Various fixes related with sales opportunity

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15107806#comment-15107806
 ] 

Hans Bakker commented on OFBIZ-6791:


Jacques, perhaps you missed it but I answered on the mailing list with:
because this change makes the leadparty a mandatory field. If not filled in, it 
will not appear in the list screen.

Regards,
Hans

To re-produce the error now:
create a new opportunity with just the opportunity name filled in.

go back to the opportunity list, and your newly opportunity will not appear.

> Various fixes related with sales opportunity
> 
>
> Key: OFBIZ-6791
> URL: https://issues.apache.org/jira/browse/OFBIZ-6791
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing, order
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Hans directly committed
> * r1723007 "sales opportunity creation: required-field removed, disturbed the 
> form submission, entityone no value field, error in the log"
> * and r1723248 "various fixes to the salesopportunity list and create 
> functions"
> I wanted to backport them and create this Jira for releases notes. But before 
> I checked the commits and found an issue, see 
> http://markmail.org/message/mspie3qdjcac2tci



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

catalina messages in the log?

[Hans Bakker]

Anybody is aware of the catalina messages?

example:
 [java] 2016-01-20 08:39:37,037 |catalina-startup-1 
|UtilXml   |W| [UtilXml.LocalResolver.resolveEntity] 
could not find LOCAL DTD/Schema with publicId [null] and the 
file/resource is [javaee_web_services_client_1_3.xsd]



--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Opinion requested: possibility to use the top ofbiz menu for a single component?

[Hans Bakker]

Your opinion please.

In GrowERP we have developed a possibility in OFBiz to replace the top 
menu of standard ofbiz, by a menu defined in a single component in 
Hot-deloy.


The use case is that you would like to build a single component 
application on top of OFbiz with its own menu structure.


It is completely transparent, if the component using it, is not present 
the standard menu is shown.


Before we put any work into this we like to know if there is an interest 
for it.


Regards,
Hans

--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Commented] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15104188#comment-15104188
 ] 

Hans Bakker commented on OFBIZ-6802:


Using the position the current user has in the company structure is an 
interesting idea and sure would be ideal implementation. This means however 
that this information needs to be available what is not always the case

When no objections we will implement the following:

When there is only a single INTERNAL_ORGANIZATIO company, then the header 
should not change and this company is automatically selected.

When there are more than a single company, a click-able accounting company name 
should be shown in the header.

Show the selected company in the user preferences, when not available use the 
system preferences, when not available use the oldest accounting company 
created, when nothing found show the accounting company setup screen where the 
partyid can be selected or created.

When the accounting company name in the header is clicked, show a popup with a 
list of accounting companies.

Check if the current user is part of an accounting company(partyRelationship), 
when yes, show that company and all accounting companies lower in the 
accounting company tree. A user can be part of more than a single company.

When the current user is not part of an accounting company, show all companies 
alphabetically with the role INTERNAL_ORGANIZATIO.

Let the user select the company and update the context and user preference.

> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
> Environment: any
>Reporter: Hans Bakker
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by 
> {code}
> "${organization} setup' and '${organization} accounting where ${organization} 
> {code}
> is the current selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonext component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

[Hans Bakker]

because this change makes the leadparty a mandatory field. If not filled 
in, it will not appear in the list screen.


Regards,
Hans

On 15/01/16 03:58, Jacques Le Roux wrote:

Le 10/01/2016 20:54, Jacques Le Roux a écrit :

Hans,

I have created https://issues.apache.org/jira/browse/OFBIZ-6791

Before backporting, I just wonder why you committed this
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?r1=1723248=1723247=1723248 



Like accountPartyId, leadPartyId is optional in 
createSalesOpportunity and updateSalesOpportunity so why only 
changing this seca?
It seems not a good idea to me, except if for a reason you prefer it 
to fail than skip? Then why only this seca instance and not the 3 
related others?


OK, w/o answers for 4 days, I will revert that and will then backport 
the rest as much as reasonably possible


Jacques



Jacques

Le 08/01/2016 13:42, Jacques Le Roux a écrit :

Hans,

Le 08/01/2016 06:34, Hans Bakker a écrit :

Jacques,

I daid it before, I appreciate tremendously the work you put into 
the OFBiz project and i am very sorry I cannot implement your 
request to put effort in a released based philosophy which I think  
does not fit in the modern times any more. Yes I am aware that the 
enterprise world is very conservative, on the other hand with the 
large customers we have, I could always convince them not to use 
the older releases but the near trunk version. Now that the system 
will move to the cloud anyway, releases will be abandoned 
completely by every ERP vendor when, like a phone app, the system 
in the cloud will be updated frequently.


That's your point of view, but I don't think that one size fits all. 
For instance what if you provide a product based on OFBiz. That's 
just an example, not everybody will use the cloud, and Cobol is 
still the language with the most line of codes on the planet.




Then your second request again for releases,  I found pretty 
embarrassing errors in the sales opportunity which better not 
appear in the change list for a release. :-( It was completely 
unusable, so I think not used anyway


But in future if the end user can benefit from it I will create a 
Jira.


Thanks! I will take care of those 2.

Cheers

Jacques



Regards,
Hans



On 08/01/16 12:05, Jacques Le Roux wrote:

Hi Hans,

Le 07/01/2016 03:09, Hans Bakker a écrit :

Jacques,

As you know, we in AntWebsystems are using a 'near' trunk version 
which we test for a month and then deploy in production. We do 
this for the last 4 years without major problems. We also support 
the continuous testing and deployment with the Kanban methodology 
with 'rolling' releases. So for us, we do not use the official 
ofbiz releases.


So my question, is it mandatory when we fix problems in the trunk 
that we have to backport even if we do not use the releases?


No, it's not mandatory but would be fair, hence my question.



The changes I did, were simple fixes, do we need a Jira for that 
too?


Yes, that would help others who rely on releases. I think you know 
creating Jira issues help to automatically generate releases notes 
like http://ofbiz.apache.org/release-notes-13.07.02.html
Remember we have been successful so far because we behave as a 
global team. You and AntWebsystems are an important part of this 
team, so I hope you will consider contributing a Jira and 
backports for these 2 cases and in the future.


Thanks

Jacques



Regards,
Hans

On 06/01/16 16:00, Jacques Le Roux wrote:

Hi Hans,

With this commit and r1723007 will you not create a Jira and 
backport fixes in released branches?


Jacques

Le 06/01/2016 08:53, hans...@apache.org a écrit :

Author: hansbak
Date: Wed Jan  6 07:53:26 2016
New Revision: 1723248

URL: http://svn.apache.org/viewvc?rev=1723248=rev
Log:
various fixes to the salesopportunity list and create functions

Modified:
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 

ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml 


ofbiz/trunk/applications/order/servicedef/secas.xml

Modified: 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml?rev=1723248=1723247=1723248=diff
== 

--- 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
(original)
+++ 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
Wed Jan  6 07:53:26 2016

@@ -64,7 +64,6 @@ under the License.
  
  
  
-value="${groovy:org.ofbiz.base.util.UtilValidate.isDateAfterNow(estimatedCloseDate)}" 
type="Boolean"/>
  value-field="salesOpportunity"/>

  
  
@@ -85,7 +84,7 @@ under the License.
  title="${uiLabel

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Description: 
Currently it is possible to set the current accounting company in the option 
under organization GL settings and in party preferences.

The proposal is to remove it from accounting and set it in the theme header so 
it will be available in all components. In order to make the system not more 
complicated, this setting is only available when there is more than a single 
accounting company.

Then replace the organization GL settings in accounting  by "${organization} 
setup' and '${organization} accounting where ${organization} is the current 
selected accounting company in the header.

The global setting of the current organization is already done in the 
application decorator in the commonex component.


  was:
Currently it is possible to set the current accounting company in the option 
under organization GL settings and in party preferences.

The proposal is to remove it from accounting and set it in the theme header so 
it will be available in all components. In order to make the system not more 
complicated, this setting is only available when there is more than a single 
accounting company.

Then replace the organization GL settings by "${organization} setup' and 
'${organization} accounting where ${organization} is the current selected 
accounting company in the header.

The global setting of the current organization is already done in the 
application decorator in the commonex component.



> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: trun
>     Environment: any
>Reporter: Hans Bakker
> Fix For: tru
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings in accounting  by "${organization} 
> setup' and '${organization} accounting where ${organization} is the current 
> selected accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonex component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.

[Hans Bakker (JIRA)]

Hans Bakker created OFBIZ-6802:
--

 Summary: be able to set accounting company in the header, remove 
from accounting, so other companent can change it too.
 Key: OFBIZ-6802
 URL: https://issues.apache.org/jira/browse/OFBIZ-6802
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: trun
 Environment: any
Reporter: Hans Bakker
 Fix For: tru


Currently it is possible to set the current accounting company in the option 
under organization GL settings and in party preferences.

The proposal is to remove it from accounting and set it in the theme header so 
it will be available in all components. In order to make the system not more 
complicated, this setting is only available when there is more than a single 
accounting company.

Then replace the organization GL settings by "${organization} setup' and 
'${organization} accounting where ${organization} is the current selected 
accounting company in the header.

The global setting of the current organization is already done in the 
application decorator in the commonex component.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker updated OFBIZ-6802:
---
Summary: be able to set accounting company in the header, remove from 
accounting, so other components can change it too.  (was: be able to set 
accounting company in the header, remove from accounting, so other companent 
can change it too.)

> be able to set accounting company in the header, remove from accounting, so 
> other components can change it too.
> ---
>
> Key: OFBIZ-6802
> URL: https://issues.apache.org/jira/browse/OFBIZ-6802
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: trun
> Environment: any
>Reporter: Hans Bakker
> Fix For: tru
>
>
> Currently it is possible to set the current accounting company in the option 
> under organization GL settings and in party preferences.
> The proposal is to remove it from accounting and set it in the theme header 
> so it will be available in all components. In order to make the system not 
> more complicated, this setting is only available when there is more than a 
> single accounting company.
> Then replace the organization GL settings by "${organization} setup' and 
> '${organization} accounting where ${organization} is the current selected 
> accounting company in the header.
> The global setting of the current organization is already done in the 
> application decorator in the commonex component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

[Hans Bakker]

Jacques,

I daid it before, I appreciate tremendously the work you put into the 
OFBiz project and i am very sorry I cannot implement your request to put 
effort in a released based philosophy which I think  does not fit in the 
modern times any more. Yes I am aware that the enterprise world is very 
conservative, on the other hand with the large customers we have, I 
could always convince them not to use the older releases but the near 
trunk version. Now that the system will move to the cloud anyway, 
releases will be abandoned completely by every ERP vendor when, like a 
phone app, the system in the cloud will be updated frequently.


Then your second request again for releases,  I found pretty 
embarrassing errors in the sales opportunity which better not appear in 
the change list for a release. :-( It was completely unusable, so I 
think not used anyway


But in future if the end user can benefit from it I will create a Jira.

Regards,
Hans



On 08/01/16 12:05, Jacques Le Roux wrote:

Hi Hans,

Le 07/01/2016 03:09, Hans Bakker a écrit :

Jacques,

As you know, we in AntWebsystems are using a 'near' trunk version 
which we test for a month and then deploy in production. We do this 
for the last 4 years without major problems. We also support the 
continuous testing and deployment with the Kanban methodology with 
'rolling' releases. So for us, we do not use the official ofbiz 
releases.


So my question, is it mandatory when we fix problems in the trunk 
that we have to backport even if we do not use the releases?


No, it's not mandatory but would be fair, hence my question.



The changes I did, were simple fixes, do we need a Jira for that too?


Yes, that would help others who rely on releases. I think you know 
creating Jira issues help to automatically generate releases notes 
like http://ofbiz.apache.org/release-notes-13.07.02.html
Remember we have been successful so far because we behave as a global 
team. You and AntWebsystems are an important part of this team, so I 
hope you will consider contributing a Jira and backports for these 2 
cases and in the future.


Thanks

Jacques



Regards,
Hans

On 06/01/16 16:00, Jacques Le Roux wrote:

Hi Hans,

With this commit and r1723007 will you not create a Jira and 
backport fixes in released branches?


Jacques

Le 06/01/2016 08:53, hans...@apache.org a écrit :

Author: hansbak
Date: Wed Jan  6 07:53:26 2016
New Revision: 1723248

URL: http://svn.apache.org/viewvc?rev=1723248=rev
Log:
various fixes to the salesopportunity list and create functions

Modified:
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 

ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml 


 ofbiz/trunk/applications/order/servicedef/secas.xml

Modified: 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml?rev=1723248=1723247=1723248=diff
== 

--- 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
(original)
+++ 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
Wed Jan  6 07:53:26 2016

@@ -64,7 +64,6 @@ under the License.
  
  
  
-value="${groovy:org.ofbiz.base.util.UtilValidate.isDateAfterNow(estimatedCloseDate)}" 
type="Boolean"/>
  value-field="salesOpportunity"/>

  
  
@@ -85,7 +84,7 @@ under the License.
  title="${uiLabelMap.SfaEstimatedAmount}">
  title="${uiLabelMap.SfaNextStepDate}" 
sort-field="true">
  title="${uiLabelMap.SfaCloseDate}">
-use-when="${groovy: estimatedCloseDate == null || isDateAfterNow == 
true || opportunityStageId != SOSTG_CLOSED}" 
widget-style="buttontext">
+use-when="estimatedCloseDate == void || estimatedCloseDate == null 
|| 
org.ofbiz.base.util.UtilValidate.isDateAfterNow(estimatedCloseDate) 
|| opportunityStageId != SOSTG_CLOSED" 
widget-style="buttontext">
  description="${uiLabelMap.CommonClose}">

  
  value="SOSTG_CLOSED"/>

@@ -151,10 +150,10 @@ under the License.
  
  
  
-use-when="communicationEvent==null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupPartyGroup" 
default-value="${accountPartyId}"/>
-use-when="communicationEvent!=null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupPartyGroup" 
default-value="${accountPartyId}"/>
-use-when="communicationEvent==null" 
title="${uiLabelMap.SfaLead}"&g

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

[Hans Bakker]

Jacques,

As you know, we in AntWebsystems are using a 'near' trunk version which 
we test for a month and then deploy in production. We do this for the 
last 4 years without major problems. We also support the continuous 
testing and deployment with the Kanban methodology with 'rolling' 
releases. So for us, we cannot use the official ofbiz releases.


So my question, is it mandatory when we fix problems in the trunk that 
we have to backport even if we do not use the releases?


The changes I did, were simple fixes, do we need a Jira for that too?

Regards,
Hans

On 06/01/16 16:00, Jacques Le Roux wrote:

Hi Hans,

With this commit and r1723007 will you not create a Jira and backport
fixes in released branches?

Jacques

Le 06/01/2016 08:53, hans...@apache.org a écrit :

Author: hansbak
Date: Wed Jan  6 07:53:26 2016
New Revision: 1723248

URL: http://svn.apache.org/viewvc?rev=1723248=rev
Log:
various fixes to the salesopportunity list and create functions

Modified:
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
 ofbiz/trunk/applications/order/servicedef/secas.xml

Modified:
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml?rev=1723248=1723247=1723248=diff
==

---
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
(original)
+++
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
Wed Jan  6 07:53:26 2016
@@ -64,7 +64,6 @@ under the License.
  
  
  
-
  
  
  
@@ -85,7 +84,7 @@ under the License.
  
  
  
-
+
  
  
  
@@ -151,10 +150,10 @@ under the License.
  
  
  
-
-
-
-
+
+
+
+
  
  
  

Modified:
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml?rev=1723248=1723247=1723248=diff
==

---
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
(original)
+++
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
Wed Jan  6 07:53:26 2016
@@ -143,13 +143,11 @@ This file contains basic services for Sa
  
  
  
-
-
-
-
  
-
  
+
+
+
  
  
  
@@ -164,12 +162,10 @@ This file contains basic services for Sa
  
  
  
-
-
-
  
-
  
+
+
  
  
  

Modified: ofbiz/trunk/applications/order/servicedef/secas.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?rev=1723248=1723247=1723248=diff
==

--- ofbiz/trunk/applications/order/servicedef/secas.xml (original)
+++ ofbiz/trunk/applications/order/servicedef/secas.xml Wed Jan 6
07:53:26 2016
@@ -421,7 +421,6 @@ under the License.
  
  
  
-
  
  
  






--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

[Hans Bakker]

Jacques,

As you know, we in AntWebsystems are using a 'near' trunk version which 
we test for a month and then deploy in production. We do this for the 
last 4 years without major problems. We also support the continuous 
testing and deployment with the Kanban methodology with 'rolling' 
releases. So for us, we do not use the official ofbiz releases.


So my question, is it mandatory when we fix problems in the trunk that 
we have to backport even if we do not use the releases?


The changes I did, were simple fixes, do we need a Jira for that too?

Regards,
Hans

On 06/01/16 16:00, Jacques Le Roux wrote:

Hi Hans,

With this commit and r1723007 will you not create a Jira and backport 
fixes in released branches?


Jacques

Le 06/01/2016 08:53, hans...@apache.org a écrit :

Author: hansbak
Date: Wed Jan  6 07:53:26 2016
New Revision: 1723248

URL: http://svn.apache.org/viewvc?rev=1723248=rev
Log:
various fixes to the salesopportunity list and create functions

Modified:
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
 ofbiz/trunk/applications/order/servicedef/secas.xml

Modified: 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml?rev=1723248=1723247=1723248=diff
== 

--- 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
(original)
+++ 
ofbiz/trunk/applications/marketing/widget/sfa/forms/OpportunityForms.xml 
Wed Jan  6 07:53:26 2016

@@ -64,7 +64,6 @@ under the License.
  
  
  
-value="${groovy:org.ofbiz.base.util.UtilValidate.isDateAfterNow(estimatedCloseDate)}" 
type="Boolean"/>
  value-field="salesOpportunity"/>

  
  
@@ -85,7 +84,7 @@ under the License.
  title="${uiLabelMap.SfaEstimatedAmount}">
  title="${uiLabelMap.SfaNextStepDate}" 
sort-field="true">
  title="${uiLabelMap.SfaCloseDate}">
-use-when="${groovy: estimatedCloseDate == null || isDateAfterNow == 
true || opportunityStageId != SOSTG_CLOSED}" 
widget-style="buttontext">
+use-when="estimatedCloseDate == void || estimatedCloseDate == null || 
org.ofbiz.base.util.UtilValidate.isDateAfterNow(estimatedCloseDate) 
|| opportunityStageId != SOSTG_CLOSED" 
widget-style="buttontext">
  description="${uiLabelMap.CommonClose}">

  
  value="SOSTG_CLOSED"/>

@@ -151,10 +150,10 @@ under the License.
  
  
  
-use-when="communicationEvent==null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupPartyGroup" 
default-value="${accountPartyId}"/>
-use-when="communicationEvent!=null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupPartyGroup" 
default-value="${accountPartyId}"/>
-use-when="communicationEvent==null" 
title="${uiLabelMap.SfaLead}">default-value="${leadPartyId}"/>
-use-when="communicationEvent!=null" 
title="${uiLabelMap.SfaLead}">default-value="${communicationEvent.partyIdFrom}"/>
+use-when="communicationEvent==null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupAccount" 
default-value="${accountPartyId}"/>
+use-when="communicationEvent!=null" 
title="${uiLabelMap.SfaInitialAccount}" >target-form-name="LookupAccount" 
default-value="${accountPartyId}"/>
+use-when="communicationEvent==null" 
title="${uiLabelMap.SfaLead}">default-value="${leadPartyId}"/>
+use-when="communicationEvent!=null" 
title="${uiLabelMap.SfaLead}">default-value="${communicationEvent.partyIdFrom}"/>
  use-when="salesOpportunity==null">
  title="${uiLabelMap.CommonUpdate}" 
use-when="salesOpportunity!=null">

  

Modified: 
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml?rev=1723248=1723247=1723248=diff
== 

--- 
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml 
(original)
+++ 
ofbiz/trunk/applications/order/script/org/ofbiz/order/opportunity/OpportunityServices.xml 
Wed Jan  6 07:53:26 2016

@@ -143,13 +143,11 @@ This file contains basic services for Sa
  
  
  
-
-from-field="parameters.accountPartyId"/>
-in-map-name="roleMap"/>

-
  value="ACCOUNT"/>
-from-field="parameters.salesOpportunityId"/>
  from-field="parameters.accountPartyId"/>
+in-map-name="salesOpportunityRole"/>

+   

[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006123#comment-15006123
 ] 

Hans Bakker commented on OFBIZ-6703:


at the time, i also did not agree, but he really pushed it and i gave up on 
it

> Cannot create more than one lead in the SFA component by same user
> --
>
> Key: OFBIZ-6703
> URL: https://issues.apache.org/jira/browse/OFBIZ-6703
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Fix For: 14.12.01, Upcoming Branch
>
>
> Repeat steps:
> # go to SFA component and click on leads
> # click on create new
> # fill mandatory information and save
> # repeat the above steps again and observe failure
> The reason for the failure is that the implementation of the createLead 
> service tries to create a PartyRole of type OWNER every time a lead is 
> created. So it works only the first time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or in OFBiz?

[Hans Bakker]

Nicolas,

as explained before this java call  is just a hook to an external java 
program which is called when the new test type is used which was added 
to the XSD as part of the patch. The required code can be added to the 
hot-deploy directory. We provided an example component with 
documentation how to use this hook in the growerptest component at 
https://gerrit.antwebsystems.com/#/admin/projects/growerptest


The component has the Apache 2.0 license, so free to download and 
contains all the documentation and example tests.


Please study that first?

Regards,
Hans

PS1. Nicolas, you forced last time the change in the 'addPartyRole' 
which I gave up on and which caused other problems in the system 
(SFA,setup and others) which i told you would happen. If you want this 
hook taken out , i am fine and i will contribute less and less to the 
core system because all the lengthy discussions.


PS2.Please note that this is also the last time i have something to say 
about this change.




On 10/11/15 03:59, Nicolas Malin wrote:

Hello,

I arrive after the war but :)
This issue is interesting for many points and I keep :
 * ModelTestSuite.java I'm afraid to see dead code, the call 'if 
("webdriver-test".equals(nodeName)' will be never use for a standard 
OFBiz and some new user won't understand why we call a non existent 
java class. I understand that we can load from third part but ... if 
all third community do the same way, how to maintain them in OFBiz 
without making committer crazy ?
 * I check the growerptest to control if it can be load on OFBiz 
directly, but the code don't respect the coding convention and is 
missing the minimum documentation like the xsd. I think it's really 
interesting for the both community to improve the growerptest quality

   ** For OFBiz to have an other test case
   ** For GrowErp community to improve the code quality and minimize 
the maintenance


I can read and try to improve the code but from grow erp do you want 
participate to improve some part ?


Nicolas

Le 23/10/2015 07:23, Hans Bakker a écrit :

Hi Jacques, thanks for bringing this up.

1. this changes in the framework is a pretty general one, any 
external test system can use it. It is not specific for the component 
we provided. It is actually just an example that Ruud created, on how 
you can use this 'hook'. Yes the change is not more than a 'hook'
2. We should implement more of these kind of hooks. I have another 
one: Did you ever try to create a component with its own menu system? 
We have the growerp backend as an example how to do that. Is the 
community interested in this menu hook?
3. Further, this growerptest component we provide is not a work in 
progress any more, it has the apache 2 license, can be included into 
ofbiz if you want, and as I said before, i can even provide 
peer-write access to the component for people who want to contribute.


If you have any further questions, let me know.

Regards, Hans

On 22/10/15 14:11, Jacques Le Roux wrote:

Hi,

There is a WIP in the GrowErp community on a growerptest Selenium 
component, see https://issues.apache.org/jira/browse/OFBIZ-6618


The commit r1709516 introduced a small change to have it working 
OOTB when you put it in hot-deploy


The question is: do we agree with this way of doing and let the 
GrowErp community handles the component out of OFBiz, or should we 
handle it ourselves?


Thanks for your opinions

Jacques






--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

Re: Security Permission being Viewable

[Hans Bakker]

Hi Simon,

like all screens can be listed from the screen xml files, it should also 
be possible to get the related security rules from the screen 
implementation. Security is also implemented in the related services 
what can be more difficult because related services names and operation 
can differ from the data entered on the screen.


You could replace the current security system and make it memory based 
on the screenname/action -> security group and servicename/action -> 
security group relationship. Still also a solution is needed for the 
databased  data owner security ruleswhich could be defined as a 
special action.


Just some thoughts..

Regards,
Hans

On 06/11/15 16:04, simon maskell wrote:

Hi

We are looking at ways of being able to show permissions on any page inside
Ofbiz, this will allow us to easily see how the security for a page is
managed. Liferay does this very well, from any page you are able to go into
edit mode and view how the page is setup from a security level.

Because the security permissions are hard coded in Ofbiz we are struggling
to find a way of doing this.

Has anyone got a solution for this or if other people see this as an issue
can we look to make a change to how Ofbiz does the permissions? I have no
ideas around this for the moment and I know it probably wont be a small
task!!!

Simon





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Security-Permission-being-Viewable-tp4674195.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.



--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Assigned] (OFBIZ-6708) Missing userLogin error on party profile screen when 1st content is non public

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker reassigned OFBIZ-6708:
--

Assignee: Hans Bakker

> Missing userLogin error on party profile screen when 1st content is non public
> --
>
> Key: OFBIZ-6708
> URL: https://issues.apache.org/jira/browse/OFBIZ-6708
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Hans Bakker
>Priority: Minor
>
> When a party 1st non content public the serveObjectData event is called in 
> party profile screen and it misses the userLogin in session.
> This was implemented with 
> [r1199681|http://svn.apache.org/viewvc?view=revision=1199681] ([see 
> this|http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml?r1=1199681=1199680=1199681])
>  which is a back hack. I guess the idea was if a "Logo Image URL" was 
> assigned to a party like "Company" it should be displayed in the profile 
> screen, that works w/o  error in the log. But when you have a party 1st non 
> content of other type for other parties (like admin for instance) it does not 
> make sense, and show an error in log.
> {code}
>  [java] 2015-11-03 12:05:12,856 |ttp-bio-8443-exec-11 |DataEvents 
>|E| null
>  [java] org.ofbiz.service.ServiceAuthException: User authorization is 
> required for this service: genericContentPermission
>  [java] at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:356) 
> ~[ofbiz-service.jar:?]
>  [java] at 
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:227) 
> ~[ofbiz-service.jar:?]
>  [java] at 
> org.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:88)
>  ~[ofbiz-service.jar:?]
>  [java] at 
> org.ofbiz.content.data.DataEvents.serveObjectData(DataEvents.java:139) 
> [ofbiz-content.jar:?]
>  [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method) ~[?:1.8.0_51]
>  [java] at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> ~[?:1.8.0_51]
>  [java] at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:1.8.0_51]
>  [java] at java.lang.reflect.Method.invoke(Method.java:497) 
> ~[?:1.8.0_51]
>  [java] at 
> org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:92) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> org.ofbiz.webapp.event.JavaEventHandler.invoke(JavaEventHandler.java:78) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:759) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:476) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:213) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> javax.servlet.http.HttpServlet.service(HttpServlet.java:620) 
> [servlet-api-3.0.jar:?]
>  [java] at 
> javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
> [servlet-api-3.0.jar:?]
>  [java] at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:324) 
> [ofbiz-webapp.jar:?]
>  [java] at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
>  [tomcat-7.0.64-catalina.jar:7.0.64]
>  [java] at 
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
>  [tomcat-7.0.64-catalina.j

[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981765#comment-14981765
 ] 

Hans Bakker commented on OFBIZ-6703:


so, it could well be that older versions do not need patching. 

> Cannot create more than one lead in the SFA component by same user
> --
>
> Key: OFBIZ-6703
> URL: https://issues.apache.org/jira/browse/OFBIZ-6703
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Fix For: Upcoming Branch
>
>
> Repeat steps:
> # go to SFA component and click on leads
> # click on create new
> # fill mandatory information and save
> # repeat the above steps again and observe failure
> The reason for the failure is that the implementation of the createLead 
> service tries to create a PartyRole of type OWNER every time a lead is 
> created. So it works only the first time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981756#comment-14981756
 ] 

Hans Bakker commented on OFBIZ-6703:


this was caused, because the internal check for existence was removed from the 
createPartyRole service for whatever reason, and the sfa component was not 
updated accordingly

> Cannot create more than one lead in the SFA component by same user
> --
>
> Key: OFBIZ-6703
> URL: https://issues.apache.org/jira/browse/OFBIZ-6703
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Fix For: Upcoming Branch
>
>
> Repeat steps:
> # go to SFA component and click on leads
> # click on create new
> # fill mandatory information and save
> # repeat the above steps again and observe failure
> The reason for the failure is that the implementation of the createLead 
> service tries to create a PartyRole of type OWNER every time a lead is 
> created. So it works only the first time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (OFBIZ-6703) Cannot create more than one lead in the SFA component by same user

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981756#comment-14981756
 ] 

Hans Bakker edited comment on OFBIZ-6703 at 10/30/15 2:36 AM:
--

this was caused, because the internal check for existence was removed from the 
createPartyRole service for whatever reason, and the sfa component was not 
updated accordingly if i will remember well Nicolas?


was (Author: hansbak):
this was caused, because the internal check for existence was removed from the 
createPartyRole service for whatever reason, and the sfa component was not 
updated accordingly

> Cannot create more than one lead in the SFA component by same user
> --
>
> Key: OFBIZ-6703
> URL: https://issues.apache.org/jira/browse/OFBIZ-6703
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Fix For: Upcoming Branch
>
>
> Repeat steps:
> # go to SFA component and click on leads
> # click on create new
> # fill mandatory information and save
> # repeat the above steps again and observe failure
> The reason for the failure is that the implementation of the createLead 
> service tries to create a PartyRole of type OWNER every time a lead is 
> created. So it works only the first time



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [QUESTION about OFBIZ-6618] growerptest Selenium component out or in OFBiz?

[Hans Bakker]

Hi Jacques, thanks for bringing this up.

1. this changes in the framework is a pretty general one, any external 
test system can use it. It is not specific for the component we 
provided. It is actually just an example that Ruud created, on how you 
can use this 'hook'. Yes the change is not more than a 'hook'
2. We should implement more of these kind of hooks. I have another one: 
Did you ever try to create a component with its own menu system? We have 
the growerp backend as an example how to do that. Is the community 
interested in this menu hook?
3. Further, this growerptest component we provide is not a work in 
progress any more, it has the apache 2 license, can be included into 
ofbiz if you want, and as I said before, i can even provide peer-write 
access to the component for people who want to contribute.


If you have any further questions, let me know.

Regards, Hans

On 22/10/15 14:11, Jacques Le Roux wrote:

Hi,

There is a WIP in the GrowErp community on a growerptest Selenium 
component, see https://issues.apache.org/jira/browse/OFBIZ-6618


The commit r1709516 introduced a small change to have it working OOTB 
when you put it in hot-deploy


The question is: do we agree with this way of doing and let the 
GrowErp community handles the component out of OFBiz, or should we 
handle it ourselves?


Thanks for your opinions

Jacques



--

Regards,

Hans Bakker
CEO, http://antwebsystems.com

[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14968330#comment-14968330
 ] 

Hans Bakker commented on OFBIZ-6618:


Thank you for your help in this matter and holding up further development in 
the area of continuous testing.

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>    Assignee: Hans Bakker
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker closed OFBIZ-6618.
--
Assignee: Hans Bakker  (was: Jacques Le Roux)

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>    Assignee: Hans Bakker
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> git clone https://gerrit.antwebsystems.com/growerptest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Bakker resolved OFBIZ-6618.

   Resolution: Fixed
Fix Version/s: Trunk

THank you Ruud for the patch: Committed revision 1709516

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>Assignee: Jacques Le Roux
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> git clone https://gerrit.antwebsystems.com/growerptest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966114#comment-14966114
 ] 

Hans Bakker commented on OFBIZ-6618:


Sorry Jacques, if i did not follow the rules, was not aware that you have in 
interest in this. the issue is now more than a month old, enough time for 
comments and objections?
The growerptest component is being worked on, so keeping it in our repository 
makes it easier for us. Since we are not using $windows, sure that could be a 
problem. I have asked Ruud to have a look at the problems you found.
Concerning Ant, you should use the version supplied within the OFBiz 
distribution?

Regards,
Hans

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>    Assignee: Hans Bakker
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> git clone https://gerrit.antwebsystems.com/growerptest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966137#comment-14966137
 ] 

Hans Bakker commented on OFBIZ-6618:


perhaps read this issue more closely?
make it easy for you: 
git clone https://gerrit.antwebsystems.com/growerptest
will get you a copy..

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>    Assignee: Hans Bakker
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> git clone https://gerrit.antwebsystems.com/growerptest



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OFBIZ-6618) Selenium test integration using XML files

[Hans Bakker (JIRA)]

[ 
https://issues.apache.org/jira/browse/OFBIZ-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966292#comment-14966292
 ] 

Hans Bakker commented on OFBIZ-6618:


Should we include it in ofbiz in view of the slim down actions?

I would rather go for having a wiki page with components like this one, who 
maintains them with the 'master' repository name. 
In this case i can even give peer-write access to this repository to people who 
requested it.

Regards,
Hans

> Selenium test integration using XML files
> -
>
> Key: OFBIZ-6618
> URL: https://issues.apache.org/jira/browse/OFBIZ-6618
> Project: OFBiz
>  Issue Type: Test
>  Components: framework
>Reporter: Ruud Griepsma
>    Assignee: Hans Bakker
>Priority: Minor
>  Labels: selenium, test, webdriver
> Fix For: Trunk
>
> Attachments: ModelTestSuite.patch, build.patch, test-suite.patch
>
>
> Added a new type of test, for testing with Selenium WebDriver, but without 
> writing any Java code. This will help making GUI tests quicker and easier to 
> create. Test steps and instances are defined in XML files, like example 
> below, which tests the login procedure for the admin user.
> {code}
> 
>   
>datavalue="https://localhost:8443/example/control/checkLogin/main"/>
>dataname="username"/>
>dataname="password"/>
>webobject="input[type=submit]"/>
>   
>   
>   
>   
>   
> 
> 
>   
> 
> {code}
> Git repository with example (put in 'hot-deploy' folder and check README.txt 
> file):
> {code}
> git clone https://gerrit.antwebsystems.com/growerptest
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Why A Framework Rewrite Is Necessary

[Hans Bakker]

Adrian,

That was a vote for replacing parts of the framework.

Now we are discussing replacing the ofbiz framework as a whole by moqui 
as a jar.

Leaving the framework control outside of ofbiz.

At my company we envision the future of OFBiz using Moqui and we are 
prepared to invest a number of our employees making the move.


We see no future in replacing the framework with something else 
especially a rewrite.


Regards,
Hans Bakker
http://antwebsystems.com
htttp://growerp.com



On 17/10/15 01:54, Adrian Crum wrote:

That discussion occurred in April, and a vote was taken:

http://ofbiz.135035.n4.nabble.com/VOTE-Begin-Replacing-OFBiz-Framework-With-Moqui-td4667500.html 



Adrian Crum
Sandglass Software
www.sandglass-software.com

On 10/16/2015 8:51 AM, Ron Wheeler wrote:

Is there any enthusiasm for incorporating Moqui as a separate third
party dependency into the ERP?
What is involved? Does anyone have any sort of plan for using Moqui as a
drop-in replacement for the current Framework?
A blog article would be a good start in adding some real flesh to this
idea if it makes any sense.

If there is a desire for a new OFBiz framework, we should start by
adding some details in the wiki.
I can not edit this or add comments.

Once we see how far we can get in a roadmap and functional overview, we
can start to look at sub-projects.
It is too early now as far as I can tell.

Ron

On 15/10/2015 11:31 PM, David E. Jones wrote:



On 15 Oct 2015, at 07:58, Adrian Crum
<adrian.c...@sandglass-software.com> wrote:

Keep in mind that much of David's code in OFBiz has been rewritten.
So yes, we CAN do a better job than him.

I think there’s a name for this logical fallacy…


Also keep in mind that Moqui duplicates some of the problems I listed
- so by using Moqui, we keep the same problems instead of fixing them.

Could you be more specific, other than the type conversion stuff you
mentioned many years ago (which I fully disagree with)?

-David



On the other hand, it is David's responsibility to fix them, not ours.

If we created a sub-project, then we would have the opportunity to
review committer permissions and perhaps restrict access to the new
code.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 10/15/2015 6:34 AM, Al Byers wrote:

I was waiting for someone to bring this up. David Jones created
Moqui with
the same end in mind that the rewrite is meant to accomplish. Do you
think
that you will do a better job than him? Even if you could, would it
be so
much better that it warrants the effort that it would take?

Is this a political thing? I don't know that David would give up
control of
Moqui Core and I, for one, would not want him to. So many of OFBiz's
problems are the result of ineptitude on the part of committers who
did not
know what they were doing (like me.) But I don't know that the Core
will
change all that much going forward and there should be places in the
Mantle
to contribute and, most certainly, in the Crust.

I know that there were some valid questions about licensing and 
project

management, but I would think that they could be worked out.

On Thu, Oct 15, 2015 at 4:46 AM, Hans Bakker
<h.bak...@antwebsystems.com>
wrote:


Why not skip this step, using moqui which is already up and running
and
then as Adrian states as a next step: applications could be pulled
down and
adapted to it.

Hans



On 15/10/15 16:51, Jacques Le Roux wrote:


I'm in the same mood than Paul and Scott. So a sub-project could
indeed
be a solution.

Jacques

Le 15/10/2015 03:11, Adrian Crum a écrit :


I agree that a sub-project would be nice to have. Once the new
framework
is up and running, applications could be pulled down and adapted
to it.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 10/14/2015 5:53 PM, Ron Wheeler wrote:


This seems to be very good advice.
A completely separate sub-project under OFBiz with its own
mailing lists
would keep the people together yet all allow the new framework 
the

flexibility to move forward.

Ron
On 14/10/2015 8:27 PM, Scott Gray wrote:


My advice is as follows:
1. If people are interested, then get them together and start
working
on it.
2. Find somewhere to do the work.  I don't think a branch is
appropriate
because it's completely new development rather than a
refactoring.  I
don't
have any objections to it being done under the ASF OFBiz 
umbrella

(although
I don't really see the need either).
3. Set up a separate mailing list for discussion.  Generally
I'd try
and
keep quiet about it in the early stages on the dev/user lists
or other
marketing channels because it could potentially harm adoption
of our
existing framework (think AngularJS 2.0).

There really isn't any need to get early stage sign-off from
the PMC or
anyone else in the community.  You only need enough PMC
approval to
get the
required infrastructure sorted, which I don't think would be an
issue.
>From there, it's really up to the community to decide whether
o