Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
On 10/18/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: gvanmatre Date: Wed Oct 18 16:37:05 2006 New Revision: 465422 URL: http://svn.apache.org/viewvc?view=revrev=465422 Log: This is a fix for the Clay implicit anchored tag mapping that was not assigning the href to the component's value attribute. It was reported by Torsten Krah (SHALE-313). Added: shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/ImplicitMappingTestCase.java (with props) shale/framework/trunk/shale-clay/src/test/resources/org/apache/shale/clay/config/implicit.html (with props) snip/ Gary, can you please add ASLv2 headers to new files? Don't worry about these two -- as part of my todo list, I'm planning on adding them to any missing source files (my guess would be we're missing these in quite a few files, probably all in the test and site docs categories. I plan to drop in the headers when I get a chance since these tend to get packaged in the source distributions -- unless these are objections to doing so). -Rahul
Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
From: Rahul Akolkar [EMAIL PROTECTED] On 10/18/06, [EMAIL PROTECTED] wrote: Author: gvanmatre Date: Wed Oct 18 16:37:05 2006 New Revision: 465422 URL: http://svn.apache.org/viewvc?view=revrev=465422 Log: This is a fix for the Clay implicit anchored tag mapping that was not assigning the href to the component's value attribute. It was reported by Torsten Krah (SHALE-313). Added: shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/Impl icitMappingTestCase.java (with props) shale/framework/trunk/shale-clay/src/test/resources/org/apache/shale/clay/config /implicit.html (with props) Gary, can you please add ASLv2 headers to new files? Don't worry about these two -- as part of my todo list, I'm planning on adding them to any missing source files (my guess would be we're missing these in quite a few files, probably all in the test and site docs categories. I plan to drop in the headers when I get a chance since these tend to get packaged in the source distributions -- unless these are objections to doing so). I did add svn:eol-style of native. What other options do we need for test cases and html resources? I figured that svn:keywords wouldn't apply to these types of resources? -Rahul Gary
Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
On 10/20/06, Gary VanMatre [EMAIL PROTECTED] wrote: From: Rahul Akolkar [EMAIL PROTECTED] On 10/18/06, [EMAIL PROTECTED] wrote: Author: gvanmatre Date: Wed Oct 18 16:37:05 2006 New Revision: 465422 URL: http://svn.apache.org/viewvc?view=revrev=465422 Log: This is a fix for the Clay implicit anchored tag mapping that was not assigning the href to the component's value attribute. It was reported by Torsten Krah (SHALE-313). Added: shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/Impl icitMappingTestCase.java (with props) shale/framework/trunk/shale-clay/src/test/resources/org/apache/shale/clay/config /implicit.html (with props) Gary, can you please add ASLv2 headers to new files? Don't worry about these two -- as part of my todo list, I'm planning on adding them to any missing source files (my guess would be we're missing these in quite a few files, probably all in the test and site docs categories. I plan to drop in the headers when I get a chance since these tend to get packaged in the source distributions -- unless these are objections to doing so). I did add svn:eol-style of native. What other options do we need for test cases and html resources? I figured that svn:keywords wouldn't apply to these types of resources? snip/ I was actually mentioning the missing ASF license header (that should be at the top of source files) in that comment. As far as svn props are concerned, I add keywords to (java) test cases and html resources (I think we should), but the comment above isn't about svn props. -Rahul -Rahul Gary
Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
From: Rahul Akolkar [EMAIL PROTECTED] On 10/20/06, Gary VanMatre wrote: From: Rahul Akolkar On 10/18/06, [EMAIL PROTECTED] wrote: Author: gvanmatre Date: Wed Oct 18 16:37:05 2006 New Revision: 465422 URL: http://svn.apache.org/viewvc?view=revrev=465422 Log: This is a fix for the Clay implicit anchored tag mapping that was not assigning the href to the component's value attribute. It was reported by Torsten Krah (SHALE-313). Added: shale/framework/trunk/shale-clay/src/test/java/org/apache/shale/clay/config/Impl icitMappingTestCase.java (with props) shale/framework/trunk/shale-clay/src/test/resources/org/apache/shale/clay/config /implicit.html (with props) Gary, can you please add ASLv2 headers to new files? Don't worry about these two -- as part of my todo list, I'm planning on adding them to any missing source files (my guess would be we're missing these in quite a few files, probably all in the test and site docs categories. I plan to drop in the headers when I get a chance since these tend to get packaged in the source distributions -- unless these are objections to doing so). I did add svn:eol-style of native. What other options do we need for test cases and html resources? I figured that svn:keywords wouldn't apply to these types of resources? I was actually mentioning the missing ASF license header (that should be at the top of source files) in that comment. As far as svn props are concerned, I add keywords to (java) test cases and html resources (I think we should), but the comment above isn't about svn props. -Rahul Cool, I'll add it to the java source but adding it to the html resource would mess with what is being tested. -Rahul Gary
Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
On 10/20/06, Gary VanMatre [EMAIL PROTECTED] wrote: From: Rahul Akolkar [EMAIL PROTECTED] snip/ I was actually mentioning the missing ASF license header (that should be at the top of source files) in that comment. As far as svn props are concerned, I add keywords to (java) test cases and html resources (I think we should), but the comment above isn't about svn props. -Rahul Cool, I'll add it to the java source but adding it to the html resource would mess with what is being tested. snap/ Thanks. On the html resources front, I'd have thought we can drop the license in a html comment between the clay:remove start and end comments at the beginning and not affect what is being tested at all? I can do that (though won't be immediate), if its OK with you and others. -Rahul -Rahul Gary
Re: svn commit: r465422 - in /shale/framework/trunk/shale-clay/src: main/java/org/apache/shale/clay/parser/builder/ test/java/org/apache/shale/clay/config/ test/resources/org/apache/shale/clay/config/
From: Rahul Akolkar [EMAIL PROTECTED] On 10/20/06, Gary VanMatre wrote: From: Rahul Akolkar I was actually mentioning the missing ASF license header (that should be at the top of source files) in that comment. As far as svn props are concerned, I add keywords to (java) test cases and html resources (I think we should), but the comment above isn't about svn props. -Rahul Cool, I'll add it to the java source but adding it to the html resource would mess with what is being tested. Thanks. On the html resources front, I'd have thought we can drop the license in a html comment between the clay:remove start and end comments at the beginning and not affect what is being tested at all? I can do that (though won't be immediate), if its OK with you and others. The problem in doing that for the test cases is that we are actually testing parsing the document. Since Clay has it's own markup parser that works for html and xml documents, there are tests to make sure the parser will handle comments. I'm not against adding the text to the templates within the remove blocks since it will actually make the test more extensive but it does broaden the scope of the test. The clay:remove is a new feature that was added in the 1.0.4-SNAPSHOT. We might as well make use of it. -Rahul Gary -Rahul Gary
