Re: Regression in s:url tag
2011/2/16 Jason Pyeron jpye...@pdinc.us: The s:url var=url escapeAmp=false/ execution used to produce (in 2.1.6) http://host/app/action!method and now produces http://host/app/action.xhtml droping the method in 2.2.1.1 Could you show the whole code example ? Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
RE: Regression in s:url tag
-Original Message-
From: Lukasz Lenart
Sent: Thursday, February 17, 2011 6:20
To: Struts Developers List
Subject: Re: Regression in s:url tag
2011/2/16 Jason Pyeron jpye...@pdinc.us:
The s:url var=url escapeAmp=false/ execution used to
produce (in
2.1.6) http://host/app/action!method and now produces
http://host/app/action.xhtml droping the method in 2.2.1.1
Could you show the whole code example ?
// this is a sensitive project, I am removing parts, that are not relevant.
public class IpAction extends ActionSupport implements Preparable ,
ServletRequestAware
{
// snip
public String index()
{
//snip
ipList=IpAddress.getList(session, new CriteriaBuilder(){
@Override
public Criteria process(Criteria x)
{
return x
// .setFetchMode(vlan,
FetchMode.JOIN)
.setFetchMode(nic, FetchMode.JOIN)
.setFetchMode(nic.device, FetchMode.JOIN)
.setFetchMode(nic.device.domain,
FetchMode.JOIN)
;
}});
return SUCCESS;
}
public String novlan()
{
//snip
ipList=IpAddress.getList(session, new CriteriaBuilder(){
@Override
public Criteria process(Criteria x)
{
// TODO Auto-generated method stub
return x
.add(Restrictions.isEmpty(vlan))
.setFetchMode(nic, FetchMode.JOIN)
.setFetchMode(nic.device, FetchMode.JOIN)
.setFetchMode(nic.device.domain,
FetchMode.JOIN)
;
}});
return SUCCESS;
}
}
ip.jsp:
%@ page language=java contentType=text/html; charset=ISO-8859-1
pageEncoding=ISO-8859-1%
%@ taglib prefix=s uri=/struts-tags %
%@ taglib uri=http://displaytag.sf.net; prefix=display %
html
head
titles:property value=#title //title
/head
body
s:url var=url escapeAmp=false/
div id=container
display:table id=ipList name=ipList
requestURI='%=((String)request.getAttribute(url)) %' class=tablesorter
sort=list pagesize=25
display:column property=ipAddress title=Ip address
sortable=true /
display:column property=nic.device.hostname
title=Host name sortable=true href=device!info paramId=device.id
paramProperty=nic.device.id /
display:column property=nic.device.domain.name
title=Domain name sortable=true href=device!info paramId=device.id
paramProperty=nic.device.id /
display:column property=nic.device.assetTag
title=Asset tag sortable=true href=device!info paramId=device.id
paramProperty=nic.device.id /
/display:table
/div
/body
/html
Kind regards
--
Lukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapitula Javarsovia http://javarsovia.pl
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For
additional commands, e-mail: dev-h...@struts.apache.org
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100-
- +1 (443) 269-1555 x333Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
2011/2/17 Wendy Smoak wsm...@gmail.com: As release manager you can frame the vote however you want. If you have specific reasons for calling it a Beta release (unfinished feature, API not yet locked down,) then you can mention them. It's unlikely the rest of the dev team will revolt and insist on labeling it GA. ;) OK, thanks :-) The convention here (decided long ago) is to use plain numbered versions like 2.3.4 and apply a quality label to them later. It's not clear whether you want to change that, but if so I'd suggest digging back through the archives to understand why it was done and then starting a separate thread to discuss. The answer is simple: I'm using Maven for development basis and it's easy for me to switch between versions. I don't need to go to a web page to check if 2.2.2 is a Beta or GA. I see it just in my pom. Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
W dniu 17 lutego 2011 16:07 użytkownik Dave Newton davelnew...@gmail.com napisał: Why not RCn? Fine for me, RC or Beta it's just a signal to community, work in progress, stay tune Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
On Thu, Feb 17, 2011 at 10:01 AM, Lukasz Lenart lukasz.len...@googlemail.com wrote: The answer is simple: I'm using Maven for development basis and it's easy for me to switch between versions. I don't need to go to a web page to check if 2.2.2 is a Beta or GA. I see it just in my pom. But does it matter? If you've tested it and it works for your project, who cares what the Struts developers think. ;) One of the reasons it was done is to eliminate double work. If you use version 5.4.3-Beta for a while and decide that it's GA, then you have to re-do the release process to re-label the artifacts, and do another round of testing. Ditto with RC1, RC2, once you decide this is the one then you have to re-do the process one last time. Once upon a time, this method of versioning had the happy side effect of letting some of use more bleeding edge versions in production, since we could say to the powers that be with a straight face, I'm using version 3.8.2 and just... not mention... that it's only a beta version. ;) Another is that it's hard to know whether something is *really* GA until it gets beat on for a while. Sure we tested as much as we could, but it's much easier to promote something after a couple of weeks than is to have to retract a GA release that turned out to have a fatal flaw. Anyway... I don't have a dog in this fight anymore, but if you want to change the versioning scheme then start a new thread with a [PROPOSAL]. -- Wendy - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
2011/2/17 Wendy Smoak wsm...@gmail.com: But does it matter? If you've tested it and it works for your project, who cares what the Struts developers think. ;) No, but it gives me a clear signal what can be the origin of my problem. One of the reasons it was done is to eliminate double work. If you use version 5.4.3-Beta for a while and decide that it's GA, then you have to re-do the release process to re-label the artifacts, and do another round of testing. Ditto with RC1, RC2, once you decide this is the one then you have to re-do the process one last time. It isn't a problem anymore, with Nexus on our side is just few steps to prepare a release ;-) Another is that it's hard to know whether something is *really* GA until it gets beat on for a while. Sure we tested as much as we could, but it's much easier to promote something after a couple of weeks than is to have to retract a GA release that turned out to have a fatal flaw. Yep, that's the one of the reasons I have, another is that we fixed 41 bugs of total 50 assigned to 2.2.2 version. The most important are done, the rest is related to JSONPlugin (not everyone uses) or development improvement. Few users requested a new release, especially that the most important bugs are done. So I can just postpone those bugs and prepare a new release or start a new thread about changing labeling. Hmmm preparing a new release will be faster ;-) Besides it's more about promoting a release. I was asking about that sometime ago. It would be great to promote Betas or RCs without calling for a Vote. I was looking for that discussion about labeling but didn't find, could you help and point to the right direction ? Maybe it was on PMC group ? Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: Broken web site link
2011/2/12 John Lindal lind...@yahoo-inc.com: Urk. All the links under Modules are also broken. Did a large chunk get left out of the latest site build of 2.2.2.1? It's there in 2.2.1 and older versions. I think, it never worked ;-) It's related how assembly packages are prepared, but it's hard for me to test them. Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: XWork maven-shade-plugin configuation
And throwing support for JDK 1.4, there are still some parts about that in poms Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
s:url tag namespace attribute not respected
Another s:url quirk:
In a jsp firstPage.jsp residing in namespace /first if you use a s:uri
tag to create an action url for action go-to-second-page om
namespace /second S2 gives a warning
No configuration found for the specified action:
'/second/go-to-second-page.action' in namespace: '/first'
and fails to find the action.
In short,
s:form action=go-to-second-page namespace=/second
...
/s:form
is not equivalent to
s:url id=myURL action=go-to-second-page namespace=/second
includeContext=false /
s:form action=%{myURL}
...
/s:form
==demo
struts.xml:
?xml version=1.0 encoding=UTF-8 ?
!DOCTYPE struts PUBLIC
-//Apache Software Foundation//DTD Struts Configuration 2.0//EN
http://struts.apache.org/dtds/struts-2.0.dtd;
struts
constant name=struts.devMode value=true /
constant name=struts.convention.action.disableScanning
value=true /
package name=one namespace=/first extends=struts-default
action name=firstPage
result/WEB-INF/content/first/firstPage.jsp/result
/action
/package
package name=two namespace=/second extends=struts-default
action name=go-to-second-page
result/WEB-INF/content/second/success.jsp/result
/action
/package
/struts
===
/WEB-INF/content/first/firstPage.jsp
%@ taglib prefix=s uri=/struts-tags%
html
body
h3
Page 1
/h3
div
s:form action=go-to-second-page namespace=/second
s:textfield label=Title name=title
size=30 maxlength=30 /
s:submit value=Go to success page /
/s:form
/div
hr/
div
s:url id=myURL action=go-to-second-page
namespace=/second
includeContext=false /
s:form action=%{myURL}
s:textfield label=Title name=title
size=30 maxlength=30 /
s:submit value=Go to success page /
/s:form
/div
/body
/html
//=
/WEB-INF/content/second/success.jsp
html
body
div
h3
Success!!
/h3
/div
/body
/html
//
web.xml
?xml version=1.0 encoding=UTF-8?
web-app xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xmlns=http://java.sun.com/xml/ns/javaee;
xmlns:web=http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd;
xsi:schemaLocation=http://java.sun.com/xml/ns/javaee
http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd;
id=WebApp_ID version=2.5
display-nameS:URL/display-name
filter
filter-namestruts2/filter-name
filter-class
org.apache.struts2.dispatcher.ng.filter.StrutsPrepareAndExecuteFilter/filter-class
/filter
filter-mapping
filter-namestruts2/filter-name
url-pattern/*/url-pattern
/filter-mapping
welcome-file-list
welcome-fileindex.html/welcome-file
/welcome-file-list
/web-app
//==
index.html
!DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.0 Transitional//EN
html
head
META HTTP-EQUIV=Refresh CONTENT=0;URL=first/firstPage
/head
body
pLoading .../p
/body
/html
===
Cheers
Chris
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
On Thu, Feb 17, 2011 at 10:35 AM, Lukasz Lenart lukasz.len...@googlemail.com wrote: I was looking for that discussion about labeling but didn't find, could you help and point to the right direction ? Maybe it was on PMC group ? I poked around on MarkMail and found some discussion in late 2004. Try this: http://struts.markmail.org/search/?q=release%20version#query:release%20version%20list%3Aorg.apache.struts.dev%20date%3A200308-200504%20+page:1+mid:byisn6isnyq25lsr+state:results Besides it's more about promoting a release. I was asking about that sometime ago. It would be great to promote Betas or RCs without calling for a Vote. What do you mean? -- Wendy - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
RE: Regression in s:url tag [interim workaround]
-Original Message-
From: Jason Pyeron
Sent: Thursday, February 17, 2011 7:53
To: 'Struts Developers List'
Subject: RE: Regression in s:url tag
-Original Message-
From: Lukasz Lenart
Sent: Thursday, February 17, 2011 6:20
To: Struts Developers List
Subject: Re: Regression in s:url tag
2011/2/16 Jason Pyeron jpye...@pdinc.us:
The s:url var=url escapeAmp=false/ execution used to produce (in
2.1.6) http://host/app/action!method and now produces
http://host/app/action.xhtml droping the method in 2.2.1.1
My kludge / workaround, for now. I am going to track down when the regression
really happened this week end.
+ private String method;
+ public String getMethod(){return method;}
+
+
@@ -131,6 +141,7 @@
public String index()
{
+ try{
@@ -149,10 +160,16 @@
return SUCCESS;
+ }
+ finally
+ {
+ method=index;
+ }
}
public String novlan()
{
+ try{
@@ -173,18 +190,30 @@
return SUCCESS;
+ }
+ finally
+ {
+ method=novlan;
+ }
}
public String input()
{
And then
-s:url var=url escapeAmp=false/
+s:url var=url method=%{method} escapeAmp=false/
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100-
- +1 (443) 269-1555 x333Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
-Original Message-
From: Jason Pyeron [mailto:jpye...@pdinc.us]
Sent: Thursday, February 17, 2011 7:53
To: 'Struts Developers List'
Subject: RE: Regression in s:url tag
-Original Message-
From: Lukasz Lenart
Sent: Thursday, February 17, 2011 6:20
To: Struts Developers List
Subject: Re: Regression in s:url tag
2011/2/16 Jason Pyeron jpye...@pdinc.us:
The s:url var=url escapeAmp=false/ execution used to
produce (in
2.1.6) http://host/app/action!method and now produces
http://host/app/action.xhtml droping the method in 2.2.1.1
Could you show the whole code example ?
// this is a sensitive project, I am removing parts, that are
not relevant.
public class IpAction extends ActionSupport implements
Preparable , ServletRequestAware { // snip
public String index()
{
//snip
ipList=IpAddress.getList(session, new CriteriaBuilder(){
@Override
public Criteria process(Criteria x)
{
return x
// .setFetchMode(vlan,
FetchMode.JOIN)
.setFetchMode(nic, FetchMode.JOIN)
.setFetchMode(nic.device,
FetchMode.JOIN)
.setFetchMode(nic.device.domain,
FetchMode.JOIN)
;
}});
return SUCCESS;
}
public String novlan()
{
//snip
ipList=IpAddress.getList(session, new CriteriaBuilder(){
@Override
public Criteria process(Criteria x)
{
// TODO Auto-generated method stub
return x
.add(Restrictions.isEmpty(vlan))
.setFetchMode(nic, FetchMode.JOIN)
.setFetchMode(nic.device,
FetchMode.JOIN)
.setFetchMode(nic.device.domain,
FetchMode.JOIN)
;
}});
return SUCCESS;
}
}
ip.jsp:
%@ page language=java contentType=text/html; charset=ISO-8859-1
pageEncoding=ISO-8859-1%
%@ taglib prefix=s uri=/struts-tags % %@ taglib
uri=http://displaytag.sf.net; prefix=display % html
head titles:property value=#title //title /head
body s:url var=url escapeAmp=false/
div id=container
display:table id=ipList name=ipList
requestURI='%=((String)request.getAttribute(url)) %'
class=tablesorter
sort=list pagesize=25
display:column property=ipAddress
title=Ip address
sortable=true /
display:column property=nic.device.hostname
title=Host name sortable=true href=device!info
paramId=device.id
paramProperty=nic.device.id /
Re: A new release
On Thu, Feb 17, 2011 at 7:35 AM, Lukasz Lenart lukasz.len...@googlemail.com wrote: 2011/2/17 Wendy Smoak wsm...@gmail.com: snip/ Yep, that's the one of the reasons I have, another is that we fixed 41 bugs of total 50 assigned to 2.2.2 version. The most important are done, the rest is related to JSONPlugin (not everyone uses) or development improvement. Few users requested a new release, especially that the most important bugs are done. So I can just postpone those bugs and prepare a new release or start a new thread about changing labeling. Hmmm preparing a new release will be faster ;-) Yup, especially since you will find me *extremely* hard to convince. :-) Besides it's more about promoting a release. I was asking about that sometime ago. It would be great to promote Betas or RCs without calling for a Vote. There is no such thing as a release without a vote. Every release must be voted on by the PMC, no exceptions. It doesn't matter how it's labeled. Just to be clear, we start by building what we call a Test Build, with the latest 3-part number. That Test Build is made available to developers (i.e. dev@ only). After it's been available for long enough that people have had a chance to determine how stable it is, we vote on whether it should become a Beta release, a GA release, or not a release at all. As Wendy has implied, we vote on actual bits. That means that if we had created a build as an RC, we would need to vote on it to release the RC, and if everyone thought it was good enough to be GA, we would need to re-roll the release with the new name (i.e. not RC now), and vote on it *again*, because the bits are different. I don't think that's what you want. Having been Release Manager for about a dozen releases of Struts over the years (not counting test builds that didn't make releases), including through the transition from the old scheme to the new one, I can tell you, you don't want to go back. -- Martin Cooper I was looking for that discussion about labeling but didn't find, could you help and point to the right direction ? Maybe it was on PMC group ? Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: A new release
On Mon, Jan 31, 2011 at 10:52 PM, Lukasz Lenart lukasz.len...@googlemail.com wrote: 2011/1/31 Paul Benedict pbened...@apache.org: He he.. I'll give you the answer that I got whenever I wanted to do beta releases. Votes determine the quality of the release, not the version label. So 2.2.2 could be production if it's voted that way. When you put out your vote, ask: [ ] GA [ ] Beta [ ] Alpha If it's GA, it's production. Otherwise, beta can be published too. Alpha will just stay a developer build. It's quite uncommon, thanks Paul :-) Actually, it's not. If you look around even just the ASF, you'll find that a number of the best-known ASF projects use this same scheme. In fact, we didn't invent it, we adopted it from those projects. -- Martin Cooper Kind regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ Kapituła Javarsovia http://javarsovia.pl - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
