Re: google-re2 pacakge update and facebook vs google python bindings ?
On Mon, 4 Mar 2024, Fabio Valentini wrote: Since this update was stuck and obviously broken, with no response from Paul in over a week (either here or on the bodhi update), I've used my provenpackager rights to revert the commits in dist-git and unpush the stuck update (it failed gating tests, so it never made it to rawhide repos). This should prevent the broken update from accidentally getting pushed to Rawhide again, and it gives an opportunity to re-do the conversion to rpmautospec correctly (i.e. "rpmautospec convert" to preserve the old changelog) if that is desirable. Thanks and sorry for dropping the ball. Last week there were issues getting the sidetag and this week it got lost in IETF deadline work. I'll try to pick this up ASAP via the sidetag. Paul -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
On Sat, Feb 24, 2024 at 5:15 PM Fabio Valentini wrote: > > On Sat, Feb 24, 2024 at 11:49 AM Michael J Gruber > wrote: > > > > Am Sa., 24. Feb. 2024 um 03:37 Uhr schrieb Adam Williamson > > : > > > > > > On Fri, 2024-02-23 at 13:36 -0500, Paul Wouters wrote: > > > > On Wed, 7 Feb 2024, Ben Beasley wrote: > > > > > > > > > Subject: Re: google-re2 pacakge update and facebook vs google python > > > > > bindings > > > > > > > > I haven't heard back from any of the maintainers. > > > > > > > > I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the > > > > first step towards getting python-google-re2 working. > > > > > > > > https://src.fedoraproject.org/rpms/re2/pull-request/6 > > > > > > You now seem to have just built re2 for Rawhide without any of the > > > deps: > > > > > > https://bodhi.fedoraproject.org/updates/FEDORA-2024-daa3669e4d > > > > > > that's not how you're supposed to do things, these days. You should > > > build re2 on a side tag and then get all the deps rebuilt on the same > > > side tag, then create a combined update. The update failed tests > > > because of this. > > > > > > The best thing to do at this point would be to create a side tag, bump > > > re2 and do a new build on the side tag, then ask maintainers of > > > dependencies and/or provenpackagers to rebuild the dependencies on the > > > side tag. > > > -- Since this update was stuck and obviously broken, with no response from Paul in over a week (either here or on the bodhi update), I've used my provenpackager rights to revert the commits in dist-git and unpush the stuck update (it failed gating tests, so it never made it to rawhide repos). This should prevent the broken update from accidentally getting pushed to Rawhide again, and it gives an opportunity to re-do the conversion to rpmautospec correctly (i.e. "rpmautospec convert" to preserve the old changelog) if that is desirable. Fabio -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
On Sat, Feb 24, 2024 at 11:49 AM Michael J Gruber wrote: > > Am Sa., 24. Feb. 2024 um 03:37 Uhr schrieb Adam Williamson > : > > > > On Fri, 2024-02-23 at 13:36 -0500, Paul Wouters wrote: > > > On Wed, 7 Feb 2024, Ben Beasley wrote: > > > > > > > Subject: Re: google-re2 pacakge update and facebook vs google python > > > > bindings > > > > > > I haven't heard back from any of the maintainers. > > > > > > I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the > > > first step towards getting python-google-re2 working. > > > > > > https://src.fedoraproject.org/rpms/re2/pull-request/6 > > > > You now seem to have just built re2 for Rawhide without any of the > > deps: > > > > https://bodhi.fedoraproject.org/updates/FEDORA-2024-daa3669e4d > > > > that's not how you're supposed to do things, these days. You should > > build re2 on a side tag and then get all the deps rebuilt on the same > > side tag, then create a combined update. The update failed tests > > because of this. > > > > The best thing to do at this point would be to create a side tag, bump > > re2 and do a new build on the side tag, then ask maintainers of > > dependencies and/or provenpackagers to rebuild the dependencies on the > > side tag. > > -- > > Also, the commit introduced a switch to autochangelog, which should be > the maintainer's decision, and is best done in a separate commit > before the bump. Besides, the changelog file was not committed to > dist-git. Did this just erase all changelog history from the rpm? Yes, this was done incorrectly (both the uncoordinated non-side-tag build *and* the conversion to rpmautospec) ... I would suggest somebody revert the two commits in git for now. Fabio -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
Am Sa., 24. Feb. 2024 um 03:37 Uhr schrieb Adam Williamson : > > On Fri, 2024-02-23 at 13:36 -0500, Paul Wouters wrote: > > On Wed, 7 Feb 2024, Ben Beasley wrote: > > > > > Subject: Re: google-re2 pacakge update and facebook vs google python > > > bindings > > > > I haven't heard back from any of the maintainers. > > > > I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the > > first step towards getting python-google-re2 working. > > > > https://src.fedoraproject.org/rpms/re2/pull-request/6 > > You now seem to have just built re2 for Rawhide without any of the > deps: > > https://bodhi.fedoraproject.org/updates/FEDORA-2024-daa3669e4d > > that's not how you're supposed to do things, these days. You should > build re2 on a side tag and then get all the deps rebuilt on the same > side tag, then create a combined update. The update failed tests > because of this. > > The best thing to do at this point would be to create a side tag, bump > re2 and do a new build on the side tag, then ask maintainers of > dependencies and/or provenpackagers to rebuild the dependencies on the > side tag. > -- Also, the commit introduced a switch to autochangelog, which should be the maintainer's decision, and is best done in a separate commit before the bump. Besides, the changelog file was not committed to dist-git. Did this just erase all changelog history from the rpm? Michael -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
On Fri, 2024-02-23 at 13:36 -0500, Paul Wouters wrote: > On Wed, 7 Feb 2024, Ben Beasley wrote: > > > Subject: Re: google-re2 pacakge update and facebook vs google python > > bindings > > I haven't heard back from any of the maintainers. > > I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the > first step towards getting python-google-re2 working. > > https://src.fedoraproject.org/rpms/re2/pull-request/6 You now seem to have just built re2 for Rawhide without any of the deps: https://bodhi.fedoraproject.org/updates/FEDORA-2024-daa3669e4d that's not how you're supposed to do things, these days. You should build re2 on a side tag and then get all the deps rebuilt on the same side tag, then create a combined update. The update failed tests because of this. The best thing to do at this point would be to create a side tag, bump re2 and do a new build on the side tag, then ask maintainers of dependencies and/or provenpackagers to rebuild the dependencies on the side tag. -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @ad...@fosstodon.org https://www.happyassassin.net -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
On Wed, 7 Feb 2024, Ben Beasley wrote: Subject: Re: google-re2 pacakge update and facebook vs google python bindings I haven't heard back from any of the maintainers. I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the first step towards getting python-google-re2 working. https://src.fedoraproject.org/rpms/re2/pull-request/6 Paul -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: google-re2 pacakge update and facebook vs google python bindings ?
I’m not aware of anything in grpc that would require re2 to be held back. If there is, I’d hope it could be resolved. An impact check in COPR would be wise for any update. I’ve CC’d the appropriate aliases to make sure *all* of the maintainers of the re2 and python-fb-re2 packages are aware of this conversation. On 2/6/24 13:36, Paul Wouters wrote: Hi, At $dayjob we are running into issues with re2 and python bindings. Fedora has a fairly old version of re2 with so.9 while upstream is at so.11. Is there a reason for this? If it is just time, I'd like to help bumping the package in rawhide. Originally, facebook creating python bindings for this, which are packaged in python-fb-re2, but this package is no longer updated as google're2 now has native python bindings (I think the fb one was pulled in and maintained and so the fb one is abandoned upsteam) I'd like to see: - google-re2 updated to version 2024-02-04 - python3-google-re2 python bindings shipped, providing the fb-re2 package. - python2-fb-re2 retired Currently, the google-re2 python bindings do not compile against the older google-re2 we ship (but that might be a fairly trivial fix, that would need to be done for the branches anyway) Added package maintainers to the CC: for additional input. Again, happy to help if time/effort is the only thing holding this back. If there are other reasons for this, I'd very much like to know more. I know there were soname issues in the past. Packages that would be affected by the soname bump: loaty dnsdist frr grpc libarrow mtxclient onnxruntime perl-re-engine-RE2 python3-fb-re2 python3-grpcio python3-onnxruntime qt5-qtwebengine syslog-ng syslog-ng-opentelemetry Thanks, Paul -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
