Re: [elinks-dev] increased risk of ECMAScript crashes in ELinks 0.11.3.GIT
Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Wed, May 30, 2007: > Jonas Fonseca <[EMAIL PROTECTED]> writes: > > > Ok, thanks for the warning, however, I thought that I expressed that I > > do not really consider ECMAScript related crashes as something to worry > > about for the current stable version. > > 2007-05-27: > fonseca: Should bug 755 be fixed in 0.11.3.GIT or 0.11.4.GIT? > paakku: I don't really care about ECMAScript bugs. > > Crashes caused by dangling pointers may be exploitable (unlike > crashes caused by null pointers). I think they should be fixed > regardless of whether they occur in ECMAScript support or > elsewhere in ELinks. And I especially don't want to become > responsible of making a release crash more than the previous one. Fair enough. I guess my reason for not caring stems from the feeling of ECMAScript being pushed too soon before it was even half decent. Perhaps those days are over. ;) > > I will try to find time to release 0.11.4 in the start of June. > > I don't think I'll be able to fix things properly before that, > so I have now reverted the two commits from elinks-0.11. Ok, cool. Will try to find time to do the preparations for .4 -- Jonas Fonseca ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] increased risk of ECMAScript crashes in ELinks 0.11.3.GIT
Jonas Fonseca <[EMAIL PROTECTED]> writes: > Ok, thanks for the warning, however, I thought that I expressed that I > do not really consider ECMAScript related crashes as something to worry > about for the current stable version. 2007-05-27: fonseca: Should bug 755 be fixed in 0.11.3.GIT or 0.11.4.GIT? paakku: I don't really care about ECMAScript bugs. Crashes caused by dangling pointers may be exploitable (unlike crashes caused by null pointers). I think they should be fixed regardless of whether they occur in ECMAScript support or elsewhere in ELinks. And I especially don't want to become responsible of making a release crash more than the previous one. > I will try to find time to release 0.11.4 in the start of June. I don't think I'll be able to fix things properly before that, so I have now reverted the two commits from elinks-0.11. pgpdww1so9UiP.pgp Description: PGP signature ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
Re: [elinks-dev] increased risk of ECMAScript crashes in ELinks 0.11.3.GIT
Kalle Olavi Niemitalo <[EMAIL PROTECTED]> wrote Tue, May 29, 2007: > Fonseca, if you release ELinks 0.11.4 soon, please revert > these commits first: > > 644908c130210ed7b17a3bd1241244576b94c546 > Garbage-collect SMJS objects before flushing caches. > > 5a49b9f14d4b8bb30bfada4958c22e6a8cfab21e > NEWS: mention bug 951 > > The extra garbage collections increase the risk of crashing > because of dangling pointers in form_state.ecmascript_obj. > This bug has been fixed in commit > b4d9b7f5a60a64a26fcfffcb66a376cae5b31bc1 in ELinks 0.12.GIT. > I am going to add the bug to bugzilla.elinks.cz (it is not the > same as bug 755, which is about pointers _to_ struct form_state) > and then backport that commit to 0.11.3.GIT (or 0.11.4.GIT). > The fix in 0.12.GIT is not entirely correct (it breaks object > identity comparisons) but fixing the bug properly will take > some time and I think it is more important now to remove the > risk of crashing. Ok, thanks for the warning, however, I thought that I expressed that I do not really consider ECMAScript related crashes as something to worry about for the current stable version. I will try to find time to release 0.11.4 in the start of June. -- Jonas Fonseca ___ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
