Possible patches
Hello devs, I've created a patchset[1] to try to improve the way fvwm looks. I've been using it for a while and made various themes and it seems to work ok. Some of it is inefficient and incomplete, but I can clean it up if you want. I was wondering if you were interested in any of the features for the main branch. I'm not sure what can be added before 2.6/3.0 so I haven't planned on commiting but some of the patches are quite small and might be worth a look. [1] http://abdn.ac.uk/~u15dm4/fvwm/
Re: Possible patches
On 6/6/06, David Maciver [EMAIL PROTECTED] wrote: Hello devs, I've created a patchset[1] to try to improve the way fvwm looks. I've been using it for a while and made various themes and it seems to work ok. Some of it is inefficient and incomplete, but I can clean it up if you want. I was wondering if you were interested in any of the features for the main branch. I'm not sure what can be added before 2.6/3.0 so I haven't planned on commiting but some of the patches are quite small and might be worth a look. [1] http://abdn.ac.uk/~u15dm4/fvwm/ I really liked the following patches: -FlatSeparators -InactiveFont -RoundedCorners -MultiBorder -Hover I also think most of the others are good too. The question is, can they be thrown in without sacrificing performance. I'm affraid I cannot answer that. Maybe in a future version the window/menu decorations could be modular, and then everyone could choose how much looks or performance they want. Before that, it's just a matter of weighting the pros and cons. And that should be the task of the senior devs.. (read the guys who know best). Anyway, good job! Renato Caldas
Re: Title font color broken
On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being done. I'd be grateful if someone could look into this problem or at least give me a minimal config to reproduce it. I can confirm Dan's bugreport. And it easily reproducable with minimal config: I compile FVWM like this: aclocal autoheader automake --add-missing autoreconf ./configure --prefix=$HOME/usr --oldincludedir=$HOME/usr/include \ --enable-xft --disable-xinerama --enable-iconv --disable-bidi \ --enable-perllib --enable-nls --enable-gtk --with-x --without-rplay-library \ --without-gnome make make install Then I move entire ~/.fvwm directory somewhere: $ mv ~/.fvwm ~/usr/src Create new empty directory: mkdir ~/.fvwm Create '~/.fvwm/config' file consisting of two lines: Style * ForeColor red Style * HilightFore red Launch FVWM and see that titles of both active and inactive windows are black, but not red. I hope you can reproduce it as well and fix this bug. If not, you can provide me with instructions what to do next and I'll be more than glad to help. Good luck
Re: Title font color broken
Serge (gentoosiast) Koksharov [EMAIL PROTECTED] writes: On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being done. I'd be grateful if someone could look into this problem or at least give me a minimal config to reproduce it. I can confirm Dan's bugreport. And it easily reproducable with minimal config: I compile FVWM like this: aclocal autoheader automake --add-missing autoreconf ./configure --prefix=$HOME/usr --oldincludedir=$HOME/usr/include \ --enable-xft --disable-xinerama --enable-iconv --disable-bidi \ --enable-perllib --enable-nls --enable-gtk --with-x --without-rplay-library \ --without-gnome make make install Then I move entire ~/.fvwm directory somewhere: $ mv ~/.fvwm ~/usr/src Create new empty directory: mkdir ~/.fvwm Create '~/.fvwm/config' file consisting of two lines: Style * ForeColor red Style * HilightFore red Launch FVWM and see that titles of both active and inactive windows are black, but not red. I hope you can reproduce it as well and fix this bug. If not, you can provide me with instructions what to do next and I'll be more than glad to help. Dominik posted a patch containing the commit that caused the problem. He asked for help trying to recreate the original problem he was trying to patch. We could just revert his patch, but the original problem would remain unsolved. I haven't had any time to look into this yet. -- Dan Espen E-mail: [EMAIL PROTECTED]
Re: Possible patches
Hello, David, I like 'Conditionals' which can be useful in function which toggles window fullscreen. Also I would use 'RoundedCorners' in my theme and I think many users want and miss this shaped title-bar functionality. And 'Hover' looks appealing. But I think other users will like and use another your patches. And I believe as long as your extensions can be explicitly disabled they will not hurt FVWM users with low-end/old/rare hardware. BTW, from your terminal in one of screenshots I assume you use Gentoo, right? Is it possible if some of your patches will not make it to the mainstream FVWM, they will be made available in Gentoo ebuild, as Translucency menus patch now does? -- Serge Koksharov, Free Software user supporter GPG public key ID: 0x3D330896 (pgp.mit.edu) Key fingerprint: 5BC4 0475 CB03 6A31 0076 82C2 C240 72F0 3D33 0896
Re: Possible patches
If you search this list for Patch: HasTitle and HasBorders, there is a thread that may be relevant. I haven't tested the borders condition though. I've made them so that everything is off by default so I don't think it would hurt performance much. I'm using gentoo, there is an unofficial ebuild available here: http://forums.gentoo.org/viewtopic-t-465973.html
Re: Possible patches
On Wed, Jun 07, 2006 at 12:30:38AM +, David Maciver wrote: If you search this list for Patch: HasTitle and HasBorders, there is a thread that may be relevant. I haven't tested the borders condition though. Yes -- which I hold my hands up admit to making a complete pigs ear of it originally. The patch on my website (and the one you subsequently added to) works just as well. I never followed up the original thread with my fix, since it's an entirely trivial patch to be of almost no consequence. -- Thomas Adam -- If I were a witch's hat, sitting on her head like a paraffin stove, I'd fly away and be a bat. -- Incredible String Band.
CVS scott: spelling fixes.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: scott 06/06/07 00:34:44 Modified files: modules/FvwmProxy: FvwmProxy.1.in Log message: spelling fixes.
