Re: [htdig-dev] 3.2RC1 Feature Freeze
On Tue, 14 Oct 2003, Gabriele Bartolini wrote: If you find a bug during testing 1) Post description of bug to devlist 2) Submit a Sourceforge bug. 3) If the bug is deemed serious we'll mark it as 'Include-in-3.2RC1' category 4) Someone Fix the Bug! 5) When a fix is committed the bug should be retested by a third person 6) When fix is verified, the Sourceforge bug is marked as 'Solved' Sounds good. As of now there are two immediate bugs 1) Fixing head_before_get to be default true and override (to false) during a '-i' reindex I volonteer for this bug. Is it ok? Great! Add something after line 156 of htdig.cc htdig.cc:156config-Read(configFile); if(initial 0) config-Add (head_before_get, FALSE); Please add a bug with the Group 'Include-in-3.2', commit the fix and I'll be the verifier on this one. Thanks! Ciao ciao -Gabriele -- Gabriele Bartolini: Web Programmer, ht://Dig IWA/HWG Member, ht://Check maintainer Current Location: Melbourne, Victoria, Australia [EMAIL PROTECTED] | http://www.prato.linux.it/~gbartolini | ICQ#129221447 Leave every hope, ye who enter!, Dante Alighieri, Divine Comedy, The Inferno Neal Richter Knowledgebase Developer RightNow Technologies, Inc. Customer Service for Every Web Site Office: 406-522-1485 --- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php ___ ht://Dig Developer mailing list: [EMAIL PROTECTED] List information (subscribe/unsubscribe, etc.) https://lists.sourceforge.net/lists/listinfo/htdig-dev
Re: [htdig-dev] 3.2RC1 Feature Freeze
htdig.cc:156config-Read(configFile); if(initial 0) config-Add (head_before_get, FALSE); I will. I also think this is not enough. I have to kind of use a 'force' variable in order to override every inner specification (i.e. blocks). I was thinking of using a class variable for the HTTP class. I will give a look at the code this morning. Ciao -Gabriele -- Gabriele Bartolini: Web Programmer, ht://Dig IWA/HWG Member, ht://Check maintainer Current Location: Melbourne, Victoria, Australia [EMAIL PROTECTED] | http://www.prato.linux.it/~gbartolini | ICQ#129221447 Leave every hope, ye who enter!, Dante Alighieri, Divine Comedy, The Inferno --- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php ___ ht://Dig Developer mailing list: [EMAIL PROTECTED] List information (subscribe/unsubscribe, etc.) https://lists.sourceforge.net/lists/listinfo/htdig-dev
Re: [htdig-dev] 3.2RC1 Feature Freeze
On Tue, 14 Oct 2003, Gabriele Bartolini wrote: As of now there are two immediate bugs 1) Fixing head_before_get to be default true and override (to false) during a '-i' reindex 2) Fixing allow_numbers bug 3) Fixing the 'Accept-Encoding' bug of the HTTP 1/1 protocol (see bug #594790). My solution, waiting to correctly handle gzipped contents (if you think it is reasonable doing it now, I could think about that) is just to send an empty 'Accept-Encoding' header, which lets the server know that our user agent is only able to manage document with the 'identity' encoding. Otherwise - the actual case - if no header is sent, the server assumes we can handle every kind of encoding. I'll leave this up to you. Does your fix solve the problem completely? Let's all evaluate bugs at this stage according to: 1) Is your potential code fix large? 2) Can it be fixed in a timely manner? 3) Is is important enough to delay 3.2? 4) Does the bug affect enough users to be important in the short-term? Thanks. Neal Richter Knowledgebase Developer RightNow Technologies, Inc. Customer Service for Every Web Site Office: 406-522-1485 --- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php ___ ht://Dig Developer mailing list: [EMAIL PROTECTED] List information (subscribe/unsubscribe, etc.) https://lists.sourceforge.net/lists/listinfo/htdig-dev
Re: [htdig-dev] 3.2RC1 Feature Freeze
At 18.10 13/10/2003 -0600, Neal Richter wrote: On Tue, 14 Oct 2003, Gabriele Bartolini wrote: 3) Fixing the 'Accept-Encoding' bug of the HTTP 1/1 protocol (see bug #594790). My solution, waiting to correctly handle gzipped contents (if you think it is reasonable doing it now, I could think about that) is just to send an empty 'Accept-Encoding' header, which lets the server know that our user agent is only able to manage document with the 'identity' encoding. Otherwise - the actual case - if no header is sent, the server assumes we can handle every kind of encoding. I'll leave this up to you. Does your fix solve the problem completely? I have committed the simple patch, which solves the bug #594790. Now the request - according to me - becomes a feature request, that is to say to handle the compressed contents. This should not be a problem, but IMHO could lead to some portability problems that I would rather avoid now. Indeed, we should enable it only if zlib is present. Let me know. Now, the HTTP request always includes an empty Accept-Encoding header (this informs the server that htdig is only able to manage documents that are not encoded. Before, no Accept-Encoding was sent, letting the server assume that the client was capable of handling every content encoding - i.e. zipped documents with Apache's mod_gzip module. 1) Is your potential code fix large? The fix is extremely simple (one line) and should not lead to problems. 2) Can it be fixed in a timely manner? Yep. Done. 3) Is is important enough to delay 3.2? I refer this question to the feature request. I think this is not urgent and I consider 3.2 more important than adding this feature, even though I suggest putting it into the TODO list for the next release. 4) Does the bug affect enough users to be important in the short-term? Potentially yes. Indeed, for mod_gzip Apache servers this could have led to some problems. Ciao -Gabriele -- Gabriele Bartolini: Web Programmer, ht://Dig IWA/HWG Member, ht://Check maintainer Current Location: Melbourne, Victoria, Australia [EMAIL PROTECTED] | http://www.prato.linux.it/~gbartolini | ICQ#129221447 Leave every hope, ye who enter!, Dante Alighieri, Divine Comedy, The Inferno --- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php ___ ht://Dig Developer mailing list: [EMAIL PROTECTED] List information (subscribe/unsubscribe, etc.) https://lists.sourceforge.net/lists/listinfo/htdig-dev
