Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053757300 > I don't know eactly the policy is on the `changes.xml`, but I just noticed that there seems to be no entry for the initial `ExifRewriterRoundtripTest`. > > So to give everyone involved proper credit maybe "Charles Hope" should be mentioned. Sounds good to me! I will do some searching in the git history to confirm where it should be added. Thanks @StefanOltmann ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
StefanOltmann commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053700501 I don't know eactly the policy is on the `changes.xml`, but I just noticed that there seems to be no entry for the initial `ExifRewriterRoundtripTest`. So to give everyone involved proper credit maybe "Charles Hope" should be mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
StefanOltmann commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053697017 @kinow Thanks for merging it. :) > The changes.xml has the due-to field set to Stefan and to Gary Lucas (as I believe Stefan used Gary's suggestion from JIRA 👍). This PR completes the work done in PR #275, started by Charles Hope. But since Gary Lucas found the bugfix and the test was done to showcase the bug it fixes, it's fine to give him credit. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
StefanOltmann commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053695842 @kinow Thanks for merging it! :) > The `changes.xml` has the due-to field set to Stefan and to Gary Lucas (as I believe Stefan used Gary's suggestion from JIRA 👍). That's true for #359. This PR fixed & completed work started by Charles Hope in #275. But yes, this test was built in the first place to showcase the bug that Gary found the bugfix for - so it's fine to give him credit. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow merged PR #366: URL: https://github.com/apache/commons-imaging/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2053691613 Rebased, added `changes.xml` entry, and squashed commits. The `changes.xml` has the due-to field set to Stefan and to Gary Lucas (as I believe Stefan used Gary's suggestion from JIRA :+1:). Waiting for GH Actions now to complete before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
garydgregory commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2028077804 @kinow Thank you for your work here. I'll merge this once 1.0.0-alpha4 is out (in 3 days). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027412302 And tests passed after re-running the failed jobs on GitHub Actions :man_shrugging: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027349014 Build errors are on macos (works on macos + java 8, fails for java 11). >Error: Java heap space I will spend some minutes checking if there's any Maven setting that we can use to fix the build, but I think that shouldn't be a blocker. I still want to test this part from @StefanOltmann 's comment before merging >Drop this [testfile.jpg](https://github.com/apache/commons-imaging/assets/9299303/2826b4ee-473a-45fb-b9fc-2168b9ae3fca) into src/test/resources/data/images/jpg to make the test fail. Then I believe a good course of action here would be to merge this to get the test passing (thanks Stefan!), and continue working on #359. If I recall correctly we may not be able to include the test file, so I will check whether I can find another one, find another way to test that, or check with legal/others other options (no need to worry about this for now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [IMAGING-351] ExifRewriterRoundtripTest fixed, completed & enabled [commons-imaging]
kinow commented on PR #366: URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2027097242 - Replaced test code from `TiffOutputField` by a public getter/setter for the bytes data (the getter is a copy, like in other formats) - Updated tests to use `assertArrayEquals` from JUnit instead of custom test code - Updated a few lines to match the formatting of other classes - Added link to the issue/PR where the test was added (for traceability) - Added Javadocs to public methods changed I added a second commit so we can still revert/remove things if needed, but if there are no objections I think this should be ready to be merged as soon as CI is happy (will take a look later, gotta go :wave: :runner: ) p.s. will hold merging this until the current ongoing release is out, I think, to avoid causing any issues with the release progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
