Re: [Libreoffice] [PATCH] Fix for fdo43460, Part II, getLength to isEmpty
Hi Oliver, nice! I had introduced this method, but this move was still on todo. Thanks for doing this :) Thomas On 12/10/2011 01:29 AM, Olivier Hallot wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Please find attached a partial fix for Easy Hack FDO43460, Part II Module basctl - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO4qf6AAoJEJp3R7nH3vLxDf4H/iBCn2M/oc14esTdjPdlAphq TDX7am464b4Wsk9W21nvEZw0HYYzOPbsuU8ubteG0MiCMEI1GCAV4vW9PqHuglZY SBrfeGzlNuMwIw6xibS0LZiOFbRBI4b8PL61wovFOiHrYfKkjbvkRxtT1tj1jOeC duHFZncd/gD7pL8yG4J8I654O+S6JTWQMXl793Okrcs8bysN2IQTT+7t8lTBjPcv wNJSVMArTNpbu4qYbAPcoSrRjfv4ILL0JILuExa1lpq2QFinX8wGHCvNxiGRSfqC sqq90OmECjEBbfEM+PcviO/EukjiH14wWXBcwuImUFpDhS+7DOLaMNlhnx8gMSM= =eSsc -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Correct bracket closing.
From 83c6e1d5ab69429fcae33bda26fcbdb6dbd97099 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Sun, 16 Jan 2011 20:55:22 +0100
Subject: [PATCH] Correct bracket closing.
---
sc/source/ui/vba/vbahelper.cxx |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sc/source/ui/vba/vbahelper.cxx b/sc/source/ui/vba/vbahelper.cxx
index e602573..4c8fe06 100644
--- a/sc/source/ui/vba/vbahelper.cxx
+++ b/sc/source/ui/vba/vbahelper.cxx
@@ -82,7 +82,7 @@ getIntrospectionAccess( const uno::Any aObject ) throw
(uno::RuntimeException)
if( !xIntrospection.is() )
{
uno::Reference lang::XMultiServiceFactory xFactory(
comphelper::getProcessServiceFactory(), uno::UNO_QUERY_THROW );
-xIntrospection.set( xFactory-createInstance(
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.beans.Introspection)
), uno::UNO_QUERY_THROW );
+xIntrospection.set( xFactory-createInstance( rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM(com.sun.star.beans.Introspection) ) ),
uno::UNO_QUERY_THROW );
}
return xIntrospection-inspect( aObject );
}
@@ -279,7 +279,7 @@ getCurrentDocument() throw (uno::RuntimeException)
// test if vba service is present
uno::Reference uno::XComponentContext xCtx(
xProps-getPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
DefaultContext ))), uno::UNO_QUERY_THROW );
uno::Referencelang::XMultiComponentFactory xSMgr(
xCtx-getServiceManager(), uno::UNO_QUERY_THROW );
-uno::Reference frame::XDesktop xDesktop
(xSMgr-createInstanceWithContext(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM((com.sun.star.frame.Desktop)),
xCtx), uno::UNO_QUERY_THROW );
+uno::Reference frame::XDesktop xDesktop
(xSMgr-createInstanceWithContext(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.frame.Desktop)),
xCtx), uno::UNO_QUERY_THROW );
xModel.set( xDesktop-getCurrentComponent(), uno::UNO_QUERY );
if ( !xModel.is() )
{
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] ure/sal/inc/rtl/ustring.hxx - new method isEmpty()
Hi folks,
what do you think about this idea:
New method: isEmpty() - Checks if a string is empty.
This could simplify logics in the source. Now this test is done
like 'if (aStr.getLength() != 0) {...}' or 'if (!aStr.getLength()) {...}'.
With isEmpty() this looks like:
if (aStr.isEmpty()) {...}
if (!aStr.isEmpty()) {...}
I think this would make the code more readable.
-Thomas
From fdf1e69730457763778f5735bb5709f5fc227327 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Fri, 21 Jan 2011 13:43:52 +0100
Subject: [PATCH] New method: isEmpty() - Checks if a string is empty.
This could simplify logics in the source. Now this test is done
like 'if (aStr.getLength() != 0) {...}' or 'if (!aStr.getLength()) {...}'.
With isEmpty() this looks like:
if (aStr.isEmpty()) {...}
if (!aStr.isEmpty()) {...}
I think this would make the code more readable.
---
sal/inc/rtl/ustring.hxx | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index a481be7..5fdbcc6 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -278,6 +278,20 @@ public:
sal_Int32 getLength() const SAL_THROW(()) { return pData-length; }
/**
+ Checks if a string is empty.
+
+ @return sal_True if the string is empty;
+sal_False, otherwise.
+*/
+sal_Bool isEmpty() const SAL_THROW(())
+{
+if ( pData-length )
+return sal_False;
+else
+return sal_True;
+}
+
+/**
Returns a pointer to the Unicode character buffer from this string.
It isn't necessarily NULL terminated.
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] impress - remove doubled copyright notice
On 01/21/2011 03:08 PM, Michael Meeks wrote: Hi Thomas, On Fri, 2011-01-21 at 14:54 +0100, Thomas Arnhold wrote: won't do this without your approval. Looks fine to me - no point in duplicating license headers. Michael K was writing a nice lint tool, that may be able to find if this problem (duplicated license headers) affects many other modules. Thanks ! Michael. I think there is no need for this. I did a simple grep: grep -A50 'Oracle and/or its affiliates.' * -R | grep 'by Sun Microsystems, Inc.' and vice versa. Nothing besides this two files popped up. All files should be clean. -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] MacOS build breakage
Hopefully this is fixed now. I accidently removed a 'premac.h' and 'postmac.h' definition. -Thomas On 01/23/2011 07:51 AM, Norbert Thiebaud wrote: components:6ea1497263e15e212d6c42c23e9e8b76d6dc1470 breaks the MacOS build: Compiling: extensions/source/plugin/base/service.cxx /Volumes/Raid0/tb/solver/330/unxmacxi.pro/inc/osl/time.h:53: error: conflicting declaration 'typedef struct TimeValue TimeValue' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/CoreServices.framework/Headers/../Frameworks/CarbonCore.framework/Headers/MacTypes.h:541: error: 'TimeValue' has a previous declaration as 'typedef SInt32 TimeValue' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:30: error: expected type-specifier before 'MacOSBoolean' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:30: error: expected `)' before 'MacOSBoolean' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:30: error: expected `;' before ')' token /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:69: error: expected type-specifier before 'MacOSBoolean' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:69: error: expected `)' before 'MacOSBoolean' /Developer/SDKs/MacOSX10.4u.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:69: error: expected `;' before ')' token /Volumes/Raid0/tb/solver/330/unxmacxi.pro/inc/tools/gen.hxx:120: error: redefinition of 'class Point' Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] sw/filter/ww1
Hi folks, do we need ww1? I googled for it, found this: ww1: old MS Word filter code ww8: new MS Word filter code (non-XML) Is this correct? And makes ww8 ww1 obsolete? I compiled LibreOffice without ww1. Works fine. -Thomas From cb98e538766d20425d713d2ace010ef54ca04a6a Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Tue, 25 Jan 2011 14:34:37 +0100 Subject: [PATCH 3/3] Don't build ww1. --- sw/prj/build.lst |3 +-- sw/source/filter/makefile.mk |1 - 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/sw/prj/build.lst b/sw/prj/build.lst index e61ab62..8db7f72 100755 --- a/sw/prj/build.lst +++ b/sw/prj/build.lst @@ -67,12 +67,11 @@ sw sw\source\filter\basflt nmake - all sw_bsflt sw_ sw sw\source\filter\html nmake - all sw_html sw_inc NULL sw sw\source\filter\rtfnmake - all sw_rtf sw_inc NULL sw sw\source\filter\writer nmake - all sw_wrtr sw_inc NULL -sw sw\source\filter\ww1nmake - all sw_ww1 sw_inc NULL sw sw\source\filter\ww8nmake - all sw_ww8 sw_inc NULL sw sw\source\filter\xmlnmake - all sw_xml sw_inc NULL sw sw\source\uinmake - all sw_ui sw_app sw_cctrl sw_chrdl sw_conf sw_dbui sw_dchdl sw_dcvw sw_dlg sw_envlp sw_fldui sw_fmtui sw_frmdl sw_globd sw_index sw_ling sw_misc sw_rbbar sw_shell sw_table sw_uiuno sw_uivw sw_utlui sw_web sw_wrtsh sw_smartmenu sw_vba NULL sw sw\source\core nmake - all sw_core sw_attr sw_bast sw_crsr sw_dcnd sw_doc sw_draw sw_edit sw_excpt sw_fld sw_frmed sw_grph sw_layo sw_ole sw_para sw_sw3io sw_swg sw_text sw_tox sw_txtnd sw_uco sw_undo sw_view sw_acc sw_objpos sw_NumberTree sw_tablecore NULL -sw sw\source\filternmake - all sw_flt sw_ascii sw_bsflt sw_html sw_rtf sw_wrtr sw_ww1 sw_ww8 sw_xml NULL +sw sw\source\filternmake - all sw_flt sw_ascii sw_bsflt sw_html sw_rtf sw_wrtr sw_ww8 sw_xml NULL sw sw\util nmake - all sw_util sw_core sw_flt sw_sdi sw_ui NULL sw sw\qa\unoapi nmake - all sw_qa_unoapi NULL sw sw\qa\core nmake - all sw_qa_cppunit sw_util NULL diff --git a/sw/source/filter/makefile.mk b/sw/source/filter/makefile.mk index c2b343e..bb75f72 100644 --- a/sw/source/filter/makefile.mk +++ b/sw/source/filter/makefile.mk @@ -48,7 +48,6 @@ SUBLIBS= \ $(SLB)$/basflt.lib \ $(SLB)$/html.lib \ $(SLB)$/writer.lib \ -$(SLB)$/ww1.lib \ $(SLB)$/xml.lib # --- -- 1.7.3.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
Hi,
does anyone need this macros? I removed them completely.
-Thomas
From dfe6fbe864926c8ef29c34681b0425f7aacdca75 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Mon, 31 Jan 2011 09:52:51 +0100
Subject: [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
---
basic/source/classes/disas.cxx | 13 --
basic/source/classes/sbxmod.cxx | 22 ---
basic/source/comp/sbcomp.cxx | 376 --
basic/source/inc/sbtrace.hxx | 45 -
basic/source/runtime/runtime.cxx | 18 --
5 files changed, 0 insertions(+), 474 deletions(-)
delete mode 100644 basic/source/inc/sbtrace.hxx
diff --git a/basic/source/classes/disas.cxx b/basic/source/classes/disas.cxx
index 3000391..e299717 100644
--- a/basic/source/classes/disas.cxx
+++ b/basic/source/classes/disas.cxx
@@ -36,7 +36,6 @@
#include sb.hxx
#include iosys.hxx
#include disas.hxx
-#include sbtrace.hxx
static const char* pOp1[] = {
@@ -364,10 +363,6 @@ BOOL SbiDisas::DisasLine( String rText )
if( !Fetch() )
return FALSE;
-#ifdef DBG_TRACE_BASIC
-String aTraceStr_STMNT;
-#endif
-
// New line?
if( eOp == _STMNT nOp1 != nLine )
{
@@ -400,10 +395,6 @@ BOOL SbiDisas::DisasLine( String rText )
rText.AppendAscii( ; );
rText += s;
rText.AppendAscii( _crlf() );
-
-#ifdef DBG_TRACE_BASIC
-aTraceStr_STMNT = s;
-#endif
}
}
@@ -463,10 +454,6 @@ BOOL SbiDisas::DisasLine( String rText )
rText += aPCodeStr;
-#ifdef DBG_TRACE_BASIC
-dbg_RegisterTraceTextForPC( pMod, nPC, aTraceStr_STMNT, aPCodeStr );
-#endif
-
return TRUE;
}
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index c5849d7..654fa2e 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -45,7 +45,6 @@
#include runtime.hxx
#include token.hxx
#include sbunoobj.hxx
-#include sbtrace.hxx
#include svtools/syntaxhighlight.hxx
@@ -1121,9 +1120,6 @@ USHORT SbModule::Run( SbMethod* pMeth )
StarBASICRef xBasic;
if( bDelInst )
{
-#ifdef DBG_TRACE_BASIC
-dbg_InitTrace();
-#endif
// #32779: Hold Basic during the execution
xBasic = (StarBASIC*) GetParent();
@@ -1180,10 +1176,6 @@ USHORT SbModule::Run( SbMethod* pMeth )
pMOD = this;
SbiRuntime* pRt = new SbiRuntime( this, pMeth, pMeth-nStart );
-#ifdef DBG_TRACE_BASIC
-dbg_traceNotifyCall( this, pMeth, pINST-nCallLvl );
-#endif
-
pRt-pNext = pINST-pRun;
if( pRt-pNext )
pRt-pNext-block();
@@ -1196,11 +1188,6 @@ USHORT SbModule::Run( SbMethod* pMeth )
if( pRt-pNext )
pRt-pNext-unblock();
-#ifdef DBG_TRACE_BASIC
-bool bLeave = true;
-dbg_traceNotifyCall( this, pMeth, pINST-nCallLvl, bLeave );
-#endif
-
// #63710 It can happen by an another thread handling at events,
// that the show call returns to an dialog (by closing the
// dialog per UI), before a by an event triggered further call
returned,
@@ -1304,19 +1291,10 @@ void SbModule::RunInit()
// The init code starts always here
SbiRuntime* pRt = new SbiRuntime( this, NULL, 0 );
-#ifdef DBG_TRACE_BASIC
-dbg_traceNotifyCall( this, NULL, 0 );
-#endif
-
pRt-pNext = pINST-pRun;
pINST-pRun = pRt;
while( pRt-Step() ) {}
-#ifdef DBG_TRACE_BASIC
-bool bLeave = true;
-dbg_traceNotifyCall( this, NULL, 0, bLeave );
-#endif
-
pINST-pRun = pRt-pNext;
delete pRt;
pMOD = pOldMod;
diff --git a/basic/source/comp/sbcomp.cxx b/basic/source/comp/sbcomp.cxx
index a9fbdeb..6b98736 100644
--- a/basic/source/comp/sbcomp.cxx
+++ b/basic/source/comp/sbcomp.cxx
@@ -32,374 +32,6 @@
#include basic/sbx.hxx
#include sbcomp.hxx
#include image.hxx
-#include sbtrace.hxx
-
-
-//==
-// Tracing, for debugging only
-
-// To activate tracing enable in sbtrace.hxx
-#ifdef DBG_TRACE_BASIC
-
-#include hash_map
-
-// Trace Settings
-static const char* GpTraceFileName = d:\\zBasic.Asm\\BasicTrace.txt;
-static const bool GbIncludePCodes = false;
-static const int GnIndentPerCallLevel = 4;
-static const int GnIndentForPCode = 2;
-
-struct TraceTextData
-{
-rtl::OString m_aTraceStr_STMNT;
-rtl::OString m_aTraceStr_PCode;
-};
-typedef std::hash_map sal_Int32, TraceTextData PCToTextDataMap;
-typedef std::hash_map ::rtl::OUString, PCToTextDataMap*, ::rtl::OUStringHash,
::std::equal_to ::rtl::OUString ModuleTraceMap;
-
-ModuleTraceMap GaModuleTraceMap;
-ModuleTraceMaprModuleTraceMap = GaModuleTraceMap;
-
-static void lcl_PrepareTraceForModule( SbModule* pModule )
-{
-String aModuleName = pModule-GetName();
-ModuleTraceMap::iterator
Re: [Libreoffice] [PATCH] Remove DBG_TRACE_BASIC, DBG_SAVE_DISASSEMBLY and sbtrace.hxx
Thanks. On 01/31/2011 12:32 PM, Cedric Bosdonnat wrote: Hi Thomas, On Mon, 2011-01-31 at 09:58 +0100, Thomas Arnhold wrote: does anyone need this macros? I removed them completely. I just pushed your patch here: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=b214264fbb55b1f33e8a50b42113137178da0125 If anyone complains about the removal, feel free to revert the commit. Regards, ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Hi, I'm not really sure about this. There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? -Thomas From b93f098328afb2cf3ad420bfef45dacbdd7d5181 Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Mon, 31 Jan 2011 19:16:09 +0100 Subject: [PATCH] Remove 'Mizi Research' copyright note --- hwpfilter/source/hiodev.h |5 - hwpfilter/source/hwpfile.h |5 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/hwpfilter/source/hiodev.h b/hwpfilter/source/hiodev.h index e859a13..0811fab 100644 --- a/hwpfilter/source/hiodev.h +++ b/hwpfilter/source/hiodev.h @@ -26,11 +26,6 @@ * / -/** - * hwpio.h - * (C) 1999 Mizi Research, All rights are reserved - */ - #ifndef _HIODEV_H_ #define _HIODEV_H_ diff --git a/hwpfilter/source/hwpfile.h b/hwpfilter/source/hwpfile.h index 787c65e..a691f7b 100644 --- a/hwpfilter/source/hwpfile.h +++ b/hwpfilter/source/hwpfile.h @@ -26,11 +26,6 @@ * / -// -// hwpfile.h -// (C) 1998 Mizi Research, All rights are reserved -// - #ifndef _HWPFILE_H_ #define _HWPFILE_H_ -- 1.7.3.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Ok, I wondered because this copyright notice is only inside two files of hwpfilter. But you're right, they have to the rights on it. -Thomas On 01/31/2011 07:30 PM, Norbert Thiebaud wrote: On 1/31/11, Thomas Arnhold tho...@arnhold.org wrote: Hi, I'm not really sure about this. There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? Unless you are the copyright holder for these particular file, I'd say no, you can't remove copyright notice. Norbert -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Mizi Research copyright note for hwpfilter
Thanks. Filed a bug #33782. -Thomas On 01/31/2011 09:44 PM, Caolán McNamara wrote: On Mon, 2011-01-31 at 19:20 +0100, Thomas Arnhold wrote: There are some files lying around with StarDivision or StarOffice copyright notes. They could be removed, could they? Heh, probably not. In this case what you could do I guess is to file a bug against the inheritors of the StarDivision/StarOffice/etc. copyrights and mention the file name that has the archaic copyright note on it. Those should all have probably been changed to Sun Microsystems, and then Oracle at each takeover/purchase point. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] solenv/inc/settings.mk overwrites CDEFS
Hi, I just found out, that settings.mk resets all CDEFS which were defined in some makefiles. For example: sc/source/ui/vba/makefile.mk defines: CDEFS+=-DVBA_OOBUILD_HACK But some lines later settings.mk is included (which is solenv/inc/settings.mk) .INCLUDE : settings.mk In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for sc/source/ui/vba. Is this intended or a bug? -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] solenv/inc/settings.mk overwrites CDEFS
Thanks, didn't see that. I fixed it that way. -Thomas On 02/02/2011 12:48 AM, Norbert Thiebaud wrote: On Tue, Feb 1, 2011 at 5:05 PM, Thomas Arnhold tho...@arnhold.org wrote: Hi, I just found out, that settings.mk resets all CDEFS which were defined in some makefiles. For example: sc/source/ui/vba/makefile.mk defines: CDEFS+=-DVBA_OOBUILD_HACK But some lines later settings.mk is included (which is solenv/inc/settings.mk) .INCLUDE : settings.mk In this file CDEFS is reset. So VBA_OOBUILD_HACK doesn't get defined for sc/source/ui/vba. Is this intended or a bug? based on the other 2 uses of VBA_OOBUILD_HACK, I'd imagine that the CDEF should be _after_ the include setting.mk Norbert -Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
Oh, I think this was a mistake o mine. I removed the brackets, didn't
really thought, that the else statement could be associated with the
inner if. I attached the patch to bring the brackets back.
-Thomas
On 02/02/2011 08:38 PM, Kohei Yoshida wrote:
On Thu, 2011-02-03 at 03:20 +0900, Takeshi Abe wrote:
Hi,
On building calc, I found a warning suggesting an ambiguous else.
The attached patch is under LGPLv3+/MPL.
Hmm... But your patch may change the intention of that code block based
on how the lines are indented.
Here is the code we have right now
if(eType==SC_CAT_CONTENT)
if(!pScChangeAction-IsDialogParent())
pScChangeAction-GetDescription( aDesc, pDoc, TRUE);
else
pScChangeAction-GetDescription( aDesc,
pDoc,!pScChangeAction-IsMasterDelete());
which makes me think the the else block is supposed to get executed when
eType != SC_CAT_CONTENT
I have no idea how the compiler parses that block of code as it is
indeed ambiguous. But I'm more in favor of interpreting it based on the
indent levels than how the compiler might be parsing it.
Kohei
From 088714d49235976ff04a0ac0f8f37e32120810b6 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Wed, 2 Feb 2011 23:26:47 +0100
Subject: [PATCH] Use brackets, to be safe.
---
sc/source/ui/miscdlgs/acredlin.cxx |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index ceba5b4..d4ea8de 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -343,8 +343,10 @@ BOOL ScAcceptChgDlg::IsValidAction(const ScChangeAction*
pScChangeAction)
aComment.EraseAllChars('\n');
if(eType==SC_CAT_CONTENT)
+{
if(!pScChangeAction-IsDialogParent())
pScChangeAction-GetDescription( aDesc, pDoc, TRUE);
+}
else
pScChangeAction-GetDescription( aDesc,
pDoc,!pScChangeAction-IsMasterDelete());
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] avoid ambiguous else
Thanks ;) On 02/02/2011 11:44 PM, Kohei Yoshida wrote: On Wed, 2011-02-02 at 23:27 +0100, Thomas Arnhold wrote: Oh, I think this was a mistake o mine. I removed the brackets, didn't really thought, that the else statement could be associated with the inner if. I attached the patch to bring the brackets back. No worries I'd already put the fix in before you sent your patch. :-) Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] HTML formatting in comments?
Ok, didn't know, that idl files get handled another way. How do we
clearly identify IDL and related files, which shouldn't be handled by
doxygen?! Are these only files with the idl extension? And is the
doxygen documentation complete without these files?
As an simple alternative we could define aliases for TRUE/FALSE and so
on with doxygen, say it replaces TRUE/ with TRUE.
Thomas
On 02/03/2011 05:50 PM, Cedric Bosdonnat wrote:
You need to pay attention to the internal javadoc-like tool used for IDL
files and some hxx files as well. This has some special tags... all the
doc is here:
http://api.openoffice.org/docs/DevelopersGuide/Appendix/IDLDocumentationGuide/IDLDocumentationGuide.xhtml
TRUE/ and FALSE/ are valid for this one. I would be in favor of
removing the use of that tool in C++ code and replace it by doxygen
comments... Keeping that thing for IDL only would be nice.
Regards,
On Thu, 2011-02-03 at 17:41 +0100, Thomas Arnhold wrote:
In addition to this:
There's the possibility to define multiple return values with \retval.
So we would get a nice formatted list like with param.
From the doxyfile documentation:
-
\retval return value { description }
Starts a description for a function's return value with name return
value, followed by a description of the return value. The text of the
paragraph that forms the description has no special internal structure.
All visual enhancement commands may be used inside the paragraph.
Multiple adjacent \retval commands will be joined into a single
paragraph. Each return value description will start on a new line. The
\retval description ends when a blank line or some other sectioning
command is encountered.
-
I think it would be nice to use this. I could write a simple script
which replaces TRUE/FALSE with @retval.
Thomas
On 02/03/2011 04:28 PM, Thomas Arnhold wrote:
Hi Christina,
seems like a XHMTL or XML tag. But doxygen doesn't know them. Here is
the list of known tags to doxygen:
http://www.stack.nl/~dimitri/doxygen/htmlcmds.html
http://www.stack.nl/~dimitri/doxygen/xmlcmds.html
If you run doxygen it says: Unsupported xml/html tag TRUE found. So
you're right. We could simply replace this with TRUE and FALSE.
Thomas
On 02/03/2011 12:46 PM, Christina Roßmanith wrote:
Hi,
I came across comments with html formatting which makes it difficult to
read them. Can this formatting be removed?
example: TRUE/ if and only if parsing was successful, FALSE/ if
default handling should...
(file: libs-core/connectivity/inc/connectivity/sqlnode.hxx)
Christina Rossmanith
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] ure/sal/inc/rtl/ustring.hxx - new method isEmpty()
Hi,
as I understand this, it would be nice to have this method in OString,
too. I've attached the patch.
Thomas
On 01/21/2011 05:55 PM, Michael Meeks wrote:
Hi Thomas,
On Fri, 2011-01-21 at 13:52 +0100, Thomas Arnhold wrote:
New method: isEmpty() - Checks if a string is empty.
I like it.
There are lots of use-cases that we need to get into sal: that we sadly
don't have at the moment: to make writing code easier and less
error-prone.
With isEmpty() this looks like:
if (aStr.isEmpty()) {...}
if (!aStr.isEmpty()) {...}
Prettier for sure.
There are some methods that are all 'pure' and all that (like those for
tokenising rtl::OUStrings) that get used in fairly unreadable ways
around the place. In a world of iterators, it is unclear to me why we
need to be managing string offsets and odd loops using 'getToken()'
Really, we need to be making OUStrings and StringBuffers easier to use,
so that we can use them everywhere - in place of the obsolete (mutable)
tools/inc/tools/string.hxx (UniString) - (mostly called 'String' outside
there).
I suppose, simply porting a good number of String instances would help
us fall over the missing pieces there.
Anyhow - nice patch, pushed to master; I added a:
@since LibreOffice 3.4
tag to the method call, since this low level piece is intended to be a
stable ABI that is managed in that way.
Thanks !
Michael.
From fee2cdb972482cb3682e83a72954d31c6ec6fcdc Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 3 Feb 2011 22:40:17 +0100
Subject: [PATCH] OString: New method isEmpty()
---
sal/inc/rtl/string.hxx | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 86bc1a6..c1af815 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -223,6 +223,22 @@ public:
sal_Int32 getLength() const SAL_THROW(()) { return pData-length; }
/**
+ Checks if a string is empty.
+
+ @return sal_True if the string is empty;
+sal_False, otherwise.
+
+ @since LibreOffice 3.4
+*/
+sal_Bool isEmpty() const SAL_THROW(())
+{
+if ( pData-length )
+return sal_False;
+else
+return sal_True;
+}
+
+/**
Returns a pointer to the characters of this string.
pThe returned pointer is not guaranteed to point to a null-terminated
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Problems with windows build
I think the problem is, that without resize the hash map could be
overfilled.
I did fix this like commit 6ecdae26517b89ee670.
Think problem is like in PspKernInfo::Initialize() [in
vcl/unx/source/gdi/salgdi3.cxx]:
maUnicodeKernPairs.insert( aKernPair );
maUnicodeKernPairs is boost::unordered_map and rKernPairs is std::list.
Is it clean to do this?! And: If we don't resize maUnicodeKernPairs to
the size of aKernPair, could we run out of memory - this would be the
case for all of them?
Thomas
On 02/04/2011 08:17 PM, Caolán McNamara wrote:
On Fri, 2011-02-04 at 06:41 -0700, Tor Lillqvist wrote:
And after a while of dismissing these, saxparser goes into an infinite loop.
For me, saxparser crashes... I am debugging that but not really getting much
wiser.
does this patch, to revert a hash_map - unordered_map make it go away
C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
diff --git a/vcl/source/gdi/configsettings.cxx
b/vcl/source/gdi/configsettings.cxx
index 0b1dcbb..ac38d23 100644
--- a/vcl/source/gdi/configsettings.cxx
+++ b/vcl/source/gdi/configsettings.cxx
@@ -134,7 +134,6 @@ void SettingsConfigItem::getValues()
m_aSettings.clear();
Sequence OUString aNames( GetNodeNames( OUString() ) );
-m_aSettings.resize( aNames.getLength() );
for( int j = 0; j aNames.getLength(); j++ )
{
diff --git a/vcl/unx/headless/svptext.cxx b/vcl/unx/headless/svptext.cxx
index 8701a7f..1523241 100644
--- a/vcl/unx/headless/svptext.cxx
+++ b/vcl/unx/headless/svptext.cxx
@@ -194,7 +194,6 @@ void PspKernInfo::Initialize() const
return;
// feed psprint's kerning list into a lookup-friendly container
-maUnicodeKernPairs.resize( rKernPairs.size() );
PspKernPairs::const_iterator it = rKernPairs.begin();
for(; it != rKernPairs.end(); ++it )
{
diff --git a/vcl/unx/source/gdi/salgdi3.cxx b/vcl/unx/source/gdi/salgdi3.cxx
index d3718f5..50283ff 100644
--- a/vcl/unx/source/gdi/salgdi3.cxx
+++ b/vcl/unx/source/gdi/salgdi3.cxx
@@ -523,7 +523,6 @@ void PspKernInfo::Initialize() const
return;
// feed psprint's kerning list into a lookup-friendly container
-maUnicodeKernPairs.resize( rKernPairs.size() );
PspKernPairs::const_iterator it = rKernPairs.begin();
for(; it != rKernPairs.end(); ++it )
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] rm double line spacing/dead code/empty comments, transl. comm. German-English
Hi Christina,
I started to remove double includes. These could be identified by a
script (if you want to have that write me a mail). But there is one
problem within this task - called forward includes. I think removing
doubled includes and removing double line spacing within them will be
more than enough.
I think the comment on this include isn't really necessary.
For a well formatted commit message type: git commit -a Then your
favorite editor will pop up and you have the possibility to give a short
description of your commit and below that a text as long as you want.
Thomas
On 02/04/2011 08:50 PM, Christina Roßmanith wrote:
Hi,
if the ordering of several bf_svx/ includes is unimportant even more
blank lines can be removed (first reorder #includes and then group
similar #includes without spacing, hope it is clear what I mean...). Or
should I just try to build after reordering? I'll take this file from
the list if this question as answered.
This file contains some comments of the type
// #\d{6}# text
e.g.
// #012345# this is need to be able to blah...
I'm not sure if only the number tag is unimportant or the text isn't
needed anymore as well.
The commit message is somewhat cryptic because of the 79 characters limit.
Christina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove bogus comments + bash line
Hi Guilaume, you can request a git account an push the patches by your own: http://freedesktop.org/wiki/AccountRequests Thomas On 02/08/2011 08:57 AM, Guillaume Poussel wrote: I have edited the wiki to show I'm currently working on it. Please find attached again new patches to remove this comments. Regards, Guillaume Poussel. 2011/2/7 Guillaume Poussel gpous...@gmail.com: I have removed all of them in impress too (see patch attached). As soon as someone push it, I edit the wiki. (still in LGPLv3/MPL) Regards, Guillaume Poussel 2011/2/7 Guillaume Poussel gpous...@gmail.com: Hi all, Again, I send patches to remove bogus comments. I have written a pretty (but not optimized) bash line to find them all: git grep -nE #[^i][0-9]+# | ( while read f; do file=$(echo $f | cut -d':' -f1) ; line=$(echo $f | cut -d':' -f2) ; emacs +$line -fh $file; done ) It opens emacs with every occurences of #xxx#. As soon as I have time, I will try to end up by finishing this Easy Hack. Regards, Guillaume Poussel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Easy hack patch!
Gna, sorry for this. Didn't update the wiki page, as these clean up was incidendental to some other cleaning. I'll update the wiki page. Thomas On 02/08/2011 09:56 PM, Caolán McNamara wrote: On Sun, 2011-02-06 at 11:59 -0500, spad...@sover.net wrote: Now with fewer blank lines! Thanks for this, unluckily though someone else got to it just before you :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build logs from the tinderbox
To have that log on the web would be nice (not all persons have a big mail account - some mail providers only give you a few megabytes at all). I did a fresh build with a git clone from the morning and there were no errors at all. Thomas On 02/10/2011 02:55 PM, Tor Lillqvist wrote: Would it be acceptable to get the full build log in case something goes wrong? Wouldn't it make sense to have the N last build logs on the web somewhere, and just point to the relevant one in the tinderbox mail? Would it be possible to in a simple way enhance build.pl to optionally redirect the output from each module into a separate log file, and then point just to the relevant one in the tinderbox mail? (No, I am not volunteering;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build logs from the tinderbox
Oh, didn't see the link. Didn't know that it's already on the web! I'm not sure if everybody knows that there are logs on the web, maybe you could add this link to the tinderbox mails :) Thomas On 02/10/2011 04:38 PM, Thomas Arnhold wrote: To have that log on the web would be nice (not all persons have a big mail account - some mail providers only give you a few megabytes at all). I did a fresh build with a git clone from the morning and there were no errors at all. Thomas On 02/10/2011 02:55 PM, Tor Lillqvist wrote: Would it be acceptable to get the full build log in case something goes wrong? Wouldn't it make sense to have the N last build logs on the web somewhere, and just point to the relevant one in the tinderbox mail? Would it be possible to in a simple way enhance build.pl to optionally redirect the output from each module into a separate log file, and then point just to the relevant one in the tinderbox mail? (No, I am not volunteering;) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] remove unused variables and indistinguishable branching
Hi, I removed these two variables this afternoon ;) I'll push the rest in some hours. Thanks, didn't see that at all! Thomas On 02/10/2011 06:11 PM, Takeshi Abe wrote: Hi, This is an easy hack against calc. Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] remove unused variables and indistinguishable branching
I pushed it. Thanks! On 02/10/2011 07:03 PM, Thomas Arnhold wrote: Hi, I removed these two variables this afternoon ;) I'll push the rest in some hours. Thanks, didn't see that at all! Thomas On 02/10/2011 06:11 PM, Takeshi Abe wrote: Hi, This is an easy hack against calc. Cheers, -- Takeshi Abe ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Easy Task - remove non-compiled / dead code
Hi, looks nice. But that doesn't replace manual overlooking what was deleted. For example in dmake/dmake.c was the following left: /* Uncomment the following line to pass commands to the DBUG engine * before the command line switches (-#..) are evaluated. */ This comment was related to DB_PUSH(d,path);. You have to delete this too, otherwise people will get confused. But at all it looks great. Have you run it on a greater repo like calc or some similar? How many lines got deleted/changed?! Thomas On 02/11/2011 04:34 PM, Jean Charles Papin wrote: Hi everyone, I've removed non-compiled pieces of code for boostrap. I hope it's ok ;) Regards, -- Jean-Charles Papin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Tools - Media Player
Hi, what the heck do we do with Tools - Media Player? Do we need this within an office suite? Is anyone using this?! Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy hack: remove obsolete gjc aot compilation
Hi, I've removed gjc aot from the build system. I grep'd for occurances inside other repos, but it doesn't match anything. Looks like this is all. LibO builds an runs fine on Linux. Thomas From a67a2555a34b07babfc809e7d58e9ee6c8f3 Mon Sep 17 00:00:00 2001 From: Thomas Arnhold tho...@arnhold.org Date: Sat, 12 Feb 2011 11:58:01 +0100 Subject: [PATCH] Easy hack: remove obsolete gjc aot compilation --- configure.cmd |2 +- configure.in | 39 --- set_soenv.in |1 - 3 files changed, 1 insertions(+), 41 deletions(-) diff --git a/configure.cmd b/configure.cmd index aff7e81..dfdc0b6 100755 --- a/configure.cmd +++ b/configure.cmd @@ -3,5 +3,5 @@ setlocal SET MY_ANT_HOME=e:/java150/apache-ant-1.7.0 SET JAVA_HOME=e:\java150 SET PATH=%JAVA_HOME%\bin;%PATH%;%MY_ANT_HOME%\bin; -sh -c configure --with-system-openssl --with-system-icu --with-system-libxml --with-system-libxslt --disable-werror --with-use-shell=bash --disable-mozilla --disable-epm --disable-odk --disable-qadevooo --with-x=no --disable-fontconfig --disable-gnome-vfs --disable-gtk --with-java=yes --disable-gcjaot --without-nas --without-fonts --with-ant-home=%MY_ANT_HOME% | tee configure.log +sh -c configure --with-system-openssl --with-system-icu --with-system-libxml --with-system-libxslt --disable-werror --with-use-shell=bash --disable-mozilla --disable-epm --disable-odk --disable-qadevooo --with-x=no --disable-fontconfig --disable-gnome-vfs --disable-gtk --with-java=yes --without-nas --without-fonts --with-ant-home=%MY_ANT_HOME% | tee configure.log endlocal diff --git a/configure.in b/configure.in index 0e1df63..45a22cd 100755 --- a/configure.in +++ b/configure.in @@ -397,13 +397,6 @@ AC_ARG_ENABLE(Xaw, [Disables the use of Xaw for the Netscape/Mozilla plugin.]), ,) -AC_ARG_ENABLE(gcjaot, -AS_HELP_STRING([--enable-gcjaot], -[Build with[[out]] using Ahead of Time java compilation support to speed - up buildsi by compiling the jars also to native code.. --enable-gcjaot - is only known to work with bytecode created with gcj or ecj.]), -,) - AC_ARG_ENABLE(check-only, AS_HELP_STRING([--enable-check-only], [Use this option option if you just want to check your environment. @@ -3548,37 +3541,6 @@ if test $SOLAR_JAVA != ; then AC_SUBST(AWTLIB) fi -dnl === -dnl Check for optional gcj for AOT -dnl === -if test $SOLAR_JAVA != ; then - AC_MSG_CHECKING([whether to enable gcj aot compilation]) - if test -n $enable_gcjaot test $enable_gcjaot != no; then - AC_MSG_RESULT([yes]) - if test `echo $WITH_JAVA | grep -c gij` -eq 0; then -gcjaot=gcj - else -gcjaot=`echo $WITH_JAVA | $SED -e s/gij/gcj/g` - fi - AC_MSG_RESULT([$gcjaot]) - if test -n $with_jdk_home; then -_javac_path=$with_jdk_home/bin/$gcjaot -dnl Check if there is a gcj at all. -if test -x $_javac_path; then - JAVAAOTCOMPILER=$_javac_path -fi - fi - if test -z $JAVAAOTCOMPILER; then -AC_PATH_PROG(JAVAAOTCOMPILER, $gcjaot) - fi - if test -z $JAVAAOTCOMPILER; then -AC_MSG_WARN([$gcjaot not found, set with_jdk_home]) - fi - else - AC_MSG_RESULT([no]) - fi -fi - AC_SUBST(JAVA_HOME) AC_SUBST(JDK) AC_SUBST(JAVAFLAGS) @@ -3587,7 +3549,6 @@ AC_SUBST(JAVA_TARGET_VER) AC_SUBST(JAVAINTERPRETER) AC_SUBST(JAVAIFLAGS) AC_SUBST(JAVACOMPILER) -AC_SUBST(JAVAAOTCOMPILER) AC_SUBST(JAVADOC) dnl === diff --git a/set_soenv.in b/set_soenv.in index 450f9fa..c914259 100755 --- a/set_soenv.in +++ b/set_soenv.in @@ -1786,7 +1786,6 @@ if ( '@JDK@' ne '' ) ToFile( JAVAINTERPRETER, PathFormat(@JAVAINTERPRETER@), e ); ToFile( JAVAIFLAGS, @JAVAIFLAGS@,e ); ToFile( JAVACOMPILER,PathFormat(@JAVACOMPILER@), e ); - ToFile( JAVAAOTCOMPILER, PathFormat(@JAVAAOTCOMPILER@), e ); ToFile( JAVADOC, PathFormat(@JAVADOC@), e ); } ToFile( SCPDEFS, '@SCPDEFS@',e ); -- 1.7.3.5 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Dead Java code
Hi Luke, thanks for that. But could you please use git format-patch for the next patches? Would be easier. Thanks for the patch! Thomas On 02/12/2011 06:15 PM, L P wrote: Deleted some more commented-out code in xmerge. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Easy hack: more commented out code
Hi Luke, I applied patchfile one only partially. These @param and @autor tags are important for javadoc. Thanks! Thomas On 02/12/2011 06:36 PM, Luke Petrolekas wrote: First patch deletes two commented lines out and removes four bogus comments. The second patch deletes some commented out returns. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Easy hack: more commented out code
Pushed. On 02/12/2011 06:57 PM, Thomas Arnhold wrote: Hi Luke, I applied patchfile one only partially. These @param and @autor tags are important for javadoc. Thanks! Thomas On 02/12/2011 06:36 PM, Luke Petrolekas wrote: First patch deletes two commented lines out and removes four bogus comments. The second patch deletes some commented out returns. Code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] More dead code in xmerge
This one got obsolete by one of your other patches. Thomas On 02/12/2011 05:56 PM, L P wrote: Deleted some more commented-out code in xmerge. code is contributed under the LGPLv3+ / MPL. Luke ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove bogus comments
Hi, thanks, looks nice! Pushed it! Thomas On 02/12/2011 09:12 PM, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove Xine
Hi, looks nice! I've build and run it without any problems. And I didn't find any references, too. Thomas On 02/12/2011 06:07 PM, Julien Nabet wrote: Hello, Here is a patch to remove xine. I didn't want to push it myself cause perhaps it needs to be reviewed. I just removed unxlng directory from avmedia, then I recompiled, it was ok. I also did a git grep xine, I didn't found anything else. Must I do a full compil ? Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments in components and impress
Thanks for all of them! I pushed them all. I deleted one additional line in cui/source/tabpages/numfmt.cxx: //@ aEdFormat.SetText( aLbFormat.GetSelectEntry() ); as this also belong to a deleted comment. Thomas On 02/13/2011 02:08 PM, Guillaume Poussel wrote: Second part. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [Patch] Remove bogus comments and dead code from editeng
Hi, nice, thanks for this! I pushed it. As far as I know there is no need to reformat the code, because this should be done by a script some time later (and we want to be compatible to diffs from OOo). Thomas On 02/13/2011 03:29 PM, Arnaud Versini wrote: Hi, Remove some comments from editeng module. Patch under LGPLv3+/MPL. Thanks -- Arnaud Versini ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments
Looks good. Thanks! I pushed it. Didn't know that there are bug numbers like this #b449874#. Thomas On 02/13/2011 01:57 AM, Antoine Proulx wrote: Hi, Here's a patch (another one) who removes bogus comments. It's released under the LGPLv3+ / MPL. Antoine ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [Patch] Easy hack: idl removed and translated comments
Thanks! I pushed it all. Thomas On 02/13/2011 01:26 AM, Michael Münch wrote: Hi, first attempt so I will take any advise (split the patch into smaller files?). License is LGPLv3+/MPL. I would have edited the wiki that I am working on this directory but the registration is disabled. Regards, Michael ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Christoph thanks for the discussion link and the specs! On 02/12/2011 10:01 PM, Michael Meeks wrote: On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote: what the heck do we do with Tools - Media Player? Do we need this within an office suite? Is anyone using this?! :-) My suspicion is that ~no-one is using it. I think the same. If I add an video to a presentation I know what file I want to add. And if I want a preview of a specific file this should be done by the filepicker. Without adding too many thoughts, here is the corresponding thread with some answers and the original specification (linked). Maybe this helps The link to the spec. is: http://specs.openoffice.org/appwide/media_player/MediaPlayer.sxw Which (on reading) suggests to me that the only useful uses of this beastie is two fold: a) to allow playback controls to appear / be used when playing + presuambly we can / should do this for embedded media anyway in some suitably tasteful way. b) to allow video files to be previewed from the gallery + cf. the difficulty of building galleries, and the fact that I've never seen any video in one + cf. the fact that I just failed to add an mgp or ogg to a gallery, via the properties dialog. So - I think b) is fairly bogus (or the gallery addition code needs some real work), a) is a real use-case; it seems we throw up the media player for preview sounds in the shipped gallery. Ah, I didn't see that sound files in the gallery use this player. I my opinion we could remove Tools - Media Player from the menu and let it act in the background for the gallery and embed media in documents. I tested to create a new gallery. There is some kind of lack of user experience: Open the gallery, then New theme, tab Files and then you have to click Find files at first to scan a directory for media contents. When this is done all media files get added to the list below and you could click Add or Add all to add these files to the gallery. Paradoxically, if you forget to click Find files and directly go to Add this is also possible, but with a very limited list of supported file formats (only images). That's some kind of strange. I've added ogg and mpg files and some more formats into the gallery. Works fine. Only lack is the list of supported formats. I manually added a flv-file with Insert - Movie and Sound (thats the player). But you have to choose All files. Within the gallery there is no such option. With the consequence that I can't add flv files to it, despite the fact that the player plays it ;) With Insert you have two possible options to add media content to the document: Insert - Movie and Sound or Insert - Object - Video/Sound. I think the second is deprecated as it doesn't really work. The gallery does add sounds and videos like Movie and Sound. So - IMHO the player-let is useful, but I'd be amazed if people really used it in anger; it is rather lame. Removing it from the menus in everything but impress might make some sense (?) Yeah for impress it is very useful. But why remove the possibility to add videos and other media to the files. I think in the background in it's the same, isn't it?! So the question is: - remove Tools - Media Player - remove Insert - Objects - Sound and Insert - Objects - Video Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove Xine
I did this already, as the registration for the wiki doesn't work at the moment. Thomas On 02/13/2011 10:19 PM, Caolán McNamara wrote: On Sat, 2011-02-12 at 18:07 +0100, Julien Nabet wrote: Hello, Here is a patch to remove xine. I think that was an Easy Hack, can you remove it from that list and move it to the completed one, stick you name on it there then. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Easy hack: remove obsolete gjc aot compilation
I pushed it now. Wanted that someone had a look at it ;) On 02/13/2011 10:38 PM, Caolán McNamara wrote: On Sat, 2011-02-12 at 17:02 +0100, Thomas Arnhold wrote: And I removed configure.cmd as it's a personal file (local paths and so on). Yeah, remove that, and the aot removal looks good too. I added that in as a desperate measure to shrink the helpcontent2 build time from 28 hours to 8 or so back in the day when it was build with some java tooling and the only free java we had was gcj. Rewrote in c++ ages ago so the aot support doesn't do anything useful anymore really. You haven't pushed these yet though I think ? Should be ok to do so. Of course java returned with the lucene stuff in there, but at least openjdk is available. Still would be great to see if clucene would work in there instead of lucene. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments
Thanks! On 02/14/2011 02:01 PM, Thorsten Behrens wrote: Thomas Arnhold wrote: Didn't know that there are bug numbers like this #b449874#. Those are from the old Sun-internal bugtracker (in contrast to the old StarDivision-internal bugtracker, which is w/o letter prefix) - and can be elided as well. Pushed a change that does that. Cheers, -- Thorsten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] duplicate code (binfilter)
I've updated the wiki. On 02/14/2011 10:40 AM, Michael Meeks wrote: Hi Christina, On Sat, 2011-02-12 at 21:07 +0100, Christina Roßmanith wrote: binfilter/bf_svtools/source/config/svt_menuoptions.cxx and svtools/source/config/menuoptions.cxx So - as Tor says, binfilter is substantially duplicate code, and code that is dying fast - we have a hero removing at half of it (the write support) right now. So - IMHO it is best to focus (and update the wiki) to state tat we should ignore any translation tasks in the binfilter code - it is just wasteage as of now, since the code may disappear quite soon. Thanks ! Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Partially Pushed] Patch
Hi Balint, looks good. I've pushed the second one. I slightly changed your patch - removed the newlines for the empty methods and didn't remove the description in writerfilter/inc/doctok/WW8Document.hxx as this is some kind of doxygen code. For the first patch, which removes the method, I'm not fully sure. I've applied it locally and it compiles fine. But it would be great if someone else could review this, too. Thomas On 02/14/2011 12:49 PM, Bálint Dózsa wrote: Hy, I have removed some dead code (0002-Remove-dead-code.patch), and one unused method (0001-Remove-unused-method-GetListTable.patch). Regards, Balint Dozsa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Patch
Now I'm sure. It's unused. But the question is, if we want to use GetListTable() in DomainMapper class to replace pImpl-GetListTable() with GetListTable(). Could be the case, that this was prepared to. But wouldn't make anything better ;) So I pushed it, thanks! Thomas On 02/14/2011 05:49 PM, Thomas Arnhold wrote: Hi Balint, looks good. I've pushed the second one. I slightly changed your patch - removed the newlines for the empty methods and didn't remove the description in writerfilter/inc/doctok/WW8Document.hxx as this is some kind of doxygen code. For the first patch, which removes the method, I'm not fully sure. I've applied it locally and it compiles fine. But it would be great if someone else could review this, too. Thomas On 02/14/2011 12:49 PM, Bálint Dózsa wrote: Hy, I have removed some dead code (0002-Remove-dead-code.patch), and one unused method (0001-Remove-unused-method-GetListTable.patch). Regards, Balint Dozsa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Files without Copyright notice
Hi, I stumbled across some files w/o any copyright notice in writerfilter/source/dmapper. So I grep'ed around and found are more or less long list of files with copyright notice missing. I've attached it to the mail. I've only searched for cxx and hxx files. I filed a bug at OOo: http://qa.openoffice.org/issues/show_bug.cgi?id=116962 If someone wants to grep for more files (others than hxx and cxx), here are the commands: find . -name *.cxx -or -name *.hxx | grep -v unxlng | sort /tmp/list for i in `cat /tmp/list`; do grep -H -m1 'Copyright' $i | cut -d':' -f1; done | sort /tmp/list.copy diff -u /tmp/list.copy /tmp/list | grep '^+' | cut -d'+' -f2 Thomas ./base/dbaccess/source/inc/constasciistring.hxx ./base/reportdesign/source/inc/constasciistring.hxx ./calc/sc/source/filter/excel/xltoolbar.cxx ./calc/sc/source/filter/excel/xltoolbar.hxx ./calc/sc/source/ui/vba/testvba/testvba.cxx ./components/cui/source/inc/cuiimapwnd.hxx ./components/cui/source/inc/cuitbxform.hxx ./components/forms/source/inc/forms_module_impl.hxx ./components/forms/source/xforms/xformsevent.hxx ./components/forms/source/xforms/xforms_services.hxx ./components/forms/source/xforms/xpathlib/extension.hxx ./components/forms/source/xforms/xpathlib/xpathlib.hxx ./components/setup_native/source/win32/customactions/quickstarter/quickstarter.cxx ./components/setup_native/source/win32/customactions/quickstarter/quickstarter.hxx ./components/setup_native/source/win32/customactions/rebase/rebase.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/msihelper.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/msihelper.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/registrar.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/registrar.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/registrationcontextinformation.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/registrationcontextinformation.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/registryexception.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/registryexception.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/registryvalueimpl.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/registryvalueimpl.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/userregistrar.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/userregistrar.hxx ./components/setup_native/source/win32/customactions/reg4msdoc/windowsregistry.cxx ./components/setup_native/source/win32/customactions/reg4msdoc/windowsregistry.hxx ./components/setup_native/source/win32/stwrapper/stwrapper.cxx ./components/xmlsecurity/tools/standalone/mscsfit/certmngr.cxx ./components/xmlsecurity/tools/standalone/mscsfit/decrypter.cxx ./components/xmlsecurity/tools/standalone/mscsfit/encrypter.cxx ./components/xmlsecurity/tools/standalone/mscsfit/helper.cxx ./components/xmlsecurity/tools/standalone/mscsfit/helper.hxx ./components/xmlsecurity/tools/standalone/mscsfit/signer.cxx ./components/xmlsecurity/tools/standalone/mscsfit/verifier.cxx ./extensions/mysqlc/source/mysqlc_propertyids.hxx ./extensions/mysqlc/source/mysqlc_statement.hxx ./filters/binfilter/bf_svtools/source/svdde/ddewrap.hxx ./filters/binfilter/bf_sw/source/core/inc/prevwpage.hxx ./filters/binfilter/inc/bf_svx/svxslots.hxx ./filters/binfilter/inc/bf_xmloff/functional.hxx ./filters/binfilter/inc/legacysmgr/legacy_binfilters_smgr.hxx ./filters/filter/inc/filter/msfilter/mstoolbar.hxx ./filters/filter/source/msfilter/mstoolbar.cxx ./filters/filter/source/svg/b2dellipse.cxx ./filters/filter/source/svg/b2dellipse.hxx ./filters/filter/source/svg/gfxtypes.hxx ./filters/filter/source/svg/parserfragments.cxx ./filters/filter/source/svg/parserfragments.hxx ./filters/filter/source/svg/spirit_supplements.hxx ./filters/filter/source/svg/svgreader.cxx ./filters/filter/source/svg/svgreader.hxx ./filters/filter/source/svg/test/parsertest.cxx ./filters/filter/source/svg/tokenmap.hxx ./filters/filter/source/svg/units.cxx ./filters/filter/source/svg/units.hxx ./filters/lotuswordpro/source/filter/genericfilter.cxx ./filters/lotuswordpro/source/filter/LotusWordProImportFilter.cxx ./filters/lotuswordpro/source/filter/LotusWordProImportFilter.hxx ./filters/oox/inc/oox/export/drawingml.hxx ./filters/unoxml/source/events/event.cxx ./filters/unoxml/source/events/eventdispatcher.cxx ./filters/unoxml/source/events/eventdispatcher.hxx ./filters/unoxml/source/events/event.hxx ./filters/unoxml/source/events/mouseevent.cxx ./filters/unoxml/source/events/mouseevent.hxx ./filters/unoxml/source/events/mutationevent.cxx ./filters/unoxml/source/events/mutationevent.hxx ./filters/unoxml/source/events/uievent.cxx ./filters/unoxml/source/events/uievent.hxx ./filters/writerfilter/documentation/AddingTable.cxx ./filters/writerfilter/qa/cppunittests/doctok/testdoctok.cxx
Re: [Libreoffice] [PUSHED] [PATCH] cppcheck easyhack
Thanks! Pushed it. Thomas On 02/14/2011 07:54 PM, Kevin Hunter wrote: Hullo List, One, likely final, cppcheck-found post- to pre-iterator patch. Cheers, Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Files without Copyright notice
On 02/14/2011 09:32 PM, Caolán McNamara wrote: On Mon, 2011-02-14 at 19:45 +0100, Thomas Arnhold wrote: Hi, I stumbled across some files w/o any copyright notice in writerfilter/source/dmapper. So I grep'ed around and found are more or less long list of files with copyright notice missing. I've attached it to the mail. I've only searched for cxx and hxx files. I filed a bug at OOo: http://qa.openoffice.org/issues/show_bug.cgi?id=116962 Some of these are our own, e.g. I forgot to add a copyright line for the swdoc-test.cxx when I cut and pasted the MPL template. Fixed now. I suspect the same is true for ww8toolbar.*xx, the vba stuff and some other bits here and there. C. Yes, some of them. I've corrected the list. Many of them don't have copyright in OOo, too. I've updated the bug. And attached a file to this mail with LibO specific files w/o copyright notice. You're right with ww8toolbar.* Thomas filter/inc/filter/msfilter/mstoolbar.hxx filter/source/msfilter/mstoolbar.cxx filter/source/svg/b2dellipse.cxx filter/source/svg/b2dellipse.hxx filter/source/svg/gfxtypes.hxx filter/source/svg/parserfragments.cxx filter/source/svg/parserfragments.hxx filter/source/svg/spirit_supplements.hxx filter/source/svg/svgreader.cxx filter/source/svg/svgreader.hxx filter/source/svg/test/parsertest.cxx filter/source/svg/tokenmap.hxx filter/source/svg/units.cxx filter/source/svg/units.hxx i18npool/qa/cppunit/test_breakiterator.cxx lotuswordpro/source/filter/genericfilter.cxx lotuswordpro/source/filter/LotusWordProImportFilter.cxx lotuswordpro/source/filter/LotusWordProImportFilter.hxx Mesa/inc/gl_mangle.h Mesa/inc/vms_x_fix.h sc/source/filter/excel/xltoolbar.cxx sc/source/filter/excel/xltoolbar.hxx slideshow/source/engine/OGLTrans/mac/aquaOpenGLView.h svtools/inc/filterutils.hxx svtools/inc/svtools/filechangedchecker.hxx svtools/inc/svtools/langhelp.hxx svtools/source/misc/filechangedchecker.cxx svtools/source/misc/filterutils.cxx svtools/source/misc/langhelp.cxx sw/qa/core/swdoc-test.cxx sw/source/filter/ww8/ww8toolbar.cxx sw/source/filter/ww8/ww8toolbar.hxx sw/source/ui/docvw/extedit.cxx sw/source/ui/inc/extedit.hxx tools/qa/test_strings.cxx ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Supported arches
Hi, i stumbled across some precompiler checks for several (deprecated?) arches: HP9000 (already removed some parts of this) SINIX RM400 ... And another thing, in combination with GCC: C272 (occurs with GCC) i.e. at impress/sd/source/ui/view/zoomlist.cxx:#if ( defined GCC defined C272 ) . Doesn't look that this is set anymore. There is a full list of this stuff at bootstrap/solenv/bin/modules/osarch.pm My question: Is there a official list of supported hardware platforms or operating systems? I think we should remove this old stuff, because nearly nobody compiles and runs LibO on this systems - if they are in use anymore. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Hi, On 02/12/2011 10:01 PM, Michael Meeks wrote: On Fri, 2011-02-11 at 23:08 +0100, Christoph Noack wrote: what the heck do we do with Tools - Media Player? Do we need this within an office suite? Is anyone using this?! :-) My suspicion is that ~no-one is using it. I think the same. If I add an video to a presentation I know what file I want to add. And if I want a preview of a specific file this should be done by the filepicker. Short: I share this view ... Long: But, some of the tracked usage seems to say some (strange) uses, maybe tries, maybe clicks on the wrong menu item, but at least some uses (see the end of the mail). Personally, I think we don't loose that much by removing the entry from the menu. Instead, we gain a more clean menu layout. Thomas, I'm not aware of that many file pickers being able to preview videos (given our platform support). Sometimes the Media Player might indeed be handy, e.g. to preview videos that got random names (e.g. from a camera). And, it seems that using the Media Player, previewing the video files seems much faster than prior embedding to the document (subjective, of course). However, we might rely on the operating system in such cases ... any further thoughts? GtkFileChooser has preview options (as used in gimp) and KDE provides KFilePreview. So this should be done by them. At this moment preview options are not implemented for movie/sound adding. For Insert - Images this is working. I think videos are not previewed by GtkFileChooser at this moment. I tested to create a new gallery. There is some kind of lack of user experience: Open the gallery, then New theme, tab Files and then you have to click Find files at first to scan a directory for media contents. When this is done all media files get added to the list below and you could click Add or Add all to add these files to the gallery. Paradoxically, if you forget to click Find files and directly go to Add this is also possible, but with a very limited list of supported file formats (only images). That's some kind of strange. I've added ogg and mpg files and some more formats into the gallery. Works fine. Only lack is the list of supported formats. I manually added a flv-file with Insert - Movie and Sound (thats the player). But you have to choose All files. Within the gallery there is no such option. With the consequence that I can't add flv files to it, despite the fact that the player plays it ;) Wow, thanks for the detailed description. I only checked the former one - same for me. So we should update the file list or add a option All Files or All video files. If the file isn't supported by the player it should handle this. With Insert you have two possible options to add media content to the document: Insert - Movie and Sound or Insert - Object - Video/Sound. I think the second is deprecated as it doesn't really work. The gallery does add sounds and videos like Movie and Sound. So - IMHO the player-let is useful, but I'd be amazed if people really used it in anger; it is rather lame. Removing it from the menus in everything but impress might make some sense (?) Yeah for impress it is very useful. But why remove the possibility to add videos and other media to the files. I think in the background in it's the same, isn't it?! So the question is: - remove Tools - Media Player - remove Insert - Objects - Sound and Insert - Objects - Video Fine from my point-of-view (as Michael suggested, keep Media Player for Impress?). But since those objects are supported in all applications, please keep View - Toolbars - Media Playback. Yes, View - Toolbars - Media Playback should be kept. === Usage Data === Data (end of 2009) ... the use of the menu bar item for opening / closing the media player (.uno:AVMediaPlayer MenuBarManager) * Writer: 638 * Calc: 152 * Impress: 594 * Draw: 77 * All Applications: 2063 Of course, these are only relative values - so here is the comparison to the Gallery item in the same menu - All Applications: 7919 Looks strange, doesn't it? Especially since Writer seems to outperform Impress. (???) Really strange ;) Nice feature indeed, to play movies in a document :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] fdo#32552 (alt key opens File-menu)
Hi Julien,
I've compiled and tested it. Works fine. I read the bug description and
there was said, that on Windows Alt works as F6 on Linux - to set focus
on the menubar. Now we completely got rid of this with Alt on Linux. Is
this intentionally, say that Alt alone has no effect at all?
I slightly changed your patch - removed the unused variable.
Thomas
On 02/15/2011 10:22 PM, Julien Nabet wrote:
Hello,
Here is small patch to close the tracker 32552 (alt key opens File-menu).
I removed the block quoted in the comments, it compiles but I didn't
test it. I use Gnome and so Gtk on my Debian.
Could someone confirm it's ok (or not) ?
Julien.
(LGPLv3+ / MPL)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
From c9f7793ad6ee79b569ab0c7b6abd080bc108bb85 Mon Sep 17 00:00:00 2001
From: Julien Nabet serval2...@yahoo.fr
Date: Tue, 15 Feb 2011 22:29:40 +0100
Subject: [PATCH] fdo#32552 (alt key opens File-menu)
---
vcl/unx/source/window/salframe.cxx | 23 +--
1 files changed, 1 insertions(+), 22 deletions(-)
diff --git a/vcl/unx/source/window/salframe.cxx
b/vcl/unx/source/window/salframe.cxx
index f52f780..5f40c20 100644
--- a/vcl/unx/source/window/salframe.cxx
+++ b/vcl/unx/source/window/salframe.cxx
@@ -3292,28 +3292,7 @@ long X11SalFrame::HandleKeyEvent( XKeyEvent *pEvent )
aModEvt.mnCode = nModCode;
aModEvt.mnTime = pEvent-time;
-int nRet = CallCallback( SALEVENT_KEYMODCHANGE, aModEvt );
-
-// emulate KEY_MENU
-if ( ( (nKeySym == XK_Alt_L) || (nKeySym == XK_Alt_R) )
- ( (nModCode ~(KEY_MOD3|KEY_MOD2)) == 0 ) )
-{
-if( pEvent-type == XLIB_KeyPress )
-mbKeyMenu = true;
-else if( mbKeyMenu )
-{
-// simulate KEY_MENU
-aKeyEvt.mnCode= KEY_MENU | nModCode;
-aKeyEvt.mnRepeat = 0;
-aKeyEvt.mnTime= pEvent-time;
-aKeyEvt.mnCharCode = 0;
-nRet = CallCallback( SALEVENT_KEYINPUT, aKeyEvt );
-nRet = CallCallback( SALEVENT_KEYUP, aKeyEvt );
-}
-}
-else
-mbKeyMenu = false;
-return nRet;
+return CallCallback( SALEVENT_KEYMODCHANGE, aModEvt );
}
mbSendExtKeyModChange = mbKeyMenu = false;
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Files without Copyright notice
Yeah, thanks for fixing them :) Thomas On 02/16/2011 09:36 AM, Noel Power wrote: Hi Thomas, On 14/02/11 21:02, Thomas Arnhold wrote: On 02/14/2011 09:32 PM, Caolán McNamara wrote: On Mon, 2011-02-14 at 19:45 +0100, Thomas Arnhold wrote: Yes, some of them. I've corrected the list. Many of them don't have copyright in OOo, too. I've updated the bug. And attached a file to this mail with LibO specific files w/o copyright notice. You're right with ww8toolbar.* couple of those are mine ( or sortof mine ) thanks for finding them, I fix them [1] today thanks again Noel [1] filter/inc/filter/msfilter/mstoolbar.hxx filter/source/msfilter/mstoolbar.cxx sc/source/filter/excel/xltoolbar.cxx sc/source/filter/excel/xltoolbar.hxx sw/source/filter/ww8/ww8toolbar.cxx sw/source/filter/ww8/ww8toolbar.hxx lotuswordpro/source/filter/LotusWordProImportFilter.cxx lotuswordpro/source/filter/LotusWordProImportFilter.hxx ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Files without Copyright notice
Hi Caolán, I'm looking ahead this at the weekend. Maybe it's worth a task to write a little lint script which checks if new files have a copyright header. Thomas On 02/14/2011 10:10 PM, Caolán McNamara wrote: On Mon, 2011-02-14 at 22:02 +0100, Thomas Arnhold wrote: You're right with ww8toolbar.* We need to make a list of the ones that belong to LibreOffice solely and have no copyright attribution and nag the initial committer to stick a correct header on top. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Supported arches
Hi, And another thing, in combination with GCC: C272 (occurs with GCC) i.e. at impress/sd/source/ui/view/zoomlist.cxx:#if ( defined GCC defined C272 ) . Doesn't look that this is set anymore. Yeah, you got me there. No idea where C272 came from. I strongly suspect it was set to indicate gcc 2.7.2. That was my first thought, too. Now there's only one occurrence, I'll check this later. My question: Is there a official list of supported hardware platforms or operating systems? I think we should remove this old stuff, because nearly nobody compiles and runs LibO on this systems - if they are in use anymore. I suppose we'll have to make such a list. All the Linux ports should remain, as should the BSDbased ones, MacOSX, Windows, Solaris and AIX as they work and are complete. The reality of what has a chance of working is the contents of bridges/source/cpp_uno (where the bsd's now share the linux bridges). OS/2 (eComStation) is the borderline one there, there was some fairly recent activity in it, and a bridge exists so it might be working, but its vcl dir is likely quickly falling behind. HP-UX wouldn't work, neither would SINIX, nor the HP9000 and RM400 foo. Removed SINIX and HP9000 (except for bootstrap). So HP-UX could be removed as well? Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Supported arches
On 02/15/2011 10:28 PM, Caolán McNamara wrote: On Tue, 2011-02-15 at 22:22 +0100, Francois Tigeot wrote: Of the ports listed on http://porting.openoffice.org/ , Tru64 is dead and I would be surprised if VMS and Linux/m68k were much alive. Yeah, only take the completed one, VMS and Tru64 never actually happened. m68k only exists emulated :-), but it does work. *shrug*, its only one ifdef IIRC outside its bridge, its day might come again. I wouldn't have bet on seeing MIPS rise from the dead :-) http://en.wikipedia.org/wiki/Loongson C. Nice, didn't know that :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove dead code
Great! Pushed it! Thanks. Thomas On 02/16/2011 07:16 PM, Bálint Dózsa wrote: Hi, I have removed some dead code form //xml2cmp, /xmlhelp/ and //xmloff/. My code is under the LGPLv3+/MPL dual license. Regards, Balint Dozsa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove OSF/1 support
Hi Francois, in the meantime I removed HPUX and SCO support. Found out, that osarch.pm is pretty unused ;) I didn't touch libs-extern(-sys) and dmake, too. Your patchset looks good. Thomas On 02/16/2011 08:49 PM, Francois Tigeot wrote: The attached patches remove OSF/1 support from the build system and some application code. There are still OSF1 references in the following files: libs-extern/libtextcat/libtextcat-2.2.patch libs-extern/libxmlsec/xmlsec1-update-config-sub-and-guess.patch libs-extern-sys/python/Python-2.6.1-mingw.patch but since they are patches, I didn't dare modify them. I have also let dmake/ untouched. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove unused macro
On 02/16/2011 03:40 PM, Francois Tigeot wrote: On Wed, Feb 16, 2011 at 01:06:47PM +, Caolán McNamara wrote: On Wed, 2011-02-16 at 13:03 +0100, Francois Tigeot wrote: On Wed, Feb 16, 2011 at 08:55:12AM +, Caolán McNamara wrote: Are the UUID_SYSTEM_TIME_RESOLUTION_100NS_TICKS defines in sal/inc/rtl/uuid.h a part of that ? It looked completely bogus to me. *shrug*, the comment on it makes a certain degree of sense, on the other hand I don't think there's any uses of it in the source. I confirm there's no use of it anywhere. The attached patch removes all remaining instances of UUID_SYSTEM_TIME_RESOLUTION_100NS_TICKS . Yeah, really unused. http://opengrok.libreoffice.org/ is your friend ;) I've pushed it, thanks! Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] WIN16 references
On 02/16/2011 09:53 PM, Francois Tigeot wrote: On Wed, Feb 16, 2011 at 09:15:37PM +0100, Thomas Arnhold wrote: in the meantime I removed HPUX and SCO support. Looking at your diffs for the SCO stuff, I found a _WIN16 test. It seems many files are infected with WIN16 references, most of them in ure, components and libs-gui. I never would have thought there was Windows 3.x code in there !! Saw this, too. But I don't have the possibility to build on Windows systems. There should not be any problem to remove the parts, but I wanted to run a build at least. So if you want to remove it, just do it ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] WIN16 references
On 02/16/2011 09:53 PM, Francois Tigeot wrote: On Wed, Feb 16, 2011 at 09:15:37PM +0100, Thomas Arnhold wrote: in the meantime I removed HPUX and SCO support. Looking at your diffs for the SCO stuff, I found a _WIN16 test. It seems many files are infected with WIN16 references, most of them in ure, components and libs-gui. I never would have thought there was Windows 3.x code in there !! Ah and you could grep for MSDOS/DOS, too... Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
Hi,
TCPP seems to be an old compiler. Google doesn't know anything about it,
but there were some comments in the source which let me conclude that
this a compiler. I've removed it from filter and writer. For libs-gui I
need a review, because there's a fuzzy logic in rsc/source/prj/gui.cxx.
I assumed the precompiler reads this from the left.
Yesterday I've removed BLC, WTC, MTW leftovers from the source - got the
information from there:
http://www.openoffice.org/issues/show_bug.cgi?id=52746
C50 and C52 seem to be Solaris versions. So it's obvious C272 is such a
thing.
Thomas
From ce9dd25c9b5383daa6259a1e328d3409a0b60778 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 17 Feb 2011 10:21:47 +0100
Subject: [PATCH] Remove TCPP
Seems to be an old compiler
---
rsc/source/prj/gui.cxx |2 +-
rsc/source/prj/start.cxx |4 ++--
rsc/source/rscpp/cppmain.c |4
svl/inc/svl/svarray.hxx | 17 -
tools/source/fsys/wntmsc.hxx |9 -
5 files changed, 3 insertions(+), 33 deletions(-)
diff --git a/rsc/source/prj/gui.cxx b/rsc/source/prj/gui.cxx
index ea8a2c3..046da64 100644
--- a/rsc/source/prj/gui.cxx
+++ b/rsc/source/prj/gui.cxx
@@ -43,7 +43,7 @@ static RscCompiler * pRscCompiler = NULL;
/*
*/
/* Description : Gibt die Temporaeren Dateien frei.
*/
//
-#if defined( UNX ) || ( defined( OS2 ) ( defined( TCPP ) || defined ( GCC
)) ) || defined(__MINGW32__)
+#if defined( UNX ) || defined ( GCC ) || defined(__MINGW32__)
void ExitProgram( void ){
#else
#if defined( CSET )
diff --git a/rsc/source/prj/start.cxx b/rsc/source/prj/start.cxx
index 3cdd32c..a4125f5 100644
--- a/rsc/source/prj/start.cxx
+++ b/rsc/source/prj/start.cxx
@@ -175,7 +175,7 @@ static BOOL CallPrePro( const ByteString rPrePro,
}
}
-#if ((defined OS2 || defined WNT) (defined TCPP || defined tcpp)) ||
defined UNX || defined OS2
+#if defined UNX || defined OS2
nExit = spawnvp( P_WAIT, rPrePro.GetBuffer(), (char*
const*)pCmdL-GetBlock() );
#elif defined CSET
nExit = spawnvp( P_WAIT, (char*)rPrePro.GetBuffer(), (const
char**)pCmdL-GetBlock() );
@@ -287,7 +287,7 @@ static BOOL CallRsc2( ByteString aRsc2Name,
printf( \n );
}
-#if ((defined OS2 || defined WNT) (defined TCPP || defined tcpp)) ||
defined UNX || defined OS2
+#if defined UNX || defined OS2
nExit = spawnvp( P_WAIT, aRsc2Name.GetBuffer(), (char*
const*)aNewCmdL.GetBlock() );
#elif defined CSET
nExit = spawnvp( P_WAIT, (char*)aRsc2Name.GetBuffer(), (char **)(const
char**)aNewCmdL.GetBlock() );
diff --git a/rsc/source/rscpp/cppmain.c b/rsc/source/rscpp/cppmain.c
index 598fded..667f9e5 100644
--- a/rsc/source/rscpp/cppmain.c
+++ b/rsc/source/rscpp/cppmain.c
@@ -37,10 +37,6 @@ int main( argc, argv )
int argc;
char *argv[];
{
-#ifdef TSTCPP
-( start_cpp( argc, argv ) );
-puts(erster teil ist fertig );
-#endif
return( start_cpp( argc, argv ) );
}
diff --git a/svl/inc/svl/svarray.hxx b/svl/inc/svl/svarray.hxx
index bd1deb8..efece4c 100644
--- a/svl/inc/svl/svarray.hxx
+++ b/svl/inc/svl/svarray.hxx
@@ -843,28 +843,11 @@ void nm::Remove( const AE aE, USHORT nL )\
nm##_SAR::Remove( nP, nL);\
}\
-#if defined(TCPP)
-
-#define _SORTARR_BLC_CASTS(nm, AE )\
-BOOL Insert( AE aE ) {\
-return Insert( (const AE)aE );\
-}\
-USHORT GetPos( AE aE ) const { \
-return SvPtrarr::GetPos((const VoidPtr)aE);\
-}\
-void Remove( AE aE, USHORT nL = 1 ) { \
-Remove( (const AE) aE, nL );\
-}
-
-#else
-
#define _SORTARR_BLC_CASTS(nm, AE )\
USHORT GetPos( const AE aE ) const { \
return SvPtrarr::GetPos((const VoidPtr)aE);\
}
-#endif
-
#define _SV_DECL_PTRARR_SORT_ALG(nm, AE, IS, GS, vis)\
SV_DECL_PTRARR_VISIBILITY(nm##_SAR, AE, IS, GS, vis)\
_SORT_CLASS_DEF(nm, AE, IS, GS, vis)\
diff --git a/tools/source/fsys/wntmsc.hxx b/tools/source/fsys/wntmsc.hxx
index b4226a7..c2719f5 100644
--- a/tools/source/fsys/wntmsc.hxx
+++ b/tools/source/fsys/wntmsc.hxx
@@ -66,15 +66,6 @@
#define d_name cFileName
#define d_type dwFileAttributes
-#if defined (TCPP) || defined (tcpp)
-#define _mkdir mkdir
-#define _rmdir rmdir
-#define _chdir chdir
-#define _unlink unlink
-#define _getcwd getcwd
-#define _access access
-#endif
-
typedef struct
{
_WIN32_FIND_DATAA aDirEnt;
--
1.7.3.5
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
Ah, forgot one.
On 02/17/2011 10:31 AM, Thomas Arnhold wrote:
Hi,
TCPP seems to be an old compiler. Google doesn't know anything about it,
but there were some comments in the source which let me conclude that
this a compiler. I've removed it from filter and writer. For libs-gui I
need a review, because there's a fuzzy logic in rsc/source/prj/gui.cxx.
I assumed the precompiler reads this from the left.
Yesterday I've removed BLC, WTC, MTW leftovers from the source - got the
information from there:
http://www.openoffice.org/issues/show_bug.cgi?id=52746
C50 and C52 seem to be Solaris versions. So it's obvious C272 is such a
thing.
Thomas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
From 58708bbecaab8715414380dc6833fe19031cfc43 Mon Sep 17 00:00:00 2001
From: Thomas Arnhold tho...@arnhold.org
Date: Thu, 17 Feb 2011 10:33:57 +0100
Subject: [PATCH] Remove TCPP
Seems to be an old compiler
---
rsc/source/prj/gui.cxx |2 +-
rsc/source/prj/start.cxx |8 ++--
rsc/source/rscpp/cppmain.c |4
svl/inc/svl/svarray.hxx | 17 -
tools/source/fsys/wntmsc.hxx |9 -
5 files changed, 3 insertions(+), 37 deletions(-)
diff --git a/rsc/source/prj/gui.cxx b/rsc/source/prj/gui.cxx
index ea8a2c3..046da64 100644
--- a/rsc/source/prj/gui.cxx
+++ b/rsc/source/prj/gui.cxx
@@ -43,7 +43,7 @@ static RscCompiler * pRscCompiler = NULL;
/*
*/
/* Description : Gibt die Temporaeren Dateien frei.
*/
//
-#if defined( UNX ) || ( defined( OS2 ) ( defined( TCPP ) || defined ( GCC
)) ) || defined(__MINGW32__)
+#if defined( UNX ) || defined ( GCC ) || defined(__MINGW32__)
void ExitProgram( void ){
#else
#if defined( CSET )
diff --git a/rsc/source/prj/start.cxx b/rsc/source/prj/start.cxx
index 3cdd32c..0738d17 100644
--- a/rsc/source/prj/start.cxx
+++ b/rsc/source/prj/start.cxx
@@ -33,10 +33,6 @@
#include stdio.h
#include fcntl.h
#include string.h
-#if defined (WNT) defined (tcpp)
-#define _spawnvp spawnvp
-#define _P_WAIT P_WAIT
-#endif
#ifdef UNX
#include unistd.h
@@ -175,7 +171,7 @@ static BOOL CallPrePro( const ByteString rPrePro,
}
}
-#if ((defined OS2 || defined WNT) (defined TCPP || defined tcpp)) ||
defined UNX || defined OS2
+#if defined UNX || defined OS2
nExit = spawnvp( P_WAIT, rPrePro.GetBuffer(), (char*
const*)pCmdL-GetBlock() );
#elif defined CSET
nExit = spawnvp( P_WAIT, (char*)rPrePro.GetBuffer(), (const
char**)pCmdL-GetBlock() );
@@ -287,7 +283,7 @@ static BOOL CallRsc2( ByteString aRsc2Name,
printf( \n );
}
-#if ((defined OS2 || defined WNT) (defined TCPP || defined tcpp)) ||
defined UNX || defined OS2
+#if defined UNX || defined OS2
nExit = spawnvp( P_WAIT, aRsc2Name.GetBuffer(), (char*
const*)aNewCmdL.GetBlock() );
#elif defined CSET
nExit = spawnvp( P_WAIT, (char*)aRsc2Name.GetBuffer(), (char **)(const
char**)aNewCmdL.GetBlock() );
diff --git a/rsc/source/rscpp/cppmain.c b/rsc/source/rscpp/cppmain.c
index 598fded..667f9e5 100644
--- a/rsc/source/rscpp/cppmain.c
+++ b/rsc/source/rscpp/cppmain.c
@@ -37,10 +37,6 @@ int main( argc, argv )
int argc;
char *argv[];
{
-#ifdef TSTCPP
-( start_cpp( argc, argv ) );
-puts(erster teil ist fertig );
-#endif
return( start_cpp( argc, argv ) );
}
diff --git a/svl/inc/svl/svarray.hxx b/svl/inc/svl/svarray.hxx
index bd1deb8..efece4c 100644
--- a/svl/inc/svl/svarray.hxx
+++ b/svl/inc/svl/svarray.hxx
@@ -843,28 +843,11 @@ void nm::Remove( const AE aE, USHORT nL )\
nm##_SAR::Remove( nP, nL);\
}\
-#if defined(TCPP)
-
-#define _SORTARR_BLC_CASTS(nm, AE )\
-BOOL Insert( AE aE ) {\
-return Insert( (const AE)aE );\
-}\
-USHORT GetPos( AE aE ) const { \
-return SvPtrarr::GetPos((const VoidPtr)aE);\
-}\
-void Remove( AE aE, USHORT nL = 1 ) { \
-Remove( (const AE) aE, nL );\
-}
-
-#else
-
#define _SORTARR_BLC_CASTS(nm, AE )\
USHORT GetPos( const AE aE ) const { \
return SvPtrarr::GetPos((const VoidPtr)aE);\
}
-#endif
-
#define _SV_DECL_PTRARR_SORT_ALG(nm, AE, IS, GS, vis)\
SV_DECL_PTRARR_VISIBILITY(nm##_SAR, AE, IS, GS, vis)\
_SORT_CLASS_DEF(nm, AE, IS, GS, vis)\
diff --git a/tools/source/fsys/wntmsc.hxx b/tools/source/fsys/wntmsc.hxx
index b4226a7..c2719f5 100644
--- a/tools/source/fsys/wntmsc.hxx
+++ b/tools/source/fsys/wntmsc.hxx
@@ -66,15 +66,6 @@
#define d_name cFileName
#define d_type dwFileAttributes
-#if defined (TCPP) || defined (tcpp)
-#define _mkdir mkdir
-#define _rmdir rmdir
-#define _chdir chdir
-#define _unlink
Re: [Libreoffice] [PATCH] 386BSD and MACH defines.
Nice. I let those files untouched, thought they came from X. I'll remove hpux and this other stuff soon. Thomas On 02/21/2011 05:19 PM, Francois Tigeot wrote: The attached patch a 386BSD #defined test (the only one ?) If nobody objects, I'll push it in a few hours. I have left the MACH test intact. Does someone know if it is useful to have around or if it corresponds to another dead system ? AFAIK, MacOS X uses a Mach kernel but its associated #define is MACOSX ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build speedup
On 02/17/2011 01:02 PM, Francois Tigeot wrote: On Thu, Feb 17, 2011 at 10:08:58AM +, Caolán McNamara wrote: CSET is probably also complete foo IIRC. Though I don't know to what it referred. I don't know if these cleanups are the reason, but my builds are now faster by a few minutes. I'm down to 2:38 on a 3GHz Core 2. Maybe because binfilter/bf_sw write support is gone ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
On 02/17/2011 10:39 AM, Tor Lillqvist wrote: TCPP seems to be an old compiler. Turbo C++ ? --tml Yes, thanks :) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove TCPP support
On 02/17/2011 11:08 AM, Caolán McNamara wrote: On Thu, 2011-02-17 at 10:34 +0100, Thomas Arnhold wrote: Ah, forgot one. All looks good, go for it. CSET is probably also complete foo IIRC. Though I don't know to what it referred. C. IBM CSet C- Compiler - I'll remove this one, too. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx
Hi, I've recently replaced all ASSERT_ID() macros with OSL_ASSERT(). Therefore errhdl.[hc]xx became obsolete. So I removed these files. There was a line in errhdl.hxx: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? There is one file left in sw/source/core/except/ - dbgloop.cxx. It's header dbgloop.hxx defines the DBG_LOOP macro. Is this still used by anyone for debugging purpose? If not I'm glad to remove this one, as we get rid of this local debug stuff with it ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Removed ASSERT_ID and errhdl.[ch]xx
On 02/21/2011 06:37 PM, Caolán McNamara wrote: On Mon, 2011-02-21 at 18:20 +0100, Thomas Arnhold wrote: SW_DLLPUBLIC void AssertFail( USHORT, const sal_Char* ); With this removed I changed the API, right? Sure, but only an internal API, the external API, i.e. the bits that extensions link to, are a subset of the ones in the ure clone dir. Ah, ok. Thanks :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
Hi Martin,
I've pushed it. Please could you attach such a diff as patch next time?
Would be easier to commit it :) Thanks!
Thomas
On 02/21/2011 10:28 PM, Martin Kepplinger wrote:
This translates the few german code comments in the cctrl directory to
english.
This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple
license.
---
sw/source/ui/cctrl/popbox.cxx |2 +-
sw/source/ui/cctrl/swlbox.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sw/source/ui/cctrl/popbox.cxx b/sw/source/ui/cctrl/popbox.cxx
index 9005eb3..c9f8a2b 100644
--- a/sw/source/ui/cctrl/popbox.cxx
+++ b/sw/source/ui/cctrl/popbox.cxx
@@ -44,7 +44,7 @@ SwHelpToolBox::SwHelpToolBox( SwNavigationPI* pParent,
const ResId rResId )
void SwHelpToolBox::MouseButtonDown(const MouseEvent rEvt)
{
-// If doubleclick is detected use doublelick handler
+// If doubleclick is detected use doubleclick handler
if(rEvt.GetButtons() == MOUSE_RIGHT
0 == GetItemId(rEvt.GetPosPixel()))
{
diff --git a/sw/source/ui/cctrl/swlbox.cxx b/sw/source/ui/cctrl/swlbox.cxx
index 908007f..3dd0c00 100644
--- a/sw/source/ui/cctrl/swlbox.cxx
+++ b/sw/source/ui/cctrl/swlbox.cxx
@@ -68,7 +68,7 @@ SwComboBox::SwComboBox(Window* pParent, const ResId rId,
USHORT nStyleBits ):
ComboBox(pParent, rId),
nStyle(nStyleBits)
{
-// Verwaltung fuer die Stringlist aus der Resource aufbauen
+// create administration for the resource's Stringlist
USHORT nSize = GetEntryCount();
for( USHORT i=0; i nSize; ++i )
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Comment fix
I've pushed it. Thanks! Thomas On 02/21/2011 10:03 PM, Martin Kepplinger wrote: This fixes a typo that occured during translation. thanks. This is contributed under the terms of the LGPLv3+/MPL dual license. --- sw/source/ui/app/docsh2.cxx |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sw/source/ui/app/docsh2.cxx b/sw/source/ui/app/docsh2.cxx index cac1857..e614d89 100644 --- a/sw/source/ui/app/docsh2.cxx +++ b/sw/source/ui/app/docsh2.cxx @@ -393,7 +393,7 @@ BOOL SwDocShell::Insert( SfxObjectShell rSource, // SwDocStyleSheetPool::aStyleSheet that uses same members of // SwDocStyleSheetPool::Find. Therefore a copy has to be used // here. Attention: SfxStylessheetBase::SetFollow calls itself -// a SwDocStyleSheetBase::Find, so that it's not sufficiant to +// a SwDocStyleSheetPool::Find, so that it's not sufficiant to // to eliminate the Find-calls in this method. rtl::Reference SwDocStyleSheet xNewSheet( new SwDocStyleSheet( (SwDocStyleSheet)pMyPool ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translation of German comment in libs-core/svx/source/customshapes/
Hi Albert, thanks! I've pushed it. But could you please separate your dead code removal and translation? It makes it hard to review this and if some dead looking code should come back later it's harder to do this (with translations in one diff). :) Thanks for your patches! Thomas On 02/21/2011 09:13 PM, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/customshapes. Made a few other fixes (removed out commented code) along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/dialog/
Yeah, thanks! Had some trouble with the diff - at the end of file there were some accidentally redos of some prior changes. I removed them (CSET and tools/list.h). And there were lots of trailing whitespaces. But now it's all fine. Thanks! Thomas On 02/21/2011 09:14 PM, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/dialog. Made a few other fixes (removed out commented code) along the way. You can commit the patch under the terms of MPL 1.1 / GPLv3+ / LGPLv3+ triple license. /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] How to start with some code?
Hi Rogerio, you could grep for it in the command line with grep '\$MINLEN' * -R or you could search the source with http://opengrok.libreoffice.org. Then you'll get libs-core/sfx2/source/dialog/password.* as result :) You've already done some contribution with this email! Would be nice if you could fill a bug for it. This could be an Easy Hack. Thanks! Thomas On 02/22/2011 04:32 AM, Rogerio Luz Coelho wrote: Ok I have found a glitch on the BrOffice product. The Message when asked for a password for protecting a document is wrong (See screen shot - the ($MINLEN) function is in view) How do I get to contribute to something like this? Just writing a Bug report? How do I find this message in ALL the code of LibreOffice? Thanks Rogerio ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Translation of German comment in libs-core/svx/source/dialog/
On 02/22/2011 01:52 AM, Kohei Yoshida wrote: On Mon, 2011-02-21 at 21:14 +0100, Albert Thuswaldner wrote: Hi, Translated German comments in libs-core/svx/source/dialog. Made a few other fixes (removed out commented code) along the way. Albert, @@ -515,9 +501,7 @@ void SvxRectCtl::Paint( const Rectangle ) } } -/* -|* -|* Konvertiert RECT_POINT in Point +// Convert RECT_POINT Point |* \/ FYI the above hunk breaks the build. When replacing the comment with a simple C++ style comment, be sure to remove the lower part of the original commit frame (the part that begins with |* and everything until the */ on the next line). Thanks, Kohei Aaah, and I didn't see that. Sorry, shame on me. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
On 02/22/2011 12:06 AM, Martin Kepplinger wrote: Am 21.02.2011 23:08, schrieb Thomas Arnhold: Hi Martin, I've pushed it. Please could you attach such a diff as patch next time? Would be easier to commit it :) Thanks! Thomas On 02/21/2011 10:28 PM, Martin Kepplinger wrote: This translates the few german code comments in the cctrl directory to english. This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. --- Hi Thomas, So no git format-patch and send-email anymore? I'm so used to it. I'm not a git pro, but I think you actually don't have to _commit_ any changes. I directly send git-commits here and you can preserve my sha1. I'm not sure if you did that in my case. (strangely, I find my patches two times under 2 different git-commits in master now... well, I'm not a git-Pro :) I would appreciate it if you could check with others (Christina Rossmanith for example pushed earlier patches of mine) about how they apply a finished git-patch and get back to me if I really should change my behaviour. Of course I will happily try to do so if this is consensus here! Since I thought I would make life easier for me _and_ you the git way, I just wanted to check once again here. Hi Martin, sorry I got this wrong. I applied one using 'git am' (c5fdfa6f475fc084250). But wasn't sure if all this text in the commit message should be there. So I manually applied the other two of you. Yes, send-email is welcome, didn't know that it was your intention with the commit message :) The sums are different, because for dialog stuff I changed it (as described). And for the other one, afaik I removed an additional comment. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Translate german comments of writer/sw/source/ui/cctrl
On 02/22/2011 11:38 AM, Thomas Arnhold wrote: On 02/22/2011 12:06 AM, Martin Kepplinger wrote: Am 21.02.2011 23:08, schrieb Thomas Arnhold: Hi Martin, I've pushed it. Please could you attach such a diff as patch next time? Would be easier to commit it :) Thanks! Thomas On 02/21/2011 10:28 PM, Martin Kepplinger wrote: This translates the few german code comments in the cctrl directory to english. This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple license. --- Hi Thomas, So no git format-patch and send-email anymore? I'm so used to it. I'm not a git pro, but I think you actually don't have to _commit_ any changes. I directly send git-commits here and you can preserve my sha1. I'm not sure if you did that in my case. (strangely, I find my patches two times under 2 different git-commits in master now... well, I'm not a git-Pro :) I would appreciate it if you could check with others (Christina Rossmanith for example pushed earlier patches of mine) about how they apply a finished git-patch and get back to me if I really should change my behaviour. Of course I will happily try to do so if this is consensus here! Since I thought I would make life easier for me _and_ you the git way, I just wanted to check once again here. Hi Martin, sorry I got this wrong. I applied one using 'git am' (c5fdfa6f475fc084250). But wasn't sure if all this text in the commit message should be there. So I manually applied the other two of you. Yes, send-email is welcome, didn't know that it was your intention with the commit message :) The sums are different, because for dialog stuff I changed it (as described). And for the other one, afaik I removed an additional comment. Mixed up something. I left your patches unchanged. So why they differ in the checksum I don't know. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Hi, I've finally removed the menu entry from calc, writer and draw. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Yeah right, but on writer, calc and draw? It's still in impress. Or are you using it from the other apps? Thomas On 02/22/2011 09:47 PM, Kálmán „KAMI” Szalai wrote: Sometimes Mediaplayer is useful. Inserting video, preview, etc. KAMI ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
On 02/23/2011 05:46 AM, Jean-Baptiste Faure wrote: Perhaps you should ask end-users. Some users are using Draw or Writer as a replacement of MS-Publisher. Or Writer to edit their website. Maybe it is useful in these cases ? Right, the website thing came to my mind later, too. But as I said: I removed the Media Player only from the menu. You could still add Videos with Insert - Movie and Sound. And the Playback Toolbar is also still there (View - Toolbars - Media Playback). Should I revert these patches?! Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Remove include of no more existent errhdl.hxx
Hi Sébastien, On 02/23/2011 08:46 AM, Sébastien Le Ray wrote: This patch removes an include which prevent debug build of sw (the file has been deleted in commit 6aa93c291d18c7db6dbee73adc6c4aa1bdc88eda. I removed the whole except directory with dbgloop.cxx in it. Maybe your tree is out of date? :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Hi Yifan, On 02/23/2011 10:47 AM, Yifan Jiang wrote: I guess end-users could still bring the menu item back using the menu customization UI (Tools-Customize...-Menus). Is that right? That's possible. But for writer and calc the background calls are gone. So it won't work. Maybe I re-enable them, so someone could still customize his menus with Media Player enabled. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Remove unused methods
Hi Balint, not all of them are unused. getDropDownEntries() and getDropDownResult() are used at FormControlHelper.cxx. But the rest is fine. I applied the rest. Thanks! Thomas On 02/22/2011 05:11 PM, Bálint Dózsa wrote: Hi, I have removed some unused methods. Regards, Balint Dozsa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] removed commented code
Hi Christina, thanks, pushed this! Why don't you commit this by your self? Your patches look good! :) Thomas On 02/24/2011 01:37 PM, Christina Roßmanith wrote: Hi, continued to remove commented code lines. As usual under LGPLv3+ / MPL Christina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Remove unused commented variable
Hi,
pushed this. Thanks!
Thomas
On 02/23/2011 10:47 PM, Michael Lefevre wrote:
---
writerfilter/source/dmapper/PropertyMap.cxx |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index 07fee7f..1d07cb4 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -420,7 +420,6 @@ void SectionPropertyMap::ApplyBorderToPageStyles(
uno::Reference beans::XPropertySet xFirst;
uno::Reference beans::XPropertySet xSecond;
sal_Int32 nOffsetFrom = (nValue 0x00E0) 5;
-//sal_Int32 bPageDepth = (nValue 0x0018) 3; //unused infromation: 0
- in front 1 - in back
//todo: negative spacing (from ww8par6.cxx)
switch( nValue 0x07)
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove commented variable
Thanks, pushed this, too :)
Thomas
On 02/23/2011 11:11 PM, Michael Lefevre wrote:
Still code cleaning.
---
sc/source/ui/view/gridwin.cxx |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 1255eb3..f514fe6 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -4399,7 +4399,6 @@ void ScGridWindow::UpdateFormulas()
Point aScrPos = pViewData-GetScrPos( nX1, nY1, eWhich );
long nMirrorWidth = GetSizePixel().Width();
BOOL bLayoutRTL = pDoc-IsLayoutRTL( nTab );
-// unused variable long nLayoutSign = bLayoutRTL ? -1 : 1;
if ( bLayoutRTL )
{
long nEndPixel = pViewData-GetScrPos( nX2+1, nPosY, eWhich ).X();
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove more commented unused variables
Pushed this. Thanks! Thomas On 02/23/2011 11:03 PM, Michael Lefevre wrote: Keep cleaning the code, line by line. --- filter/source/flash/swfwriter.hxx |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/filter/source/flash/swfwriter.hxx b/filter/source/flash/swfwriter.hxx index e758a6f..35e04ab 100644 --- a/filter/source/flash/swfwriter.hxx +++ b/filter/source/flash/swfwriter.hxx @@ -197,9 +197,7 @@ public: void write( SvStream out ); void addUI32( sal_uInt32 nValue ); -//unused as of yet void addI32( sal_Int32 nValue ); void addUI16( sal_uInt16 nValue ); -//unused as of yet void addI16( sal_Int16 nValue ); void addUI8( sal_uInt8 nValue ); void addBits( BitStream rIn ); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build fails without gdb installed
Hi,
the latest build fails on sal cppunit tests, because I have no gdb
installed. This dependency is new, maybe because some tests got enabled.
I think configure should check for gdb and turn this test on/off.
---
--
- start unit test #1 on library ../../unxlngx6/lib/librtl_ByteSequence.so
--
:
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/thomas/temp/libreoffice/libo/clone/ure/sal/unxlngx6/lib:/home/thomas/temp/libreoffice/libo/solver/330/unxlngx6/lib
gdb -nx
--command=/home/thomas/temp/libreoffice/libo/solenv/bin/gdbtrycatchtrace
--args ../../unxlngx6/bin/cppunittester
../../unxlngx6/lib/librtl_ByteSequence.so
/bin/sh: gdb: command not found
dmake: Error code 127, while making 'test1'
Forcing regeneration of dependency info
---
Thomas
build -- version: 275224
=
Building module sal
=
Entering /home/thomas/temp/libreoffice/libo/sal/inc
mkout -- version: 1.8
Entering /home/thomas/temp/libreoffice/libo/sal/typesconfig
Compiling: sal/typesconfig/typesconfig.c
Making:typesconfig
unx
mkdir ../unxlngx6/inc/sal
:
LD_LIBRARY_PATH=${LD_LIBRARY_PATH+${LD_LIBRARY_PATH}:}/home/thomas/temp/libreoffice/libo/solver/330/unxlngx6/lib
../unxlngx6/bin/typesconfig ../unxlngx6/inc/sal/typesizes.h
char= signed char
short = signed short
int = signed int
long= signed long
long long = signed long long
sizeof(short) = 2
sizeof(int) = 4
sizeof(long)= 8
sizeof(long long) = 8
sizeof(float) = 4
sizeof(double) = 8
sizeof(void *) = 8
LITTLEENDIAN (Intel, x86-64, PowerPC(LE))
cannot read address (nil)
cannot write address (nil)
can read address 0x7fff5d3861c8
can write address 0x7fff5d3861c8
Access short on 8-Aligned Address : OK
Access short on 4-Aligned Address : OK
Access short on 2-Aligned Address : OK
Access short on 1-Aligned Address : OK
Access int on 8-Aligned Address : OK
Access int on 4-Aligned Address : OK
Access int on 2-Aligned Address : OK
Access int on 1-Aligned Address : OK
Access long on 8-Aligned Address : OK
Access long on 4-Aligned Address : OK
Access long on 2-Aligned Address : OK
Access long on 1-Aligned Address : OK
Access double on 8-Aligned Address : OK
Access double on 4-Aligned Address : OK
Access double on 2-Aligned Address : OK
Access double on 1-Aligned Address : OK
Entering /home/thomas/temp/libreoffice/libo/sal/osl/all
Making:all_oslall.dpslo
Making:all_oslall.dpobj
Compiling: sal/osl/all/utility.cxx
Compiling: sal/osl/all/filepath.c
Compiling: sal/osl/all/debugbase.cxx
Compiling: sal/osl/all/loadmodulerelative.cxx
Making:oslall.lib
Compiling: sal/osl/all/utility.cxx
Compiling: sal/osl/all/filepath.c
Compiling: sal/osl/all/debugbase.cxx
Compiling: sal/osl/all/loadmodulerelative.cxx
Making:oslall.lib
Making:all_oslall.dpslo
Making:all_oslall.dpobj
Entering /home/thomas/temp/libreoffice/libo/sal/rtl/source
Making:all_cpprtl.dpslo
Making:all_cpprtl.dpobj
--- ALWAYSDBGFILES ---
Compiling: sal/rtl/source/debugprint.cxx
--- ALWAYSDBGFILES OVER ---
Compiling: sal/rtl/source/memory.c
Compiling: sal/rtl/source/cipher.c
Compiling: sal/rtl/source/crc.c
Compiling: sal/rtl/source/digest.c
Compiling: sal/rtl/source/random.c
Compiling: sal/rtl/source/locale.c
Compiling: sal/rtl/source/strimp.c
Compiling: sal/rtl/source/hash.cxx
Compiling: sal/rtl/source/string.c
Compiling: sal/rtl/source/ustring.c
Compiling: sal/rtl/source/strbuf.c
Compiling: sal/rtl/source/ustrbuf.c
Compiling: sal/rtl/source/uuid.cxx
Compiling: sal/rtl/source/rtl_process.c
Compiling: sal/rtl/source/byteseq.c
Compiling: sal/rtl/source/uri.cxx
Compiling: sal/rtl/source/bootstrap.cxx
Compiling: sal/rtl/source/cmdargs.cxx
Compiling: sal/rtl/source/unload.cxx
Compiling: sal/rtl/source/logfile.cxx
Compiling: sal/rtl/source/tres.c
Compiling: sal/rtl/source/math.cxx
Compiling: sal/rtl/source/alloc_global.c
Compiling: sal/rtl/source/alloc_cache.c
Compiling: sal/rtl/source/alloc_arena.c
Making:cpprtl.lib
Compiling: sal/rtl/source/memory.c
Compiling: sal/rtl/source/cipher.c
Compiling: sal/rtl/source/crc.c
Compiling: sal/rtl/source/digest.c
Compiling: sal/rtl/source/random.c
Compiling: sal/rtl/source/locale.c
Compiling: sal/rtl/source/strimp.c
Compiling: sal/rtl/source/hash.cxx
Compiling: sal/rtl/source/string.c
Compiling: sal/rtl/source/ustring.c
Compiling: sal/rtl/source/strbuf.c
Compiling: sal/rtl/source/ustrbuf.c
Compiling: sal/rtl/source/uuid.cxx
Compiling: sal/rtl/source/rtl_process.c
Compiling: sal/rtl/source/byteseq.c
Compiling: sal/rtl/source/uri.cxx
Compiling: sal/rtl/source/bootstrap.cxx
Compiling: sal/rtl/source/cmdargs.cxx
Compiling: sal/rtl/source/unload.cxx
Compiling: sal/rtl/source/logfile.cxx
Compiling: sal/rtl/source/tres.c
Compiling: sal/rtl/source/math.cxx
Compiling: sal/rtl/source/alloc_global.c
Re: [Libreoffice] Build fails without gdb installed
On 02/24/2011 10:37 PM, Caolán McNamara wrote: It only does this if the environmental variables DEBUGCPPUNIT or debugcppunit are set. Those aren't automatically set, they have to be set manually when trying to debug a unit test, at which point its reasonable to expect gdb to be installed. Did you set those yourself recently ? Yes, set them. But before I set them it failed, too (also at this cppunit test, but don't know if with gdb). I started from a clean tree (make distclean). Now it doesn't occur and builds... Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Tools - Media Player
Hi, On 02/25/2011 12:07 PM, Fernand Vanrie wrote: Please consider: We are living and working in a Multi Media world: Not only who is working with Impress needs a media player, all content can have mixed content and LO must be the one stop place to handle all multi media stuff. I partially reverted the changes for writer. The background calls are there again, so anybody who needs Media Player could add this by customizing the menu. And I've enabled Media Player for web by default as this make really sense. Fernand, only for my personal interest: are you using videos in odt files? Maybe I'm not knowing what's possible with this ;) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove dead code
Nice, thanks :) Pushed it.
Thomas
On 02/28/2011 11:21 PM, Michael Lefevre wrote:
ACCESSIBLE_EVENT_NOTIFICATION_ENABLED was never define. So the #ifdef #endif
brackets could go away.
---
.../extended/accessibleiconchoicectrlentry.hxx | 16
.../extended/accessibleiconchoicectrlentry.cxx | 15 ---
2 files changed, 0 insertions(+), 31 deletions(-)
diff --git
a/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
b/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
index 3e9cec0..b2c145d 100644
---
a/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
+++
b/accessibility/inc/accessibility/extended/accessibleiconchoicectrlentry.hxx
@@ -83,22 +83,6 @@ namespace accessibility
::com::sun::star::uno::Reference
::com::sun::star::accessibility::XAccessible m_xParent;
private:
-#ifdef ACCESSIBLE_EVENT_NOTIFICATION_ENABLED
-// (the following method is unused currently. If you need it, simply
remove the #ifdef thing here and
-// in the cxx)
-/** notifies all listeners that this object has changed
-@param _nEventId
-is the event id
-@param _aOldValue
-is the old value
-@param _aNewValue
-is the new value
-*/
-void NotifyAccessibleEvent( sal_Int16 _nEventId,
- const ::com::sun::star::uno::Any
_aOldValue,
- const ::com::sun::star::uno::Any
_aNewValue );
-#endif
-
RectangleGetBoundingBox_Impl() const;
RectangleGetBoundingBoxOnScreen_Impl()
const;
sal_Bool IsAlive_Impl() const;
diff --git a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
index 6a613de..791d89a 100644
--- a/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
+++ b/accessibility/source/extended/accessibleiconchoicectrlentry.cxx
@@ -122,21 +122,6 @@ throw(RuntimeException)
dispose();
}
}
-#ifdef ACCESSIBLE_EVENT_NOTIFICATION_ENABLED
-// (the following method is unused currently. If you need it, simply
remove the #ifdef thing here and
-// in the hxx)
-//
-
-void AccessibleIconChoiceCtrlEntry::NotifyAccessibleEvent( sal_Int16
_nEventId,
- const
::com::sun::star::uno::Any _aOldValue,
- const
::com::sun::star::uno::Any _aNewValue )
-{
-Reference uno::XInterface xSource( *this );
-AccessibleEventObject aEventObj( xSource, _nEventId, _aNewValue,
_aOldValue );
-
-if (m_nClientId)
-comphelper::AccessibleEventNotifier::addEvent( m_nClientId,
aEventObj );
-}
-#endif
//
-
Rectangle AccessibleIconChoiceCtrlEntry::GetBoundingBox_Impl() const
{
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [Patch] remove dead code
Thanks, pushed the first one. The second didn't apply (0002-..). Thomas On 02/27/2011 10:26 PM, Xisco Faulí wrote: Remode all dead code from /libs-core/sfx2/source ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [PATCH] Remove bogus comments
Hi Antoine, pushed this, thanks! Probably your name isn't set in the gitconfig, only your mail address was given as author. You could set this with: git config --global user.name Your Name Thomas On 02/28/2011 12:06 AM, Antoine Proulx wrote: Hi, Here's a patch who removes bogus comments. It's realeased under LGPLv3+ / MPL. I also have a question: do we need to remove the lines @author OD? Antoine ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] Remove Dead Code
Thanks! I've pushed it. Deleted three additional comments as they belong to the deleted code. Nice work :) Thomas On 02/27/2011 04:17 PM, Xisco Faulí wrote: Greetings ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] No full justification in master?
Hi Khaled, On 03/01/2011 05:10 PM, Khaled Hosny wrote: In locally built libreoffice master I can't get full justification; text is kept left aligned. I tested with the distro packaged 3.3.1 and justification is fine. Can anyone confirm this, or it is just me? Yes, I can confirm this! I've tested the 3.3.1 Gentoo version - works fine. But for git master it won't do anything. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] media export ...
Hi, On 03/01/2011 06:29 PM, Fernand Vanrie wrote: Video in PDF can been done but it must be Flash-video :-) So: or: we need a on the fly conversion, or you havbe accept Flash video in the LO documents. I can help to do some research but i am not a coder, just a bit off a avandced user. That sounds really nice. The Media Player already understands flv files, but the file chooser isn't ready (no possibility to choose flv files). Somehow I got a flv file added to the document with All files as filter. Wrote this in an earlier mail, this stuff is some out of sync. I may look at it later. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Code cleanliness
On 03/01/2011 02:07 PM, Caolán McNamara wrote: #n123456# bugids are Novell bugids, typically publically available, e.g. #n672421# - https://bugzilla.novell.com/show_bug.cgi?id=672421 So they're typically useful information. I've added this information to the Easy Hacks page, under Translate German comments. If someone has more info feel free to add :) Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] media export ...
Hi Fernand, On 03/02/2011 11:48 AM, Fernand Vanrie wrote: 2 Corrections: - I was wrong, in PDF documents we can now embed most off the Video-formats - LO - (windows) still not accept flash video Use Insert - Media and Sound - Select 'All files' as filter, so you are able to add flv videos, and all other formats the player is capable of (works on Linux). Not so many applications allows to embed video in PDF, Android and Ipad will been allover the place, and PDF is still the most simple way to produce MultiMedia for this devices, so LO will have a very interesting new feather. Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files
On 03/12/2011 11:46 PM, Miklos Vajna wrote: So far we have 4 .gitattributes files in the root of 4 repos with the same contents. To have them in the rest of the repos and avoid duplication, it's better to have a single one in the bootstrap repo and configure the rest of the repos to use that one. I'm attaching two patches: 1) is for bootstrap 2) is for extensions/filters/libs-gui/testing OK to push? Nice, thanks for this. I did add those *.sdw and *.doc patterns for some files in one repo. Maybe the list could be completed with other binary files git has no idea of. I think excel files and some more could be good to be on that list (there are some of those files in some test dirs). Maybe this could be an Easy Hack. So I'll add it to the list. Any appeals? Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Replace j_assert with OSL_ in writer/starmath
On 03/17/2011 11:26 PM, Jacek Wolszczak wrote: Easy hacks align ASSERT ( friends) macro foo patch. Yeah, this looks nice. Did you build this once with --enable-debug and --enable-dbgutil? Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Replace j_assert with OSL_ in writer/starmath
Hi Jacek, On 03/18/2011 09:14 AM, Jacek Wolszczak wrote: I did compile it with --enable-debug as it's OSL_ specific and it compiled correctly. Haven't used --enable-dbgutil as there are no #ifdef DBG_UTIL in the files I touched. But for the future I will recompile LibreO with both flags enabled. I think this is ok as you did it. I'll push it in the afternoon. Thanks for your patch. Can you confirm that your patch is under LGPLv3+ / MPL licence? Thomas ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
