Re: Does a change in layouttranslations require a format change?
On 1/7/24 05:40, Jürgen Spitzmüller wrote: Am Samstag, dem 06.01.2024 um 19:08 -0500 schrieb Richard Kimberly Heck: On 1/6/24 18:55, Udicoudco wrote: On Thu, Jan 4, 2024 at 8:42 PM Richard Kimberly Heck wrote: It is not too late to do this for 2.4. We'd prefer not to have format changes at this point, so it would depend upon how involved it is, i.e., how complex the lyx2lyx code was. I can wait a day or two. If it is not too late, I can send a patch tomorrow. Others seemed to think it was better to wait. So, lacking consensus, let's wait for 2.4.1. Since it's a file format change, it needed to be done now or for 2.5, no? I think this would be a fair change for 2.4.0. OK, let's do it, then. Riki -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Sun, Jan 07, 2024 at 11:40:49AM +0100, Jürgen Spitzmüller wrote: > > > > It is not too late to do this for 2.4. We'd prefer not to have format > > > > changes at this point, so it would depend upon how involved it is, > > > > i.e., how complex the lyx2lyx code was. I can wait a day or two. > > > If it is not too late, I can send a patch tomorrow. > > > > Others seemed to think it was better to wait. So, lacking consensus, let's > > wait for 2.4.1. > > Since it's a file format change, it needed to be done now or for 2.5, no? I > think this would be a fair change for 2.4.0. Sorry coming so late in this discussion. It is certainly not late to change layouttranslations now. But the way it is done is to change he.po and regenerate layouttranslations from it (I'll do that once new he.po is committed). Once 2.4.0 is out layouttranslations is frozen for the whole 2.4.x release but you can still can he.po as much as you want... Pavel -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
Am Samstag, dem 06.01.2024 um 19:08 -0500 schrieb Richard Kimberly Heck: > On 1/6/24 18:55, Udicoudco wrote: > > On Thu, Jan 4, 2024 at 8:42 PM Richard Kimberly Heck > > wrote: > > > It is not too late to do this for 2.4. We'd prefer not to have > > > format > > > changes at this point, so it would depend upon how involved it > > > is, i.e., > > > how complex the lyx2lyx code was. I can wait a day or two. > > If it is not too late, I can send a patch tomorrow. > > Others seemed to think it was better to wait. So, lacking consensus, > let's wait for 2.4.1. Since it's a file format change, it needed to be done now or for 2.5, no? I think this would be a fair change for 2.4.0. -- Jürgen -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Sun, Jan 7, 2024 at 2:08 AM Richard Kimberly Heck wrote: > > On 1/6/24 18:55, Udicoudco wrote: > > On Thu, Jan 4, 2024 at 8:42 PM Richard Kimberly Heck > > wrote: > >> It is not too late to do this for 2.4. We'd prefer not to have format > >> changes at this point, so it would depend upon how involved it is, i.e., > >> how complex the lyx2lyx code was. I can wait a day or two. > > If it is not too late, I can send a patch tomorrow. > > Others seemed to think it was better to wait. So, lacking consensus, > let's wait for 2.4.1. Can a format change happen in a maintenance release? -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On 1/6/24 18:55, Udicoudco wrote: On Thu, Jan 4, 2024 at 8:42 PM Richard Kimberly Heck wrote: It is not too late to do this for 2.4. We'd prefer not to have format changes at this point, so it would depend upon how involved it is, i.e., how complex the lyx2lyx code was. I can wait a day or two. If it is not too late, I can send a patch tomorrow. Others seemed to think it was better to wait. So, lacking consensus, let's wait for 2.4.1. Riki -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Thu, Jan 4, 2024 at 8:42 PM Richard Kimberly Heck wrote: > It is not too late to do this for 2.4. We'd prefer not to have format > changes at this point, so it would depend upon how involved it is, i.e., > how complex the lyx2lyx code was. I can wait a day or two. If it is not too late, I can send a patch tomorrow. Udi -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On 12/30/23 04:26, Udicoudco wrote: On Sat, Dec 30, 2023 at 11:14 AM Jürgen Spitzmüller wrote: Am Freitag, dem 29.12.2023 um 02:56 +0200 schrieb Udicoudco: While working on the Hebrew .po file all of the people involved agreed that the translation to "Notation" should be changed. The problem is that if we'll change only the .po file, the output won't be the same as the GUI, but if we'll change layouttranslations it can potentially affect the output of existing documents. Yes, this would be a file format change in my opinion. Mine, as well. The basic rule is that anything that changes output needs a format change, so that there are no surprises when importing or exporting. Ok! we'll do it in 2.5. It is not too late to do this for 2.4. We'd prefer not to have format changes at this point, so it would depend upon how involved it is, i.e., how complex the lyx2lyx code was. I can wait a day or two. Riki -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
Am Samstag, dem 30.12.2023 um 11:26 +0200 schrieb Udicoudco: > Is there any significance for the accelerator as long as it is > unique and contained in the UI string? I am not sure I understand. Do you mean, what are the criteria? It should be unique and contained in the UI string, this is a must. If possible, I always go for one that is easily reachable on any keyboard (e.g., <ä> in German is difficult on non-German keyboards) and one that is easily memorizable (ideally first letter of one of the words or a main syllable). -- Jürgen -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Sat, Dec 30, 2023 at 11:26 AM Udicoudco wrote: > Is there any significance for the accelerator as long as it is > unique and contained in the UI string? Let me rephrase. Are there more restrictions I should be aware of? > Thanks, > Udi > > -- > > lyx-docs mailing list > > lyx-docs@lists.lyx.org > > http://lists.lyx.org/mailman/listinfo/lyx-docs -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Sat, Dec 30, 2023 at 11:14 AM Jürgen Spitzmüller wrote: > > Am Freitag, dem 29.12.2023 um 02:56 +0200 schrieb Udicoudco: > > While working on the Hebrew .po file all of the > > people involved agreed that the translation to > > "Notation" should be changed. > > > > The problem is that if we'll change only the .po > > file, the output won't be the same as the GUI, but > > if we'll change layouttranslations it can potentially > > affect the output of existing documents. > > Yes, this would be a file format change in my opinion. Ok! we'll do it in 2.5. > > In addition, can someone please explain the meaning, and how > > to avoid the following warnings? > > > > Menus.cpp (759): Menu warning: menu entries "מסך מלא|מ" and "חלונית > > מתאר|מ" share the same shortcut. > You'd need to use a different (available) accelerator in one of these > strings (something else than "|מ" > > > Menus.cpp (753): Menu warning: menu entry "חזור אחורה" does not > > contain shortcut `נ'. > > The po file contains > > #: lib/ui/stdmenus.inc:622 > msgid "Navigate Back|B" > msgstr "חזור אחורה|נ" > > The letter after "|" is the accelerator. It must be a letter that is > contained in the UI string (before the accelerator), which isn't the > case here (נ is not in "חזור אחורה"). Mabye this was just a typo and it > was meant to use "חזור אחורה|ר"? Oh, I think currently the accelerators in he.po are translated by the position of the key on a hebrew layout keyboard (e.g. נ and B are on the same key). This is surely a mistake... Is there any significance for the accelerator as long as it is unique and contained in the UI string? Thanks, Udi > -- > Jürgen > -- > lyx-docs mailing list > lyx-docs@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-docs -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
Am Freitag, dem 29.12.2023 um 02:56 +0200 schrieb Udicoudco: > While working on the Hebrew .po file all of the > people involved agreed that the translation to > "Notation" should be changed. > > The problem is that if we'll change only the .po > file, the output won't be the same as the GUI, but > if we'll change layouttranslations it can potentially > affect the output of existing documents. Yes, this would be a file format change in my opinion. > In addition, can someone please explain the meaning, and how > to avoid the following warnings? > > Menus.cpp (759): Menu warning: menu entries "מסך מלא|מ" and "חלונית > מתאר|מ" share the same shortcut. You'd need to use a different (available) accelerator in one of these strings (something else than "|מ" > Menus.cpp (753): Menu warning: menu entry "חזור אחורה" does not > contain shortcut `נ'. The po file contains #: lib/ui/stdmenus.inc:622 msgid "Navigate Back|B" msgstr "חזור אחורה|נ" The letter after "|" is the accelerator. It must be a letter that is contained in the UI string (before the accelerator), which isn't the case here (נ is not in "חזור אחורה"). Mabye this was just a typo and it was meant to use "חזור אחורה|ר"? -- Jürgen -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
Re: Does a change in layouttranslations require a format change?
On Fri, Dec 29, 2023 at 2:56 AM Udicoudco wrote: > The problem is that if we'll change only the .po > file, the output won't be the same as the GUI, but > if we'll change layouttranslations it can potentially > affect the output of existing documents. Sorry, I meant to ask if because of this fact it will require a format change? -- lyx-docs mailing list lyx-docs@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-docs
