Re: Perl's Sacrifice Stone

2004-07-14 Thread khemir nadim

Andrew savige [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
 khemir nadim wrote:
  I'd love to review the second module that is offered for sacrifice ;-)
  Anything to offer?

 How about Apache::MVC? It was posted for review on Simon's code review
 ladder mailing list in February but didn't get any response AFAICT.
 What has been harming this list, IMHO, is selfish people asking for their
 module to be reviewed -- and then disappearing without reviewing someone
 else's module in return. Maybe there should be a convention that you
 should first review someone else's before posting yours (?).
This is a good idea but to do that you must have a list of modules to pick
from and to have
your module added to the llist you to have tested a module that should come
from the list.

:-) it's a good idea anyhow.

About Apache::MVC, I'm unfortunately the wrong guy for that one. It would
take me ages
to get anything having something to do with web to work (yeah I'm that
good). I'm more on
system module side. But I'll find something to grind soon, promised.


 BTW, I think the code review ladder mailing list is exactly what you are
 looking for. Unless you are prepared to create an account and start by
 posting on PerlMonks Discussion seeking feedback re your Perl Sacrifice
 Stone idea, I don't think Perl Monks will work for you. There is nothing
 stopping you posting a review of your favourite module/s on Perl Monks --
 doing that may give you more credibility at that site, so your ideas may
 then be better received.

 /-\


 Find local movie times and trailers on Yahoo! Movies.
 http://au.movies.yahoo.com




Re: Perl's Sacrifice Stone

2004-07-13 Thread khemir nadim

Andrew savige [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
 So far this node has been ignored and downvoted.
I saw that, well that's life.

 I suggest you start by creating a perl monks account (rather than
 posting anonymously). Then hang around for a while to get a feel
 for how the place works.
Not being active or registred doesn't mean I don't hang around. I rather
dislike to register, I have memory holes and all my password are remmebered
as 123TEST.

 If you want someone to review your module, it seems best to start
 by first reviewing someone else's module.
I'd love to review the second module that is offered for sacrifice ;-)
Anything to offer?

Nadim.




Re: Perl's Sacrifice Stone

2004-07-13 Thread khemir nadim

Randy W. Sims [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
 wrote:
 Hmm, we have:

 1) Simon's code review ladder:
 http://lists.netthink.co.uk/listinfo/code-review-ladder
Seems rather dead to me. A very interresting link anyhow. Let's see if we
can get more life there

 2) Ask's CPAN Ratings: http://cpanratings.perl.org/
We had a long discussion about this. As long the rating are not more visible
and people are not actively ask to rate, there will be no real effect
which is a pity because it's also a very good idea.


 3) Perl Monks' Reviews: http://www.perlmonks.org/index.pl?node=Reviews
That did work so well. Maybe I should have done it in another way but I've
done my best. I can't seriously review my own modules (remember it's the
only vonlontary review module so far) or it will be no better than module
authors that rate their own modules.

 Each has a slightly different focus, but there is some overlap. A part
 of me wonders if they should be at least loosely linked together instead
 of remaining 3 independant but related review tools for authors  users;
 maybe one review site with two faces, one to help module users find
 modules and the other to help module authors improve their modules.
Amen.





Re: Perl's Sacrifice Stone

2004-07-13 Thread Andrew Savige
khemir nadim wrote:
 I'd love to review the second module that is offered for sacrifice ;-)
 Anything to offer?

How about Apache::MVC? It was posted for review on Simon's code review
ladder mailing list in February but didn't get any response AFAICT.
What has been harming this list, IMHO, is selfish people asking for their
module to be reviewed -- and then disappearing without reviewing someone
else's module in return. Maybe there should be a convention that you
should first review someone else's before posting yours (?).

BTW, I think the code review ladder mailing list is exactly what you are
looking for. Unless you are prepared to create an account and start by
posting on PerlMonks Discussion seeking feedback re your Perl Sacrifice
Stone idea, I don't think Perl Monks will work for you. There is nothing
stopping you posting a review of your favourite module/s on Perl Monks --
doing that may give you more credibility at that site, so your ideas may
then be better received.

/-\


Find local movie times and trailers on Yahoo! Movies.
http://au.movies.yahoo.com


Re: Perl's Sacrifice Stone

2004-07-13 Thread Andrew Savige
Randy W. Sims wrote:
 Hmm, we have:
 
 1) Simon's code review ladder: 
 http://lists.netthink.co.uk/listinfo/code-review-ladder
 
 2) Ask's CPAN Ratings: http://cpanratings.perl.org/
 
 3) Perl Monks' Reviews: http://www.perlmonks.org/index.pl?node=Reviews
 
 Each has a slightly different focus, but there is some overlap. A part 
 of me wonders if they should be at least loosely linked together instead 
 of remaining 3 independant but related review tools for authors  users; 
 maybe one review site with two faces, one to help module users find 
 modules and the other to help module authors improve their modules.

I see 2) above as Amazon-style cheer-leading, and 3) above as
more detailed and analytical. I prefer the latter. ;-)

There is also gav's CPAN module review wiki at:
 http://cpan.thegav.com/
and Mark Fowler's lovely Advent Calendar at:
 http://www.perladvent.org/

I suppose all the above sites could do with more quality content.
Bottom line: a quality review is unpaid work taking considerable
time and effort; there will always be a shortage of them. Notice
that Uri Guttman offers a commerical code review service.

To improve your CPAN module code, it's often best to isolate small
pieces of code from the module that you're unhappy with and post
multiple small questions to Perl Monks; that is much more likely
to elicit a response than posting a 500-line module for review.

/-\


Find local movie times and trailers on Yahoo! Movies.
http://au.movies.yahoo.com


Re: Perl's Sacrifice Stone

2004-07-13 Thread Dave Rolsky
On Wed, 14 Jul 2004, Andrew Savige wrote:

 I suppose all the above sites could do with more quality content. Bottom
 line: a quality review is unpaid work taking considerable time and
 effort; there will always be a shortage of them. Notice that Uri Guttman
 offers a commerical code review service.

I've done that too.  Doing a truly thorough review takes a fair amount of
time.  When I've been paid to do it I try to evaluate the code in a number
of areas, include Perl-ishness (are they using Perl effectively),
security flaws, robustness, correctness, efficiency, quality of comments,
quality of docs (hah, they never exist!).  I also make specific
suggestions for improvements.

For CPAN modules, you have to add in an evaluation of the API itself, from
the standpoint of an API consumer.

Needless to say, doing that for any non-trivial amount of code is a lot of
work.

I think part of the reason I haven't done this sort of stuff for CPAN
modules is that it's just so much work.  I've written some reviews on
cpanratings of stuff I've used a fair amount, or stuff that is obviously
horribly wrong, but that's about it.


-dave

/*===
House Absolute Consulting
www.houseabsolute.com
===*/


Re: Perl's Sacrifice Stone

2004-07-10 Thread Andrew Savige
khemir nadim wrote:
 I started a vonlontary review on Perl Monks. I don't know if it's the best
 place but since they have reviews I thought it would be a good place to
 start with (and I couldn't think of a better place). It hasn't given any
 result so far :-) . If some of you would be nice enough to review the module
 I put there or put a module that they want to be reviewed, that might start
 things up.

So far this node has been ignored and downvoted.
I suggest you start by creating a perl monks account (rather than
posting anonymously). Then hang around for a while to get a feel
for how the place works.

If you want someone to review your module, it seems best to start
by first reviewing someone else's module.

/-\


Find local movie times and trailers on Yahoo! Movies.
http://au.movies.yahoo.com


Re: Perl's Sacrifice Stone

2004-07-10 Thread Randy W. Sims
khemir nadim wrote:
Hi,
I started a vonlontary review on Perl Monks. I don't know if it's the best
place but since they have reviews I thought it would be a good place to
start with (and I couldn't think of a better place). It hasn't given any
result so far :-) . If some of you would be nice enough to review the module
I put there or put a module that they want to be reviewed, that might start
things up.
Hmm, we have:
1) Simon's code review ladder: 
http://lists.netthink.co.uk/listinfo/code-review-ladder

2) Ask's CPAN Ratings: http://cpanratings.perl.org/
3) Perl Monks' Reviews: http://www.perlmonks.org/index.pl?node=Reviews
Each has a slightly different focus, but there is some overlap. A part 
of me wonders if they should be at least loosely linked together instead 
of remaining 3 independant but related review tools for authors  users; 
maybe one review site with two faces, one to help module users find 
modules and the other to help module authors improve their modules.

Randy.


RE: Perl's Sacrifice Stone

2004-07-09 Thread Konovalov, Vadim
 I started a vonlontary review on Perl Monks. I don't know if 

What is your URL?


 it's the best
 place but since they have reviews I thought it would be a 
 good place to
 start with (and I couldn't think of a better place). It 

PerlMonks site is quite conservative, so they will probably not reorganize
one of their sections. Rather they will convince you to live with elder
system, and they're strong at that.

Vadim.