Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

[Eric Koegel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/
---

(Updated June 20, 2017, 5:58 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kwin


Description
---

ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
required by Kwin to run under Wayland. This patch first looks for the login1 
service before attempting the ConsoleKit service.


Diffs
-

  logind.h 8bb0206 
  logind.cpp fee0f2f 

Diff: https://git.reviewboard.kde.org/r/130163/diff/


Testing
---

On a system running ConsoleKit2, logging into a text console and running:
```
export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
```
Most of this patch is just shuffling code around to support both logind and CK2.


Thanks,

Eric Koegel

D6274: Use AbstractClient instead of Client in placement

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:92207be904aa: Use AbstractClient instead of Client in 
placement (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6274?vs=15587=15619

REVISION DETAIL
  https://phabricator.kde.org/D6274

AFFECTED FILES
  placement.cpp

To: graesslin, #kwin, #plasma, davidedmundson, mart
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6275: Make Workspace::switchWindow operate on AbstractClient

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:763fbf5fafd0: Make Workspace::switchWindow operate on 
AbstractClient (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6275?vs=15588=15620

REVISION DETAIL
  https://phabricator.kde.org/D6275

AFFECTED FILES
  useractions.cpp

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6264: Fix switch desktop on screenedge while resizing a Wayland window

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:7a3c29261226: Fix switch desktop on screenedge while 
resizing a Wayland window (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6264?vs=15562=15617

REVISION DETAIL
  https://phabricator.kde.org/D6264

AFFECTED FILES
  screenedge.cpp

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:3b9ccc65a3a8: [tabbox] Fix casts to Client where it 
should be AbstractClient (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6273?vs=15582=15618

REVISION DETAIL
  https://phabricator.kde.org/D6273

AFFECTED FILES
  tabbox/tabbox.cpp
  tabbox/tabbox.h

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6258: Workaround Qt regression of no longer delivering events for the root window

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a6dee74ee455: Workaround Qt regression of no longer 
delivering events for the root window (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6258?vs=15545=15615

REVISION DETAIL
  https://phabricator.kde.org/D6258

AFFECTED FILES
  effects.cpp

To: graesslin, #kwin, #plasma, broulik
Cc: fvogt, broulik, plasma-devel, kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D6260: Better handle cases when the xkb keymap fails to be created

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:0df09a8cbbb1: Better handle cases when the xkb keymap 
fails to be created (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6260?vs=15551=15614

REVISION DETAIL
  https://phabricator.kde.org/D6260

AFFECTED FILES
  autotests/integration/CMakeLists.txt
  autotests/integration/keymap_creation_failure_test.cpp
  xkb.cpp

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6257: Fix switch desktop through edge when moving window

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c45e165514ec: Fix switch desktop through edge when moving 
window (authored by graesslin).

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6257?vs=15543=15616

REVISION DETAIL
  https://phabricator.kde.org/D6257

AFFECTED FILES
  autotests/mock_abstract_client.cpp
  autotests/mock_abstract_client.h
  autotests/mock_client.cpp
  autotests/mock_client.h
  autotests/test_screen_edges.cpp
  screenedge.cpp

To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

[Breeze] [Bug 381407] SDDM's Breeze theme should have a prettier background than just a flat blue color

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381407

--- Comment #1 from Nate Graham  ---
By chance, I happened to stumble on a similar comment made by a KDE-using
Redditor today (not me):
https://www.reddit.com/r/kde/comments/6i4uf0/has_anyone_tried_kde_on_new_debian_9/dj40lw3/

"Edit: Also, the default SDDM theme is VERY ugly. Change it the first chance
you get. Not bashing it, because overall, [Debian is] one of the best KDE
experiences for me."

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=381387

Christoph Feck  changed:

   What|Removed |Added

  Component|general |general
Version|master  |unspecified
   Target Milestone|1.0 |---
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org
Product|plasmashell |Powerdevil

-- 
You are receiving this mail because:
You are the assignee for the bug.

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

[Sebastian Kügler]

https://bugs.kde.org/show_bug.cgi?id=379680

Sebastian Kügler  changed:

   What|Removed |Added

 CC||se...@kde.org
   Assignee|plasma-devel@kde.org|plasma-b...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6282: Context: Return early from connectToDaemon when already connected

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:70f090314296: Context: Return early from connectToDaemon 
when already connected (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6282?vs=15597=15598

REVISION DETAIL
  https://phabricator.kde.org/D6282

AFFECTED FILES
  src/context.cpp

To: drosca, #plasma, apol, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6282: Context: Return early from connectToDaemon when already connected

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6282

To: drosca, #plasma, apol, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6282: Context: Return early from connectToDaemon when already connected

[David Rosca]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  connectToDaemon is called after 1 second delay when PulseAudio context
  becomes invalid, but it is also called when PulseAudio service registers
  on DBus.
  
  In case when PulseAudio crashes and immediately restarts, the delayed
  call to connectToDaemon will be called when already connected which will
  open second connection and leak the first one.
  It also leads to assert with debug build.
  
  BUG: 381411

TEST PLAN
  Restarted pulseaudio, plasma-pa reconnected

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6282

AFFECTED FILES
  src/context.cpp

To: drosca, #plasma, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: [Kirigami] Support for stacked page rows (a proposal)

[Marco Martin]

On Sunday 18 June 2017 21:39:36 kelvin.atomblen...@riseup.net wrote:
> I hope this idea will somehow be introduced into Kirigami, if not the
> way I proposed (activities) then some other. It doesn't change
> Kirigami's design principles but rather extends it and makes it more
> flexible.

Hi,
I think it's a rather nice idea :)

now, i want to think of a way to make something along the lines but that 
doesn't require any api change in old applications, which is necessary, as we 
promise long term cmpatibility and i don't want to have a kirigami3 for at 
least a couple of years.

an optional page stack on which is possible to push extra pagerows should be 
feasible, if applciationwindow.pagestack always points to the last pagerow, 
should be compatible and possible to achievable those stacked contexts.

-- 
Marco Martin

D6260: Better handle cases when the xkb keymap fails to be created

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  safety-checks-xkbcommon-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6260

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6264: Fix switch desktop on screenedge while resizing a Wayland window

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  fix-screenedge-wayland-window-resize-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6264

To: graesslin, #kwin, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6274: Use AbstractClient instead of Client in placement

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R108 KWin

BRANCH
  placement-fix-abstract-client-casts

REVISION DETAIL
  https://phabricator.kde.org/D6274

To: graesslin, #kwin, #plasma, davidedmundson, mart
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

[Breeze] [Bug 381407] New: SDDM's Breeze theme should have a prettier background than just a flat blue color

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=381407

Bug ID: 381407
   Summary: SDDM's Breeze theme should have a prettier background
than just a flat blue color
   Product: Breeze
   Version: 5.9.4
  Platform: Ubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: pointedst...@zoho.com
  Target Milestone: ---

Linux distro: Kubuntu 17.04

SDDM's default Breeze theme uses a plain blue background. I have heard that
this was a deliberate choice by the VDG, and I would like to make the case that
substituting the excellent Next wallpaper would be superior for the following
reasons:

1. The screen locker matches the desktop by using use the Next wallpaper at
/usr/share/wallpapers/Next by default, and they both look great. But SDDM
doesn't, providing two needlessly different visual experiences when users need
to type their password at the lock and login screens. Most users will not (and
should not need to) understand the difference between the login screen and the
lock screen, so the fact that one shows a picture and the other shows a plain
blue background seems weird and inconsistent.

2. This is a missed opportunity to reinforce the Breeze visual brand via the
Next wallpaper, which is really excellent.

2. Entirely apart from consistency and branding, a picture is more attractive
than a plain blue background. It's not even a soft blue; the color is very
bright and hard. It's rather jarring. Next is much prettier--calming, and
comforting, even.

Therefore, I propose that the Breeze SDDM theme use the Next wallpaper instead
of just the plain blue background.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6275: Make Workspace::switchWindow operate on AbstractClient

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  switch-window-wayland

REVISION DETAIL
  https://phabricator.kde.org/D6275

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6274: Use AbstractClient instead of Client in placement

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  placement-fix-abstract-client-casts

REVISION DETAIL
  https://phabricator.kde.org/D6274

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

[Germano Massullo]

https://bugs.kde.org/show_bug.cgi?id=379680

--- Comment #6 from Germano Massullo  ---
A few logs, while trying to browse a Samsung Galaxy S5

Note: VID and PID have been edited to avoid any privacy problem

$ Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
ignoring libusb_claim_interface() = -6PTP_ERROR_IO: failed to open session,
trying again after resetting USB interface
LIBMTP libusb: Attempt to reset device
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
ERROR: Could not close session!
inep: usb_get_endpoint_status(): Device or resource busy
outep: usb_get_endpoint_status(): Device or resource busy
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
ignoring libusb_claim_interface() = -6PTP_ERROR_IO: failed to open session,
trying again after resetting USB interface
LIBMTP libusb: Attempt to reset device
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
ERROR: Could not close session!
inep: usb_get_endpoint_status(): Device or resource busy
outep: usb_get_endpoint_status(): Device or resource busy
ERROR: Could not close session!
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
ignoring libusb_claim_interface() = -6PTP_ERROR_IO: failed to open session,
trying again after resetting USB interface
LIBMTP libusb: Attempt to reset device
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
ignoring libusb_claim_interface() = -6PTP_ERROR_IO: failed to open session,
trying again after resetting USB interface
LIBMTP libusb: Attempt to reset device
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
ERROR: Could not close session!
inep: usb_get_endpoint_status(): Device or resource busy
outep: usb_get_endpoint_status(): Device or resource busy
ERROR: Could not close session!
Device 0 (VID=01xu and PID=6123) is a Samsung Galaxy models (MTP).
Android device detected, assigning default bug flags
Android device detected, assigning default bug flags
ERROR: Could not close session!
inep: usb_get_endpoint_status(): Device or resource busy
outep: usb_get_endpoint_status(): Device or resource busy
ERROR: Could not close session!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D6188: [Desktop] Pad cellWidth/cellHeight with the extra space

[Chris Holland]

Zren added a comment.


  What behaviour should the folder widget use:
  
  1. Old behaviour: https://streamable.com/5gk5p
  2. Current behaviour with the patch: https://streamable.com/qs4s4
  3. Combination of the two, when "arranged in rows", it should stretch to fill 
the width, but keep a fixed height so that it's easy to spot at a glance that 
there's more icons. Vice versa for "arranged in columns", where it'll fill the 
height, but have a fixed width.
  
  In https://phabricator.kde.org/D6188#116002, @hein wrote:
  
  > The comment is mostly about the fact that this means you can no longer drop 
icons there then. Keep in mind that when the view is in columnar mode, 
horizontal overflow is (currently) the expected and correct behavior - if the 
folder is fuller than the screen can fill, the view has to start scrolling 
horizontally then.
  
  
  A scrollbar will still appear when needed (too many icons). It's just harder 
to get the scrollbar accidentally by dropping in the bottom right when there 
isn't an overflow.
  You can still create a scrollbar accidently like this: 
https://streamable.com/why77
  Where you mouse is still hovering the FolderView, but the center of the 
dropped icon is hovering the next column.
  You can also force it by selecting a group of icons (eg: 3x3) and dropping 
icons off the screen. You need to drop them twice. Once to trigger the 
"overflow" mode, and a second time to actually place them. I think it's a bug 
that you need to do it twice. I think this happened before this patch though 
(I'll test after supper).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6188

To: Zren, hein
Cc: anthonyfieroni, broulik, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6275: Make Workspace::switchWindow operate on AbstractClient

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  By using AbstractClient instead of Client the method works also for
  Wayland windows.

REPOSITORY
  R108 KWin

BRANCH
  switch-window-wayland

REVISION DETAIL
  https://phabricator.kde.org/D6275

AFFECTED FILES
  useractions.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R108 KWin

BRANCH
  fix-tabbox-wayland-client-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6273

To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6274: Use AbstractClient instead of Client in placement

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  There were a few places where we still used Client instead of
  AbstractClient. By changing this the placement also works for
  Wayland windows in those cases.

REPOSITORY
  R108 KWin

BRANCH
  placement-fix-abstract-client-casts

REVISION DETAIL
  https://phabricator.kde.org/D6274

AFFECTED FILES
  placement.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D6267: Use appstream-qt insted of glib based one

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks! Please merge to master when the new API is available.

REPOSITORY
  R134 Discover Software Store

BRANCH
  appstream-qt

REVISION DETAIL
  https://phabricator.kde.org/D6267

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6273: [tabbox] Fix casts to Client where it should be AbstractClient

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  A few areas in TabBox perform casts from Toplevel to Client. By casting
  to Client instead of AbstractClient the Wayland windows are excluded.
  
  This change addresses the problem by changing the casts where possible.
  The only remaining cast to Client is for shading which is not (yet)
  supported for Wayland windows anyway.

REPOSITORY
  R108 KWin

BRANCH
  fix-tabbox-wayland-client-5.10

REVISION DETAIL
  https://phabricator.kde.org/D6273

AFFECTED FILES
  tabbox/tabbox.cpp
  tabbox/tabbox.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

Minutes Monday Plasma Meeting

[Sebastian Kügler]

Salut,

Meeting minutes of today, attached!

Cheers,
-- 
sebas

http://vizZzion.org   ⦿http://www.kde.org
Plasma Weekly Meeting 19-7-2017

Present: Sho, mart, d_ed, kbroulik

Sho:
* I'm currently focused on fixing various 5.10 regressions
  which will probably take another few days this week before I can return to 
better things
* [TM] Fixed drag hover activation of tasks inside group popup dialogs
* [TM] Fixed group popup dialog contents not refreshing when switching between 
group parents via drag hover
* [TM] Fixed group popup dialog scrollbar not always appearing when required
* [TM] Fixed accounting for scrollbar width when setting group popup dialog 
width
* [FV/KF5] Fixed MouseEventListener not emitting canceled on QEvent:Ungrab on 
Qt 5.8+: Fixes rectangle selection not ending after moving a FV desktop widget 
with press-and-hold, and potentially similar cases in FV and elsewhere
* [FV] Fixed clicking outside preview popup dialogs to dismiss them not being 
handled correctly as a result of refactorings, caused e.g. folders to 
inadvertently being opened in $file_manager and the item not being deselected
next up is looking into all the kio_desktop breakage that makes icons lose 
positions on renames on the desktop etc

mart:
* [wayland] fix windows without decorationto be immediately without 
(kwaylandintegration)
* Plasma::Dialog: make sure size is final after showEvent will allow dialog to 
have a more reliable custom positioning https://phabricator.kde.org/D6215
Diff 6215 "Make sure size is final after showEvent" [Needs Revision] 
https://phabricator.kde.org/D6215
* refactoring notification positioning a bit for making them work better in 
wayland, should get rid of most of its fragile positioning logic, and its 
random fail of notifications wrongly positioned sometimes even on x11, don't 
animate anymore on the client side as is quite wrong
* kwin: make notifications animated with morphingpopups
* had to revert 4690808e65 on kxmlgui
* qqc2-desktop-style now in workspace, so in next plasma release \o/
* kirigami 2.2 release
* in particular, i'm still on the dialog positioning on wayland for the 
notificstion applet: D6215 and D6216
  Diff 6215 "Make sure size is final after showEvent" [Needs Revision] 
https://phabricator.kde.org/D6215
  Diff 6216 "simplify positioning code" [Accepted] 
https://phabricator.kde.org/D6216


d_ed:
* I'm going to upload the hopefully final KWayalnd XDGV6 today
* I think that's been my main work. I also spent some time with these silly 
popups
* I've been improving the current plasma-tests, so it now loads every plasmoid 
and will fail if something fails to load

kbroulik:
* Been answering questions by VDG about their notification stuff (e.g. if 
certain things are possible at all technically before they start coming up with 
crazy ideas ;)
* Plasma browser integration can now also control video players inside of 
iframes, ie. embedded players should now also work
* Will probably do some overall bug triaging this week, perhaps some Dolphin 
stuff

sebas:
- KScreen: Back-and-forth with UTS Data arena, trying to figure out which parts 
of a complex problem we can improve, if not fix
- Working on my kscreen OSD branch ( https://phabricator.kde.org/D3598 ), but 
want to wait for https://phabricator.kde.org/D6215 since I've got positioning 
problems
- want to move Plasma vision forward
- working on app deployment stories, esp which store features do we need for 
asset reviews, gauging how we can get that implemented with the store folks
- bit of more or less random bug triaging, whatever escaped my filtering

Re: Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

[Martin Flöser]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/#review103347
---



We are currently in the process of fading out reviewboard. Could you please 
reopen the request on phabricator.kde.org in order to reach all developers. Not 
everyone is looking at reviewboard any more.

Thank you!

- Martin Flöser


On June 19, 2017, 9:42 a.m., Eric Koegel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130163/
> ---
> 
> (Updated June 19, 2017, 9:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> ---
> 
> ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
> required by Kwin to run under Wayland. This patch first looks for the login1 
> service before attempting the ConsoleKit service.
> 
> 
> Diffs
> -
> 
>   logind.h 8bb0206 
>   logind.cpp fee0f2f 
> 
> Diff: https://git.reviewboard.kde.org/r/130163/diff/
> 
> 
> Testing
> ---
> 
> On a system running ConsoleKit2, logging into a text console and running:
> ```
> export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
> ```
> Most of this patch is just shuffling code around to support both logind and 
> CK2.
> 
> 
> Thanks,
> 
> Eric Koegel
> 
>

D6216: simplify positioning code

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in NotificationItem.qml:33
> If in https://phabricator.kde.org/D6215 you've got a mainItem->setVisible()   
> before the showEvent because that fixes what this is doing.
> 
> If that's the case, why do we still need these changes?

not strictly need, but they should trigger less resizes anyways when the 
dialogs are shown i think, even if they happen before the window is actually 
visible

> davidedmundson wrote in NotificationPopup.qml:60
> So instead of making this inhibitor and changing a bunch of code
> 
> just convert:
> 
> list.clear()
> list.append()
> 
> into:
> 
> list = otherList

can't do that, as notificationItem.actions is a ListModel and 
notificationsProperties is a javascript array instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6216

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6215#117498, @davidedmundson wrote:
  
  > > this will work only when the Dialog' version of setvisible is called,
  >
  > So this will break released Plasma?
  
  
  no, it just means that who calls show() or the wrong setVisible() would just 
get the previous behavior of mainItem being shown only at showevent, so with 
the potential resize/position glitch that is already in now, but setvisible 
gets called both there and in the showevent, so it wouldn't significantly break 
(just in most common case, the second setvisible would be a noop)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[David Edmundson]

davidedmundson added a comment.


  > this will work only when the Dialog' version of setvisible is called,
  
  So this will break released Plasma?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6216: simplify positioning code

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> NotificationItem.qml:33
>  width: parent.width
> -implicitHeight: Math.max(appIconItem.visible || imageItem.visible ? 
> units.iconSizes.large : 0, mainLayout.height)
> +implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 
> ? units.iconSizes.large : 0, mainLayout.height)
>  

If in https://phabricator.kde.org/D6215 you've got a mainItem->setVisible()   
before the showEvent because that fixes what this is doing.

If that's the case, why do we still need these changes?

> NotificationPopup.qml:60
>  // notification.actions is a JS array, but we can easily append that 
> to our model
>  notificationItem.actions.clear()
>  notificationItem.actions.append(notificationProperties.actions)

So instead of making this inhibitor and changing a bunch of code

just convert:

list.clear()
list.append()

into:

list = otherList

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6216

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart updated this revision to Diff 15579.
mart added a comment.


  hide again mainitem when not visible
  
  show it in setVisible, that is before show.
  this will work only when the Dialog' version of setvisible is called,
  so must be paid attention when using dialog directly from C++,
  but it covers all QML usage

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6215?vs=15462=15579

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6215

AFFECTED FILES
  src/declarativeimports/core/tooltip.cpp
  src/plasmaquick/dialog.cpp

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6216: simplify positioning code

[Marco Martin]

mart updated this revision to Diff 15578.
mart added a comment.


  - make sure Dialog::setHeight is used
  
  disable height binding when notifications are repopulated

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6216?vs=15568=15578

BRANCH
  arcpatch-D6216

REVISION DETAIL
  https://phabricator.kde.org/D6216

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5961: PoC: Generic adoption of KUserFeedback for Discover

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> CMakeLists.txt:30
>  
> +find_package(UserFeedback)
> +

Hm, looks like I forgot to rename this to KUserFeedback... Should probably done 
to be consistent with naming elsewhere. I'll look into it, and sorry for yet 
another SC change.

> DiscoverWindow.qml:114
> +
> +UserFeedback.Provider {
> +id: provider

You probably want to set submissionInterval to a fixed positive value for it to 
actually send data automatically. For best results, pick one that matches the 
time aggregation modes in UserFeedbackConsole (1, 7 or 30).

> DiscoverWindow.qml:119
> +feedbackServer: "http://localhost:8083/;
> +telemetryMode: UserFeedback.Provider.BasicUsageStatistics
> +

Note that this means you have basic telemetry enabled by default. If you want 
to let the user control this entirely, just drop the line. Same for 
surveyInterval above.

> DiscoverWindow.qml:133
> +
> +onShowEncouragementMessage: {
> +showPassiveNotification(i18n("You can help us improving this 
> application by sharing statistics and participate in surveys."), 5000, 
> i18n("Contribute..."), encouraged)

For this to trigger you will need to set some of the encouragement related 
properties on Provider, by default it's off.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D6186: Implement software cursor in OpenGL backend

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> Kanedias wrote in scene_opengl.cpp:713
> How come! There's a condition on !m_cursorTexture for that, no? Or is 
> Cursor::cursorChanged itself called on every paint?

Sorry, I missed that the "if (!m_cursorTexture) {" condition still covers these 
calls - to my excuse: inline comments in phabricator are rather messy :-P

So the above worries are void - the only remainders are
a) possible glBlend restorage
b) null'ing m_cursorTexture on empty images to skip rendering (no idea how 
relevant that is) ie. not using the pointer vaildity as indicator for a 
required reset.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

[Kai Uwe Broulik]

broulik added a comment.


  Hover state is reset fine but now the action buttons don't reappear after the 
popup is closed unless I start dragging the folder. Just selecting and 
unselecting does not help, I really need to start a drag (perhaps you break 
some binding in the delegate?)
  
  1.) Click "popup" button on top left of folder
  2.) Click outside of popup so it closes, with this patch the folder is no 
longer highlighted (which is good)
  3.) Hover the folder → the action buttons in the top left of the folder don't 
show anymore, they still work on other folders. So some state still isn't 
correctly reset.
  
  F3787324: Screenshot_20170619_124207.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6247

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:fd4d41bd65fd: Don't rely on QQuickWindow delivering 
QEvent::Ungrab as mouseUngrabEvent (as it… (authored by hein).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6246?vs=15508=15574

REVISION DETAIL
  https://phabricator.kde.org/D6246

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp

To: hein, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:84300b516b79: Fix DND onto Task Manager for groups, group 
dialog scrollbar (authored by hein).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6231?vs=15485=15572#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6231?vs=15485=15572

REVISION DETAIL
  https://phabricator.kde.org/D6231

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6247: Fix clicking outside of preview popups to dismiss them corrupting mouse state

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in FolderItemDelegate.qml:119
> This check is now superfluous as it's also done in `closePopup()`

Yeah, but it's minutely faster to check this than do a function call (and the 
dialog not being open is the common case), it's a little more careful to assume 
a function body doesn't check, and the function does check because it's just 
good practice, ... it's redundant but I'd leave it like that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6247

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5bd54084cf41: Make --test mode run without spawning 
kactivitymanagerd (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6133?vs=15246=15569

REVISION DETAIL
  https://phabricator.kde.org/D6133

AFFECTED FILES
  shell/main.cpp
  shell/shellcorona.cpp

To: davidedmundson, #plasma, hein
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6237: Avoid resize on showing notificaton item

[David Edmundson]

davidedmundson abandoned this revision.
davidedmundson added a comment.


  Code is now in https://phabricator.kde.org/D6216

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6237

To: davidedmundson, #plasma, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6216: simplify positioning code

[Marco Martin]

mart updated this revision to Diff 15568.
mart added a comment.


  - don't depend from visibility

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6216?vs=15464=15568

BRANCH
  arcpatch-D6216

REVISION DETAIL
  https://phabricator.kde.org/D6216

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/plugin/notificationshelper.cpp
  applets/notifications/plugin/notificationshelper.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6231: Fix DND onto Task Manager for groups, group dialog scrollbar

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D6231

To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6133: Make --test mode run without spawning kactivitymanagerd or restarting

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6133

To: davidedmundson, #plasma, hein
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart, lukas

D6267: Use appstream-qt insted of glib based one

[Jan Grulich]

jgrulich created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Currently appstream-qt doesn't provide all necessary stuff we need to use and 
that's why
  we used for part of the code glib based appstream API. I implemented the 
missing bits to
  appstream-qt which are now on review and once those changes are merged and 
new version
  of appstream is released we can use appstream-qt only.

TEST PLAN
  I tested the flatpak backend with my changes and it works as before.

REPOSITORY
  R134 Discover Software Store

BRANCH
  appstream-qt

REVISION DETAIL
  https://phabricator.kde.org/D6267

AFFECTED FILES
  CMakeLists.txt
  libdiscover/backends/CMakeLists.txt
  libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
  libdiscover/backends/FlatpakBackend/FlatpakResource.cpp
  libdiscover/backends/FlatpakBackend/FlatpakResource.h

To: jgrulich, apol
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  with this, that removes most of the properties depending from visible, i 
usually get properly sized notifications, tough every now and then the size 
still fails and a reposition is always visible right after the notification 
appears
  https://pastebin.com/ia8nLGiw

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D6215#117370, @mart wrote:
  
  > it's maybe due to the layout of actions buttons that changes (in the 
notification applet, populatepopup) but this (columnLayout computed height) 
doesn't really have effect until it's visible.
  
  
  in fact, if in the notification applet i do, right before setVisible():
  popup->property("mainItem").value()->setVisible(true);
  
  making mainitem visible just before the showevent, 
  then the look is correct.
  
  if i do that right in the showevent handler, it's too late and i get wrongly 
calculate sizes and spurious extra resize events

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  it's maybe due to the layout of actions buttons that changes (in the 
notification applet, populatepopup) but this (columnLayout computed height) 
doesn't really have effect until it's visible.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

[Marco Martin]

mart added a comment.


  this is how it looks under wayland, keeping the visibility change of the 
mainitem in plasma-framework and your patch in the notifications applet 
F3787256: Spectacle.Vd3087.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

Review Request 130163: Add ConsoleKit2 support for launching Wayland sessions

[Eric Koegel]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130163/
---

Review request for Plasma.


Repository: kwin


Description
---

ConsoleKit2 as of version 1.1.1 implements the Session Controller dbus calls 
required by Kwin to run under Wayland. This patch first looks for the login1 
service before attempting the ConsoleKit service.


Diffs
-

  logind.h 8bb0206 
  logind.cpp fee0f2f 

Diff: https://git.reviewboard.kde.org/r/130163/diff/


Testing
---

On a system running ConsoleKit2, logging into a text console and running:
```
export $(dbus-launch); export QT_QPA_PLATFORM=wayland; startplasmacompositor
```
Most of this patch is just shuffling code around to support both logind and CK2.


Thanks,

Eric Koegel

D6186: Implement software cursor in OpenGL backend

[Oleg Chernovskiy]

Kanedias added inline comments.

INLINE COMMENTS

> luebking wrote in scene_opengl.cpp:713
> You still update the cursor texture with every paint() - there should be no 
> need to hook this signal.
> Actually, the patch got much worse:
> 
> a) you're fetching the image and reset the texture with each! paint()
> b) you're creating a nerw connection to cursorChanged() with each! paint()

How come! There's a condition on !m_cursorTexture for that, no? Or is 
Cursor::cursorChanged itself called on every paint?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6186

To: Kanedias, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein, lukas

D1231: Add Remote Access interface to KWayland

[David Edmundson]

davidedmundson added a comment.


  We don't want or need to go via the QPA on the server side. The wayland 
specific output management is in the  DRM plugin, your code is in the DRM 
plugin. It should be simple.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, 
hein, lukas