Re: Plasma 6.1 and 6.2 release schedule proposal
On Friday, 7 June 2024 21.11.07 CEST Jonathan Riddell wrote: > The main action happens around September, pic attached. We have repo > and soft feature freeze 29 August, 6.2 beta 12 september, 6.2 Tars on > 3 October to be released 8 October. That means 6.1.5 and 6.2 beta > happen during Akademy. > > Yay or nay? To me seemsto make sense, +1. other opinions? -- Marco Martin
Monday meeting notes for 6/5/2024
Kai Uwe fixed audio indicators in task manager not working after the pulseaudio-qt port – turns out there’s a subtle API difference between the two that broke the lookup by stream index. jpetso Continued work on my per-monitor brightness branch. Current MR backlog: (1, 2, 3, 4), more coming up but still grouping code together into reviewable chunks. After working through code and Bugzilla, I am now convinced that dimming will always be at least a little buggy unless we store display brightness for all "managed" displays across reboots & hotplugging events. Will make another push for replacing Power Management KCM's "Change screen brightness" transition in power state profiles to simply "Screen brightness" persistent state. Tweaks for New ComboBoxWithCustomValue component from Screen Locker KCM following review comments, with an aim to upstream it to Kirigami once approved for the KCM itself. I'm also hoping for Kirigami.Dialog preferredWidth auto-expand fix to get reviewed now that Carl's redesign is in, to allow moving forward on standardizing Screen Locker's DurationPromptDialog. Made "Shader Wallpaper" plugin work in the lock screen by assigning the wallpaper context property early enough for bindings to use. In response to a Discuss thread about having lock screen savers. Also needs review. Nico I worked towards deploying applets as QML modules. I have a working prototype, still needs to be clean up a bit There's still some places like the widgets explorer that assumes that applets always have a KPackage, that needs to be cleaned up Nate I proposed a merge request template (https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4247) that seems to have gathered many opinions Natalie Reworked releasing app inhibitions to permanently block an app - reason combination instead of one inhibition occurrence. It works but I'm now thinking it might still be useful to be able to block an inhibition just once; currently working on a suitable frontend for it. What I have in mind is a sort of ComboButton, basically what can be done with nested Kirigami actions but in a way that doesn't break the layout and is styled appropriately when used outside toolbars. I ws thinking of a Plasma component but not yet sure I'll succeed and if it will have any other uses. Otherwise nothing noteworthy. Spent some time (mostly unsuccessfully) educating myself about monitor connections and DDC/CI and looking through bug reports. Marco * Merged the plasma popups workaround for the size bug in Qt 6.7 * Fighting against layershell for some panel sizing misbehaviors https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4274 * but actually started to look at a layershell protocol extension to further improve things * pushed taskbar refactor * started a desktop edit mode ui redesign https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2235 -- Marco Martin
Re: Improving Tiling Window Support in KDE Plasma
On Thu, Mar 28, 2024 at 1:43 PM Aakarsh MJ wrote: > > there are already 3rd party scripts that attempt to do that, like one > > called polonium https://github.com/zeroxoneafour/polonium tough is > > still quite buggy > > I have checked polonium before, unfortunately for me it was way too buggy to > use it on a daily basis. yeah, for now i', not sure polonium "can" be much bettergiven the underlying features. A significant thing missing that i seen is virtual desktops support, as tiles are at the moment per-screen and not (yet) per-virtualdesktop, so even just switching desktop it kinda breaks the layout. The script could keep a copy of every window-tile association and reassign everything on every desktop switch but would be kinda error prone and have too much complexity on javascript side. What really needsto happen here is an internal support of tiles per-visrtualdesktop on kwin side (ideally the cartesian product of screen,virtualdesktop and activities) but it will be a significant refactor -- Marco Martin
monday meeting notes for 19/2/2024
Kai Uwe Okular: Fix render glitches in presentation mode with fractional scaling under Wayland, please have a look: https://invent.kde.org/graphics/okular/-/merge_requests/927 Seems there’s some other things wrong in it during transitions (damage region? dunno) but at least the presentation itself looks ok now plasma-browser-integraton: Truncate excessively long URLs in download reporting (e.g. data URLs), https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/121 Plasma: Fixed Kickoff search broken, looks like a QTBUG but I haven’t been able to reproduce with a minimal example It fails to resolve some property type and then assignment fails :/ Add %j placeholder for Solid device action, needed by KIO AFC, please review: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/121 Frameworks: KIO::iconNameForUrl strips slashes now before matching a standard path, fixes Dolphin’s tab bar not using the proper (e.g. Downloads) icon Qt: Been looking into supporting QSurfaceFormat for SHM (raster) windows Right now all Qt Wayland SHM windows are RGBA32, regardless of whether the app wants transparency or not. I want to at least alpha vs non-alpha (QSurfaceFormat is quite extensive), so we get an XRGB surface for e.g. WA_OpaquePaintEvent windows That’s most toplevel windows, except maybe context menus and tooltips All much more complicated thanks to stupid client-side decorations, as usual presentationwidget: Invalidate pixmaps on dpr change (!927) · Merge requests · Graphics / Okular · GitLab - GitLab Since the last rendered pixmap is usually reused, its device pixel ratio can end up different from the devicePixelRatioF() of the widget which is used for most size... Download Job: Truncate excessively long URLs (!121) · Merge requests · Plasma / Plasma Browser Integration · GitLab - GitLab Limit them to a reasonable length, and don't send data URLs at all since they aren't human-readable and typically very long. Modeled after what KIO does... Xaver: * mostly bugfixing ahead of the release, not gonna list it all * implemented direct scanout for the nested Wayland backend, which reduces latency and improves efficiency with fullscreen windows. More nested pass-through stuff might still come later * started fixing plasmashell dying when too many windows are open. KWayland is getting in the way though, so if anyone is more motivated than me to port shellcorona away from KWayland, that would be nice :) * added a workaround for Intel to not advertise HDR support by default, because the Intel driver is broken AF. So don't be surprised if the HDR option disappears on Intel hw... You can get it back with KWIN_DRM_ALLOW_INTEL_COLORSPACE=1 * implemented an experimental tag of the upstream color management protocol in KWin. If KWIN_ENABLE_XX_COLOR_MANAGEMENT=1 is set, it'll be exposed to apps, and you can start experimenting with it / implementing it in apps. There shouldn't be any major changes to the final upstream protocol when that's merged. Note that you'll also want to set KWIN_DRM_FORCE_COLOR_MANAGEMENT=1 if you do anything with alpha blending through Wayland, because otherwise it won't be correct [DavidE] wrt plasmashell and kwayland lets check what it's using it for and see if we can make some dedicated simpler API for that [Xaver] it's only about the active window. Adding a plasma window management event for that would make it simpler instead of all the tracking that KWayland does internally Nico: In terms of "are we ready?": There's ~500 bugreports tagged with 'qt6', which sounds scary but isn't really But I'd appreciate if eneryone went though the list and looked for important ones/blockers https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=qt6_type=allwords_id=2616845_format=advanced Fushan Port many QString::split to QStringView::split, use efficient overloads. Many have been merged thanks to apol and alex, some awaiting approval, one regression found and fixed thanks to genericity. It's a simple change that can reduce hundreds of instructions :) https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/539 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3925 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2043 (not mergeable because gcc11 doesn't fully support split_views) https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2044 Keep the context menu of a containment to work around a qtbug: https://invent.kde.org/plasma/libplasma/-/merge_requests/1061 Add screenFromQuickWindow in PanelView to fix a keyboard navigation problem: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3722 Be more heuristic in finding the associated desktop file for a window: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3932
Re: More 5.27 Releases
I agree, but as discussed in the meeting today, if we want to do a 5.27 release, we should backport the ci adaptations and make ci actually work there On Mon, Feb 12, 2024 at 11:53 AM David Edmundson wrote: > > Plasma 5.27 is not getting any more regular timed releases. However in > the past for LTS releases we have said that we would just make them > on-demand if there's enough stuff. > > I've seen enough patches over the last month that warrant putting into > 5.27 with people not cherry-picking some major fixes because "there's > not going to be another release". I want to request that we do at > least one more spin some time in the next few months. > > David
Monday meeting notes for 18/12/2023
Joshua Stuff that's already approved but still noteworthy: Been talking about it last week, but finally did it! Kirigami now says which style you're using which may help you with "platform plugin not found" warnings. https://invent.kde.org/frameworks/kirigami/-/merge_requests/1411 Handle the lockscreen fallback greeter failing, which should never happen but now it works a little bit better. https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/193 This MR needs another look, because I modified it quite a bit: Check if the QQC2 style exists before setting it in (Qt6) Plasma Intregration: https://invent.kde.org/plasma/plasma-integration/-/merge_requests/126 Fallback styles work differently in Qt6, as in if it doesn't exist then the engine will hard exit (that pesky "org.kde.breeze module not found" error.) I filed https://bugreports.qt.io/browse/QTBUG-120194 for this. I suggest it should still be merged for 6.0, I don't know when it'll get fixed upstream (or when I'll find time to fix it.) There's also the question of it affecting everything before 6.6.2 or something like that, so the code needs to stay until we bump the required min Qt. I tried to section it off as much as possible, so it can be easily removed later. Also KWaylandIntegration was stripped of something it should've had, if nicofee or David Redondo (@davidre:kde.org) could take a look at https://invent.kde.org/plasma/kwayland-integration/-/merge_requests/63 that would be nice :) Niccolò I spent some time refactoring the code that sizes the applets in the panel after the change from @notmart to make all them fillWidth by default; there were some edge cases which I think I fixed now. I was also looking into panels having the keyboard focus line on startup whenever they were empty, but I couldn't find the issue. I added a button to make the dialogs floating (detached from the panel); we had that already out of the box for floating panels, but there was no way to trigger it for non-floating ones. However it's technically a feature and it will require an exeption. Plus some other uninteresting bugfixes :P https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1901 Xaver I'm spending most of my KDE time bugfixing, but I got a few nice things still done and queuing up: * an implementation for tearing with atomic modesetting, so that the "allow tearing" checkbox finally actually does something by default: https://invent.kde.org/plasma/kwin/-/merge_requests/4800 * an implementation for explicit sync. It's still very WIP but it'll fix lots of issues with NVidia on Wayland: https://invent.kde.org/plasma/kwin/-/merge_requests/4693 * I wrote a blog post about the HDR stuff * I have some more color management and VRR improvements I plan to work on, but a bunch of them probably have to wait for Plasma 6.1 Nico I upgraded my Qt to the new 6.7 branch Which was fun, because I ran into a handful of bugs, so I spent some time reporting them Other than that I did a push on https://invent.kde.org/plasma/kscreen/-/merge_requests/126 Which has a few dependent changes And multiple ways how things could be done Akseli * I worked on this MR over the weekend because it was bothering me, I wanted to refactor that old code I had there. https://invent.kde.org/plasma/breeze/-/merge_requests/386 * Instead doing our own weird math, just use KColorUtil::mix to make the colors fit. * This should make the colors more consistent across desktop, since it follows the values other elements have. * It's a small step towards my goal of making outline and separator colors consistent. * This consistency will also help in future if/when I start working on customizable separator colors. * Which then in turn allows us make accessible high contrast themes. :) * Also looking into issues with kickoff crashing when resuming to use PC after screen has been turned off for a while. This is my prio. https://bugs.kde.org/show_bug.cgi?id=478679 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3695 Arjen * been chasing plasma bugs * currently investigating a crash in plasmashell I get with mirrored screen Carl Worked mostly on porting apps to Qt6 Plasma relevant, i created https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/344 and a related thread on the kde-devel mailing list about spacing/margins. It might be a good idea to get some other thoughts on the topic of Kirigami.Units vs QStyle::pixelMetric(PM_LayoutMargin). Kai Uwe KWin: Allow show desktop screen edge during drag and drop, please review: https://invent.kde.org/plasma/kwin/-/merge_requests/4792 Lets you start dragging a file, nudge the screen edge to show the desktop, drop on desktop Plasma: Folder View creates drag pixmap with dpr now Will add “Channel” to WLAN frequency details Frameworks: Support XDG foreign, I’d really get this in soon...
Monday meeting notes from 11/12/2023
Kai Uwe Frameworks: Worked on a nicer public API for XDG foreign, please review: https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/136 It kinda feels like KWindowSystem::setMainWindow should work with it, too, but it’s WId and not a string, and apps need to cater for the Wayland case either way? Opinions on the API? Qt: Investigating how to make QQuickDefaultTextureFactory take into account devicePixelRatio (for grabToImage) without jeopardizing any of its internal use cases (SVG and @2x pixmap stuff), https://codereview.qt-project.org/c/qt/qtdeclarative/+/494129 It’s a bit of a game of whack-a-mole, fix one use case, break another one :( Now just checking for it being a grabresult URL scheme and setting the DPR from it, to not touch any other codepaths. Still need to investigate why drag pixmap in FolderView is still blurry Joshua i've been doing lots of gear-related stuff. my qmlformat patches are slowly making their way through the pipeline and will start being usable from 6.5 onwards for us soon im fixing those two kscreenlocker tests that kept failing on the CI: https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/191 https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/192 Arjen I tried finding and fixing a caching bug in ksvg but didn't really have any luck Nico I worked on getting KAccounts ready for KF6 There's still a few unmerged patches on the upstream side But at least the KDE side should now be ready [fvoght]: Did you see the signon-ui patch I sent upstream a while ago? [nico will look]https://gitlab.com/accounts-sso/signon-ui/-/merge_requests/6 Other than that I fixed some stuff for service menus in Dolphin/KIO And I've been thinking that we might want to be more lenient about supporting older entries that aren't adapted to KF6 To support existing store entries Fixed media controls on the lockscreen Looked into why the emoji picker is laggy on 6 but fine on 5 Seems like a regression in QtQuick text rendering perf in Qt6 My best guess is that the glyph caching is broken DavidR I bumped Plasma repos to Qt 6.6 FreeBSD was on Qt 6.6 but nobody told anyone (Job labels are still Qt 6.5) Rest of the weeks I spend pressing "stage" on qt CI, but now QWaylandScreen is public API And QWindowsScreen and QAndroidScreen as well if you have use cases for those Fushan Implement touch action in the at-spi webdriver, which will be useful in some places: https://invent.kde.org/sdk/selenium-webdriver-at-spi/-/merge_requests/54 Slightly improve the visual feedback of the switch indicator when it's being dragged: https://invent.kde.org/plasma/libplasma/-/merge_requests/1010 Will sync to qqc2-d-s once there is a consensus Port the device notifier dataengine away. The one is simpler but I still want to leave it for 6.1 in case of any unexpected regressions since there is only a smoke test. Make the media controller widget more efficient by preventing the same image from being loaded twice when the widget is expanded. Also found another ancient transition glitch in StackView. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3662 Added a new property in WallpaperItem named accentColor to replace the old repaintNeeded signal, which will be useful for custom accent colors from wallpapers (especially for the color preview). Marco * Adapted to QScreen behavior change upon last screen disconenction * fixed some fallout from the panel applet config popup porting out of PlasmaCore.Dialog * made the comic applet actually work again * helped a bit investigating overview animations * investigation on what store categories need duplicating, asked Justin as need all of them to be created on store side before doing any further work * some more keyboard navigation in panel config * investigating panel sizing issues
Re: Plasma 6 alpha modules list
On Sat, Oct 28, 2023 at 9:30 PM Nicolas Fella wrote: > > In https://mail.kde.org/pipermail/release-team/2023-June/013081.html I > proposed to move print-manager and wacomtablet from Gear to Plasma. > Nobody objected so I guess we can move forward with this? yesplease <3 -- Marco Martin
Monday meeting notes for 23/10/2023
Kai Uwe For some reason for a couple of days I am having something eat all RAM when my system wakes up after having been suspended by closing the lid. It recovers after a short while when the Linux kernel starts killing chromium processes but I still haven’t figure out what causes this. KWin: Let decorations communicate init failure, allows e.g. Aurorae to report failure to load QML files ABI break, void init() is now bool init(), adjusted Aurorae and Breeze, Oxygen pending Fall back to CSD when decoration loading fails as a last resort to avoid ending up with no decorations Minimize geometry for child windows checks their parent now To match X11 behavior. Ensures they are minimized correctly to Task Manager once we filter them out there Plasma: VPN password dialog calls forceActivateWindow again, focus stealing prevention breaks that on X Need to find a proper/cleaner way for Plasma 6… Frameworks: KUrlNavigatorToggleButton is rendered correctly with fractional scaling now Qt: Qt Multimedia sets correct app id/name/icon now Apps no longer show up as just “QtPulseAudio” in Volume applet Looked a bit into non-RGB subpixel font rendering Gonna be a tough one, on Unix Qt just checks Fontconfig, completely disregards what QScreen says, and even if it did mostly just checks the primary one, nevertheless implemented subpixelAntialiasingTypeHint on QWaylandScreen Found that nasty Qt DBus “Could not connect” error breaking Solid, BlueDevil and others: https://codereview.qt-project.org/c/qt/qtbase/+/513362 Joshua Did two small things for plasma last week: Fixed the default keybinds for switching between virtual desktops in kwin (https://invent.kde.org/plasma/kwin/-/merge_requests/4519) Fixed the activity manager applet for Plasma 6 (https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1772) DavidE There's some activity on the topic of activities Discussion about https://invent.kde.org/plasma/plasma-workspace/-/issues/35 Xaver * I was at a Valve hackfest and XDC, and got a bunch done there: * I helped push the tearing patches for the kernel forward again by talking with a few people and testing an edge case * I figured out why my ICC profile patch for KWin weren't working, they're all correct now * made some plans for multi gpu handling with Vulkan and Wayland protocols * I got some advice on how to debug GPU resets with my WIP Vulkan renderer for KWin * last but very much not least, together with Joshua (Valve) and Victoria (System76) I got a working prototype of HDR games working in gamescope running nested in KWin, with the upstream color management protocol proposal! I'm currently looking into cutting down the protocol so that we can still get this working before Plasma 6 DavidR * Last week nicofee and I made a last push to get rif of kwayland-intregation * The wayland plugin is finally in kwindowsystem now * kwayland-integration is Qt5 only to support Qt5 apps on plasma6 * I see nicofee has continued refactoring kwindowsystem but that he can tell about himself Niccolò I finished up the panel settings redesign, now everything should be working nicely, including the ruler :) I did found a couple of weird positioning issues on plasma-framework / plasma-workspace for the main dialog though, I've investigated them a bit. Next up I'll be focusing on adding the visibility options we decided to introduce (or re-introduce) in the VDG (windows go below, dodge windows) Marco * fixed layout problems in panel on non fillwidth * pushed api change in ksvg and a bunch of depending repos (QSize->QSizeF signature change) * redone and properly fixed the fix of kirigami applicationheader * kwin: fixed crash in kwin on WindowThumbnail teardown (destructor already ran) * fixed some papercuts in discover, continuing this week * backported a crash fix in Qt5: still have to do a commit in the proper format, ugh https://invent.kde.org/qt/qt/qtdeclarative/-/merge_requests/53
Re: Taking on maintenance of Latte Dock
Hi Lana, thanks for volunteering on taking on this project! And yes, you should get a developer account, see https://community.kde.org/Infrastructure/Get_a_Developer_Account On Sun, Oct 15, 2023 at 11:04 PM Lana Black wrote: > > Hello list, > > I tried poking various people on IRC and what not about this, but nobody > pointed me in the right direction, so I'm here. > I'm willing to take on maintenance of Latte, because it's just so cool and I > would very much hate to see it go. For that, I would either need a write > access to the repo or to have someone in contact who can merge my changes for > me (poking people on IRC doesn't work and trying to join the Matrix room sent > my server OOM with flying colours). Anyhow, I have already made a cool PR [1] > and can make more, if anyone's interested in this. Otherwise, I'll just fork > Latte and continue with it on my own turf. > > With best regards. > > [1]: https://invent.kde.org/plasma/latte-dock/-/merge_requests/46 -- Marco Martin
Re: Latte Dock Farewell
On Mon, Oct 16, 2023 at 6:33 AM Carl Schwan wrote: > > Someone is trying to step up. See > https://invent.kde.org/plasma/latte-dock/-/merge_requests/46/ > > We probably should try to support them, instead of shutting down the project. > Cheers, > Carl Agree, let's see how this goes, i'm hopeful :) -- Marco Martin
Monday meeting notes for 18/09/2023
Nico * I spent some time cleaning up runtime warnings in plasmashell * Which exposed some minor issues * Reworked kstart help page: https://invent.kde.org/plasma/kde-cli-tools/-/merge_requests/87 * Fixed a small regression in systemsettings: https://invent.kde.org/plasma/systemsettings/-/merge_requests/254 * Fixed various Qt 6.6 build issues in kde stuff * Some cleanups for thumbnail code * And some powerdevil cleanup * In terms of more interesting stuff: * Made a patch to use the new QML module stuff for KCMs: https://invent.kde.org/frameworks/kcmutils/-/merge_requests/171 * Which allows us to benefit from the qmlcachegen compiler etc * And it's surprisingly self-contained * We also should think about doing something like that for applets, at least first-party ones * That's it from me Arjen * main thing I've been doing is work on replacing basiclistitem in kirigami * I think the kirigami side is now pretty much done * there's an open mr for plasma-workspace that has some regressions, nothing too major though * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2948 Kai Uwe Wrote a post about what I did in Plasma 6 in August: https://blog.broulik.de/2023/09/on-the-road-to-plasma-6-vol-%e2%85%b2/ :-) I was looking into using a “soft hyphen” in places to allow for dynamic word wrapping of certain long works in German. It seems to render fine (App result breaks in Kickoff grid view, shows in a single line with no hyphen in KRunner) but KRunner needs to be adjusted to ignore those characters during matching, otherwise it wouldn’t find them anymore. Still unsure if we can somehow enable dynamic wordwrapping, with a Kirigami component or something based on this LaTeX word hyphenation database? Plasma: Fixed add to panel / add to desktop not working in Kickoff Currently fixing “Add to favorites” not working in Kickoff Also found that Kickoff doesn’t reload the menu, it creates it only once per delegate, so “add to favorites” doesn’t update live in the menu… Hack around KFontViewer not working on Wayland, please review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3290 Strip null bytes from FileChooser portal, in line with what we had to do in Solid, please review https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/226 Kirigami: Did a bunch of fixes for Mnemonics, please review: Trigger update when toggling mnemonic, so QStyle repaints, https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/296 Rework event filter: https://invent.kde.org/frameworks/kirigami/-/merge_requests/1255 Currently every single MnemonicAttached installs an event filter on the QWindow Fix mnemonics not working on buttons, https://invent.kde.org/frameworks/kirigami/-/merge_requests/1256 Toggle control in FormLayout on mnemonic activation, like QFormLayout does: https://invent.kde.org/frameworks/kirigami/-/merge_requests/1254 Vlad * I have been working on making resizing windows on wayland less glitchy * qtwidgets: if you run qt dev, then dolphin, kate and any other application that uses qwidgets should look perfect if it's resized * qtquick: it's more challenging but it's fixable https://bugreports.qt.io/browse/QTBUG-116982. The good thing is that it is a problem common to other platforms too so there's motivation to fix it * As is, wayland is glitcher than x11 * but hopefully with my changes in dev, they are going to be on par Natalie fixed manual inhibition state not synchronized across battery applets: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3294 started digging into patching logind to emit lid close property change signal so we can move forward with https://invent.kde.org/plasma/powerdevil/-/issues/22 revived discussion on energy saving KCM redesign: https://invent.kde.org/plasma/powerdevil/-/issues/10 looked into some suspension related bug reports -- Marco Martin
Monday meeting notes for 11/09/2023
Natalie - Added an eco tab for kxmlgui (still needs revisions): https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/187 Joshua would take care of a Kirigami equivalent. Apart from that, worked on suspend handling: - Fixed https://bugs.kde.org/show_bug.cgi?id=473835 - Fixed hybrid-suspend and added suspend-then-hibernate in kworkspace session management, so we can go forward with https://invent.kde.org/plasma/powerdevil/-/issues/28 - Did various enhancements to the power KRunner - Tried to port lid close handling (in PowerDevil, but something equivalent is needed in KScreen too) to logind because it will break with the next release of upower (https://invent.kde.org/plasma/powerdevil/-/issues/22). It failed on the fact that no proprety change singal is emitted for the lid closed property with logind. I'm thinking that the easiest fix for us might be to try and submit a patch for this upstream. We discussed some alternatives in the KWin room but I haven't been able to find a readily available solution for both X11 and Wayland. 1) upower is dropping support for it, 2) the KWin device DBus interface only works on Wayland, 3) XInput doesn't seem to have lid events, 4) libinput debug-events or equivalent requires root privileges, 5) and hacking directly in sysfs seems complicated and unsafe. Thoughts welcome. Arjen * we've merged the changes in ECM that port ecm_add_qml_module to use the upstream QML module macros * on system monitor, me and david redondo have been doing some work to port it to upstream treeview * generally it works, though there's a few hoops to jump through still Meven * I have updated slightly https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3122 * And then did a few bug fix and review, in kio-extra: jpeg won't use exif thumbnail if they are too small, https://invent.kde.org/network/kio-extras/-/merge_requests/279 no more libpng warning: known incorrect sRGB profile https://invent.kde.org/network/kio-extras/-/merge_requests/280 in dolphin : open containing folders for files in recentlyused:/ https://invent.kde.org/system/dolphin/-/merge_requests/616 https://invent.kde.org/system/dolphin/-/commit/5c33e0211ff09f37adb5b48c59cf15b67c0059dc Nico * A recent KAuth change exposed some pre-existing issue where dev sessions don't find things I tried to fix it with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3257, but doesn't seem to work * Using ecm_add_qml_module for QML KCMs: https://invent.kde.org/frameworks/kcmutils/-/merge_requests/171 * And a bit of powerdevil refactoring * And fix bluedevil not finding devices sometimes: https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/50 Fushan I have one important fix that I hope it can be landed on tomorrow's 5.27.8 Fix 1px gap in Breeze decoration: https://invent.kde.org/plasma/breeze/-/merge_requests/352 Efficiency improvement in mobile toolbar: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/865 https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/279 Test the new waylandtasksmodel and fix a few bugs: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3266 A few a11y cleanups for window switchers: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3272 https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/456 https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/455 https://invent.kde.org/plasma/kwin/-/merge_requests/4392 Looking for supporters on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3256 , will use it to debug a11y problems in KCMs Marco * some cleanups in KSvg api * fixing some regressions in porting to new KSortFilterProxyModel * merged the new hint in kirigami for alternating row colors * some improvements in kcms api, introduce the "sidebar" ones * port users kcm to that, getting rid of some ugly code * fixed meta+number task activation on plasma6 -- Marco Martin
Monday meeting notes for 28/8/2023
Nico * I did a bit of refactoring in powerdevil * Splitting the monolithic "backend" thing into separate classes * Splitting the monolithic "backend" thing into separate classes * Based on Arjen's work on ecm_add_qml_module I ported Kirigami to use declatative type registration * https://invent.kde.org/frameworks/kirigami/-/merge_requests/1220 * (ecm_add_qml_module not landed yet) * Proposal for new API for KService::property(): https://invent.kde.org/frameworks/kservice/-/merge_requests/155 * unbroke kwallet after recent change: https://invent.kde.org/frameworks/kwallet/-/merge_requests/65 Fushan * Add a message to the deprecation porting guide that strut arguments must be in device coordinates: https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/114. What do you think of the idea? Most existing users are still using KWindowSystem::setExtendStruts in KF5, so when they port things they should notice that. (https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/113#note_743400) * While removing the application dashboard, I also looked into reviving the rotten code in Kicker, replacing custom drag helper and the odd Kicker.WindowSystem, using declarative KeyNavigation instead of forceActiveFocus() to handle keyboard navigation. The code should be simplified now. [discussion on dropping the dashboard, current code is not salvageable, but something is needed for 6.0] [no objection from me to blow up the current one, kinda feel something new is eventually needed] Kai Uwe KWin: Continued on don’t trigger screen edge during implicit pointer grab Don’t activate desktop window when it shows up, https://invent.kde.org/plasma/kwin/-/merge_requests/4349 imho is a valid real-world fix (and one that X also has), so I don’t like that debate of principles it sparked again… Plasma: Fixed crash in ContainmentLayoutManager (5.27) Fixed excess padding in user switcher applet, please review cherry-pick: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/448 (5.27) Fixed config button and global shortcut setting not working in System Tray (6.0) Set default message box icon for confirmation prompt in system settings, please review https://invent.kde.org/plasma/kwin/-/merge_requests/4349 (6.0) Had a look at my constant KRunner crashes, it’s somewhere with make current in wayland GL context + decorations + threads but can’t reproduce now that I have a debugger hooked up and some qdebug added… Apps: Fixed Dolphin view icon rendering blurry/pixelated with fractional scaling (Qt 6) Fixed Dolphin text color not updating properly when changing the color scheme, again… (Qt 6) KDialog plays a sound on message boxes now, like “proper” message boxes do Frameworks: Fixed DialogButtonBox sizing, made the QtQuick Dialogs look broken They still don’t resize horizontally (can barely fit three buttons) but that’s a Qt issue imho there’s no way around providing our own MessageDialogHelper based on KMessageDialog in plasma-integration for Plasma 6 even if we fixed Qt for 6.7 (which is a big task because it needs infra to use widgets without pulling that into the main lib…) that’s still too late for Plasma 6.0 KMessageDialog uses the correct sound for warning notifications now KConfig reads time stamps in UTC now (new Qt 6.6 API), it’s a few tens of milliseconds faster on startup :-) Next up is KService to shed another 0.1ms or so… Qt: Worked on a QGuiApplication::setDefaultTextFormat, so we can force PlainText everywhere, “fun” discussion: https://codereview.qt-project.org/c/qt/qtbase/+/498400 Working on a QScrollBar::createStandardContextMenu, so a caller can override the context menu without re-implementing it entirely Want to add check boxes for toggling minimap on Kate’s scroll bar Kickstarted fixing MessagDialog not working without a Window, cf. https://codereview.qt-project.org/c/qt/qtdeclarative/+/433022 It’s what broke the “Delete?” confirmation in network settings Fixed switching from a shape cursor back to bitmap cursor not working on Wayland (e.g. kolourpaint tool cursors) No longer creates a cursor surface on Wayland at all if only using shape cursors, tiny optimization :-) Wait for compositor to send a fractional scale, don’t assume 1.0 initially apps really shhouldn’t be rendering before exposed with the right scale and output and all, though [discussion about dialogs, labs version or "proper" which still has problems] Xaver * I've been doing a bunch of optimization work for KWin: * KWin is measuring GPU rendering time properly now, so fewer frames should get dropped when the GPU can keep up * for when the GPU doesn't keep up, there's https://invent.kde.org/plasma/kwin/-/merge_requests/4358 which should help boost GPU clock speeds when needed. It would be great if someone with an underpowered Intel laptop could test the MR with the linked kernel
Monday meeting notes for 21/8/2023
Nico * Mostly frameworks-y stuff as usual * Hightlight: a new framwork, kstatusnotifieritem * I did one big-ish Plasma thing: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1675 * This is beneficial for cases where we have a big listview, like e.g. in Systemtray * There we then can use ScrollViewKCM * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3204 * doesn't change yet the cfg_foo magic properties [discussion about plasmoids config] [why plasmoid config doesn't really work in kiosk] Kai Uwe There’s a session by Volker Hilsheimer planned for Qt Contributor’s Summit about “Evolving QIcon and theming”: Theme support is very much based on the freedesktop spec, which hasn't moved much since 2006 years. In more recent years, Microsoft and esp Apple have added rich support for icons to their platforms. QIcon and the theme-abstraction as it is today doesn't map well to those capabilities. The implementation has improved in the context of QTBUG-102346, but the design is in general too limited to support multiple system themes, layered icons with variable properties, and icon coloring and tinting with palette or hierarchical color support. (see https://wiki.qt.io/Qt_Contributor_Summit_2023_-_Program ) We should make sure to get our requirements in there, too! KWin: Don’t send preferred scale if not determined yet QtWayland also assumes scale from wl_output, then inits the fractional scale interface to 1.0 and then KWin sends it the real scale this leads to a momentary incorrectly scaled frame. Will look if working with “move resize ouptut” (so we get the pending state) helps. Ported the screenedge KCM from Plasma::FrameSvg to KSvg::FrameSvg, please review: https://invent.kde.org/plasma/kwin/-/merge_requests/4342 Now just the screenedge effect is missing and then KWin will no longer depend on plasma-framework at build time \o/ Explicitly set Text.PlainText in various labels. Go have a window or virtual desktop with the name hello and get funky results Stupid AutoText … Fixed XDG Positioner code in KWin, now repositions “non-reactive” popups, too e.g. if you move a window while a context menu is open, the context menu will stick to the window and move around with it Replay move window action if window isn’t movable, https://invent.kde.org/plasma/kwin/-/merge_requests/4332 Mostly meant to fix tabbox when using Alt as KWin modifier (since you hold Alt during Alt+Tab and then it conflicts) However, also means that trying to move any immovable windows, like context menus, with Alt/Meta+click will trigger any action that is under the mouse Notifications: KMessageDialog now uses the correct sound for “WarningTwoActionCancel” and friends Looked into System Settings “module has changed, save?” prompt not having an icon. KMessageDialog does not set an icon by default, must call setIcon(QIcon()) to get the default warning icon. Feels weird, though. Qt: Fixed a bug where doing model.foo = ... in an Instantiator, which causes the row to be removed from the model (e.g. proxy model), to crash https://codereview.qt-project.org/c/qt/qtdeclarative/+/497726 Fixes KDE Connect (and others, it’s the “resident” flag which triggers this) notifications crashing Plasma 6 Fixed a bug in Qt 6.6 / dev which broke method overload resolution for derived objects, as can be observed by non-reactive SNIs in System Tray in Plasma 6 https://codereview.qt-project.org/c/qt/qtdeclarative/+/497473 Thanks @isma:kde.org for your help! Worked on making Item.grabToImage support high-dpi. Patch itself is simple, but adjusting all the unit tests is tedious. Also probably Qt 6.7 or even 6.8 material given it’s a behavior change. Made a patch for Qt’s built-in KDE style to use "breeze-dark" icon set in dark mode since Qt does not do the colorization KIconLoader does Probably needs a bit of rework to support changing the color scheme at runtime, which Nico claims it does, but doesn’t work here Had a look at fixing blurry fonts with native renderer, found that the glyph coordinates are rounded, leading to blurriness There’s a comment above QSGTextMaskMaterial::popuplate where it mentions this is for macOS, not sure how to proceed https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/quick/scenegraph/qsgdefaultglyphnode_p.cpp#n455 I got a few labels that are consistently blurry but I failed to reproduce it in a minimal example for a bug report yet Other: Breeze style creates icons with explicit device pixel ratio now, fixes (among other things) blurry button icons in qqc2-desktop-style with fractional scaling Joshua * not much plasma stuff, but I plan on working on something interesting today now that gear 23.08 has tagged. somewhat related, you might've seen I've been spamming repositories with new or improved READMEs
Monday meeting notes for 14/8/2023
Nico * I think https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/822 is good to go now * And found a way to make the brightness slider much smooth: https://invent.kde.org/plasma/powerdevil/-/issues/27 * Other than that I've mostly poked frameworks * Cleaning up kbookmarks and kio_http Nate * Worked on making Panel and tray icons always be symbolic when using a theme with symbolic icons. * Created a ShadowedLabel component and ported everything I found in Plasma that could use it, to use it. * Merged work to remove the "globally change (some) icon sizes" project * I'm a bit unhappy about https://invent.kde.org/frameworks/kirigami/-/merge_requests/1190, which has caused breakage throughout Plasma and KDE apps * can we revert it for now to give ourselves time to port stuff away without it being a high-pressure thing? [carl created mrs for p-w and p-d porting away, will do kdeplasma-addons, arjen will do plasma-pa] * I really want to emphasize here the need to to porting work in a transparent way. Ideally people not involved in the work should not even notice that anything has changed. Otherwise it becomes a firedrill and amps up the pressure and we all end up tense and stressed out and annoyed at one another. Usages need to be ported before the thing being ported away from is removed. I've said my peace, so that's the last time I'll bring it up about this. Arjen * I've been doing some work on stuff that we discussed during the kirigami bof at Akademy * the list item MR (https://invent.kde.org/frameworks/kirigami/-/merge_requests/1073) I would say is ready to go now [nate will rereview] * I also have a very broken Kirigami locally that is split up into a bunch of submodules, where I concluded that doing it in one large MR is going to be incredibly unwieldy * so I'm instead going to make smaller MRs to introduce individual submodules and do other cleanups separately Kai Uwe Wrote a blog post about my recent experiences and fixes for Plasmsa 6: https://blog.broulik.de/2023/08/on-the-road-to-plasma-6-contd/ Started getting a bunch of “Called object is not of the correct type (class destructor may have already run)” errors on teardown of plasmashell and Dolphin, not sure how that cropped up. [marco fixed some, still more to come] KWin: Fixed window menu on CSD apps opening offset from the cursor Had a look at having Blur effect take into account Window opacity Fixed a bunch of issues where KWin would send an intermediate scale factor causing blurry window contents for a frame or so Don’t trigger screen edge during implicit pointer grab, please review https://invent.kde.org/plasma/kwin/-/merge_requests/4325 Fixes screne edges triggering when touching the screen edge while e.g. dragging a scroll bar or text selection Looked into porting rest of Plasma::FrameSvg to KSvg::FrameSvg in KWin (screenedge KCM and screenedge effect) Would get rid of the plasma-framework build time dependency \o/ Can’t figure out how to load plasma SVGs from outside Plasma through KSvg IconSet, even if I tell it to look in /usr/share/plasma/desktoptheme… Notifications: Looked into making drag to trigger default action do so only if the mouse has rested on the popup for a bit Dolphin “terminal still running” prompt now plays the message box warning sound Fushan * Request to add isSessionIdle and isSessionActive properties in powerdevil, which will be used to activate/disable the ambient light sensor. Properties are read from login1 and set by some powerdevil actions: https://invent.kde.org/plasma/powerdevil/-/merge_requests/208 * Introduce 3 preliminary tests for the media controller widget, so the widget can be ported away from dataengine safely: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3171 * Fix wrong widget order in new panel, again: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1658 * Looking to merging the last_used MRs to enhance the AppChooser experience Marco * last two weeks was away, so not much * those past 2 days i've been trying to fix a multiscreen autotest in plasmashell, and oh boy it was a rabbit hole * that made me follow a lot of crashes dut=ring teardown of things (including that warning message on dtor alreadty ran) * and now looking into the screen order protocol, looking on what why how slight behavior changes since 5.27
Monday meeting notes for 12/6/2023
Nico * Lots of random KF6 stuff * In terms of Plasma most relevant: Worked on renaming kded5 to kded6 * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2979 * That needs some careful review of existing modules to avoid surprises/incompatibilities * I also worked a bunch on refactoring brightness handling in powerdevil * Mostly separating keyboard and screen brightness handling Alex * I have been working mostly on KF6 related stuff. * Most importantly, the KCM refactoring and move of the org.kde.kcm module. * This is finished now and the last thing to do is clean up some unneded/compat code in https://invent.kde.org/frameworks/kcmutils/-/merge_requests/147. This could use a review. * Folks need to recompile the KCM-consuming projects, but that should not bee too big of an issue * I worked on the KRunner threading refactor of https://invent.kde.org/frameworks/krunner/-/merge_requests/139 and discussed some API things regarding threading with Volker. Will need a few days to finish it. * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2915 is ready now, I only need to revive the KCM counterpart. The plasma-workspace change can already be reviewed. Fushan * The custom drag helper in the notification widget is ready to be removed: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2962 * Fix a minor accent color glitch: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2970 * Make it possible to drag QR image to the desktop, like in KDE4 times: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/392 * Revived some old MRs to improve panel efficiency after I daily drive a 4k monitor, now it consumes less cpu when moving windows around. Xaver * KWin git master should now be pretty robust against GPU resets, at least with the very latest Mesa from git. If it still causes issues for anyone, please annoy me about it * I did lots of experiments and research for HDR and color management stuff. The situation with monitors is very sad - most of them completely ignore all the specifications and predicting their behavior is hard. We likely have to pack some workaround toggles into KScreen to make it work well * I'm close to fixing multi gpu performance with NVidia on Wayland. It's "working" but there's still lots of glitches because of missing synchronization Marco * "only" main highlight, i finally merged most of the huge mrs about the mega refactor started at the sprint * there will still need to be done some smaller refactors but in the future * 2 mrs rmain open: printer manager and kdeconnect: because they are not in workspace therefore can't be merged yet kf6-only stuff * after that i restarted my port to standalone ksvg, opening a bunch of reviews, will undraft them soon Afterwards short discussion on what to do about kdeclarative's DND which some applet still use it. needs more work
Monday meeting notes for 22/5/2023
Meven * Plasma related I have been trying to fix the kcm touchpad Hi bug https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1526 * On the build side, I made a couple patch for kdesrc-build to help building baloo-widgets and dolphin-plugins * there is a patch https://invent.kde.org/sdk/kdesrc-build/-/merge_requests/232 to help with the appstream runtime errors, that I'd encourage to review * Other than that I have been trying to fix an important regression in dolphin, by due to KActivities architecture I think I will have to reintroduce the bug that the regression fixed in the first place * Bug regression was introduced by https://invent.kde.org/system/dolphin/-/merge_requests/529 Nate * I have a few Plasma MRs that could use review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2931 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1524 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2936 * been working on miscellaneous Plasma porting and UI improvement topics Jonathan * I just switched over KDE neon unstable edition to Qt6 builds of frameworks and Plasma Vlad The biggest update from my side is: the panel has been ported to the layer-shell protocol We're not done with the panel yet though. There are two more things that must be addressed: improve the panel configuration ui to play nicer with layer-shell the panel configuration should be ported away from the plasma-shell protocol the second is still unclear Xaver atm I'm mostly working on HDR stuff and color management: I want to make brightness control go through KWin: https://invent.kde.org/plasma/kwin/-/issues/156 I'm researching tonemapping and gamut mapping, so that we can show HDR stuff on SDR screens appropriately I'm thinking about how to handle lookup tables, which can improve performance a lot generating the lookup tables can be quite resource intensive, a 64^3 3D lookup table for example has more than 26 entries. So for that I think we should use a shader to generate a texture that can then be used in other shaders Generating large LUTs for KMS will probably need to use a thread to not cause any stutter, and some careful handling to fall back to a shader until the LUT is ready I'm also looking into fractional scaling bugs but my patches for that are super broken atm, so there's no real news there yet Fushan * 3 for 5.27 that is waiting for someone to pick. * Reload holiday events without restarting plasmashell: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2927 * Fix blurry SVG wallpaper if it's from a KPackage: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2904 * Revert button padding hack to make Firefox CSD window buttons look nice again: https://invent.kde.org/plasma/breeze-gtk/-/merge_requests/83 Marco ok on my part last thing. i have a bit on hold the ksvg stuff atm, concentrated almost only on the big refactor those are the mrs so far: https://invent.kde.org/frameworks/plasma-framework/-/issues/15 There has been discussion on how to do the move of p-f to workspace, not conclusive -- Marco Martin
Monday meeting notes for 17/04/2023
Nico * Sprint: Everything seems to be in order * Clean up KNotifications API: * Drop notification contexts: https://invent.kde.org/frameworks/knotifications/-/merge_requests/98 https://invent.kde.org/frameworks/knotifyconfig/-/merge_requests/21 * Hide internal API: https://invent.kde.org/frameworks/knotifications/-/merge_requests/95 * New actions API: https://invent.kde.org/frameworks/knotifications/-/merge_requests/97 * Opened an issue about some troubles with notification actions and xdg activation: https://invent.kde.org/plasma/plasma-workspace/-/issues/65 * Started splitting out the kglobalaccel runtime as discussed, and adjusted kwin: https://invent.kde.org/plasma/kwin/-/merge_requests/3973 * Needs adding the new repo to the plasma repos * Some adjustments in various repos to support appstream-qt6 * Ported task manager badge shader to Qt6, needs some work still: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1472 pls help * Fix opening folderview folder in Dolphin P6 regression: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1470 * Add setAssociatedWindow to KSNI: https://invent.kde.org/frameworks/knotifications/-/merge_requests/94 * Make wireguard import in plasma-nm much more robust: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/242 * Drop recent contacts from Kicker: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1468 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2813 * Fix filedialog freezing: https://invent.kde.org/frameworks/kio/-/merge_requests/1250 * Worked towards building KAccounts with Qt6 * Some refactoring in powerdevil: https://invent.kde.org/plasma/powerdevil/-/merge_requests/155 https://invent.kde.org/plasma/powerdevil/-/merge_requests/154 Xaver * I made some progress on the Wayland protocol for apps with tabs (https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/203). The current approach should work fine for everything afaict, so I plan to implement it soon * finally got a Wayland change merged that allows us to make ctrl+scroll to work in windows that aren't focused * did some refactoring in KWin that makes dealing with drm properties a bit less annoying * multi gpu performance is now fixed for non-NVidia systems; fixing performance with NVidia as well is next. If you have a multi gpu system with non-NVidia and performance still sucks on master, please make a bug report about it Fushan * Fix an uncommon crash in plasmashell: https://invent.kde.org/frameworks/kio/-/merge_requests/1253 * Fixed a longstandarding bug in flameshot caused by xdg portal * Some minor refactoring in kde-gtk-config and breeze-gtk
Monday meeting notes for 3/4/2023
Nico * We have a date for the Plasma sprint! * May 4th to 11th * In Augsburg, Germany Other: * Restore double click interval setting: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1455 * Drop per-activity power management settings: https://invent.kde.org/plasma/powerdevil/-/merge_requests/150 Fushan * After adwaita-icon-theme was updated to its GNOME 44 version, 32x32 pixmaps were removed, so the icon preview in the icon KCM looks bad: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2789 * Sync double click interval for GTK2/3/4 apps once double click interval setting is restored: https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/76 * Test org.kde.Solid.PowerManagement, which will introduce inelegant Glib/Gio code, not using python-dbusmock because the dbus interfaces can be out of sync with upstream at any time: https://invent.kde.org/plasma/powerdevil/-/merge_requests/151 If merged I can continue to look into testing the battery monitor. DavidE * Big topic for discussion * when are we depending on Qt 6.5? * Imo as soon as possible we have it on CI * but also going too early will lock out some potential users [davidR]Having it on CI means having it on suse tumbleweed Will there be important distros that have 6.4 right now but will not have 6.5? [marco]would go for soon as well [nico]yeah, I'd say as soon as CI has it it's fine to require [d_ed] * ok * and when that happens lets maybe only require it in layer-shell-qt - and see if anyone complains before rolling out to everywhere else that doesn't really need it for new API Vlad * I made a few huge Window refactors in kwin. If you notice a kwin crash that you used not to see, poke me * Got qtwayland popup apis merged \o/ * Created patches to add an interim xdg-shell integration fork in meanwhile * Looked into kde-screen-edge-v1 again, the first design didn't work out well (because of pesky X11 details). Will try to get something else that matches the existing design * Did a few other things, but I don't think it's that important * d_ed can you rebase your axis_physical_direction patch in qtwayland? * https://invent.kde.org/plasma/plasma-pa/-/merge_requests/171 see for more details Xaver * if you're good with threads, pls review https://invent.kde.org/plasma/kwin/-/merge_requests/3828 * https://invent.kde.org/plasma/kwin/-/merge_requests/3859 is almost ready and should fix multi gpu performance. If you have a multi gpu system, please test it * note that it's not expected to help on NVidia just yet, but it would be good to know if it regresses anything there * I created a Wayland protocol for apps like Kate and Firefox to no longer ignore virtual desktops and Activities: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/203 * the app can provide a list of windows, the compositor picks the best one - based on stacking order, focus, virtual desktops, Activities, whatever. It can also indicate to create a new window * if this lacks something we'd need in KDE or to make a usable Qt API for it, complain about it to me and we'll see how to improve the situation Marco * I don't have much to report, only thing directly plasma related i have is that i continued a bit on the standalone plasmasvg library * i have a branch that removes all colors from theme and uses kirigami::theme directly * what i don't like much is that it introduces qml dependency also in the plain library not only on the qml bindings * and this all because QPalette doesn't have positive/neutral/negative colors, otherwise could have gone with qpalette and be happy about
Monday meeting notes for 27/3/2023
Marco
* Directly related to plasma, working mostly in the Svg/Framesvg refactor.
* lives in g...@invent.kde.org:mart/plasmasvg.git but will be called
KSvg (namespace already updated)
* A thing that changes is that what is now Plasma::Theme is just about
"retrieving the proper svg file"
* Colors go away, what i would like is to rely on Kirigami::Theme for
colors so one can do:
KSvg.FrameSvgItem {
Kirigami.Theme.colorSet: Kirigami.Theme.Header
imagePath: "widgets/background"
}
* and even this which gives problems for the cache:
KSvg.FrameSvgItem {
Kirigami.Theme.textColor: "blue"
imagePath: "widgets/background"
}
* with this it means that every color (at the moment 10 colors
supported) needs to be encoded somehow in the cache key, which could
give problems as computing the cache key is not super efficient
already
* I would like to go completely with QPalette on ksvg side (with
kirigami::theme only on the qml bindings side), which means dropping
* it means that i need dropping support for the named colors in the
stylesheet (like buttontextcolor and what not)
[arjen] there are some options here, what we probably need is some
sort of multi-level key so that we don't need to calculate the full
key just to check if an image exists for example, but this requires
some extensive thinking
[marco] ok, i'll start to remove those extra names and try to go
qpalette and see if that is feasible, then when is simpler is easier
to think about making the cache better
[d_ed] to be seen if cachekey is stable between sessions
DavidE
* I nearly have the digital clock ported to the new libclock import,
didn't encounter any big issues
Arjen
* I've mainly been working on rdp support
* today spent a bit of time on kirigami and currently looking at a
related issue in systemsettings/kcmmodule that causes an infinite loop
in delegate creation
* because systemsettings ends up using a qml engine without a proper
async incubation controller
Nico
* Sprint!
* I'm still missing names in the poll
Vlad
* spent a good chunk of the week on Window stuff
* killed Workspace::clientList,unmanagedList,internalWindows
* patch to drop Deleted is on review
* fixed a few wayland related bugs while was working on Deleted stuff
in meanwhile
* did some tabbox cleanups
* create a patch in qtwayland to add popup hooks so plasmashell
doesn't need to carry its own xdg-shell shell integration fork
* dropped KWin.registerWindow() scripting workaround
* any thoughts about dropping javascript scripting in favor of qml? (in kwin)
[d_ed] having two APIs isn't great
[d_ed] IMHO the JS API is kinda the better one for the usages kwin has
[Natalie] I would imagine the hurdle of needing both QML and JS would
be discouraging to many potential KWin script developers (or those who
want to port existing ones), but I don't know how much in addition one
would really need, if it's as simple as that snippet you showed that
we'd put in the KWin scripting tutorial I think that's manageable
Xaver
* I'm looking into reducing cursor latency by having a thread in KWin
that more or less simulates mailbox presentation on top of the drm
API. * There are some problems with proprietary drivers though,
because they don't give us any timing information.
* I've also attempted to make some progress with multi gpu as my new
CPU has an integrated GPU, but it's kind of stalled again because of
driver issues on AMD+AMD systems
- with some additional work it could at least be usable on
Intel+NVidia systems, but the potential for regressions appears to be
relatively large too
- there is the alternative possibility to make the existing CPU
copy path be done in a separate thread, which would alleviate at least
part of the performance problems. Both performance and battery life
would still not be good though so I'd rather avoid that
- another alternative is to start using Vulkan for the specific
purpose of buffer allocations and multi GPU, which completely
sidesteps most of the problems, at the cost of more code and
potentially more edge cases like one GPU supporting Vulkan but not the
other
Joshua
* prepping Tokodon for the next gear release. I can say that this week
I'll finally begin opening MRs for the documentation improvements I've
been sitting on.
* If you haven't seen, I'm improving the doxyqml output so it includes
import statements, and slowly working my way through fixing frameworks
doc comments (p-framework is the first one up) and doing the same for
our custom QQuickItems.
* Also found a really odd syncColors bug (and fixed it?) in
desktop-style, if anyone is more familiar with that please take a
look: https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/244.
I'm also curious why this only affects desktop style, and not breeze
style (AFAIK, they have similar mechanisms for syncing theme colors).
Meeting notes about Plasma::Svg
All the svg stuff in plasma will be split in a new standalone framework, at the moment repo living at: https://invent.kde.org/mart/plasmasvg New framework atm is called PlasmaSvg but is a library that should be ok for apps as well (svgs with caching could be nice on android as well for instance) -> Decided to call it KSvg (a library with that name existed in kde3 times but not relevant anymore) We will continue the standalone library, publish it as a framework then start to move everything plasma to it, after that, we'll kill svg from Plasma No changes in Plasma svg stuff should be made anymore in plasma-framework The framework will have a public library and a QML import Public library: * Svg -> almost unchanged * FrameSvg -> almost unchanged (do we still need the distinction between margins and fixedmargins?) * Theme -> Ideally should die, but we would still need some of it remaining (more on that later) QML import: * SvgItem -> almost unchanged: the svg property should become an imagePath string method instead * FrameSvgItem -> almost unchanged * Units-> used for the devicepixelratio scaling, as we want to kill it, this unit will go. * Theme-> shouldn't be accessible in QML anymore, it was used only for colors, Kirigami::Theme should be used instead (which it should give plasma colors when used in plasma) * ColorScope -> should be removed, all it did is the inherit featue of Kirigami::Theme * Plasma::Dialog uses framesvgItem internally from c++, what to do? have those items publicly exported? Plasma::Theme It does separate things: * path resolution for the svg files (almost like KPackage but slightly different * colors: should be Kirigami::Theme * wallpaper in theme -> kill * fonts from theme-> kill * image and rects cache for the svgs -> should be internal api not an exposed symbol (so we can start requiring timestamps) * stuff that wraps KWindowSystemS: those are used to choose between the opaque, normal or translucent versions based on composite and blur effect, it should become api set by Plasma Summary of dependencies: Can something be further slimmed down? Archiveto read svgz and do stylesheet before giving it to the renderer ConfigWidgets KColorScheme, read colorscheme from theme folder, apply it to stylesheet GuiAddons KImageCache IconThemes KIconEffects (can it be hardcoded at this point? effect is not even exposed in systemsettings anymore) WindowSystem+x11 Loading files from the "translucent" folder when compositing/blur effect is active, will be replaced by api exposed by some singleton called by plasma Kirigami2 If we are going to directly call Theme/Units from C++, as SvgItem/FrameSvgItem do for the plasma counterparts -- Marco Martin
Monday meeting notes for 20/03/2023
Nico * We're planning a Plasma sprint! * Tentative location is Augsburg, Germany * Please see https://mail.kde.org/pipermail/plasma-devel/2023-March/122995.html and enter yourself in the poll * Other than that: * Port kio-extras to KF6: https://invent.kde.org/network/kio-extras/-/merge_requests/232 DavidE * I uploaded my new datetime engine replacement as a MR * I haven't ported digital clock to it yet, which is the real test * One discussion point, I tried to use the magic new macro qt_make_qml_import (or something like that) with the QML_ELEMENT macros and couldn't make it work * It didn't install the generated qmldir file * [nico] ah, it doesn't allow "installing" a qml module * [nico] and is a dealbreaker for us, i'm poking Qt people Redstrate * i fixed activities not switching on plasma 6 * did more doc stuff for p-w which should land soon (it will be targetting mostly kf6) * more p6 applet ports got merged, there's still some left in review in p-desktop if anyone wants to take a look Fushan * I am still looking forward to disabling triangle filter in the task manager in 5.27. Here is the patch: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1391 Luigi Working on renaming translation files for the KF6 branch and I have two questions, probably more-Frameworks than Plasma, but a lot of people here contribute to those repositories: - the translation template of kirigami in KF5 is called libkirigami2plugin_qt.pot, how should it be called in KF6? libkirigami2plugin6_qt? - same for kirigami-addons (which is not a framework yet but it seems it's going to need co-installability): from kirigami-addons.pot to kirigami-addons6.pot? - Marco: I would go for libkirigami6_qt.pot Marco * there is now a wip standalone plasma::svg library * on wednesday i want to do a short video meeting about it on 15pm cet
Monday meeting notes for 13/2/2023
Fushan * KDE Connect will no longer hijack the notification interface used in libnotification thanks to gdbus's filter function that does not exist in qdbus. * This can be merged in 5.27.3 to remedy the klipper bug existing in 5.27 beta and 5.27.0: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2730 * What do you think of remembering the last used app in appchooser? https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/179 [discussion: can be made per-mimetype? might be difficult] * I wonder if the portal can use something from KIO * promptUserForApplication(KJob *job, const QList , const QString ) override Oh Yes there is mimeType! * will make changes soon Xaver * I'm currently working on some output management stuff, to move output setting management into KWin on Wayland. https://invent.kde.org/plasma/kscreen/-/merge_requests/192 is in preparation for that, pls review or complain if you need that setting for some reason * ping on https://invent.kde.org/plasma/kscreen/-/merge_requests/187 too Jonathan * 5.27.3 is due out tomorrow Nico * Ported a few apps/libs to KF6 * Fixed up some Plasma stuff wrt Kirigami and P5support API changes * Fixed an internal application name leaking into the window title in a couple of places, e.g. the portal-based dialogs no longer get "- Portal" appended to the title * Fixed network KCM for Qt6: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/232 * Prepared to backport some VPN fixes to 5.27, needs string freeze exception Marco * Removed dataengines from plasma-framework * ported everything using dataengines to plasma5support * started to do the same for plasma-svg * https://invent.kde.org/mart/plasmasvg is a repo which has only the svg related stuff of plasma including history Marco Martin / plasmasvg · GitLab - GitLab KDE Invent (Gitlab) * goal is to make it a normal framework, perhaps needs a new name, dunno and for sure some api refactors (hate the theme class which is also a kpackage clone, half a kirigami.Theme clone but is kinda needed)
Re: Plasma repositories sprint cleaning
Answering only on the few ones i know anything about :p On Fri, Mar 3, 2023 at 1:45 PM Nicolas Fella wrote: > - khotkeys: consensus seems to be to abandon it, because maintaining two > global shortcut systems is no joy: https://phabricator.kde.org/T2050. > It's still released with 5.27 though How do we go for epos that are part of 5.27 but won't be on 6? anyways yeah, let's yank it from 6. repo should still be there for 5.27 maintenance mode tho > - ksysguard: We stopped releasing/maintaining it several releases ago. > Not part of any supported release. Could be archived? +1 > - kwrited: The functionality is kind of old/niche. Is it worth having at > all? If yes, given it is quite tiny, would it make sense to fold it into > plasma-desktop instead of having it separate? +1 for p-d > - kwayland-server: Obsolete implementation detail. Not released any > more. Can probably be archived now > > - lancelot: An alternative Plasma launcher. No releases, not much > activity in recent years. If anyone cares about it it might be better of > maintained outside of KDE to avoid impression that it is "officially" > supported > > - plasma-active-window-control: No release, a little activity in recent > times. What do we do with it? would go for archive > - plasma-redshift-control: No releases. Does this provide anything > interesting compared to the "official" night color stuff? archive... i think is x11 only by the way > - plasma-simplemenu: Had releases in the past, but last one is from 4 > years ago. Semi-active recently. Might be worth incorporating into > proper Plasma release? if is semi active if current contributors plan to maintain it, folding into p-d could make sense > - plasma-tests: Is this useful at all? Afaik that was an old attempt on a plasmoid test suite for ci which didn't go anywhere... I would say obsoleted by the appium stuff, so archive -- Marco Martin
Monday meeting notes for 6/3/2023
Important: wed, 15th 3pm cet there will be a short meeting about porting plasma to layershell David E * I have started a replacement for the datetime dataengine with simple QML bindings - it's going to be amazing * digital clock gained a lot of hacks that I'm trying to avoid this time * I should have that ready in a few days * has same features as timezones and alignment between instances * a topic I want to dicsuss in teh meeting is this plasma_use_qt_scaling env var [Nico] The big problem was that it breaks mixed-dpi setups quite badly [d_ed] yeah, the noteworthy things are: we need to have a consistent story in KWindowSystem [notmart] should we get rid of the env var now to "force" more fixings there? [ahiemstra/nate]: to me that makes sense break things early so people run into the issues and they get fixed [nico] Do we have an idea of what exactly needs fixing in kwindowsystem? [d_ed] Not explicit, right now the state is we have a few paths that happen to be used sometimes converting and some paths that might not be used not converting things I'm hoping in terms of public api we can end up at : KwindowSystem - > logical KX11STuff -> device [nico] There isn't much public API left in KWindowSystem anyway, Most moved to KX11Extras [d_ed] ok, I'll see if we can take a look and make some more concrete tasks * One more superfast topic plasma-workspace: * I was thinking of introducing a toplevel folder called "libs" Nico * We haz Qt6 in Plasma now \o/ * Things don't seem too bad, I've been running it all week * Some related thoughts: * There's a couple of Plasma-ish repos not ported yet, e.g. various bigscreen stuff * Related to that I sent an email about portentially cleaning up some repos under plasma/: https://mail.kde.org/pipermail/plasma-devel/2023-March/122977.html * We now have a 'qt6' keyword in bugzilla to tag Qt6-related stuff I filled that with a couple of crashes already: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=qt6%2C%20_type=allwords_id=2296434_format=advanced * Should we be more systematic about writing down known issues? [nate] we'll need to be systematic eventually so IMO we might as well start sooner rather than later [nico] I was mostly talking about https://phabricator.kde.org/project/view/316/ specifically [d_ed] It might be easier to start with a clean slate and look what here is actually relevant Aleix Bugfixing some things creeping up from Plasma 5.27 memfd screencasting will always work for the first time. A number of things were fixed as some users pointed out which legacy clients (slack!) to test with. There were some regressions on libkscreendpms on some corner cases. Discover port to Qt/Plasma 6. It's kind of there, needs some dependencies to catch up. Worked with Arjen on KPipeWire API that sends ffmpeg-encoded frames to be used on his new krdp test app. Arjen * I've mainly been working on rdp remote desktop stuff * now looking into some optimisation stuff so there isn't as much lag as well as making sure things like resolution are actually properly done (rather than hardcoded which is the current state) Marco * removed and ported away from the deprecated "AppletScript" api in libplasma, merged patches about that * new repo plasma5support in workspace to split out all the deprecated dataengine stuff * ported usages in p-w, p-d and kdeplasma-addons. some more usages may still lingers in applets in other repos https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2723 https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/356 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1423 * preliminar port of plasma-sdk to kf6, plasmoidsviewer works, still to fix qml of otehr apps here and there https://invent.kde.org/plasma/plasma-sdk/-/merge_requests/64 * I still have some potentially breaking changes in the pipeline that i hope to get them as soon as possible namely: * changing who the "plasmoid" object is as seen from qml * split svg in own framework (whether before or after removing the own scaliong, not sure) [fusionfuture] If it's time to remove PLASMA_USE_QT_SCALING and fractional scaling on Wayland is a thing, perhaps https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/637 can be considered again [notmart] probably to try again after one of the two scalings is gone to make things less headache Vlad * I'd like to have a discussion about porting plasma to layer shell. Either some time this week or later Currently not high prio because of qt6 porting [d_ed] Lets do so in a week, we can start introducing some classes which have the right plasma-facing API decision: wed, 15th 3pm cet Xaver * I'm working on killing the kded part of kscreen. The plan is to have it be X11-exclusive, and have KWin manage the output configs on Wayland going forward https://invent.kde.org/plasma/kwin/-/issues/116#note_632691 -- Marco Martin
Monday meeting notes for 27/02/2023
Nico * Looked into why the portal-based Open With dialog is not properly parented to the main app window. Found that exporting the window id on Wayland is broken: https://invent.kde.org/plasma/plasma-integration/-/merge_requests/72 * Still not working as I expect it though, so something else may be broken * Improved the UX around adding VPN connection: * Show import errors in UI: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/224 * Allow importing VPN files by opening them: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/225 * Add openvpn mimetype to shared-mime-info * More ideas for UX improvements: https://invent.kde.org/plasma/plasma-nm/-/issues/3 * On that topic, can we move forward with https://invent.kde.org/plasma/plasma-nm/-/merge_requests/124 ? * Add parent windows to file dialogs in Neochat: https://invent.kde.org/network/neochat/-/merge_requests/814 * removed a build system footgun in kidletime by making optional dependencies opt-out: https://invent.kde.org/frameworks/kidletime/-/merge_requests/39 * We've had several distros build kidletime without Wayland support, breaking things * Big refactoring/cleanup in KService, removing the obsolete implementation of KServiceType: https://invent.kde.org/frameworks/kservice/-/merge_requests/134 * Port KDeclarative color button to QQC2: https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/189 * Started work on removing KActionCollection from the public plasma-framework API: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/735 * Several minor Plasma Qt6 build fixes * On the topic of Qt6: Tomorrow's the day, right? * Where we switch Plasma * https://invent.kde.org/sysadmin/repo-metadata/-/merge_requests/139 would switch kdesrc-build to build Plasma/5.27 by default for branch-group kf5-qt5 * We still need Breeze and plasma-integration for Qt5 [discussion] just a cmake flag? in 4 to 5 times it was pretty annoying. and how would them relate with the 5.27 versions? Keeping 6.x compatible with Qt5 should be reasonable doable Jonarhan * I did 5.27.1 * and 5.27.2 is due tomorrow * in neon I did kf6 packages which are now complete * and we have a plan for plasma 6 which is the same as we do for qt releases, freeze the public archive (this is unstable edition) and * build it hidden away until it sane to use * where sane to use is still "unstable" and for devs and testers * does that make sense? Fushan * Fix illegal config filename: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2673 * Can Plasma consider setting GTK_THEME in startplasma so libadwaita apps can also be themed? I proposed one: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2669 * Another thing about GTK theme: I investigated Breeze GTK a little last weekend and found if a theme uses mm instead of px as the size unit, GTK3 apps can correctly react to fractional scaling. GTK4 looks buggy for unknown reason. [discussion] d_ed: I would rather we try to make use of services and ordering than polluting startplasma fusionfuture: libadwaita is immune to local gtk theme settings. It's just a proposal since I have set the env var in /etc/environment to force libadwaita look consistent mart: you would prefer a tiny executable started by a service which would have the same code of the patch? d_ed :yeah, but also not hardcoded but using kcminit / kded we have mechanisms to get those run before any other apps Vlad * I did some bugfixing and refactorings.. * Did some preparation work for kwin Marco * Made and backported a patch that lets the user delete unused desktops for the containment screen reorder ui * most of the week used at starting a weird qtwayland issue that makes panels open popups in the wrong screen in certain cases * identified and made a qt patch with the help oif multiple davids * https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/723 still awaiting review (i shall rebase it now) Discussion on tomorrow port to kf6 start consensus is to have a minimal session starting asap nico trying to merge necessary mrs to achieve that
Monday meeting notes for 20/02/2023
David E * big topic to discuss * next Tuesday * the KF6 branching * not branching * migration * we've ended up with a scattered collection of MRs on plasma * most of it is auto-generated * which is good * but there's commits in there which aren't * Is it worth reopening them all with a consistent branch name? * then it'd at least be easier to try and build them all before Tuesday * I can send message to distro list just to say "from next tuesday we'll do this, be careful" Nico * I'd appreciate if we could go over the KF6 workboard and give some triage to the Plasma-related things * Sorting out things like "this is done", "this is important", "this is optional" * To get a better picture what needs doing Fhushan Testing https://invent.kde.org/plasma/kde-gtk-config/-/merge_requests/56 and it can be merged in 5.27.1 IMO. Steam seems to depend on GDK_SCALE and GDK_DPI_SCALE to properly scale itself on Wayland. Is it worth setting the two values on Wayland again? A controversial topic, left a MR there to calm down angry users: https://invent.kde.org/plasma/breeze/-/merge_requests/288 On that topic, I got two GTK related bug reports downstream One is that supposedly scaling doesn't quite work and FF and TB are ~10% too big (?) Another is that breeze-dark isn't applied to gtk2 anymore Didn't have time to look at them yet Marco * please review https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/723
Monday meeting notes for 13/02/2023
Johnathan * 5.27 is out tomorrow * speak now or forever haud yer wheesht Nico * have, again, mostly done frameworks stuff, some of which leaked into Plasma * I'm working towards removing KWindowSystem::raiseWindow, because it's redundant with QWindow::raise, and as far as I can tell also not needed at all in most cases * I'm also cleaning up and reworking KService * And looked again at some KGlobalAccel stuff I started a while ago * With KGlobalAccel there's a bigger thing that needs to happen IMO, that is moving the runtime part from Frameworks to Plasma * But I will send a dedicated email about this Fhushan * Two appium tests that may help porting to Qt6 less vulnerable to regressions, please review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2599 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2591 Kai Uwe plasma-browser-integration: Fixed "Share..." context menu not working as Purpose ShareUrl requires a title, please also approve 5.24 LTS MR: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/92 Fixed bug where it failed to query the title of the current page being shared Notifications: Fix Snap app identification not working well, please review https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2577 I’d love to have this in 5.27, even if it also runtime-depends on KService knowing that field. Shouldn’t have negative impact if it’s not there, I suppose. Arjen * continued work on an rdp server implementation Marco * breaking my head on https://bugs.kde.org/show_bug.cgi?id=465536 * two plasma6 patches in p-f i would like to push soonish * https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/719 * first part of the major api refactor -> https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/723 * I want to make official my standalone dataengine library (before removing the old one from p-f or doing any porting) i guess usual kdereview process?
Splitting Plasma-frameworks
Hi all, I've resurrected a project i started a long time ago. Since Plasma Dataengines are now deprecated, but being able to port away everything for Plasma 6.0 is not a given, I've started a split as a standalone dataengines library called Plasma5Support, so far in my personal area https://invent.kde.org/mart/plasma5support Even in the unlikely event if we can port all the things in time and end up not releasing this, It will allow to having what we don't want removed from libplasma to not have big unwanted thing there for the 6 lifetime. as soon as workspace goes kf6, i would then port plsmoids to use that, and then remove dataengines from p-f I would like after ironing out the obvious big rough edges to make it a module in workspace (after workspace is kf6 of course) Opinions? comments? -- Marco Martin
Monday meeting notes for 6/2/2023
Jonathan * I'm making tars for 5.27 on thursday * so get your fixes in before then * release the following tuesday [discussion] Do we know of any blocker bugs? svuorela: there are regressions with kscreen and lxqt/ukui/kylin, lxqt fixed upstream already Kai Uwe Notifications: Fix Snap app identification not working well, please review https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2577 Baloo: Show "Details" only if there are interesting details, please review https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2577 PowerDevil: RFC: Enable "Fully Charged" notification by default, https://invent.kde.org/plasma/powerdevil/-/merge_requests/132 plasma-browser-integration: Will probably do a maintenance release this week, just to get the latest minor fixes out there Haven't had the time or motivation to continue on the wildcard media controls stuff or the blacklist UI... Fixed media controls not working on some websites e.g. when the website has finished loading before p-b-i gets a chance to install its listeners Nico * Mostly KF6 things, lot's of minor TODOs * I did a bit of plasma-framework cleanup, like removing deprecated components * The examples/ folder could use some cleanup, it's still mostly based on PC2 * I started porting to PC3, but there's more to do * Also dropped some Plasma4 era examples Other stuff: * Made Dashboard skip the task switcher: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2583 * Refactor jumplist handling in kicker: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2525 * Started cleaning up/refactoring KWindowSystem * That needs some thinking because a lot of the functions on Wayland only makes sense for plasmashell surfaces, not any window * So the API promises something it can't do Arjen * I did a fix for a bug in system settings the other day, https://invent.kde.org/plasma/systemsettings/-/merge_requests/193 * where in some cases the menu will re-trigger if you've clicked on the "show changed settings" menu entry * but apparently the original change was intentional? * other than that, there was a bug in Kirigami's ActionToolBar where it didn't handle TextBelowIcon display mode properly, notmart did an initial patch to introduce a new heightMode which I didn't really like, so I wrote an alternative that was a bit more complex but fixes the issue without having to choose a different mode https://invent.kde.org/frameworks/kirigami/-/merge_requests/956 * ultimately it turns out QQuickItem::heightValid() is rather useless if your item is ever used as part of a Control Fabian * I just came up with a topic an hour before the meeting while looking at a bug * Some users complained that ~/Documents etc. were missing until they ran xdg-user-dirs-update manually * Turns out this is normally done by an xdg autostart .desktop file * That went victim of https://github.com/systemd/systemd/issues/18791 * So it's quite a few applications and other stuff affected by this * What's the best way to address this? I don't think systemd will move anytime soon * Turning off systemdBoot is probably not a good idea either? [d_ed] * some distros provide systemd services for xdg-data-dirs * I thought we landed that in upstream xdg somewhere * but I doubt there was a release * https://gitlab.freedesktop.org/xdg/xdg-user-dirs/-/merge_requests/10 * It's not as trivial as checking "are we on gnome, if not ignore this flag" * because we have desktops like cinnamon that do honour that flag but aren't gnome [fabian] Then it could be ignored on KDE [d_ed] I suppose :) [fvogt] will try both Fushan * XWindowTasksModel is thoroughly tested now. WaylandTasksModel seems to be unstestable in CI for unknown reasons (windows not listed). * Was investigating how to port K4TimeZoneWidget, and found TImeZoneModel in digital-clock can almost replace it, so * I added flag support in the model. Besides those, I mainly fixed some bugs about system tray: * Open context menu on pressed for SNI. The mousegrabber bug was "fixed" in 5.24 but the old fix is not ideal. * Fix another xembed tray icon not clickable bug by making sure the container window is under mouse upon click: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2581 I don't understand why root_x and root_y were included. The root pos seems to often vary much from the actual click pos on Wayland. * Long press on plasmoid icon to open context menu for touchscreen users * XEmbed tray icon test plan: atspi webdriver can be used to compare the icon title, and test the icon can respond to click events. I plan to use Gtk.StatusIcon which seems to be the easiest way to create an XEmbed tray icon. Since an atspi test is done in python, I wonder if it's possible to use pygobject in CI. Meven * I merged my componentchooser KCM refactor for Plasma 6 though https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1207 * KF6 related, I merged my
Monday meeting notes for 30/01/2023
#DavidE * It's worth discussing the state of KF6 * there's been some recent issues on other parts of KDE with people porting early * so to make sure we're all on the same page, it's worth following anything on frameworks-devel before going loco with devleopment [Discussion] Nico: There's two things to keep in mind here: 1. KF6 is going to be somewhat unstable/breaking for the forseeable future 2. if a project makes the jump to KF6 (even if 5 compat is kept) that means that all deps need to make the jump, and all other projects that consume the project need to make the jump too David: * So right now we should avoid anything in plasma. Current plan seems to be that we hold off on a while before pushing. * and just to clarify, the CI on plasma right now for Qt6 is Qt6 builds of kf5 which is a bit confusing! but overall makes sense *And on a related note, is it worth now putting into plasma code #ifdef KF5 #include #else #include #endif Marco: I'm still not clear if the bigger changes can be started on p-f or not then Nico: * We can do them without breaking CI * But Plasma won't be able to use them yet Nico So consensus seems to be to wait a bit before making the jump? we should be polishing 5.27 anyway :D David: we have said in the past we do it on the day of 5.27.2 #DavidR * I am busy investigating annoying bugs with klipper and plasma-nm with one liner fixes that do not reflect the investigation time :D #Aleix * spectacle: juggling encoders and players to make sure we offer something interesting * settling with vp8 which works about as well as x264 (maybe not entirely but quite) and it's free of patents and other bullshits * discover: fixed the ci run for flatpaktest and worked on some bugfixing around flatpak support too * sddm: did a push on a longstanding issue from fedora that is almost fixed (in a PR, feel free to give it a go) * otherwise spent quite some time in SDDM issues and PRs to see what can be included in view of a release and what should be postponed #Nico * I've mostly done KF6 things * Nothing worth mentioning in particular #Arjen * Mmh, might be worth mentioning we're working on an rdp implementation for remote desktop * Trying to build on top of freedrp, which so far is proving pretty tricky * There's a repo at https://invent.kde.org/ahiemstra/krdp * Which is currently mostly me trying to wrap my head around things #Fushan * Was investigating AppImage desktop integration behavior. Do you think it makes sense to make changes in Plasma to make AppImage integrate better (as libtaskmanager already did for snapd)? * AppImageKit patch, blind fix, still fighting against building it but it builds on OBS: https://github.com/AppImage/AppImageKit/pull/1232 * Libtaskmanager patch: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2558 * Kwin patch: https://invent.kde.org/plasma/kwin/-/merge_requests/3519 [Discussion] Nico: I really don't like us bending over to make appimages work Also I don't like the code duplication between kwin and libtaskmanager The problem boils down to appimages not having .desktop files in the standard location Which is kind of a fundamental issue with appimage's deployment model I understand https://github.com/TheAssassin/AppImageLauncher kind of fixes that #Marco Tests * adapting tests to qt patch which exports the pushed actions on checkable toolbuttons * revisiting some gui-testing related merge requests that weere stuck since a while BugFixes * better migration code and consistency check for multiscreen mapping in plasma containments * merged notification applets fixes * fixed layout problems of desktop widgets when the resolution changes and fixed the "widget migrate upwards some pixels" on plasma restart KF6 stuff * kirigami fixes to make kirigami gallery mostly load and work in kf6 * added most properties of AppletInterface back into Applet (stiull some more difficult ones missing,all the ones i did didn't require any api change at all) in preparation of ScriptEngine killing attempt
Monday meeting notes for 23/1/2023
Beta review day is in three days! Nico * As you probably noticed KF6 is happening * We're currently working through the post-branching checklist * Things are a bit in flux right now, so I don't recommend trying to "use" it yet * From a Plasma POV there's a couple of questions: */When do we start requiring KF6 in Plasma? * IIRC the idea was to do that after 5.27.2 on Tue 2023-02-28 [people generally agree there] * My third question would be about kwayland * Consensus seems to be to drop it, but there's a few usages left answer by d_ed: right, but the target for that is when we release frameworks 6 it can stay in frameworks in frameworks6 for now building on CI and everything, maybe dropping the server side quickly discussion on when to switch, recap: "It's worth us getting master of frameworks into a state where plasma runs before toggling things over. Right now you'll get QML errors on kirigami and nothing will load" Fhushan * Make wine application in system tray clickable, now the wayland bug is also fixed: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2503 * Thoroughly test xwindowtasksmodel: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2514 * I also tried to test waylandtasksmodel, but the model can't initialize itself because it didn't receive KWayland::Client::Registry::plasmaWindowManagementAnnounced when running in nested kwin_wayland. Maybe leave the test for the taskmanager widget * Fixed a regression in latte dock caused by "porting away from custom drag handler", and 3rd-part task manager widgets can work like before. * https://invent.kde.org/plasma/plasma-workspace/-/blob/master/shell/kconf_update/plasmashell-5.27-use-panel-thickness-in-default-group.upd this update script does not seem to work in beta, which causes https://bugs.kde.org/show_bug.cgi?id=464628 Does anyone know why? Arjen * I mainly did some plasma systemmonitor related thigns * not much more to report than that Aleix * spectacle: Landed video support, noah's looking into polishing the UI, I'm looking into improving the generated videos. * Otherwise I've mostly been trying to get bugs sorted out for 5.27.0 on XDP and well, plasma in general. Kai Uwe KScreenLocker: Only inhibit screen locker on "ChangeScreenSettings", please review, it’s a behavior change, missed 5.x then I guess: https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/121 plasma-pa: Had a look at battery reporting for Bluetooth headset: Turns out PulseAudio already tells Bluez, but Bluez only forwards it to upower (and subsequently Battery Monitor and PowerDevil) when daemon is run with -E (experimental) flag Still I can at least provide that info through plasma-pa, please review https://invent.kde.org/plasma/plasma-pa/-/merge_requests/154 Might want to add this info to the popup, too, but ideally without duplicating it for headphones and the accompanying microphone Marco # Tests * done a test for logout greeter * backported a Qt fix into our patch collection to be able to do dolphin toolbar testing * fix in KUrlnavigator to enable dolphin adressbar testing * started a gui test for dolphin: it looks like some patches in Qt accessibility will be needed # Bugfixes * investigated and fixed a mouse input misbehavior in discover reviews page (hoverhandler in labels does interesting effects) * investigated a layout problem in the notifications plasmoid (transitions in listviews are... meh)
Monday meeting notes for 16/1/2023
Kai Uwe KScreenLocker: Only inhibit screen locker on "ChangeScreenSettings", please review, it’s a behavior change and all: https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/121 Dolphin: Install middle-click event filter on KXmlGui window, it’s a hack: https://invent.kde.org/system/dolphin/-/merge_requests/490 KWin: Fixed rendering getting stuck in x11 windowed backend Fixed mouse cursor not woroking on x11 windowed backend with GLES Nico * I've built KDE against the latest Qt6 dev * Which uncovered quite a few broken things such as https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/141/diffs https://invent.kde.org/pim/kalendar/-/merge_requests/296 * Some of it I addressed in our code * Some of it I reported to Qt * Looked more into the curse-that-keeps-giving that is window activation on X11 * Made a Qt patch to allow setting the xdg-activation token on a QWindow: https://codereview.qt-project.org/c/qt/qtbase/+/454085 * Plasma now sends startup ids when invoking notification actions on X11: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2498 * Looked into an (alleged) behavior change when activating windows on a different desktop, but I can't reproduce what people say https://bugs.kde.org/show_bug.cgi?id=464283 * KDE bug 464283 in kwin (general) "Virtual window behaviour has changed and excludes the original behaviour" [normal,] https://bugs.kde.org/show_bug.cgi?id=464283 * Some other, minor Plasma things * I would like some input on https://invent.kde.org/plasma/kwin/-/merge_requests/3365#note_598432 Fhushan * Export plasmawindowed to allow writing plasmoid tests using pure C++. The GUI testing method I believe is much more powerful and efficient than appium: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2506 but requires more efforts to write tests (also this is similar to how Qt wrote there tests) * Require all translatable strings specify translation domains in wallpaper plugins: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/323 * Fix xembed icon not reacting to click events when using Qt scaling: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2503 * Improve Islamic calendar in Plasma 6: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/317 * Fix Bug of the Month (2023.1) by adding a delete button in lookandfeel KCM: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2499 Arjen * I mostly spent time last week updating and merging some stale MRs * one in plasma-framework that was a bit of a pain: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/677 * mostly because the autotest started failing and the test didn't/doesn't make a whole lot of sense to me * not much else to report Aleix * Mostly worked on the MR that adds video recordings to spectacle: https://invent.kde.org/graphics/spectacle/-/merge_requests/176 and other related topics, mostly on KPipeWire. It all seems to be in its way to be adopted, there still are some quirks here and there. * I've been also polishing XDPK to make sure it works as expected on a couple of fronts. Like making sure RemoteDesktop can be used comfortably with apps or our users don't get flooded with notifications at times. Marco * Looked at merge requests made by community during the holidays KWin * more work on tiling refiniements https://invent.kde.org/plasma/kwin/-/merge_requests/3310 , should be ready to go Multiscreen * looking at multiscreen issues of folderview, came up with some config migration infrastructure to adapt the diffrent multiuscreen in 5.27 Testing * started to look at the testing framework made by Harald and did a test for the digital clock calendar ui * investigated/first draft for the logout greeter
Monday meeting notes for 9/1/2023
Nico Gnome is hosting a sprint around graphics stuff (in particular HDR) https://wiki.gnome.org/Hackfests/ShellDisplayNext2023 Might be interesting for some of us to attend (Probably Xaver will go) Since it will involve stuff in the lower/shared levels * Some a11y-related work in kwin_wayland: * https://invent.kde.org/plasma/kwin/-/merge_requests/3362 * https://invent.kde.org/plasma/kwin/-/merge_requests/3365 * And a big-ish refactor in plasma-nm: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/193 * Besides that I've been working on cleaning up our X11 startup id handling across all of KDE * A lot of it was quite broken * And I worked on making third-party kwin addons translatable * That's it from me Kai Uwe Happy new year :) Did some bloggy things: https://blog.broulik.de/2022/12/looking-back-at-2022/ Also finally merged the AFC KIO worker for accessing iOS devices. Please give it a try if you have such a device: https://blog.broulik.de/2022/11/introducing-kio-afc/ (it's in kio-extras, git master should give it to you already) KWin: Been investigating various issues in the x11 windowed backend glGetTexImage isn’t in GLES, which makes GLTexture::toImage abort KWin. Ported it to use a framebuffer and use glReadPixels (will upload MR shortly) It randomly got stuck not continuing to render with no present complete event. Turns out it doesn’t schedule a frame if damage is fully empty, unlike all other backends, causing rendering to get stuck as the frame never “finishes”. (will upload MR to drop the damage region check) Other Wayland: Fixed KFilePlacesView context menu appearing as toplevel when Dolphin doens’t have focus, please review: https://invent.kde.org/frameworks/kio/-/merge_requests/1091 (should go into kf5, too) Notifications: Workaround for PlasmoidHeading being a Control, which eats mouse. Do we have a Qt bug report for that? https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2456 PowerDevil: Turn off keyboard backlight when closing the lid, not needed on my machine and apparently not working with this patch either, please check it out: https://invent.kde.org/plasma/powerdevil/-/merge_requests/122 KRunner: Add context menu (file menu) to results, so you can e.g. “Open With” a file that you found, please review: https://invent.kde.org/plasma/milou/-/merge_requests/51 Would be nice to have this as a shared component with Notifications applet, but p-w already depends on Milou, so we can’t depend on p-w, so we can’t put it in workspace components. Improved Service vs Shell runner duplicates, environment variables are filtered out now, and so are special cmdline args (e.g. -qwindowtitle), makes "vlc", and "kpat", among other things, find the proper apps instead of executables now. plasma-browser-integration: Some more Manifest v3 related fixes and tweaks Turns out xesam "artist" is a string list Fixed album art not showing up on Soundcloud. It’s a bug on their end but our code for handling this situation was broken, too :-) Fushan * About https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2133 I have no idea how to reduce duplicate code without a boolean if the two keyboard shortcuts (Move keyboard focus between panels && Activate a panel widget) will use the same logic to focus on a panel and return focus to window. Is the change good enough to be merged? * This MR is begging for more acks: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2463 Marco * we (some Bluesystems people) are starting to look into using accessibility stuff for gui testing (as Harald blogged a while ago about iirc as he di the infra) * so on the next weeks there will be mrs that do that all over the place, should give us better test coverage also of gui stuff and accessibility support getting better as a bonus
Re: Soft Feature Freeze Approaching
I have a minor refactor pending in kwin https://invent.kde.org/plasma/kwin/-/merge_requests/3310 given how fiddly it has been to keep the tests for working, i was meditating that perhaps is not worth the effort and may be abandoned altogether, what do you think? On Tue, Jan 3, 2023 at 5:37 PM David Edmundson wrote: > > Soft freeze takes effect on Thursday the 5th January After that we > are to avoid any big changes and huge refactors until Plasma 6. > > All new repos should be announced and through kde-review by this point. > > Small features can land until the full final hard freeze on the 19th January. > CC this thread if anything is slightly controversial or exceptions are needed. > > If there are any major things stuck in review, please respond to this > email and make a fuss so they can be prioritised. > > David Edmundson > > https://community.kde.org/Schedules/Plasma_5 -- Marco Martin
Monday meeting notes for 5/12/2022
Very short meeting due to matrix problems: Fushan Week of efficiency: * Move panel overlapping code from QML to C++ which accelerates the computation 100x~200x approximately tools.js in task manager becomes a library * Move ToolTipArea to root item in task manager to replace MouseArea * Process QQuickWheelEvent in the backend to get wheelEventString * Remove duplicate thickness config entries in plasmashellrc * Searching in Kickoff/Krunner no longer hangs plasmashell/krunner for the first time when Marble runner is enabled * Destroy many QQmlComponents early so no need to wait garbage collector to delete them * Make ImageColors generate palettes faster by positioning colors in parallel Nico * Mostly cleaning up deprecated stuff
Monday meeting notes for 21/11/2022
Nico * Refactor VPN plugin extension handling: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/180 * Fix crash in KDE Connect clipboard sync: https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/507 * Worked on filter refactoring in KFileWidget, not ready for review yet * https://invent.kde.org/plasma/kwin/-/merge_requests/3032 * https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1227 * https://invent.kde.org/frameworks/kwindowsystem/-/merge_requests/72 * https://invent.kde.org/frameworks/kio/-/merge_requests/769 * https://invent.kde.org/frameworks/kio/-/merge_requests/1041 Carl * Not much from my side too, just many merge requests for kirigami addons (thanks for devin for the review) Arjen * i've been busy looking at the performance of KWin, starting with a noticable delay on activation of the windowview effect * so far this has mostly resulted in me trying to improve the creation performance of PC3 which is... not that great * (as comparison: Button using default style takes ~0.175 ms to create, qqc2-desktop-style takes ~0.4ms, PC3 ~2ms) * unfortunately most of that is eaten by FrameSvgItem which is hard to make more performant * the main MR is here: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/645 * other than that, I was wondering if we're still planning on deprecating dataengines for the qt6 version of plasma? * and if so, do we have a list of data engines with their replacements? [seems a list is still not there] Apol SDDM Went through some problems as reported Went through current PRs and issues, will be doing some more testing too in preparation for a release. Wayland Addressed some small problems in screencasting and pipewire stream recording Put some more work on Drawing tablets usability with multimonitors 勞 xdp: Been looking into how to authenticate RemoteDesktop apps natively. These apps can't properly use the modal dialog as when you are remote you can't accept it. Discover Adopted a new optimisation in PackageKit into PackageKit Qt, should make it startup much faster on some distros when there's a lot of updates (apt, dnf so far). Usability work in preparation of 5.27 Reviewed MRs for the two new backends for immutable OSs: SteamOS and RPM OSTree Fushan * Optimize the battery remaining time a bit by using exponential moving average filter: https://invent.kde.org/plasma/powerdevil/-/merge_requests/118 * Made PotD wallpaper plugin future-proof by porting away from NetworkManagerQt and using QNetworkInformation Marco # Multiscreen refactor * more testing of the kscreen backend * worked on the x11 part of the screen protocol on plasmashell * more autotests # Tiling * worked a lot on adressing review comments * added in the layout editor a quick ui to switch between 3 presets * 3 columns layout by default to adress out of the box ultrawide monitors * fixes in keyboard navigation
Monday meeting notes for 14/11/2022
Kai Uwe well, I dont envy everyone who has to deal with that dependency and packaging stuff, so dont say "just" ;) Plasma: Fixed issue causing audio indicator space stay occupied if it was hidden Plasma-nm: Worked on adding a QR code scanner for connecting to a WiFi network, https://invent.kde.org/plasma/plasma-nm/-/merge_requests/178 WIP: needs the actual logic from qrca lifted into a library of sorts Notifications: No longer shows "ago" text for paused jobs KRunner: Add tooltip for main text, too, please look again: https://invent.kde.org/plasma/milou/-/merge_requests/48 Solid: Fixed a few bugs regarding the iOS backend, in preparation for: KIO: Finished up the AFC KIO for accessing iOS devices. If you have one, please give it a try: https://invent.kde.org/network/kio-extras/-/merge_requests/7 Nico * Set correct version for kglobalacceld: https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/78 * Fix button assignment in X11 wacom KCM: https://invent.kde.org/system/wacomtablet/-/merge_requests/19 * Deprecate KDeclarative IconItem: https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/157 * Deprecate some unused stuff in PreviewJob: https://invent.kde.org/frameworks/kio/-/merge_requests/1047 * Deprecate ThumbCreator and related classes: https://invent.kde.org/frameworks/kio/-/merge_requests/1044 * Port some thumbnailers to new base class: https://invent.kde.org/network/kio-extras/-/merge_requests/196 https://invent.kde.org/graphics/kdegraphics-thumbnailers/-/merge_requests/9 * Fix i18n in kdeconnect URL handler: https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/506 * Add autotest for filter combobox in KFileWidget: https://invent.kde.org/frameworks/kio/-/merge_requests/1041 * Several refactorings/cleanups in plasma-nm: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/176 https://invent.kde.org/plasma/plasma-nm/-/merge_requests/175 https://invent.kde.org/plasma/plasma-nm/-/merge_requests/174 https://invent.kde.org/plasma/plasma-nm/-/merge_requests/173 * Offload openvpn file parsing to networkmanager, hopefully making it a lot more reliable: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/172 * Fix dpr for thumbnails on Windows: https://invent.kde.org/frameworks/kio/-/merge_requests/1038 * Reload output list in tablet KCM when screens change: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1244 * Fix crash in kwin when setting output for a touchscreen to empty: https://invent.kde.org/plasma/kwin/-/merge_requests/3176 * Fix crash when doing openconnect stuff: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/169 Fushan A11y: * In QML, ObjectShow event will be sent whenever a visible item is initialized, which allows Orca to read Plasma notifications with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2295 applied * Allow to focus on labels in FormLayout: https://invent.kde.org/frameworks/kirigami/-/merge_requests/823 Proposing a SoK idea about improving a11y in KDE applications. Kleopatra provides a good example. Not sure how deep a SoK idea should be. Eco: * Unload ListView model when the widget is not expanded: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2326 which also potentially fixes bug 460895 since there are some ill-behaved Layouts. Aleix Discover * Gave some more love to the category infrastructure as it had regressed a bit. All restored and shinier and more featured than ever. XDP * As part of the ease of adoption of the different protcols and stuff on wayland, I took a closer look at RemoteDesktop. Addressed some usability usage and improved the UI in a couple of places. * Also fixed resizing dmabuf screencasting streams. Woohoo! SDDM * Closed on some topics regarding wayland sessions and keyboard layouts, which now can be switched in a kde-agnostic way. Other * Was at the Ubuntu Summit, it was nice to see some, maybe most notably seeing how happy Ubuntu Studio folks are with Plasma <3. More info from @jriddell https://jriddell.org/2022/11/14/ubuntu-summit-2022-prague/ Jonathan * I'm working on Plasma Bigscreen Neon flavour. I mention this mostly so I can ask if it should be x11 or wayland? Marco * week spent almost completely on multiscreen refactor, * wired up the x11 protocol coming from KScreen that Ivan did * more autotests that test more edge cases with more than 2 screens * while refactoring, found the reason of all that "requesting unexisting screen" spam * a part of the fix is here: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/648 * the other part in the refactor branch: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2277
Monday meeting notes for 31/10/2022
Fushan * I created one merge request on qtdeclarative which can help port many custom drag handler to Qt Quick Drag. https://codereview.qt-project.org/c/qt/qtdeclarative/+/440738 But I don't know how to compile tests. I have enabled QT_BUILD_TESTS_BY_DEFAULT but still don't see any test executable. If it can be merged https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1224 can be merged. [Discussion on how build tests] Nico * As usual most of what I did was somehow related to Qt6/KF6 * Make sure KWin effect configs only allow global shotcuts. This worked before until it broke. https://invent.kde.org/plasma/kwin/-/merge_requests/3141 https://invent.kde.org/plasma/kwin/-/merge_requests/3142 * Various "Port away from deprecated stuff" * Various Qt6 ports * Add test case for webapp matching in libtaskmanager: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2265 * Fix resourceName for XWayland windows in libtaskmanager: https://invent.kde.org/frameworks/kwayland/-/merge_requests/82 https://invent.kde.org/plasma/kwin/-/merge_requests/3113 * Add autotest for thumbnail generation: https://invent.kde.org/network/kio-extras/-/merge_requests/192 * Continued work on new thumbnailer interface https://invent.kde.org/frameworks/kio/-/merge_requests/833 https://invent.kde.org/network/kio-extras/-/merge_requests/154 * Please review, I want to get that in before Gear 22.12 freeze Aleix Discover Performance: Did a push looking at some startup problems we might be seeing, some fixes merged already, others waiting on upstream. Nothing super big but it will feel fresher. Homepage: Merged a new design and included some new concepts. Navigation: As per external* feedback, thinking of some ways to disentangle the feeling of category navigation with Discover. KWin For KWin I've been trying to get a number of stuff I had lingering unstuck. Went for a refactor of how Plasma clients deal with DPMS. Continued pushing the artists on wayland epic on the tablet input front, following the feedback from Blender Studio. See a number of merge requests, exciting stuff for them I hope. Carl * I worked on a ci job for qmlformat: https://invent.kde.org/sysadmin/ci-utilities/-/merge_requests/52 feedback welcome on it * and I also did a bit of work on the kirigami inlinemessage redesign Marco * a multiscreen refactor will be a big focus for Plasma 5.27 * functional branch of plasmashell which will be wired up with the new screen ordering protocol, added several autotests, aiming for a good coverage * merged plasmashell multiscreen autotest
Monday meeting notes for 17/10/2022
Jonathan * 5.26 is out! * 5.26.1 is tomorrow * 5.24.7 is out! * all seems to have gone smooth from my side [discussion: was there any drama? overall calm, one big issue seems https://invent.kde.org/plasma/kwin/-/commit/abf40c4a94c2c19dab4324c5879ca01ad048ffdc#note_542515 d_ed looking into it] above commit was a bug fix, so needs a way that fixes both Nico * I mostly did KF6 prep/porting * Added/fixed xdg-activation support in a couple of places, including Dolphin, Okular, Disks applet, KHelpCenter * Tweaked KWin's heuristic for mapping a touchscreen to a monitor a bit: https://invent.kde.org/plasma/kwin/-/merge_requests/3032 * Will look into making this configurable via KCM * Besides that I wanted to ask: (when) do we do a 5.27 kickoff meeting? * Given we said it's the last Qt5 release I imagine we have some planning to do [Discussion, are we having a 5.27 kickoff meeting?] [Johnathan will do a doodle to organize one] David R * I am banging my head against https://bugs.kde.org/show_bug.cgi?id=460345 * the gist is that it broke after it was merged because of https://invent.kde.org/frameworks/kirigami/-/commit/11e63f54dd66d0876392aef5b3c35e26b609c228 * columnview filters the mouse button release event from children * I want to get away with a plasma only fix to not have rely on a newer frameworks but nothing I tried works so far. Fushan * Fixed some visual glitches in the image wallpaper plugin (side-by-side preview not showing, wrong scale caused by reuseItems), and fixed a severe performance issue when using avif wallpapers (both static and animated are affected). * Continue the work on custom accent colors from wallpaper plugins: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1128 and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2084 * Ported away from PC2.ToolButton in color picker, and add support for extracting color from image: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/249 * This crash seems suspicious but I cannot reproduce it: https://bugs.kde.org/460378 For safety I reverted the DnD enhancement because I saw QQuickItemGrabResult::render() in the backtrace. David E * I want to talk about Sentry for a bit * firstly, is everyone here familiar with https://errors-eval.kde.org/ * if not, please make sure you're signed up * you need to join the plasma group * Overall it's working better than bugzilla in terms of getting data in and duplicate handling * I'm a bit disappointed in just how many different issues we have * many more in obscure areas of the stack that I assumed were fine * but hopefully we can now start fixing them all [discussion on how merge more sentry and bugzilla reports] [Harald: Ideally we'd get sentry out of evaluation and I can write some code to glue bugzilla and sentry tighter together. that said, longer term one would want to stop having crashes in bugzilla me thinks] Marco * fixed a crash in libplasma wrt the Plasmoid attached property * merged the port away of folderview from pc2 scrollarea * more work on kwin tiling, doing the last push for it * investigating if the tiles per virtual desktop can be done in the first merge or need to wait * all of today plus most yesterday looking at bugs of kscreen, a lot of effort will go in multiscreen now * fought and found a not super nice but workable solution for screen dragging in kscreen kcm, event handling is fun * started an autotest for multiscreen that instantiates a ShellCorona in a fake wayland server * as there are again plans to refactor multiscreen handling in plasmashell, that is an area that the more autotests there are the better it is, also emulating misbehaving monitors, docks and what not
akademy 2022 BOF notes
Those are the raw unedited notes for the plasma bof at akademy. probably not super clear to who wasn't there, but ask and discuss anything not clear Plasma BoF Akademy 2022 Things we want in 5.27 Noah: New spectacle Noah: has something to finish for the Breeze effort to see if the list highlight in plasma style can be done Kai MUST to port KPBI to manifest v3 Aleix: port system dialogs to the qtquick dialogs, so they can work better in plamo Marco: window tiling refactor in kwin tied one layout per output and VD combination Marco & David: multiscreen containment mapping robustness overhaul Plasma 5.27 becomes a new LTS, with ongoing maintenance releases until Plasma 6 is out Planning for Plasma 6 boring release or visual overhaul? new qstyle is infeasible icon overhaul using Ken Vermette's WIP work? using the naming scheme and release schedule of KDE gear based on date, and release the same day as gear apps? might make sense, but could give some flooding problems for promo, needs to be discussed with them plasma-framework will be moved to the Plasma group to be released along with Plasma instead of Frameworks Move all Breeze theme assets and data into Breeze repo Eventually move SVG handling out of Plasma Framework and into its own Framework Wayland multiple shells per client Remove concept of scriptengines, merge DeclarativeAppletScript into main library Sprint Before or after 5.27? to be discussed in the mailing list
monday meeting notes for 26/09/2022
BOF at akademy on 4th october 10:00 https://community.kde.org/Akademy/2022/Tuesday#Room_3_.E2.80.93_4th_October DavidE Are we doing a plasma beta testing day? was supposed to be last thursday but wasn't done [after discussion, let's skip it] Fushan [discussion on regressions, and weather applet which is one of those 3 regressions] * "One line change in the header file" to enable custom accent color from wallpaper plugins: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/587 Please review Kai Uwe Notificatons: Noticed that X-GNOME-UsesNotifications key isn't working in the KCM anymore, will fix later, unless @nicofee knows a reason for doing a string compare (he did the port) seems a porting bug to KApplicationTrader. The field is a proper bool now MS Teams sets it to an Array (true;), so it will still not work with it, though :D WIP: Play sound when plugging in/out USB device, please give it some real-world testing to filter out false positives: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2106 KScreen: Refactored output QML using a clever Gradient hack, please review https://invent.kde.org/plasma/kscreen/-/merge_requests/134 Frameworks: KIconEngine now returns the actual icon you get rather than the one that was requested kde-non-existing will fall back to kde and QIcon::name() will now return kde This allows e.g. Telegram to check if panel icon stuff is supported by the current theme Got a request to re-visit https://github.com/telegramdesktop/tdesktop/issues/25073 – what do you think? code lgtm. Not too happy with the static hash but I also wouldnt like an unsolicited setProperty into a const mimedata.. Marco * Another bugfix week * Systemsettings: (ugly) fix for dragging of screens in the kscreen kcm * qqc2-desktop-style: fixed a bug in horizontal scrollbars sometimes appearing when they shouldn't * Plasma: further work in layout solidity after resolution change, pushed fix * Plasma: fix for https://bugs.kde.org/show_bug.cgi?id=454416
Monday meeting notes for 19/09/2022
Fushan * Fix Kickoff DnD crash on Wayland: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1157 * Fix DnD not cancelling on Wayland: https://codereview.qt-project.org/c/qt/qtwayland/+/433461 * Are we sure not shipping https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1854 in 5.26? [discussion said to wait for reports] Aleix * Added support for locale1 into KWin, it gives us an opportunity to implement generically keyboard layout switching in SDDM+Wayland * Addressed a number of issues in the KeySequenceItem stemming from a review of the kcm tablet, but it could lead to several usability problems and even crashes. * I was pointed to a problem in SDDM and I've been looking into polishing some things there (including their CI, it was busted). The bug itself isn't fixed yet but I am closing on it, should have a PR today. * KWin doesn't crash upon SIGTERM/SIGHUP anymore * Overall bugfixing in preparation of Plasma 5.26 Nico * Refactor app launching in Discover: https://invent.kde.org/plasma/discover/-/merge_requests/374 * Fix translations in network KCM: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/151 * Fix apply button when defaulting kwin scripts KCM: https://invent.kde.org/plasma/kwin/-/merge_requests/2966 * Fix translations in kwin scripts KCM: https://invent.kde.org/plasma/kwin/-/merge_requests/2967 Marco # KWin * Tiling: fixing autotests # Misc * port folderview scrollarea to PC3 (still buggy) https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1144 # Bugfixes KWin * fixed annoying effect trigger loop when the use keeps pushing with the mouse on a corner * fixed touchscreen regression in overview * Fix for maximized windows not respecting panels upon kwin restart https://invent.kde.org/plasma/kwin/-/merge_requests/2953 # Other bugfixes * Kirigami: scrolling with touchpads very slowly on overlaysheet did break positions * SDDM: resurrected https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1386 * fixed build error on plasma-workspace * https://bugs.kde.org/show_bug.cgi?id=375740 -> https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1150 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2120
Monday meeting notes for 12/9/2022
Kai Uwe Notifications: Can now close notification popups with middle click on the popup Cleaned up the wording of some PowerDevil notifications Worked on a KDED module that monitors UDev for any (un)plugged USB devices to play a sound, similar to other popuplar desktop environments Independent of Solid or storage devices, also trips for e.g. USB headset, mouse, etc Quite noticeable for external HDDs where it takes a while for it to spin up before device notifier shows up Will get an RFC MR up sometime this week KWin: Generate blur noise texture on-demand, saves some startup time and resources when there are no blurred windows Some cleanup Solid: Trim output from (u)mount in fstab backend, please review: https://invent.kde.org/frameworks/solid/-/merge_requests/102 Other: Found that JavaScript is text/javascript again instead of application/javascript. Added a Breeze icon for that. Shouldn't really have any significant impact otherwise as the old one is still an alias. Fusan * I have one last a11y improvement for default Plasma applets and would like to ship in 5.26 beta: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2036 * Add animated wallpaper for beta testing: https://invent.kde.org/plasma/breeze/-/merge_requests/245 will be removed after beta is tagged * Fix yet another task rearranging bug: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2105 Aleix KWin+Wayland put the last nail on the "virtual keyboard on Xwayland is impossible", thanks to Arjen and I now it's just almost convenient added support of locale1 so that SDDM can switch keyboard layouts. Worked on the SDDM counter-part as well, so it's usable merged the tablet buttons MR Published Plasma Wayland Protocols 1.8.0 Discover Looked into certain problems regarding Flatpak Bundles which are now addressed and working beautifully SteamDeck Helped getting KWalletManager to work on the steamdeck Others OMGOMGOMG Akademy is so soon! 勞 Nico * Did a post-merge review/test of the new tablet button feature, filed some bugs * Add xdg-activation support for clicking links in Konsole: https://invent.kde.org/utilities/konsole/-/merge_requests/736 * Fix apply button when defaulting KRunner KCM: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1132 * Fix a quite common systemtray crash: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2091 * Ported Cuttlefish away from KPackage, fixes duplicate appstream data: https://invent.kde.org/plasma/plasma-sdk/-/merge_requests/53 * Allow analyzing remote folders with Filelight in Dolphin: https://invent.kde.org/frameworks/knewstuff/-/merge_requests/204 * Hopefully fix parent windows for KNS dialogs: https://invent.kde.org/frameworks/knewstuff/-/merge_requests/202 * Fix issues with defaults/apply button for GTK style setting: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2069 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2068 [DavidE]: do you know what the situation is with the regression in 5.25.5 in widget explorer you mentioned that we had something regress in stable [Nico]: Yes, something seems to have broken between 5.25.4 and .5 I don't know what change broke it There's a patch that fixes it, I asked distros to backport it Perhaps we should do a 5.25.5.1? Volker * KF6: the QSB port of plasma-frameworks still needs review :) * Help on PC2 components without replacement would still be appreciated, e.g. PC2.ModelContextMenu Nate * Mostly I have an urging for folks to work on Plasma regressions over the next few weeks so we can get Plasma 5.26 polished up nice and good * Here's the giant list: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_name=VHI-priority%20Plasma%20regressions_id=2148202=Bluedevil=Breeze=Discover=drkonqi=frameworks-kirigami=frameworks-plasma=frameworks-qqc2-desktop-style=kactivitymanagerd=kde-gtk-config=kdeplasma-addons=khelpcenter=kinfocenter=klipper=kmenuedit=krunner=KScreen=kscreenlocker=ksmserver=ksysguard=KSystemLog=kwin=Plasma%20SDK=Plasma%20Vault=Plasma%20Workspace%20Wallpapers=plasma-integration=plasma-nm=plasma-pa=plasma-simplemenu=plasmashell=policykit-kde-agent-1=Powerdevil=print-manager=printer-applet=pulseaudio-qt=systemsettings=Touchpad-KCM=user-manager=xdg-desktop-portal-kde_based_on=VHI-priority%20Plasma%20regressions_format=advanced Marco # KWin * more autotests for tiling * scripting bindings and a test script that gives more of a traditional tiling wm behavior * attempt to use the tilemanager for maximized windows as well (this will also allow for things like maximizing on a particular screen portion on ultrawides) however kinda failed and scrapped/postponed * Merged crossfade \o/ ## Bugs * Decoration shade button doesn't disappear anymore at going in/out of fullscreen * Plasma dialog doesn't lose the
Monday meeting notes for 5/9/2022
Nico * Quite a lot of stuff since the last meeting, not worth listing everything * There's one thing that's worth mentioning * I took a stab at globalaccel and fixed some issues there * And I have pending/WIP patches to fix more stuff * I wrote up the ideas in https://invent.kde.org/frameworks/kglobalaccel/-/issues/3 Eric * I'm working on logarithmic brightness Arjen * most prominent thing I've been working on is proper fractional scaling support in KWin * which means adding support for the protocol which is being worked on in upstream wayland (which was implemented by d_ed) * and on the rendering side ensuring that we don't render pixels off the pixel grid * the latter is what I've been focusing on and which involves a fair bit of refactoring on the rendering side * to make sure we can basically write output position = round(window position * output scale) * instead of having to go back and forth between logical and device coordinates * unfortunately I don't think it's going to make it for 5.26 as much of this doesn't make sense without the wayland protocol which is still in draft * anyway, that's it for me Jonathan * plasma-bigscreen got added to the next release * there's some more bits to go with it but I don't think they have passed kde review * so reviews needed * 5.25.5 is out tomorrow! * we are now in repo freeze and soft feature freeze, so no new big features please * 5.26 beta is a week on thursday Aleix KWin Finished the lockscreen overlay MR work so that the dialer can go over the lock screen. Maybe we want other things to go over the lockscreen now? Put together a MR to support tablet buttons to keyboard emulation, since it's apparently it is a must for artists. Approval is still pending https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1116 Discover A bunch of polishing and feature work done in preparation for 5.26: Content Rating, update bigger than free disk space, notification frequency, licence display, and more Others Been tracking a kscreenlocker crash that only seems to happen on Plasma Mobile Worked with Nate a bit on untangling the startup apps mess and did some coding work on the welcome app Found some unadressed comments in the GlobalShortcuts XDP protocol that needed addressing and worked on them. Need a last look and hopefully approve the tablets MR from Nico. I'd like to get this in for 5.26 Kai Uwe KWin: Ported sharing of keyboard map (among other things) to use memfd_create instead of QTemporaryFile Decoration palette is only created on demand, saves some resources/cycles when there are no windows with decoration (or client-side decorations) Blur noise texture is only created on demand, saves some resources/cycles when there are no blurred windows Plasma: Icon applet now disables itself if no backing file is present (also avoids assert in KPropertiesDialog) Use PlainText labels in Kickoff (still need to make a patch for 5.25/5.24 since master didn't apply cleanly) Notifications: No longer uses Root path for "/" (so it doesn't show 500 GiB internal storage/foo) plasma-browser-integration: Now ignores "non-browser" desktop entries, so p-b-i doesn't pretend to be a webapp instead of the browser itself Dolphin/KIO: Fixed various places where" user canceled would result in a pointless error message Minor improvement in KFileItemModel Show busy indicator while (un)mounting device, please review https://invent.kde.org/frameworks/kio/-/merge_requests/962 Read .hidden file in file:/ worker rather than KCoreDirLister, saves some blocking calls in UI, needs a bit of rework (API for ListJob): https://invent.kde.org/frameworks/kio/-/merge_requests/962 Fusan * I am looking forward to supporting custom accent color: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/587 If the idea is approved I will start working on the Plasma part. * I am also looking forward to supporting xml wallpapers in the next Plasma version Volker * Qt 6 porting: making progress on custom shaders (Kirigami MR awaiting review, KQuickCharts done but blocked by another open MR, Plasma Frameworks and KWin MRs coming later today). * One issue beyond that are PC2 components with no equivalent (ModelContextMenu, ButtonColumn, etc), would appreciate input on how to proceed with those. * will need help to see what PC2 components need to be ported to qt6, what one can be ported away and removed completely Marco # KWin * Continuing on tiling and started to write autotests for it * bindings for scripting # QQC2 bug * investigation in various fallouts from the Qt upstream changes in QQc2 scrollbars behavior, resulted in reporting a new upstream bug * https://bugreports.qt.io/browse/QTBUG-106118 * and a workaround on our side in qqc2-desktop-style
Re: semicolons and the policy that was none
> I don't know. We really are not adding ; everywhere now and I can > already feel the waves of pointless MRs adding/removing ;. > > Big A) from me. I would be fine with A as well... as long as is not b :p -- Marco Martin
Re: semicolons and the policy that was none
On Wed, Aug 10, 2022 at 6:43 PM Carl Schwan wrote: > > Please cast votes > > I would vote for c, it's more consistent with C++ and avoids some rare > issues where removing the semicolon creates issues. This is what I'd been > already doing for the app I maintain. Agree. for instance see here https://www.freecodecamp.org/news/codebyte-why-are-explicit-semicolons-important-in-javascript-49550bea0b82/ where gives some examples of code doing unexpected things not using a semicolon -- Marco Martin
Re: semicolons and the policy that was none
On Wed, Aug 10, 2022 at 3:58 PM Harald Sitter wrote: > a) we don't care, do whatever you feel like but be consistent with > your surrounding > b) use semicolons never [*unless required] > c) use semicolons always > d) use semicolons sometimes [*define sometimes] I know i'm always the contrarian but i always hated javascript without semicolns.. I vote for c (or d where the definition of sometimes is a single line binding like text: propertyA || propertyB ) -- Marco Martin
Monday meeting notes for 1/8/2022
Nico * Merged a patch for p-w to introduce a WITH_X11 cmake option Some follow-ups: * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1966 * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1967 * Fixed KHelpCenter now showing most KCMs: https://invent.kde.org/system/khelpcenter/-/merge_requests/20 * Fixed X11 monitor EDID parsing in kwin: https://invent.kde.org/plasma/kwin/-/merge_requests/2750 * Refactored KWin to make bugs such as the above less likely: https://invent.kde.org/plasma/kwin/-/merge_requests/2754 * That patch raises the compiler requirements, but should be fine * Removed unused SeviceTypes declarations from lots of places * Random cleanups here and there * Fixed kscreen KCM crashing on screens with 0x0 geometry: https://invent.kde.org/plasma/kscreen/-/merge_requests/122 [asturm: libksysguard also has an X11 dep like that, could work on that with the same logic] [nicofee: yes, there are plenty of places left including plasma-desktop] * Given the recent Latte news I proposed to add it to the regular Plasma releases to make it easier for "us" to do some basic maintainance: https://mail.kde.org/pipermail/plasma-devel/2022-July/122616.html [discussion about that, pros is easier to catch when things break, cons, the implied message may be wrong as it could message it's more maintained now while it's less] [probably making the tarball the same day but not advertising it as part of the plasma release] Fusan * More a11y works in kdeplasma-addons 15Puzzle is now playable with only a keyboard: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/209 give Timer applet a fresh new compact representation: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/211 * Allow to cycle through more than one panel, also port m_panelViews to std::map so it can be lighter, since panels need an ordered container. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1983 * Add option to disable updating PoTD over metered connections: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/207 DavidE RE: porting to QMap -> QMap there's a frameworks thread about porting to frameworks things with stl equivalents the consensus there was "do it for pointers, not for containers" [discussion about what is still needed to remove completely KDisplayManager in favor of SessionManagement] Kai Uwe plasma-browser-integration: Started porting to Manifest v3 Chrome will stop supporting Manifest v3 EOY Features that do not interact with website contents (historyrunner, tabsrunner, kdeconnect integration, download monitoring) were straightforward to port Interacting with website contents (mpris, purpose share) will be a PITA to port, fvogt already did some PoC a year ago, need to look into that: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/14 KRunner: Set location (for slidingpopups effect) before showing, please review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1986 Plasma-pa: Fixed volume monitor not working for "recording applications" KWin: Fixed flickering while resizing Chrome after some refactoring in KWin, also fixed a (potential) crash in that area PowerDevil: Low/critial battery notification now shows if battery drains even while plugged in Some other minor notification fixes KScreenlocker: Added "busy" property to authenticator (not used by UI yet because:) Experienced an issue where it would remain busy indefinitely when auto-locked not sure yet what causes this, as it doesn't happen when locking manually https://bugs.kde.org/show_bug.cgi?id=457179 looks related, hope this patch helps here KIO: Add Solid actions to KFilePlacesView (WIP) Allows to add e.g. "format partition" to context menu of a drive in Places panel using the actions from Device Notifier please have a look: https://invent.kde.org/frameworks/kio/-/merge_requests/930 Marco * work on bug https://bugs.kde.org/show_bug.cgi?id=455783 -> https://invent.kde.org/plasma/kwin/-/merge_requests/2680 * this is about having better keyboard navigation with qml fullscreen effects and multi monitor together * still working on some last problems on this patch * most work this week done to restore the crossfade effect in kwin https://bugs.kde.org/show_bug.cgi?id=439689 -> https://bugs.kde.org/show_bug.cgi?id=439689
monday meeting notes for 25/7/2022
Fusan * Reduce duplicate code in showdesktop and minimizeall applets: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1043 * Add a11y properties to Plasma applets, most applets in plasma-desktop and plasma-workspace should be usable with the help of a screen reader after those MRs are merged. * Notification: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1954 * Task manager progress bar: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1060 *Two foundation fixes which will greatly improve accessibility for Qt applications on Linux, and are the prerequisite for The Accessibility Goal: https://codereview.qt-project.org/c/qt/qtbase/+/423439 and https://codereview.qt-project.org/c/qt/qtbase/+/423457 * Add ATK_ROLE_PUSH_BUTTON_MENU to Atspi, which should allow a screen reader to properly react to a button that opens a menu if merged: https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/103 * Question: Is it possible to give menu role to a menu item that has a submenu in Qt applications? https://gitlab.gnome.org/GNOME/orca/-/issues/257#note_1510181 Nico * Remove dead code for KCM loading in KInfoCenter: https://invent.kde.org/system/khelpcenter/-/merge_requests/19 * Make sure that notifications via portals don't have sound by default: https://invent.kde.org/frameworks/frameworkintegration/-/merge_requests/13 * Fix Yakuake crashing on close: https://invent.kde.org/utilities/yakuake/-/merge_requests/64 * Fix KMoreTools detecting whether apps are installed: https://invent.kde.org/frameworks/knewstuff/-/merge_requests/194 * Fixed several things in the comic applet: * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/194 * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/195 * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/196 * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/198 * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/199 * https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/200 * Remove some dead code: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1944 * https://invent.kde.org/system/khelpcenter/-/merge_requests/19 https://invent.kde.org/frameworks/frameworkintegration/-/merge_requests/13 https://invent.kde.org/utilities/yakuake/-/merge_requests/64 https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/197 need review Nate I have two MRs stuck in review: *https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1041 *https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1874 Aleix wayland * looked at touch on subsurfaces so gtk apps work fine on touch * finished some discussion over the tablet fitting kcm and it's about ready to merge * improved the bouncing cursor feature for Xwayland apps that define StartupWMClass * fixed a problem in the XDP screencasting kcm Discover Discover * Had a swipe over different bugs reported, most of them already fixed or in the process. They were generally useful UX annoyances, nothing major. David E * My patches for making kwin support floating point scaling are in - please do report bugs. Except Kai as I'm fixing yours right now * it was inevitably going to get some regressions * The other big topic is trying to write QML unit tests for more things * I have: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1914 * it's blocked on Nate having issues running the tests * which I don't understand Kai Uwe Plasma-pa: Show indicator when app starts using a muted microphone so you don't forget, https://invent.kde.org/plasma/plasma-pa/-/merge_requests/128 I will add a setting to it since we also have settings for all the other OSD stuff Breeze style: Fixed menu width with long section headers (bigger section font wasn't taken into account) Notifications: When no thumbnail available (rare), drag pixmap is now file icon KMessageDialog (async variant of KMessageBox) now also emits notification sounds Screenlocker: Add "busy" property to authenticator so we can provide some feedback when unlocking takes a while, please review https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/68 Other: SFTP KIO now lets you continue after a warning when host identity has changed rather than flat out refusing to connect Various bits of the UI (Dolphin's tab bar, qqc2-desktop-style) now use the correct QHeaderView font (since Breeze uses a smaller font for column headers now) that screenlocker patch is working marvellously both on normal setup and ldap login stuff needs a change to p-w lnf to add a busy indicator, o/c Marco KWin * bugfix https://invent.kde.org/plasma/kwin/-/merge_requests/2680 which is still not ready Spectacle * Continuing on the annotation component, most tools and export pretty much done, plan to wind down with it starting next week to dedicate a bit more to kwin again
Monday meeting notes for 18/7/2022
Aleix * spent some time testing plasma wayland on a nvidia card david gave me. I originally asked him for testing screen recording and that worked alright (all things considered), still quite disappointed by the state about the state overall. I am not entirely sure it's our fault as other DEs have similar problems so it's hard to judge. It's clear that their driver behaves different to mesa drivers anyway. I am back on amd because it hurt productivity too much. * I did work on supporting the keysym method from the RemoteDesktop portal, stuck in reviews: https://invent.kde.org/libraries/plasma-wayland-protocols/-/merge_requests/43 https://invent.kde.org/plasma/kwin/-/merge_requests/2584 https://invent.kde.org/frameworks/kwayland/-/merge_requests/67 https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/480 * I did work on supporting the mapping of drawing tablets to outputs, stuck in reviews: https://invent.kde.org/plasma/kwin/-/merge_requests/2627 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1025 * Worked with Aditya a bit towards polishing the remote controllers KCM * I am looking now at xdg activation + x11 apps which doesn't seem to work that well Nico * Not much Plasma this week * Mostly porting apps away from deprecated stuff * Last weekend I was at a KDE eco sprint * One of the tools we use there for measurement automation is xdotool * To be able to do that on wayland I've been looking into making a similar tool that uses the fake input protocol * So apol's work is welcome there :) Xaver * I've been looking into supporting color management in KWin * getting the basics to work is relatively easy, hope to have some MRs for that soon. The tricky bits will be ensuring accuracy and hardware offloading Marco # Kirigami * Merged the long-due scrollablepage refactor # Spectacle * passed most week on the annotation editor of spectacle: annotations possible directly on top of the fullscreen rectangle selection * it was basically implementing Paint from scratch which is just long but a well-known well researched topic, so during this week was almost completed * is just basic shapes/text on the image with undo/redo support * hopefully that could be made to replace kquickimageeditor some day (or merged into), so usable in koko and what not * kquickimageeditor was looked into, but its architecture was completely unsuitable (undo/redo steps with a complete image copy of each step) Kai Uwe Notifications: * Job aggregator ignores stopped jobs now as it should Plasma: * Show microphone OSD as reminder when app starts using muted microphone, idea https://invent.kde.org/plasma/plasma-pa/-/merge_requests/128 Solid: * Removed pointles QDBusInterface, sped up Dolphin startup by 50ms on my machine * Ported some QDom stuff to QXmlStreamReader, saves another couple of milliseconds KRunner: * Now reuses items in ListView, should make it snappier * In general I have a bunch of reviews open on GitLab that haven't seen any activity, please review :( https://invent.kde.org/plasma/plasma-pa/-/merge_requests/128 https://invent.kde.org/system/dolphin/-/merge_requests/424 https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/168 https://invent.kde.org/system/dolphin/-/merge_requests/423 https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/61 https://invent.kde.org/frameworks/kfilemetadata/-/merge_requests/60 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1729
Monday meeting notes for 4/7/2022
Kai Uwe Back from vacation :) KWin: Was investigating why Aurorae window decoration doesn't play nicely with nested KWin. EffectQuickScene changes GL context and then when KWin wants to continue and calls GL stuff libepoxy falls on its face. Plasma: Found the new language and locale KCM doesn't for packagekit-qt5 availability properly, I filed https://bugs.kde.org/show_bug.cgi?id=456305 Other: JPEG thumbnailer now extracts preview image from Exif metadata, if available, significantly speeding up thumbnail generation For the 12 MP image sin my pictures folder the average thumbnail generation time went from 80–120ms down to as little as 3–5ms [Discussion on CMake 3.22 bump and the need of checks if ubuntu, due to differentces on how tanslations are packaged] Nico * Revived and finished some old open MRs * From ~150 open MRs down to ~130 :D * new stuff: * Pass parent window to syscoca progress dialogs: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1882 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1013 * Port things to new KIO WorkerBase: https://invent.kde.org/network/kio-extras/-/merge_requests/169 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1884 * Fix modem sim pin dialog, after I broke it: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/133 * Some cleanup and fixing in knewfiledialog: https://invent.kde.org/frameworks/kio/-/merge_requests/889 https://invent.kde.org/frameworks/kio/-/merge_requests/884 https://invent.kde.org/frameworks/kio/-/merge_requests/883 https://invent.kde.org/frameworks/kio/-/merge_requests/882 * Fix showing "Show QR code" only for wifi networks: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/131 * Fix crash in Wayland tablet KCM: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1014 * I may look into tablet button rebinding on Wayland for $WORK soon, hence my interest in https://invent.kde.org/plasma/kwin/-/merge_requests/2312 Fusan * Add option to give a visible option to configure Qt scaling for Plasma on X11 after one of the most annoying multiscreen bugs has been fixed: https://invent.kde.org/plasma/kscreen/-/merge_requests/107 and https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1890 * In the future it can be default enabled, if most people are using PLASMA_USE_QT_SCALING and can endure those known bugs nowadays. Vlad * Debugged a visual glitch in the slide effect on X11. Submitted a patch to fix it, but Dave wants to put another fix on top of it * Refactored idle detection on wayland so it's less error prone * Fixed missing desktop background in the slide animation after changing system settings * Lots of other kwin related chore * Implemented the desktop cube effect using qtquick 3d, I would like to keep it as a third party effect and close relevant bug reports in bko, any thoughts? * Got sick, I need a couple of days to recover so the symptoms don't interfere with the work too much [Discussion on where the desktop cube should live, probably kdeplasma-addons] Asturm * systemsettings-5.24.6 will depend on KF-5.91 unless something changes [Discussion: revert and keep the bug or ask distros if is ok to bump?] Marco * further work on tiling support https://invent.kde.org/plasma/kwin/-/merge_requests/2560 ** now save and restore work perfectly ** configuration ui is usable ** still needs figuring out how to wire up editing tiles when tiled windows are normally resized ** still needs some viable solution for fake fullscreen in tiles * fix bug on touchscreen and fullscreen qml events https://invent.kde.org/plasma/kwin/-/merge_requests/2601
Monday meeting notes for 27/6/2022
Nico * Fixed a performance regression in thumbnail code: https://invent.kde.org/network/kio-extras/-/merge_requests/166 * Simplified some plasma-nm code: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/126 * Made a patch for AppstreamQt to make it not break C++20 builds: https://github.com/ximion/appstream/pull/414 * Needed for when we want to use C++20 in Plasma, which I hope is soon * Fixed some KIO popups not having a parent window: https://invent.kde.org/frameworks/kio/-/merge_requests/872 * made a patch for plasma-nm to refactor some code by using coroutines: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/124 * Which is mostly a RFC for using coroutines in Plasma * See also https://invent.kde.org/network/kaccounts-integration/-/merge_requests/35 for why coroutines are awesome * I found a problem though: Our FreeBSD builders don't have the necessary deps ATM, due to libc++ being behind on things * So we need to double check if/when we can rely on it Jonathan * 5.25.1 is out and 5.25.2 is tomorrow * see my email to the list today with questions * is the 5.26 schedule still lovely? * I have 5.24.6 due next week but I'm away on holiday, can I delay it a week? [discussion agreed is fine, then every 6 months after that] Fusan * Show EXIF title and author in wallpaper image plugin: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1852 * Time of day wallpaper: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1862 * note: I still have no time to absorb vladzzag's great code, so solar/day-night is not added for now. Arjen * I did a bunch of work on plasma-nm to improve how it works in combination with iwd (inet wireless daemon by intel) * it's this intel project to replace wpa_supplicant as wireless backend for networkmanager * anyway, most prominently I did an mr that provides a config option to create system connections by default and which links together the "all users can connect" checkbox with the storage location for passwords, so that if you create a system connection the password is also stored system wide * https://invent.kde.org/plasma/plasma-nm/-/merge_requests/125 * I also found and did an mr to fix a bug where trying to connect to a network that shows the config dialog we only add a connection and don't immediately connect: https://invent.kde.org/plasma/plasma-nm/-/merge_requests/128 * if anyone knows networkmanagerqt it'd also be nice to get a review on https://invent.kde.org/frameworks/networkmanager-qt/-/merge_requests/23 * which would allow a fair bit of cleanup in the plasma-nm codebase Nate * I want to briefly discuss https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/556 and https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/557, which just came up [Marco: would like to have one scaling method on x11 as a prerequisite oof trying to properly fix] Marco # Kirigami * further work on scrollablePage refactor # KWin * bugfixes on the desktop grid * merged the overview window thumbnails refactor * first draft version of the kwin tiling work, can already be testable https://invent.kde.org/plasma/kwin/-/merge_requests/2560 * Better focus handling in fullscreen qml effects (merged) https://invent.kde.org/plasma/kwin/-/merge_requests/2572
Monday meeting notes for 20/6/2022
Fusan * Merged multiscreen fix for picture of the day plugin, backported to 5.25.1 as there are some duplicate bug reports. * A minor visual glitch fix for Discover which I have seen in many 5.25 review videos: https://invent.kde.org/plasma/discover/-/merge_requests/322 * The animated wallpaper has a severe leak issue on both Intel and AMD platforms. I suggest we merge https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1845 or disable animated wallpapers on X11 by default. https://fars.ee/1j8E.png But as it is likely a bug in mesa so I am not sure where should I report the bug. [ discussion on how to avoid workarounds of 1845 and 1854] [ discussion about dynamic wallpaper ] Aleix * kwin: worked on the screencast+modifiers, it's working now, pending to test it on an nvidia system. some corners to polish but it should be there, finally. Testing would be very much appreciated, especially if you are running nvidia: https://invent.kde.org/plasma/kwin/-/merge_requests/2507 https://invent.kde.org/plasma/kpipewire/-/merge_requests/2 * kwin: refactored how backends produce dmabuf textures for optimal handling. * kscreen: merged all the bits for seamless xwayland scaling experience * discover: Fixed an issue reported where it wouldn't respect each remotes' priority, now it does. * kwin: This week I'll be looking into new strategies for managing windows on humongous displays David E I've made a MR on every plasma repo requiring passing unit tests and we have a lot of issues on various repos https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/81 https://invent.kde.org/plasma/plasma-thunderbolt/-/merge_requests/9 https://invent.kde.org/plasma/drkonqi/-/merge_requests/64 https://invent.kde.org/plasma/libkscreen/-/merge_requests/57 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/985 https://invent.kde.org/plasma/kdecoration/-/merge_requests/21 https://invent.kde.org/plasma/discover/-/merge_requests/318 Vlad * Boring stuff. Mostly, bugfixing.. It appears like most of new bug reports are about effects (desktop grid, window view, etc) [discussion: some bug reports on the rewritten effects are actual regressions, some are on config options purposedfully removed, so will need to gather data on how much those were used] Marco # KWin * Most of the time spent in that tiling support based upon windows fancyzones will finally open a draft MR about it this week, mostly to gather feedback to see i'm headed in a completely wrong direction * fix windows dragging between desktops in desktop grid * search on all screens in windowview https://invent.kde.org/plasma/kwin/-/merge_requests/2532 * move windowheap delegate on own file for readability https://invent.kde.org/plasma/kwin/-/merge_requests/2519 # Kirigami * fix checkable labels in FormLayout https://invent.kde.org/frameworks/kirigami/-/merge_requests/572 * more work on the ScrollablePage refactor, regressions should be fixed now
Monday meeting notes for 13/6/2022
Nate regressions: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=2023541_format=advanced=5.24.90=5.25.0=5.25.1=5.25.2=5.25.3=5.25.4=5.25.5 Fusan Some minor panel fixes targeted at 5.25.1 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/971 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1807 A regression that I can't reproduce on 5.24.5/KF5.94, need investigate: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1783 Port away from singleton EventPluginsManager: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1755 Fix unable to apply wallpaper settings after switching layout: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/964 Various image wallpaper enhancement, like automatic background color detection: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1825 Marco # KWin * splitting thumbnails of overview in separate component * started to work on a feature which imitates windows fancyzones: this is to better work in big ultra wide screens to simulate sub-screens, or in general towards "make tiling a first class" https://invent.kde.org/plasma/kwin/-/issues/10 still at super early prototype stage
Monday meeting notes for 6/6/2022
Fusan Add wide wallpaper support: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1800 Add dark wallpaper support: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1802 and this MR replaces the former MR but lacks support for time of day. Any ideas how can time of day be supported by KPackage? Fixed some panel bugs Nico * I've mostly done Android stuff * Like adding version handling to the apps so that the nightly fdroid repo actually offers nightly updates * And a couple of other related fixes * In terms of Plasma the most noteworthy thing is fixing x-d-p-kde to properly encode URLs: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/108 Marco # Kirigami * More work on the ScrollView refactor, though reverted for now, will probably aim for not this framework release but the next # KWin * more regression bugfixes, merged window dragging between screens in overview effect
Monday meeting notes for 30/5/2022
Nico * More xdg-activation fixes this week * Added support for it to the email xdg portal: https://github.com/flatpak/xdg-desktop-portal/pull/806 * And raised an issue (pun intended) about MPRIS raise: https://gitlab.freedesktop.org/mpris/mpris-spec/-/issues/18 * Fixed a regression from earlier work https://invent.kde.org/plasma/kwayland-integration/-/merge_requests/23 * And ported the email portal impl to KEmailClientLaucherJob: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/99 * There's also a patch (not from me) to add activation to the notification portal Once that is in I'll implement it on our side https://github.com/flatpak/xdg-desktop-portal/pull/791 [apol: maybe a patch would be easier to act on?] [nico: Probably. I wasn't sure what the best solution is, hence I made an issue] Fusan Panel Fix panel keyboard navigation: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1771 Fix potentially many visual glitches introduced in panel refactoring, needs review before 5.25.0: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/956 Wallpaper Fix unable to apply wallpaper settings after switching layout: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/964 Preserve wallpaper type after changing desktop layout: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1784 Fix desktop layout setting not being saved (I can't reproduce the bug on 5.24.5/KF5.94, but can reproduce on master): https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1783 Kickoff Add section view for Kickoff, needs approval: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/941 Porting Port to QConcatenateTablesProxyModel for notificationsAndJobsModel. @kbroulik:kde.org I didn't see a crash, but maybe I missed something: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1770 also can https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1781 be merged to Plasma first to save hidpi x11 users since I don't know how long will it take to merge the fix in Qt. [kbroulik: I think that crash was fixed in Qt 5.15.4 but not sure I guess since master is open again we can merge and see? :D] [d_ed: it won't affect any normal X11 user as it only applies when additional envs are enabled] [d_ed: What I don't want to happen is for us to merge this then not have the motivation to follow up on the Qt patch, especially if Tor is pushing for a sightly more in depth solution] [fusionfuture: but there are reports even without hidpi the bug can appear After 5.24] Aleix did a kpipewire push to make sure things are done when Noah finishes the spectacle port. There's a merge request for Plasma Mobile that adds screen recording also created this simple app for screen and window recording, testing and reporting will be very welcome: https://invent.kde.org/apol/screenrecord In the process of creating a flatpak version of screenrecord, I've gone down the rabbit hole of a series of problems in our screencasting stack that I've been addressing Iterated the shortcuts language spec a bit further: https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/56 Did a test app for the curious, feedback welcome too https://gitlab.freedesktop.org/apol/xdg-shortcuts-spec Did some work to prepare Plasma for Xwayland high dpi support, adapting some bits when Plasma starts as well as making it possible to configure through KScreen. Improved Discover system upgrades process, more work still to be done. Biggest problem now is users being annoyed about too many updates. Kai Uwe KWin: Screen edges trigger on fullscreen effects again, i.e. you can leave overview/windowview the same way you came Port screenedge effect to EffectQuickScene, allows to drop the build-time dep on plasma-framework in KWin effects https://invent.kde.org/plasma/kwin/-/merge_requests/2435 Apparently high-dpi issue on Wayland, need to investigate Killed KWinXRenderUtils, mostly unused after XRender backend was dropped Fixed issues running kwin_wayland nested in X11 KWinXRenderUtils needs to talk to the "host" X server if there is no XWayland Fake Vsync stuff wasn't working, breaking GL rendering Now supports resizing the window and syncs the output size to it Skips creating a mouse cursor from a null pixmap, it's pointless and results in console warnings KWin's platform plug-in provides a QPlatformNativeInterface now for maximum compatibility with Qt Seems some parts of Qt (notably font stuff) behave quite differently under Gnome-based desktops, crashing left and right if there is no native interface provided, but using different codepaths when run under Plasma. Plasma: Mouse wheel in calendar now does what you think (switches year/decade) System Tray popup now fakes "pressed" signal, too, in addition to "clicked" to ensure applets relying on onPressed to work KIO:
Monday meeting notes for 23/05/2022
Nico
* I did a bunch of xdg-activation related fixes in various apps
* Like porting from QProcess to ApplicationLauncherJob so things "just work"
* I made a Qt patch to add activation support to
QDesktopServices::openUrl:
https://codereview.qt-project.org/c/qt/qtbase/+/411997
Alex
* Been workig o the Qt6 builds and foud some issues where I created MRs for.
* Though I had to build Qt6 from source, because the Neon Qt6 package
did not seem to provide the Qt paths target.
* Did anyone do KF Qt6 builds with the Neon provided package?
* https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1746
needs a formal approval, could you give it a look Aleix or d_ed?
* Been working on some KCM bugfixes, but those are already merged :)
* https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/925#note_453384
Could sb. try out if the focus issue works for them in the current
state of the MR Arjen said that it works for him, but it does not work
for me. (Hopefully it is not related to me having Qt build using
kdesrc-build)
* and maybe kbroulik could give
https://invent.kde.org/plasma/milou/-/merge_requests/40 a look. That
would be all from me.
Fusan
* Merged alternate calendar MR for 5.26:
https://invent.kde.org/frameworks/kdeclarative/-/issues/1
* Merged wallpaper backend refactoring MR for 5.26, 9 new tests have
been added: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1638
* About the dynamic (day/night) wallpaper proposed by @zzag, what kind
of wallpaper file format should be used?
Aleix
KWin & Wayland-ish
Fixed the output composition when connecting an external monitor
on a transformed device (i.e. rotated)
Put together the protocol for appearing on top of the lock screen
(mainly for plasma mobile & dialer, some adapting still is necessary)
Worked on enabling window activation when launching from
kglobalaccel and from within kwin (e.g. when starting processes from
an effect, like Overview)
Fixed a silly regression on the edges kcm
KPipeWire
finally got it out of the drawer
Ported plasma-workspace and plasma-mobile to it
Added a UI component in Plasma Mobile for Desktop recording, so we
could get some more testing for it
Fixed the issues I found (not few ^^')
Hoping to integrate it soon
Now going through @jgrulich's feedback
For context, I'd been developing KPipeWire for a while from a scratch repository
which is what we were using in Plasma Workspace for rendering thumbnails
but since there's a growing number of users it makes sense to share
this code because it's quite finicky and there's no good reason for
repeating it all over the place
Arjen
* main thing I did last week is adding a fallback path to inputmethod
for when there's no text-input-v{2,3} interface
* since we don't have a way to communicate with the client in that
case, the fallback path sends fake key events to the client
* it works surprisingly well
* though it's converting a text string to a key event which is slightly tricky
Marco
# Kirigami
* refactor all the usage of the private ScrollView in kirigami to
upstream QQC2.ScrollView, which kills a lot of code and fixes some
freezes, especially in discover
https://invent.kde.org/frameworks/kirigami/-/merge_requests/548
# Plasma/wayland
* heuristics to work around the different connector names between x11
and wayland, which makes it have different desktop containments
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1745
* spent time to identify where those connector names come from on both
x11 and wayland, documented on above commit
* ended up not being reliable eough as is too much driver specific,
decided to byte the bullet and start to use libdrm directly, to have
one.bloody.source.of.truth.
Monday meeting notes for 16/05/2022
Nico * I added support for Wayland window activation to a bunch of KDE apps * Too many to list the MRs e.g. https://invent.kde.org/network/kget/-/merge_requests/30/diffs * There's two cases still where activation doesn't work: * When launching apps from global shortcuts: https://bugs.kde.org/show_bug.cgi?id=453748 [apol: I'm looking into it right now] Fusan URGENT: This MR must be merged before 5.25 beta is shipped: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/936 The memory leak in Kirigami.ColumnView has been fixed by d_ed, so "Port Kirigami.ApplicationItem to Loader" is not needed anymore. A regression is found in kcms/desktoptheme after updating to KF5.94 but the proper fix is in Plasma. Could suggest distros to also add the 2 patches before shipping KF5.94: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1730 https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1732 Kai Uwe KWin: Some build system fixes and clean up Working on porting screenedge effect from using Plasma Svg C++ API to EffectFrameQuickScene → Would allow to drop the build-time dependency on Plasma Framework (outside of KCMs, that is, screenedge KCM monitor thing also uses the C++ API) Notifications: Show file for stat job, so that ominous "Examining" notification you sometimes get (when stat takes a while) at least tells you what it's examining, please review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1729 System Monitor: Add "Resume stopped process" context menu entry, WIP, please suggest how I can check the process state in https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/182 Arjen * I did a bunch of system monitor bugfixing last week * one bug was rather puzzling and turned out to not be a system monitor bug in the end * the fix turned a bit more complex: https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/122 * so the bug was that when adding a system monitor plasmoid "weatherwidget2" ended up with an incorrect user agent * which turned out to be because kdeclarative::~kdeclarative unconditionally deletes the qnam factory set on the engine (the engine remains valid, but the qnam factory still gets deleted) * so it needed a way to track if a certain engine was still being shared, which is exactly what shared pointers are for Aleix KWin * Edges get inhibited when using a fullscreen window. The alternative was to smash my computer when playing Age of Empires. Or disabling the edge, but that's too civilised. Did some extra clean up of edges code as it had some x11 considerations that can now be abstracted. * Put together a Wayland protocol for apps to appear on top of the lock screen. This is important for plasma mobile users to properly take calls while their device is locked. https://invent.kde.org/plasma/kwin/-/merge_requests/2385 * Looked into an xdg activation problem and addressed it, then a couple more were reported (kglobalaccel + overview) that I am looking into right now. * kscreen, found that we were extending the desktop wrong when we were connecting an external output while an output is rotated, it is now addressed. Discover * Addressed a problem Harald pointed out where we were taking up too many inotify instances from KNewStuff. * App Permissions view SoK code merged * Worked on the usability of some Flatpak features like deleting data and such. Marco # KWin * hide panel from overview effect * kwin part and KCM part to control tablet mode, to always turn it on or off * working on dragging windows between screens on the overview effect # Plasma * spent a bit more than usual with upstream code reviews # Kirigami * looking into making a ScrollablePage2 with a less confusing behavior than ScrollablePage probably will need to coexist until kf6
monday meeting notes for 9/5/2022
Alex: * I resumed working on the KCM porting, see https://invent.kde.org/plasma/kwin/-/merge_requests/2333 * and https://invent.kde.org/frameworks/kio/-/merge_requests/836. * With https://invent.kde.org/plasma/systemsettings/-/merge_requests/138 we emit deprecation warnings for old modules. But we should fix the KDE ones first. * I need a bit of help regarding the focus stuff in https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/925 notmart ahiemstra Could you maybe help out? Kai Uwe Plasma: Broke the global menu accidentally, did an unbreak attempt, but didn't succeed: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1701 Don't have the time right now to follow up, if anyone wants to, feel free KWin: Worked on rebasing and cleaning up the EffectFrameQuickScene patch, now that Present Windows is gone I feel a bit more at ease with the performance overhead it introduces Looked at porting screenedge effect to EffectQuickScene, ran into some trouble with scaling and/or enabled borders on FrameSvg, need to investigate Other: Added BUILD_RUNTIME option to kglobalaccel, to turn it into API-only repo and drop most its deps for Wayland-only build (where it's inside of KWin) Arjen * the biggest feature I did was a dialog to fix pages that are missing sensors (either because it was broken when uploaded to the store or because hardware disappeared), I'm not sure if that's still mergeable as it has a somewhat bigger impact https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/180 Fusan * I would like to add support for alternate calendar in Plasma 5.26. The minimum required changes in the framework are sub-label and alternate-date supports as I proposed in https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/112. * The feature MR is ready and is waiting for the changes in calendareventsplugin to be merged: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/112 . Currently it supports 6 alternate calendars (4 from QCalendar, 2 from libicu). Carl * I made a small PR to kirigami https://invent.kde.org/frameworks/kirigami/-/merge_requests/543 and other than that worked on kalendar and tokodon :) Volker * Plasma 6 build status overview: https://phabricator.kde.org/T15468 * help with looking at the remaining QDesktopWidget uses would be appreciated, reviewing https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/138 would help in that direction as well :) Fabian * Should be quick: https://bugs.kde.org/show_bug.cgi?id=452817 Marco * merged realtime screen borders for scriped effects * merged dynamic load of effects in edges KCM * merged presentwindows replacement by windowview * merged of a QML post of desktop grid * mr to kill the old present windows code, merged that one as well * all of those make a net of -4000 lines of code in kwin, should allow for much easier maintainance
Re: Soft Feature Freeze Tomorrow
after that, one thing that i would still do is queuing one to remove the old present windows effect, that at that point would become effectively dead code On Thu, May 5, 2022 at 5:58 PM David Edmundson wrote: > > https://invent.kde.org/plasma/kwin/-/merge_requests/2327 only has some > nits left. > > I'm happy to say we can land that as long as it goes in by the end of tomorrow
Monday meeting notes for 2/5/2022
Aleix * Attended the LinuxAppSummit, it was amazing to see some of you again!! * Looked into some xdgactivation_v1 report Please review: https://invent.kde.org/plasma/kwin/-/merge_requests/2302 * Virtual Outputs screen sharing Needs review https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/89 * Global Shortcuts We agreed that being able to suggest shortcuts from the start would be very desirable, I'm putting together a spec recommendation. WIP. Otherwise the proposal seems to be good to go. * Discover+Flatpak web flow To support payments on Flatpak remotes we need it, we need to integrate it closer in Discover's main window, needs doing. https://invent.kde.org/plasma/discover/-/merge_requests/272 * I think these are the most important topics right now * I merged the kglobalaccel changes for action disconnect, so that's usable from plasma 5.25 * https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers/-/merge_requests/11 < I also ported the remote controllers to kwin's fake input when uinput is not available Nate * We're down to only 6 VHI regression bugs in Plasma: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_name=VHI-priority%20Plasma%20regressions_id=2049834=VHI=Bluedevil=Breeze=Discover=drkonqi=frameworks-kirigami=frameworks-plasma=frameworks-qqc2-desktop-style=kactivitymanagerd=kde-gtk-config=kdeplasma-addons=khelpcenter=kinfocenter=klipper=kmenuedit=krunner=KScreen=kscreenlocker=ksmserver=ksysguard=KSystemLog=kwin=Plasma%20SDK=Plasma%20Vault=Plasma%20Workspace%20Wallpapers=plasma-integration=plasma-nm=plasma-pa=plasma-simplemenu=plasmashell=policykit-kde-agent-1=Powerdevil=print-manager=printer-applet=pulseaudio-qt=systemsettings=Touchpad-KCM=user-manager=xdg-desktop-portal-kde_based_on=VHI-priority%20Plasma%20regressions_format=advanced * that's great, and it would be good to get those down a bit more for Plasma 5.25 * two are about the screen locker, one for mouse settings getting lost, two wayland-specific regressions, and one issue with Kickoff's shortcut * any volunteers? Nico * I've mostly worked on porting apps to Qt6 * And adding CI to apps Kai Uwe plasma-systemmonitor: Filed two bugs about minor UI issues Wrote ColorGrid face plug-in, for people with many CPU cores: https://invent.kde.org/plasma/libksysguard/-/merge_requests/228 kscreenlocker: Add busy property to Authenticator to indicate that an auth process is still ongoing, https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/68 On networked systems it can take quite a while to unlock with currently no indication Other: Fixed bug in KFilePlacesView causing Qt Creator to crash accessing a null widget Fixed both KFilePlacesView to send a widget and Qt Creator to check if it is not null David R * I did a thing to assign key combinations to mouse buttons * if you have a gaming mouse with 100 buttons * https://invent.kde.org/plasma/kwin/-* more work on the open kwin merge requests from last week https://invent.kde.org/plasma/kwin/-/merge_requests/2267 https://invent.kde.org/plasma/kwin/-/merge_requests/2260 https://invent.kde.org/plasma/kwin/-/merge_requests/2279 * started a QML-only desktop grid effect to replace the old one/merge_requests/2312 * https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/920 Fusan * Fix a memory leak after changing wallpaper plugin, which is caused by KConfigLoader lacking a parent, other fixes are in the frameworks, but may also help reduce memory leaks in Plasma. * The two workaround MRs below greatly mitigates the memory leak in Plasma config window. As Kirigami.ApplicationItem still leaks, I think it's worth temporarily porting away from it in Plasma config window. Please give opinions. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1698 https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/922 Marco * more work on the open kwin merge requests from last week https://invent.kde.org/plasma/kwin/-/merge_requests/2267 https://invent.kde.org/plasma/kwin/-/merge_requests/2260 https://invent.kde.org/plasma/kwin/-/merge_requests/2279 * started a QML-only desktop grid effect to replace the old one
Re: Require passing unit tests
let's go for it at least p-w andplasma-integration and slowly aim for everywhere On Mon, Apr 11, 2022 at 11:10 AM David Edmundson wrote: > > There's a new flag we can set on CI to fail a job if unit tests fail. > https://www.volkerkrause.eu/2022/04/09/kde-ci-required-unit-tests.html > > Catching things as early as possible will unquestionably be a good thing. > > Realistically right now this is going to cause some merge failures as > we know some tests are flakey. It might act as good motivation to fix > them, it might just be annoying. > > https://build.kde.org/job/Plasma/view/Everything%20-%20kf5-qt5/ is a > good enough overview things either yellow or blue with a cloud will > probably be issues. > > Should we: > - apply everywhere? > - apply in a few safe places? -- Marco Martin
moday meeting notes for 11/4/2022
Alex * I have been doing mostly plasma-frameworks work regarding some KF6 stuff * The KPluginSelector QML component can hopefully be fnished this week (thanks to Nate for helping me with the QML parts) * The KWin port is close to finished [kbroulik: can it do sophisticated mutually exclusive options?] [alex: not yet, eventually] * I would appreciate feedback on https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/127#note_419403 on how to handle the different release cycle. (Feel free to give it a look after this meeting, nothing that needs to block the chat for now). Next, please :) Nico * Not much Plasma-y from me * I've been mostly working on Windows and Android stuff * Rolling out Gitlab CI for Windows and fixing some fallout * And working on a new Android CI image * Besides that I caught up on some older MRs from me next [Alex: I will give the KParts related stuff a review] Kai Uwe * some kwin build system stuff * fix dropping files from Ark into Places panel (will finish that tonight) David E * I have been working on revisiting wayland scaling * That's been both fractional scaling in Qt with some negotiation, trying some different approaches to see what actually works best with a lot of clients * I've also got a POC way of having xwayland clients not get resized without external changes * that gives us some user control * https://invent.kde.org/plasma/kwin/-/issues/86 has more details * there's lot of upstream threads * Also - I started a thread this morning on the ML * we have a path to make unit tests mandatory to pass on CI before a merge is allowed * We have a lot of broken tests * I feel if we just toggle the switch it'll cause some disruption, but maybe pay off long term [discussion seem to agree] * Just had a thought. If I go yolo mr MR to enable the tests will fail if there's a consistent problem in the tests - so it won't break everything on day 1 * last but not least - I did a cool minor visual thing: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/499 I see it all the time when I connect N bluetooth devices and it annoys me, so I'm pleased with this solution. Arjen * main thing I've been working on is supporting layershell for virtual keyboard panels, so we can change maliit to use layershell and that way get improved resize behaviour * there isn't much to show yet since it's been rather tricky to get working correctly Fabian * After the 5.24 release I saw several reports about settings getting "lost" after rebooting, is there anything known about that? * Apparently multi-monitor support "became worse" with 5.24 for some reason, with various different issues * I wonder what caused that, probably not a single change * Having that (possibly) fixed only in 5.25 is a bit annoying * Third question, originally reported by fusionfuture who hit https://libera.ems.host/_matrix/media/r0/download/kde.org/55521ca8b05eca05db0496a4e4d9a2577e024e7d/%E5%9B%BE%E7%89%87.png * It started very recently, I can reproduce locally * Happens sometimes, but of course neither in plasmawindowed or plasmoidviewer * Any changes in kirigami/qqc2-desktop-style/p-f/... which might've caused this? * There are some "implicitBackgroundWidth is not defined" warnings in plasmaextras/ListItem.qml, but they aren't new at least Marco * adapted to master Vlad's appview effect * investigating crashes on x11 and multimonitor, merged a part * more work on touchpad gestures for overview, merged * started ateempt to have cross fade again in scripted effects, so far only frustration :/
Monday meeting notes for 4/4/2022
Aleix * I'm more or less still working on the global shortcuts portal and sddm Arjen * nothing too major from my side, I did some work on virtual keyboard related stuff * including fixing some focus handling things in the network and clipboard applets * I did a change for qqc2-desktop-style that should reduce memory usage a little and (in my opinion) improves code readability * generally, I wish QObject::connect was a little cheaper on memory usage Nate * Lots of MR review and bug triage * Gave PlaceholderMessages throughout Plasma icons to go with their text * Made Task Manager icon spacing increase when in Tablet Mode with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/880. In conjunction with Marco's recent work to make Breeze widgets bigger in tablet mode, we have have a fairly complete UI scaling story for Tablet Mode! * Would appreciate review on https://invent.kde.org/plasma/plasma-nm/-/merge_requests/109, https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/491, and https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/473 * We still have 34 known unfixed regressions in Plasma 5.24: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=2023541=dupecount%20DESC%2Cchangeddate%20DESC%2Cbug_status%2Cpriority%2Cassigned_to%2Cbug_id_format=advanced=5.23.90=5.24.0=5.24.1=5.24.2=5.24.3=5.24.4 Marco # KWin * more work on and merged touch friendly changes for Overview * realtime touchpad gesture support for overview https://invent.kde.org/plasma/kwin/-/merge_requests/2196 # Breeze * more work for widgets enlarging on tablet mode, meged \o/
Monday meeting notes for 21/3/2022
Alex
* Taken care of the KQuickAddons::QtQuickSettings::init deprecation
(the code has been moved to the plasma integration plugin).
https://invent.kde.org/plasma/kwin/-/merge_requests/2166 Removes the
explicit call from KWin. I will go ahead with other Plasma usages
* unless anyone objects.
* Working on a KPluginWidget QML version, please give feedback on the
visualy: https://phabricator.kde.org/T15398
* Task 15398 "Create QML equivalent for KPluginWidget" [Open,Needs
Triage] {Frameworks,Plasma 6,VDG} https://phabricator.kde.org/T15398
* I will port the KWin Scripts KCM at first, because I took
inspiration from the Effects KCM :)
* https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/458
This is a pretty good optimization, but will lead to plugin filenames
being renamed. I would recommend devs to clean up the applets dir, to
make sure the correct plugins are loaded. Is a Mail on plasma-devel
good enought to inform everyone?
Aleix
* here's some of the things I've going on now, mostly those that can
use some feedback
* global shortcuts: still working on the spec proposal, slowly getting
closer to something we can use, feedback welcome:
https://github.com/flatpak/xdg-desktop-portal/pull/711
* sddm: working on it slowly but surely
* on unnecessary wallpaper load at startup:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1580
* xdp restore: of screencast streams
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/79
Kai Uwe
Plasma:
Fixed notification body size max line count
Fixed fallout from Plasmoid attached property porting in places
Looks like QML Connections {} doesn't work with attached properties?
Media controller now shows a tooltip over the slider with current
track position
KIO:
KFilePlacesView: Show free space as a permanent line (restore
Dolphin behavior), please review:
https://invent.kde.org/frameworks/kio/-/merge_requests/787
Dolphin:
Back/forward button context menu now shows pretty place names
Might be worth adding a utility method to KFilePlacesModel
since Notifications applet has similar code that turns e.g.
file://home/foo/Pictures/bar into Pictures/bar
KWin:
Removed unused Qt Quick Widgets dependency
With the removal of QtQuickSettings we could now get rid of
KDeclarative entirely (safe for KCMs)
Other:
Added NOTIFY declaration to priority property of QAction in Qt
(6.2/6.3 + KDE patch collection), fixing warnings printed by system
tray
Fixed print-manager applet not working in 22.04 Beta caused by
depending on newer unreleased plasma-framework (print-manager is not
part of Plasma!)
Fixed bug in Ark extract file item action using .path() instead of
.toLocalFile()
Vlad
* dropped the fbdev backend in kwin, use simpledrm+drm backend instead
* merged more render layer stuff, if you notice regressions, please
ping me in the kwin matrix channel
Arjen
* right
* I've mainly been working on some tablet mode related stuff
* First, a way of excluding certain devices from tablet mode detection
https://invent.kde.org/plasma/kwin/-/merge_requests/2111
* then I did a MR for breeze to change button sizes based on tablet
mode: https://invent.kde.org/plasma/breeze/-/merge_requests/200
* I also have two bugfix mrs for KWin that I would be nice to have
some movement on:
https://invent.kde.org/plasma/kwin/-/merge_requests/2086
* and https://invent.kde.org/plasma/kwin/-/merge_requests/2106
Nico
* I started to look at some of the failing unit tests on Windows
A lot of them fail because we use XDG_DATA_DIRS to find test data,
which of course doesn't work on windows
e.g. https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/114
* Added KRunner integration in NeoChat:
https://invent.kde.org/network/neochat/-/merge_requests/430
* Made an optimization in KWin to not reload decoration colors all the
time: https://invent.kde.org/plasma/kwin/-/merge_requests/2146
* Ported the printer KCM to QML:
https://invent.kde.org/utilities/print-manager/-/merge_requests/21
Marco
# KScreen
* backported touchscreen alignment patch to 5.24
# Wayland
* more investigation on the popup issue, is an upstream wayland issue
now https://gitlab.freedesktop.org/wayland/wayland/-/issues/280
* more work on realtime screen edges gestures, rebased on top of the
touchpad gestures refactor by a new contributor
* adressing comments on the mr, fixed tests regreessions, shold be
good to go now
Monday meeting notes for 14/3/2022
Nate * Not gonna list what I did cuz it's boring, so instead I'll just poke people to work in 5.24 regressions. :) https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=2003087_format=advanced=5.23.90=5.24.0=5.24.1=5.24.2=5.24.3 * that's all from me Nico * Some Plasma things to be reviewed: * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1504 * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1503 Arjen * I think the most major thing I worked on last week is to have a way for kwin to ignore devices when trying to determine whether we are in tablet mode or not * my initial approach was using an env var but zzag suggested using udev tags instead * see https://invent.kde.org/plasma/kwin/-/merge_requests/2111 * unfortunately I think fixing the root cause is basically impossible since you'd not only need to fix libinput/kernel to report the devices properly, but you also need the devices to report themselves properly * anyway, other than that I did some smaller things kwin/plasma related oh and the new keyboard animation in kwin was merged, I wonder how well that works on plasma mobile Kai Uwe (also includes stuff from last week as there was no meeting adjacent to the Plasma sprint) KF6 Stuff: Removed unused references to KConcatenateRowsProxyModel in Discover Ported Kicker to QConcatenateTablesProxyModel Did not port notifications yet as I recall there was a bug in the model which might only have been fixed in Qt 5.15.4 Might do an ifdef port instead for Qt 6 to unblock build Found a bunch of regressions in (lib)ksysguard caused by porting away form deprecated stuff, plug-ins (network and nvidia data source) didn't have a parent anymore causing crashes the filter box is broken in System Monitor because of setFilterRegularExpression not setting filter fixed string (not sure if Nico fixed that or we just talked about it) Fixed fallout from porting to Plasmoid attached property in Notifications plasmoid Uncovered a few bits that weren't well-engineered :) Battery Monitor: Only shows charge limit for power supply batteries now Notifications: Tooltip now shows basic job info, e.g. "Copying (50%)" instead of just "1 running job" Use popupWidth for thmbnail size, avoids needless re-requsting of thumbnails, please review https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1560 Other Plasma: Fixed icon KCM icon size popup size, ItemDelegate without a text seems to be less tall nowadays than when it has text Klipper plasmoid now remembers last used barcode type Allow non-file "recent documents" in Task Manager, please review https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/551 KWin: Fixed a crash in layer rendering on screen resolution change KNotifications is now optional Dropped some more dependencies Now has a dedicated GitLab CI run with minimal build configuration to catch future changes that will use build-time optional stuff unconditionally Caused some test failures, will follow up on that later this week Frameworks: Add Ctrl+Tab to KPageView (e.g. multi-page KCMs, file properties dialog), https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1531 I recall there having been a massive bikeshed about the fact that we use this awkward Ctrl+PgDn rather than Ctrl+Tab but I cannot find it anymore. So can we change the default shortcut for NextTab to this? Ark: Sped up Dolphin context menu by caching the check for whether libarchive was build with Lzo which was super duper slow Added a MIME type for ASAR (Electron) archives to shared-mime-info Worked on an Ark backend for reading those, can already extract individual files but unfortunately quite a lot of boilerplate logic (e.g. overwrite/skip handling) is needed in every plug-in Jonathan * we've not had a kickoff meeting * I assume that's not needed? * https://community.kde.org/Schedules/Plasma_5 are we sticking to the 5.25 schedule? David E * we have GSOC coming * there's some tasks on the wiki * as discussed last sprint * someone was asking about the KCM porting one on here this morning Marco * more investigating the popup menus issue under wayland (activating an item by pressing rmb, going over button, release), what seemed a minor issue ended up being a combined issue between KWin, Qt and wayland protocol not being clear, have some patches half ready, needs to be cleared up at protocol level first (see https://gitlab.freedesktop.org/wayland/wayland/-/issues/280) * looking into realtime gestures for screen edges, to make them actually look good, results are encoraging and the visual result "it's gorgeous"(tm)
Monday meeting notes for 21/2/2022
Nate * Not much to say other than an urging to work on 5.24 regressions: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=1984326_format=advanced=5.23.90=5.24.0=5.24.1 Nico * Add support for mime globs in KFileWidget filters and KCoreDirLister: https://invent.kde.org/frameworks/kio/-/merge_requests/766 * Port dragging in quicklaunch applet to Qt DnD: https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/119 * Fix emitting result in KEmailClientLauncherJob: https://invent.kde.org/frameworks/kio/-/merge_requests/764 * Show paths instead of URLs in KMail's attachment warning: https://invent.kde.org/pim/kmail/-/merge_requests/59 * Properly propagate some error messages in KIO: https://invent.kde.org/frameworks/kio/-/merge_requests/762 * tweak bluedevil wizard so it fits on the pinephone screen: https://invent.kde.org/plasma/bluedevil/-/merge_requests/74 * Besides that I've been looking into 5.24 bugs * There is one that leaves me puzzled * plasma-nm doesn't load secrets: https://bugs.kde.org/show_bug.cgi?id=449984 * KDE bug 449984 in plasma-nm (general) "Plasma 5.24.0 NetworkManager cannot get secrets using DBus" [major,] https://bugs.kde.org/show_bug.cgi?id=449984 * this time for non-systemd boot https://bugs.kde.org/show_bug.cgi?id=449828 * I bisected it to a change in startplasma Arjen * so main thing I did was to finish up a MR to add support for showing/hiding the virtual keyboard to KWin's sliding popups effect * it works quite well actually https://invent.kde.org/plasma/kwin/-/merge_requests/2035 Aaron * https://invent.kde.org/pim/kalendar/-/issues/161 <-- kalendar does not show event titles with HTML-ish things in them correctly [davidre] Do we wanna do to HtmlEscaped on the string or change the text style? https://doc.qt.io/qt-5/qml-qtquick-text.html#textFormat-prop [aseigo] David Redondo: html escaped is the solution i went for there. but it ends up being every place it is used * in kalendar this is complicated by the fact that it wraps the text in tags to get styling * basically -> text should be shown *literally as contained in the string*, full stop, no interp * an interesting solution i've seen in the Broad World is to *always* escpae *all* content unless it is wrapped in a "this is safe" container. that's obviously a breaking change for plasma (and qml) at this point, but something to consider. Aleix On moving away from X11 I have patches for both X11 to work and for xdg-desktop-portals (https://github.com/flatpak/xdg-desktop-portal/pull/711). Feedback welcome. Scaling (https://invent.kde.org/plasma/kwin/-/merge_requests/1959), which is stuck as much as it was before my PR, need good ideas to move scaling forward for x11 clients. On Kirigami/QQC2 event mayhem as reported by nicofe There is https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/130 which should bring some peace there. Also https://invent.kde.org/frameworks/kirigami/-/merge_requests/501 Reviews very welcome. I need reviews on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1458 https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/75 @kbroulik: https://invent.kde.org/frameworks/solid/-/merge_requests/70 Otherwise, been focusing on stability in general. Kai Uwe Spent last week at work hacking on KWin, fixing build with reduced feature-set all over it and its dependencies, and shedding some. Please review: * https://invent.kde.org/plasma/kwin/-/merge_requests/2039 (Allow disabling screenlocker build) * https://invent.kde.org/plasma/kwin/-/merge_requests/2040 (Port effectframe to offscreenquickview) Marco * fixed an ui glitch in the users kcm https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1454 * more work on the multiscreen refactor * a fix for the panel keyboard navigation to ensure plasmoids are focused on the expected order https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1466
Spring on 5-6 of March
also discussed during the meeting this seems the latest agreement for the sprint. is it ok for everybody? i would make this date final -- Marco Martin
5.25 kickoff meeting
during the meeting today it was proposed to do it together in the sprint, is it ok for everybody?
Monday meeting notes for 14/02/2022
During the meeting has also been talked about doing the sprint on 5-6 march and doing the kickoff meeting together the sprint itself Nico * Mostly post-5.24 bug squashing * Fix application launcher containment action: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1445 * Fix pressing Esc in kscreen KCM: https://invent.kde.org/plasma/kscreen/-/merge_requests/83 * Fix some apps not opening when lauched by kwin: https://invent.kde.org/plasma/kwin/-/merge_requests/2003 * Fix QDesktopServices not working in KWin: https://invent.kde.org/plasma/kwin/-/merge_requests/2005 * Fix screensharing dialog when no types are passed: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/72 * Mark internal copyjob in KParts as transient: https://invent.kde.org/frameworks/kparts/-/merge_requests/38 * Add fancy finished notification to Ark compress action: https://invent.kde.org/utilities/ark/-/merge_requests/99 Kai Uwe KInfoCenter: Make details in About Distro selectable: https://invent.kde.org/plasma/kinfocenter/-/merge_requests/83 plasma-browser-integration: Only list tabs from "normal" windows: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/65 KWin: Fixed i18n for Overlay effect, there was no Messages.sh and I believe i18n also only works by accident (being pulled in implicitly by some plasma import) Fixed build without tabbox and Qt session manager Working on porting stuff away from QmlObjectSharedEngine allows to drop dependency on KDeclarative (outside of KCMs) Working on porting effects away from EffectFrame, to eventually get rid of it showfps, desktopgrid, presentwindows, mouseclick and subsequently drop build dependency on plasma-framework KIO: An assortment of fixes to KFilePlacesView, still open: Consider section header for drop highlight: https://invent.kde.org/frameworks/kio/-/merge_requests/733 Improve outcome of dropped places: https://invent.kde.org/frameworks/kio/-/merge_requests/734 Other: Fixed QIcon::paint not selecting the proper high-dpi pixmap, QPainter::drawPixmap would Support high-dpi in KOverlayIconEngine, please review: https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/43 Nate * Made some Plasma fixes, helped with the release. Thanks everyone for fixing bugs! Here's the list of remaining 5.24 regressions: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=1979546_format=advanced=5.23.90=5.24.0 * many more now * after normal people update, they always find more stuff we missed during the beta period Vlad * For the past week or so, I've been on bugfixing * After .1-.2, I plan to spend a good portion of my time on layered compositing. Both Xaver and I looking into it * Merged support for xdg_toplevel.configure_bounds in kwin Arjen * I've been digging into kwin effects in an effort to have kwin perform the virtual keyboard show/hide animation * vlad suggested to reuse the slidingpopups effect, I now have a working version there that still has a few caveats * it's mostly that there's some offset calculation that happens at the wrong time * and I haven't figured out the right trigger yet for starting the animation * so currently if you tap on a text field that is already focused, part of the animation happens again Marco * More work on the ScreenPool refactoring and autotesting * Merged accounting of unknown screens for the reordering ui * fixed an ui glitch in the users kcm https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1454
Re: Plasma sprint doodle
On venerdì 11 febbraio 2022 01:26:26 CET Aleix Pol wrote: > We should wrap this as the dates are getting near. > > Should we do March 5th and 6th? +1 -- Marco Martin
Monday meeting notes from 7/2/2022
Nico * Don't crash plasma-integration on invalid color scheme setting: https://invent.kde.org/plasma/plasma-integration/-/merge_requests/34 * Set proper name in desktop file for keditfiletype: https://invent.kde.org/plasma/kde-cli-tools/-/merge_requests/33 * Work around a quirk in macOS in kidletime: https://invent.kde.org/frameworks/kidletime/-/merge_requests/15 * Fix font change notification in qqc2-desktop-style/qqc2-breeze-style: https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/124 * perf optimization in qqc2-desktop-style/qqc2-breeze-style: https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/125 * Fix opening files on remote shares in Dolphin: https://invent.kde.org/system/dolphin/-/merge_requests/343 * A question would be whether to backport the perf improvements in qqc2-breeze-style to 5.24 * They are not strictly bug fixess * But perf improvements are very welcome on mobile [ Discussion seems to say yes go ahead] Nate * Did some MRs and lots of bug triage and minor bugfixes for Plasma 5.24 * we have 6 regressions left, if folks wanna have a look: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=1974758_format=advanced=5.23.90 Arjen * I did some system monitor bugfixing * and also apparently broke a few things in kirigami with the qmlmodule port * mostly because of random path issues * I'm now working on an ecm module that helps with writing qml unit tests, including having a function that adds a very simple instantiation test for a number of items * so that we can quickly verify that "public" qml items still work Fabian * There's this discover ocs topic... * The URL changes we have in 5.24 are at best a workaround, and probably won't hit the actually affected systems soon [apol well I know Ben is angry, I saw taht indeed there were some providers that were not hitting the cache and Ben addressed that] [apol I see there's a whole lot of people using unattended updates which is fairly new and is having an impact there, the changes we are merging today should have an impact] [apol I should look at how it scales for people with a lot of KNS resources that need updating on each run too] [fvogt Would be great if someone could reproduce the issue locally somehow If it's actually really a bug and not just missing optimization] [nicofee There was a discussion about high requests for the providers a while ago, but it seems to have exploded the last two? days Any idea why that could be?] [apol maybe a distro enabled unattended updates by default?] [fvogt I suspect that there's some loop with the updater, e.g. there's an update which fails to download, so it tries in a loop] Marco # Plasma * investigated into https://bugs.kde.org/show_bug.cgi?id=448609 : It is clearly *not* a regreession but something that always happened even in kde4 times every single time the appletsrc file is deleted. All it can be done is a workaround in doing a cleanup of old actions every time plasma starts from the default layout, tough all kglobalaccess api that could do such manipulation is deprecated * A small fix on kcms which have an header (merged): https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/110 * Helping a bit on the power kcm * Final work on the panel keyboard navigation mrs and now all merged \o/ * More work on the plasmashell ScreenPool refactor * please review: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1400 * Now ShellCorona is ported ScreenPool as its single source of truth about what screens are available, and primarychanges. Concepts like fake screens or redundant screens are completely hidden from corona. a redundant screen is like it doesn't exists at all for corona * now has a fully working wayland based autotest for ScreenPool work/mart/screenPoolLogicWaylandTest, 14 tests so far which should be quite exaustive (maybe some day will be possible autotest a shellcorona instance itself, even tough that looks even more complicated) * Since is a lot of code copy from Qt's QWayland autotests, i am not completely sure on what to do with that, both on a licensing pow (gpl3 only but since is just in an autotest should be fine) and on a code reusing pow (also, uses some private qplatform api) . perhaps a library exported from kwayland-server?
Monday meeting notes for 31/1/2022
Fabian * Move the wayland socket polling to a separate event thread https://invent.kde.org/qt/qt/qtwayland/-/merge_requests/24 in advance Nico * Dolphin: Improve placeholder message for unassigned tags: https://invent.kde.org/system/dolphin/-/merge_requests/333 * Fix filtering in Open With dialog: https://invent.kde.org/frameworks/kio/-/merge_requests/739 [kopenwithdialog] Fix filtering (!739) · Merge requests · Fram * Fix touchpad applet not updating: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/826 * Optimize Gwenview a bit: https://invent.kde.org/graphics/gwenview/-/merge_requests/133 * Optimize Ruqola a lot: https://invent.kde.org/network/ruqola/-/merge_requests/71 Nate * So https://invent.kde.org/qt/qt/qtwayland/-/merge_requests/24 caused regressions for Intel GPU users. Fedora is already reverting it. Seems like it needs a hotfix, since simply reverting it will regress everything for NVIDIA GPU users. [bshah: It also needs hotfix for Plasma Mobile partially unrelated but still https://invent.kde.org/plasma/kactivitymanagerd/-/commit/66ea663e5d8f07a297490dc53d6198b180475612 is needed otherwise plasma mobile doesn't have working shell (and yes that commit have absolutely no relationship whatsoever with qtwayland but still it fixes things) not committedin master] [fvogt: zzag has a potential fix, but not really production-ready] [apol: I'm not sure why this is so much more of a problem for plasma mobile than it is for the desktop, but I can easily see this hitting the desktop as well] * Other than that we are pretty good on the Plasma 5.24 front. We're down to only 7 known regressions: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_id=1971077_format=advanced=5.23.90 * Let's prioritize these in the next week to make the final release as strong as possible. [discussion about the wrong notification position bug and missing greeter] Arjen * I chased down and fixed a whole bunch of system monitor bugs last week * which were piling up a bit high, including some pretty big regressiosn * I was rather annoyed by the fact that every applet got changed from metadata.desktop to metadata.json but apparently no effort was put in verifying that this broke anything since that caused all system monitor presets to break Aleix Stability work towards Plasma 5.24 SDDM, again please test the develop branch PineNote Proof: https://i.imgur.com/Zibc2W6.jpg PoC: https://invent.kde.org/apol/plasma-ink #plasma-ink:kde.org Kai Uwe Not much Plasma, worked mostly on ironing out bugs in KFilePlacesView surfaced by its higher exposure in Dolphin, got a tonne of recent MRs still open, please have a look: https://invent.kde.org/dashboard/merge_requests?scope=all=opened_username=broulik KGuiAddons: Implement high-dpi support in KOverlayIconEngine: https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/43 KIO: Unset active/selected state for drag pixmap to make the drop target more visible: https://invent.kde.org/frameworks/kio/-/merge_requests/726 I tried Nate's "make room for drop" idea but we all know how fancy stuff like that goes in Qt item views … Use KMessageWidget for error reporting in KFileWidget – it's much nicer Found a hack around the drop bug I mentioned last time, not very pretty: https://invent.kde.org/frameworks/kio/-/merge_requests/735 An assortment of various bug fixes to KFilePlacesView Dolphin: Added a image dimensions (width x height) role, was there in KDE 4, must have gotten lost in the port to Baloo Found a way to avoid the double "Places" header when unlocking panels (ancient bug report) Solid: Skips "might be optical" check for "loop" devices On my system with ~30 snaps, this saves me 100ms startup time on Dolphin Had a look at porting Solid to DBus ObjectManager again This way we can get _all_ device properties at once instead of issuing a tonne of DBus requests on startup, one for each device Got a working prototype but again stuck on all this optical media madness :-( Marco * More work on the panel keyboard navigation ** https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/641 ** https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1143 ** https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/439 ** https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/107 * Small fix/workaround for systemmonitor plasmodis on touchscreen (merged) * On the reorder ui list any containment that has a screen that lost all its mappings https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1400 * started a refactor to move some of the logic of ShellCorona on management of screen added/removed/primary change over to ScreenPool, added a small screenpool manual test, plan is to have both that and a more expanded autotest (idea is a minimal wayland server that adds/removes/moves screens)
Plasma sprint doodle
Hi all, Here is a doodle with a bunch of dates to plan the sprint https://doodle.com/poll/nvdyzp979y8dvfyd?utm_source=poll_medium=link -- Marco Martin
Monday meeting notes for 24/1/2022
Jonathan * beta is out, beta testing day is done * please fix bugs * is there any progress on answering the lts question? [discussion recap: lts now means we can't do the "last plasma release" for 2 years, which is a quite realistinc timeframe anyways, so decision is: let's do an lts-lite that can last less than 2 years] [Discussion will continue on ML] Arjen * so I finally merged a set of patches that have been around for a while so we don't set default focus for a number of things if that would show a virtual keyboard * I also did a few small patches during the bug day last thursday to fix some "vhi regression" bugs * other than that, there was some discussion on the ml about doing a virtual sprint february or march, were there any more concrete plans there? [Discussion: needs doodle] [apol: I guess it could also make sense to discuss which topics we need to go through] [nico: I'd suggest that we collect topics on the ML in advance] [apol: maybe we can have an invent issue] [invent issue it is] [d_ed: one thing we need to do, potentially at a sprint, is tag things as "this is an interesting idea we could do" vs "this has to happen by 6.0"] Bhushan * So I've been trying to debug the weird plasma mobile issue where plasmashell fails to connect to kactivitymanagerd and then doesn't show anything. * Some people say it is happening after recent qtwayland update * But weirdly enough disabling systemd boot also makes it work * I'm continuing to debug it today [d_ed will look into it as it seems systemd-related] Nate * So I have been doing a lot of bug triaging for the Plasma 5.24 beta and we're in a pretty good shape. *We're down to only 6 issues in the "VHI regressions" list: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=regression%2C%20_type=allwords_name=VHI-priority%20Plasma%20regressions_id=1967106=VHI=Bluedevil=Breeze=Discover=drkonqi=frameworks-kirigami=frameworks-plasma=frameworks-qqc2-desktop-style=kactivitymanagerd=kde-gtk-config=kdeplasma-addons=khelpcenter=kinfocenter=klipper=kmenuedit=krunner=KScreen=kscreenlocker=ksmserver=ksysguard=KSystemLog=kwin=Plasma%20SDK=Plasma%20Vault=Plasma%20Workspace%20Wallpapers=plasma-integration=plasma-nm=plasma-pa=plasma-simplemenu=plasmashell=policykit-kde-agent-1=Powerdevil=print-manager=printer-applet=pulseaudio-qt=systemsettings=Touchpad-KCM=user-manager=xdg-desktop-portal-kde_based_on=VHI-priority%20Plasma%20regressions_format=advanced [d_ed will take 448475] [marco will take 370676] Aleix: * maybe most useful to comment is sddm. I'd encourage anyone who can to test the develop branch * we'd like to get a release out so we can work on simplifying some parts of the codebase and given how important a component it is, it would be useful * I'm aware there's some important pending PRs, we're trying to go through them but it's also a delicate beast in itself * testing these MRs on the different use-cases we might have would also make it easier for reviewers * other than that, I've been working on Discover and video recording on wayland, not much to comment on that though Kai Uwe Dolphin/KIO: Tab bar now accepts drop only ontop of a tab (denied cursor on blank space) Fix for janky show/hide animation in KFilePlacesView, please review: https://invent.kde.org/frameworks/kio/-/merge_requests/725 "Details" tab from Baloo-widgets is now only shown when it actually has some details (it doesn't fetch them for remote locations) Did some investigation as to why KFilePlacesView drop on place is broken (cf. last week's notes), Qt ignore()s the event and subsequently runs into the fallback of calling dropMimeData to add the place to the model https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/qlistview.cpp?h=5.15#n963 No idea what the right fix would be here. Just not calling into the superclass in this case also wreaks all sorts of havoc to the view's internal state. And doing a check for that special case in KFilePlacesModel doesn't work as dropMimeData doesn't get the QEvent, just the QMimeData within. And adding a special mime type is also ugly because the QMimeData in the QEvent we get is const … whatever I try :-( Plasma: Fixed regression in Bluetooth applet breaking the big "Enable" button when it's off Other: Noticed a breakage in SDDM in neon, identical to https://bugs.kde.org/show_bug.cgi?id=441080 – no idea why and how Nico * Fixed task manager identification for some XWayland apps, e.g. Chrome webapps https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1396 * which requires extending the plasmawindowmanagement protocol, so lots of accompaning MRs * Besides that I ported some things to the new ecm_add_qml_module * I made patches to show pairing notifications for bluetooth and KDE Connect even when in Do not Disturb, because those require user interaction * https://invent.kde.org/plasma/bluedevil/-/merge_requests/71 *
Re: Request for help for developing new XDG StatusNotifier/AppIndicator spec for KDE+GNOME
On lunedì 17 gennaio 2022 22:16:12 CET Neal Gompa wrote: > The new specification development has been kicked off with an issue on > the xdg-specs repository: > https://gitlab.freedesktop.org/xdg/xdg-specs/-/issues/84 Modernizing the spec to be usable in sandboxed apps would be a thing i'm intersted in.. (original spec dates as back as 2009 btw so yeah, they really weren't a thing back then) On the KDE side I'm wondering what would be the best approach, we would probably have to migrate both the semi-deprecated kstatusnotifieritem in knotifications and qdbussystemtray upstream in Qt -- Marco Martin
Next monday Plasma meeting will be 16:00 CET
Or 15:00 UTC -- Marco Martin
New Monday meeting timeframe
Hi all, here is the doodle poll for a new time for the monday meeting: https://doodle.com/poll/s4ycfqwhua99a7h6?utm_source=poll_medium=link for now the winner seems either at 15:00 or 16:00 Europe time overlap not exact for Nate and Fabian) So in the end should be done between one of those two times -- Marco Martin
Monday meeting notes for 17/1/2022
Kai Uwe
KWin:
Now takes into accont GTK_APPLICATION_ID property for desktop file
name on X11, too
Dolphin/KIO:
Dolphin port to KFilePlacesView has been merged \o/ what's left to be done
Fix free space bar (I will use a custom painted rectangle like
Dolphin had instead of a KCapacityBar as it just does not fit in the
constrained space we have)
There is an odd drag and drop issue, which seems to be a Qt
bug. When dropping a folder onto a folder in Places, it still adds it
to the model ("fallback" in Qt), despite it having accepted the
dropevent (in KFilePlacesView), I don't understand why
KIconLoader bugs:
picks wrong high dpi icon for non-matching size (if you
request 16@2x you get 16@2x but if you request 17@2x you get 32@1x),
visible during transition
overlay painter disregards screen scaling
Some other minor cleanup and performance work, maybe
Other:
Fixed Plasma Firewall showing busy indicator ontop of "no
connections" on Connections page
Fixed blurry printer list on high-dpi in print-manager
https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/qabstractitemview.cpp?h=5.15#n2123
in QAbstractItemView::dropEvent it checks dropOn which does if
(event->isAccepted()) return false and in
https://invent.kde.org/frameworks/kio/-/blob/master/src/filewidgets/kfileplacesview.cpp#L1275
it does event->acceptProposedAction();
so I don't see why it would still add it
Fabian
* https://invent.kde.org/qt/qt/qtwayland/-/merge_requests/24 (nvidia
gbm improvements) looks like it's mergable
* Regarding the beta, there was one regression in kcm_keyboard
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/797
* I wonder how that wasn't noticed earlier, but fixing that was simple at least
* Then there's the issue with kickoff favorites no longer being distro
configurable, which RikMills also hit today
* That's a fresh 5.23.5 regression:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/793
(mainly the discussion, not the MR itself)
* From a downstream perspective, the 5.24 beta looks fine so far, I'll
submit the packages after giving it a final test run
* Are there any other rather annoying beta issues which got fixed
meanwhile or have pending fixes?
[nicofee]: yes
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1368
[MartinR]: There was also that SDDM issue (background changed from PNG
to JPG, I believe)
[fvogt]: Right, the one that was fixed before anyone actually hit it :D
Jonathan
* I released plasma 5.24 beta
* no major issues
* promo seem to be working on the final announce and video, if anyone
has input do talk to them
* we have a testing day pencilled in for thursday
* I'm busy until 11GMT and after 1700GMT that day but could help
between those hours
* I'd need a list of distos with packages and how to install them I think
* then publicise it
(Jonathan and Marco will run a small one between 11 and 17)
Carl
Kirigami
Ensure OverlayDrawer handles is keyboard navigable
https://invent.kde.org/frameworks/kirigami/-/merge_requests/473 (to
review)
TreeView LRT support + api doc
https://invent.kde.org/libraries/kirigami-addons/-/merge_requests/25
(merged)
SearchField improvements:
https://invent.kde.org/frameworks/kirigami/-/merge_requests/469
(merged)
SearchField code cleanup:
https://invent.kde.org/frameworks/kirigami/-/merge_requests/470
Plasma
ActionTextField/SearchField/PaswordField plasma components:
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/426
(to review)
Related SearchField port:
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/795 (to
review)
Fix scrollview in battery applet not taking the entire view:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1350
(to review)
Various other fixes for Plasma applets and their ScrollViews
Others
Started working on Okular Mobile navigation improvements:
https://invent.kde.org/graphics/okular/-/merge_requests/542
Nico:
* Add desktop file for window rules dialog:
https://invent.kde.org/plasma/kwin/-/merge_requests/1853
* set desktop file name for theme explorer:
https://invent.kde.org/plasma/plasma-sdk/-/merge_requests/29
* set desktop file name for xdg-desktop-portal-kde:
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/60
* set desktop file name for some akonadi resources:
https://invent.kde.org/pim/kdepim-runtime/-/merge_requests/69
* Optimize Breeze a bit:
https://invent.kde.org/plasma/breeze/-/merge_requests/171
* Optimize KMail: https://invent.kde.org/pim/messagelib/-/merge_requests/78
* Optimize previewjob a bit:
https://invent.kde.org/frameworks/kio/-/merge_requests/710
* Make printing in Okular not block the UI:
https://invent.kde.org/graphics/okular/-/merge_requests/540
* Unbreak screencast dialog:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1368
Marco
* merged fixes for multi monitor: less plasma crashes (the
Re: Can we move the Monday Plasma meeting to a later time?
The most likely based on the doodle is Monday from 16 to 17 Europe time. I guess we can move it there starting from the next On Wed, Dec 8, 2021 at 7:05 PM Nate Graham wrote: > > Currently the Monday Plasma meeting is held at 3 or 4 AM for people in > the Americas, which is not a very convenient time for them to be able to > participate. > > Could we consider moving it to a few hours later? > > Nate
Re: Plasma 6 Kickoff sprint
On giovedì 13 gennaio 2022 23:13:11 CET Nicolas Fella wrote: > Therefore I'd suggest we have a Plasma 6 Kickoff Sprint (pun intended) > sometime soon. Date and everything to be discussed. Given _vaguely > gestures at everything_ I don't see us doing a physical one though, sadly. Yeah I can see definitely a virtual one in the February/March timeframe. a phisical one is probably not going to happen, as the pandemic situation is again horrible across all Europe -- Marco Martin
Re: Next Plasma LTS?
On Mon, Jan 10, 2022 at 12:52 PM David Edmundson wrote: > An LTS now effectively means we can't start Plasma 6 for another year. > I personally think that's too late we're at a point where some people > are building certain plasma repos against Qt6 already. > > I can envision Plasma 5.25 being the last before branching. That would be nice, tough i can see perhaps one or two more. but good point for not having an lts now. -- Marco Martin
Next Plasma LTS?
as said in the meeting notes, there is a request from Opensuse and Kubuntu to do a new Plasma LTS release. Optimal for them would be 5.24, but a potential problem is that is a quite feature heavy release, so it may be too buggy for an lts. Opinions? ideas? do we go with 5.24? 5.25? or not lts anymore until the last kf5 based relase? (which may be too far ahead in the future) -- Marco Martin
Monday Meeting notes for 10/1/2022
MartinR * Picking up a question from Jonathan Esk-Riddell : how do dev's feel about making 5.24 an LTS release? There's interest from Kubuntu and Opensuse (potentially) [ahiemstra] didn't we conclude last time it didn't really make sense to do an lts until the last plasma 5 release? [kbroulik] I am kinda inclined to want a new LTS but on the other hand 5.24 is coming out soon™ and we havent really done the usual LTS polish and imho there#s quite a bunch of bugs in 5.24 right now introduced recently [notmart] maybe 5.25? * Topic for mailinglist: LTS? When? 5.24? 5.25? Kai Uwe Worked on porting Dolphin back to using KFilePlacesView and dropping its custom places view code: Just over 4,000 lines of code removed: https://blog.broulik.de/ 2022/01/reunited-after-a-decade/ API additions made to KFilePlacesView (refactored menu, custom teardown handling, redesigned context menu, etc) have been merged Dolphin MR is still pending, but mostly because I'm waiting for CI to catch up, please test: https://invent.kde.org/system/dolphin/-/merge_requests/ 309 Now looking after various bugs and glitches unearthed by this port as well as some feature work: Add inline eject button (always feels great to close bug reports in the 1xx range :), please review: https://invent.kde.org/frameworks/kio/-/ merge_requests/697 Don't highlight delegates when hovering the section header, needs some more work (Qt is too clever an doesn't repaint) Don't hide all places when clicking one, please review: https:// invent.kde.org/frameworks/kio/-/merge_requests/699 Free space bar, will probably port away from KCapacityBar on hover to a permanent, custom painted rectangle like in Dolphin (MR tbd) Tweak the spacing, please have a look: https://invent.kde.org/ frameworks/kio/-/merge_requests/701 Solid: Now checks Bluteooth battery for any not recognized battery type rather than just explicit "unknown" This way we will at least recognize new UPower types (e.g. "headset") as Battery Now ignores partitions with x-gdu.hide option Notifications: Tried to investigate notification popup size glitch, haven't found anything yet, suspecting the reworked critical notification bar thing… Other: Component chooser is now able to configure the default handler for tel:/ URLs, e.g. whether those should be sent to your phone through KDE Connect or called in some dialer app Use file name in archive rather than /tmp/ark... in Ark previewer: https://invent.kde.org/utilities/ark/-/merge_requests/91 Regressions: My sddm-greeter crashes (SIGTERM) when I type a wrong password on the login prompt for the past few weeks. Plasma crashes when (un)plugging HDMI as a result of that "destroy method on containment view" Battery monitor switching compact rep for battery vs brightness mode doesn't work and would lose features such as mouse wheel for battery change Marco: * very little, just back from vacations * merged fixes for multi monitor: less plasma crashes (the hdmi unplug issue) and now we don't have anymore a containment-less situation after disconnecting everything and reconnecting (which only a plasma restart can solve) -- Marco Martin
Monday meeting meeting notes for 20/12/2021
Nico * I did lot's of task manager related stuff * Fix desktop entry for gwenview-importer so it shows up correctly there: https://invent.kde.org/graphics/gwenview/-/merge_requests/126 * Fix desktop entry for kcmshell: https://invent.kde.org/plasma/kde-cli-tools/-/merge_requests/25 * Add a new role to the model for whether launching a new instance is possible: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1290 * Fix matching services with NoDisplay=true: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1288 * Fix matching services with NoDisplay=true: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1288 * Don't offer launching new instances of tasks with nodisplay=true: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1289 * Better autotest for desktop file mapping logic: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1297 * Remove some presumed dead code: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1299 * That's it for TM stuff * Besides that fix private browsing in webshortcuts runner: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1300 BPort * From my side I created oxygen-sounds repository, for the split * ANd still on panel keyboard navigation Carl * Not much from my side, mostly Plasma Mobile apps related: * Adapt Neochat settings to new plasma settings style: https://invent.kde.org/network/neochat/-/merge_requests/386 * Add some unit tests in Koko * Try to improve the kirigami settings page header: https://invent.kde.org/frameworks/kirigami/-/merge_requests/442 * And a blog post about all the new plasma mobile app I'm working on https://carlschwan.eu/2021/12/18/more-kde-apps/ MartinR * at some point not too far in the distance I think it would be good to check with Distributions if there's an interest in 5.24 being an LTS version. I think Kubuntu and openSuse voiced some interest. openSuse latest "Leap" release is still on 5.18, though a much newer Plasma was already out at that time, so they might want an LTS version for Leap Kai Uwe Notifications: Stat and fetch jobs are now "transient" and don't show up in history anymore e.g. "loading archive" Support notification-icons hint, pending spec discussion, cf. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1272 PowerDevil: Fixed power button not working after tablet mode changes Dolphin: Ported it back to KFilePlacesView, please review: https://invent.kde.org/frameworks/kio/-/merge_requests/670 https://invent.kde.org/system/dolphin/-/merge_requests/309 Other: Fixed global menu translations Show toolbar delayed popup actions in context menu, please review: https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/86 Fixed glitch in KMessageWidget appearing Fixed glitch in KSplash theme especially the KFilePlacesView one, not really Plasma, but still massive and useful… removes 4000 loc also thx for d_ed for finding a memleak in notifications Fvogt * I'm currently looking at some kcm_keyboard bugs * The kconfigxt port caused some regressions, and there are some bugs on top * https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/757 Marco * not much, but I've finally merged the first little stage of multiscreen refactor for plasmashell that even if still not perfect, should make less easy to "lose" panels or desktops when fiddling with multiscreen
monday meeting notes from 22/11/2021
Alex * Reworking the KDeclarative ConfigPropertyMap API, also moving the QML bindings to the respective framework https://invent.kde.org/frameworks/kconfig/-/merge_requests/85 * Unfortunately porting of plasma-workspace (https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1182) is blocked by * the property for the wallpaper config being part of plasma-frameworks and thus public API. * I will create a KF6 task to keep track of it * Did lots of porting in plasma-workspace, https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1195, there was a regression so I had to revert a part of the change * I will need to investigate this further * Also https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1201 could use a review from d_ed[m] :) * Besides that mostly work on the KF6 tasks, nothing too much related to Plasma :) * I made a small MR in plasma-workspace fixing some inconsistencies regarding the translation domain and plugin id of the icons KCM * Then KAboutData can be dropped for the icons KCM too Arjen * I think the most important things of last week are that I merged a bunch of touch drag and drop fixes in kwayland-server, though I left out window-to-window drag since that currently causes crashes until qt is fixed * I also managed to break qtdeclarative by backporting something that was apparently insufficient * which was in preparation of touch support for the overview effect, which is now also merged (with a workaround for the thing I tried to fix in qtdeclarative) * explanation: taphandler and some other code in qtquick currently assumes touch point id 0 is invalid which is a stupid assumption and meant that initially, kwin's touch code didn't work because it was sending events as touch id 0 the workaround is to add an offset to touch ids when sending them to qt... * oh and I also spent some time on my qmlmodule cmake thing to resolve open review comments, to hopefully move that forward Kai Uwe Notifications: Receiving files via Bluetooth now shows "Bluetooth transfer" as app name instead of "KDE Daemon" Add "transient" flag to jobs, allows to skip showing a "finished" notification once done for e.g. "loading archive..." or statjob that provide no meaningful actions to the user when done, please review Plasma part: https://invent.kde.org/frameworks/kjobwidgets/-/merge_requests/13 Frameworks part: https://invent.kde.org/frameworks/kjobwidgets/-/merge_requests/13 KRunner: I believe we can speed up (make more determinstic) KRunner showing up by not waiting for Plasma's strut manager When Plasma is randomly busy/frozen it jeopardizes KRunner showing up Had a brief look but the positioning/window handling code is quite brittle, so did not dare touching it KIO: Fixed various minor bugs in KPropertiesDialog, e.g. time labels not hiding correctly if info is unavailable Replaced that massive "File type options" in KPropertiesDialog with an "Open with: [name of default handler]" line Makes it more obvious to the user what all of this file type association stuff means https://invent.kde.org/frameworks/kio/uploads/9f7d390631d5e28a7b47077a630d5b26/Screenshot_2029_233644.png Dolphin: Generate thumbnails for visible files first since folders take a long time to generate, please review: https://invent.kde.org/system/dolphin/-/merge_requests/291 Other: Fix Ark "Create new archive" not hiding welcome screen Worked on improving job reporting in Ark, found some issues with meta type registration https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/154 but not sure if this is the correct layer --- Discussion about Krunner: can we move it already to layershell? krunner has a single window so we could try to do it already. may be a problem on the free floating option tough DavidR has a prototype, there is a problem with dialog shadows still (Dialog problem?) And also you need to kinda not make dialog create a plasmashellsurface --- Vlad * Made various improvements in the overview effect, e.g. krunner search integration, better launch times, cursor handling, etc * Created a merge request to extract reusable parts of the overview effect to simplify writing new qtquick effects in kwin * I would like to start a discussion about phasing out desktop grid and present windows effects some time later * Those two has caused so much trouble and I need them to go away as they make changing effects/scene stuff very difficult [question from MArco: is it possible to rewrite the desktop grid in the new qml api?] * Yeah, maybe... Some people may be very vocal about the fact that the overview ignores the desktop grid layout * Although, as a kwin maintainer, I'm not happy about maintaining a bunch of effects and would like to
Monday meeting notes for 15/11/2021
Kai Uwe plasma-browser-integration: * Firefox 1.8.1 has been released a few weeks back, bringing the app back into the store, thanks fvogt and d_ed for support * Support wildcard in media controls blacklist, please review: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/63 I am also working on a UI to manage the domains list but that's not strictly necessary for this imho * "Rename Plasma Search to KRunner" https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/56 but VDG has hinted they want to change name again... so I am hesistant to merge Notifications: * Wanted to delay showing screenshot notification until thumbnail is ready, however sometimes causes popup to not show at all :/ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1162 * Emit moving while renaming, fixes job tracker display for trashing loads of files: https://invent.kde.org/frameworks/kio/-/merge_requests/624 Plasma: * Port from deprecated Plasma::Applet constructor: https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/56 * What shall we do with https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/551 and to some extent https://invent.kde.org/network/krdc/-/merge_requests/19 Other: Show non-default Port in full host name (%H) in tab bar in Konsole (so you can tell apart several connections to the same host on different ports): https://invent.kde.org/utilities/konsole/-/merge_requests/521 Arjen * half my week was spent looking into drag and drop problems, turns out Qt does not support the most recent version of the wayland drag and drop protocol * but there's already a patch for implementing that which fixes most of the issues * and makes it a lot simpler to handle touch drag and drop https://codereview.qt-project.org/c/qt/qtwayland/+/334777 needs to land in qt6, then can be backported to our patch collection * so now I'm looking into touch support for KWin's overview effect, which means adding touch forwarding to KWin's QuickEffectView * which unfortunately turns out to be another potential rabbit hole since kwin's internal touch handling is quite different from what Qt expects * but it may need more extensive changes Aleix * Discover: Did look into Discover entirely stopping updates of compulsory packages so it never happens that the distro suggests to uninstall everything and the user just accepts it. * Purpose: There's a PoC in a merge request about more ad-hoc sharing API for our apps, so the workflows can be better documented. https://invent.kde.org/frameworks/purpose/-/merge_requests/45 * Homescreen: this one is a bit stuck, it's about having applications list themselves with their GenericName on Plasma Mobile. It's a bit stuck because some apps really identify as their branded name. https://invent.kde.org/plasma/plasma-phone-components/-/merge_requests/203 * KDE Connect Virtual Monitors feature is done and could use review. I think it's especially interesting from a Plasma perspective. https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/427 Marco # Plasma/Plamo * reviewing stuff # Kirigami * Spent a bit of time around Noah's review https://invent.kde.org/frameworks/kirigami/-/merge_requests/415 to find workable solutions, making last tests to the patch now, but seems it's almost ready (tm) # Wayland * in general going trough the visible ui/interaction papercuts i'm seeing * More time spent on the OSD issue, ended up with a patch in p-f, one in the OSD qml in p-w, and after some investigation on a kwayland-server patch which Vlad did the final form of it * More time investigating wrong blur regions. the actual window with blur behind doesn't get a commit. This fixes it https://invent.kde.org/plasma/kwayland-integration/-/merge_requests/15 tough may need a more proper solution * workaround to send slighly smaller blur and contrastregions to the contrast effect so corners won't bleed over when scaling is on, very visible look improvement * looking into morphinpopups for wayland, have a patch https://invent.kde.org/plasma/kwin/-/merge_requests/1652 which i'm reworking based on feedback now
monday meeting notes for 8/11/2021
Carl * Nothing big from me. I made mostly some code reviews in Kalendar and NeoChat. Aside from that, could someone review https://invent.kde.org/graphics/koko/-/merge_requests/103/diffs. I do want at some point to upstream it inside purpose. Arjen * I continued with trying to figure out why drag and drop with touch between windows crashes * and I actually found a rather significant problem with drag and drop using mouse - apparently the drag doesn't end for the source window until focus is returned to the window * which is why it doesn't crash using mouse, but touch properly ends the drag on drop and then deletes the drag object * could be some protocol quirk i'm not aware of, but it seems like incorrect behaviour on the wayland side * anyway, I'm continuing with digging around in that code, even though I feel like I only understand maybe half of it [notmart: and i guess fixing the mouse one makes both crash t he same way] [ahiemstra: yeah, that's what I'm hoping for at least] * I actually already know how to avoid the crash, it "just" needs implementing DavidR * I've looked into applying a look and feel on startup * Example a distro has a default lnf set in /etc/xdg, right now it wouldn't be applied * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1175 * there is always the pain point of colors, but this is another task Nico * I was mostly workking on porting plasma-pa to pulseaudio-qt * Which I've been only doing since ... 2018 * Made some prep patches https://invent.kde.org/plasma/plasma-pa/-/merge_requests/91 https://invent.kde.org/plasma/plasma-pa/-/merge_requests/93 https://invent.kde.org/libraries/pulseaudio-qt/-/merge_requests/13 Hanyoung * working on merging language and formats kcms * https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1147/diffs but hit a roadblock as some languages do not correspond to a valid locale * checking what locales are valid is distro specific Marco * helping with look and feel apply in startplasma and the new lnf-controlled default settings, helped a bit DavirR on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1175 ** all system colors are reapplied on first startup and every time the colorscheme entry or the colorscheme file contents changed * helping with touch friendliness of the widget explorer drag and drop on the X11 part * fixed a plasma freeze in Wayland when quickly hovering between the clock and other appelts (problem in clock tooltip) * investigating the wayland issue of OSDs showing up maximized, with patches on palsma-framework and kwin, so far https://invent.kde.org/plasma/kwin/-/merge_requests/1608 and https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/373 super hacky for now, will take a look with Vlad when he's back * started investigating why sometimes the first time the clock panel tooltip has a wrong blur area behind
Monday meeting notes for 1/11/2021
Carl * Add pane to QQC2-desktop-style: https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/105 (merged) * Don't use id in QQC2-desktop-style (minor performace improvement): https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/104 (merged) * Wrote a new simple Kirigami app: https://invent.kde.org/carlschwan/hash-validator * Made icon fallback work with KIconLoader: https://invent.kde.org/frameworks/kiconthemes/-/merge_requests/45 (please review) * Also started working on an high level purpose api based QQC2.Action Arjen * I've been working on touch support for the plasma widget explorer * the initial patch is done, but it turned into a deep dive into drag and drop on wayland * which has a bunch of issues * I've solved most of them at this point, but hit a nasty crash * that I've not found a fix for yet * the mr is https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/630 * I have the crash when dragging between two widgets examples so yes, it'll also crash * it crashes because Qt has deleted the "data_source" object that is used to send data from one application to another * most of the drag and drop work I have done so far is done with qt's drag and drop examples, which are widgets based, but the problems are more fundamental * basically, I started looking at this because drag and drop with touch just didn't really work in plasma * originally, things like dragging icons on the desktop didn't even work properly * that bit is now resolved, but the widget explorer is a different window, which turned out to have a separate set of problems * once I have things working correctly between the example applications I can get back to the widget explorer and test that Hanyoung * https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/87 * you have main menu A, sub menu B and C. When user selected the option in B or C, auto pop back to A. But user may access B or C again * B and C is expensive to construct Vlad * I fixed a bug where windows shift after changing output layout
Monday meeting notes for 25/10/2021
[discussion about problems in wayland wrt wacom tablets, may need more discussion with hanyoung and tyson tan] David E * We're seeing the usual mass of bugs come in after a .0 release * so we need to be more on top of that * I approved a bunch of things wrt fingerprints * There's some good stuff from Devin * and I'll merge my kscreenlocker side * it's currently "blocked" on letting someone merge their patch for custom prompts * and then I'll land the fingerprint stuff on top [David Redondo We broke plasmashell dbus api. d_ed I saw the mrs] Nicofe * One big-ish thing is implementing fdo color preference support in our portal https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/49 * Fixed a relevant KCM bug https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1123 * I also added API to use it from an app: https://invent.kde.org/frameworks/kguiaddons/-/merge_requests/27 * On the PlaMo side I finally merged the ModemManager port of Spacebar And started working on fixing all the things Something that came out of that is https://invent.kde.org/frameworks/modemmanager-qt/-/merge_requests/7 Carl * Fix pushDialogLayers https://invent.kde.org/frameworks/kirigami/-/merge_requests/405 (merged) and ported Kalendar's OverlaySheets, Koko's share dialog and Neochat settings to it * Ported Qrca and the health certificate part of Itinerary to Kirigami.NavigationTabBar: https://invent.kde.org/plasma-mobile/qrca/-/merge_requests/45 (merged) and https://invent.kde.org/pim/itinerary/-/merge_requests/53 (merged) * Fix some issues with the new Sonnet QtQuick feature: https://invent.kde.org/frameworks/sonnet/-/merge_requests/33 (merged) * Kirigami doc improvements: https://invent.kde.org/frameworks/kirigami/-/merge_requests/406 (merged), https://invent.kde.org/frameworks/kirigami/-/merge_requests/407 * KCM doc improvements: https://invent.kde.org/documentation/develop-kde-org/-/merge_requests/151 (merged) Arjen * I've been doing some work on touch support for plasma * I did a few MRs to set Qt.ImhNoPredictiveText on text fields that are used as search fields, without it the virtual keyboard will only cause the textEdited/textChanged signals to be fired on enter, which means things like krunner don't work properly with virtual keyboard * I wrote a kirigami MR to detect whether an input method/virtual keyboard is active https://invent.kde.org/frameworks/kirigami/-/merge_requests/398 * but it's a bit stuck as the kwin api basically is insufficient * that said, the only property Qt.inputMethod has that is the same is the "visible" property * it doesn't have any information about whether an input method is enabled or what kind of input method is being used * the end goal of this was to prevent system settings from focusing the search field on startup when started with touch and a virtual keyboard is active * and be able to do the same in other places * last thing I'm working on is porting the plasma widget explorer away from DragArea so that it becomes easier to change the behaviour between mouse and touch * I have a draft mr https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/630 * it works great with mouse * but touch only works sporadically * so far we figured out that drags are started properly, but then kwin doesn't seem to properly update the drags on touch motion [d_ed i can believe it's an untested area] Kai Uwe * not much from my side * just that p-b-i got kicked out of Mozilla store last Monday * fvogt did a fix and d_ed will upload it … thanks for that! Marco i started to port some of the code of the plasma6 prototype wrt applet loading i did to plasma5, as at akademy we talked about the possibility to have the api we liked more in plasma5alsready, so some plamoid could be ported in any moment.. -- Marco Martin
Monday meeting notes for 11/10/2021
David E we can start breaking 5.24 now Jonathan how's the announce going Paul Brown ? must be going good then Marco has kickoff been scheduled? Jonathan No but I can make a doodle poll now if you think that's useful Jonathan Esk-Riddell and as ripper17 points out I've not made a proposed schedule for 5.24 yet d_ed (@d_ed:kde.org) it takes a week for people to fill it in Jonathan Esk-Riddell so should I assume we'll be doing another 12 months of Plasma 5 releases on the same schedule as the previous ones and plan for that then confirm it at the kickoff meeting? d_ed (@d_ed:kde.org) certainly we'll be doing another 2 when 6 comes I really don't know we're not exactly on top of frameworks ATM Jonathan Esk-Riddell okay I'll find dates for another 12 months and we can just confirm each release one release ahead d_ed (@d_ed:kde.org) yeah Jonathan Esk-Riddell I'll also chat to dfaure or vkrause and see if they have any idea on kf6 dates d_ed (@d_ed:kde.org) we have a frameworks meeting today at 4pm my time which I should promote here Jonathan Esk-Riddell Monday 15:00 UTC / 17:00 CEST on https://meet.kde.org/b/ada-mi8-aem! KF6 You have been invited to join KF6 using BigBlueButton. To join, click the link above and enter your name. d_ed (@d_ed:kde.org) that's the one Jonathan Esk-Riddell groovy, meeting over I think unless anyone has anything Carl Schwan
Monday meeting notes for 4/11/2021
Nico * The only thing I want to draw attention to is the .kde-ci.yml files for Plasma * We really should get those in place since that blocks a wider rollout of gitlab CI [discussion] Arjen: yeah I think the frameworks work was scripted and that script could potentially be reused for other modules Nico: But we don't have the individual frameworks deps for Plasma in the current metadata, have we? We rely on frameworksumbrella which is not a thing any more So not sure how a script would wor Marco: so all of those need to be added by hand in the metadata? Nico: Yes Marco: can deps be extrapolated from cmake: Bhushan: There's a CMake command to generate the dependency graph Carl * https://invent.kde.org/frameworks/kirigami/-/merge_requests/386 Would be nice to have it in Kirigami respin since it fixes some nasty bugs in the Kirigami settings page using in Koko and Kalendar and blocks porting NeoChat to it -- Marco Martin
Monday meeting notes for 27/10/2021
David E * If someone wants to run a plasma 5.23 beta testing day, we'll need to start soon * I don't have time this release [Jonathan volunteered] * We also need to start planning a 5.24 kickoff meeting [Discussion: Paul asked if we are still ok releasing on 14th, seems so] Jonathan * will run beta testing day * after the release will plan the kickoff meeting * In other news Paul Brown says the release announce is being worked on and this release will be called "Plasma 25th Anniversary Edition" * I got married * /nick is updated * I suppose I need a new gpg key * has anyone looked at the .ci yml files? [d_ed: yes, vlad has a script on frameworks devel to generate for all plasma, we "just" need to run that in a for loop across all repos, and commit everywhere] Nico * not terribly much from me * But some bugfixes * https://invent.kde.org/plasma/plasma-pa/-/merge_requests/84 * https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/567 * https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/423 * https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/424 * https://invent.kde.org/system/dolphin/-/merge_requests/276 * all merged Fabian * would only ping on https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1079 [d_ed: will check] David R * Nothing exciting just trying to fix klipper sending/receiving from/to plasma on wayland * I am about 3/4 done, one direction works the other half-ish * I will make just a MR for the working one and push on to get the other into 5.23 -- Marco Martin
Monday meeting notes for 20/09/2021
David E: * We had a release! * There was some minor drama release day * I don't want to create a fuss over it, but a big change was landed on the morning of release over some miscommunication. * We had said in a previous meeting that this MR could ask for an exemption for a freeze and I'm sure we would allow it. Then an * email happened and it merged literally hours before the release. * and whilst the direction of the patch is good it wasn't really desktop-ready * Bshah and I talked it out, and came up with a plan that doesn't hold mobile back too much * they can release a mobile version with the X-KDE-FormatThingy set * Ultimately the bigger problem is that we have a huge review backlog * and the author did start work following up on my desktop comments * so that's good too * In terms of the rest of my week, I did a few klipper + wayland fixes * I'm really hoping for this to be the release of perfect wayland clipboard management, so please do test that! * we need to start planning the beta test day * schedule stays that will be in 3 days * but also says it will be a saturday * Edit: it doesn't say Saturday, I imagined that * Does anyone want to volunteer to help run that? Bhushan: (still on the previous topic) * So plan is to copy kcm in plasma-settings for time being of 5.23 to 5.24 -- Marco Martin
monday meeting notes for 6/9/2021
# Arjen * I did a few kirigami things last week to improve startup performance * biggest change there being switching a whole bunch of loaders to async * which improved startup for my koko testcase by ~500ms which was rather significant * other than kirigami, I merged two bigger mrs for quick charts, which change how line and bar charts are rendered so they can be batched by the scene graph, which should improve performance # David E * We are now in soft feature freeze * which is exciting * We have a big backlog of reviews * I've been trying to spend my evenings going through them * There's a lot that have been abandoned by authors, so I'm making heavy use of the "needs changes" tag * and then doing searches based on that * One potential issue is the new kwin "frost effect" * we merged in all the surrounding infrastrcuture and API for it to land this release, but it doesn't seem to have happened yet * as that's quite a large change I would rather that happened sooner than later * I also have a large kwin change I want to get in that's a bit of a large refactor and potentially breaks the idea of the soft freeze, but it's to fix a bug, so I'll ask for an exception on plasma-devel * it's rewriting a bunch of D code to be much more sane [discussion d_ed -> Bhushan Shah: as you're here, what's the status of https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/147 Bhushan Shah -> d_ed: I'll try to follow up by this week (it won't get in 5.23 anyway but let's try to move that review somewhat) ] * Has anyone spoke to promo about release announcements? * If not I'll give them a "heads up" # Bhushan * So I discussed this earlier as well, but one specific change I am interested in for soft-freeze exception is formats KCM QML port * I believe MR is now complete from hanyoung side * Main reason for that is, without it some locale variables can not be configured on plasma mobile and those locale variables are used for detecting phone number format e.g. etc. * will write to plasma-devel about that * Second topic, is modemmanager port we have in plasma-nm and plasma-phone-components, we will merge it close to beta most likely since it needs to sync up with other components as well (out of plasma release schedule), it does not affect anything in desktop space * main reason being it needs sync with other components as well (dialer,spacebar) https://invent.kde.org/plasma/plasma-phone-components/-/merge_requests/176 https://invent.kde.org/plasma/plasma-nm/-/merge_requests/33 * I will discuss with Nico and Devin later today and depending on discussion will send email to plasma-devel thread about both formats kcm and broadband one # Nico * A while ago I asked distros whether we can use C++20 in Plasma * And no objections were raised * So I started porting some of the async DBus stuff in plasma-nm to use coroutines * Since the combination of clang + libstdc++ + coroutines currently is broken * The problem is we don't know when clang will fix that * either wait or force Openmandriva to use gcc for now for plasma * need to reach and say "we want to do this for this time, can you find a way to make it work"
Re: Setting Look and Feels
On Tue, Aug 31, 2021, 18:27 Aleix Pol wrote: > Now, is this something that we would like to entertain? I'd say it's a > good way to configure a system to use a certain Plasma experience (be > it Plasma Phone, Big Screen, etc). On the other hand, it also might > dilute the current use of the look and feel kcm which is more about > Look and less about Feel. > I am not sure all the settings plastered around for plamo are suitable to go in lnf, but surely many of them >
Re: Setting Look and Feels
On Tue, Aug 31, 2021, 18:33 Nate Graham wrote: > There have been persistent calls--both in the VDG as well as by users-- > for the Global Theme/LNF system to become better at the "feel" side, as > you put it (I like that!). I've still got > https://phabricator.kde.org/D24223 open, which was about the feel side > of the equation, and I still don't think it would be a bad idea to do. > > If we don't want to make Global Themes too much about the "feel" side, > then I think we need to create a new "Desktop Layout" KCM that's all > I would rather keep this in one place and make the feel part better at it :) > >
monday meeting notes for 30/8/2021
Monday meeting notes for 30 august 2021: Arjen: we spent some time on the bug where popups have incorrect shadows not enough to fix it unfortunately but we did narrow it down somewhat, since we realised it is the shadows that are wrong which means it's not framesvg being weird, it's something to do with dialogshadows specifically I created a manual test that just shows the actual shadow elements, which didn't trigger the bug unfortunately other than that, there's general system monitor maintenance happening * and my ecm qml module cmake thing is still waiting on any reply: https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/170 Kai Uwe Plasma: Allow "non-file" recent docs in Task Manager, RFC, please have a look: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/551 (Kickoff would need similar treatment then) Is there anything being done about https://bugs.kde.org/show_bug.cgi?id=438994 – 5.23 is approaching and this is quite a severe usabilit regression Other: Kolourpaint "rotate" dialog now uses theme icons rather a fixed PNG Track connections in KRDC in KActivitiesStats: https://invent.kde.org/network/krdc/-/merge_requests/19 (needs aforementioned non-file patch) Wrote "generate QR code" plug-in for Purpose for "sending" links to your phone on networks where KDE Connect doesn't work, please have a look: https://invent.kde.org/frameworks/purpose/-/merge_requests/34 Worked on an ILBM (some Amiga image format used by old DOS games, such as The Settlers) Qt image format plug-in, just for fun, might put it on my GitHub rather than KImageFormats as it is quite esoteric discussion on bug 438994: is probably better to revert the change for now -- Marco Martin
