Re: PROPOSAL: register user with e-mail activation

2007-03-25 Thread sedat ciftci
Here is the updated patch: 
http://jroller.com/resources/s/sedat/newRollerPropertyVer6.jar

Sedat Çiftçi

--- Dave [EMAIL PROTECTED] wrote:

 On 3/23/07, sedat ciftci [EMAIL PROTECTED]
 wrote:
  If you prefer that design, I can change it and
  re-submit the patch.
Sedat Çiftçi
 
 Yes, please. I think the consensus is that we'd
 rather avoid new table
 creation in this enhancement.
 
 - Dave
 
 
 
  --- Dave [EMAIL PROTECTED] wrote:
 
   On 3/21/07, sedat ciftci [EMAIL PROTECTED]
   wrote:
Yes, it can also be done with this design.
 Note
   that,
in this design you have to clear the
   activationCode
(or make something else, to mark that it is
 used)
after the account is activated (Also in my
 design,
   I
delete the related record from useractivate
   table).
The reason behind this requirement can be
   explained as
follows:
Let's assume that a user registers with e-mail
activation and assume that the related
   activationCode
is not deleted. After a while, admin user
 wants to
disable the account of this user from the
 User
   Admin
menu of the Server Administration and disables
 it.
Then, if the user clicks the activation link
 in
   the
sent activation mail (assume user stores it;
 did
   not
delete it), his/her account is enabled again.
   Because
of this simple scenario, do not forget to mark
 the
activated accounts so that the link in the
 sent
activation mail will not be used again once it
 is
used.
  
   Sedat,
  
   Are you willing to change the design to remove
 the
   new table and then
   re-submit the patch?
  
   - Dave
  
 
 
 
 
 


  Sucker-punch spam with award-winning protection.
  Try the free Yahoo! Mail Beta.
 

http://advision.webevents.yahoo.com/mailbeta/features_spam.html
 
 



 

Don't get soaked.  Take a quick peek at the forecast
with the Yahoo! Search weather shortcut.
http://tools.search.yahoo.com/shortcuts/#loc_weather


Re: PROPOSAL: register user with e-mail activation

2007-03-23 Thread sedat ciftci
If you prefer that design, I can change it and
re-submit the patch.
  Sedat Çiftçi

--- Dave [EMAIL PROTECTED] wrote:

 On 3/21/07, sedat ciftci [EMAIL PROTECTED]
 wrote:
  Yes, it can also be done with this design. Note
 that,
  in this design you have to clear the
 activationCode
  (or make something else, to mark that it is used)
  after the account is activated (Also in my design,
 I
  delete the related record from useractivate
 table).
  The reason behind this requirement can be
 explained as
  follows:
  Let's assume that a user registers with e-mail
  activation and assume that the related
 activationCode
  is not deleted. After a while, admin user wants to
  disable the account of this user from the User
 Admin
  menu of the Server Administration and disables it.
  Then, if the user clicks the activation link in
 the
  sent activation mail (assume user stores it; did
 not
  delete it), his/her account is enabled again.
 Because
  of this simple scenario, do not forget to mark the
  activated accounts so that the link in the sent
  activation mail will not be used again once it is
  used.
 
 Sedat,
 
 Are you willing to change the design to remove the
 new table and then
 re-submit the patch?
 
 - Dave
 



 

Sucker-punch spam with award-winning protection. 
Try the free Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/features_spam.html


Re: PROPOSAL: register user with e-mail activation

2007-03-23 Thread Dave

On 3/23/07, sedat ciftci [EMAIL PROTECTED] wrote:

If you prefer that design, I can change it and
re-submit the patch.
  Sedat Çiftçi


Yes, please. I think the consensus is that we'd rather avoid new table
creation in this enhancement.

- Dave




--- Dave [EMAIL PROTECTED] wrote:

 On 3/21/07, sedat ciftci [EMAIL PROTECTED]
 wrote:
  Yes, it can also be done with this design. Note
 that,
  in this design you have to clear the
 activationCode
  (or make something else, to mark that it is used)
  after the account is activated (Also in my design,
 I
  delete the related record from useractivate
 table).
  The reason behind this requirement can be
 explained as
  follows:
  Let's assume that a user registers with e-mail
  activation and assume that the related
 activationCode
  is not deleted. After a while, admin user wants to
  disable the account of this user from the User
 Admin
  menu of the Server Administration and disables it.
  Then, if the user clicks the activation link in
 the
  sent activation mail (assume user stores it; did
 not
  delete it), his/her account is enabled again.
 Because
  of this simple scenario, do not forget to mark the
  activated accounts so that the link in the sent
  activation mail will not be used again once it is
  used.

 Sedat,

 Are you willing to change the design to remove the
 new table and then
 re-submit the patch?

 - Dave






Sucker-punch spam with award-winning protection.
Try the free Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/features_spam.html



Re: PROPOSAL: register user with e-mail activation

2007-03-22 Thread Dave

On 3/21/07, sedat ciftci [EMAIL PROTECTED] wrote:

Yes, it can also be done with this design. Note that,
in this design you have to clear the activationCode
(or make something else, to mark that it is used)
after the account is activated (Also in my design, I
delete the related record from useractivate table).
The reason behind this requirement can be explained as
follows:
Let's assume that a user registers with e-mail
activation and assume that the related activationCode
is not deleted. After a while, admin user wants to
disable the account of this user from the User Admin
menu of the Server Administration and disables it.
Then, if the user clicks the activation link in the
sent activation mail (assume user stores it; did not
delete it), his/her account is enabled again. Because
of this simple scenario, do not forget to mark the
activated accounts so that the link in the sent
activation mail will not be used again once it is
used.


Sedat,

Are you willing to change the design to remove the new table and then
re-submit the patch?

- Dave


PROPOSAL: register user with e-mail activation

2007-03-21 Thread Dave

I have taken a look at Sedat's patch and the design and actual code
look good. I tested against Roller trunk and everything worked fine --
there are a couple of small fixes in error handling and email
word/formatting that I will make before committing, but overall it is
ready to go.

I wrote-up a proposal based on his work here:
http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration

Please review and comment on this proposal.

- Dave


Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread Allen Gilliland
I don't understand what exactly this is trying to accomplish.  How do 
you actually register an account via email?  You need to supply input 
for the various form fields at some point right?


Can we get a description of the work flow that this is advocating?  When 
does the email get sent?  What does it contain?  What action does the 
recipient take?  etc.


Can we get Sedat access to the wiki so that he can add this info since 
this is really his proposal?


-- Allen


Dave wrote:

I have taken a look at Sedat's patch and the design and actual code
look good. I tested against Roller trunk and everything worked fine --
there are a couple of small fixes in error handling and email
word/formatting that I will make before committing, but overall it is
ready to go.

I wrote-up a proposal based on his work here:
http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration 



Please review and comment on this proposal.

- Dave


Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread Dave

On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:

I don't understand what exactly this is trying to accomplish.  How do
you actually register an account via email?  You need to supply input
for the various form fields at some point right?

Can we get a description of the work flow that this is advocating?  When
does the email get sent?  What does it contain?  What action does the
recipient take?  etc.


The work flow is this:
1) User enters registration info into existing registration form and posts
2) Roller responds: thanks for registering, please wait for activation email
3) User gets email, clicks activation link
4) Roller responds: You are registered! Here's a link for you to login



Can we get Sedat access to the wiki so that he can add this info since
this is really his proposal?


That's my question as well. Can we give non-committers access to the wiki?

Anybody (hi Henri) know?

- Dave




Dave wrote:
 I have taken a look at Sedat's patch and the design and actual code
 look good. I tested against Roller trunk and everything worked fine --
 there are a couple of small fixes in error handling and email
 word/formatting that I will make before committing, but overall it is
 ready to go.

 I wrote-up a proposal based on his work here:
 http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration


 Please review and comment on this proposal.

 - Dave



Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread Allen Gilliland



Dave wrote:

On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:

I don't understand what exactly this is trying to accomplish.  How do
you actually register an account via email?  You need to supply input
for the various form fields at some point right?

Can we get a description of the work flow that this is advocating?  When
does the email get sent?  What does it contain?  What action does the
recipient take?  etc.


The work flow is this:
1) User enters registration info into existing registration form and posts
2) Roller responds: thanks for registering, please wait for activation 
email

3) User gets email, clicks activation link
4) Roller responds: You are registered! Here's a link for you to login


gotcha, i don't know why i was thinking of something else.

in any case, i think the design could be simplified a bit.  rather than 
create a whole new table why not just add the activationcode column to 
the existing rolleruser table?  that way we don't need the new table, 
pojo, and manager methods.  in fact, the registration code is basically 
unchanged except for adding in this logic ...


if(emailActivationEnabled) {
  newUser.setEnabled(false);

  // generate activation code
  newUser.setActivationCode(code);

  // send activation email
}

-- Allen






Can we get Sedat access to the wiki so that he can add this info since
this is really his proposal?


That's my question as well. Can we give non-committers access to the wiki?

Anybody (hi Henri) know?

- Dave




Dave wrote:
 I have taken a look at Sedat's patch and the design and actual code
 look good. I tested against Roller trunk and everything worked fine --
 there are a couple of small fixes in error handling and email
 word/formatting that I will make before committing, but overall it is
 ready to go.

 I wrote-up a proposal based on his work here:
 
http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration 




 Please review and comment on this proposal.

 - Dave



Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread Dave

On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:

Dave wrote:
 On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:
 I don't understand what exactly this is trying to accomplish.  How do
 you actually register an account via email?  You need to supply input
 for the various form fields at some point right?

 Can we get a description of the work flow that this is advocating?  When
 does the email get sent?  What does it contain?  What action does the
 recipient take?  etc.

 The work flow is this:
 1) User enters registration info into existing registration form and posts
 2) Roller responds: thanks for registering, please wait for activation
 email
 3) User gets email, clicks activation link
 4) Roller responds: You are registered! Here's a link for you to login

gotcha, i don't know why i was thinking of something else.

in any case, i think the design could be simplified a bit.  rather than
create a whole new table why not just add the activationcode column to
the existing rolleruser table?  that way we don't need the new table,
pojo, and manager methods.  in fact, the registration code is basically
unchanged except for adding in this logic ...

if(emailActivationEnabled) {
   newUser.setEnabled(false);

   // generate activation code
   newUser.setActivationCode(code);

   // send activation email
}


Yes. I prefer that too.

- Dave


Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread Matt Raible

I'm fine with this proposal.

Matt

On 3/21/07, Dave [EMAIL PROTECTED] wrote:

On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:
 Dave wrote:
  On 3/21/07, Allen Gilliland [EMAIL PROTECTED] wrote:
  I don't understand what exactly this is trying to accomplish.  How do
  you actually register an account via email?  You need to supply input
  for the various form fields at some point right?
 
  Can we get a description of the work flow that this is advocating?  When
  does the email get sent?  What does it contain?  What action does the
  recipient take?  etc.
 
  The work flow is this:
  1) User enters registration info into existing registration form and posts
  2) Roller responds: thanks for registering, please wait for activation
  email
  3) User gets email, clicks activation link
  4) Roller responds: You are registered! Here's a link for you to login

 gotcha, i don't know why i was thinking of something else.

 in any case, i think the design could be simplified a bit.  rather than
 create a whole new table why not just add the activationcode column to
 the existing rolleruser table?  that way we don't need the new table,
 pojo, and manager methods.  in fact, the registration code is basically
 unchanged except for adding in this logic ...

 if(emailActivationEnabled) {
newUser.setEnabled(false);

// generate activation code
newUser.setActivationCode(code);

// send activation email
 }

Yes. I prefer that too.

- Dave




--
http://raibledesigns.com


Re: PROPOSAL: register user with e-mail activation

2007-03-21 Thread sedat ciftci

--- Allen Gilliland [EMAIL PROTECTED] wrote:

 
 
 Dave wrote:
  On 3/21/07, Allen Gilliland
 [EMAIL PROTECTED] wrote:
  I don't understand what exactly this is trying to
 accomplish.  How do
  you actually register an account via email?  You
 need to supply input
  for the various form fields at some point right?
 
  Can we get a description of the work flow that
 this is advocating?  When
  does the email get sent?  What does it contain? 
 What action does the
  recipient take?  etc.
  
  The work flow is this:
  1) User enters registration info into existing
 registration form and posts
  2) Roller responds: thanks for registering, please
 wait for activation 
  email
  3) User gets email, clicks activation link
  4) Roller responds: You are registered! Here's a
 link for you to login
 
 gotcha, i don't know why i was thinking of something
 else.
 
 in any case, i think the design could be simplified
 a bit.  rather than 
 create a whole new table why not just add the
 activationcode column to 
 the existing rolleruser table?  that way we don't
 need the new table, 
 pojo, and manager methods.  in fact, the
 registration code is basically 
 unchanged except for adding in this logic ...
 
 if(emailActivationEnabled) {
newUser.setEnabled(false);
 
// generate activation code
newUser.setActivationCode(code);
 
// send activation email
 }
 
 -- Allen

Yes, it can also be done with this design. Note that,
in this design you have to clear the activationCode
(or make something else, to mark that it is used)
after the account is activated (Also in my design, I
delete the related record from useractivate table).
The reason behind this requirement can be explained as
follows:
Let's assume that a user registers with e-mail
activation and assume that the related activationCode
is not deleted. After a while, admin user wants to
disable the account of this user from the User Admin
menu of the Server Administration and disables it.
Then, if the user clicks the activation link in the
sent activation mail (assume user stores it; did not
delete it), his/her account is enabled again. Because
of this simple scenario, do not forget to mark the
activated accounts so that the link in the sent
activation mail will not be used again once it is
used.

Sedat Çiftçi

 
  
  
  Can we get Sedat access to the wiki so that he
 can add this info since
  this is really his proposal?
  
  That's my question as well. Can we give
 non-committers access to the wiki?
  
  Anybody (hi Henri) know?
  
  - Dave
  
  
  
  Dave wrote:
   I have taken a look at Sedat's patch and the
 design and actual code
   look good. I tested against Roller trunk and
 everything worked fine --
   there are a couple of small fixes in error
 handling and email
   word/formatting that I will make before
 committing, but overall it is
   ready to go.
  
   I wrote-up a proposal based on his work here:
   
 

http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration
 
 
  
  
   Please review and comment on this proposal.
  
   - Dave
 
 



 

Looking for earth-friendly autos? 
Browse Top Cars by Green Rating at Yahoo! Autos' Green Center.
http://autos.yahoo.com/green_center/


Re: Proposal: register user with e-mail activation

2007-03-20 Thread Dave

I'm looking at the patch now and I should have some feedback soon.

I wrote up a proposal for you here:
http://cwiki.apache.org/confluence/display/ROLLER/Proposal+Email+Registration

- Dave



On 3/19/07, Dave [EMAIL PROTECTED] wrote:

Thanks Sedat. I'll hope to get to this today. - Dave



On 3/18/07, sedat ciftci [EMAIL PROTECTED] wrote:
 Hello again,

 I add a small but necessary code into the activateUser
 method of UserNewAction.java for handling the user
 account activation manually by site admin (site
 administrator can manually activate the user account
 by simply enabling the user from the 'User Admin'
 menu).

 zip file that contains diff patch for current trunk:
 http://jroller.com/resources/s/sedat/newRollerPropertyVer5.jar

 Note: I apologize for too many versions but I hope
 this is the last version.

  Sedat Çiftçi

 --- sedat ciftci [EMAIL PROTECTED] wrote:

  Hello,
 
  Here is the zip file that contains the patch to work
  with the current trunk:
 
 http://www.jroller.com/resources/s/sedat/newRollerPropertyVer4.jar
 
  Note that this patch file also contains new added
  class (org.apache.roller.pojos.UserActivationData)
 
  Note about sandbox:
 
  I do not know anything about sandbox. I do not make
  any changes on the files related under the directory
  sandbox.
 
  Sedat Çiftçi
 
  --- Dave [EMAIL PROTECTED] wrote:
 
   On 3/17/07, sedat ciftci [EMAIL PROTECTED]
   wrote:
Yes, you are right. I forget to include it. Here
   is the updated zip file:
   
  
 
 http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar
  
   Sedat,
  
   I took a look at the patch this morning.
   Unfortunately, it targets the
   3.0 code-base and enough has changed that most of
   the changes cannot
   be applied to trunk.
  
   Unfortunately, I don't have time right now to port
   your patch from 3.0
   to trunk. But, if you are willing to update the
   patch to work with the
   current trunk, then I'm willing to evaluate it and
   write-up a short
   proposal so we can get it committed.
  
   - Dave
  
 
 
 
 
 
 

  No need to miss a message. Get email on-the-go
  with Yahoo! Mail for Mobile. Get started.
  http://mobile.yahoo.com/mail
 




 

 Don't get soaked.  Take a quick peek at the forecast
 with the Yahoo! Search weather shortcut.
 http://tools.search.yahoo.com/shortcuts/#loc_weather




Re: Proposal: register user with e-mail activation

2007-03-19 Thread Dave

Thanks Sedat. I'll hope to get to this today. - Dave



On 3/18/07, sedat ciftci [EMAIL PROTECTED] wrote:

Hello again,

I add a small but necessary code into the activateUser
method of UserNewAction.java for handling the user
account activation manually by site admin (site
administrator can manually activate the user account
by simply enabling the user from the 'User Admin'
menu).

zip file that contains diff patch for current trunk:
http://jroller.com/resources/s/sedat/newRollerPropertyVer5.jar

Note: I apologize for too many versions but I hope
this is the last version.

 Sedat Çiftçi

--- sedat ciftci [EMAIL PROTECTED] wrote:

 Hello,

 Here is the zip file that contains the patch to work
 with the current trunk:

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer4.jar

 Note that this patch file also contains new added
 class (org.apache.roller.pojos.UserActivationData)

 Note about sandbox:

 I do not know anything about sandbox. I do not make
 any changes on the files related under the directory
 sandbox.

 Sedat Çiftçi

 --- Dave [EMAIL PROTECTED] wrote:

  On 3/17/07, sedat ciftci [EMAIL PROTECTED]
  wrote:
   Yes, you are right. I forget to include it. Here
  is the updated zip file:
  
 

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar
 
  Sedat,
 
  I took a look at the patch this morning.
  Unfortunately, it targets the
  3.0 code-base and enough has changed that most of
  the changes cannot
  be applied to trunk.
 
  Unfortunately, I don't have time right now to port
  your patch from 3.0
  to trunk. But, if you are willing to update the
  patch to work with the
  current trunk, then I'm willing to evaluate it and
  write-up a short
  proposal so we can get it committed.
 
  - Dave
 






 No need to miss a message. Get email on-the-go
 with Yahoo! Mail for Mobile. Get started.
 http://mobile.yahoo.com/mail






Don't get soaked.  Take a quick peek at the forecast
with the Yahoo! Search weather shortcut.
http://tools.search.yahoo.com/shortcuts/#loc_weather



Re: Proposal: register user with e-mail activation

2007-03-18 Thread sedat ciftci
Hello again,

I add a small but necessary code into the activateUser
method of UserNewAction.java for handling the user
account activation manually by site admin (site
administrator can manually activate the user account
by simply enabling the user from the 'User Admin'
menu).

zip file that contains diff patch for current trunk:
http://jroller.com/resources/s/sedat/newRollerPropertyVer5.jar

Note: I apologize for too many versions but I hope
this is the last version.
 
 Sedat Çiftçi

--- sedat ciftci [EMAIL PROTECTED] wrote:

 Hello,
 
 Here is the zip file that contains the patch to work
 with the current trunk: 

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer4.jar
 
 Note that this patch file also contains new added
 class (org.apache.roller.pojos.UserActivationData)
 
 Note about sandbox:
 
 I do not know anything about sandbox. I do not make
 any changes on the files related under the directory
 sandbox.
 
 Sedat Çiftçi
 
 --- Dave [EMAIL PROTECTED] wrote:
 
  On 3/17/07, sedat ciftci [EMAIL PROTECTED]
  wrote:
   Yes, you are right. I forget to include it. Here
  is the updated zip file:
  
 

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar
  
  Sedat,
  
  I took a look at the patch this morning.
  Unfortunately, it targets the
  3.0 code-base and enough has changed that most of
  the changes cannot
  be applied to trunk.
  
  Unfortunately, I don't have time right now to port
  your patch from 3.0
  to trunk. But, if you are willing to update the
  patch to work with the
  current trunk, then I'm willing to evaluate it and
  write-up a short
  proposal so we can get it committed.
  
  - Dave
  
 
 
 
  


 No need to miss a message. Get email on-the-go 
 with Yahoo! Mail for Mobile. Get started.
 http://mobile.yahoo.com/mail 
 



 

Don't get soaked.  Take a quick peek at the forecast
with the Yahoo! Search weather shortcut.
http://tools.search.yahoo.com/shortcuts/#loc_weather


Re: Proposal: register user with e-mail activation

2007-03-17 Thread sedat ciftci
Yes, you are right. I forget to include it. Here is
the updated zip file:
http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar

I also update the method for generating activation
code .

Sedat 

--- Dave [EMAIL PROTECTED] wrote:

 Sedat,
 
 I don't see any DIFF patch file in the jar you sent.
 Perhaps you
 forgot to include it?
 
 - Dave
 
 
 
 On 3/12/07, sedat ciftci [EMAIL PROTECTED]
 wrote:
  I reprepare a single DIFF patch file plus the new
  added file and put them into the (
 

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer2.jar
  )  (i also put the all of the files that i changed
 if
  anyone needs).
 
  Please, forget the previous link, and look at this
 new
  file.
 
  note that the extension of the file is indeed
 .zip.
  jroller does not allow to upload files with .zip
  extensions. Due to this reason, i change the
 extension
  of the file to .jar ( by renaming it) in order to
  upload it to the jroller. So, when you download
 it,
  change its extension to .zip .
 
Sedat
 
 
  --- sedat ciftci [EMAIL PROTECTED] wrote:
 
   Hello,
  
  I add a new property to roller that is
 related
   with
   the activation of user account via e-mail
   when the user register to the system.
  
  A brief summary of what i do:
  - i add a property to the roller.properties
 so
   that
   a user can turn on/off the registration of user
 with
   e-mail activation (property is
   user.account.activation.enabled).
  if user.account.activation.enabled=false,
   then a user can directly register to the roller,
 as
   it
   is done normally.
  if user.account.activation.enabled=true, then
   a user has to activate his/her account by
 clicking
   the
   link in the activation mail (when a user
 registers
   to
   roller, i save the user by setting the enabled
   property as false so that he/she can not login.
   Then,
   I create an activation code, associate it with
 this
   user, and send this code to the user via e-mail.
   When
   user clicks the link in this e-mail, user
 account is
   activated by setting the enabled property of
 this
   user
   to true and then the related activation code
 record
   is
   deleted from the database).
  
 I sent this email with the patch for the
 roller
   3.0
   as an attachment before, but this mail is not
   delivered to the roller-dev mail list. So, i put
   this
   file on jroller
  
 

(http://www.jroller.com/resources/s/sedat/newRollerProperty.jar);
   note that the extension of the file is indeed
 .zip.
   jroller does not allow to upload files with .zip
   extensions. Due to this reason, i change the
   extension
   of the file to .jar ( by renaming it) in order
 to
   upload it to the jroller. So, when you download
 it,
   change its extension to .zip .
  
 If you copy and paste the files to the
   roller 3.0  src and compile it, it will work. I
 do
   not
   try with roller 3.1 but i hope it will work (in
 this
   case, you have to copy the related code segments
 to
   the existing files in the roller 3.1 since there
 may
   be changes on these files after roller 3.0).
  
 I hope you like this feature.
  
 Sedat
  
  
  
  
 


   TV dinner still cooling?
   Check out Tonight's Picks on Yahoo! TV.
   http://tv.yahoo.com/
  
 
 
 
 
 


  Looking for earth-friendly autos?
  Browse Top Cars by Green Rating at Yahoo! Autos'
 Green Center.
  http://autos.yahoo.com/green_center/
 
 



 

We won't tell. Get more on shows you hate to love 
(and love to hate): Yahoo! TV's Guilty Pleasures list.
http://tv.yahoo.com/collections/265 


Re: Proposal: register user with e-mail activation

2007-03-17 Thread Dave

On 3/17/07, sedat ciftci [EMAIL PROTECTED] wrote:

Yes, you are right. I forget to include it. Here is the updated zip file:
http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar


Sedat,

I took a look at the patch this morning. Unfortunately, it targets the
3.0 code-base and enough has changed that most of the changes cannot
be applied to trunk.

Unfortunately, I don't have time right now to port your patch from 3.0
to trunk. But, if you are willing to update the patch to work with the
current trunk, then I'm willing to evaluate it and write-up a short
proposal so we can get it committed.

- Dave


Re: Proposal: register user with e-mail activation

2007-03-17 Thread sedat ciftci
Hello,

Here is the zip file that contains the patch to work
with the current trunk: 
http://www.jroller.com/resources/s/sedat/newRollerPropertyVer4.jar

Note that this patch file also contains new added
class (org.apache.roller.pojos.UserActivationData)

Note about sandbox:

I do not know anything about sandbox. I do not make
any changes on the files related under the directory
sandbox.

Sedat Çiftçi

--- Dave [EMAIL PROTECTED] wrote:

 On 3/17/07, sedat ciftci [EMAIL PROTECTED]
 wrote:
  Yes, you are right. I forget to include it. Here
 is the updated zip file:
 

http://www.jroller.com/resources/s/sedat/newRollerPropertyVer3.jar
 
 Sedat,
 
 I took a look at the patch this morning.
 Unfortunately, it targets the
 3.0 code-base and enough has changed that most of
 the changes cannot
 be applied to trunk.
 
 Unfortunately, I don't have time right now to port
 your patch from 3.0
 to trunk. But, if you are willing to update the
 patch to work with the
 current trunk, then I'm willing to evaluate it and
 write-up a short
 proposal so we can get it committed.
 
 - Dave
 



 

No need to miss a message. Get email on-the-go 
with Yahoo! Mail for Mobile. Get started.
http://mobile.yahoo.com/mail 


Re: Proposal: register user with e-mail activation

2007-03-16 Thread Dave

Sedat,

I don't see any DIFF patch file in the jar you sent. Perhaps you
forgot to include it?

- Dave



On 3/12/07, sedat ciftci [EMAIL PROTECTED] wrote:

I reprepare a single DIFF patch file plus the new
added file and put them into the (
http://www.jroller.com/resources/s/sedat/newRollerPropertyVer2.jar
)  (i also put the all of the files that i changed if
anyone needs).

Please, forget the previous link, and look at this new
file.

note that the extension of the file is indeed .zip.
jroller does not allow to upload files with .zip
extensions. Due to this reason, i change the extension
of the file to .jar ( by renaming it) in order to
upload it to the jroller. So, when you download it,
change its extension to .zip .

  Sedat


--- sedat ciftci [EMAIL PROTECTED] wrote:

 Hello,

I add a new property to roller that is related
 with
 the activation of user account via e-mail
 when the user register to the system.

A brief summary of what i do:
- i add a property to the roller.properties so
 that
 a user can turn on/off the registration of user with
 e-mail activation (property is
 user.account.activation.enabled).
if user.account.activation.enabled=false,
 then a user can directly register to the roller, as
 it
 is done normally.
if user.account.activation.enabled=true, then
 a user has to activate his/her account by clicking
 the
 link in the activation mail (when a user registers
 to
 roller, i save the user by setting the enabled
 property as false so that he/she can not login.
 Then,
 I create an activation code, associate it with this
 user, and send this code to the user via e-mail.
 When
 user clicks the link in this e-mail, user account is
 activated by setting the enabled property of this
 user
 to true and then the related activation code record
 is
 deleted from the database).

   I sent this email with the patch for the roller
 3.0
 as an attachment before, but this mail is not
 delivered to the roller-dev mail list. So, i put
 this
 file on jroller

(http://www.jroller.com/resources/s/sedat/newRollerProperty.jar);
 note that the extension of the file is indeed .zip.
 jroller does not allow to upload files with .zip
 extensions. Due to this reason, i change the
 extension
 of the file to .jar ( by renaming it) in order to
 upload it to the jroller. So, when you download it,
 change its extension to .zip .

   If you copy and paste the files to the
 roller 3.0  src and compile it, it will work. I do
 not
 try with roller 3.1 but i hope it will work (in this
 case, you have to copy the related code segments to
 the existing files in the roller 3.1 since there may
 be changes on these files after roller 3.0).

   I hope you like this feature.

   Sedat





 TV dinner still cooling?
 Check out Tonight's Picks on Yahoo! TV.
 http://tv.yahoo.com/






Looking for earth-friendly autos?
Browse Top Cars by Green Rating at Yahoo! Autos' Green Center.
http://autos.yahoo.com/green_center/



Proposal: register user with e-mail activation

2007-03-12 Thread sedat ciftci
Hello,

   I add a new property to roller that is related with
the activation of user account via e-mail
when the user register to the system. 

   A brief summary of what i do:
   - i add a property to the roller.properties so that
a user can turn on/off the registration of user with
e-mail activation (property is
user.account.activation.enabled).
   if user.account.activation.enabled=false,
then a user can directly register to the roller, as it
is done normally.
   if user.account.activation.enabled=true, then
a user has to activate his/her account by clicking the
link in the activation mail (when a user registers to
roller, i save the user by setting the enabled
property as false so that he/she can not login. Then,
I create an activation code, associate it with this
user, and send this code to the user via e-mail. When
user clicks the link in this e-mail, user account is
activated by setting the enabled property of this user
to true and then the related activation code record is
deleted from the database).

  I sent this email with the patch for the roller 3.0
as an attachment before, but this mail is not
delivered to the roller-dev mail list. So, i put this
file on jroller
(http://www.jroller.com/resources/s/sedat/newRollerProperty.jar);
note that the extension of the file is indeed .zip.
jroller does not allow to upload files with .zip
extensions. Due to this reason, i change the extension
of the file to .jar ( by renaming it) in order to
upload it to the jroller. So, when you download it,
change its extension to .zip .

  If you copy and paste the files to the
roller 3.0  src and compile it, it will work. I do not
try with roller 3.1 but i hope it will work (in this
case, you have to copy the related code segments to
the existing files in the roller 3.1 since there may
be changes on these files after roller 3.0).

  I hope you like this feature.
  
  Sedat  


 

TV dinner still cooling? 
Check out Tonight's Picks on Yahoo! TV.
http://tv.yahoo.com/


Re: Proposal: register user with e-mail activation

2007-03-12 Thread sedat ciftci
I reprepare a single DIFF patch file plus the new
added file and put them into the (
http://www.jroller.com/resources/s/sedat/newRollerPropertyVer2.jar
)  (i also put the all of the files that i changed if
anyone needs). 

Please, forget the previous link, and look at this new
file.

note that the extension of the file is indeed .zip.
jroller does not allow to upload files with .zip
extensions. Due to this reason, i change the extension
of the file to .jar ( by renaming it) in order to
upload it to the jroller. So, when you download it,
change its extension to .zip .

  Sedat


--- sedat ciftci [EMAIL PROTECTED] wrote:

 Hello,
 
I add a new property to roller that is related
 with
 the activation of user account via e-mail
 when the user register to the system. 
 
A brief summary of what i do:
- i add a property to the roller.properties so
 that
 a user can turn on/off the registration of user with
 e-mail activation (property is
 user.account.activation.enabled).
if user.account.activation.enabled=false,
 then a user can directly register to the roller, as
 it
 is done normally.
if user.account.activation.enabled=true, then
 a user has to activate his/her account by clicking
 the
 link in the activation mail (when a user registers
 to
 roller, i save the user by setting the enabled
 property as false so that he/she can not login.
 Then,
 I create an activation code, associate it with this
 user, and send this code to the user via e-mail.
 When
 user clicks the link in this e-mail, user account is
 activated by setting the enabled property of this
 user
 to true and then the related activation code record
 is
 deleted from the database).
 
   I sent this email with the patch for the roller
 3.0
 as an attachment before, but this mail is not
 delivered to the roller-dev mail list. So, i put
 this
 file on jroller

(http://www.jroller.com/resources/s/sedat/newRollerProperty.jar);
 note that the extension of the file is indeed .zip.
 jroller does not allow to upload files with .zip
 extensions. Due to this reason, i change the
 extension
 of the file to .jar ( by renaming it) in order to
 upload it to the jroller. So, when you download it,
 change its extension to .zip .
 
   If you copy and paste the files to the
 roller 3.0  src and compile it, it will work. I do
 not
 try with roller 3.1 but i hope it will work (in this
 case, you have to copy the related code segments to
 the existing files in the roller 3.1 since there may
 be changes on these files after roller 3.0).
 
   I hope you like this feature.
   
   Sedat  
 
 
  


 TV dinner still cooling? 
 Check out Tonight's Picks on Yahoo! TV.
 http://tv.yahoo.com/
 



 

Looking for earth-friendly autos? 
Browse Top Cars by Green Rating at Yahoo! Autos' Green Center.
http://autos.yahoo.com/green_center/