[Spacewalk-devel] Haskell API Bindings
Hi all. Have you ever pondered being able to use all goodness that Haskell has while working with Spacewalk API? Now you can try it :-) https://github.com/xkollar/spacewalk-api-hs Well... it is not complete, I implemented only those calls that I needed, but pull requests are (as allways) welcome. Matej. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] Outstanding pull requests
It is a pity that this one can't be merged automatically anymore because of 8c31e63 / 3daaad01 Matej, did you replace everything with 8 spaces? It was standard retab procedure with tabstop=8. So it would be simpler to describe it as fill with spaces to the next closest multiple of 8. There might be differences for files that had explicitly set tabstop to different value. I am unable to find commit 3daaad01. -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Branch for Spacewalk 2.1 has been created
Hi everyone, We have a new branch, SPACEWALK-2.1, to track our next release of Spacewalk. Spacewalk nightly builds will now be for Spacewalk 2.2. -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Date/Time picker
On 02/14/2014 03:16 PM, Michael Mraka wrote: should likely be / otherwise it produce opening tags not self closed tags. Actually in HTML5 void tags do not need the slash (it is optional). http://www.w3.org/TR/html-markup/syntax.html#void-element self-closing as a definition does not exist anymore in HTML5, except for SVG and MathML elements! We also recently started a discussion about this same topic and decided to stick to a coding standard rule to avoid confusion - namely not using those optional slashes in new code. I hope you are also fine with that. I was supposed to start a discussion with you in the next days, but this was faster :-) I am strongly against it. Ok, let me go a little deeper than that: * standard allows closing of tags, * HTML is generated on some places explicitly... are you sure it would not lead to state where we would be inconsistent (=bad), * in case we switch (and do it properly and completely) it would make it much harder to switch to say XHTML if desired, * without closing tags it would be like those evil old times with wild HTML... (not speaking about omitting closing tags...) * code that Michael commented on was wrong anyway as it only deleted symbol and immediately pended it. Matej ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Date/Time picker
-- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, February 14, 2014 3:43:32 PM Subject: Re: [Spacewalk-devel] [PATCH] Date/Time picker On 02/14/2014 03:16 PM, Michael Mraka wrote: should likely be / otherwise it produce opening tags not self closed tags. Actually in HTML5 void tags do not need the slash (it is optional). http://www.w3.org/TR/html-markup/syntax.html#void-element self-closing as a definition does not exist anymore in HTML5, except for SVG and MathML elements! We also recently started a discussion about this same topic and decided to stick to a coding standard rule to avoid confusion - namely not using those optional slashes in new code. I hope you are also fine with that. I was supposed to start a discussion with you in the next days, but this was faster :-) I am strongly against it. Thanks, -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches
Pushed to master as 1ae33e052ef7b449ed34b8bea9411bc45631c0e6. Two little things were fixed in following two commits: * 31d358af3f9707771107ed6887989d30e50f Consistent closing of void tags (as you said that you completely rewritten the page so I thought it would be nice co have it consistent). * 6303cdfbff967d124c8113b1ecef534ca71c610c While checking how the page looks you probably missed doubled colons. Thanks for contribution :-). -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Bo Maryniuk b...@suse.de To: Bo Maryniuk b...@suse.de, spacewalk-devel@redhat.com Sent: Monday, February 10, 2014 3:40:58 PM Subject: Re: [Spacewalk-devel] UI: Errata pages ASAP removal missing patches Hi, errata fix (again), must be applicable this time. -- Bo Maryniuk SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer No matter where you go in the world, there never seems to be a shortage of idiots. ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] On quality of patches
Hi all. We welcome community contributions and we want to maintain some level of quality. Natural expectation is that every proposed patch is tested for the functionality. However, recently I came across quite nasty little thing in Spacewalk... Using SSM to schedule reboot one might end up very unpleasantly surprised, expecting it not to occur for specified period of time, when in fact it is being scheduled as soon as possible, no matter what you try. (There was no way it ever worked - parameters for forms were not passed to script in request (where DatePicker looks for them) and new Date object was returned. Well, someone scamped his work, so I had to do it for him last night. And I consider myself lucky that I found out... As en exercise in applied imagination, try to imagine OSAD running on such machine. To stretch your imagination even further, imagine the machine acting as a life supporting computer during child surgery...) Btw: next time have a peek into struts-config.xml and look for form-bean and form-property tags... say like in eea3c6320bfc3dae8532844a7c0e71dcc5712c39. To continue with our story: Purpose of that form is to schedule action to occur not sooner than. It fails on all but one particular case. It simply cold not have been tested. Reboot is considered destructive operation. Therefore we insisted on two-step scheduling for this feature. I fixed this one but wonder how many other similar features there were recently introduced. And the final rhetorical question: Have the author even tried it before submitting the patch? I tend to doubt it. Matej ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
-- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Maximilian Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Friday, January 24, 2014 2:33:46 PM Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/24/2014 12:29 PM, Matej Kollar wrote: * Warning pop-up. * Could it be moved to the right or bottom of the filed? Yes. Though on the bottom it overlaps with the bar, and on the right it could end up being compressed, depending on the window size of your browser. I guess I could try to hang the popover on the bottom of the bar for example. Right now it's attached to the input field, which makes sense IMO. So I personally would keep it on top, what do you think? * It also blinks/flickers on change, is there a way to stop it? The popover needs to be destroyed and recreated to update it, otherwise it stacks up in the html output. That's where the flickering comes from. I am currently not aware of a workaround. The popover class has the methods show, hide, toggle and destroy. * Colored progress bar/strength meter. * It is connected with the password field in very strange way (visually). Would it be possible to change it as per Michael's suggestion to look like [1] or [2]? Personally I would prefer second option. I guess I could give it an extra column like in [2] and place it under the Confirm Password: field? * Spec * `jquery.pwstrength.bootstrap` is not good name for package. I suggest `pwstrength-bootstrap` (the .spec is called such anyway). I will rename it. * `Source0` is defined in a bit complicated way. Using [4] would not only be sufficient but will make it clearer and easier to understand. Agreed. I took a hint at https://fedoraproject.org/wiki/Packaging:SourceURL But I can change it as you said. Appreciate that you looked up some recommendations. However, the document you mention states: If the upstream does not create tarballs for releases, you can use this mechanism to produce them But upstream does create the tarball... [4]. Just saying ;-). * Is there simple way to change rules that determine what is acceptable password? * E.g. various character classes reminded me there are other ways to make good password :-). [3] [3] = Nice :) I couldn't imagine that yet... Yesterday the maintainer of that project also opened an issue: https://github.com/ablanco/jquery.pwstrength.bootstrap/issues/14 which points exactly to that illustration, so maybe soon there'll be support for that. -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
Pushed as series of patches ending last of which is 201b52db45f9c7f10b159bbbcb8d41b1b9fc6f2d. -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Maximilian Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, January 28, 2014 11:45:14 AM Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/24/2014 12:29 PM, Matej Kollar wrote: Hi everybody, here you can find the new patch with the following changes: Hi Maximilian. I see you have made some nice work there but there are still few things that need to be fixed. * Warning pop-up. * Could it be moved to the right or bottom of the filed? * It also blinks/flickers on change, is there a way to stop it? * Colored progress bar/strength meter. * It is connected with the password field in very strange way (visually). Would it be possible to change it as per Michael's suggestion to look like [1] or [2]? Personally I would prefer second option. * progress bar now has its own named column * Spec * `jquery.pwstrength.bootstrap` is not good name for package. I suggest `pwstrength-bootstrap` (the .spec is called such anyway). * package name == filename * `Source0` is defined in a bit complicated way. Using [4] would not only be sufficient but will make it clearer and easier to understand. Source0 is now readable :) as in [4] * Is there simple way to change rules that determine what is acceptable password? * E.g. various character classes reminded me there are other ways to make good password :-). [3] Thanks for the effort invested and keep up good work :-). [1] http://www.jqueryscript.net/demo/Simple-jQuery-Password-Strength-Indicator-Plugin-passMeter/ [2] http://cdn1.freshdesignweb.com/wp-content/uploads/2011/09/jquery-password-strength-meter-005.jpg [3] http://xkcd.com/936/ [4] https://github.com/ablanco/jquery.pwstrength.bootstrap/archive/1.0.2.tar.gz please check it out, and tell me if I missed something. Thank you Maximilian -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk
Hi Maximilian. I see you have made some nice work there but there are still few things that need to be fixed. * Warning pop-up. * Could it be moved to the right or bottom of the filed? * It also blinks/flickers on change, is there a way to stop it? * Colored progress bar/strength meter. * It is connected with the password field in very strange way (visually). Would it be possible to change it as per Michael's suggestion to look like [1] or [2]? Personally I would prefer second option. * Spec * `jquery.pwstrength.bootstrap` is not good name for package. I suggest `pwstrength-bootstrap` (the .spec is called such anyway). * `Source0` is defined in a bit complicated way. Using [4] would not only be sufficient but will make it clearer and easier to understand. * Is there simple way to change rules that determine what is acceptable password? * E.g. various character classes reminded me there are other ways to make good password :-). [3] Thanks for the effort invested and keep up good work :-). [1] http://www.jqueryscript.net/demo/Simple-jQuery-Password-Strength-Indicator-Plugin-passMeter/ [2] http://cdn1.freshdesignweb.com/wp-content/uploads/2011/09/jquery-password-strength-meter-005.jpg [3] http://xkcd.com/936/ [4] https://github.com/ablanco/jquery.pwstrength.bootstrap/archive/1.0.2.tar.gz Sincerely -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Maximilian Meister mmeis...@suse.de To: spacewalk-devel@redhat.com Sent: Thursday, January 23, 2014 2:08:56 PM Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to spacewalk On 01/23/2014 11:04 AM, Michael Mraka wrote: Hi Maximilian, that sounds great. % Question is now do I need to package the second .js as well? Or can % i simply add it to the git tree % in web/html/javascript? If it's spacewalk specific (I think so) then just put it to web/html/javascript next to other spacewalk-*.js. Hi, here is the new patch with the * recent release of jquery.pwstrength.bootstrap * a spec file to build a package from it * the patch to the sources during rpmbuild * the customization/caller script + a function to generate the tick icon * custom styles for the password strength meter please have a look. Thanks -- -- Mit freundlichen Grüßen, Maximilian Meister Systems Management Department SUSE LINUX Products GmbH Maxfeldstr. 5 D-90409 Nuremberg, Germany http://www.suse.com GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] Eclipse with Spacewalk Java code
Hi all. In case you tried to use Eclipse to edit Spacewalk Java stuff and followed these instructions [1], you might have failed. If so, you might want to give it another try, as Stephen took a look and fixed the problem (well, at least it works for me now ;-). Thanks Stephen! Matej [1] https://fedorahosted.org/spacewalk/wiki/EclipseSetup -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java
Thanks for your patchs, I have applied/pushed them to the master. -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Silvio Moioli smoi...@suse.de To: spacewalk-devel@redhat.com Sent: Tuesday, January 21, 2014 6:19:49 PM Subject: Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java On 01/21/2014 01:26 PM, Matej Kollar wrote: * $Rev$ is legacy of our old versioning system (cvs) and has no use now that we use git (and we would not like to see it in new code). Just to have everyone informed: I used those tags because they were required by checkstyle_eclipse.xml. Matej will fix that configuration file, meanwhile I fixed the patch. By the way I also fixed my review-pending branches with these commits: e9ac621 - master-pxe-default-image-no-powermanagement 9e04ed5 - master-power-management-ssm * Preferred space indentation for `.jsp` files is 2 spaces. As discussed, since there is no current standard in Spacewalk and the Oracle code conventions for JSP is four spaces[1], we will stick with four. Of course we can revert the decision later if a decision is taken. * Use of `property=dispatch` for submit button isn't needed when the only thing you actually check is `isSubmitted(form)`. [...] Agreed, fixed. * Confirm button -- I would prefer Reboot system that was used on `.pxt` page.. Fixed. * Using sid: [...] one sid is enough. Okay! :-) Thanks for your review and thorough explanations. Regards [1] http://www.oracle.com/technetwork/articles/javase/code-convention-138726.html -- Silvio Moioli SUSE LINUX Products GmbH Maxfeldstraße 5, 90409 Nürnberg Germany ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Single-system reboot page ported to Java
Dear Spacewalkers, Those two patches are from my colleague Michael Calmer and they contain ported Java code for the reboot page. Patch 0002 removes stale Perl code; HTML has been adapted for Bootstrap already. Bootstrap porting of the Date picker widget, as you know, is being tackled separately. Hello Silvio, I've reviewed Michael's patches and have couple of notes: * $Rev$ is legacy of our old versioning system (cvs) and has no use now that we use git (and we would not like to see it in new code). * Preferred space indentation for `.jsp` files is 2 spaces. * Use of `property=dispatch` for submit button isn't needed when the only thing you actually check is `isSubmitted(form)`. Example of usage of `dispatch` can be found in `com/redhat/rhn/frontend/taglibs/list/helper/ListSetHelper.java`. It is however used for more complicated stuff, e.g.: Form where you can change parameters of how things are displayed (number of displayed systems per page) and at the same time perform some action (reboot selected systems). Property `dispatch` is there so you (or some helper) can tell them apart. * Confirm button -- I would prefer Reboot system that was used on `.pxt` page.. * Using sid: I can see that you actually made it a little better by abstracting sid into variable rather than repeating same string all over the place (as it is unfortunately now on many places :-(). And I see that you try to sensibly differentiate between uses of sid for include header and sid for request purposes, but my opinion is that we do not need this level of differentiating things and that one sid is enough. So please either do `SID_PARAMETER = RequestContext.SID` or just use that one. (Not arguing that `RequestContext.SID` is the right source to take it from. In case you find better one I will be glad.) Other than that, the patches look good and follow conventions that are in the existing code and I will be more than happy to apply them. Could you/Michael please fix the above issues? Sincerely -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] New way for displaying icons
Hi all. Say yay [1] to little change in rhn:icon tag -- title is from now on supposed to contain localization string instead of raw data. For example rhn:icon type=system-ok title=spacewalk.shark.funnyMessage / This will have following advantages: * less code -- otherwise you would be doing dereferencing of localization messages anyway (if done properly); * enforcing internationalization -- if you add title to icon (which is not always needed, only when icon is (or might end up being) the only visible element for some action (e.g. Sign Out)), it simply have to be internationalized; * old way was not working for this tag anyway; * and probably more ;-). Enjoy. [1] NbIGnY_DSIE -- Matej Kollar Satellite Engineering, Red Hat - Original Message - From: Tomáš Kašpárek tkaspa...@redhat.com To: spacewalk-devel@redhat.com Sent: Tuesday, December 10, 2013 11:02:10 AM Subject: [Spacewalk-devel] New way for displaying icons Hello, Hello as new Spacewalk webUI brought new icons with itself and many of those icons are used at many places, scattered across entire webUI, some effort would be required if any of those icons would need to be changed for whatever reason (sure, nothing that grep and sed can't handle). For this reason I've implemented new rhn:icon tag, so icon definitions like fa fa-check-circle fa-1-5x text-success are all put at one place and only this would need to be changed if any changes are needed. I am not calling for using rhn:icon for every icon in Spacewalk (espetialy those that are used only in one place), but if you know that some icon is or will be used multiple times, please consider using the new tag. It will make future changes easier ;-) Syntax of the new tag is following: rhn:icon type=system-ok title=I am dangerous shark! / Type is mandatory and it must be one of the HashMap keys specified in IconTag.java. Title is optional and as it's name says it will place title for the icon. Any comments are welcome Regards -- Tomáš Kašpárek Red Hat Satellite 5, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] - BZ#1021930 - From WebUI configuration files diff functionality for User, group and mode
Hello Team, According to current functionality for configuration files: From WebUI, config file comparison doesnt check for user, group and permissions. It displays compare results for only selinux and file content. Other way when checking from client side rhncfg-client verify It display diff results for user, group, permissions, selinux and file content Bugzilla - https://bugzilla.redhat.com/show_bug.cgi?id=1021930 Attached the proposed patch to add User, mode and permissions diff results to web-UI similar to CLI. Please share your feedback on this. Thanks, Neha Hello Neha. I see lack of information regarding permission change as problematic too, so time and thoughts you have invested into this issue is greatly appreciated :-). I have seen few example results of code you have provided, here are some rather general thoughts: * There is no formal specification of diff format beyond implementation. Document that describes at least something and is from relevant source [https://www.gnu.org/software/diffutils/manual/html_node/Detailed-Unified.html] is not very precise (or is there better source?). That complicates things a little. * Cited source says that The unified output format starts with a two-line header, which looks like this, introducing ambiguity (while based on that wording I personally would say that patch must start with those two lines, one of referential implementations (patch) accepts diffs that start with garbage as long as valid header and chunks follows). * So it looks like your solution would work: * there is additional information for the user; * information is gracefully ignored by `patch`, so it can be used. But... there is too often but in my thoughts I'm afraid :-/ ... specification is interpreted so that the two-line header must be present and followed by at least one hunk. This is a complication, as in case where only permissions are changed, your code would produce output, that is not valid (by impolite language of patch only garbage was found in the patch input). I can imagine all those people complaining that lines we present to them as diff is not a diff. Adding header without hunk would not help, and adding some obscure hunk that would say that nothing has been changed (I haven't tried that, so I do not know whether that would be possible or not) is simply not good idea. Another (I admit only hypothetical) thing to consider is, that this being patch, someone might think that added part of file have some semantic beyond being just a comment for reader/user. Maybe some kind of separate meta-data that would describe the permissions change? I wish I would have been able to help some more here. As I said: those are only my thoughts. Maybe someone else would like to add something or correct me in case I'm wrong. Thanks again :-) -- Matej Kollar Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
