Re: [Spacewalk-devel] rhn-prefix check when creating new channel

[Duncan Mac-Vicar P.]

On 03/02/2012 04:20 PM, Miroslav Suchý wrote:

On 03/02/2012 02:57 PM, Duncan Mac-Vicar P. wrote:

 As we replaced
some errror messages Redhat with a configurable vendor string
we now get the error message as


Did I miss this patch?


- Or its generic version: make it a vendor restriction and the regex
configurable


Hmm, this one sounds best to me.


For channel validation there seems to be a bunch of duplicated code: 
NewChannelHelper and CreateChannelCommand both perform very similar 
validations.


If I make the regexp rhn independent, configurable and 
switchable/optional it would be easier if the validations are refactored 
in one place.


I think the right place for the validations is the helper, and the 
command class should consume the validations from the helper. Is that fine?


Duncan






___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

[Spacewalk-devel] rhn-prefix check when creating new channel

[Duncan Mac-Vicar P.]

Hi Astronauts

The create channel page does a check for a prefix rhn-*. As we replaced 
some errror messages Redhat with a configurable vendor string

we now get the error message as

SUSE channels creation need admin privileges (or something like that)

We are discussing how to remove that check in the best 
upstream-friendly way possible:


- remove the restriction completely
 (btw, the regex is duplicated, I guess CreateChannelCommand could use 
 the one in NewChannelHelper instead)

- Allow to disable the check
- Or its generic version: make it a vendor restriction and the regex 
configurable


What do you think?

In any case we need to get rid of the check, we are trying to avoid a 
patch in our tree that would live forever.


cheers

--
Duncan Mac-Vicar P. - http://www.suse.com/

SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix 
Imendörffer, HRB 16746 (AG Nürnberg)

Maxfeldstraße 5, 90409 Nürnberg, Germany

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel