Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
Peter Rossbach wrote: The issue is that this mechanism is bad, period. Why it is so bad? The implementation was faster then the revert mapper state. What is a better way to implement this feature? The optimization is just a ploy to force feed us with the feature. As I said, using a slightly different algorithm for exact (with or without case sensitivity) matches may be a good idea, but it is completely separate from the feature addition itself. I think the implementation provided of the algorithm could likely be cleaner (= more generic). The wild card alias usage is very useful for tomcat hoster. Now the customer can use a new host subdomain without change the server.xml. Very nice and the admin must do nothing. And the usefulness of that is non existent as well. What's the purpose of adding hosts if they are all the same ? Easy: Hoster has installed the site with mydomain.net and later your customer want www.mydomain.net, foto.mydomain.net, or you have an application (blog,wiki,cms) that people can register and then there get an own universe (new subdomain). Currently I add new Alias to the Host section and save the server.xml without context.xml writing ( feature from new storeconfig module). With the same webapps ? (with what you describe, you can access those virtual virtual host any way you want, and it serves no purpose, as they will all look the same) This will almost never happen. In all other cases (which are bound to happen more often) deployment steps are needed. Why add this crap for nothing ? Other scenario: what if you have a.foo.com and b.foo.com, and you want to add an alias for a and an alias for b. Oops, sorry I guess ... This just proves it is a special purpose feature, and the person should do its own customization. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
-Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Saturday, June 04, 2005 11:30 AM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java And the usefulness of that is non existent as well. What's the purpose of adding hosts if they are all the same ? The reasoning as I explained in my very lengthy message justifying the patch is to allow the application to have different behaviors based on the virtual host name, without having to re-configure tomcat. -1 vote for this feature. Rémy George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
-Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Saturday, June 04, 2005 1:27 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Saturday, June 04, 2005 10:29 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The issue is that this mechanism is bad, period. I have to agree with Remy on this. The issue is that the code is just plain bad :(. So I'm going to add my -1 to the patch until the There's no justification here. Explain why you think the code is bad it's actually a hell of a lot cleaner and easier to follow than the original code, and it's 15% faster. What exactly are your criteria for measuring goodness. mechanism is cleaned up. In fact, I'd have -1ed it just for the import com.sun. line alone. I don't know what you are looking at. My submission had NO com.sun.xxx class imports. Perhaps you missed the thread where I said I rewrote it? http://www.mhsoftware.com/~gsexton/HostMap.java http://www.mhsoftware.com/~gsexton/Mapper.java If you are going to -1 some code, you should at least look at it. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
George Sexton wrote: The reasoning as I explained in my very lengthy message justifying the patch is to allow the application to have different behaviors based on the virtual host name, without having to re-configure tomcat. Thanks, I didn't understand ;) What is amazing is that you're advocating coding virtual hosting in the application itself ... I recommend you don't waste your time and continue arguing for this feature to get it, as it will not. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
George Sexton wrote: There's no justification here. Explain why you think the code is bad it's actually a hell of a lot cleaner and easier to follow than the original code, and it's 15% faster. What exactly are your criteria for measuring goodness. I stated the reason, and the main one is that it should I think be more generic. The performance improvement is just a lame trick to push through your feature, as this could as well be submitted as two separate patches (the first one being the optimizations, and the second one the wildcard host feature addition which I would -1). hell of a lot just made me laugh, BTW ;) Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
- Original Message - From: George Sexton [EMAIL PROTECTED] To: 'Tomcat Developers List' tomcat-dev@jakarta.apache.org Sent: Sunday, June 05, 2005 8:53 AM Subject: RE: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java -Original Message- From: Bill Barker [mailto:[EMAIL PROTECTED] Sent: Saturday, June 04, 2005 1:27 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java - Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Saturday, June 04, 2005 10:29 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/htt p/mapper HostMap.java Mapper.java Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The issue is that this mechanism is bad, period. I have to agree with Remy on this. The issue is that the code is just plain bad :(. So I'm going to add my -1 to the patch until the There's no justification here. Explain why you think the code is bad it's actually a hell of a lot cleaner and easier to follow than the original code, and it's 15% faster. What exactly are your criteria for measuring goodness. Well, the gratuitous cloning of the HostMap is bad for one. It looks like an attempt to avoid a sync in a non-critial path, but of course it can't possibly work. Before I could move to +1, the code would have to be (like Remy says) a lot more generic. Especially with pre-compiled JSPs, there are a lot of cases where you'd get a lot more bang doing this type of optimization for servlet-mappings than for Hosts. mechanism is cleaned up. In fact, I'd have -1ed it just for the import com.sun. line alone. I don't know what you are looking at. My submission had NO com.sun.xxx class imports. I'm looking at the commit message, obviously. That's what we are voting on ;-). Perhaps you missed the thread where I said I rewrote it? http://www.mhsoftware.com/~gsexton/HostMap.java http://www.mhsoftware.com/~gsexton/Mapper.java If you are going to -1 some code, you should at least look at it. George Sexton MH Software, Inc. http://www.mhsoftware.com/ Voice: 303 438 9585 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
[EMAIL PROTECTED] wrote: pero2005/06/04 05:32:53 Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java Added: util/java/org/apache/tomcat/util/http/mapper HostMap.java Log: Support Host Alias matching with Connector attribute allowedAliasMatches Submitted by George Sexton You're not giving up, eh ? ;) Good, because neither do I. First, the bad behavior of the algorithm (adding hosts) has not been changed. Everything seems to indicate that the algorithm is bound to mess up any possible dynamic management of hosts. I also have to insist that this feature addition is useless. The idea of using a different algorithm for exact matching is good (not critical, but good), but I am agaist this wildcard host feature. -1. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
Hey Remy, For usefull feature I don't give up :-) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The wild card alias usage is very useful for tomcat hoster. Now the customer can use a new host subdomain without change the server.xml. Very nice and the admin must do nothing. simple add first time Alias*.mydomain.net/Alias to your host. +1 vote for this feature. Peter Remy Maucherat schrieb: [EMAIL PROTECTED] wrote: pero2005/06/04 05:32:53 Modified:util/java/org/apache/tomcat/util/http/mapper Mapper.java Added: util/java/org/apache/tomcat/util/http/mapper HostMap.java Log: Support Host Alias matching with Connector attribute allowedAliasMatches Submitted by George Sexton You're not giving up, eh ? ;) Good, because neither do I. First, the bad behavior of the algorithm (adding hosts) has not been changed. Everything seems to indicate that the algorithm is bound to mess up any possible dynamic management of hosts. I also have to insist that this feature addition is useless. The idea of using a different algorithm for exact matching is good (not critical, but good), but I am agaist this wildcard host feature. -1. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The issue is that this mechanism is bad, period. The wild card alias usage is very useful for tomcat hoster. Now the customer can use a new host subdomain without change the server.xml. Very nice and the admin must do nothing. And the usefulness of that is non existent as well. What's the purpose of adding hosts if they are all the same ? simple add first time Alias*.mydomain.net/Alias to your host. +1 vote for this feature. -1 vote for this feature. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
- Original Message - From: Remy Maucherat [EMAIL PROTECTED] To: Tomcat Developers List tomcat-dev@jakarta.apache.org Sent: Saturday, June 04, 2005 10:29 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The issue is that this mechanism is bad, period. I have to agree with Remy on this. The issue is that the code is just plain bad :(. So I'm going to add my -1 to the patch until the mechanism is cleaned up. In fact, I'd have -1ed it just for the import com.sun. line alone. The wild card alias usage is very useful for tomcat hoster. Now the customer can use a new host subdomain without change the server.xml. Very nice and the admin must do nothing. And the usefulness of that is non existent as well. What's the purpose of adding hosts if they are all the same ? simple add first time Alias*.mydomain.net/Alias to your host. +1 vote for this feature. -1 vote for this feature. Rémy This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/http/mapper HostMap.java Mapper.java
Hey. Remy Maucherat schrieb: Peter Rossbach wrote: Hey Remy, For usefull feature I don't give up :-) Fine, I'll just revert your patch then ;) Hmm, thanks for that... :-( The default of host alias matching is off. The current implementation is little bit fast then the old one. (Great) Every user of this feature can limit the dynamic host addition with Connector port=8080 allowedAliasMatches=10 / The issue is that this mechanism is bad, period. Why it is so bad? The implementation was faster then the revert mapper state. What is a better way to implement this feature? The wild card alias usage is very useful for tomcat hoster. Now the customer can use a new host subdomain without change the server.xml. Very nice and the admin must do nothing. And the usefulness of that is non existent as well. What's the purpose of adding hosts if they are all the same ? Easy: Hoster has installed the site with mydomain.net and later your customer want www.mydomain.net, foto.mydomain.net, or you have an application (blog,wiki,cms) that people can register and then there get an own universe (new subdomain). Currently I add new Alias to the Host section and save the server.xml without context.xml writing ( feature from new storeconfig module). (Bill: the com.sun... package not used inside code... My fault.) simple add first time Alias*.mydomain.net/Alias to your host. +1 vote for this feature. -1 vote for this feature. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
