Re: Key-Encryption-key support, r1334257

2012-11-20 Thread Adam Heath
On 11/18/2012 05:38 AM, Carsten Schinzer wrote: Hello again and thanks. ant target works, the different jarfile does in principle as well, would need the full cp though incuding the reference to commons-codec library. I got my stuff and will continue working my way through to make my

Re: Slim-down effort: current situation

2012-11-20 Thread Adam Heath
On 11/16/2012 05:40 AM, Jacques Le Roux wrote: Very well summed up, Paul Thanks Jacques From: madppiper p...@ilscipio.com @jacopo: That sounds like a terrific idea of yours! I have to read up on [Proposal], but from your outline here, i would say it is a more sincere step.

Re: Is it a good time to remove the debian folder?

2012-11-15 Thread Adam Heath
On 11/15/2012 10:54 AM, Jacopo Cappellato wrote: This is now completed at rev. 1409880 https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Attic Jacopo On Jul 26, 2012, at 8:09 AM, Jacopo Cappellato wrote: ... the removal will be documented, as usual, in the Attic page:

Re: Is it a good time to remove the debian folder?

2012-11-15 Thread Adam Heath
On 11/15/2012 11:49 AM, Adam Heath wrote: 4: Start filing issue trees in jira for pure upstream work. This would include things like removing embedded libraries(maybe a post-download kinda thing). (responding to myself). Debian-policy says that any upload to main(and therefore is DFSG), must

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-06 Thread Adam Heath
On 11/06/2012 11:10 AM, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 02:26:20PM -0700, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote: On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist

Bug#691508: [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-06 Thread Adam Heath
On 11/06/2012 11:10 AM, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 02:26:20PM -0700, Ben Pfaff wrote: On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote: On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 12:49 PM, Ben Pfaff wrote: On Mon, Oct 29, 2012 at 03:03:13PM -0500, Adam Heath wrote: On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a global option? The call would not do anything useful, because it would exit with a fatal error every time. Taking this argument to its logical conclusion, one

Bug#691508: [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 12:49 PM, Ben Pfaff wrote: On Mon, Oct 29, 2012 at 03:03:13PM -0500, Adam Heath wrote: On 10/29/2012 11:34 AM, Ben Pfaff wrote: Until now, a command like ovs-vsctl --may-exist add-br br0 yielded a confusing error message. Users had to realize that the correct form was ovs-vsctl

Bug#691508: [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-11-02 Thread Adam Heath
On 11/02/2012 04:19 PM, Ben Pfaff wrote: I still don't understand. Why would an existing script call ovs-vsctl with --may-exist as a global option? The call would not do anything useful, because it would exit with a fatal error every time. Taking this argument to its logical conclusion, one

Re: [ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-10-29 Thread Adam Heath
: 691...@bugs.debian.org Reported-by: Adam Heath doo...@brainfood.com Signed-off-by: Ben Pfaff b...@nicira.com --- AUTHORS |1 + tests/ovs-vsctl.at | 13 - utilities/ovs-vsctl.8.in | 11 ++-- utilities/ovs-vsctl.c| 131

Bug#691508: [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

2012-10-29 Thread Adam Heath
: 691...@bugs.debian.org Reported-by: Adam Heath doo...@brainfood.com Signed-off-by: Ben Pfaff b...@nicira.com --- AUTHORS |1 + tests/ovs-vsctl.at | 13 - utilities/ovs-vsctl.8.in | 11 ++-- utilities/ovs-vsctl.c| 131

[ovs-dev] Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
Package: openvswitch-switch Version: 1.4.2+git20120612-9 From the man page: [--may-exist] add-br bridge [--may-exist] add-br bridge parent vlan [--may-exist] add-port bridge port [column[:key]=value]... [--if-exists] del-port [bridge] port From my script: ++

[ovs-dev] Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
On 10/26/2012 11:43 AM, Ben Pfaff wrote: [snip] Right you are, mea-culpa. You're right that there is an example in the manpage, showing exactly what I want. Sorry for the noise, and thanks for the fast response. ___ dev mailing list

[ovs-dev] Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
On 10/26/2012 01:11 PM, Ben Pfaff wrote: On Fri, Oct 26, 2012 at 01:00:32PM -0500, Adam Heath wrote: On 10/26/2012 11:43 AM, Ben Pfaff wrote: [snip] Right you are, mea-culpa. You're right that there is an example in the manpage, showing exactly what I want. Sorry for the noise

Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
Package: openvswitch-switch Version: 1.4.2+git20120612-9 From the man page: [--may-exist] add-br bridge [--may-exist] add-br bridge parent vlan [--may-exist] add-port bridge port [column[:key]=value]... [--if-exists] del-port [bridge] port From my script: ++

Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
On 10/26/2012 11:43 AM, Ben Pfaff wrote: [snip] Right you are, mea-culpa. You're right that there is an example in the manpage, showing exactly what I want. Sorry for the noise, and thanks for the fast response. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a

Bug#691508: ovs-vsctl: --may-exist --if-exists don't work

2012-10-26 Thread Adam Heath
On 10/26/2012 01:11 PM, Ben Pfaff wrote: On Fri, Oct 26, 2012 at 01:00:32PM -0500, Adam Heath wrote: On 10/26/2012 11:43 AM, Ben Pfaff wrote: [snip] Right you are, mea-culpa. You're right that there is an example in the manpage, showing exactly what I want. Sorry for the noise

[jira] [Commented] (OFBIZ-1151) Passwords are not salted

2012-10-09 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472521#comment-13472521 ] Adam Heath commented on OFBIZ-1151: --- Technically, *any* hard-coded value, even hashed

[Google Maps API v3] Re: Zoom issues on iPad when the page itself is zoomed

2012-08-14 Thread Adam Heath
Doesn't look like it, the issue is still just confirmed: http://code.google.com/p/gmaps-api-issues/issues/detail?id=4046 On Tuesday, August 14, 2012 7:28:47 PM UTC+8, dragos wrote: Hi William, Any luck in solving this issue? Thank you On Monday, May 23, 2011 12:06:30 AM UTC-4, William

Re: svn commit: r1346269 - /ofbiz/trunk/framework/entity/ofbiz-component.xml

2012-06-05 Thread Adam Heath
On 06/05/2012 02:35 AM, hans...@apache.org wrote: Author: hansbak Date: Tue Jun 5 07:35:26 2012 New Revision: 1346269 URL: http://svn.apache.org/viewvc?rev=1346269view=rev Log: enable tenant demo data Modified: ofbiz/trunk/framework/entity/ofbiz-component.xml Modified:

Re: Groovy and ScriptUtil: pragmatic consideration

2012-06-03 Thread Adam Heath
On 06/03/2012 07:47 AM, Jacques Le Roux wrote: For https://issues.apache.org/jira/browse/OFBIZ-4882 I stumbled upon this with OOTB setting for ScriptUtil exception report -- Error running script at location

Re: svn commit: r1345660 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductSummary.groovy

2012-06-03 Thread Adam Heath
On 06/03/2012 07:08 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Jun 3 12:08:00 2012 New Revision: 1345660 URL: http://svn.apache.org/viewvc?rev=1345660view=rev Log: Fixes QuickAdd screen rendering exception in ecommerce https://issues.apache.org/jira/browse/OFBIZ-4882 It was only

Re: svn commit: r1345661 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductSummary.groovy

2012-06-03 Thread Adam Heath
On 06/03/2012 07:20 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Jun 3 12:20:48 2012 New Revision: 1345661 URL: http://svn.apache.org/viewvc?rev=1345661view=rev Log: Revert r1345660, I was caught by the cache I thought it was only that when another change I put before was also

Re: svn commit: r1345661 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductSummary.groovy

2012-06-03 Thread Adam Heath
On 06/03/2012 02:52 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 06/03/2012 07:20 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Jun 3 12:20:48 2012 New Revision: 1345661 URL: http://svn.apache.org/viewvc?rev=1345661view=rev Log: Revert r1345660, I was caught

Re: svn commit: r1345661 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ProductSummary.groovy

2012-06-03 Thread Adam Heath
On 06/03/2012 03:45 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 06/03/2012 02:52 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 06/03/2012 07:20 AM, jler...@apache.org wrote: Author: jleroux Date: Sun Jun 3 12:20:48 2012 New Revision: 1345661 URL

Re: Minilang error

2012-06-03 Thread Adam Heath
On 06/03/2012 04:48 PM, Adrian Crum wrote: I am unable to reproduce that error. Someone didn't do a clean, which mean their build/lib/foo.jar wasn't rebuilt, so it had an older META-INF/services that referenced a class that had been removed. Or something like that. -Adrian On 6/3/2012

Re: svn commit: r1345652 [1/2] - in /ofbiz/trunk/framework/minilang: dtd/ src/META-INF/services/ src/org/ofbiz/minilang/method/entityops/ src/org/ofbiz/minilang/method/envops/

2012-06-03 Thread Adam Heath
On 06/03/2012 04:51 PM, Adrian Crum wrote: This commit is one of many similar commits that have been made over the last three months. There was a Mini-language overhaul discussion on the dev mailing list. Sure, I know there was a discussion. But 2 years from now, when someone is looking at

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath
On 06/02/2012 11:51 AM, Jacques Le Roux wrote: Hi Adam, I don't know what others think about that, but personnally I don't like it. For instance we get now from beginning of the line (trailers blanks included) The terminal on my laptop is 198 chars. At work it's 147. But that doesn't

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath
On 06/02/2012 01:06 PM, Jacopo Cappellato wrote: On Jun 2, 2012, at 7:15 PM, Adam Heath wrote: There is no way that we can ever enforce a single, unified width. Screen sizes change, font sizes change. It's too political to come up with a solution. So, the only fallback is to never split

Re: svn commit: r1343472 - in /ofbiz/trunk/applications: accounting/src/org/ofbiz/accounting/invoice/ manufacturing/src/org/ofbiz/manufacturing/bom/ manufacturing/src/org/ofbiz/manufacturing/jobshopmg

2012-06-02 Thread Adam Heath
On 06/02/2012 01:14 PM, Jacopo Cappellato wrote: On Jun 2, 2012, at 8:10 PM, Adam Heath wrote: In the commit you commented on, Oh no, it was Jacques not me :-) Jacopo No, really, I don't get you two confused. I just wasn't paying attention. I've only had half a cup of coffee today.

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 01:53 AM, Jacopo Cappellato wrote: On May 31, 2012, at 6:10 PM, Adam Heath wrote: Component/TenantComponent entities are defined in framework/entity. However, that code does not use them. entityext does. They should be moved to the later component. +1 I've currently got

Re: Remove PartyContactMech.(months|years)WithContactMech?

2012-06-01 Thread Adam Heath
On 06/01/2012 12:42 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 6:44 AM, Scott Gray wrote: The only problem there would be that the information would need to be known when the record was created since fromDate forms part of the primary key. It's entirely possible that the user could

Re: [jira] [Commented] (OFBIZ-4916) Applying change of commit r1343156 to other ftls.

2012-06-01 Thread Adam Heath
On 06/01/2012 04:27 AM, Jacopo Cappellato (JIRA) wrote: [ https://issues.apache.org/jira/browse/OFBIZ-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287291#comment-13287291 ] Jacopo Cappellato commented on OFBIZ-4916:

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 10:20 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 4:59 PM, Adam Heath wrote: entity depends on geronimo and entityext components, because of defaults in the code and entityengine.xml. entityext depends on service. as a side note: I am currently working

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 10:52 AM, Adam Heath wrote: On 06/01/2012 10:20 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 4:59 PM, Adam Heath wrote: entity depends on geronimo and entityext components, because of defaults in the code and entityengine.xml. entityext depends on service. as a side note

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 11:52 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 6:48 PM, Jacopo Cappellato wrote: On Jun 1, 2012, at 5:52 PM, Adam Heath wrote: What is different about the new implementation? Or what problems are you trying to solve? I am in a rush now, I am sorry but I will share

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 11:48 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 5:52 PM, Adam Heath wrote: What is different about the new implementation? Or what problems are you trying to solve? I am in a rush now, I am sorry but I will share details about what I am trying to do and why

Re: Component/TenantComponent entities

2012-06-01 Thread Adam Heath
On 06/01/2012 12:16 PM, Adrian Crum wrote: On 6/1/2012 4:55 PM, Adam Heath wrote: On 06/01/2012 10:52 AM, Adam Heath wrote: On 06/01/2012 10:20 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 4:59 PM, Adam Heath wrote: entity depends on geronimo and entityext components, because

Re: Remove PartyContactMech.(months|years)WithContactMech?

2012-06-01 Thread Adam Heath
On 06/01/2012 12:29 PM, Adrian Crum wrote: On 6/1/2012 6:42 AM, Jacopo Cappellato wrote: On Jun 1, 2012, at 6:44 AM, Scott Gray wrote: The only problem there would be that the information would need to be known when the record was created since fromDate forms part of the primary key. It's

Re: svn commit: r1345379 [1/27] - in /ofbiz/trunk: applications/accounting/config/ applications/commonext/config/ applications/content/config/ applications/humanres/config/ applications/manufacturing/

2012-06-01 Thread Adam Heath
On 06/01/2012 05:32 PM, jler...@apache.org wrote: Author: jleroux Date: Fri Jun 1 22:32:57 2012 New Revision: 1345379 URL: http://svn.apache.org/viewvc?rev=1345379view=rev Log: A patch from Tri Duc Vo for Next Vietnamese Ofbiz translation https://issues.apache.org/jira/browse/OFBIZ-4759

Re: svn commit: r1345379 [1/27] - in /ofbiz/trunk: applications/accounting/config/ applications/commonext/config/ applications/content/config/ applications/humanres/config/ applications/manufacturing/

2012-06-01 Thread Adam Heath
On 06/01/2012 11:41 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 06/01/2012 05:32 PM, jler...@apache.org wrote: Author: jleroux Date: Fri Jun 1 22:32:57 2012 New Revision: 1345379 URL: http://svn.apache.org/viewvc?rev=1345379view=rev Log: A patch from Tri Duc Vo

Component/TenantComponent entities

2012-05-31 Thread Adam Heath
Component/TenantComponent entities are defined in framework/entity. However, that code does not use them. entityext does. They should be moved to the later component. I've currently got org.ofbiz.entity.Main that can load a delegator, without any of service or any other component loaded. No

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 02:46 AM, Adrian Crum wrote: On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: Jacques Le Roux jacques.le.r...@les7arts.com From: Adam Heath doo...@brainfood.com On 05/24/2012 04:05 PM, Jacques

Re: Proposal for a new best practice for logging

2012-05-30 Thread Adam Heath
On 05/30/2012 04:14 AM, Jacopo Cappellato wrote: Would you agree in adopting the following as a best practice for OFBiz logging: do not include full maps/lists in the output or if really necessary limit this to verbose output. For example, avoid code like this:

Re: Discussion: Using Javolution

2012-05-30 Thread Adam Heath
On 05/30/2012 06:24 AM, Adrian Crum wrote: I am reposting this thread with a different subject to make sure everyone interested has a chance to comment. To summarize (and to make sure we are all on the same page): 1. Javolution was added to the project in the JDK 1.4 days. David Jones ran

Re: Proposal for a new best practice for logging

2012-05-30 Thread Adam Heath
On 05/30/2012 04:14 AM, Jacopo Cappellato wrote: Would you agree in adopting the following as a best practice for OFBiz logging: do not include full maps/lists in the output or if really necessary limit this to verbose output. For example, avoid code like this:

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 11:47 AM, Adrian Crum wrote: On 5/30/2012 4:30 PM, Adam Heath wrote: On 05/30/2012 02:46 AM, Adrian Crum wrote: On 5/29/2012 5:49 AM, Adam Heath wrote: On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: Jacques Le Rouxjacques.le.r

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-30 Thread Adam Heath
On 05/30/2012 12:22 PM, Adrian Crum wrote: I need to reacquaint myself with the entity engine code. I was thinking the visitor pattern could be used to construct the SQL string instead of the complicated if-then-else code spread across a number of classes. We could use different visitors for

Remove PartyContactMech.(months|years)WithContactMech?

2012-05-29 Thread Adam Heath
I noticed the 2 fields in the subject, but didn't actually recoginize them(I've been using ofbiz for a *long* time). I did a big of digging, and noticed that those fields were added to the model in 2006-05-04(1), and were first utilized when anonymous checkout was added 2006-11-28(2). There has

Re: svn commit: r1343088 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java

2012-05-28 Thread Adam Heath
On 05/27/2012 03:28 PM, jler...@apache.org wrote: Author: jleroux Date: Sun May 27 20:28:16 2012 New Revision: 1343088 URL: http://svn.apache.org/viewvc?rev=1343088view=rev Log: Fixes this error found by chance in log exception report

Re: svn commit: r1343469 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/transaction/TransactionUtil.java

2012-05-28 Thread Adam Heath
On 05/28/2012 10:55 PM, doo...@apache.org wrote: Author: doogie Date: Tue May 29 03:55:05 2012 New Revision: 1343469 URL: http://svn.apache.org/viewvc?rev=1343469view=rev Log: FIX: This is the correct fix for 1343088; TransactionUtil.doNewTransaction was starting a new transaction, then

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-28 Thread Adam Heath
On 05/25/2012 01:22 AM, Adam Heath wrote: On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: Jacques Le Roux jacques.le.r...@les7arts.com From: Adam Heath doo...@brainfood.com On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/24/2012 10:18 AM, Adam

Re: buildbot success in ASF Buildbot on ofbiz-trunk

2012-05-28 Thread Adam Heath
On 05/28/2012 11:48 PM, build...@apache.org wrote: The Buildbot has detected a restored build on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/3134 Buildbot URL: http://ci.apache.org/ Buildslave for this

Re: jdk7 feature that might be good for ofbiz

2012-05-27 Thread Adam Heath
On 05/27/2012 07:09 AM, Jacques Le Roux wrote: From: Adrian Crum adrian.c...@sandglass-software.com FYI, in the Mini-language overhaul I interned the Element tag name Strings. Yes, that's really a good improvment! Things are much more clear now. It's only in minilang though (I mean not in

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-25 Thread Adam Heath
On 05/25/2012 12:26 AM, Jacques Le Roux wrote: From: Jacques Le Roux jacques.le.r...@les7arts.com From: Adam Heath doo...@brainfood.com On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/24/2012 10:18 AM, Adam Heath wrote: The idea was that you would

Re: svn commit: r1342324 - in /ofbiz/trunk: startofbiz.sh stopofbiz.sh

2012-05-25 Thread Adam Heath
On 05/25/2012 10:58 AM, Pierre Smits wrote: Please revert this commit. Not all documentation on website and wiki reflect the new situation. Keep the commit. Trunk doesn't have to be perfect all the time, it *will* be broken, and will be inconsistent from time to time. Fix the other locations.

Re: Dependency of DBCPConnectionFactory on ExampleType entity

2012-05-24 Thread Adam Heath
On 05/24/2012 03:22 AM, Jacopo Cappellato wrote: On May 24, 2012, at 9:04 AM, Jacques Le Roux wrote: From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On May 23, 2012, at 9:25 PM, Adam Heath wrote: On 05/23/2012 01:13 PM, Jacopo Cappellato wrote: Using count() was simply a trick

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there are not only addressed to Adam... About javacc dependency do we really need it *OOTB*? Can't we use rather

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say the least), there are not only addressed to Adam... About javacc dependency do we

Re: Slim-down continue [was Re: svn commit: r1340414 - ...]

2012-05-24 Thread Adam Heath
On 05/24/2012 04:05 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/24/2012 10:18 AM, Adam Heath wrote: On 05/24/2012 08:15 AM, Adrian Crum wrote: On 5/20/2012 10:01 AM, Jacques Le Roux wrote: Quick questions (seems that there is a lack of internal documentation to say

Re: Fwd: [CVE-2012-2098] Apache Commons Compress and Apache Ant denial of service vulnerability

2012-05-23 Thread Adam Heath
And which ofbiz versions use commons/bzip2? Might have to check catalina, jetty, etc. On 05/23/2012 11:07 AM, Adrian Crum wrote: Original Message Subject: [CVE-2012-2098] Apache Commons Compress and Apache Ant denial of service vulnerability Date: Wed, 23

Re: Dependency of DBCPConnectionFactory on ExampleType entity

2012-05-23 Thread Adam Heath
On 05/23/2012 11:51 AM, Jacopo Cappellato wrote: I just realized that line 150 in DBCPConnectionFactory: factory.setValidationQuery(select example_type_id from example_type limit 1); is a dependency on ExampleType entity declared in the example component. This is probably not a big

Re: Dependency of DBCPConnectionFactory on ExampleType entity

2012-05-23 Thread Adam Heath
On 05/23/2012 12:05 PM, Jacopo Cappellato wrote: DBCPConnectionFactory is in framework/entity; having it require a framework/entity/entitymodel seems the safest approach. I agree; what if we use: select count(testing_type_id) from testing_type where testing_type_id = 'ABC' Actually, no,

Re: Dependency of DBCPConnectionFactory on ExampleType entity

2012-05-23 Thread Adam Heath
On 05/23/2012 01:13 PM, Jacopo Cappellato wrote: Using count() was simply a trick to be sure to get a record back even if the entity is empty... but if we use an entity that we are sure is populated we don't have to use it, of course. Of course if we use count(*) we have to use it in an

Re: svn commit: r1341021 - /ofbiz/trunk/common.xml

2012-05-21 Thread Adam Heath
On 05/21/2012 10:47 AM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/21/2012 09:55 AM, Jacques Le Roux wrote: Could not the asm library (not sure what it is exactly) be loaded on the fly with Cobertura? The less optional libs we have inside, the more we resolve with Ivy

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 10:56 AM, Jacopo Cappellato wrote: Looks good to me, are you going to attach it to the ticket I have created in the Freemarker bug tracker? I'll do it; what's the other bug#? Do we want to bump the severity?

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 10:57 AM, Adam Heath wrote: On 05/17/2012 10:56 AM, Jacopo Cappellato wrote: Looks good to me, are you going to attach it to the ticket I have created in the Freemarker bug tracker? I'll do it; what's the other bug#? Do we want to bump the severity? I'm just waiting

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 11:48 AM, Jacopo Cappellato wrote: wonderful I can't seem to attach files to that issue, maybe because I didn't originally file it. Could you see if you can attach both files? If you can, but I can't, then the sf tracker is really stupid.

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 11:50 PM, Adam Heath wrote: On 05/17/2012 12:23 PM, Jacopo Cappellato wrote: file are attached; that bug tracker is really awful. This is all becoming very troubling. == example methods String a(String name, List list) {} String a(String name, Map map) {} String a(Object[] args

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 11:30 AM, Adam Heath wrote: On 05/16/2012 11:18 AM, Adam Heath wrote: On 05/16/2012 11:05 AM, Adam Heath wrote: On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002 This may be a stupid question

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
provide the test report XML file please? -Adrian On 5/12/2012 3:59 AM, Adam Heath wrote: On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103view=rev Log: Fixed broken Mini

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
On 05/12/2012 07:17 AM, Adrian Crum wrote: Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without going into too much detail, here is a

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from the command line. Some of us use a graphical Subversion client - like Tortoise

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 05:15 AM, Jacques Le Roux wrote: +1 Though I'd like to keep revert.bat, it's easier to change path (and not forget) with new release than have to search in build.xml, not a big deal though... tools/ant-revert.xml: ./ant revert ./ant -f tools/ant-revert.xml revert both commands

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm too lazy :o) I mean the definition for the ant revert command should be in a separate

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:39 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:04 PM, Jacques Le Roux wrote: From: Adam Heath doo...@brainfood.com On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm too

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-12 Thread Adam Heath
On 05/12/2012 04:28 PM, Jacques Le Roux wrote: I'm sure you are both afraid of that, but in case you freithened people about DCL I wanted to say that since jdk 1.5 way of handling volatile it's now possible to safely use this pattern with Java

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 08:53 AM, Adam Heath wrote: On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:26 PM, Adam Heath wrote: @@ -177,10 +184,18 @@ public class GroovyUtil { Class? scriptClass = parsedScripts.get(script); if (scriptClass == null) { scriptClass = loadClass(script); - if (Debug.verboseOn

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:51 AM, Adam Heath wrote: On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:26 PM, Adam Heath wrote: @@ -177,10 +184,18 @@ public class GroovyUtil { Class? scriptClass = parsedScripts.get(script); if (scriptClass == null) { scriptClass = loadClass

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:51 PM, Adam Heath wrote: == result = parsedScripts.get(key) if (result == null) { syncyronized (parsedScripts) { result = parsedScripts.get(key) if (result == null) { result = genResult

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:49 AM, Jacopo Cappellato wrote: On May 11, 2012, at 5:38 PM, Adam Heath wrote: On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: On May 11, 2012, at 4:51 PM, Adam Heath wrote: == result = parsedScripts.get(key) if (result == null) { syncyronized (parsedScripts

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:30 PM, Jacopo Cappellato wrote: On May 11, 2012, at 6:34 PM, Adam Heath wrote: There is no difference. The act of map.get() can be doing a *lot* of separate, individual steps. Without any kind of happens-before/happens-after on map.get(), the protected put/get

Warning! In the next few hours, I will be committing findByPrimaryKey-findOne changes

2012-05-11 Thread Adam Heath
As I have discussed, I will be committing a series of separate commits, that change findByPrimaryKey calls into findOne. I have run the test cases on these changes, and everything compiles. However, ofbiz does *not* have 100% coverage, no where close. Some of the changes are inside groovy/ftl

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 02:46 PM, Jacopo Cappellato wrote: The UtilCache objects *are* thread-safe. You will not get any internal corruption inside UtilCache. That is all that can be guaranteed. What isn't thread safe, is that calling code may end up having multiple instances for the same key, unless

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-11 Thread Adam Heath
On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103view=rev Log: Fixed broken Mini-languagecheck-errors element (second try). Modified:

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:05 AM, doo...@apache.org wrote: Author: doogie Date: Thu May 10 16:05:00 2012 New Revision: 1336768 URL: http://svn.apache.org/viewvc?rev=1336768view=rev Log: FIX: s/run-install/load-demo/ I'm surprised I actually had to do this. It implies that the scripts are not being

Re: svn commit: r1336772 - in /ofbiz/trunk/tools: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:13 AM, doo...@apache.org wrote: Author: doogie Date: Thu May 10 16:13:23 2012 New Revision: 1336772 URL: http://svn.apache.org/viewvc?rev=1336772view=rev Log: FEATURE/OPTIMIZE: Copied these from the release12.04 branch(using svn copy). Having to manually add them to

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from the command line. Some of us use a graphical Subversion client - like Tortoise, or the Eclipse plugin. Which brings up another thought I had. Maybe converting these to a series of

backports(to 12.04) of my recent commits

2012-05-10 Thread Adam Heath
I've added 2 major(ish) new features recently. * salt-based password hashing(with base64 encoding) * key-encrypting-key(kek) support. The salt-based psasword feature was written when JIRA was hacked several years ago; JIRA is based on an old version of OfBiz, so this change could be considered a

[jira] [Commented] (OFBIZ-4870) Multithreading in GenericDAO / Delegator

2012-05-10 Thread Adam Heath (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272862#comment-13272862 ] Adam Heath commented on OFBIZ-4870: --- There is multi-threading per-datasource during

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:40 PM, Adrian Crum wrote: I wanted to discuss this again. Some time ago I modified my local copy of OFBiz to execute the the ant run-install task faster by using multi-threaded entity creation and data loading. I don't remember what i was working on at the time, but I

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:58 PM, Adrian Crum wrote: On 5/11/2012 12:45 AM, Adam Heath wrote: On 05/10/2012 06:40 PM, Adrian Crum wrote: I wanted to discuss this again. Some time ago I modified my local copy of OFBiz to execute the the ant run-install task faster by using multi-threaded entity creation

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-10 Thread Adam Heath
On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev=1328356view=rev Log: The cache of parsed Groovy scripts was not thread safe; this issue, in instances with several concurrent threads

Re: svn commit: r1337024 - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/base/src/org/ofbiz/base/util/ framework/webapp/src/org/ofbiz/webapp/eve

2012-05-10 Thread Adam Heath
On 05/10/2012 11:46 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:46:26 2012 New Revision: 1337024 URL: http://svn.apache.org/viewvc?rev=1337024view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: svn commit: r1337026 - in /ofbiz/branches/release11.04: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/webapp/src/org/ofbiz/webapp/event/ specialpurpose/shark

2012-05-10 Thread Adam Heath
On 05/10/2012 11:51 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:51:55 2012 New Revision: 1337026 URL: http://svn.apache.org/viewvc?rev=1337026view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: old ofbiz versions

2012-05-09 Thread Adam Heath
On 05/08/2012 11:18 PM, Jacopo Cappellato wrote: Hi Adam, I don't know if it is useful but for some time in its history (but I don't remember the years) the OFBiz project was hosted at dev.java.net,maybe the url was: https://ofbiz.dev.java.net/ dev.java.net doesn't exist either.

<    1   2   3   4   5   6   7   8   9   10   >