Corey Farrell has uploaded a new change for review.
https://gerrit.asterisk.org/27
Change subject: Enable support for directory containing custom tests.
..
Enable support for directory containing custom tests.
This change
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4578/#review15041
---
Ship it!
Ship It!
- George Joseph
On April 3, 2015, 7:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4391/#review15039
---
/trunk/main/manager.c
Hello Ashley Sanders,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/22
to look at the new patch set (#4).
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test
Jonathan Rose has uploaded a new change for review.
https://gerrit.asterisk.org/28
Change subject: Address review feedback
..
Address review feedback
Change-Id: If37cf20857ae3c0b35e0637a0a2cb7e7d6226df6
---
M
John Bigelow has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/25
To unsubscribe,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4579/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24937
Jonathan Rose has uploaded a new patch set (#2).
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test The test will start two instances of Asterisk. The first will
originate a PJSIP call with authentication to the second using an extension
that will run
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108/
---
(Updated April 3, 2015, 12:58 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15046
---
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/#review15047
---
When I try to view the review, Review Board complains that it
Kevin Harwell has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3:
Updated the per review based on feedback and other findings.
A couple of
Jonathan Rose has abandoned this change.
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test
..
Abandoned
I'm abandoning this one since the patch got mangled. Go over to c/28
--
To view,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4581/
---
Review request for Asterisk Developers and Scott Griepentrog.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/
---
(Updated April 3, 2015, 12:03 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4579/#review15045
---
Ship it!
I'll just say that I enjoy that this is all it took
Hello Ashley Sanders, Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/25
to look at the new patch set (#3).
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
Hello Ashley Sanders,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/22
to look at the new patch set (#2).
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test The test will start two instances of Asterisk. The first will
Hello Ashley Sanders,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/22
to look at the new patch set (#3).
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test The test will start two instances of Asterisk. The first will
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4580/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-13271
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4585/
---
Review request for Asterisk Developers, Joshua Colp and Mark Michelson.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/
---
(Updated April 3, 2015, 10:06 p.m.)
Review request for Asterisk
On April 3, 2015, 4:28 p.m., rmudgett wrote:
branches/13/res/res_pjsip/pjsip_configuration.c, lines 152-153
https://reviewboard.asterisk.org/r/4582/diff/1/?file=73574#file73574line152
Are the flags exclusive to each other?
Maybe SUPPORT is needed to enable the functionality
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24928
Mark Michelson has abandoned this change.
Change subject: Add SIP attended transfer for Asterisk 11.
..
Abandoned
--
To view, visit https://gerrit.asterisk.org/20
To unsubscribe, visit https://gerrit.asterisk.org/settings
Mark Michelson has posted comments on this change.
Change subject: Add SIP attended transfer for Asterisk 11.
..
Patch Set 1:
I am abandoning this change in favor of change /c/29/
--
To view, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/
---
(Updated April 3, 2015, 9:32 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/#review15049
---
This is still a nuisance warning that doesn't add much value
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/#review15053
---
/branches/13/channels/chan_iax2.c
Mark Michelson has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 1:
(1 comment)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4586/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-20524
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24939
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/#review15050
---
You probably want to add documentation for the new
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4588/
---
(Updated April 3, 2015, 9:49 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/
---
(Updated April 3, 2015, 5:25 p.m.)
Review request for Asterisk
Mark Michelson has uploaded a new change for review.
https://gerrit.asterisk.org/29
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
sip_attended_transfer now supports pre-12 Asterisk versions.
Mark Michelson has uploaded a new patch set (#2).
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
sip_attended_transfer now supports pre-12 Asterisk versions.
The sip_attended transfer test was
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
(Updated April 3, 2015, 11:24 p.m.)
Review request for Asterisk
On April 3, 2015, 11:36 p.m., rmudgett wrote:
This is still a nuisance warning that doesn't add much value for the effort.
Diederik de Groot wrote:
We can drop it no problem. I still think it could be useful in detecting
_ref/_unref issues, alas it would quite a bit of work but
Jonathan Rose has posted comments on this change.
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test
..
Patch Set 1:
(2 comments)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4587/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24863
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/#review15048
---
branches/13/res/res_pjsip/pjsip_configuration.c
On April 4, 2015, 12:40 a.m., rmudgett wrote:
/branches/13/channels/chan_iax2.c, lines 2009-2013
https://reviewboard.asterisk.org/r/4554/diff/2/?file=73276#file73276line2009
This change causes bugs. It is supposed to return peer because it
increased the ref.
Stupid me. If
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554/
---
(Updated April 4, 2015, 1:15 a.m.)
Review request for Asterisk
On April 3, 2015, 4:36 p.m., rmudgett wrote:
This is still a nuisance warning that doesn't add much value for the effort.
Diederik de Groot wrote:
We can drop it no problem. I still think it could be useful in detecting
_ref/_unref issues, alas it would quite a bit of work but could
On April 4, 2015, 12:40 a.m., rmudgett wrote:
/branches/13/channels/chan_iax2.c, lines 2009-2013
https://reviewboard.asterisk.org/r/4554/diff/2/?file=73276#file73276line2009
This change causes bugs. It is supposed to return peer because it
increased the ref.
Diederik de Groot
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/#review15056
---
Ship it!
Ship It!
- rmudgett
On April 3, 2015, 5:52 p.m.,
On April 3, 2015, 5:40 p.m., rmudgett wrote:
/branches/13/channels/chan_iax2.c, lines 2009-2013
https://reviewboard.asterisk.org/r/4554/diff/2/?file=73276#file73276line2009
This change causes bugs. It is supposed to return peer because it
increased the ref.
Diederik de Groot
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/
---
(Updated April 3, 2015, 5:52 p.m.)
Review request for Asterisk
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(1 comment)
On April 3, 2015, 11:36 p.m., rmudgett wrote:
This is still a nuisance warning that doesn't add much value for the effort.
Diederik de Groot wrote:
We can drop it no problem. I still think it could be useful in detecting
_ref/_unref issues, alas it would quite a bit of work but
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
On April 2, 2015, 6:13 p.m., Kevin Harwell wrote:
It is probably always the case that framehooks should not be attached
twice. If this is true then it might be better to add a check in
'ast_framehook_attach' that first makes sure the hook is not already in the
list. If so don't add
54 matches
Mail list logo
