---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4599/
---
Review request for Asterisk Developers.
Bugs: 21211
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4599/#review15086
---
Ship it!
Ship It!
- Matt Jordan
On April 7, 2015, 8:28
Matt Jordan has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/25
To
Matt Jordan has submitted this change and it was merged.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
non_stasis_bridge_to_stasis_bridge: Update regex for ami events
Due to a bug in
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15087
---
Please update the CHANGES file :-)
- Matt Jordan
On April
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4599/
---
(Updated April 7, 2015, 8:28 a.m.)
Review request for Asterisk
On April 7, 2015, 6:15 a.m., Corey Farrell wrote:
branches/13/res/res_pjsip_config_wizard.c, lines 1189-1191
https://reviewboard.asterisk.org/r/4596/diff/1/?file=73638#file73638line1189
I'm concerned that this is needed due to the load order change. My
worry is that there might
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4592/#review15093
---
I think this change is widening the scope of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4575/
---
(Updated April 7, 2015, 11:41 a.m.)
Status
--
This change has been
On April 7, 2015, 10:46 a.m., Matt Jordan wrote:
Also, please remember to close findings that you feel have been resolved.
Otherwise, it is difficult to know what all has been addressed between reviews.
- Matt
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/#review15090
---
trunk/channels/chan_iax2.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---
(Updated April 7, 2015, 11:05 a.m.)
Review request for Asterisk
Mark Michelson has uploaded a new patch set (#3).
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
sip_attended_transfer now supports pre-12 Asterisk versions.
The sip_attended transfer test was
Mark Michelson has uploaded a new patch set (#3).
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
sip_attended_transfer now supports pre-12 Asterisk versions.
The sip_attended transfer test was
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4549/
---
(Updated April 7, 2015, 10:21 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4577/#review15089
---
Ship it!
/certified/branches/13.1/res/res_pjsip_t38.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15095
---
branches/13/res/res_pjsip/config_global.c
Joshua Colp has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.asterisk.org/28
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/#review15103
---
I want to give this a Ship It! but the Testing Done section is
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4594/#review15099
---
I don't see the actual patch on the issue. Did you use
On April 7, 2015, 1:05 a.m., rmudgett wrote:
/branches/13/apps/app_minivm.c, line 1842
https://reviewboard.asterisk.org/r/4541/diff/3/?file=73407#file73407line1842
Missing the !
if (!ast_strlen_zero())
Diederik de Groot wrote:
Thanks again for checking my stuff,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4598/#review15092
---
/team/group/dns/main/dns_test.c
On April 7, 2015, 10:46 a.m., Matt Jordan wrote:
trunk/channels/chan_iax2.c, lines 12365-12375
https://reviewboard.asterisk.org/r/4536/diff/2/?file=73573#file73573line12365
I would put a comment in here explaining why the schedule times are
chosen as they are. 5/6 feels arbitrary
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4598/
---
(Updated April 7, 2015, 5:49 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4595/#review15101
---
Ship it!
Ship It!
- Mark Michelson
On April 6, 2015, 8:20
On April 7, 2015, 5:28 p.m., Kevin Harwell wrote:
/trunk/main/dns_core.c, line 438
https://reviewboard.asterisk.org/r/4598/diff/1/?file=73671#file73671line438
No value is set on true.
This is intended. See
https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html
- Mark
Joshua Colp has submitted this change and it was merged.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Testsuite: New test for FAX via PJSIP T38 with authentication
Add a test for PJSIP t38
Mark Michelson has posted comments on this change.
Change subject: Enable support for directory containing custom tests.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/27
To unsubscribe, visit
On April 7, 2015, 1:04 p.m., Mark Michelson wrote:
branches/13/res/res_pjsip/config_global.c, lines 234-240
https://reviewboard.asterisk.org/r/4597/diff/2/?file=73682#file73682line234
I think for now this is fine, but there actually is the possibility to
misrepresent to the user
Mark Michelson has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/28
To unsubscribe,
On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
Matt Jordan wrote:
Also, please remember to close findings that you feel have been resolved.
Otherwise, it is difficult to know what all has been addressed between
reviews.
ok.
On April 7, 2015, 3:46 p.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4594/
---
(Updated April 7, 2015, 6:25 p.m.)
Review request for Asterisk
On April 7, 2015, 3:05 a.m., rmudgett wrote:
/branches/13/apps/app_minivm.c, line 1842
https://reviewboard.asterisk.org/r/4541/diff/3/?file=73407#file73407line1842
Missing the !
if (!ast_strlen_zero())
Diederik de Groot wrote:
Thanks again for checking my stuff,
Matt Jordan has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/29
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
---
global is used for global variabels. Other CLI commands have
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4563/#review15110
---
Did this really apply to all operating systems and all
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/#review15106
---
Ship it!
Minor nit and then it's good to go.
Matt Jordan has submitted this change and it was merged.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
sip_attended_transfer now supports pre-12 Asterisk versions.
The sip_attended transfer
Matt Jordan has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.asterisk.org/29
To unsubscribe, visit
On April 7, 2015, 2:55 p.m., Olle E Johansson wrote:
global is used for global variabels. Other CLI commands have show
settings - can't we reuse the same with some extra options for system?
Where are you getting global variables from the command?
pjsip show global gives the settings for
On April 7, 2015, 9:55 p.m., Olle E Johansson wrote:
global is used for global variabels. Other CLI commands have show
settings - can't we reuse the same with some extra options for system?
rmudgett wrote:
Where are you getting global variables from the command?
pjsip
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4522/#review15105
---
Ship it!
Ship It!
- Mark Michelson
On March 25, 2015, 4:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4595/
---
(Updated April 7, 2015, 2:34 p.m.)
Status
--
This change has been
Ashley Sanders has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 3: Code-Review+1
(2 comments)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4536/
---
(Updated April 7, 2015, 8:38 p.m.)
Review request for Asterisk Developers
On March 31, 2015, 11:19 a.m., Michael Young wrote:
I would hold off on committing this patch as I feel it is not really a
proper solution. I believe that this is just short circuiting the
conditional and always applying remapping if IPv6 is involved or not. On
the issue tracker,
On March 31, 2015, 8:16 p.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
An additional decision to be made:
Do we need to support IDNA in asterisk or not?
If I want to set up a sip trunk do blåbärsmjölk.ästerisk.org - do I add that in
the config file?
For those that create web interfaces to asterisk - should they do the
conversion or will Asterisk?
There are now
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#3).
Change subject: stasis: set a channel variable on websocket disconnect error
..
On April 7, 2015, 1:04 p.m., Mark Michelson wrote:
branches/13/res/res_pjsip/config_system.c, lines 149-155
https://reviewboard.asterisk.org/r/4597/diff/2/?file=73683#file73683line149
This should be impossible to happen since default system configuration
should automatically get
On April 7, 2015, 2:55 p.m., Olle E Johansson wrote:
global is used for global variabels. Other CLI commands have show
settings - can't we reuse the same with some extra options for system?
rmudgett wrote:
Where are you getting global variables from the command?
pjsip
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/
---
(Updated April 7, 2015, 5:35 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4598/#review15116
---
Ship it!
/trunk/main/dns_test.c
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
Addressed Matt Jordan's review feedback.
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#5).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#4).
Change subject: stasis: set a channel variable on websocket disconnect error
..
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated April 8, 2015, 1:26 a.m.)
Review request for Asterisk
On April 7, 2015, 9:32 p.m., rmudgett wrote:
/branches/13/apps/app_minivm.c, line 1872
https://reviewboard.asterisk.org/r/4541/diff/4/?file=73676#file73676line1872
Might as well fix the comment typo while changing the line anyway.
Rest - Reset
Another One Done.. Just a
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4541/
---
(Updated April 8, 2015, 1:18 a.m.)
Review request for Asterisk
On April 1, 2015, 3:16 a.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533/
---
(Updated April 8, 2015, 1:25 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4587/
---
(Updated April 7, 2015, 5:54 p.m.)
Review request for Asterisk
On April 7, 2015, 7:06 p.m., Mark Michelson wrote:
I want to give this a Ship It! but the Testing Done section is not
filled in at all. What has been done to test this change?
I did test the 1st version of the patch even if I somehow missed that I should
document it in the Testing Done
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(1 comment)
Addressed Mark Michelson's suggestion for refactoring the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/
---
(Updated April 7, 2015, 10:54 p.m.)
Review request for Asterisk
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(5 comments)
I found some more minor issues with the review.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4571/#review15123
---
Ship it!
Ship It!
- Matt Jordan
On April 7, 2015, 8:54
69 matches
Mail list logo
