Re: [asterisk-dev] [Code Review] 3629: pbx_lua: Remove the problematic and unnecessary AST_MODFLAG_GLOBAL_SYMBOLS from pbx_lua.c

2014-06-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3629/#review12187 --- Ship it! Ship It! - Joshua Colp On June 18, 2014, 11:27

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-19 Thread Joshua Colp
On June 10, 2014, 11:22 a.m., Joshua Colp wrote: /branches/11/main/channel.c, line 7113 https://reviewboard.asterisk.org/r/3603/diff/1/?file=59449#file59449line7113 This change is hazardous. It makes it so that some file descriptors on the original channel which were from

Re: [asterisk-dev] [Code Review] 3626: res_parking: Parking manager actions were registered without module information.

2014-06-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3626/#review12189 --- Ship it! Ship It! - Joshua Colp On June 17, 2014, 10:45

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-12 Thread Joshua Colp
as if nothing had happened. Tested using the default persistence of going to astdb and also configured it to persist through realtime - ODBC - MySQL. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3615: MoH: Don't restart stream on repeated start calls

2014-06-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3615/#review12136 --- Ship it! Ship It! - Joshua Colp On June 12, 2014, 2:47 p.m

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

2014-06-11 Thread Joshua Colp
://reviewboard.asterisk.org/r/3602/#comment22147 The answer is yes. Changing this code so that it returns if they are not exactly equal would be sufficient. IE: != AST_FORMAT_CMP_EQUAL - Joshua Colp On June 10, 2014, 7:10 p.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

2014-06-10 Thread Joshua Colp
ast_format_cap_get_format, ast_format_cap_iscompatible_format, and ast_format_cap_count. - Joshua Colp On June 8, 2014, 7:38 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3603: func_jitterbuffer: fix errors and leaks caused by certain masquerade's

2014-06-10 Thread Joshua Colp
because that behavior is undefined. The jitterbuffer code itself assumes yes, but as you've said the file descriptor is not preserved so it can't. - Joshua Colp On June 10, 2014, 12:12 a.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-10 Thread Joshua Colp
it to persist through realtime - ODBC - MySQL. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-10 Thread Joshua Colp
working on resolving. It should barely impact the code. - Joshua Colp On June 10, 2014, 1:21 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3598

Re: [asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-10 Thread Joshua Colp
it to persist through realtime - ODBC - MySQL. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] Question about audiohook.c and re-sampling

2014-06-09 Thread Joshua Colp
the ast_format_rate function which returns the rate of a format. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 3586: testsuite: Update PJSIP blind transfer tests for expected direct media re-INVITEs

2014-06-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3586/#review12097 --- Ship it! Ship It! - Joshua Colp On June 5, 2014, 9:33 p.m

[asterisk-dev] [Code Review] 3598: res_pjsip_pubsub: Persist subscriptions using sorcery and recreate them upon startup.

2014-06-06 Thread Joshua Colp
wireshark, that the expected NOTIFY was sent out upon startup as if nothing had happened. Tested using the default persistence of going to astdb and also configured it to persist through realtime - ODBC - MySQL. Thanks, Joshua Colp

Re: [asterisk-dev] Question about audiohook.c and re-sampling

2014-06-06 Thread Joshua Colp
the assumption that it will always be dealing with AST_FORMAT_SLINEAR. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [svn-commits] file: branch file/pjsip-subscription-persistence r415170 - /team/file/pjsip-s...

2014-06-04 Thread Joshua Colp
by this? -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [svn-commits] file: branch file/pjsip-subscription-persistence r415170 - /team/file/pjsip-s...

2014-06-04 Thread Joshua Colp
this for testing? -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3579: odbc: Fix for remove fixed size buffers fix (r414968).

2014-06-02 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3579/#review12023 --- Ship it! Ship It! - Joshua Colp On June 2, 2014, 10:23 a.m

Re: [asterisk-dev] [Code Review] 3577: bridge_native_rtp: Use combined result of both channels to determine bridge type.

2014-06-01 Thread Joshua Colp
with direct media disabled. Placed a call from the caller to the callee. Without this patch a reinvite occurs and the media is direct. With this patch no reinvite occurs and media is locally exchanged. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

2014-05-30 Thread Joshua Colp
413652 /team/group/media_formats-reviewed/channels/sip/include/sip.h 413300 /team/group/media_formats-reviewed/channels/chan_sip.c 413300 Diff: https://reviewboard.asterisk.org/r/3516/diff/ Testing --- Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3577: bridge_native_rtp: Use combined result of both channels to determine bridge type.

2014-05-30 Thread Joshua Colp
no reinvite occurs and media is locally exchanged. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3573: [main/config.c] AMI action UpdateConfig EmptyCat clears all categories but the requested one

2014-05-29 Thread Joshua Colp
been this way since the initial commit. - Joshua Colp On May 29, 2014, 7:56 a.m., zvision wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3573

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

2014-05-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3541/#review11992 --- Ship it! Ship It! - Joshua Colp On May 28, 2014, 10:58 p.m

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

2014-05-29 Thread Joshua Colp
://reviewboard.asterisk.org/r/3563/#comment21919 Good job remembering this can happen. :D - Joshua Colp On May 25, 2014, 4:47 a.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3563

Re: [asterisk-dev] [Code Review] 3563: TALK_DETECT: A channel function that raises AMI/ARI events when talking is detected

2014-05-29 Thread Joshua Colp
On May 29, 2014, 1:53 p.m., Joshua Colp wrote: How do you foresee this being invoked for ARI? the existing channel variable stuff? Matt Jordan wrote: Yup. Enabling an event to be emitted on a channel didn't feel worthy of a full operation on the channels resource

Re: [asterisk-dev] [Code Review] 3557: odbc: Remove fixed size buffers.

2014-05-28 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

2014-05-28 Thread Joshua Colp
person since anything to do with parsing could always use two sets, plus the overall change is large. trunk/include/asterisk/http_websocket.h https://reviewboard.asterisk.org/r/3541/#comment21889 You have this as error here but it's actually result. - Joshua Colp On May 23, 2014, 7:30 p.m

Re: [asterisk-dev] [Code Review] 3557: odbc: Remove fixed size buffers.

2014-05-27 Thread Joshua Colp
and func_odbc. Configured chan_sip to use peers stored in MySQL (via ODBC) and stored very long values. Confirmed read in completely. Also ran these scenarios under valgrind to confirm no memory insanity. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

2014-05-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3516/#review11805 --- On May 11, 2014, 12:46 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

2014-05-27 Thread Joshua Colp
/media_formats-reviewed/channels/chan_sip.c 413300 Diff: https://reviewboard.asterisk.org/r/3516/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

[asterisk-dev] [Code Review] 3557: odbc: Remove fixed size buffers.

2014-05-22 Thread Joshua Colp
stored in MySQL (via ODBC) and stored very long values. Confirmed read in completely. Also ran these scenarios under valgrind to confirm no memory insanity. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c

2014-05-22 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3477/#review11956 --- Ship it! Ship It! - Joshua Colp On May 9, 2014, 3:36 a.m

Re: [asterisk-dev] [Code Review] 3547: Logger/CLI: Fix some aesthetic issues; clean up some chatty verbose messages

2014-05-22 Thread Joshua Colp
, and some of the old log messages amuse me. - Joshua Colp On May 18, 2014, 8 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3547

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

2014-05-22 Thread Joshua Colp
On May 20, 2014, 10:55 a.m., Joshua Colp wrote: trunk/tests/test_websocket_client.c, line 6 https://reviewboard.asterisk.org/r/3541/diff/1/?file=58462#file58462line6 You are not my brother. My brother is named Matthew. Matt Jordan wrote: I'm your brother??!?!?! I wanted

Re: [asterisk-dev] [Code Review] 3557: odbc: Remove fixed size buffers.

2014-05-22 Thread Joshua Colp
://reviewboard.asterisk.org/r/3557/#comment21862 After using as a buffer you can call ast_str_update to update the internal string length value, and thus not require using strlen. - Joshua Colp On May 22, 2014, 2:53 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3557: odbc: Remove fixed size buffers.

2014-05-22 Thread Joshua Colp
it was read in completely. This used static realtime and func_odbc. Configured chan_sip to use peers stored in MySQL (via ODBC) and stored very long values. Confirmed read in completely. Also ran these scenarios under valgrind to confirm no memory insanity. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

2014-05-21 Thread Joshua Colp
On May 20, 2014, 10:55 a.m., Joshua Colp wrote: trunk/include/asterisk/http_websocket.h, line 259 https://reviewboard.asterisk.org/r/3541/diff/1/?file=58458#file58458line259 It would be useful to return why it failed and not just that it did. Kevin Harwell wrote: I don't

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-21 Thread Joshua Colp
://reviewboard.asterisk.org/r/3485/#comment21851 Extra ; - Joshua Colp On May 21, 2014, 4:29 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-21 Thread Joshua Colp
://reviewboard.asterisk.org/r/3485/#comment21854 So you've documented this as being an ao2 object and then it's not used as one here. If someone else comes along and assumes this in ast_bridge_transfer_blind there will be problems. - Joshua Colp On May 21, 2014, 6:18 p.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485/#review11950 --- Ship it! Ship It! - Joshua Colp On May 21, 2014, 8:25 p.m

Re: [asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

2014-05-20 Thread Joshua Colp
/r/3541/#comment21787 You are not my brother. My brother is named Matthew. - Joshua Colp On May 15, 2014, 6:10 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-20 Thread Joshua Colp
this? What problem was there? What does it solve? - Joshua Colp On May 19, 2014, 6:25 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3485

Re: [asterisk-dev] [Code Review] 3549: Replace __ast_answer with ast_raw_answer in app_control_answer

2014-05-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3549/#review11920 --- Ship it! Ship It! - Joshua Colp On May 19, 2014, 5:20 p.m

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-16 Thread Joshua Colp
/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-14 Thread Joshua Colp
/12/res/parking/parking_bridge_features.c https://reviewboard.asterisk.org/r/3485/#comment21771 It is possible for this to wake up early so you need to put it in a while loop which checks conditions. Same for the below duplicated code. - Joshua Colp On May 8, 2014, 5:40 p.m., Jonathan Rose

Re: [asterisk-dev] [Code Review] 3535: bridge_native_rtp: Reconfigure bridge on removal of framehook; don't send re-INVITE to hungup channel

2014-05-13 Thread Joshua Colp
... it could go badly. - Joshua Colp On May 13, 2014, 12:11 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3535

Re: [asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

2014-05-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3073/#review11881 --- Ship it! Ship It! - Joshua Colp On May 1, 2014, 12:53 p.m

Re: [asterisk-dev] [Code Review] 3531: app_chanspy: Fix broken barge test and address an unfree'd frame I noticed.

2014-05-12 Thread Joshua Colp
://reviewboard.asterisk.org/r/3531/#comment21753 To reduce the chance of your ast_frfree issue again if someone else mucks with this I'd just put the bridge_whisper_audiohook logic in an if (bridge_connected) - Joshua Colp On May 12, 2014, 6:52 p.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3531: app_chanspy: Fix broken barge test and address an unfree'd frame I noticed.

2014-05-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3531/#review11873 --- Ship it! Ship It! - Joshua Colp On May 12, 2014, 8 p.m

Re: [asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

2014-05-11 Thread Joshua Colp
/media_formats-reviewed/channels/chan_sip.c 413300 Diff: https://reviewboard.asterisk.org/r/3516/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3522: Allow framehooks to be queried for what frame types they consume.

2014-05-10 Thread Joshua Colp
would be used. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

2014-05-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/3515/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-10 Thread Joshua Colp
/#review11853 --- On May 5, 2014, 11:11 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3388

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-10 Thread Joshua Colp
/chan_unistim.c 413300 /team/group/media_formats-reviewed/channels/chan_skinny.c 413300 /team/group/media_formats-reviewed/channels/chan_mgcp.c 413300 Diff: https://reviewboard.asterisk.org/r/3388/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3522: Allow framehooks to be queried for what frame types they consume.

2014-05-08 Thread Joshua Colp
/r/3522/diff/ Testing --- Performed numerous attended transfers across SIP and PJSIP. Before patch simple_bridge would be used after completion for attended. After patch the expected native_rtp would be used. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

2014-05-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3512/#review11851 --- Ship it! Ship It! - Joshua Colp On May 8, 2014, 5:16 p.m

Re: [asterisk-dev] [Code Review] 3477: Japanese language patch for app_voicemail.c and say.c

2014-05-08 Thread Joshua Colp
/r/3477/#comment21721 Some minor redness. /trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/3477/#comment21722 Why the change? Is this a bugfix? - Joshua Colp On May 8, 2014, 7:08 a.m., Kevin McCoy wrote

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3505/#review11860 --- Ship it! Ship It! - Joshua Colp On May 8, 2014, 7:31 p.m

Re: [asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

2014-05-08 Thread Joshua Colp
://reviewboard.asterisk.org/r/3485/#comment21741 I need time to grok your other changes and the possible repercussions but I'll comment on this right now. Would this get called twice since the framehook is invoked when detached? - Joshua Colp On May 8, 2014, 5:40 p.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3522: Allow framehooks to be queried for what frame types they consume.

2014-05-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3522/#review11836 --- On May 5, 2014, 6:48 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3522: Allow framehooks to be queried for what frame types they consume.

2014-05-07 Thread Joshua Colp
://reviewboard.asterisk.org/r/3522/diff/ Testing --- Performed numerous attended transfers across SIP and PJSIP. Before patch simple_bridge would be used after completion for attended. After patch the expected native_rtp would be used. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-05-07 Thread Joshua Colp
/team/group/media_formats-reviewed/addons/chan_ooh323.h 413300 /team/group/media_formats-reviewed/addons/chan_mobile.c 413300 Diff: https://reviewboard.asterisk.org/r/3410/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-07 Thread Joshua Colp
/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-07 Thread Joshua Colp
the old and new code, except that the logic is in a separate function. Am I crazy? - Joshua Colp On May 2, 2014, 8:35 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3506: format improvements: Port bridge_native_rtp over to new format capability API

2014-05-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3506/#review11843 --- Ship it! Ship It! - Joshua Colp On April 30, 2014, 2:26

Re: [asterisk-dev] [Code Review] 3512: media formats: Convert the translation core over

2014-05-07 Thread Joshua Colp
not then fall back to this method. As well - this function will get called multiple times so ideally only set the main frame details up once instead of each time, like was done in the past. Type, format, mallocd, offset, src, and data. - Joshua Colp On May 2, 2014, 2:51 p.m., Kevin

Re: [asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-05-05 Thread Joshua Colp
/chan_unistim.c 413300 /team/group/media_formats-reviewed/channels/chan_skinny.c 413300 /team/group/media_formats-reviewed/channels/chan_mgcp.c 413300 Diff: https://reviewboard.asterisk.org/r/3388/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3518: media_formats: Move abstract jitterbuffer, audiohooks, smoother, and some core stuff over.

2014-05-05 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-05-05 Thread Joshua Colp
-reviewed/addons/chan_mobile.c 413300 Diff: https://reviewboard.asterisk.org/r/3410/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-05-05 Thread Joshua Colp
generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3410/#review11470 --- On March 31, 2014, 2:52 p.m., Joshua Colp wrote: --- This is an automatically generated e

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-05 Thread Joshua Colp
/channels/chan_iax2.c 413300 /team/group/media_formats-reviewed/channels/chan_h323.c 413300 /team/group/media_formats-reviewed/apps/app_meetme.c 413300 Diff: https://reviewboard.asterisk.org/r/3519/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3519: media_formats: Add legacy format API and move chan_iax2, chan_h323, and chan_misdn over.

2014-05-05 Thread Joshua Colp
. To reply, visit: https://reviewboard.asterisk.org/r/3519/#review11797 --- On April 30, 2014, 10:54 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

2014-05-05 Thread Joshua Colp
/format_cache.h 413300 /team/group/media_formats-reviewed/channels/pjsip/dialplan_functions.c 413300 /team/group/media_formats-reviewed/channels/chan_pjsip.c 413300 Diff: https://reviewboard.asterisk.org/r/3515/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

2014-05-05 Thread Joshua Colp
p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3515/ --- (Updated April 30, 2014, 10:49 p.m

[asterisk-dev] [Code Review] 3522: Allow framehooks to be queried for what frame types they consume.

2014-05-05 Thread Joshua Colp
. Before patch simple_bridge would be used after completion for attended. After patch the expected native_rtp would be used. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

2014-05-01 Thread Joshua Colp
://reviewboard.asterisk.org/r/3491/diff/ Testing --- Before patch: Configured cipher using name, received Unsupported log message. After patch: Configured cipher using name, received no log message. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-05-01 Thread Joshua Colp
/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

2014-05-01 Thread Joshua Colp
/asterisk/trunk/tests/channels/pjsip/hold/run-test 5006 Diff: https://reviewboard.asterisk.org/r/3473/diff/ Testing --- Ran and confirmed happy (after fixes were applied). Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3505: app_chanspy: Fix a bug where barge mode only works on the first connection when multiple sessions are spied on for a channel

2014-05-01 Thread Joshua Colp
On May 1, 2014, 6:14 p.m., Joshua Colp wrote: /branches/11/apps/app_chanspy.c, lines 664-668 https://reviewboard.asterisk.org/r/3505/diff/1/?file=58139#file58139line664 Can you explain why the audiohook would not already be attached by the previous code here? Or to be more

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-30 Thread Joshua Colp
before fixing and confirmed broken. Ran test after fixing and confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3495: res_stasis: Add missing PROGRESS indications to functions

2014-04-30 Thread Joshua Colp
progress was indicated if unanswered. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] A thread for format work

2014-04-30 Thread Joshua Colp
Matthew Jordan wrote: On Wed, Apr 30, 2014 at 5:59 AM, Joshua Colp jc...@digium.com mailto:jc...@digium.com wrote: Matthew Jordan wrote: snip If we allow attributes to be set after format creation, we have two options: (1) We make formats mutable, and all the badness that entails

Re: [asterisk-dev] A thread for format work

2014-04-30 Thread Joshua Colp
to 'deal with that', in some form or fashion. Yeah, a lot of stuff like that existed in the core because it had codec specific knowledge. All of that has been moved out so the areas where it occurs should be minimal. We should have as little codec knowledge in the core as possible. -- Joshua

Re: [asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

2014-04-30 Thread Joshua Colp
://reviewboard.asterisk.org/r/3473/diff/ Testing --- Ran and confirmed happy (after fixes were applied). Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

[asterisk-dev] [Code Review] 3515: media_formats: Move chan_pjsip over.

2014-04-30 Thread Joshua Colp
-reviewed/channels/pjsip/dialplan_functions.c 413144 /team/group/media_formats-reviewed/channels/chan_pjsip.c 413144 Diff: https://reviewboard.asterisk.org/r/3515/diff/ Testing --- Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3516: media_formats: Move chan_sip over.

2014-04-30 Thread Joshua Colp
413144 Diff: https://reviewboard.asterisk.org/r/3516/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 3517: media_formats: Move addons over.

2014-04-30 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/3517/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 3518: media_formats: Move abstract jitterbuffer, audiohooks, smoother, and some core stuff over.

2014-04-30 Thread Joshua Colp
413144 /team/group/media_formats-reviewed/include/asterisk/smoother.h 413144 Diff: https://reviewboard.asterisk.org/r/3518/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] A thread for format work

2014-04-30 Thread Joshua Colp
to contribute but don't know where to start (I know that feeling, this project is indeed very far reaching) feel free to send an email to this list or reply to this email and we can work things out! Cheers, [1] https://reviewboard.asterisk.org/dashboard/ -- Joshua Colp Digium, Inc. | Senior Software

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
that format around, in which case why not just add/set in the same API call? Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

2014-04-29 Thread Joshua Colp
. Diffs - /branches/12/channels/chan_pjsip.c 413007 Diff: https://reviewboard.asterisk.org/r/3480/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-29 Thread Joshua Colp
://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
be just going crazy however) For getting them you use ast_format_cap_get_framing. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] A thread for format work

2014-04-29 Thread Joshua Colp
accessed there. The question becomes... how do we notify the RTP side of stuff for *setting up* the smoother. Since format capabilities are reference counted we could pass in the same structure as the channel nativeformats, and have it access that. -- Joshua Colp Digium, Inc. | Senior Software

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
://reviewboard.asterisk.org/r/3481/#comment21584 I'd remove this or change the message - otherwise you'll get it twice. - Joshua Colp On April 28, 2014, 6:18 p.m., opticron wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
On April 29, 2014, 12:28 p.m., Joshua Colp wrote: branches/11/res/res_http_websocket.c, line 195 https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line195 I don't see a close_sent change in here. opticron wrote: close_sent is set to 1 on line 206. I meant

Re: [asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

2014-04-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3481/#review11781 --- Ship it! Ship It! - Joshua Colp On April 29, 2014, 1:48

Re: [asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-29 Thread Joshua Colp
:06 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3472/ --- (Updated April 23, 2014, 11:06 a.m

[asterisk-dev] [Code Review] 3491: res_pjsip: Allow cipher to be specified by name

2014-04-29 Thread Joshua Colp
: Configured cipher using name, received no log message. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 3495: res_stasis: Add missing PROGRESS indications to functions

2014-04-29 Thread Joshua Colp
- /branches/12/res/stasis/control.c 413101 Diff: https://reviewboard.asterisk.org/r/3495/diff/ Testing --- Invoked the different actions and confirmed progress was indicated if unanswered. Thanks, Joshua Colp

<    4   5   6   7   8   9   10   11   12   13   >