Re: [asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.

2015-03-06 Thread rmudgett
/channels/chan_sip.c 432422 Diff: https://reviewboard.asterisk.org/r/4454/diff/ Testing --- Compiling and code inspection. I don't have a realtime setup to test with. Thanks, rmudgett -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-06 Thread rmudgett
) usedistinctiveringdetection=yes with distinctiveringaftercid=no 3) usedistinctiveringdetection=yes with distinctiveringaftercid=yes * Caller-ID was detected for each call * The configured distinctive ring dringX pattern was detected and the specified context set. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP

2015-03-04 Thread rmudgett
://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25139 guidelines: C++ comment - rmudgett On March 4, 2015, 2:51 a.m., Graham Barnett wrote: --- This is an automatically generated e

[asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-04 Thread rmudgett
/res_pjsip_session.c 432446 /branches/13/res/res_pjsip_refer.c 432446 /branches/13/include/asterisk/res_pjsip_session.h 432446 Diff: https://reviewboard.asterisk.org/r/4460/diff/ Testing --- The testsuite tests/channels/pjsip/ tests still pass with the patch. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP

2015-03-04 Thread rmudgett
. http://svn.asterisk.org/svn/asterisk/trunk/apps/app_voicemail.c https://reviewboard.asterisk.org/r/4459/#comment25143 guidelines: Declarations only at beginning of code blocks. - rmudgett On March 4, 2015, 2:20 p.m., Graham Barnett wrote

Re: [asterisk-dev] [Code Review] 4461: app_voicemail: Fix compile breaking in app_voicemail with IMAP_STORAGE.

2015-03-04 Thread rmudgett
. - rmudgett On March 4, 2015, 4:10 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4461/ --- (Updated

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-02 Thread rmudgett
pattern was detected and the specified context set. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-27 Thread rmudgett
values when I pass an integer value. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

[asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.

2015-02-27 Thread rmudgett
a realtime setup to test with. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-25 Thread rmudgett
/branches/13/include/asterisk/json.h 432235 Diff: https://reviewboard.asterisk.org/r/4447/diff/ Testing --- The four commands no longer crash and now report 400 Bad Request with a message that the 'variables' object only accepts string values when I pass an integer value. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4445: app_chanspy, channel: fix frame leaks

2015-02-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4445/#review14548 --- Ship it! Ship It! - rmudgett On Feb. 24, 2015, 5:05 p.m

Re: [asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-25 Thread rmudgett
/branches/13/include/asterisk/json.h 432235 Diff: https://reviewboard.asterisk.org/r/4447/diff/ Testing --- The four commands no longer crash and now report 400 Bad Request with a message that the 'variables' object only accepts string values when I pass an integer value. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4441: Enable TLS Dual-Certificates (ECC+RSA)

2015-02-24 Thread rmudgett
://reviewboard.asterisk.org/r/4441/#comment25083 This should be: ast_log(LOG_ERROR, TLS/SSL error... - rmudgett On Feb. 23, 2015, 10:10 a.m., Alexander Traud wrote: --- This is an automatically generated e-mail. To reply, visit: https

[asterisk-dev] [Code Review] 4447: ARI: Fix crash if integer values used in JSON payload 'variables' object.

2015-02-24 Thread rmudgett
/diff/ Testing --- The four commands no longer crash and now report 400 Bad Request with a message that the 'variables' object only accepts string values when I pass an integer value. Thanks, rmudgett -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-23 Thread rmudgett
with distinctiveringaftercid=no 3) usedistinctiveringdetection=yes with distinctiveringaftercid=yes * Caller-ID was detected for each call * The configured distinctive ring dringX pattern was detected and the specified context set. Thanks, rmudgett

[asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-23 Thread rmudgett
* The configured distinctive ring dringX pattern was detected and the specified context set. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-20 Thread rmudgett
https://reviewboard.asterisk.org/r/4431/#comment25063 Please add a blank line between declarations and code. - rmudgett On Feb. 19, 2015, 10:52 p.m., David Lee wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4430: ISDN AOC: Fix crash from an AOC-E message that doesn't have a channel association.

2015-02-19 Thread rmudgett
Diff: https://reviewboard.asterisk.org/r/4430/diff/ Testing --- Created a dummy AOC-E event with and without a channel association when an ISDN call came in. The AMI AOC-E events were generated as expected and didn't crash. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

2015-02-19 Thread rmudgett
://reviewboard.asterisk.org/r/4435/#comment25040 I prefer the #if defined(SO_PASSCRED) format as it allows more complicated expressions. - rmudgett On Feb. 19, 2015, 3:43 p.m., Corey Farrell wrote

Re: [asterisk-dev] [Code Review] 4436: asterisk/lock.h: Fix syntax errors for non-gcc OSX with 64-bit integers

2015-02-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4436/#review14495 --- Ship it! Ship It! - rmudgett On Feb. 19, 2015, 4:13 p.m

Re: [asterisk-dev] [Code Review] 4422: res_pjsip_refer: Handle INVITE with Replaces failure after answer.

2015-02-19 Thread rmudgett
. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4431: Increase WebSocket frame size and improve large read handling

2015-02-19 Thread rmudgett
) { sanity session close and exit. } } } return 0; /branches/11/res/res_http_websocket.c https://reviewboard.asterisk.org/r/4431/#comment25044 Move to were sanity is now decremented. See above issue location. - rmudgett On Feb. 18, 2015, 4:32 p.m., David

Re: [asterisk-dev] [Code Review] 4417: res_pjsip_refer: Fix crash from a REFER and BYE collision.

2015-02-17 Thread rmudgett
, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread rmudgett
/bridge_softmix.c https://reviewboard.asterisk.org/r/4429/#comment25017 Assigning entry here is unnecessary. The value set in entry here is not used. - rmudgett On Feb. 16, 2015, 12:30 p.m., Kevin Harwell wrote

[asterisk-dev] [Code Review] 4430: ISDN AOC: Fix crash from an AOC-E message that doesn't have a channel association.

2015-02-17 Thread rmudgett
an ISDN call came in. The AMI AOC-E events were generated as expected and didn't crash. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

2015-02-17 Thread rmudgett
to be tolerant of there not being a channel. rmudgett wrote: @matt: ISDN can send the AOC-E event with the incoming DISCONNECT or well after the channel is gone so there may not be a channel available. It is up to the network when or if AOC-E is sent. Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread rmudgett
for the current mixing run. The counts are incremented for each mixing run. If nothing uses it on the current mixing run then it is removed. softmix_translate_helper_cleanup() sets up for the next mixing run. - rmudgett

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-17 Thread rmudgett
Asterisk was going to do things. The testsuite may no longer care about this though. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14470

Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

2015-02-16 Thread rmudgett
to be tolerant of there not being a channel. @matt: ISDN can send the AOC-E event with the incoming DISCONNECT or well after the channel is gone so there may not be a channel available. It is up to the network when or if AOC-E is sent. - rmudgett

Re: [asterisk-dev] [Code Review] 4414: res_pjsip_session: Fix double re-INVITE collision crash.

2015-02-13 Thread rmudgett
with the patch. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 4417: res_pjsip_refer: Fix crash from a REFER and BYE collision.

2015-02-13 Thread rmudgett
--- Since this is a very timing dependent problem, I made some calls and did an attended transfer for a warm fuzzy that nothing serious broke. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] [Code Review] 4422: res_pjsip_refer: Handle INVITE with Replaces failure after answer.

2015-02-13 Thread rmudgett
-INVITE. The debug log on ast2 was as expected. Funny thing is the testsuite test passed for the three scenarios but a reactor timeout happened on 2 and 3. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-11 Thread rmudgett
shutdown phase sleep so I could send a HTTP request while in the final shutdown phase. The HTTP request was not refused while the shutdown request was pending and refused after the final shutdown phase was reached. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread rmudgett
over the other. All config files are read using the same code and nothing in the code treats the '=' vs. '=' differently. The code only makes note of which was used so if the config file needs to be written out the original operator is used. - rmudgett

[asterisk-dev] [Code Review] 4414: res_pjsip_session: Fix double re-INVITE collision crash.

2015-02-11 Thread rmudgett
-- box 2 -- box 1 -- PJSIP/200 1) 100 calls 200 2) 200 answers 3) 100 hangs up 4) repeat call A crash no longer happens on either Asterisk box with the patch. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread rmudgett
. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14435 --- On Feb. 4, 2015, 11:31 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

2015-02-06 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4407/#review14427 --- Ship it! Ship It! - rmudgett On Feb. 6, 2015, 7:37 a.m

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-05 Thread rmudgett
the final shutdown phase sleep so I could send a HTTP request while in the final shutdown phase. The HTTP request was not refused while the shutdown request was pending and refused after the final shutdown phase was reached. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-05 Thread rmudgett
be created at this time but otherwise things should still function until the call hangs up. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/#review14410

Re: [asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

2015-02-05 Thread rmudgett
of size Should be: 2) Utils.c ast_join_delim: don't touch w[x] if x out of bounds of size /branches/13/main/config.c https://reviewboard.asterisk.org/r/4407/#comment24938 Should set cfg_hooks = NULL after cleanup. - rmudgett On Feb. 5, 2015, 4:25 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-03 Thread rmudgett
, line 2022 https://reviewboard.asterisk.org/r/4399/diff/1/?file=71249#file71249line2022 It looks like you will double lock safe_system_lock here with the lock on line 1989. Nope. The lock is released before the No more Mr. Nice guy... comment on line 2000. - rmudgett

[asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-02 Thread rmudgett
, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4390: app_agent_pool: Fix initial module load agent device state reporting.

2015-01-30 Thread rmudgett
is the expected Unavailable state. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread rmudgett
://reviewboard.asterisk.org/r/4374/#comment24871 Double this because SVN versions could get lengthy and server names can be larger as well. - rmudgett On Jan. 28, 2015, 8:13 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-29 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/#review14364 --- Ship it! Ship It! - rmudgett On Jan. 29, 2015, 11:20 a.m

[asterisk-dev] [Code Review] 4390: app_agent_pool: Fix initial module load agent device state reporting.

2015-01-29 Thread rmudgett
/ Testing --- Without the patch, the initial agent state reported by app_queue is Invalid. With the patch, the initial agent state reported by app_queue is the expected Unavailable state. Thanks, rmudgett -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-29 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14383 --- Ship it! Ship It! - rmudgett On Jan. 29, 2015, 4:54 p.m

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread rmudgett
? if !swap swap_control = stasis_app_control_find_by_channel(swap-chan) - rmudgett On Jan. 28, 2015, 11:01 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread rmudgett
://reviewboard.asterisk.org/r/4382/#comment24860 The channel cannot be pushed. - rmudgett On Jan. 28, 2015, 1:35 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread rmudgett
/4374/#comment24864 I'm surprised that the compiler didn't complain about http_header_data being const because it is passed to ast_http_send() and ast_free() which takes a non-const parameter. - rmudgett On Jan. 28, 2015, 5:15 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread rmudgett
://reviewboard.asterisk.org/r/4382/#comment24848 Create a new typedef for the new callback. Also the new callback doesn't need the swap parameter since that pointer is passed in with the bridge_channel parameter struct. - rmudgett On Jan. 27, 2015, 8:55 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread rmudgett
are not much and the function is small. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/#review14340 --- On Jan. 27, 2015

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread rmudgett
On Jan. 27, 2015, 7:48 p.m., rmudgett wrote: ./branches/13/main/http.c, line 639 https://reviewboard.asterisk.org/r/4374/diff/1-2/?file=71085#file71085line639 What you had before was better: char *status_title = Unauthorized; char status_title[16] always reserves

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-28 Thread rmudgett
On Jan. 27, 2015, 7:51 p.m., rmudgett wrote: ./branches/13/main/http.c, line 384 https://reviewboard.asterisk.org/r/4374/diff/2/?file=71124#file71124line384 Does this need to be skipped if http_server_name is empty? Ashley Sanders wrote: I think in the case of the status

[asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

2015-01-27 Thread rmudgett
there should have been an object displayed. With the patch it no longer fails to load. The test_config, test_sorcery, and test_sorcery_astdb unit tests still pass. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-27 Thread rmudgett
/4374/#comment24828 Does this need to be skipped if http_server_name is empty? - rmudgett On Jan. 27, 2015, 6:16 p.m., Ashley Sanders wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-27 Thread rmudgett
/#comment24827 This seems kind of small for the amount that could be put in here. May want to switch to using an ast_str for this and use ast_str_set_va() instead of the snprintf() when filling the string. - rmudgett On Jan. 27, 2015, 6:16 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread rmudgett
member list at inappropriate times? - rmudgett On Jan. 27, 2015, 6:06 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378/#review14316 --- Ship it! I'm fine with the bridge core change. - rmudgett

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread rmudgett
On Jan. 27, 2015, 9:57 a.m., rmudgett wrote: /branches/13/main/bridge_channel.c, lines 1998-2001 https://reviewboard.asterisk.org/r/4378/diff/1/?file=71097#file71097line1998 The reason a swap channel is pulled after the new channel is pushed is because pulling the last channel

Re: [asterisk-dev] [Code Review] 4369: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v13 version)

2015-01-27 Thread rmudgett
no longer has the CBRec channel left in the CLI core show channels output. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

2015-01-27 Thread rmudgett
://reviewboard.asterisk.org/r/4368/diff/ Testing --- With the test: The confbridge testsuite tests still pass. Manual testing no longer has the recording channel ref leak. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

2015-01-27 Thread rmudgett
show registrations frequently showed an empty list when there should have been an object displayed. With the patch it no longer fails to load. The test_config, test_sorcery, and test_sorcery_astdb unit tests still pass. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

2015-01-27 Thread rmudgett
? The comma is there so if another member is initialized the comma doesn't need to be added later. It is common practice in Asterisk. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

2015-01-27 Thread rmudgett
. The instance observer I added only works with an internal container to the outgoing registrations so it isn't critical for that to be complete before the type observers run. I'll rework the descriptions. - rmudgett --- This is an automatically

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-27 Thread rmudgett
/4382/#comment24829 13.2.0 /branches/13/res/stasis/stasis_bridge.c https://reviewboard.asterisk.org/r/4382/#comment24833 13.2.0 /branches/13/res/stasis/stasis_bridge.c https://reviewboard.asterisk.org/r/4382/#comment24834 not used - rmudgett On Jan. 27, 2015, 8:11 p.m

Re: [asterisk-dev] [Code Review] 4381: res_pjsip_outbound_registration: Fix reload race condition.

2015-01-27 Thread rmudgett
showed an empty list when there should have been an object displayed. With the patch it no longer fails to load. The test_config, test_sorcery, and test_sorcery_astdb unit tests still pass. Thanks, rmudgett -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, line 2155 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line2155 Setting a blank string will really mean a blank servername output value: Server: Is it intended

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 4:55 p.m., Scott Griepentrog wrote: /branches/13/apps/confbridge/conf_config_parser.c, line 2304 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71080#file71080line2304 Use ast_copy_string? rmudgett wrote: I second this should be ast_copy_string

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/#review14300 --- Ship it! Minor nit about the /* Safe */ comment. - rmudgett

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, lines 567-568 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line567 Why are the allocation sizes passed in? Ashley Sanders wrote: To account for this handling the error and auth

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
to the default Asterisk/version? An alternate method is to check the set value at the end of the function for an empty string and set the global value to Asterisk/version. - rmudgett On Jan. 26, 2015, 2:03 p.m., Ashley Sanders wrote

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
://reviewboard.asterisk.org/r/4372/#comment24780 This really should be a define instead of a magic number. Hmm... The bridge profile name is also set at 64. - rmudgett On Jan. 26, 2015, 10:28 a.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 4:55 p.m., Scott Griepentrog wrote: /branches/13/apps/confbridge/conf_config_parser.c, line 2304 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71080#file71080line2304 Use ast_copy_string? I second this should be ast_copy_string() for safety. - rmudgett

Re: [asterisk-dev] [Code Review] 4351: ARI: improve wiki documentation

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4351/#review14294 --- Ship it! Ship It! - rmudgett On Jan. 17, 2015, 11:28 a.m

Re: [asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

2015-01-23 Thread rmudgett
. Manual testing no longer has the recording channel ref leak. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

[asterisk-dev] [Code Review] 4369: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v13 version)

2015-01-23 Thread rmudgett
--- With the test: The confbridge testsuite tests still pass. Manual testing no longer has the recording channel ref leak. The v13 version of the patch no longer has the CBRec channel left in the CLI core show channels output. Thanks, rmudgett

[asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel.

2015-01-23 Thread rmudgett
/confbridge.h 431048 /branches/11/apps/app_confbridge.c 431049 Diff: https://reviewboard.asterisk.org/r/4368/diff/ Testing --- With the test: The confbridge testsuite tests still pass. Manual testing no longer has the recording channel ref leak. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

2015-01-23 Thread rmudgett
/ Testing --- With the test: The confbridge testsuite tests still pass. Manual testing no longer has the recording channel ref leak. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4366: res_pjsip_outbound_registration.c: Minor code cleanup.

2015-01-22 Thread rmudgett
() handle partially created state objects from sip_outbound_registration_state_alloc(). Diffs - /branches/13/res/res_pjsip_outbound_registration.c 430903 Diff: https://reviewboard.asterisk.org/r/4366/diff/ Testing --- Code inspection and it compiles. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-22 Thread rmudgett
/bridge_channel_internal.h 430836 /branches/13/include/asterisk/bridge.h 430836 Diff: https://reviewboard.asterisk.org/r/4354/diff/ Testing --- The testsutite masquerade super test and the --tags=transfer tests still pass. Thanks, rmudgett

Re: [asterisk-dev] [Code Review] 4095: Add a prompt to be read to the winner when a call is connected through app_followme

2015-01-22 Thread rmudgett
://reviewboard.asterisk.org/r/4095/#comment24753 Change to: connecting_prompt= ;connecting_prompt=tt-weasels ; The sound file name for 'Please say hello to the caller' message. Default is the global default. - rmudgett On Jan. 21, 2015, 6:23 p.m., Graham Mainwaring wrote

Re: [asterisk-dev] [Code Review] 4095: Add a prompt to be read to the winner when a call is connected through app_followme

2015-01-21 Thread rmudgett
/4095/#comment24739 It would be safer if the prompt wasn't played if the string is empty. This way you don't need a silence/0 default sound file. if (!ast_strlen_zero(targs-conprompt) { /* Play connecting message to the winner. */ ast_stream_and_wait() } - rmudgett

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-21 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4341/#review14259 --- Ship it! Ship It! - rmudgett On Jan. 20, 2015, 6:07 p.m

Re: [asterisk-dev] [Code Review] 4363: res_pjsip: make it unloadable (take 2)

2015-01-21 Thread rmudgett
I saw with the previous patch. - rmudgett On Jan. 21, 2015, 10:30 a.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4363

[asterisk-dev] [Code Review] 4366: res_pjsip_outbound_registration.c: Minor code cleanup.

2015-01-21 Thread rmudgett
/res_pjsip_outbound_registration.c 430903 Diff: https://reviewboard.asterisk.org/r/4366/diff/ Testing --- Code inspection and it compiles. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 4342: CHANNEL(peer), chan_iax2, res_fax, SNMP agent: Fix deadlock from reaching across a bridge.

2015-01-20 Thread rmudgett
430688 /branches/13/UPGRADE.txt 430688 Diff: https://reviewboard.asterisk.org/r/4342/diff/ Testing --- Testsuite tests still pass for FAX. The full testsuite didn't hit any deadlock. Thanks, rmudgett -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-20 Thread rmudgett
On Jan. 19, 2015, 6:56 p.m., rmudgett wrote: cleanup_all_regs() should just be the ao2_callback() line and the original guts should be put into a cleanup_registration() ao2_callback function. Matt Jordan wrote: I'm not sure I understand your comment. cleanup_all_regs is being

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-20 Thread rmudgett
, which could occur when the channel was released from the bridge. If I'm wrong, feel free to disregard :-) rmudgett wrote: If bridge_channel-swap is non-NULL here then the join really did fail and the unref is logged to REF_DEBUG as a result of join failure. If it is NULL

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread rmudgett
://reviewboard.asterisk.org/r/4347/#comment24710 Simply deleting these lines will accomplish the same thing. - rmudgett On Jan. 20, 2015, 2:05 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-20 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4347/#review14249 --- Ship it! Ship It! - rmudgett On Jan. 20, 2015, 2:37 p.m

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-20 Thread rmudgett
/include/asterisk/bridge.h 430836 Diff: https://reviewboard.asterisk.org/r/4354/diff/ Testing --- The testsutite masquerade super test and the --tags=transfer tests still pass. Thanks, rmudgett -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-19 Thread rmudgett
if the channel successfully joined. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4354/#review14233 --- On Jan. 19, 2015

Re: [asterisk-dev] [Code Review] 4355: chan_sip: Fix leak of SIP registrations

2015-01-19 Thread rmudgett
(). As it is you are passing the string as the arg pointer to cleanup_all_regs(). /branches/13/channels/chan_sip.c https://reviewboard.asterisk.org/r/4355/#comment24703 Idem - rmudgett On Jan. 19, 2015, 4:34 p.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 4347: Investigate and fix memory leaks in Asterisk

2015-01-19 Thread rmudgett
the jason_variables. Either that or the semantics of this function needs to change so that the ref is passed to this function. - rmudgett On Jan. 15, 2015, 1:15 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4336: app_dial: Don't publish DialEnd events twice if GOSUB_RESULT or MACRO_RESULT return an unexpected value

2015-01-19 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4336/#review14229 --- Ship it! Ship It! - rmudgett On Jan. 16, 2015, 9:03 p.m

Re: [asterisk-dev] [Code Review] 4351: ARI: improve wiki documentation

2015-01-19 Thread rmudgett
/bridges.json https://reviewboard.asterisk.org/r/4351/#comment24691 Ah. This is the place where the long comment block paragraph needs to be wrapped. Either that or the mustache template processor needs to learn to wrap long lines. - rmudgett On Jan. 17, 2015, 11:28 a.m., Matt Jordan wrote

[asterisk-dev] [Code Review] 4354: Bridge core: Pass a ref with the swap channel when joining a bridge.

2015-01-19 Thread rmudgett
--- The testsutite masquerade super test and the --tags=transfer tests still pass. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-16 Thread rmudgett
/stasis_bridge.c https://reviewboard.asterisk.org/r/4341/#comment24674 May need to add this call here to ensure that the swap channel leaves the bridge: ast_bridge_channel_leave_bridge(swap, BRIDGE_CHANNEL_STATE_END_NO_DISSOLVE, 0); Have to test to see if it is needed. - rmudgett

Re: [asterisk-dev] [Code Review] 4342: CHANNEL(peer), chan_iax2, res_fax, SNMP agent: Fix deadlock from reaching across a bridge.

2015-01-15 Thread rmudgett
was relatively expensive for every frame. - rmudgett --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4342/#review14200 --- On Jan

<    1   2   3   4   5   6   7   8   9   >